Commit Graph

25209 Commits

Author SHA1 Message Date
Ronnie Sahlberg 88d3b24a4e add initial dnsserver dcerpc implementation
svn path=/trunk/; revision=25943
2008-08-06 06:53:37 +00:00
Anders Broman d261400dea From Gary Reynolds:
Extended the cldap desector to include all the current netlogon response data
types.  

Expanded the cldap netlogon ntver option to be a bit mask of the search flags

Updated the DS flags fields to include Windows 2008 options.

svn path=/trunk/; revision=25942
2008-08-06 06:53:04 +00:00
Ronnie Sahlberg e0e1c45922 in nfs name to filehandle mappings
when we check and ignore the two names "." and ".."
we must do so for both methods a caller can provide the name :
offset into a tvb, as well as a char* to a string.

also add ->full_name in the dissection to the replies  so that fh 
matches
both request and reply and not ->name



svn path=/trunk/; revision=25941
2008-08-06 06:45:44 +00:00
Luis Ontanon a4412aa3c1 Make the buttons of the UAT dialog usable again, and get rid of some gtk warnings.
svn path=/trunk/; revision=25940
2008-08-06 00:43:01 +00:00
Gerald Combs 5e1a101afd Add a missing </para>.
svn path=/trunk/; revision=25939
2008-08-05 23:08:16 +00:00
Guy Harris 71a607d7e7 Fix some errors introduced when fixing Luis Ontanon's e-mail address.
svn path=/trunk/; revision=25938
2008-08-05 21:31:17 +00:00
Luis Ontanon 42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Luis Ontanon 99331d7b99 Remove obsolete "example_snmp_users_file"
svn path=/trunk/; revision=25936
2008-08-05 20:39:31 +00:00
Jeff Morriss c1736aec4e (Temporary?) fix to get the Windows buildbot going again: remove constness from a couple of variables.
svn path=/trunk/; revision=25935
2008-08-05 20:38:22 +00:00
Anders Broman 45b2e37a27 FromVincent Helfre:
A patch for the PS handover XID parameters Information element, which uses the sndcp-xid dissector.

svn path=/trunk/; revision=25934
2008-08-05 18:49:02 +00:00
Jeff Morriss dd6a15e1c7 Don't put (non-extern'd) prototypes for protect_thread_critical_region() and
unprotect_thread_critical_region() in every module in gtk/: instead have those
modules include main.h (which has the properly extern'd prototype).

This should fix the link error on HP-UX described in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2702

svn path=/trunk/; revision=25933
2008-08-05 17:33:14 +00:00
Gerald Combs 10260fb76b Switch the default MSVC_VARIANT from MSVC6 to MSVC2008.
svn path=/trunk/; revision=25932
2008-08-05 17:02:30 +00:00
Gerald Combs 811724ce01 Add --settag and --checktag arguments to win32-setup.sh, which respectively
save and verify the current download tag. Add --settag and --checktag calls
to the process_libs target. (This should automatically notify everyone when
wireshark-win32-libs is updated, which I tend to forget to do.)

svn path=/trunk/; revision=25931
2008-08-05 17:00:34 +00:00
Jeff Morriss f695f6f531 There's no need to have _DEPENDENCIES variables (which have only a very limited
subset of the real dependencies as specified in the _LDADD variables) for
Wireshark, tshark, and the rest of the programs: by specifying the
_DEPENDENCIES variable we just prevent automake from doing its job and
automatically figuring out the dependencies for us.

This should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2765

svn path=/trunk/; revision=25930
2008-08-05 14:51:34 +00:00
Jeff Morriss a330eaa8dc From Daniel Krueger:
The attached patch fixes a bug in the dissection of the StatusResponse,
where device-specific error code is only 6 Bytes long instead of 8 Bytes.

Additionally, I changed the spelling (i.e. the case) of "Ethernet
POWERLINK" to the new preferred one of the EPSG.

svn path=/trunk/; revision=25929
2008-08-05 13:59:27 +00:00
Luis Ontanon 10aa072565 Have some UAT helper functions copying the passed buffer before
freeing the contained buffer ( The client might have passed the
contained buffer to avoid read-after-free )


svn path=/trunk/; revision=25928
2008-08-05 11:16:24 +00:00
Luis Ontanon 230d917776 Add a debug helper for EP memory corruption
if compiled in and the env var WIRESHARK_DEBUG_EP_CANARY is set:
will check for canary integrity at every call to EP_CHECK_CANARY()
if corruption is found it exits pronting the prior location and the location in which corruption was found.
Hopefully it stops running while the corruptor is still in the stack.

see EP_CHECK_CANARY() calls in packet.c as an example.




svn path=/trunk/; revision=25927
2008-08-05 02:23:35 +00:00
Bill Meier 6916eaf587 Keep the OSX compiler happy: initialize a variable (altho not really req'd)
svn path=/trunk/; revision=25926
2008-08-04 23:58:03 +00:00
Bill Meier af00f796a0 Another temporary fix to prevent a build error
svn path=/trunk/; revision=25925
2008-08-04 23:50:11 +00:00
Luis Ontanon fd2c4d0f83 if it's se allocated it needs to be filled only once.
svn path=/trunk/; revision=25924
2008-08-04 23:25:07 +00:00
Luis Ontanon 0177061bff Fix an ep memory corruption due to passing ep blocks into a se allocated structure.
far away from UAT...


svn path=/trunk/; revision=25923
2008-08-04 23:15:54 +00:00
Bill Meier 9ef15c9aa4 temp fix (until the proper fix) to handle buildbot errs;
svn path=/trunk/; revision=25922
2008-08-04 23:15:51 +00:00
Gerald Combs 7d8e29f501 From Pascal Quantin via bug 2719: Fix support for Microsoft Visual C++ 2008.
From me:

Instead of adding adns_config.h, place it a custom adns package in
wireshark-win32-libs. Update tools/win32-setup.sh accordingly.

Split the MSVC2008EE variant into MSVC2008 and MSVC2008EE, similar to
MSVC2005 and MSVC2005EE. We have to worry about vcredist_x86.exe in
both cases.

Add Pascal to AUTHORS.

Update the Developer's Guide.

svn path=/trunk/; revision=25921
2008-08-04 23:05:32 +00:00
Anders Broman da85c3dfab From Alexey Neyman :
This patch implements a function for dissecting bitfields with better control
over the resulting representation than the existing proto_tree_add_bitmask()
routine. This function will be used by reworked IPMI/ATCA dissector (bug 2048).

The function is described in README.developer. In short, the differences are as
follows:

- The new function does not require a hf_XXX field for the whole bitmask. When
the bitmask includes several unrelated fields, such hf_XXX field does not make
sense.

- The new function allows better control over the way the sub-item descriptions
are added to the top-level item. For example, proto_tree_add_bitmask() function
does not add non-enumerated integers, does not use true_false_string to display
boolean.

- The new function allows to specify "fallback" text for the top-level item
which is used if no items were added to the top-level item.

svn path=/trunk/; revision=25920
2008-08-04 20:41:43 +00:00
Anders Broman 774f288597 Give Vincent Helfre and Magnus Sörman credit.
svn path=/trunk/; revision=25919
2008-08-04 20:21:41 +00:00
Anders Broman 5cbe7f0f17 Fix packet-gsm_a_common.c:63: warning: assignment makes integer from pointer without a cast.
Assuming the default shouldn't occure and fix a copy past error.

svn path=/trunk/; revision=25918
2008-08-04 20:17:34 +00:00
Anders Broman 082a5aec04 From Neil Piercy:
All I've done in these is to split the 3 obviously distinct protocols (BSSMAP & RP) from the still-large (and wrongly-named) DTAP (really the whole of layer 3 - it includes RR and packet parts too).

So far I've only split in a "minimum change" manner - there is clearly some tidying and structure enhancement of how the common bits are used, removing the globals just added, and great scope for consistency of white space, improved naming etc. - but I thought it best to keep it very close to the original initially to establish the split.

With some changes to make it compile on Windows.

svn path=/trunk/; revision=25917
2008-08-04 19:44:03 +00:00
Martin Mathieson ad16b7b403 Declare next_tvb volatile. This prevents the warning:
packet-infiniband.c:806: warning: variable 'next_tvb' might be clobbered by `longjmp' or `vfork'

seen with gcc 3.4.6 (building for 32-bits on a pentium 4).

svn path=/trunk/; revision=25916
2008-08-04 16:36:16 +00:00
Anders Broman 96aa45646d First step to split the gsm_a dissector into several smaller ones ( done by Neil Piercy)
rename the "old" one to gsm_a_common.

svn path=/trunk/; revision=25915
2008-08-04 16:11:17 +00:00
Bill Meier f4a7b39753 Print various uints with %u ...
svn path=/trunk/; revision=25914
2008-08-04 03:46:49 +00:00
Bill Meier 8f84b18945 Fix 2 bugs:
- Misplaced } resulted in incorrect program flow in switch statement;
- Invalid input caused "Dissector bug: infinite loop";

svn path=/trunk/; revision=25913
2008-08-04 02:56:47 +00:00
Bill Meier be04142585 Fix buildbot error: "no newline at end of file"
svn path=/trunk/; revision=25912
2008-08-04 02:31:35 +00:00
Bill Meier 1fc904c6be Adjust various indentation/spacing; Do some minor reformatting
svn path=/trunk/; revision=25911
2008-08-04 02:27:20 +00:00
Anders Broman d8c21bbe38 Revert previous checkin.
svn path=/trunk/; revision=25910
2008-08-03 16:11:23 +00:00
Anders Broman 86e0bde995 packet-multipart.c:179: warning: unused parameter 'pinfo'
packet-multipart.c:179: warning: unused parameter 'name'
( restore a bit of previous code)
Move inclusion of tvbuff.h to base64.c

svn path=/trunk/; revision=25909
2008-08-03 15:44:26 +00:00
Anders Broman 2b9d63a4b5 Move common code to base64.c
svn path=/trunk/; revision=25908
2008-08-03 14:27:22 +00:00
Guy Harris ea4fbda062 Don't fetch data until you need it.
svn path=/trunk/; revision=25907
2008-08-02 21:59:33 +00:00
Anders Broman 38ac851958 Fix packet-netflow.c:2666: warning: 'pen' may be used uninitialized in this function
and remove some C++ comments - some compilers don't allow them (at least not by default).

svn path=/trunk/; revision=25906
2008-08-02 16:13:40 +00:00
Anders Broman 7be2278d3c From Hitoshi Irino:
This patch
(1) fixes to decode IPFIX packets.
The revision 25601 warns and be not able to decodes IPFIX packets fully,
because the array "hf_register_info" does not have an entry
"hf_cflow_datarecord_length", and a length check for IPFIX packets is incorrect
in "dissect_netflow" function.
(2) is able to decode all Information Elements standardized by RFC 5102
(3) is able to decode IPFIX templates and data that contains PEN (Private
Enterprise Number) fields standardized by RFC 5101, and is able to decode
bi-directional flow standardized by RFC 5103.

svn path=/trunk/; revision=25905
2008-08-02 13:53:49 +00:00
Anders Broman 449e40f6b1 From Abhik Sarkar:
Some buttons are always disabled in the "User DLTs Table" dialog.

svn path=/trunk/; revision=25904
2008-08-02 13:47:31 +00:00
Bill Meier c90024fe80 WIN32 ==> _WIN32
svn path=/trunk/; revision=25903
2008-08-02 12:20:38 +00:00
Anders Broman bb54e0bb03 From metatech:
- In DRDA the data is of different "nature" : EBCDIC vs ASCII, so I think they
deserve different field names.

svn path=/trunk/; revision=25902
2008-08-01 18:17:23 +00:00
Jaap Keuter 18b69aef03 Really start printing in 8 pnt Courier, not just state so in the template.
Add Wireshark version info to the page header.

svn path=/trunk/; revision=25901
2008-08-01 17:36:09 +00:00
Jaap Keuter 2db97aed2c Several improvements to the PostScript code:
- Remove old code and comments.
- Add 5 pnt between last lines baseline and lower horizontal line to avoid having the last line sitting right on top of the horizontal line
- Fix pagewidth expression (although outcome is the same)
- Add page decorations for single page print as well
- Add DSC end of file marker

svn path=/trunk/; revision=25900
2008-08-01 17:34:36 +00:00
Stig Bjørlykke 341fba51c5 Remove a few warnings.
svn path=/trunk/; revision=25899
2008-08-01 16:49:12 +00:00
Stig Bjørlykke 2f2a8edbd7 Regenerated to use the new decode function for UTCTime.
svn path=/trunk/; revision=25898
2008-08-01 16:45:30 +00:00
Stig Bjørlykke d255e44bfa From Martin Peylo (bug 2507):
The attached patch enables asn2wrs.py and packet-ber.c to decode UTCTime
according to the definitions in X.680.

svn path=/trunk/; revision=25897
2008-08-01 16:44:06 +00:00
Anders Broman 1fa1d7736e packet-turnchannel.c:219: warning: passing argument 2 of 'register_dissector' from incompatible pointer type
A dissector returning int should return the length consumed of the tvb and be
registered with new_register_dissector();

svn path=/trunk/; revision=25896
2008-08-01 15:45:29 +00:00
Anders Broman 47aca4c30f From stéphane bryant:
STUN, STUN2 and TURN dissection enhancements.

svn path=/trunk/; revision=25895
2008-08-01 15:11:06 +00:00
Stig Bjørlykke 94d4e2c70a boolean -> gboolean
svn path=/trunk/; revision=25894
2008-08-01 14:26:48 +00:00