Commit Graph

25209 Commits

Author SHA1 Message Date
Anders Broman b3e93c1391 Fix typo(s)
svn path=/trunk/; revision=25842
2008-07-26 22:38:53 +00:00
Anders Broman 2894d5c550 Fix unused code warings generated because some IE:s uses the same "value" for different
IE:s depending on message type.
(Thanks to Tomas Kukosa for helping to solve the problem).

svn path=/trunk/; revision=25841
2008-07-26 22:22:08 +00:00
Tomas Kukosa 7d1c30c417 Get rid of next few warnings (dissect_per_choice needs signed value parameter)
svn path=/trunk/; revision=25840
2008-07-26 19:07:04 +00:00
Tomas Kukosa 1644e4138a Get rid of few warnings (unused generated code, signed/unsigned mismatch)
svn path=/trunk/; revision=25839
2008-07-26 15:28:04 +00:00
Tomas Kukosa 4ac15ee6d4 Update Ply to version 2.5
svn path=/trunk/; revision=25838
2008-07-26 15:26:09 +00:00
Jeff Morriss 31d0fb16d7 From Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2637 : Make the RANAP SSN configurable.
svn path=/trunk/; revision=25837
2008-07-26 02:04:19 +00:00
Guy Harris 5b836ec674 Fix typos, clean up a message.
svn path=/trunk/; revision=25835
2008-07-25 23:34:15 +00:00
Anders Broman 8db1e7a8b2 From David Aggeler:
Follow-up from SVN 25825 check in

The g_slist_free() is really needed in export_object.c, otherwise, the export
list has false (repetitive) entries in it, that cause a crash when selecting
them.

Whether false entries are in the list, only depends on the speed of the export
processing, since this tap is 

Replaced all guchar with gchar. This should eliminate the warnings on solaris. 
I guess I used the wrong reference.

Added patch for 'Authors' in case I need to add myself to the list.

svn path=/trunk/; revision=25834
2008-07-25 22:58:05 +00:00
Gerald Combs cb3022d098 If we can't open open an interface in Windows, instead of talking about
specific issues (one of which no longer applies), point the user at the 
wiki.

svn path=/trunk/; revision=25833
2008-07-25 22:29:02 +00:00
Jeff Morriss 09407457f3 Set svn:keyword Id.
svn path=/trunk/; revision=25832
2008-07-25 21:03:14 +00:00
Gerald Combs 2f5f9ae606 Remove dead code found in Coverity CID 271.
svn path=/trunk/; revision=25831
2008-07-25 18:51:44 +00:00
Jeff Morriss 9bacbeceb5 static variable declarations don't belong in header files
svn path=/trunk/; revision=25830
2008-07-25 15:42:46 +00:00
Jeff Morriss 4e19755680 Remove an unused variable and cast a string constant into a guchar. Also add newline at the end of the file.
svn path=/trunk/; revision=25829
2008-07-25 15:06:52 +00:00
Martin Mathieson d9f8023b63 Add a newline to the end of the file.
Still seeing these errors...

packet-dcm.c: In function `dcm_uid_or_desc':
packet-dcm.c:960: warning: pointer type mismatch in conditional expression
packet-dcm.c: At top level:
packet-dcm.c:229: warning: 'dcm_desegment_headers' defined but not used


svn path=/trunk/; revision=25828
2008-07-25 15:00:16 +00:00
Anders Broman 72c2f913e5 Try to fix some of the warnings.
svn path=/trunk/; revision=25827
2008-07-25 14:54:12 +00:00
Anders Broman 6dd20d987d Try to fix some of the warnings.
svn path=/trunk/; revision=25826
2008-07-25 14:19:36 +00:00
Anders Broman b7f89ecec1 From David Aggeler:
Patch to enable DICOM Export

svn path=/trunk/; revision=25825
2008-07-25 13:45:31 +00:00
Anders Broman e9a6106af5 From David Aggeler:
multiple PDV per PDU support
 - Support multiple PDVs per PDU
 - Better summary, in PDV, PDU header and in INFO Column, 
   e.g. show commands like C-STORE
 - Fixed Association Reject (was working before my changes)
 - Fixed PDV Continuation with very small packets. Reduced minimum packet
   length from 10 to 2 Bytes for PDU Type 4 
 - Fixed PDV Continuation. Last packet was not found correctly.
 - Fixed complilation warning (build 56 on solaris)
 - Fixed tree expansion (hf_dcm_xxx)
 - Added expert_add_info() for Assoctiation Reject
 - Added expert_add_info() for Assoctiation Abort
 - Added expert_add_info() for short PDVs (i.e. last fragment,
   but PDV is not completed yet)
 - Clarified and grouped data structures and its related code 
   (dcmItem, dcmState) to have consistent _new() & _get() functions 
   and to be be according to coding conventions 
 - Added more function declaration to be more consistent
 - All dissect_dcm_xx now have (almost) the same parameter order
 - Removed DISSECTOR_ASSERT() for packet data errors.
   Not designed to handle this.
 - Handle multiple DICOM Associations in a capture correctly, 
   i.e. if presentation contexts are different.

svn path=/trunk/; revision=25824
2008-07-25 13:36:58 +00:00
Anders Broman 4a233c45a7 From David Aggeler:
DICOM dissector bugfixes and features

svn path=/trunk/; revision=25823
2008-07-25 13:20:18 +00:00
Anders Broman 7c12f0438a From Alex Turbov:
Incorrect size for 'SSI Entry' in SNAC(0x13, 0x06) packet
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2721

svn path=/trunk/; revision=25822
2008-07-25 12:44:55 +00:00
Gerald Combs 5c4af7d6be Use tvb_format_stringzpad instead of tvb_memcpy to fetch the SAP server name.
svn path=/trunk/; revision=25821
2008-07-24 16:46:09 +00:00
Jeff Morriss acd338f422 Remove the (long deprecated) proto_tree_add_*_hidden() functions
svn path=/trunk/; revision=25820
2008-07-24 15:35:29 +00:00
Anders Broman 1de4da8343 Get rid of unused code warnings.
svn path=/trunk/; revision=25819
2008-07-24 12:32:00 +00:00
Anders Broman 22de14d9bf Get rid of unused code warnings.
svn path=/trunk/; revision=25818
2008-07-24 12:26:59 +00:00
Anders Broman ece87c88fd Get rid of unused code warnings.
svn path=/trunk/; revision=25817
2008-07-24 10:58:23 +00:00
Martin Mathieson 7921dca80d Fix DLMAP UL_interference_and_noise_level_IE decode error (bug 2737).
From Frank Wang.

svn path=/trunk/; revision=25816
2008-07-24 08:53:14 +00:00
Martin Mathieson 9c34677453 Fix HARQ_ULMAP_IE decoder padding error (bug 2738).
From Frank Wang.

svn path=/trunk/; revision=25815
2008-07-24 08:46:13 +00:00
Tomas Kukosa edbcca785f Fix TCP desegmentation when minimal header spans multiple segments.
svn path=/trunk/; revision=25814
2008-07-24 06:33:23 +00:00
Anders Broman 44e2eccb03 Get rid of unused code warnings.
svn path=/trunk/; revision=25813
2008-07-24 00:44:00 +00:00
Anders Broman ff8291413a Get rid of unused code warnings.
svn path=/trunk/; revision=25812
2008-07-24 00:30:11 +00:00
Bill Meier a4d1eb9ee9 (Minor) Disable un-needed 'capture' in regexp
svn path=/trunk/; revision=25811
2008-07-23 23:15:07 +00:00
Bill Meier e86d6997c7 Fix double-quoted string regexp to match strings with "line continuation";
Enable value_string check again ....

svn path=/trunk/; revision=25810
2008-07-23 22:50:03 +00:00
Anders Broman 84bbe30340 Get rid of unused code warnings.
svn path=/trunk/; revision=25809
2008-07-23 21:55:56 +00:00
Jeff Morriss a5c48c4c6f Don't use proto_tree_add_string_hidden() any more: it's deprecated.
svn path=/trunk/; revision=25808
2008-07-23 21:04:48 +00:00
Jeff Morriss f97023f302 Don't use proto_tree_add_uint_hidden() any more: it's deprecated.
svn path=/trunk/; revision=25807
2008-07-23 20:35:28 +00:00
Jeff Morriss d5aff45ab8 Don't split a value_string's string across multiple lines.
svn path=/trunk/; revision=25806
2008-07-23 19:54:17 +00:00
Martin Mathieson 56455be25a This file predominantly uses spaces, so remove tabs that were making
indentation look wrong in my editor.


svn path=/trunk/; revision=25805
2008-07-23 14:32:24 +00:00
Anders Broman 89f82718ac Get rid of some unused code warnings.
svn path=/trunk/; revision=25804
2008-07-23 13:26:43 +00:00
Anders Broman 201b5205df Get rid of some unused code warnings and fix an Id marking and some indentation changes.
svn path=/trunk/; revision=25803
2008-07-23 12:45:24 +00:00
Bill Meier d35d95395a Disable value_string check for now.
Apparently the "regex which matches double-quoted strings"
doesn't work with some versions of Perl (eg: 5.8.8) if the
string contains a 'line-continuation' (\ folowed by a new-line).
(This works for Perl 5.10.0).
So: disable value_string check until I look into this further.

svn path=/trunk/; revision=25802
2008-07-23 11:36:27 +00:00
Martin Mathieson ee1534f851 Fix bug 2663 (DLMAP HAEQ_DLMAP_UE decode error).
From Frank Wang.

svn path=/trunk/; revision=25801
2008-07-23 11:18:33 +00:00
Bill Meier ac48c59340 Add test to check if value_string arrays are NULL terminated;
default: test is enabled.
Check for error return from GetOptions

svn path=/trunk/; revision=25800
2008-07-22 22:27:08 +00:00
Bill Meier e2e72c7664 Add NULL termination element to value_string arrays
svn path=/trunk/; revision=25799
2008-07-22 21:53:50 +00:00
Bill Meier 7631d2b494 Add NULL termination element to value_string array
svn path=/trunk/; revision=25798
2008-07-22 20:20:17 +00:00
Bill Meier 3b6cd83389 Add NULL termination element to value_string arrays;
Fix some indentation

svn path=/trunk/; revision=25797
2008-07-22 20:19:17 +00:00
Anders Broman ac5909c827 Get rid of some unused code warnings.
svn path=/trunk/; revision=25796
2008-07-22 18:55:49 +00:00
Bill Meier 3dd77dc972 Remove unnecessary comma from value_string initializer
svn path=/trunk/; revision=25795
2008-07-22 18:40:32 +00:00
Bill Meier 39b20c0081 Add NULL termination element to value_string arrays.
(Done for consistency although not strictly required in these cases);
(Also: so no kickouts on this file when doing automated checking
 for missing NULL termination elements in value-string arrays). 

svn path=/trunk/; revision=25794
2008-07-22 18:36:40 +00:00
Bill Meier 67559b7dfe Add NULL termination element to value_string arrays
svn path=/trunk/; revision=25793
2008-07-22 18:27:13 +00:00
Martin Mathieson 670f7b46f8 Add Bahaa Naamneh to AUTHORS.
svn path=/trunk/; revision=25792
2008-07-22 18:01:13 +00:00