ac335fc5f4
From Jacob Nordgren and Rishie Sharma:
...
Handle RRC_MESSAGE_TYPE_BCCH_FACH.
svn path=/trunk/; revision=43741
2012-07-16 07:02:29 +00:00
7deecbf36b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7479 :
...
Provide an empty string when data pointer is not NULL (regression introduced in r43703)
svn path=/trunk/; revision=43724
2012-07-15 15:26:57 +00:00
e173f01c5c
Be sure to assign the return value of tvb_length_remaining() to a signed integer and not an unsigned integer, and then check that value is > 0.
...
svn path=/trunk/; revision=43720
2012-07-15 14:31:40 +00:00
0d41b6edad
tvb_length_remaining() can return -1, so check that it's > 0, and not != 0. If tvb_length_remaining() is > 0, then tvb_reported_length_remaining() should also be > 0, so I don't think there's a need for further checks there.
...
svn path=/trunk/; revision=43719
2012-07-15 14:29:06 +00:00
1ff8c1fcba
Don't pass the return value of tvb_length_remaining() to fragment_add_check(), as it might have been -1.
...
Fixes Coverity CID 280510: Improper use of negative value.
svn path=/trunk/; revision=43716
2012-07-14 19:52:18 +00:00
590cec6962
tvb_length_remaining() can return -1, so be sure to deal with it if it does. Should fix a bunch of Coverity CID's.
...
svn path=/trunk/; revision=43715
2012-07-14 19:28:40 +00:00
adfe9d3ced
Fix a few 'value stored is never read' warnings and a typo error
...
svn path=/trunk/; revision=43714
2012-07-14 18:54:32 +00:00
d6959d2715
As suggested by Richard Sharpe in http://www.wireshark.org/lists/wireshark-dev/201207/msg00111.html :
...
Make the NTLMSSP Unknown message type string more explicit
svn path=/trunk/; revision=43713
2012-07-14 18:31:08 +00:00
a4ec2596bc
If the offset is out of range, just assign to len to 0 so we don't end up passing a huge value to fragment_add().
...
Fixes Coverity CID 280246: Improper use of negative value.
svn path=/trunk/; revision=43712
2012-07-14 16:29:45 +00:00
a14d130713
Add support for SCSI SBC ORWRITE command
...
svn path=/trunk/; revision=43711
2012-07-14 08:00:03 +00:00
285ee0f9b5
Add support for SCSI SBC COMPARE_AND_WRITE opcode
...
svn path=/trunk/; revision=43709
2012-07-14 02:19:32 +00:00
33b0d13dec
tvb_length_remaining() can return -1, so be sure to deal with it if it does.
...
svn path=/trunk/; revision=43708
2012-07-13 22:20:09 +00:00
7320ebcfd9
Various minor cleanup, including:
...
- remove unneeded #includes;
- remove some unneeded initializers;
- use tvb_reported_length() instead of tvb_length();
- use val_to_str_const() instead of val_to_str();
- fix some typos;
- do some whitespace changes and some reformatting.
svn path=/trunk/; revision=43707
2012-07-13 22:06:40 +00:00
b1eb22bd51
Minor cleanup;
...
- Remove unneeded #includes;
- Create/use value_string_ext for some value_string arrays;
- Do some whitespace changes and reformat some lines.
svn path=/trunk/; revision=43706
2012-07-13 21:59:25 +00:00
5e12ba51e6
If there's not enough data left for a timestamp, be sure there's at least some data to pass off to the generic data dissector.
...
svn path=/trunk/; revision=43705
2012-07-13 21:58:58 +00:00
a099ae38f5
tvb_length_remaining() can return -1, so be sure to deal with it if it does.
...
svn path=/trunk/; revision=43704
2012-07-13 21:46:27 +00:00
472db7609c
tvb_length_remaining() can return -1, so be sure to deal with it if it does.
...
svn path=/trunk/; revision=43703
2012-07-13 21:43:46 +00:00
ad3c388b4b
tvb_length_remaining() can return -1, so check if its return value is <= 0 when aborting and not just == 0.
...
svn path=/trunk/; revision=43702
2012-07-13 21:32:15 +00:00
ba376235da
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7474 :
...
Dissect LTE RADIUS AVP 3GPP-User-Location-Info
svn path=/trunk/; revision=43700
2012-07-13 21:18:35 +00:00
f8d42e6f61
tvb_length_remaining() can return -1, so don't assign its return value to an unsigned integer and don't check it against non-zero but greater than zero.
...
svn path=/trunk/; revision=43699
2012-07-13 21:14:43 +00:00
a592bd657c
tvb_length_remaining() can return -1, so don't assign its return value to an unsigned integer. Fixes Coverity CID 281367: Improper use of negative value.
...
svn path=/trunk/; revision=43698
2012-07-13 21:03:54 +00:00
7e3019c186
tvb_length_remaining() can return -1, so don't assign its return value to an unsigned integer. Fixes Coverity CID's 280233 and 280234.
...
svn path=/trunk/; revision=43696
2012-07-13 20:43:55 +00:00
ed47e7bae4
Remove unused filters found by checkhf.pl
...
svn path=/trunk/; revision=43693
2012-07-13 17:16:28 +00:00
e31dfd95ea
From Harald Welte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7476 :
...
UMA dissector incorrectly passes MAC addresses to wireshark core
svn path=/trunk/; revision=43692
2012-07-13 17:04:43 +00:00
30e481a804
Update dissector to match asn1/pkcs1 sources.
...
svn path=/trunk/; revision=43690
2012-07-13 12:34:36 +00:00
e6818f164e
Fix incorrect(duplicate) value in artnet_oem_code_vals[] value string array;
...
{ 0x0ae0, "chainzone:RoundTable:0 DMX Inputs,
...
- { 0x0ae0, "STC Mecatronica:DDR 2404 Digital Dimmer Rack:...
+ { 0x0b00, "STC Mecatronica:DDR 2404 Digital Dimmer Rack:...
Correct value obtained from Bug #7407 attachment #8684 :
"Art-Net OEM manufacturer codes for 1.4be specification"
https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8684
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407
(Issue noticed because value_string_ext search was 'linear' for this array).
svn path=/trunk/; revision=43689
2012-07-13 04:52:40 +00:00
99bd7cfe44
Add a preference to that when the window scaling options are not
...
visible, we can still configure a scaling factor and therefore get
better TCP sequence analysis and see better stream graphs.
A single preference is used for any/all streams for which the true value
isn't known. I tried to make it obvious when showing the calculated
window size that it came fromt he preference setting. The default value
for this preference is off, i.e. it won't change existing behaviour.
This was discussed a little at Sharkfest and raised on the developers
list last week.
svn path=/trunk/; revision=43686
2012-07-12 23:57:51 +00:00
5150511879
Do expert "telegrams lost" only of field is > 0;
...
Don't call expert...() under 'if (tree)'
svn path=/trunk/; revision=43683
2012-07-12 20:08:34 +00:00
d5b965176a
Don't call subdissector / expert...() under 'if (tree)'
...
Reformat hf[] entries.
svn path=/trunk/; revision=43682
2012-07-12 19:36:35 +00:00
859affc2bd
Don't call subdissectors / expert...() / col...() under 'if (tree)'
...
Also:
Remove some uneeded initializers;
Do some whitespace cleanup and re-formatting.
svn path=/trunk/; revision=43681
2012-07-12 17:22:47 +00:00
409cdcc5ed
Speed up reading of out-header values, and add a couple of 'monitor'
...
fields.
svn path=/trunk/; revision=43678
2012-07-12 01:26:08 +00:00
220958548c
Fix compile error.
...
svn path=/trunk/; revision=43674
2012-07-11 20:52:52 +00:00
26fd1cf862
Add some initializers to prevent some not really valid compiler warnings.
...
svn path=/trunk/; revision=43673
2012-07-11 20:49:35 +00:00
38e9ae2805
Don't call col_...() and expert...() functions under 'if (tree)'
...
svn path=/trunk/; revision=43672
2012-07-11 20:44:22 +00:00
ac7b2df9e8
Don't call col...() and expert..() functions under 'if (tree)';
...
Reformat hf[] entries and various other.
svn path=/trunk/; revision=43671
2012-07-11 20:40:13 +00:00
fad55cdecc
Remove unneeded #includes;
...
Rename header_fields[] tp hf[] as per convention;
Reformat hf[] entries;
Remove empty proto_reg_handoff...().
svn path=/trunk/; revision=43670
2012-07-11 20:31:47 +00:00
4248fa670a
Explicit value_string array size specifier not required.
...
svn path=/trunk/; revision=43669
2012-07-11 20:26:24 +00:00
9ee1981c7f
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7468 :
...
DVB-CI/CI+: fix offset error in operator_info apdu
svn path=/trunk/; revision=43668
2012-07-11 20:20:10 +00:00
e38f07f29a
Don't call expert_...() under 'if (tree)';
...
Prefs callback not needed.
svn path=/trunk/; revision=43667
2012-07-11 20:18:23 +00:00
59e9b969e9
Fix [-Werror=sign-compare] compiler warning
...
svn path=/trunk/; revision=43666
2012-07-11 18:43:30 +00:00
85504b052f
Simplify code ....
...
svn path=/trunk/; revision=43665
2012-07-11 18:32:20 +00:00
3b7e75852a
Remove "comment to myself".
...
svn path=/trunk/; revision=43664
2012-07-11 16:24:01 +00:00
0bace7313c
General cleanup:
...
- Fix potential array overflow;
- Calls to expert...() should not be under 'if (tree)';
- Don't use DISSECTOR_ASSERT for bad data; use expert...();
- Add some XXX comments about enum item values different than
specified in the comments associated with the enum items;
- Init global 'mfgCommandFlag' as appropriate before use;
- Add missing hf[] entries;
- #if 0 various unused #defines and enums;
- Reduce (somewhat) repeated fetches of the same tvb data;
- Remove unneeded initializers;
- Don't use 'l' as a variable name;
- Reformat long lines, hf[] array entries and other;;
- Fix some indentation;
svn path=/trunk/; revision=43663
2012-07-11 15:28:31 +00:00
62f645715a
failure cause is an OCTET STRING not a string.
...
svn path=/trunk/; revision=43662
2012-07-11 14:41:21 +00:00
6dfa10bc57
Revert part of revision 43107 which broke sub dissection of
...
Signal and events as a new tvb wasn't created.
|BASE_EXT_STRING also removed.
svn path=/trunk/; revision=43661
2012-07-11 14:40:35 +00:00
fb095f288f
From Ben Bowen:
...
Add additional named fields for IMAP.
svn path=/trunk/; revision=43651
2012-07-10 19:43:55 +00:00
1410207421
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7438 :
...
Do not call tvb_ensure_length_remaining on an empty tvb
svn path=/trunk/; revision=43648
2012-07-10 15:43:03 +00:00
8ecd85f1ad
Introduce a preference setting for application context version.
...
svn path=/trunk/; revision=43641
2012-07-10 11:39:06 +00:00
a0c58375be
Move LPP and LPPe dissectors to the ASN.1 dirty library
...
svn path=/trunk/; revision=43637
2012-07-10 07:19:40 +00:00
309e6646f7
Add LTE Positioning Protocol Extensions dissector
...
Upgrade LTE Positioning Protocol to V10.5.0
svn path=/trunk/; revision=43628
2012-07-09 20:55:09 +00:00
3dc1e2df63
Update AVP dissection.
...
svn path=/trunk/; revision=43625
2012-07-09 14:10:40 +00:00
eedc186e94
Dissect Release 8 CDR:s
...
svn path=/trunk/; revision=43624
2012-07-09 14:09:59 +00:00
3be39a23aa
From Evan Huus: Struct cleanup in packet-assa_r3.c
...
Cleanup and simplify structures and arrays in packet-assa_r3.c as described in
my email to the -dev list [1].
[1] http://www.wireshark.org/lists/wireshark-dev/201207/msg00050.html
From me:
Do the same as above for the commandDissectorParser_t struct mentioned in the EMail
(but not fixed in the patch).
svn path=/trunk/; revision=43623
2012-07-09 03:00:03 +00:00
f207987aa3
From Martin Kaiser:
...
DVB-CI/CI+: dissect the payload of LSC messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7440
svn path=/trunk/; revision=43620
2012-07-09 02:28:14 +00:00
1ae38887b6
From Evan Huus:
...
Grab-bag of unused variables.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7452
svn path=/trunk/; revision=43616
2012-07-09 01:49:02 +00:00
0cb874b9ec
Add a function to packet-giop.c that does what the code that
...
template_get_CDR_string (in wireshark_gen.py) did. This eliminates another
whole pile of function-local variables in packet-parlay.c.
Unfortunately it doesn't seem to speed up compilation (or eliminate the
variable tracking size limit problem). But it does eliminate a lot of
lines of code...
svn path=/trunk/; revision=43610
2012-07-08 03:57:35 +00:00
a2c4716670
Eliminate a lot of function-local variables by not storing the result of
...
(several of the) get_CDR_*() functions: instead call the function directly
in the proto_tree_add_text() calls.
Eliminate a lot of global variables that are only later used in (a single)
strcmp().
All the GIOP dissectors are built-in now; don't include the (#if'd out) plugin
registration code in the generated dissector.
Try to clean up the formatting of the generated code a bit.
Regenerate the IDL dissectors; as noted in r39932, this seems to involve a
lot of function re-ordering in packet-parlay.c (making the delta bigger).
These changes decrease the time to compile packet-parlay.c by, on my system,
about half. But it still complains:
variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
and it still takes "too long."
svn path=/trunk/; revision=43609
2012-07-08 03:29:49 +00:00
659cf0527a
UATs could be put into "categories". The categories were defined only
...
implicitly by the #define name and string they were defined to; not all
UATs neatly fit into any of the categories, so some of them were put
into categories that weren't obviously correct for them, and one - the
display filter macro UAT - wasn't put into any category at all (which
caused crashes when editing them, as the GUI code that handled UAT
changes from a dialog assumed the category field was non-null).
The category was, in practice, used only to decide, in the
aforementioned GUI code, whether the packet summary pane needed to be
updated or not. It also offered no option of "don't update the packet
summary pane *and* don't redissect anything", which is what would be
appropriate for the display filter macro UAT.
Replace the category with a set of fields indicating what the UAT
affects; we currently offer "dissection", which applies to most UATs
(any UAT in libwireshark presumably affects dissection at a minimum) and
"the set of named fields that exist". Changing any UAT that affects
dissection requires a redissection; changing any UAT that affects the
set of named fields that exist requires a redissection *and* rebuilding
the packet summary pane.
Perhaps we also need "filtering", so that if you change a display filter
macro, we re-filter, in case the display is currently filtered with a
display filter that uses a macro that changed.
svn path=/trunk/; revision=43603
2012-07-08 01:00:46 +00:00
9e7c7e7d10
From Evan Huus: Fix "Useless null checks in packet-dcerpc*"
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7448
svn path=/trunk/; revision=43599
2012-07-07 14:21:20 +00:00
9315a45deb
From Evan Huus: fix "Unused variable in packet-ansi_a.c"
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7447
svn path=/trunk/; revision=43598
2012-07-07 14:11:38 +00:00
dd105b80d8
Display (and allow filtering on) the "reserved for national use" bit in the AI.
...
(This bit is already decoded as the "national indicator" bit in ANSI.)
svn path=/trunk/; revision=43590
2012-07-06 21:25:47 +00:00
a898b392e2
Gadu-Gadu: dissect more packets.
...
svn path=/trunk/; revision=43589
2012-07-06 21:24:16 +00:00
41e5166f81
Add a few missing ENC_ASCII and remove a few unused hf entries
...
svn path=/trunk/; revision=43581
2012-07-06 05:33:55 +00:00
0bcc9b0e66
From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407 :
...
Update ESTA manufacturer IDs and OEM code values
svn path=/trunk/; revision=43580
2012-07-06 05:17:09 +00:00
217514e565
Remove a couple set-but-unused variables. I *think* the new tree isn't
...
particularly useful...
svn path=/trunk/; revision=43577
2012-07-05 23:31:17 +00:00
c7dbc44bf3
Fix bug #7436
...
offset returned from dissect_nfs_open_claim4, dissect_nfs_openflag4 were different
when we were building tree and where we didn't.
Fix other similar cases.
svn path=/trunk/; revision=43576
2012-07-05 21:09:34 +00:00
a9b2a718a7
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7437 :
...
PTP Cancel unicast transmission and Acknowledge cancel unicast transmission packets are decoded as malformed
svn path=/trunk/; revision=43575
2012-07-05 20:07:43 +00:00
889ddbd9eb
Fix compilation with gcc 4.3.2
...
svn path=/trunk/; revision=43572
2012-07-05 09:02:08 +00:00
a7fef5b3bf
Upgrade LTE RRC dissector to v10.6.0
...
svn path=/trunk/; revision=43571
2012-07-05 08:44:30 +00:00
d94492cc71
From Richard Sharpe via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7428 :
...
Add SPNEGO Extended Negotiation (NEGOEX) Security Mechanism dissector
svn path=/trunk/; revision=43569
2012-07-05 05:26:28 +00:00
c02d156881
The amqp dissector is not a plugin; remove comment indicating that it's a plugin.
...
Also: Fix some "4 space tab" indentation (replace with spaces).
svn path=/trunk/; revision=43566
2012-07-04 13:04:16 +00:00
c529c306d4
From Evan Huus via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7433 :
...
Remove unused mask variable in packet-bmc.c
svn path=/trunk/; revision=43565
2012-07-04 10:08:22 +00:00
a24fa25716
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7430 :
...
Dissection of EAP-SIM and EAP-AKA is broken
svn path=/trunk/; revision=43560
2012-07-03 20:07:53 +00:00
234cd599b3
Remove a leftover // "comment to self" (fixes checkAPI error).
...
svn path=/trunk/; revision=43559
2012-07-03 19:47:54 +00:00
7882ec57c3
Improve use of the value_string x11_keysym_vals_source[]:
...
- Compile the value_string only as part of packet-x11.c
- Create a value_string_ext to ref the value_string;
- packet_vnc.c: Access the value_string using the value_string_ext;
- packet-x11.c: Access the value-string using the value_string_ext
rather then building a temp GTree from the value_string.
svn path=/trunk/; revision=43558
2012-07-03 18:49:12 +00:00
a16c3e2692
From report of Dennis Mendoza via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7429
...
Wireshark > 1.4 does not correctly read Association ID for PS Poll packets
Wireless Frame with subtype 0x1a don't interpret the Association ID (always 0).
Fix :
proto_tree_add_uint() wasn't changed to proto_tree_add_item()
#BACKPORT
svn path=/trunk/; revision=43556
2012-07-03 12:28:06 +00:00
d25ae90a67
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7420 :
...
CI/CI+: dissect CICAM NIT
svn path=/trunk/; revision=43546
2012-06-29 20:10:25 +00:00
e083f0f71e
Try to fix win64 buildbot.
...
packet-dbus.c(354) : error C2220: warning treated as error - no 'object' file generated
packet-dbus.c(354) : warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data
svn path=/trunk/; revision=43543
2012-06-29 17:44:48 +00:00
33bfa85452
Initial support for D-Bus dissection (bug #5502 )
...
svn path=/trunk/; revision=43542
2012-06-29 15:23:21 +00:00
163ca72bab
From Роман Донченко: "Adaptation" misspelled as "adaption"
...
In MPEG-related dissectors, "adaption" is used instead of "adaptation" several
times. See patch (it also fixes an unrelated typo that happens to be on the
same line).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7421
svn path=/trunk/; revision=43539
2012-06-29 01:55:05 +00:00
b18e880040
Update FSF address - part II.
...
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
698337ee9a
Prettify display of O_RDONLY and O_ACCMODE flags
...
svn path=/trunk/; revision=43510
2012-06-27 14:57:58 +00:00
fca94d1d2d
From Martin Raison via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7414
...
PMIPV6 support over IPV4 network
PMIPv6 is an extension of MIPv6, adding a certain number of options to the
MIPv6 protocol. These options are already implemented in the wireshark
dissector, and the MIPv6 headers are recognized, but only inside IPv6 packets.
However, RFC5844 extends the PMIPv6 protocol to make it work over IPv4 networks
: as explained in section 4 of this RFC, the MIPv6 message is carried inside an
IPv4 packet with a UDP header. The port number in the UDP header is 5436
svn path=/trunk/; revision=43505
2012-06-27 13:27:28 +00:00
e3b8929a46
General cleanup:
...
- Remove _U_ when function arg is actually used;
- Use consistent formatting and whitespace style.
svn path=/trunk/; revision=43500
2012-06-26 21:45:06 +00:00
f7d834b564
Validate 'offset' before calling proto_item_set_end(); prevents potential 'Dissector Bug' msg
...
Addresses comment in Bug #7390 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7390#c1
svn path=/trunk/; revision=43496
2012-06-26 16:06:26 +00:00
5efda930a6
From Richard Sharpe:
...
I noticed some inconsistencies in the command naming. The following
patch fixes those (so that they now match between SMB and SMB2):
svn path=/trunk/; revision=43495
2012-06-26 13:02:13 +00:00
289707eccc
From Michal Labedzki:
...
RFCOMM-Add-Version-and-DecodeBy-preferences
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6567
svn path=/trunk/; revision=43491
2012-06-25 23:17:12 +00:00
bdb1eb55e9
From Michal Labedzki:
...
RFCOMM-Cosmetic-fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6567
svn path=/trunk/; revision=43490
2012-06-25 23:10:01 +00:00
b8b2d513f6
From Michal Labedzki:
...
BT: Expose RFCOMM Channel instead of DLCI
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6567
svn path=/trunk/; revision=43489
2012-06-25 22:48:11 +00:00
b160466dd2
From Martin Kaiser:
...
add X.509 certificate extensions for DVB-CI/CI+
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7397
svn path=/trunk/; revision=43485
2012-06-25 21:16:43 +00:00
9b21bf229f
Tighten up validity checking when doing reassembly.
...
Fixes Bug #7390 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7390
(Esentially: Do proper validity checking to prevent a "Dissector Bug" exception;
throw a BoundsError exception instead).
svn path=/trunk/; revision=43483
2012-06-25 20:43:54 +00:00
053707aef8
Fix dissection of NAS EPS Service Request message (broken in r42200)
...
svn path=/trunk/; revision=43474
2012-06-25 11:12:54 +00:00
2d5792d19b
Fix typo errors
...
svn path=/trunk/; revision=43473
2012-06-25 10:16:15 +00:00
342812d0ee
From Yair:
...
1. OAM cells are not automatically detected if the AAL type passed is
AAL_UNKNOWN.
2. CRC10 calculation does not take into account the "crc_stripped" option, and
uses a hardcoded offset of 5 bytes into the cell.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7385
svn path=/trunk/; revision=43471
2012-06-24 23:56:27 +00:00
753d90e57e
From Martin Kaiser:
...
add oid for sha256.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7395
svn path=/trunk/; revision=43469
2012-06-24 23:52:24 +00:00
a2a9d5757a
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7386 :
...
Fix dissection of Packet Receipt Times Report Block
svn path=/trunk/; revision=43467
2012-06-24 21:26:40 +00:00
a0e2ba5eb0
FT_FLOAT and FT_DOUBLE share the same comparison functions -> use same filter name
...
svn path=/trunk/; revision=43460
2012-06-24 17:41:18 +00:00
9adf66b3fb
From Adam Langley:
...
Decrypt resumed, SSL sessions from keylog file-
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7396
svn path=/trunk/; revision=43458
2012-06-24 15:24:59 +00:00
fb0a2f3031
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43451
2012-06-23 15:45:01 +00:00
4a6244d1fa
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43450
2012-06-23 15:27:51 +00:00
3ceda0e1c4
Rename two entries to avoid having same filter name for entries with incompatible types
...
svn path=/trunk/; revision=43449
2012-06-23 15:04:13 +00:00
472f036552
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43448
2012-06-23 14:36:21 +00:00
e68222ebfd
Fix copy/paste errors
...
svn path=/trunk/; revision=43447
2012-06-23 14:11:06 +00:00
8c91a5ab0b
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43446
2012-06-23 14:10:19 +00:00
10f6bcc140
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7391 :
...
Do not use same name for filters with incompatible types
svn path=/trunk/; revision=43443
2012-06-22 20:44:52 +00:00
a66eee919e
Mark a couple more variables volatile.
...
svn path=/trunk/; revision=43437
2012-06-21 21:19:48 +00:00
7a18a5e7b9
From Richard Sharpe via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7387 :
...
Don't break/return out of a TRY/CATCH.
svn path=/trunk/; revision=43434
2012-06-21 19:32:56 +00:00
fe3c093534
Fix compilation with gcc...
...
svn path=/trunk/; revision=43409
2012-06-20 13:42:17 +00:00
29fb9f460b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7383 :
...
Put back items into the correct dtap_tree tree and comment pd_tree that is unused for now
svn path=/trunk/; revision=43408
2012-06-20 13:37:22 +00:00
96a3da3e05
Use separate filters for the RTT found on a SACK and the RTT found on a
...
DATA chunk: having them in both places is helpful when looking at the
messages but having them separate is helpful when graphing the RTTs.
svn path=/trunk/; revision=43406
2012-06-20 13:30:07 +00:00
1f96f7105e
Revert http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=43404 .
...
(Needs rethinking).
svn path=/trunk/; revision=43405
2012-06-20 11:44:28 +00:00
21e86b9d4d
SDP data embeded in OCTET STRING.
...
svn path=/trunk/; revision=43404
2012-06-20 10:48:00 +00:00
3cdd0278aa
Add a link to IANA registry.
...
svn path=/trunk/; revision=43403
2012-06-20 10:47:18 +00:00
3b24901e53
Upadte e-mail.
...
svn path=/trunk/; revision=43402
2012-06-20 10:46:38 +00:00
4cc3cae627
- In INTERNAL HANDOVER COMMAND Circuit Identity Code is C(Coded optional in WS)
...
- be_speech_codec ( 3.2.2.104 Speech Codec) did not cover all codecs.
svn path=/trunk/; revision=43401
2012-06-20 07:59:20 +00:00
030a76319c
Correct the IPv6 fragment offset shown in COL_INFO.
...
Make some Fragment header fields filterable (add_text() -> add_item()).
Display (and make filterable) the reserved octet and bits.
svn path=/trunk/; revision=43389
2012-06-19 20:20:18 +00:00
760559b957
Simplify proto_tree_add_string_format_value(..., val, "%s", val) with proto_tree_add_string.
...
hash is 16-bytes hex dump (ASCII!). No need to use proto_tree_add_string_format_value().
svn path=/trunk/; revision=43386
2012-06-19 19:50:43 +00:00
fe8280ce5e
Use tvb_get_ephemeral_string_enc() in combination with proto_tree_add_unicode_string() (as recommended by Jakub on the mailing list)
...
svn path=/trunk/; revision=43385
2012-06-19 19:25:01 +00:00
6356f914c4
Use newly introduced proto_tree_add_unicode_string() to add UTF-8 strings
...
svn path=/trunk/; revision=43379
2012-06-19 18:21:53 +00:00
adb2a47a58
Mark another variable as volatile to pacify the buildbot.
...
svn path=/trunk/; revision=43376
2012-06-19 17:29:56 +00:00
7364abf0bc
Typo
...
svn path=/trunk/; revision=43365
2012-06-19 14:46:21 +00:00
85aad38347
Add proto_tree_add_unicode_string() to add UTF-8 string to tree.
...
Convert some proto_tree_add_string_format_value(..., val, "%s", val); to use new function.
svn path=/trunk/; revision=43363
2012-06-19 14:32:24 +00:00
7c59ac0280
Fix bug #7378 : Wireshark 1.8.0rc1: gsm_a_dtap SMS 7-bit default alphabet regression w.r.t. 1.6.8
...
proto_item_add_string() can be only used with ASCII strings.
svn path=/trunk/; revision=43362
2012-06-19 14:25:50 +00:00
f39c0913ed
Mark some variables as volatile to avoid compiler warnings.
...
svn path=/trunk/; revision=43357
2012-06-19 13:24:43 +00:00
f0f3e36bda
Try to fix unused variable warnings and "clobbered by 'longjmp' or 'vfork' "
...
svn path=/trunk/; revision=43355
2012-06-19 12:44:13 +00:00
9ee8562c32
From Richard Sharpe:
...
Wireshark is unable to dissect Security Descriptors that span TCP segments where some are not captured or reassembled
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7363
svn path=/trunk/; revision=43352
2012-06-19 10:30:51 +00:00
86a888bc0d
Set save_fragmented at the beginning of the routine, so it can always be
...
used at the end to restore pinfo->fragmented.
svn path=/trunk/; revision=43350
2012-06-19 08:24:23 +00:00
98c0e827d0
In dissect_nt_transaction_request(), restore pinfo->fragmented before
...
returning.
svn path=/trunk/; revision=43348
2012-06-19 08:09:28 +00:00
99e919bf8b
From Richard Sharpe:
...
packet-smb.c does not properly handle NT TRANSACT requests (and probably TRANSACT and TRANSACT2 requests)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7351
svn path=/trunk/; revision=43347
2012-06-19 06:24:30 +00:00
24d2178eb7
From Sandeep Dahiya.
...
Add support for Gigamon timestamp trailer (different from existing Gigamon header format).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7365
svn path=/trunk/; revision=43346
2012-06-19 06:18:30 +00:00
0bf0ece483
Integrate r43221 and 43222 with 43211. (Revert back to having only
...
dscp_vals_ext.)
svn path=/trunk/; revision=43335
2012-06-18 17:23:10 +00:00
4945ce61ef
Fix a null pointer warning from Clang. Not sure if we'll run into this
...
in practice.
svn path=/trunk/; revision=43334
2012-06-18 17:09:54 +00:00
697cc92c86
Use enums instead of hand written values
...
svn path=/trunk/; revision=43333
2012-06-18 16:53:24 +00:00
7351065ccd
From Sven Eckelmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7375 :
...
Add support for not_best_next_hop flag in B.A.T.M.A.N. Advanced v14
svn path=/trunk/; revision=43332
2012-06-18 09:17:58 +00:00
d9d97cb7ce
Fix typos.
...
svn path=/trunk/; revision=43320
2012-06-17 20:07:32 +00:00
28e925a381
Allow future forward compatibility
...
svn path=/trunk/; revision=43312
2012-06-17 16:08:43 +00:00
3bbb0d3bc6
Enhance dissection of the NewSessionTicket handshake message.
...
svn path=/trunk/; revision=43304
2012-06-17 11:30:25 +00:00
e058a65c17
Fix reading back exported SSL keys. Bug was introduced in r43097.
...
svn path=/trunk/; revision=43303
2012-06-17 09:02:04 +00:00
02b7064a87
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7372 :
...
tcap.otid and tcap.dtid can be used as display filters
svn path=/trunk/; revision=43288
2012-06-16 19:13:48 +00:00
d57552df5d
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7371 :
...
Add dissection of Release 8 or higher P-GW QoS profile
svn path=/trunk/; revision=43280
2012-06-16 13:09:51 +00:00
1463b2b0c8
Minor cleanup:
...
- Use _U_ on a fcn parameter so can remove "prevent compiler warning" line of useless code;
- indentation
- ...
svn path=/trunk/; revision=43273
2012-06-15 15:49:05 +00:00
a9690db5a3
Minor Changes:
...
- checkcol() not needed;
- remove unneeded #include <expert.h>
- remove 'if(tree)' so "bytes dissected" returned always the same.
svn path=/trunk/; revision=43272
2012-06-15 15:15:48 +00:00
cf28e12ed7
Correct a discrepancy in the specification.
...
svn path=/trunk/; revision=43270
2012-06-15 11:23:40 +00:00
0acb6e6f34
Fix Coverity CID 703858: Unused pointer value.
...
svn path=/trunk/; revision=43268
2012-06-14 23:56:59 +00:00
718a61d6f4
Fix Coverity CID 703859: Unused pointer value.
...
Fix Coverity CID 703860: Unused pointer value.
svn path=/trunk/; revision=43267
2012-06-14 23:39:44 +00:00
17da162356
Try to fix a couple of warnings.
...
svn path=/trunk/; revision=43259
2012-06-14 15:50:24 +00:00
2d4d566636
Add dissection of utra-BCCH-Container-r10
...
svn path=/trunk/; revision=43257
2012-06-14 10:43:54 +00:00
d4aaeccac7
Pretify columns.
...
svn path=/trunk/; revision=43256
2012-06-14 08:44:45 +00:00
41b3988bbd
Fix function name (it is an Authentication failure, not an Attach failure)
...
svn path=/trunk/; revision=43255
2012-06-14 07:25:53 +00:00
Anders Broman