Pascal Quantin
4a6244d1fa
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43450
2012-06-23 15:27:51 +00:00
Pascal Quantin
3ceda0e1c4
Rename two entries to avoid having same filter name for entries with incompatible types
...
svn path=/trunk/; revision=43449
2012-06-23 15:04:13 +00:00
Pascal Quantin
472f036552
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43448
2012-06-23 14:36:21 +00:00
Pascal Quantin
e68222ebfd
Fix copy/paste errors
...
svn path=/trunk/; revision=43447
2012-06-23 14:11:06 +00:00
Pascal Quantin
8c91a5ab0b
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43446
2012-06-23 14:10:19 +00:00
Pascal Quantin
10f6bcc140
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7391 :
...
Do not use same name for filters with incompatible types
svn path=/trunk/; revision=43443
2012-06-22 20:44:52 +00:00
Jeff Morriss
a66eee919e
Mark a couple more variables volatile.
...
svn path=/trunk/; revision=43437
2012-06-21 21:19:48 +00:00
Jeff Morriss
7a18a5e7b9
From Richard Sharpe via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7387 :
...
Don't break/return out of a TRY/CATCH.
svn path=/trunk/; revision=43434
2012-06-21 19:32:56 +00:00
Pascal Quantin
fe3c093534
Fix compilation with gcc...
...
svn path=/trunk/; revision=43409
2012-06-20 13:42:17 +00:00
Pascal Quantin
29fb9f460b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7383 :
...
Put back items into the correct dtap_tree tree and comment pd_tree that is unused for now
svn path=/trunk/; revision=43408
2012-06-20 13:37:22 +00:00
Jeff Morriss
96a3da3e05
Use separate filters for the RTT found on a SACK and the RTT found on a
...
DATA chunk: having them in both places is helpful when looking at the
messages but having them separate is helpful when graphing the RTTs.
svn path=/trunk/; revision=43406
2012-06-20 13:30:07 +00:00
Anders Broman
1f96f7105e
Revert http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=43404 .
...
(Needs rethinking).
svn path=/trunk/; revision=43405
2012-06-20 11:44:28 +00:00
Anders Broman
21e86b9d4d
SDP data embeded in OCTET STRING.
...
svn path=/trunk/; revision=43404
2012-06-20 10:48:00 +00:00
Anders Broman
3cdd0278aa
Add a link to IANA registry.
...
svn path=/trunk/; revision=43403
2012-06-20 10:47:18 +00:00
Anders Broman
3b24901e53
Upadte e-mail.
...
svn path=/trunk/; revision=43402
2012-06-20 10:46:38 +00:00
Anders Broman
4cc3cae627
- In INTERNAL HANDOVER COMMAND Circuit Identity Code is C(Coded optional in WS)
...
- be_speech_codec ( 3.2.2.104 Speech Codec) did not cover all codecs.
svn path=/trunk/; revision=43401
2012-06-20 07:59:20 +00:00
Jeff Morriss
030a76319c
Correct the IPv6 fragment offset shown in COL_INFO.
...
Make some Fragment header fields filterable (add_text() -> add_item()).
Display (and make filterable) the reserved octet and bits.
svn path=/trunk/; revision=43389
2012-06-19 20:20:18 +00:00
Jakub Zawadzki
760559b957
Simplify proto_tree_add_string_format_value(..., val, "%s", val) with proto_tree_add_string.
...
hash is 16-bytes hex dump (ASCII!). No need to use proto_tree_add_string_format_value().
svn path=/trunk/; revision=43386
2012-06-19 19:50:43 +00:00
Pascal Quantin
fe8280ce5e
Use tvb_get_ephemeral_string_enc() in combination with proto_tree_add_unicode_string() (as recommended by Jakub on the mailing list)
...
svn path=/trunk/; revision=43385
2012-06-19 19:25:01 +00:00
Pascal Quantin
6356f914c4
Use newly introduced proto_tree_add_unicode_string() to add UTF-8 strings
...
svn path=/trunk/; revision=43379
2012-06-19 18:21:53 +00:00
Jeff Morriss
adb2a47a58
Mark another variable as volatile to pacify the buildbot.
...
svn path=/trunk/; revision=43376
2012-06-19 17:29:56 +00:00
Anders Broman
7364abf0bc
Typo
...
svn path=/trunk/; revision=43365
2012-06-19 14:46:21 +00:00
Jakub Zawadzki
85aad38347
Add proto_tree_add_unicode_string() to add UTF-8 string to tree.
...
Convert some proto_tree_add_string_format_value(..., val, "%s", val); to use new function.
svn path=/trunk/; revision=43363
2012-06-19 14:32:24 +00:00
Jakub Zawadzki
7c59ac0280
Fix bug #7378 : Wireshark 1.8.0rc1: gsm_a_dtap SMS 7-bit default alphabet regression w.r.t. 1.6.8
...
proto_item_add_string() can be only used with ASCII strings.
svn path=/trunk/; revision=43362
2012-06-19 14:25:50 +00:00
Jeff Morriss
f39c0913ed
Mark some variables as volatile to avoid compiler warnings.
...
svn path=/trunk/; revision=43357
2012-06-19 13:24:43 +00:00
Anders Broman
f0f3e36bda
Try to fix unused variable warnings and "clobbered by 'longjmp' or 'vfork' "
...
svn path=/trunk/; revision=43355
2012-06-19 12:44:13 +00:00
Anders Broman
9ee8562c32
From Richard Sharpe:
...
Wireshark is unable to dissect Security Descriptors that span TCP segments where some are not captured or reassembled
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7363
svn path=/trunk/; revision=43352
2012-06-19 10:30:51 +00:00
Guy Harris
86a888bc0d
Set save_fragmented at the beginning of the routine, so it can always be
...
used at the end to restore pinfo->fragmented.
svn path=/trunk/; revision=43350
2012-06-19 08:24:23 +00:00
Guy Harris
98c0e827d0
In dissect_nt_transaction_request(), restore pinfo->fragmented before
...
returning.
svn path=/trunk/; revision=43348
2012-06-19 08:09:28 +00:00
Anders Broman
99e919bf8b
From Richard Sharpe:
...
packet-smb.c does not properly handle NT TRANSACT requests (and probably TRANSACT and TRANSACT2 requests)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7351
svn path=/trunk/; revision=43347
2012-06-19 06:24:30 +00:00
Anders Broman
24d2178eb7
From Sandeep Dahiya.
...
Add support for Gigamon timestamp trailer (different from existing Gigamon header format).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7365
svn path=/trunk/; revision=43346
2012-06-19 06:18:30 +00:00
Gerald Combs
0bf0ece483
Integrate r43221 and 43222 with 43211. (Revert back to having only
...
dscp_vals_ext.)
svn path=/trunk/; revision=43335
2012-06-18 17:23:10 +00:00
Gerald Combs
4945ce61ef
Fix a null pointer warning from Clang. Not sure if we'll run into this
...
in practice.
svn path=/trunk/; revision=43334
2012-06-18 17:09:54 +00:00
Pascal Quantin
697cc92c86
Use enums instead of hand written values
...
svn path=/trunk/; revision=43333
2012-06-18 16:53:24 +00:00
Pascal Quantin
7351065ccd
From Sven Eckelmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7375 :
...
Add support for not_best_next_hop flag in B.A.T.M.A.N. Advanced v14
svn path=/trunk/; revision=43332
2012-06-18 09:17:58 +00:00
Chris Maynard
d9d97cb7ce
Fix typos.
...
svn path=/trunk/; revision=43320
2012-06-17 20:07:32 +00:00
Pascal Quantin
28e925a381
Allow future forward compatibility
...
svn path=/trunk/; revision=43312
2012-06-17 16:08:43 +00:00
Sake Blok
3bbb0d3bc6
Enhance dissection of the NewSessionTicket handshake message.
...
svn path=/trunk/; revision=43304
2012-06-17 11:30:25 +00:00
Sake Blok
e058a65c17
Fix reading back exported SSL keys. Bug was introduced in r43097.
...
svn path=/trunk/; revision=43303
2012-06-17 09:02:04 +00:00
Pascal Quantin
02b7064a87
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7372 :
...
tcap.otid and tcap.dtid can be used as display filters
svn path=/trunk/; revision=43288
2012-06-16 19:13:48 +00:00
Pascal Quantin
d57552df5d
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7371 :
...
Add dissection of Release 8 or higher P-GW QoS profile
svn path=/trunk/; revision=43280
2012-06-16 13:09:51 +00:00
Bill Meier
1463b2b0c8
Minor cleanup:
...
- Use _U_ on a fcn parameter so can remove "prevent compiler warning" line of useless code;
- indentation
- ...
svn path=/trunk/; revision=43273
2012-06-15 15:49:05 +00:00
Bill Meier
a9690db5a3
Minor Changes:
...
- checkcol() not needed;
- remove unneeded #include <expert.h>
- remove 'if(tree)' so "bytes dissected" returned always the same.
svn path=/trunk/; revision=43272
2012-06-15 15:15:48 +00:00
Anders Broman
cf28e12ed7
Correct a discrepancy in the specification.
...
svn path=/trunk/; revision=43270
2012-06-15 11:23:40 +00:00
Chris Maynard
0acb6e6f34
Fix Coverity CID 703858: Unused pointer value.
...
svn path=/trunk/; revision=43268
2012-06-14 23:56:59 +00:00
Chris Maynard
718a61d6f4
Fix Coverity CID 703859: Unused pointer value.
...
Fix Coverity CID 703860: Unused pointer value.
svn path=/trunk/; revision=43267
2012-06-14 23:39:44 +00:00
Anders Broman
17da162356
Try to fix a couple of warnings.
...
svn path=/trunk/; revision=43259
2012-06-14 15:50:24 +00:00
Pascal Quantin
2d4d566636
Add dissection of utra-BCCH-Container-r10
...
svn path=/trunk/; revision=43257
2012-06-14 10:43:54 +00:00
Anders Broman
d4aaeccac7
Pretify columns.
...
svn path=/trunk/; revision=43256
2012-06-14 08:44:45 +00:00
Pascal Quantin
41b3988bbd
Fix function name (it is an Authentication failure, not an Attach failure)
...
svn path=/trunk/; revision=43255
2012-06-14 07:25:53 +00:00
Pascal Quantin
3c20eeb452
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7368 :
...
Identity request, Identity response and Authentication failure message dissection are swapped
svn path=/trunk/; revision=43253
2012-06-14 07:14:59 +00:00
Pascal Quantin
b9debc4467
Use value_string_ext for arrays with more than 15 entries
...
svn path=/trunk/; revision=43243
2012-06-13 22:02:12 +00:00
Pascal Quantin
96231f396a
Use value_string_ext for arrays with more than 15 entries
...
svn path=/trunk/; revision=43241
2012-06-13 21:05:10 +00:00
Jeff Morriss
75972ddcd9
Mark a couple of parameters as unused.
...
svn path=/trunk/; revision=43235
2012-06-13 17:25:16 +00:00
Anders Broman
d2d882e4b1
From Michael Mann:
...
length bugfix + proto_tree_add_text() cleanup
Fixed the Web-Cache Identity Info dissection. Also converted many of the
proto_tree_add_text() to "more filterable" APIs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5141
svn path=/trunk/; revision=43231
2012-06-13 15:27:41 +00:00
Jeff Morriss
f00c8309af
From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3317
...
Add SSL/TLS support to the POP dissector (functionality copied from the
SMTP dissector).
svn path=/trunk/; revision=43230
2012-06-13 14:56:33 +00:00
Jeff Morriss
4fdc3c3cc2
Create, and start using, file name preferences.
...
File name preferences are basically just string preferences except that the
GUI will present a "Browse" button that allows the user to go and find the
file s/he wants (rather than having to blindly type in the full path).
svn path=/trunk/; revision=43228
2012-06-13 01:13:12 +00:00
Pascal Quantin
f0a74f3a5c
Upgrade GSM BSSMAP dissection to Release 9 (V9.8.0)
...
svn path=/trunk/; revision=43227
2012-06-12 21:36:55 +00:00
Bill Meier
1b17369504
Fix: code under 'if(tree)' (in)directly calls sub-dissector/col_...()/expert...() fcns
...
svn path=/trunk/; revision=43226
2012-06-12 21:22:46 +00:00
Jörg Mayer
f679b89649
Revert r41952
...
BACKPORT to 1.8
svn path=/trunk/; revision=43222
2012-06-12 10:44:57 +00:00
Jörg Mayer
9228ece476
Manually revert r41953
...
BACKPORT to 1.8
svn path=/trunk/; revision=43221
2012-06-12 10:38:22 +00:00
Bill Meier
4f47eefa79
Fix bugs and other issues:
...
- remove 'if (tree)' around code which (eventually) calls col_...() functions;
- remove unneeded check_col() usage;
- use extended value-strings where appropriate;
- use col_set_str() instead of col_add_fstr();
- fix mismatch between proto_tree_add_item() size arg and the FT type in the
referenced hf[] entry (in a few cases);
- FT_STRING fields should have ENC_ASCII|ENC_NA as the 'encoding' arg
in the corresponding proto_tree_add_item() call;
- do whitespace cleanup.
Note: 1 issue remains:
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260#c12
svn path=/trunk/; revision=43217
2012-06-11 20:51:47 +00:00
Bill Meier
bdebbb9bdf
Re-order 2 value_string arrays so that entries are in ascending order by value.
...
svn path=/trunk/; revision=43216
2012-06-11 20:35:00 +00:00
Pascal Quantin
aa0ebee47c
From Alexander via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7361 :
...
Add BSS supported Codec list dissection to Assigment Complete message
svn path=/trunk/; revision=43215
2012-06-11 20:28:31 +00:00
Pascal Quantin
653f74bfcf
From Alexander via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7360 :
...
Service handover IE is not correctly dissected
svn path=/trunk/; revision=43214
2012-06-11 20:12:17 +00:00
Bill Meier
5e3066f006
Use dscp_vals_ext everyplace (instead of dscp_vals);
...
(dscp_vals is now a static array in packet-ip.c)
svn path=/trunk/; revision=43211
2012-06-11 19:07:53 +00:00
Bill Meier
70cc6362fe
Don't define value_string arrays in a .h file (included in multiple places).
...
Also:
- don't use val_to_str_const() with a "format" default string;
- rename 'opt_len_type' enumeration identifiers to be less generic.
svn path=/trunk/; revision=43210
2012-06-11 18:47:42 +00:00
Bill Meier
afab63c34c
Fix another compiler warning
...
svn path=/trunk/; revision=43209
2012-06-11 16:53:49 +00:00
Bill Meier
332f743f6c
Fix a compiler warning
...
svn path=/trunk/; revision=43208
2012-06-11 16:44:42 +00:00
Bill Meier
8469651f54
General cleanup:
...
- remove some redundant code;
- use ep_strdup_printf() instead of g_snprintf() to a static buffer;
- create and use extended-value-strings as appropriate;
- define a value_string array as static (not as an automatic);
- use val_to_str_const() instead of val_to_str() as appropriate;
- reformat hf[] array entries;
- do general formatting cleanup;
- do whitespace cleanup (e.g., indentation & 4-space tabs).
svn path=/trunk/; revision=43207
2012-06-11 16:33:56 +00:00
Bill Meier
df07bfeba4
Create dscp_vals_ext value_str_ext (based upon dscp_vals); Use it as appropriate.
...
Also:
- use val_to_str_const() [instead of val_to_str()] in a few cases;
- do some trivial formatting cleanup.
svn path=/trunk/; revision=43204
2012-06-11 15:47:50 +00:00
Pascal Quantin
a923c28ede
Use restricted character string decoding for IA5String type
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6246
svn path=/trunk/; revision=43203
2012-06-11 13:54:06 +00:00
Anders Broman
4f2c3a8e86
len is no longer used.
...
svn path=/trunk/; revision=43200
2012-06-11 08:07:48 +00:00
Anders Broman
8456dcbceb
From Michael Mann:
...
Implemented RFC 4954 within the SMTP dissector. On principle, the decryption
is disabled by default (making this feature not obviously present). However I
don't think there will ever be enough data that the performance would be an
issue if the default was changed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7349
svn path=/trunk/; revision=43197
2012-06-11 07:10:18 +00:00
Anders Broman
34cb6f96d3
From Michael Mann:
...
NUL terminate the decoded string.
Updated only dissector that uses epan_base64_decode() (packet-http.c) to assume
NULL termination.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7349
svn path=/trunk/; revision=43196
2012-06-11 07:09:11 +00:00
Bill Meier
7b94cadffd
From Evan Huus: Missing breaks in packet-rsvp.c
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7353
svn path=/trunk/; revision=43194
2012-06-11 03:36:04 +00:00
Chris Maynard
339bedb75c
Fix UDP-Lite checksum verification bug introduced with r40387 and reported by "answer" via http://ask.wireshark.org/questions/11798/is-udp-lite-checksum-correct-ipv6
...
There is a difference between the UDP and UDP-Lite pseudo header that wasn't realized when r40387 was committed. Details of the difference in http://tools.ietf.org/html/rfc3828#section-3.2
svn path=/trunk/; revision=43187
2012-06-10 19:43:40 +00:00
Chris Maynard
ebe8ed3a3e
Fix the other part of Coverity CID 703086. I thought I got it with r42798, but apparently that was only 1/2 the fix as sometimes they group more than one bug into a single CID.
...
svn path=/trunk/; revision=43185
2012-06-10 19:02:03 +00:00
Anders Broman
912ba5d00b
From Michael Mann: Added dissection of IceP over UDP as well as a few preferences mentioned in the TODO. Also replaced a few proto_tree_add_text with expert_add_info_format. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1646
...
svn path=/trunk/; revision=43182
2012-06-10 08:24:18 +00:00
Bill Meier
4b4bb7acf5
Fix compiler error
...
svn path=/trunk/; revision=43181
2012-06-09 18:42:20 +00:00
Bill Meier
61d278c921
str_to_ipaddr() had a bug; use inet_pton() instead;
...
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844#c27
Also: Improve handling of an invalid value for the 'proxy IP Address'
preference. If the address is invalid, setting the preference
to "" in proto_reg_handoff...() doesn't work well.
Instead, issue a g_warning for an invalid IP address when it'
s processed in proto_reg_handoff...()
(AFAIK, there's not a way for a dissector to validate the semantic
value of a preference and report an error).
svn path=/trunk/; revision=43180
2012-06-09 18:24:09 +00:00
Chris Maynard
951b5b9c54
Do not use BASE_NONE for FT_*INT* types.
...
svn path=/trunk/; revision=43179
2012-06-09 17:56:08 +00:00
Chris Maynard
0169f77ac6
Do not use BASE_NONE for FT_*INT* types.
...
svn path=/trunk/; revision=43178
2012-06-09 17:51:30 +00:00
Chris Maynard
d9a5e3a1d2
Do not use BASE_NONE for FT_*INT* types.
...
svn path=/trunk/; revision=43177
2012-06-09 17:47:58 +00:00
Chris Maynard
365139b5cf
Do not use BASE_NONE for FT_UINT8 types.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7333 (I think).
svn path=/trunk/; revision=43176
2012-06-09 17:08:46 +00:00
Chris Maynard
8fe8287a39
Add sip.to.tag and sip.from.tag filters.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5226
svn path=/trunk/; revision=43175
2012-06-09 15:54:15 +00:00
Chris Maynard
bf35ccfbce
Allow syslog to work with "Decode As" for TCP.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5241
svn path=/trunk/; revision=43174
2012-06-09 15:43:08 +00:00
Jeff Morriss
be965bff75
Don't register 3 (IPAddress) hf's with the same abbreviation but with 3
...
different types; instead use different abbreviations (filters).
This is in order to prevent running into
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402
and seg-faulting when someone applies a filter of, for example,
diameter.Framed-IP-Address .
svn path=/trunk/; revision=43166
2012-06-08 22:23:11 +00:00
Bill Meier
836ed4ccfc
Fix bug I introduced in SVN #43129 .
...
Fixes fuzz crash reported in Bug #7346 .
svn path=/trunk/; revision=43164
2012-06-08 21:17:42 +00:00
Jeff Morriss
b4f3ea200c
Thinking about it more, how we're storing the application ID isn't a problem.
...
svn path=/trunk/; revision=43163
2012-06-08 20:08:43 +00:00
Jeff Morriss
c75657ad14
Don't call val_to_str() only to then compare the result with "Uknown": use
...
match_strval() instead.
Also, don't retrieve the application ID 3 more times; we've already got it
in a variable...
Point out a bug regarding how we're storing the application ID for use by
subdissectors (from r34570).
svn path=/trunk/; revision=43162
2012-06-08 19:59:33 +00:00
Gerald Combs
39dbd45c9f
Fix some dead assignments.
...
svn path=/trunk/; revision=43157
2012-06-08 17:20:44 +00:00
Anders Broman
ae43364681
Only dissect as SDp if it's IPBCP (text encoded).
...
svn path=/trunk/; revision=43152
2012-06-08 11:50:52 +00:00
Anders Broman
98b74816ae
From Stefan Hoffmeister:
...
ActiveSync WBXML CodeSpace updated to match official documentation.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7345
svn path=/trunk/; revision=43151
2012-06-08 06:26:55 +00:00
Bill Meier
fabd558ffe
Fix invalid hf[] entry 'display' field value.
...
result: incorect display of value (and, incidentally,
a crash in 'tshark -G values'
svn path=/trunk/; revision=43147
2012-06-07 17:39:11 +00:00
Anders Broman
059d407e19
From Niels de Vos: GlusterFS: Display SETATTR attribute valid as a list of flags https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7341
...
svn path=/trunk/; revision=43144
2012-06-06 20:44:21 +00:00
Anders Broman
7881fe8493
From Stephen Donnelly: Correct ERF name, add WTAP_ENCAP string display https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7313
...
svn path=/trunk/; revision=43141
2012-06-06 20:35:37 +00:00
Pascal Quantin
2f035a3c0f
From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7334 :
...
FPSpotlightRPC dates structure can contain multiple dates
svn path=/trunk/; revision=43133
2012-06-06 16:55:48 +00:00
Bill Meier
027b57b472
Fix compiler error (I hope)
...
svn path=/trunk/; revision=43131
2012-06-06 05:58:42 +00:00
Bill Meier
e18d46784f
Fix compiler error
...
svn path=/trunk/; revision=43130
2012-06-06 05:36:43 +00:00
Bill Meier
57c6467b81
Fix some bugs & do extensive cleanup;
...
Bugs fixed:
- Calling col_...() fcns or dissectors under 'if (tree)'
- Potential buffer overflows (if bad data)
- Misc incorrect data display issues
Cleanup including;
- Remove unneeded #includes
- Fix excessive use of value_strings
- Use extended value_strings & val_to_str_(ext_)const as appropriate
- Optimize repeated fetches of the same data from a tvb
- Do general code simplification
- Remove or #if 0 unused code;
- Add XXX comments for code which may be incorrect
- Remove unneeded prefs callback to proto_reg_handoff...()
- Remove unneeded use of check_col()
- Define several functions as static
- Move proto_reg_handoff...() to the end of the file
- Fix whitespace (including "4 space tabs")
- ...
svn path=/trunk/; revision=43129
2012-06-06 04:54:47 +00:00
Jörg Mayer
f554994823
Just fix some clang analysis warnings
...
svn path=/trunk/; revision=43126
2012-06-05 23:03:13 +00:00
Jakub Zawadzki
cf25f08af0
yami: dissect header messages, add parameter names to parent tree item.
...
svn path=/trunk/; revision=43117
2012-06-05 15:52:08 +00:00
Jeff Morriss
49c359bf2d
Fix Coverity 703495: reference fpinf *after* checking that it is not NULL.
...
Also replace some 4 space tabs with spaces.
svn path=/trunk/; revision=43113
2012-06-05 15:05:17 +00:00
Jakub Zawadzki
97d51ce67f
packet-yami: cleanup, remove non-ASCII character.
...
svn path=/trunk/; revision=43112
2012-06-05 15:02:49 +00:00
Jakub Zawadzki
7d075658b1
packet-wreth: cleanup
...
- make function and arrays static
- comment out unused hf-entry.
- comment out unused variable.
svn path=/trunk/; revision=43111
2012-06-05 14:50:37 +00:00
Jakub Zawadzki
6dc698ca27
Dissector for YAMI protocol.
...
svn path=/trunk/; revision=43110
2012-06-05 14:17:50 +00:00
Anders Broman
28098ed4ab
From Roland Knall:
...
openSAFETY - Names for certain SOD objects, automatic SCM UDID detecion.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7335
svn path=/trunk/; revision=43109
2012-06-05 13:12:28 +00:00
Anders Broman
aa4e655696
Set SVN properties.
...
svn path=/trunk/; revision=43108
2012-06-05 11:19:33 +00:00
Anders Broman
189ea54f0b
from Alex Lindberg:
...
Update to packet-h248.c and associated h248 dissecorts.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332
svn path=/trunk/; revision=43107
2012-06-05 10:54:21 +00:00
Anders Broman
5bd0c263f2
From Andrew Kampjes:
...
SDH support for wireshark.
- Added GPL license.
- Removed not needed includes.
- Skipped th .h file as it wasn't used.
svn path=/trunk/; revision=43106
2012-06-05 10:42:38 +00:00
Anders Broman
1d27ce5d99
From Adam Langley: Add support for decrypting ECDHE-RSA-RC4-SHA. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7331
...
svn path=/trunk/; revision=43100
2012-06-05 05:27:06 +00:00
Anders Broman
75319f09a9
From Adam Langley: Add support for CLIENT_RANDOM lines in SSL keylog. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7330
...
svn path=/trunk/; revision=43099
2012-06-05 05:22:41 +00:00
Anders Broman
cec562ddd2
From Alex Lindberg: Add preference to packet-ber.c to toggle BER warning on leading zero bits. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7328
...
svn path=/trunk/; revision=43098
2012-06-05 05:16:06 +00:00
Anders Broman
6c85e092cf
From Adam Langley: Clean up code for handling keylog files. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7329
...
svn path=/trunk/; revision=43097
2012-06-05 05:10:18 +00:00
Gerald Combs
7186d034f0
Fix compilation.
...
svn path=/trunk/; revision=43094
2012-06-04 23:47:11 +00:00
Alexis La Goutte
167b8c6cba
From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260
...
New dissector for WSE Remote Ethernet protocol
From me :
* Fix Compilation under linux
* Use proto_tree_add_item*
* Make build-in dissector
* Include Status.* and Codef.* in dissector
* Reorder function (to respect Wireshark Codelines)
* Add Modelines Info and fix indent (use 4 spaces)
* Fix check* tools
* Add Clement to AUTHORS
With the dissector....
svn path=/trunk/; revision=43092
2012-06-04 22:34:27 +00:00
Alexis La Goutte
42451447b1
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=43091
2012-06-04 22:26:40 +00:00
Alexis La Goutte
e2cec4bb63
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
(Manual Fix, not found how to fix the generator...)
svn path=/trunk/; revision=43090
2012-06-04 22:26:18 +00:00
Alexis La Goutte
c7e8a39966
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=43089
2012-06-04 22:25:27 +00:00
Alexis La Goutte
cb2000b9f3
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=43087
2012-06-04 22:24:46 +00:00
Alexis La Goutte
7ec2d11b9b
From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260
...
New dissector for WSE Remote Ethernet protocol
From me :
* Fix Compilation under linux
* Use proto_tree_add_item*
* Make build-in dissector
* Include Status.* and Codef.* in dissector
* Reorder function (to respect Wireshark Codelines)
* Add Modelines Info and fix indent (use 4 spaces)
* Fix check* tools
* Add Clement to AUTHORS
svn path=/trunk/; revision=43086
2012-06-04 22:22:32 +00:00
Jakub Zawadzki
11e584f4cf
packet-gadu-gadu: set COL_INFO in undissected/unknown packet types.
...
svn path=/trunk/; revision=43068
2012-06-04 14:37:24 +00:00
Anders Broman
a90e1a353a
Try to make the buildbot happy.
...
svn path=/trunk/; revision=43067
2012-06-04 14:31:53 +00:00
Anders Broman
b69547925f
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43066
2012-06-04 13:52:46 +00:00
Anders Broman
2a30b1eff9
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43065
2012-06-04 13:21:44 +00:00
Anders Broman
a0910557c7
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43064
2012-06-04 12:20:37 +00:00
Anders Broman
131334481d
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43063
2012-06-04 11:44:52 +00:00
Anders Broman
81a7df91dd
Revert previous change as it did not compile.
...
svn path=/trunk/; revision=43062
2012-06-04 11:18:17 +00:00
Anders Broman
920ad0bcee
Try to get rid of a couple of warnings.
...
svn path=/trunk/; revision=43061
2012-06-04 10:36:43 +00:00
Pascal Quantin
f275aeadd9
Fix 'lvalue required as left operand of assignment' error when compiling with gcc 4.3.2
...
svn path=/trunk/; revision=43059
2012-06-04 10:02:08 +00:00
Anders Broman
85972d91c7
Try to get rid of a couple of warnings.
...
svn path=/trunk/; revision=43058
2012-06-04 09:04:36 +00:00
Anders Broman
10fe76d8a0
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43057
2012-06-04 08:56:48 +00:00
Pascal Quantin
ebbaf7f820
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7325 :
...
Add support for the Gluster CLI RPC-protocol
svn path=/trunk/; revision=43055
2012-06-04 08:42:12 +00:00
Chris Maynard
4902b4d857
Remove a few of "if (tree)" checks surrounding expert_add_info_format().
...
svn path=/trunk/; revision=43054
2012-06-04 06:22:50 +00:00
Pascal Quantin
6a4606b1f1
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7324 :
...
Add support for the Gluster Handshake and Callback RPC-protocols
svn path=/trunk/; revision=43035
2012-06-03 17:15:21 +00:00
Pascal Quantin
3201d56f05
Convert space to tab
...
svn path=/trunk/; revision=43033
2012-06-03 16:49:58 +00:00
Alexis La Goutte
6c8174a1a8
Make checkhf tools Happy, Remove hf_ieee80211_chan*
...
svn path=/trunk/; revision=43032
2012-06-03 16:49:01 +00:00
Alexis La Goutte
44d7c7fb73
Add 802.11 AP Channel Report IE (51)
...
svn path=/trunk/; revision=43031
2012-06-03 16:47:15 +00:00
Alexis La Goutte
588fd3e761
Enhance 802.11 Secondary Channel Offset (62)
...
svn path=/trunk/; revision=43030
2012-06-03 16:45:30 +00:00
Alexis La Goutte
9a7409589a
Enhance 802.11 HT Info 1.1 (60)
...
svn path=/trunk/; revision=43029
2012-06-03 16:43:19 +00:00
Alexis La Goutte
7852f04531
Cleanup Header (Remove e-mail of original author to report bugs...)
...
svn path=/trunk/; revision=43028
2012-06-03 16:41:11 +00:00
Alexis La Goutte
8f94d6a813
Enhance 802.11 (Vendor Specific) HT Capability (45)
...
And fix last Dead Store warning found by Clang
svn path=/trunk/; revision=43027
2012-06-03 16:39:55 +00:00
Alexis La Goutte
3899295893
Enhance 802.11 (vendor specifiq) HT Info 1.0 (Draft)
...
svn path=/trunk/; revision=43025
2012-06-03 16:37:56 +00:00
Pascal Quantin
8edc336db6
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7323 :
...
Add support for the Gluster Portmapper and DUMP RPC-protocols
svn path=/trunk/; revision=43024
2012-06-03 16:17:38 +00:00
Pascal Quantin
b3f2c794e2
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7315 :
...
Initial support for the GlusterD RPC-protocol
svn path=/trunk/; revision=43023
2012-06-03 15:52:15 +00:00
Pascal Quantin
aa95f6b73d
Revert files committed by error in revision 43007
...
svn path=/trunk/; revision=43008
2012-06-02 19:20:04 +00:00
Pascal Quantin
797b83c838
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7322 :
...
Add a missing break in packet-bpkmattr.c (CID 280484)
svn path=/trunk/; revision=43007
2012-06-02 19:15:07 +00:00
Anders Broman
96beb44145
From Evan Huus Useless null check in packet-ssh.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7319
...
svn path=/trunk/; revision=42996
2012-06-02 13:25:02 +00:00
Balint Reczey
7ef7aae265
Fix header file includes to allow make dumpabi run without errors
...
svn path=/trunk/; revision=42994
2012-06-02 12:57:26 +00:00
Anders Broman
d4e17555ad
Put more mesage names in info col
...
svn path=/trunk/; revision=42993
2012-06-02 10:11:46 +00:00
Jeff Morriss
d4fdd6ad52
Only propose decoding PPID 0 if that PPID is in the currently-selected frame.
...
(I used PPID 0xffffffff as an end-of-list marker so that PPID can no longer
be used in this dialog; if someone starts using that PPID then we'll have
to put a count of PPIDs in pinfo.)
svn path=/trunk/; revision=42991
2012-06-01 21:18:59 +00:00
Gerald Combs
c408151a80
Try to be a bit more clear that "lost" is from Wireshark's perspective,
...
not necessarily one of the TCP endpoints.
svn path=/trunk/; revision=42990
2012-06-01 20:54:04 +00:00
Pascal Quantin
2256e71cc5
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7316 :
...
Use correct field type for OUI
svn path=/trunk/; revision=42989
2012-06-01 20:32:15 +00:00
Jeff Morriss
e83180023e
Clean up some indentation (get rid of 4-space tabs) and white space.
...
svn path=/trunk/; revision=42988
2012-06-01 19:46:53 +00:00
Jeff Morriss
a2fe7eabbb
Remember the 'lower' UDP port information even if we got the UDP packet
...
non-heuristically. This prevents us from trying to decode the user's UDP
payload as FP.
(This is a followup/revision to r31113/bug 4218.)
svn path=/trunk/; revision=42987
2012-06-01 19:22:01 +00:00
Jeff Morriss
9e3b598e30
Some code/white space cleanup.
...
svn path=/trunk/; revision=42985
2012-06-01 18:35:20 +00:00
Guy Harris
6a43200ee9
Squelch warning about uninitialized variable (the dataflow analysis
...
isn't sophisticated enough to know that can't happen).
svn path=/trunk/; revision=42983
2012-06-01 18:01:42 +00:00
Pascal Quantin
b9917a1248
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7310 :
...
Initial support for the GlusterFS RPC-protocol
svn path=/trunk/; revision=42979
2012-06-01 17:10:03 +00:00
Anders Broman
a8e8234831
Make packet-coseventcomm.c a bultin dissector
...
svn path=/trunk/; revision=42974
2012-06-01 15:57:05 +00:00
Anders Broman
6e3d56f039
For RLC re-assembly to work we need to fake urnti.
...
svn path=/trunk/; revision=42970
2012-06-01 13:01:32 +00:00
Anders Broman
a2f13cad70
Don't call subdissectors if the CRCI bit is set.
...
svn path=/trunk/; revision=42969
2012-06-01 12:28:05 +00:00
Anders Broman
c8625796f1
Make the cosnaming dissector a builtin dissector.
...
svn path=/trunk/; revision=42968
2012-06-01 12:27:04 +00:00
Anders Broman
b42bbc2cd6
Make the tango dissector a builtin dissector.
...
svn path=/trunk/; revision=42967
2012-06-01 10:31:34 +00:00
Anders Broman
5ef6c6d08a
Make the parlay dissector a buil tin dissector.
...
svn path=/trunk/; revision=42964
2012-06-01 08:48:31 +00:00
Anders Broman
728584510b
Fix a couple of warnings
...
svn path=/trunk/; revision=42957
2012-06-01 05:55:20 +00:00
Anders Broman
6a505b4cce
Fix a couple of warnings
...
svn path=/trunk/; revision=42956
2012-06-01 05:36:52 +00:00
Gerald Combs
5690373d48
g_snprintf → ep_strbuf. I can't find an ERF file with a virtual
...
container but the conversion seemed be straightforward enough.
svn path=/trunk/; revision=42951
2012-05-31 21:30:40 +00:00
Pascal Quantin
b83080f5b6
From Erwin Rol via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7311 :
...
Fix a cut and paste error in packet-dmx.c
svn path=/trunk/; revision=42949
2012-05-31 20:40:07 +00:00
Gerald Combs
ae6e4d6dd3
Fix a possible zero division found by scan-build. While we're at it replace
...
occurrences of g_snprintf+strlen with ep_strbuf.
svn path=/trunk/; revision=42948
2012-05-31 20:24:04 +00:00
Anders Broman
b9e5955f46
Set dir if we don't have it.
...
svn path=/trunk/; revision=42945
2012-05-31 13:23:42 +00:00
Pascal Quantin
08c7db0421
Display hf_smb_server_guid, hf_smb_volume_guid and hf_smb_dfs_referral_server_guid as FT_GUID
...
svn path=/trunk/; revision=42944
2012-05-31 13:22:52 +00:00
Pascal Quantin
4d1abc7bbb
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7306 :
...
RPC: show the AUTH_GLUSTERFS/lk_owner as hex
svn path=/trunk/; revision=42940
2012-05-31 08:56:19 +00:00
Pascal Quantin
48fee70339
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7307
...
svn path=/trunk/; revision=42939
2012-05-31 08:25:00 +00:00
Anders Broman
867de6145e
From Sheetal Kshirsagar and Andrew Williams:
...
Updating the RPL SRH dissector and implementing RPL Options header dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6986
svn path=/trunk/; revision=42937
2012-05-31 07:25:11 +00:00
Anders Broman
fc19f32931
Try to squelch a couple of warnings
...
svn path=/trunk/; revision=42936
2012-05-31 05:42:02 +00:00
Jakub Zawadzki
14bfedccd9
Revert r42853, cleanup packet-jxta which might really fix CID 280210
...
References: http://www.wireshark.org/lists/wireshark-dev/201205/msg00226.html
svn path=/trunk/; revision=42932
2012-05-30 22:39:56 +00:00
Jeff Morriss
6341191d72
From Richard Sharpe on -dev:
...
Attached is a patch that fixes (I think) the handling of extended
responses on NTCreate&X requests.
svn path=/trunk/; revision=42923
2012-05-30 18:29:37 +00:00
Pascal Quantin
59b621e67b
Prefix TransportFormatSet_type_enum values with NBAP_ to avoid a clash with 'PCH' in <WinNT.h>
...
svn path=/trunk/; revision=42922
2012-05-30 18:27:40 +00:00
Chris Maynard
b35b911748
Mark pinfo as unused. Change args to proto_tree_add_text().
...
svn path=/trunk/; revision=42921
2012-05-30 17:26:00 +00:00
Chris Maynard
39d4fbeb52
PPP CCP improvements. And yay, checkAPIs no longer complains about the number of useless add_text()'s since the ratio is finally below 50%. This ratio should continue to drop as more and more fields become filterable.
...
svn path=/trunk/; revision=42920
2012-05-30 17:02:44 +00:00
Anders Broman
79e91685b7
Stab at DCH 31 dissection.
...
svn path=/trunk/; revision=42915
2012-05-30 14:04:45 +00:00
Anders Broman
a307c8318d
Dissect non segmented MiB and SiB:s
...
svn path=/trunk/; revision=42914
2012-05-30 11:48:05 +00:00
Pascal Quantin
d9b845534d
Use ett variable for proto_item_add_subtree function call
...
svn path=/trunk/; revision=42913
2012-05-30 08:49:56 +00:00
Jakub Zawadzki
4c3735771a
Fix bug #5077 in IPv6.
...
svn path=/trunk/; revision=42909
2012-05-30 05:39:39 +00:00
Jakub Zawadzki
a2dac52152
Cleanup geoip support in ipv6.
...
svn path=/trunk/; revision=42908
2012-05-30 05:33:37 +00:00
Pascal Quantin
86dd3248f6
Avoid using C99 '%hh' length modifier
...
svn path=/trunk/; revision=42904
2012-05-29 21:51:52 +00:00
Pascal Quantin
3f07cc05bc
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7301 :
...
Dissector for DVB Application Information Table (AIT)
svn path=/trunk/; revision=42903
2012-05-29 21:36:39 +00:00
Pascal Quantin
0e557f4421
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7302 :
...
Small updates to ISO 7816 dissector
svn path=/trunk/; revision=42902
2012-05-29 21:09:46 +00:00
Pascal Quantin
8b72c6506e
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7303
...
Remove unnecessary null checks before calling proto_item_set_len() in DVB-CI dissector
svn path=/trunk/; revision=42901
2012-05-29 20:28:41 +00:00
Jakub Zawadzki
dfa5a78130
Fix bug #7304 , stupid mistake.
...
svn path=/trunk/; revision=42900
2012-05-29 20:27:22 +00:00
Jakub Zawadzki
e5be60bc81
Fix bug #5735
...
dissect_attribute_value_pairs() should be also called with NULL tree.
Broken from r29964.
svn path=/trunk/; revision=42899
2012-05-29 20:01:25 +00:00
Anders Broman
2a7bef2cb0
Handle E-DCH
...
svn path=/trunk/; revision=42898
2012-05-29 14:34:34 +00:00
Ronnie Sahlberg
5f04a8404b
SCSI SBC: Add dissection of GET_LBA_STATUS command
...
svn path=/trunk/; revision=42897
2012-05-29 11:25:38 +00:00
Anders Broman
8d6b6f58d6
From Deepti Ragha:
...
Additions to the ARP dissector as per the IANA specifications for ARP
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7216
svn path=/trunk/; revision=42895
2012-05-29 08:00:35 +00:00
Anders Broman
7aa5527274
From Aditya Ambadkar and Diana Chris:
...
Enhancement to LDP dissector to support changes proposed in RFC6391 - flow aware transport of PW over an MPLS PSN.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7046
svn path=/trunk/; revision=42894
2012-05-29 07:45:40 +00:00
Anders Broman
859f794544
From Evan Huus:
...
Fix to
BACapp item length causes Buildbot crash output: randpkt-2011-04-13-1899.pcap
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5825
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7296
svn path=/trunk/; revision=42893
2012-05-29 07:31:38 +00:00
Guy Harris
1020c20d9e
From Erwin Rol: fix a copy-and-paste leftover.
...
svn path=/trunk/; revision=42890
2012-05-29 00:05:39 +00:00
Pascal Quantin
a891f54067
Keep backward compatibility with UDP framing format for UMTS RLC dissector
...
Fix a few typo errors while we are at it
svn path=/trunk/; revision=42889
2012-05-28 20:34:27 +00:00
Anders Broman
091138dafe
Use C/T as rbid
...
svn path=/trunk/; revision=42888
2012-05-28 20:11:59 +00:00
Anders Broman
1c9920ada6
Use ett instead of hf variable
...
svn path=/trunk/; revision=42887
2012-05-28 20:09:00 +00:00
Anders Broman
b74438e41d
Set but not used variable
...
svn path=/trunk/; revision=42885
2012-05-28 17:55:47 +00:00
Anders Broman
4312a9dd61
Remove C++ style comments initilize some variables.
...
svn path=/trunk/; revision=42884
2012-05-28 16:00:20 +00:00
Jakub Zawadzki
5020a3f170
While iterating over string characters don't use strlen(), but check for NUL.
...
svn path=/trunk/; revision=42883
2012-05-28 15:59:00 +00:00
Anders Broman
bb08a70594
Set SVN properties.
...
svn path=/trunk/; revision=42882
2012-05-28 15:30:09 +00:00
Anders Broman
136ad63adf
Set SVN properties.
...
svn path=/trunk/; revision=42881
2012-05-28 15:29:36 +00:00
Anders Broman
14eb5154ac
From Erwin Rol:
...
Artnet, RDM and DMX dissector updates
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7286
svn path=/trunk/; revision=42880
2012-05-28 15:24:54 +00:00
Anders Broman
55261641d9
Extend the switch statement.
...
svn path=/trunk/; revision=42879
2012-05-28 15:09:33 +00:00
Anders Broman
d52a12c60e
Move defenition of rlc_mode.
...
svn path=/trunk/; revision=42878
2012-05-28 14:50:54 +00:00
Anders Broman
2a412f000b
Try to pacify the Ubuntu buildbot.
...
svn path=/trunk/; revision=42877
2012-05-28 13:53:33 +00:00
Anders Broman
d8ddd39c3d
Enhance CHANNEL_HSDSCH dissection.
...
svn path=/trunk/; revision=42876
2012-05-28 13:38:40 +00:00
Ronnie Sahlberg
4baba1c684
Sometimes you might have plaintext LDAP for a SASL LDAP connection if the handshake never occured.
...
Observed with exchange in some configurations.
From Matthieu Patou <mat@matws.net>
svn path=/trunk/; revision=42875
2012-05-28 09:40:54 +00:00
Gerald Combs
3e24d3bbce
Add a null check to fix Coverity CID 280210. It doesn't look like we'd
...
run into this in the wild.
svn path=/trunk/; revision=42853
2012-05-25 18:25:31 +00:00
Chris Maynard
cd7c8f671b
Fix Coverity CID 700177 Unused pointer value.
...
svn path=/trunk/; revision=42849
2012-05-25 02:51:23 +00:00
Chris Maynard
22415dc211
The rest of the fix for Coverity CID's 280507 and 280508. (There were multiple occurrences grouped into the 2 CID's, but I hadn't noticed them all.)
...
svn path=/trunk/; revision=42848
2012-05-25 02:43:39 +00:00
Chris Maynard
c0b55e486a
tvb_length_remaining() can return a negative number, so be sure to handle it. Fixes Coverity CID's 280507 and 280508.
...
svn path=/trunk/; revision=42847
2012-05-25 02:18:49 +00:00
Chris Maynard
814682d0d8
Fix Coverity CID 701035: Dereference after null check of hfinfo.
...
svn path=/trunk/; revision=42843
2012-05-25 01:14:29 +00:00
Chris Maynard
3445d93bf2
Fix Coverity CID 700201: Dereference after null check, by ensuring "decoder" is not NULL before passing it to ssl_decrypt_record().
...
svn path=/trunk/; revision=42842
2012-05-25 00:54:49 +00:00
Chris Maynard
8fd9342f7d
tvb_length_remaining() can return a negative number, so be sure to handle it. Fixes Coverity CID 281367.
...
svn path=/trunk/; revision=42840
2012-05-25 00:29:46 +00:00
Chris Maynard
0c49176411
tvb_length_remaining() can return a negative number, so be sure to handle it. Fixes Coverity CID's 280233-280235.
...
svn path=/trunk/; revision=42839
2012-05-24 23:35:23 +00:00
Chris Maynard
b7e5cce721
Update asn1-generated dissector.
...
svn path=/trunk/; revision=42838
2012-05-24 23:31:38 +00:00
Chris Maynard
06606bb68f
tvb_reported_length_remaining() can return a negative number. In dissect_gadu_gadu_userlist80_compressed(), bail out if it does. Fixes Coverity CID 703085. In dissect_gadu_gadu_stringz_cp1250(), be sure to compare against its return value as being only positve rather than non-zero. Also, fixed a couple of typos.
...
svn path=/trunk/; revision=42837
2012-05-24 23:14:30 +00:00
Jakub Zawadzki
c09a95a0e3
Fix bug #7283
...
When Engine ID is 128 we should only break when we know the enterprise id.
svn path=/trunk/; revision=42825
2012-05-24 12:26:34 +00:00
Anders Broman
d40cb34ba9
From Martin Kaiser:
...
RVALS() needs BASE_RANGE_STRING
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7282
svn path=/trunk/; revision=42823
2012-05-24 09:17:11 +00:00
Anders Broman
a51cd8a036
From Mayuresh Raut.
...
Addition of DDMAP TLV and Downstream FEC stack change sub-TLV to DDMAP [RFC 6424]
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7006
svn path=/trunk/; revision=42819
2012-05-24 06:55:18 +00:00
Pascal Quantin
25e70c04d7
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7275 :
...
iso7816: dissect ATR (answer to reset)
svn path=/trunk/; revision=42814
2012-05-23 20:51:38 +00:00
Jakub Zawadzki
401dba8987
Fix bug #7277
...
Check tvb length before fetching data.
svn path=/trunk/; revision=42812
2012-05-23 12:20:15 +00:00
Anders Broman
551dcff815
Dissect MAC and RLC for CHANNEL_FACH_FDD
...
svn path=/trunk/; revision=42811
2012-05-23 10:47:52 +00:00
Anders Broman
0832853fa8
From Robert Bullen:
...
The Wireshark and tshark TCP conversations stats tables aggregate reused connections into a single line item
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7248
svn path=/trunk/; revision=42806
2012-05-23 06:36:47 +00:00
Anders Broman
a6deef666c
Fix a typo
...
svn path=/trunk/; revision=42805
2012-05-23 06:26:46 +00:00
Anders Broman
ab58c26ff3
From Jim Wright:
...
Enhance the DTN dissector so that it understands ECOS blocks (Extended Class of Service)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7242
svn path=/trunk/; revision=42804
2012-05-23 06:25:00 +00:00
Bill Meier
8f5f906146
All:
...
- whitespace cleanup;
- Remove redundant code;
packet-ymsg.c:
- Check if bytes available before doing tvb fetch for heuristic check;
- Required tcp pdu "fixed part length" is 10 (not 8);
- Use val_to_str_const() as appropriate;
- Remove some unneeded initializations.
svn path=/trunk/; revision=42802
2012-05-23 03:26:35 +00:00
Bill Meier
e72c6574ef
From Evan Huus: "Fix Potential padding issues in Yahoo dissectors"
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7276
svn path=/trunk/; revision=42801
2012-05-23 03:22:51 +00:00
Chris Maynard
509917229b
Fix Coverity CID 703086: Dereference after null check in decode_tcp_ports().
...
svn path=/trunk/; revision=42798
2012-05-23 00:56:15 +00:00
Jeff Morriss
a59aa64da4
Fix: packet-gsm_a_gm.c:3965:6: error: comparison is always true due to limited range of data type [-Werror=type-limits]
...
svn path=/trunk/; revision=42797
2012-05-22 23:59:41 +00:00
Guy Harris
dba158c167
Suppress a (legitimate) compiler warning for now, and leave a comment
...
indicating that we should do *something* about nanoseconds values >= 1
billion.
svn path=/trunk/; revision=42796
2012-05-22 23:57:54 +00:00
Jakub Zawadzki
261fb63ec4
nflog dissector:
...
- dissect NFULA_TIMESTAMP as 16B time.
- fix byte_order_types (selecting BE selected little endian)
svn path=/trunk/; revision=42793
2012-05-22 22:34:57 +00:00
Anders Broman
4e7d87caa2
Fix PCH dissection
...
svn path=/trunk/; revision=42791
2012-05-22 21:12:59 +00:00
pascal
9746c22630
Dissect Operator Specific Use container in Protocol Configuration Options IE
...
Put protocol and container ID in a subtree
svn path=/trunk/; revision=42790
2012-05-22 20:34:20 +00:00
Anders Broman
e460267b82
Set paging indication and start fixing TFI list.
...
svn path=/trunk/; revision=42783
2012-05-22 15:39:12 +00:00
Jeff Morriss
913455d3b3
Get rid of non-ASCII chars. Remove a few trailing commas.
...
svn path=/trunk/; revision=42782
2012-05-22 14:00:19 +00:00
Anders Broman
ec5ec34f1f
Collect and use E-DCH data.
...
svn path=/trunk/; revision=42779
2012-05-22 11:53:12 +00:00
Ronnie Sahlberg
2a2dc8c5f3
TCP: Some protocols running ontop of TCP needs the PDUs to be delivered in order. for example decryption of DCERPCoverHTTP.
...
For such protocols, hte state gets out of sync of for example the same PDU is invoked twice in a row, which sometimes can happen if there is tcp retransmission and we see the same PDU twice. First for hte original segment and a second time for the tcp retransmission.
These protocols might lack an easy way to detect that a PDU is seen twice or out of order.
To handle this a little better, offer a TCP option that defaults to being disabled but when enabled skips invoking any subdissector for retransmitted or out of order packets.
(For some virtualization environments it sometimes becomes VERY common to see false tcp retransmissions due to segments being captured twice making this even worse)
We dont want this option to default to ON because for most cases we do want the current behaviour where the subdissector is called twice, or more, for any PDU that is retrasnmitted on the TPC layer.
For example, assume a SMB response packet is retransmitted on the TCP level.
This may result in a capture file that looks like
1 -> SMB request
2 <- SMB response to 1
... 1 second ...
3 <- SMB response to 1 TCP retransmission
For this case we definitely want packet 3 to be passed to the SMB layer so that
the request/respons ematching will detect that the response time for this transaction was > 1.0 second
We want smb.time to indicate the delta betwenn packets 1 and 3
as well as the SMB Service Response Time to indicate that this command took very long.
svn path=/trunk/; revision=42774
2012-05-22 07:51:12 +00:00
Ronnie Sahlberg
b3bfefd03c
packet-smb2: dissect the channel sequence in the SMB 2.2 header
...
From Stefan Metzmacher <metze@samba.org>
svn path=/trunk/; revision=42772
2012-05-22 05:56:39 +00:00
Ronnie Sahlberg
ba54127556
SMB: Add dissection of TRANS2_REQUEST_TRANSPORT_ENCRYPTION messages
...
From Stefan Metzmacher <metze@samba.org>
svn path=/trunk/; revision=42771
2012-05-22 05:55:05 +00:00
Ronnie Sahlberg
50b992d139
SMB: Dissect TRANS2_SET_FS_INFORMATION infolevel
...
From Stefan Metzmacher <metze@samba.org>
svn path=/trunk/; revision=42770
2012-05-22 05:53:28 +00:00
Ronnie Sahlberg
920b760f15
SMB: Call dissect_nt_quota() via a new dissect_sfsi_request/response()
...
From Stefan Metzmacher <metze@samba.org>
svn path=/trunk/; revision=42769
2012-05-22 05:51:16 +00:00
Ronnie Sahlberg
4ded3c7fe0
SMB2: Add dissection of the encrypted SMB2 headers
...
From Matthieu Patou <mat@matws.net>
svn path=/trunk/; revision=42768
2012-05-22 05:48:55 +00:00
Ronnie Sahlberg
cf0a6d0b96
SMB2: Add support for the "encrypted" flag for shares
...
From Michael Adam <obnox@samba.org>
svn path=/trunk/; revision=42767
2012-05-22 05:46:47 +00:00
Ronnie Sahlberg
0882a858c4
SMB2: Fix, the flag is called PERSISTENT_HANDLES, not LARGE_MTU
...
From Michael Adam <obnox@samba.org>
svn path=/trunk/; revision=42766
2012-05-22 05:45:30 +00:00