I don't understand the relationship between the "frame data" and the "conversation" (to me they seem independent, but the code seems to put them together), but at least this fixes the crash
svn path=/trunk/; revision=43985
- FP: added payload CRC validation, RLC: some more error reporting
- RLC: fixed an exotic LI bug, some cosmetic fixes.
svn path=/trunk/; revision=43983
- prevent potential array overflow: do some bounds checking;
- use emem_strbuf instead of buffers on the stack;
- check_col() not required;
- simplify code in several places;
- remove some boilerplate comments;
- ...
svn path=/trunk/; revision=43970
don't simply assume the PAT continues until the end of the input tvb
this is similar to packet_dvb_ait.c
I'll change this for other tables shortly
svn path=/trunk/; revision=43969
- Added support for EDCH type 2 MAC-is reassembly and slightly improved RLC error reporting
- RLC: fixed bug where complete sequences in the end of a trace where not reassembled
svn path=/trunk/; revision=43954
printable. If binary, just show the number of bytes in summary.
Not that there are no items inside it, don't create ftp-data as a tree.
Also, fix the type of the variable 'ti'.
svn path=/trunk/; revision=43929
freeing them. This was slow and leaked gobs of memory.
Be like XML: allocate one parser during set-up and share it around.
svn path=/trunk/; revision=43920
*very* slow (in a profiled run where FTP data is carried over LTE
MAC/RLC/PDCP/IP/TCP, this one function call was 20% of overall runtime).
Have limited to call to ITEM_LABEL_LENGTH, as that is all that
will be displayed anyway. As per comment, I'm not convinced that doing
this for binary FTP data segments is worthwhile at all. It doesn't
even display as hex.
svn path=/trunk/; revision=43908
packet-sdp.c:
Init 'proto_sprt' in proto_reg_handof..()
[instead of using a registered init fcn];
packet-sprt.c:
Fix some typos;
Comment out dissect_sprt_heur() since it doesn't
really do any dissection. Add an XXX comment re same.
packet-v150fw.c:
Remove unused 'v150fw_handle' and thus unneeded proto_reg_handoff...();
Add an XXX comment re the (commented out) dissect_v150fw() not actually
doing any dissection.
svn path=/trunk/; revision=43902
We have to divide the 'length' field to work with guint32 pointer arithmetic,
but we still want to allocate and memcpy the original length value, since
both of those operate in raw bytes, not blocks of sizeof(guint32).
svn path=/trunk/; revision=43901
trying to track sessions for iq, jabber, et al. Just return, so we can
dissect whatever attributes we can find. An expert info already gets added
later on.
The other part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7509
svn path=/trunk/; revision=43899
Convert "4 space tabs" to spaces;
Remove trailing whitespace;
Change hf[] entry blurbs from "" to NULL;
Add svn:id and svn:eol-style properties.
svn path=/trunk/; revision=43892
I'm not exactly sure what's up with the v150fw dissector, since
it defines a heuristic which is never used and registers in no tables.
The comments indicate it's carried over rtp, but rtp doesn't have a
heuristic table. Revision 43887 caused rtp to load a handle to v150fw,
but I've done a quick scan and I don't think it ever actually does anything
with the handle.
For now, #if 0 out the heuristic function to avoid compile errors. A better
fix is needed though.
svn path=/trunk/; revision=43890
to a pointer to a guint32 and dereferenced. On some platforms, such as
SPARC, this requires that the pointer be aligned on a 4-byte boundary;
there is no guarantee that the data field of an address structure is
aligned on a 4-byte boundary, so allocate a buffer for a copy of that
data and copy the data into it, and free it when we're done with it.
Should fix bug 7501.
svn path=/trunk/; revision=43880
Attached is a patch which corrects the string construction issue in the
PropertyStates method. This patch also corrects a spelling error for
'utcTimeSyncronization' and adds decode support for this property.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6475#c8
svn path=/trunk/; revision=43868
Bill Meier