3dc1e2df63
Update AVP dissection.
...
svn path=/trunk/; revision=43625
2012-07-09 14:10:40 +00:00
eedc186e94
Dissect Release 8 CDR:s
...
svn path=/trunk/; revision=43624
2012-07-09 14:09:59 +00:00
3be39a23aa
From Evan Huus: Struct cleanup in packet-assa_r3.c
...
Cleanup and simplify structures and arrays in packet-assa_r3.c as described in
my email to the -dev list [1].
[1] http://www.wireshark.org/lists/wireshark-dev/201207/msg00050.html
From me:
Do the same as above for the commandDissectorParser_t struct mentioned in the EMail
(but not fixed in the patch).
svn path=/trunk/; revision=43623
2012-07-09 03:00:03 +00:00
f207987aa3
From Martin Kaiser:
...
DVB-CI/CI+: dissect the payload of LSC messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7440
svn path=/trunk/; revision=43620
2012-07-09 02:28:14 +00:00
1ae38887b6
From Evan Huus:
...
Grab-bag of unused variables.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7452
svn path=/trunk/; revision=43616
2012-07-09 01:49:02 +00:00
0cb874b9ec
Add a function to packet-giop.c that does what the code that
...
template_get_CDR_string (in wireshark_gen.py) did. This eliminates another
whole pile of function-local variables in packet-parlay.c.
Unfortunately it doesn't seem to speed up compilation (or eliminate the
variable tracking size limit problem). But it does eliminate a lot of
lines of code...
svn path=/trunk/; revision=43610
2012-07-08 03:57:35 +00:00
a2c4716670
Eliminate a lot of function-local variables by not storing the result of
...
(several of the) get_CDR_*() functions: instead call the function directly
in the proto_tree_add_text() calls.
Eliminate a lot of global variables that are only later used in (a single)
strcmp().
All the GIOP dissectors are built-in now; don't include the (#if'd out) plugin
registration code in the generated dissector.
Try to clean up the formatting of the generated code a bit.
Regenerate the IDL dissectors; as noted in r39932, this seems to involve a
lot of function re-ordering in packet-parlay.c (making the delta bigger).
These changes decrease the time to compile packet-parlay.c by, on my system,
about half. But it still complains:
variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
and it still takes "too long."
svn path=/trunk/; revision=43609
2012-07-08 03:29:49 +00:00
659cf0527a
UATs could be put into "categories". The categories were defined only
...
implicitly by the #define name and string they were defined to; not all
UATs neatly fit into any of the categories, so some of them were put
into categories that weren't obviously correct for them, and one - the
display filter macro UAT - wasn't put into any category at all (which
caused crashes when editing them, as the GUI code that handled UAT
changes from a dialog assumed the category field was non-null).
The category was, in practice, used only to decide, in the
aforementioned GUI code, whether the packet summary pane needed to be
updated or not. It also offered no option of "don't update the packet
summary pane *and* don't redissect anything", which is what would be
appropriate for the display filter macro UAT.
Replace the category with a set of fields indicating what the UAT
affects; we currently offer "dissection", which applies to most UATs
(any UAT in libwireshark presumably affects dissection at a minimum) and
"the set of named fields that exist". Changing any UAT that affects
dissection requires a redissection; changing any UAT that affects the
set of named fields that exist requires a redissection *and* rebuilding
the packet summary pane.
Perhaps we also need "filtering", so that if you change a display filter
macro, we re-filter, in case the display is currently filtered with a
display filter that uses a macro that changed.
svn path=/trunk/; revision=43603
2012-07-08 01:00:46 +00:00
9e7c7e7d10
From Evan Huus: Fix "Useless null checks in packet-dcerpc*"
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7448
svn path=/trunk/; revision=43599
2012-07-07 14:21:20 +00:00
9315a45deb
From Evan Huus: fix "Unused variable in packet-ansi_a.c"
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7447
svn path=/trunk/; revision=43598
2012-07-07 14:11:38 +00:00
dd105b80d8
Display (and allow filtering on) the "reserved for national use" bit in the AI.
...
(This bit is already decoded as the "national indicator" bit in ANSI.)
svn path=/trunk/; revision=43590
2012-07-06 21:25:47 +00:00
a898b392e2
Gadu-Gadu: dissect more packets.
...
svn path=/trunk/; revision=43589
2012-07-06 21:24:16 +00:00
41e5166f81
Add a few missing ENC_ASCII and remove a few unused hf entries
...
svn path=/trunk/; revision=43581
2012-07-06 05:33:55 +00:00
0bcc9b0e66
From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407 :
...
Update ESTA manufacturer IDs and OEM code values
svn path=/trunk/; revision=43580
2012-07-06 05:17:09 +00:00
217514e565
Remove a couple set-but-unused variables. I *think* the new tree isn't
...
particularly useful...
svn path=/trunk/; revision=43577
2012-07-05 23:31:17 +00:00
c7dbc44bf3
Fix bug #7436
...
offset returned from dissect_nfs_open_claim4, dissect_nfs_openflag4 were different
when we were building tree and where we didn't.
Fix other similar cases.
svn path=/trunk/; revision=43576
2012-07-05 21:09:34 +00:00
a9b2a718a7
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7437 :
...
PTP Cancel unicast transmission and Acknowledge cancel unicast transmission packets are decoded as malformed
svn path=/trunk/; revision=43575
2012-07-05 20:07:43 +00:00
889ddbd9eb
Fix compilation with gcc 4.3.2
...
svn path=/trunk/; revision=43572
2012-07-05 09:02:08 +00:00
a7fef5b3bf
Upgrade LTE RRC dissector to v10.6.0
...
svn path=/trunk/; revision=43571
2012-07-05 08:44:30 +00:00
d94492cc71
From Richard Sharpe via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7428 :
...
Add SPNEGO Extended Negotiation (NEGOEX) Security Mechanism dissector
svn path=/trunk/; revision=43569
2012-07-05 05:26:28 +00:00
c02d156881
The amqp dissector is not a plugin; remove comment indicating that it's a plugin.
...
Also: Fix some "4 space tab" indentation (replace with spaces).
svn path=/trunk/; revision=43566
2012-07-04 13:04:16 +00:00
c529c306d4
From Evan Huus via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7433 :
...
Remove unused mask variable in packet-bmc.c
svn path=/trunk/; revision=43565
2012-07-04 10:08:22 +00:00
a24fa25716
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7430 :
...
Dissection of EAP-SIM and EAP-AKA is broken
svn path=/trunk/; revision=43560
2012-07-03 20:07:53 +00:00
234cd599b3
Remove a leftover // "comment to self" (fixes checkAPI error).
...
svn path=/trunk/; revision=43559
2012-07-03 19:47:54 +00:00
7882ec57c3
Improve use of the value_string x11_keysym_vals_source[]:
...
- Compile the value_string only as part of packet-x11.c
- Create a value_string_ext to ref the value_string;
- packet_vnc.c: Access the value_string using the value_string_ext;
- packet-x11.c: Access the value-string using the value_string_ext
rather then building a temp GTree from the value_string.
svn path=/trunk/; revision=43558
2012-07-03 18:49:12 +00:00
a16c3e2692
From report of Dennis Mendoza via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7429
...
Wireshark > 1.4 does not correctly read Association ID for PS Poll packets
Wireless Frame with subtype 0x1a don't interpret the Association ID (always 0).
Fix :
proto_tree_add_uint() wasn't changed to proto_tree_add_item()
#BACKPORT
svn path=/trunk/; revision=43556
2012-07-03 12:28:06 +00:00
d25ae90a67
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7420 :
...
CI/CI+: dissect CICAM NIT
svn path=/trunk/; revision=43546
2012-06-29 20:10:25 +00:00
e083f0f71e
Try to fix win64 buildbot.
...
packet-dbus.c(354) : error C2220: warning treated as error - no 'object' file generated
packet-dbus.c(354) : warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data
svn path=/trunk/; revision=43543
2012-06-29 17:44:48 +00:00
33bfa85452
Initial support for D-Bus dissection (bug #5502 )
...
svn path=/trunk/; revision=43542
2012-06-29 15:23:21 +00:00
163ca72bab
From Роман Донченко: "Adaptation" misspelled as "adaption"
...
In MPEG-related dissectors, "adaption" is used instead of "adaptation" several
times. See patch (it also fixes an unrelated typo that happens to be on the
same line).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7421
svn path=/trunk/; revision=43539
2012-06-29 01:55:05 +00:00
b18e880040
Update FSF address - part II.
...
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
698337ee9a
Prettify display of O_RDONLY and O_ACCMODE flags
...
svn path=/trunk/; revision=43510
2012-06-27 14:57:58 +00:00
fca94d1d2d
From Martin Raison via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7414
...
PMIPV6 support over IPV4 network
PMIPv6 is an extension of MIPv6, adding a certain number of options to the
MIPv6 protocol. These options are already implemented in the wireshark
dissector, and the MIPv6 headers are recognized, but only inside IPv6 packets.
However, RFC5844 extends the PMIPv6 protocol to make it work over IPv4 networks
: as explained in section 4 of this RFC, the MIPv6 message is carried inside an
IPv4 packet with a UDP header. The port number in the UDP header is 5436
svn path=/trunk/; revision=43505
2012-06-27 13:27:28 +00:00
e3b8929a46
General cleanup:
...
- Remove _U_ when function arg is actually used;
- Use consistent formatting and whitespace style.
svn path=/trunk/; revision=43500
2012-06-26 21:45:06 +00:00
f7d834b564
Validate 'offset' before calling proto_item_set_end(); prevents potential 'Dissector Bug' msg
...
Addresses comment in Bug #7390 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7390#c1
svn path=/trunk/; revision=43496
2012-06-26 16:06:26 +00:00
5efda930a6
From Richard Sharpe:
...
I noticed some inconsistencies in the command naming. The following
patch fixes those (so that they now match between SMB and SMB2):
svn path=/trunk/; revision=43495
2012-06-26 13:02:13 +00:00
289707eccc
From Michal Labedzki:
...
RFCOMM-Add-Version-and-DecodeBy-preferences
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6567
svn path=/trunk/; revision=43491
2012-06-25 23:17:12 +00:00
bdb1eb55e9
From Michal Labedzki:
...
RFCOMM-Cosmetic-fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6567
svn path=/trunk/; revision=43490
2012-06-25 23:10:01 +00:00
b8b2d513f6
From Michal Labedzki:
...
BT: Expose RFCOMM Channel instead of DLCI
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6567
svn path=/trunk/; revision=43489
2012-06-25 22:48:11 +00:00
b160466dd2
From Martin Kaiser:
...
add X.509 certificate extensions for DVB-CI/CI+
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7397
svn path=/trunk/; revision=43485
2012-06-25 21:16:43 +00:00
9b21bf229f
Tighten up validity checking when doing reassembly.
...
Fixes Bug #7390 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7390
(Esentially: Do proper validity checking to prevent a "Dissector Bug" exception;
throw a BoundsError exception instead).
svn path=/trunk/; revision=43483
2012-06-25 20:43:54 +00:00
053707aef8
Fix dissection of NAS EPS Service Request message (broken in r42200)
...
svn path=/trunk/; revision=43474
2012-06-25 11:12:54 +00:00
2d5792d19b
Fix typo errors
...
svn path=/trunk/; revision=43473
2012-06-25 10:16:15 +00:00
342812d0ee
From Yair:
...
1. OAM cells are not automatically detected if the AAL type passed is
AAL_UNKNOWN.
2. CRC10 calculation does not take into account the "crc_stripped" option, and
uses a hardcoded offset of 5 bytes into the cell.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7385
svn path=/trunk/; revision=43471
2012-06-24 23:56:27 +00:00
753d90e57e
From Martin Kaiser:
...
add oid for sha256.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7395
svn path=/trunk/; revision=43469
2012-06-24 23:52:24 +00:00
a2a9d5757a
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7386 :
...
Fix dissection of Packet Receipt Times Report Block
svn path=/trunk/; revision=43467
2012-06-24 21:26:40 +00:00
a0e2ba5eb0
FT_FLOAT and FT_DOUBLE share the same comparison functions -> use same filter name
...
svn path=/trunk/; revision=43460
2012-06-24 17:41:18 +00:00
9adf66b3fb
From Adam Langley:
...
Decrypt resumed, SSL sessions from keylog file-
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7396
svn path=/trunk/; revision=43458
2012-06-24 15:24:59 +00:00
fb0a2f3031
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43451
2012-06-23 15:45:01 +00:00
4a6244d1fa
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43450
2012-06-23 15:27:51 +00:00
3ceda0e1c4
Rename two entries to avoid having same filter name for entries with incompatible types
...
svn path=/trunk/; revision=43449
2012-06-23 15:04:13 +00:00
472f036552
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43448
2012-06-23 14:36:21 +00:00
e68222ebfd
Fix copy/paste errors
...
svn path=/trunk/; revision=43447
2012-06-23 14:11:06 +00:00
8c91a5ab0b
Do not use same name for filters with incompatible types
...
svn path=/trunk/; revision=43446
2012-06-23 14:10:19 +00:00
10f6bcc140
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7391 :
...
Do not use same name for filters with incompatible types
svn path=/trunk/; revision=43443
2012-06-22 20:44:52 +00:00
a66eee919e
Mark a couple more variables volatile.
...
svn path=/trunk/; revision=43437
2012-06-21 21:19:48 +00:00
7a18a5e7b9
From Richard Sharpe via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7387 :
...
Don't break/return out of a TRY/CATCH.
svn path=/trunk/; revision=43434
2012-06-21 19:32:56 +00:00
fe3c093534
Fix compilation with gcc...
...
svn path=/trunk/; revision=43409
2012-06-20 13:42:17 +00:00
29fb9f460b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7383 :
...
Put back items into the correct dtap_tree tree and comment pd_tree that is unused for now
svn path=/trunk/; revision=43408
2012-06-20 13:37:22 +00:00
96a3da3e05
Use separate filters for the RTT found on a SACK and the RTT found on a
...
DATA chunk: having them in both places is helpful when looking at the
messages but having them separate is helpful when graphing the RTTs.
svn path=/trunk/; revision=43406
2012-06-20 13:30:07 +00:00
1f96f7105e
Revert http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=43404 .
...
(Needs rethinking).
svn path=/trunk/; revision=43405
2012-06-20 11:44:28 +00:00
21e86b9d4d
SDP data embeded in OCTET STRING.
...
svn path=/trunk/; revision=43404
2012-06-20 10:48:00 +00:00
3cdd0278aa
Add a link to IANA registry.
...
svn path=/trunk/; revision=43403
2012-06-20 10:47:18 +00:00
3b24901e53
Upadte e-mail.
...
svn path=/trunk/; revision=43402
2012-06-20 10:46:38 +00:00
4cc3cae627
- In INTERNAL HANDOVER COMMAND Circuit Identity Code is C(Coded optional in WS)
...
- be_speech_codec ( 3.2.2.104 Speech Codec) did not cover all codecs.
svn path=/trunk/; revision=43401
2012-06-20 07:59:20 +00:00
030a76319c
Correct the IPv6 fragment offset shown in COL_INFO.
...
Make some Fragment header fields filterable (add_text() -> add_item()).
Display (and make filterable) the reserved octet and bits.
svn path=/trunk/; revision=43389
2012-06-19 20:20:18 +00:00
760559b957
Simplify proto_tree_add_string_format_value(..., val, "%s", val) with proto_tree_add_string.
...
hash is 16-bytes hex dump (ASCII!). No need to use proto_tree_add_string_format_value().
svn path=/trunk/; revision=43386
2012-06-19 19:50:43 +00:00
fe8280ce5e
Use tvb_get_ephemeral_string_enc() in combination with proto_tree_add_unicode_string() (as recommended by Jakub on the mailing list)
...
svn path=/trunk/; revision=43385
2012-06-19 19:25:01 +00:00
6356f914c4
Use newly introduced proto_tree_add_unicode_string() to add UTF-8 strings
...
svn path=/trunk/; revision=43379
2012-06-19 18:21:53 +00:00
adb2a47a58
Mark another variable as volatile to pacify the buildbot.
...
svn path=/trunk/; revision=43376
2012-06-19 17:29:56 +00:00
7364abf0bc
Typo
...
svn path=/trunk/; revision=43365
2012-06-19 14:46:21 +00:00
85aad38347
Add proto_tree_add_unicode_string() to add UTF-8 string to tree.
...
Convert some proto_tree_add_string_format_value(..., val, "%s", val); to use new function.
svn path=/trunk/; revision=43363
2012-06-19 14:32:24 +00:00
7c59ac0280
Fix bug #7378 : Wireshark 1.8.0rc1: gsm_a_dtap SMS 7-bit default alphabet regression w.r.t. 1.6.8
...
proto_item_add_string() can be only used with ASCII strings.
svn path=/trunk/; revision=43362
2012-06-19 14:25:50 +00:00
f39c0913ed
Mark some variables as volatile to avoid compiler warnings.
...
svn path=/trunk/; revision=43357
2012-06-19 13:24:43 +00:00
f0f3e36bda
Try to fix unused variable warnings and "clobbered by 'longjmp' or 'vfork' "
...
svn path=/trunk/; revision=43355
2012-06-19 12:44:13 +00:00
9ee8562c32
From Richard Sharpe:
...
Wireshark is unable to dissect Security Descriptors that span TCP segments where some are not captured or reassembled
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7363
svn path=/trunk/; revision=43352
2012-06-19 10:30:51 +00:00
86a888bc0d
Set save_fragmented at the beginning of the routine, so it can always be
...
used at the end to restore pinfo->fragmented.
svn path=/trunk/; revision=43350
2012-06-19 08:24:23 +00:00
98c0e827d0
In dissect_nt_transaction_request(), restore pinfo->fragmented before
...
returning.
svn path=/trunk/; revision=43348
2012-06-19 08:09:28 +00:00
99e919bf8b
From Richard Sharpe:
...
packet-smb.c does not properly handle NT TRANSACT requests (and probably TRANSACT and TRANSACT2 requests)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7351
svn path=/trunk/; revision=43347
2012-06-19 06:24:30 +00:00
24d2178eb7
From Sandeep Dahiya.
...
Add support for Gigamon timestamp trailer (different from existing Gigamon header format).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7365
svn path=/trunk/; revision=43346
2012-06-19 06:18:30 +00:00
0bf0ece483
Integrate r43221 and 43222 with 43211. (Revert back to having only
...
dscp_vals_ext.)
svn path=/trunk/; revision=43335
2012-06-18 17:23:10 +00:00
4945ce61ef
Fix a null pointer warning from Clang. Not sure if we'll run into this
...
in practice.
svn path=/trunk/; revision=43334
2012-06-18 17:09:54 +00:00
697cc92c86
Use enums instead of hand written values
...
svn path=/trunk/; revision=43333
2012-06-18 16:53:24 +00:00
7351065ccd
From Sven Eckelmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7375 :
...
Add support for not_best_next_hop flag in B.A.T.M.A.N. Advanced v14
svn path=/trunk/; revision=43332
2012-06-18 09:17:58 +00:00
d9d97cb7ce
Fix typos.
...
svn path=/trunk/; revision=43320
2012-06-17 20:07:32 +00:00
28e925a381
Allow future forward compatibility
...
svn path=/trunk/; revision=43312
2012-06-17 16:08:43 +00:00
3bbb0d3bc6
Enhance dissection of the NewSessionTicket handshake message.
...
svn path=/trunk/; revision=43304
2012-06-17 11:30:25 +00:00
e058a65c17
Fix reading back exported SSL keys. Bug was introduced in r43097.
...
svn path=/trunk/; revision=43303
2012-06-17 09:02:04 +00:00
02b7064a87
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7372 :
...
tcap.otid and tcap.dtid can be used as display filters
svn path=/trunk/; revision=43288
2012-06-16 19:13:48 +00:00
d57552df5d
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7371 :
...
Add dissection of Release 8 or higher P-GW QoS profile
svn path=/trunk/; revision=43280
2012-06-16 13:09:51 +00:00
1463b2b0c8
Minor cleanup:
...
- Use _U_ on a fcn parameter so can remove "prevent compiler warning" line of useless code;
- indentation
- ...
svn path=/trunk/; revision=43273
2012-06-15 15:49:05 +00:00
a9690db5a3
Minor Changes:
...
- checkcol() not needed;
- remove unneeded #include <expert.h>
- remove 'if(tree)' so "bytes dissected" returned always the same.
svn path=/trunk/; revision=43272
2012-06-15 15:15:48 +00:00
cf28e12ed7
Correct a discrepancy in the specification.
...
svn path=/trunk/; revision=43270
2012-06-15 11:23:40 +00:00
0acb6e6f34
Fix Coverity CID 703858: Unused pointer value.
...
svn path=/trunk/; revision=43268
2012-06-14 23:56:59 +00:00
718a61d6f4
Fix Coverity CID 703859: Unused pointer value.
...
Fix Coverity CID 703860: Unused pointer value.
svn path=/trunk/; revision=43267
2012-06-14 23:39:44 +00:00
17da162356
Try to fix a couple of warnings.
...
svn path=/trunk/; revision=43259
2012-06-14 15:50:24 +00:00
2d4d566636
Add dissection of utra-BCCH-Container-r10
...
svn path=/trunk/; revision=43257
2012-06-14 10:43:54 +00:00
d4aaeccac7
Pretify columns.
...
svn path=/trunk/; revision=43256
2012-06-14 08:44:45 +00:00
41b3988bbd
Fix function name (it is an Authentication failure, not an Attach failure)
...
svn path=/trunk/; revision=43255
2012-06-14 07:25:53 +00:00
3c20eeb452
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7368 :
...
Identity request, Identity response and Authentication failure message dissection are swapped
svn path=/trunk/; revision=43253
2012-06-14 07:14:59 +00:00
b9debc4467
Use value_string_ext for arrays with more than 15 entries
...
svn path=/trunk/; revision=43243
2012-06-13 22:02:12 +00:00
96231f396a
Use value_string_ext for arrays with more than 15 entries
...
svn path=/trunk/; revision=43241
2012-06-13 21:05:10 +00:00
75972ddcd9
Mark a couple of parameters as unused.
...
svn path=/trunk/; revision=43235
2012-06-13 17:25:16 +00:00
d2d882e4b1
From Michael Mann:
...
length bugfix + proto_tree_add_text() cleanup
Fixed the Web-Cache Identity Info dissection. Also converted many of the
proto_tree_add_text() to "more filterable" APIs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5141
svn path=/trunk/; revision=43231
2012-06-13 15:27:41 +00:00
f00c8309af
From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3317
...
Add SSL/TLS support to the POP dissector (functionality copied from the
SMTP dissector).
svn path=/trunk/; revision=43230
2012-06-13 14:56:33 +00:00
4fdc3c3cc2
Create, and start using, file name preferences.
...
File name preferences are basically just string preferences except that the
GUI will present a "Browse" button that allows the user to go and find the
file s/he wants (rather than having to blindly type in the full path).
svn path=/trunk/; revision=43228
2012-06-13 01:13:12 +00:00
f0a74f3a5c
Upgrade GSM BSSMAP dissection to Release 9 (V9.8.0)
...
svn path=/trunk/; revision=43227
2012-06-12 21:36:55 +00:00
1b17369504
Fix: code under 'if(tree)' (in)directly calls sub-dissector/col_...()/expert...() fcns
...
svn path=/trunk/; revision=43226
2012-06-12 21:22:46 +00:00
f679b89649
Revert r41952
...
BACKPORT to 1.8
svn path=/trunk/; revision=43222
2012-06-12 10:44:57 +00:00
9228ece476
Manually revert r41953
...
BACKPORT to 1.8
svn path=/trunk/; revision=43221
2012-06-12 10:38:22 +00:00
4f47eefa79
Fix bugs and other issues:
...
- remove 'if (tree)' around code which (eventually) calls col_...() functions;
- remove unneeded check_col() usage;
- use extended value-strings where appropriate;
- use col_set_str() instead of col_add_fstr();
- fix mismatch between proto_tree_add_item() size arg and the FT type in the
referenced hf[] entry (in a few cases);
- FT_STRING fields should have ENC_ASCII|ENC_NA as the 'encoding' arg
in the corresponding proto_tree_add_item() call;
- do whitespace cleanup.
Note: 1 issue remains:
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260#c12
svn path=/trunk/; revision=43217
2012-06-11 20:51:47 +00:00
bdebbb9bdf
Re-order 2 value_string arrays so that entries are in ascending order by value.
...
svn path=/trunk/; revision=43216
2012-06-11 20:35:00 +00:00
aa0ebee47c
From Alexander via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7361 :
...
Add BSS supported Codec list dissection to Assigment Complete message
svn path=/trunk/; revision=43215
2012-06-11 20:28:31 +00:00
653f74bfcf
From Alexander via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7360 :
...
Service handover IE is not correctly dissected
svn path=/trunk/; revision=43214
2012-06-11 20:12:17 +00:00
5e3066f006
Use dscp_vals_ext everyplace (instead of dscp_vals);
...
(dscp_vals is now a static array in packet-ip.c)
svn path=/trunk/; revision=43211
2012-06-11 19:07:53 +00:00
70cc6362fe
Don't define value_string arrays in a .h file (included in multiple places).
...
Also:
- don't use val_to_str_const() with a "format" default string;
- rename 'opt_len_type' enumeration identifiers to be less generic.
svn path=/trunk/; revision=43210
2012-06-11 18:47:42 +00:00
afab63c34c
Fix another compiler warning
...
svn path=/trunk/; revision=43209
2012-06-11 16:53:49 +00:00
332f743f6c
Fix a compiler warning
...
svn path=/trunk/; revision=43208
2012-06-11 16:44:42 +00:00
8469651f54
General cleanup:
...
- remove some redundant code;
- use ep_strdup_printf() instead of g_snprintf() to a static buffer;
- create and use extended-value-strings as appropriate;
- define a value_string array as static (not as an automatic);
- use val_to_str_const() instead of val_to_str() as appropriate;
- reformat hf[] array entries;
- do general formatting cleanup;
- do whitespace cleanup (e.g., indentation & 4-space tabs).
svn path=/trunk/; revision=43207
2012-06-11 16:33:56 +00:00
df07bfeba4
Create dscp_vals_ext value_str_ext (based upon dscp_vals); Use it as appropriate.
...
Also:
- use val_to_str_const() [instead of val_to_str()] in a few cases;
- do some trivial formatting cleanup.
svn path=/trunk/; revision=43204
2012-06-11 15:47:50 +00:00
a923c28ede
Use restricted character string decoding for IA5String type
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6246
svn path=/trunk/; revision=43203
2012-06-11 13:54:06 +00:00
4f2c3a8e86
len is no longer used.
...
svn path=/trunk/; revision=43200
2012-06-11 08:07:48 +00:00
8456dcbceb
From Michael Mann:
...
Implemented RFC 4954 within the SMTP dissector. On principle, the decryption
is disabled by default (making this feature not obviously present). However I
don't think there will ever be enough data that the performance would be an
issue if the default was changed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7349
svn path=/trunk/; revision=43197
2012-06-11 07:10:18 +00:00
34cb6f96d3
From Michael Mann:
...
NUL terminate the decoded string.
Updated only dissector that uses epan_base64_decode() (packet-http.c) to assume
NULL termination.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7349
svn path=/trunk/; revision=43196
2012-06-11 07:09:11 +00:00
7b94cadffd
From Evan Huus: Missing breaks in packet-rsvp.c
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7353
svn path=/trunk/; revision=43194
2012-06-11 03:36:04 +00:00
339bedb75c
Fix UDP-Lite checksum verification bug introduced with r40387 and reported by "answer" via http://ask.wireshark.org/questions/11798/is-udp-lite-checksum-correct-ipv6
...
There is a difference between the UDP and UDP-Lite pseudo header that wasn't realized when r40387 was committed. Details of the difference in http://tools.ietf.org/html/rfc3828#section-3.2
svn path=/trunk/; revision=43187
2012-06-10 19:43:40 +00:00
ebe8ed3a3e
Fix the other part of Coverity CID 703086. I thought I got it with r42798, but apparently that was only 1/2 the fix as sometimes they group more than one bug into a single CID.
...
svn path=/trunk/; revision=43185
2012-06-10 19:02:03 +00:00
912ba5d00b
From Michael Mann: Added dissection of IceP over UDP as well as a few preferences mentioned in the TODO. Also replaced a few proto_tree_add_text with expert_add_info_format. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1646
...
svn path=/trunk/; revision=43182
2012-06-10 08:24:18 +00:00
4b4bb7acf5
Fix compiler error
...
svn path=/trunk/; revision=43181
2012-06-09 18:42:20 +00:00
61d278c921
str_to_ipaddr() had a bug; use inet_pton() instead;
...
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844#c27
Also: Improve handling of an invalid value for the 'proxy IP Address'
preference. If the address is invalid, setting the preference
to "" in proto_reg_handoff...() doesn't work well.
Instead, issue a g_warning for an invalid IP address when it'
s processed in proto_reg_handoff...()
(AFAIK, there's not a way for a dissector to validate the semantic
value of a preference and report an error).
svn path=/trunk/; revision=43180
2012-06-09 18:24:09 +00:00
951b5b9c54
Do not use BASE_NONE for FT_*INT* types.
...
svn path=/trunk/; revision=43179
2012-06-09 17:56:08 +00:00
0169f77ac6
Do not use BASE_NONE for FT_*INT* types.
...
svn path=/trunk/; revision=43178
2012-06-09 17:51:30 +00:00
d9a5e3a1d2
Do not use BASE_NONE for FT_*INT* types.
...
svn path=/trunk/; revision=43177
2012-06-09 17:47:58 +00:00
365139b5cf
Do not use BASE_NONE for FT_UINT8 types.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7333 (I think).
svn path=/trunk/; revision=43176
2012-06-09 17:08:46 +00:00
8fe8287a39
Add sip.to.tag and sip.from.tag filters.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5226
svn path=/trunk/; revision=43175
2012-06-09 15:54:15 +00:00
bf35ccfbce
Allow syslog to work with "Decode As" for TCP.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5241
svn path=/trunk/; revision=43174
2012-06-09 15:43:08 +00:00
be965bff75
Don't register 3 (IPAddress) hf's with the same abbreviation but with 3
...
different types; instead use different abbreviations (filters).
This is in order to prevent running into
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402
and seg-faulting when someone applies a filter of, for example,
diameter.Framed-IP-Address .
svn path=/trunk/; revision=43166
2012-06-08 22:23:11 +00:00
836ed4ccfc
Fix bug I introduced in SVN #43129 .
...
Fixes fuzz crash reported in Bug #7346 .
svn path=/trunk/; revision=43164
2012-06-08 21:17:42 +00:00
b4f3ea200c
Thinking about it more, how we're storing the application ID isn't a problem.
...
svn path=/trunk/; revision=43163
2012-06-08 20:08:43 +00:00
c75657ad14
Don't call val_to_str() only to then compare the result with "Uknown": use
...
match_strval() instead.
Also, don't retrieve the application ID 3 more times; we've already got it
in a variable...
Point out a bug regarding how we're storing the application ID for use by
subdissectors (from r34570).
svn path=/trunk/; revision=43162
2012-06-08 19:59:33 +00:00
39dbd45c9f
Fix some dead assignments.
...
svn path=/trunk/; revision=43157
2012-06-08 17:20:44 +00:00
ae43364681
Only dissect as SDp if it's IPBCP (text encoded).
...
svn path=/trunk/; revision=43152
2012-06-08 11:50:52 +00:00
98b74816ae
From Stefan Hoffmeister:
...
ActiveSync WBXML CodeSpace updated to match official documentation.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7345
svn path=/trunk/; revision=43151
2012-06-08 06:26:55 +00:00
fabd558ffe
Fix invalid hf[] entry 'display' field value.
...
result: incorect display of value (and, incidentally,
a crash in 'tshark -G values'
svn path=/trunk/; revision=43147
2012-06-07 17:39:11 +00:00
059d407e19
From Niels de Vos: GlusterFS: Display SETATTR attribute valid as a list of flags https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7341
...
svn path=/trunk/; revision=43144
2012-06-06 20:44:21 +00:00
7881fe8493
From Stephen Donnelly: Correct ERF name, add WTAP_ENCAP string display https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7313
...
svn path=/trunk/; revision=43141
2012-06-06 20:35:37 +00:00
2f035a3c0f
From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7334 :
...
FPSpotlightRPC dates structure can contain multiple dates
svn path=/trunk/; revision=43133
2012-06-06 16:55:48 +00:00
027b57b472
Fix compiler error (I hope)
...
svn path=/trunk/; revision=43131
2012-06-06 05:58:42 +00:00
e18d46784f
Fix compiler error
...
svn path=/trunk/; revision=43130
2012-06-06 05:36:43 +00:00
57c6467b81
Fix some bugs & do extensive cleanup;
...
Bugs fixed:
- Calling col_...() fcns or dissectors under 'if (tree)'
- Potential buffer overflows (if bad data)
- Misc incorrect data display issues
Cleanup including;
- Remove unneeded #includes
- Fix excessive use of value_strings
- Use extended value_strings & val_to_str_(ext_)const as appropriate
- Optimize repeated fetches of the same data from a tvb
- Do general code simplification
- Remove or #if 0 unused code;
- Add XXX comments for code which may be incorrect
- Remove unneeded prefs callback to proto_reg_handoff...()
- Remove unneeded use of check_col()
- Define several functions as static
- Move proto_reg_handoff...() to the end of the file
- Fix whitespace (including "4 space tabs")
- ...
svn path=/trunk/; revision=43129
2012-06-06 04:54:47 +00:00
f554994823
Just fix some clang analysis warnings
...
svn path=/trunk/; revision=43126
2012-06-05 23:03:13 +00:00
cf25f08af0
yami: dissect header messages, add parameter names to parent tree item.
...
svn path=/trunk/; revision=43117
2012-06-05 15:52:08 +00:00
49c359bf2d
Fix Coverity 703495: reference fpinf *after* checking that it is not NULL.
...
Also replace some 4 space tabs with spaces.
svn path=/trunk/; revision=43113
2012-06-05 15:05:17 +00:00
97d51ce67f
packet-yami: cleanup, remove non-ASCII character.
...
svn path=/trunk/; revision=43112
2012-06-05 15:02:49 +00:00
7d075658b1
packet-wreth: cleanup
...
- make function and arrays static
- comment out unused hf-entry.
- comment out unused variable.
svn path=/trunk/; revision=43111
2012-06-05 14:50:37 +00:00
6dc698ca27
Dissector for YAMI protocol.
...
svn path=/trunk/; revision=43110
2012-06-05 14:17:50 +00:00
28098ed4ab
From Roland Knall:
...
openSAFETY - Names for certain SOD objects, automatic SCM UDID detecion.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7335
svn path=/trunk/; revision=43109
2012-06-05 13:12:28 +00:00
aa4e655696
Set SVN properties.
...
svn path=/trunk/; revision=43108
2012-06-05 11:19:33 +00:00
189ea54f0b
from Alex Lindberg:
...
Update to packet-h248.c and associated h248 dissecorts.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332
svn path=/trunk/; revision=43107
2012-06-05 10:54:21 +00:00
5bd0c263f2
From Andrew Kampjes:
...
SDH support for wireshark.
- Added GPL license.
- Removed not needed includes.
- Skipped th .h file as it wasn't used.
svn path=/trunk/; revision=43106
2012-06-05 10:42:38 +00:00
1d27ce5d99
From Adam Langley: Add support for decrypting ECDHE-RSA-RC4-SHA. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7331
...
svn path=/trunk/; revision=43100
2012-06-05 05:27:06 +00:00
75319f09a9
From Adam Langley: Add support for CLIENT_RANDOM lines in SSL keylog. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7330
...
svn path=/trunk/; revision=43099
2012-06-05 05:22:41 +00:00
cec562ddd2
From Alex Lindberg: Add preference to packet-ber.c to toggle BER warning on leading zero bits. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7328
...
svn path=/trunk/; revision=43098
2012-06-05 05:16:06 +00:00
6c85e092cf
From Adam Langley: Clean up code for handling keylog files. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7329
...
svn path=/trunk/; revision=43097
2012-06-05 05:10:18 +00:00
7186d034f0
Fix compilation.
...
svn path=/trunk/; revision=43094
2012-06-04 23:47:11 +00:00
167b8c6cba
From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260
...
New dissector for WSE Remote Ethernet protocol
From me :
* Fix Compilation under linux
* Use proto_tree_add_item*
* Make build-in dissector
* Include Status.* and Codef.* in dissector
* Reorder function (to respect Wireshark Codelines)
* Add Modelines Info and fix indent (use 4 spaces)
* Fix check* tools
* Add Clement to AUTHORS
With the dissector....
svn path=/trunk/; revision=43092
2012-06-04 22:34:27 +00:00
42451447b1
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=43091
2012-06-04 22:26:40 +00:00
e2cec4bb63
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
(Manual Fix, not found how to fix the generator...)
svn path=/trunk/; revision=43090
2012-06-04 22:26:18 +00:00
c7e8a39966
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=43089
2012-06-04 22:25:27 +00:00
cb2000b9f3
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=43087
2012-06-04 22:24:46 +00:00
7ec2d11b9b
From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260
...
New dissector for WSE Remote Ethernet protocol
From me :
* Fix Compilation under linux
* Use proto_tree_add_item*
* Make build-in dissector
* Include Status.* and Codef.* in dissector
* Reorder function (to respect Wireshark Codelines)
* Add Modelines Info and fix indent (use 4 spaces)
* Fix check* tools
* Add Clement to AUTHORS
svn path=/trunk/; revision=43086
2012-06-04 22:22:32 +00:00
11e584f4cf
packet-gadu-gadu: set COL_INFO in undissected/unknown packet types.
...
svn path=/trunk/; revision=43068
2012-06-04 14:37:24 +00:00
a90e1a353a
Try to make the buildbot happy.
...
svn path=/trunk/; revision=43067
2012-06-04 14:31:53 +00:00
b69547925f
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43066
2012-06-04 13:52:46 +00:00
2a30b1eff9
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43065
2012-06-04 13:21:44 +00:00
a0910557c7
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43064
2012-06-04 12:20:37 +00:00
131334481d
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43063
2012-06-04 11:44:52 +00:00
81a7df91dd
Revert previous change as it did not compile.
...
svn path=/trunk/; revision=43062
2012-06-04 11:18:17 +00:00
920ad0bcee
Try to get rid of a couple of warnings.
...
svn path=/trunk/; revision=43061
2012-06-04 10:36:43 +00:00
f275aeadd9
Fix 'lvalue required as left operand of assignment' error when compiling with gcc 4.3.2
...
svn path=/trunk/; revision=43059
2012-06-04 10:02:08 +00:00
85972d91c7
Try to get rid of a couple of warnings.
...
svn path=/trunk/; revision=43058
2012-06-04 09:04:36 +00:00
10fe76d8a0
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43057
2012-06-04 08:56:48 +00:00
ebbaf7f820
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7325 :
...
Add support for the Gluster CLI RPC-protocol
svn path=/trunk/; revision=43055
2012-06-04 08:42:12 +00:00
4902b4d857
Remove a few of "if (tree)" checks surrounding expert_add_info_format().
...
svn path=/trunk/; revision=43054
2012-06-04 06:22:50 +00:00
6a4606b1f1
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7324 :
...
Add support for the Gluster Handshake and Callback RPC-protocols
svn path=/trunk/; revision=43035
2012-06-03 17:15:21 +00:00
3201d56f05
Convert space to tab
...
svn path=/trunk/; revision=43033
2012-06-03 16:49:58 +00:00
6c8174a1a8
Make checkhf tools Happy, Remove hf_ieee80211_chan*
...
svn path=/trunk/; revision=43032
2012-06-03 16:49:01 +00:00
44d7c7fb73
Add 802.11 AP Channel Report IE (51)
...
svn path=/trunk/; revision=43031
2012-06-03 16:47:15 +00:00
588fd3e761
Enhance 802.11 Secondary Channel Offset (62)
...
svn path=/trunk/; revision=43030
2012-06-03 16:45:30 +00:00
9a7409589a
Enhance 802.11 HT Info 1.1 (60)
...
svn path=/trunk/; revision=43029
2012-06-03 16:43:19 +00:00
7852f04531
Cleanup Header (Remove e-mail of original author to report bugs...)
...
svn path=/trunk/; revision=43028
2012-06-03 16:41:11 +00:00
8f94d6a813
Enhance 802.11 (Vendor Specific) HT Capability (45)
...
And fix last Dead Store warning found by Clang
svn path=/trunk/; revision=43027
2012-06-03 16:39:55 +00:00
3899295893
Enhance 802.11 (vendor specifiq) HT Info 1.0 (Draft)
...
svn path=/trunk/; revision=43025
2012-06-03 16:37:56 +00:00
8edc336db6
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7323 :
...
Add support for the Gluster Portmapper and DUMP RPC-protocols
svn path=/trunk/; revision=43024
2012-06-03 16:17:38 +00:00
b3f2c794e2
From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7315 :
...
Initial support for the GlusterD RPC-protocol
svn path=/trunk/; revision=43023
2012-06-03 15:52:15 +00:00
aa95f6b73d
Revert files committed by error in revision 43007
...
svn path=/trunk/; revision=43008
2012-06-02 19:20:04 +00:00
797b83c838
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7322 :
...
Add a missing break in packet-bpkmattr.c (CID 280484)
svn path=/trunk/; revision=43007
2012-06-02 19:15:07 +00:00
96beb44145
From Evan Huus Useless null check in packet-ssh.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7319
...
svn path=/trunk/; revision=42996
2012-06-02 13:25:02 +00:00
7ef7aae265
Fix header file includes to allow make dumpabi run without errors
...
svn path=/trunk/; revision=42994
2012-06-02 12:57:26 +00:00
Anders Broman