osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
40,420 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

40420 Commits

Author SHA1 Message Date
Chris Maynard 0b44e6f99b Mention that dissect_ip_tcp_options() is used by more protocols than just IP and TCP. 
svn path=/trunk/; revision=42533
 2012-05-10 01:26:53 +00:00
Chris Maynard 91b151278b PPP LCP improvements, mostly with LCP options. checkAPIs.pl and checkfiltername.pl are happy, but checkhf.pl complains; however, all complaints are false positives - maybe a Perl expert is able to modify checkhf.pl to avoid reporting them? Lots of changes so fuzz testing was performed, but no captures exist w/all the LCP options, so some are likely still untested. Compiled on Windows using MSVC2010EE, which is notorious for not reporting problems that other compilers do. Hopefully there are no warnings, but we'll see what the buildbots say ... 
svn path=/trunk/; revision=42532
 2012-05-10 01:21:37 +00:00
Guy Harris 27286517f7 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Also, fix a call for IPv4 addresses to use ENC_BIG_ENDIAN (yes, we do
support ENC_LITTLE_ENDIAN for IPv4 addresses - at least one protocol
apparently puts IPv4 addresses out byte-swapped!).

svn path=/trunk/; revision=42531
 2012-05-10 01:08:50 +00:00
Guy Harris 47cd41dbda Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

For RADIUS, this means that, for string attributes that are encrypted,
we need separate fields for the encrypted and decrypted versions, the
former of which is an FT_BYTES (as its value is *NOT* a text string!)
and the latter of which is FT_STRING.

While we're at it:

	make some routines static that don't need to be exported;

	"encrypt=" takes a value between 1 and 3 - get the value from
	the dictionary and store it, and only do User-Password-style
	decryption for encrypt=1 attributes;

	rename "hf64" to "hf_alt", as it's a general "alternate field",
	used for 64-bit values for integral attributess, IPv6 addresses
	for "combo IP" attributes, and encrypted values for string
	fields;

	give the URL for the FreeRADIUS dictionary file format man page.

svn path=/trunk/; revision=42530
 2012-05-10 01:01:18 +00:00
Gerald Combs dedd0eadd0 Better fixes for the last commit. 
svn path=/trunk/; revision=42529
 2012-05-10 00:21:40 +00:00
Gerald Combs 4d30e72575 Fix a few scan-build warnings. 
svn path=/trunk/; revision=42528
 2012-05-09 23:08:47 +00:00
Guy Harris 843f041270 Get rid of one remaining Booleans-as-encoding-argument in a 
proto_tree_add_item() call.

svn path=/trunk/; revision=42527
 2012-05-09 22:14:03 +00:00
Guy Harris e0e5f597d4 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42526
 2012-05-09 22:10:31 +00:00
Guy Harris 46872cdbbd Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42525
 2012-05-09 22:08:00 +00:00
Guy Harris b280cdfbdc Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42524
 2012-05-09 22:05:21 +00:00
Bill Meier 75f6458053 From Martin Kaiser: 
"attached is a simple fix for CID281213. Although the bug can't crash wireshark,
 dissect_si_string() is not really fit for handling negative string lengths (and
 doesn't need to)."

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7243

svn path=/trunk/; revision=42523
 2012-05-09 20:39:21 +00:00
Gerald Combs d5b3acebd1 Send a useful User-Agent header. 
svn path=/trunk/; revision=42522
 2012-05-09 19:17:48 +00:00
Anders Broman 582c102f16 Setup more flows, flow info is incomplete. 
svn path=/trunk/; revision=42521
 2012-05-09 14:24:46 +00:00
Anders Broman 9141a4fbcb Setup CPCH flows. 
svn path=/trunk/; revision=42520
 2012-05-09 12:54:58 +00:00
Martin Mathieson 9cd2bdf381 Remove an accidental ; following a test. 
svn path=/trunk/; revision=42519
 2012-05-09 12:07:14 +00:00
Anders Broman 41ae73c57d Collect and use more information in converstion data to be able to dissect FP flows. 
svn path=/trunk/; revision=42518
 2012-05-09 12:01:16 +00:00
pascal bdeea8408e Fix last parameter for tvb_get_guid() call 
svn path=/trunk/; revision=42517
 2012-05-08 20:25:55 +00:00
pascal 19a766b152 Remove unused hf entries 
svn path=/trunk/; revision=42516
 2012-05-08 20:20:12 +00:00
pascal 0c4569d941 From Frank Lahm: 
Display guids in FPSpotlightRPC AFP packets
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7237

svn path=/trunk/; revision=42515
 2012-05-08 19:38:58 +00:00
Alexis La Goutte 7e0c1e3a5a Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=42514
 2012-05-08 17:42:54 +00:00
Alexis La Goutte 3c47f9e73b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=42513
 2012-05-08 17:42:36 +00:00
Alexis La Goutte c16cd8f997 Enhance MPLS Dissector 
* use proto_tree_add_item
 * start Header field by hf_mpls...


svn path=/trunk/; revision=42512
 2012-05-08 17:41:23 +00:00
Alexis La Goutte f5a1787a06 Enhance Unknown IPv6 Extension Header 
svn path=/trunk/; revision=42511
 2012-05-08 17:34:46 +00:00
Alexis La Goutte 3fa9ea87ce Add RFC6608 Subcodes for BGP Finite State Machine Error 
Update other notify subcodes (draft-ietf-idr-cease-subcode-02 => RFC4484)...

svn path=/trunk/; revision=42510
 2012-05-08 17:31:05 +00:00
Bill Meier 5d1d282213 General cleanup including: 
- remove unneeded #include <stdlib.h>
- rework some "function-like" macros to use
  'do {...} while (0)' construct;
- reformat hf[] entries;
- indentation/whitespace/long-lines/parentheses.

svn path=/trunk/; revision=42509
 2012-05-08 15:16:55 +00:00
Anders Broman b438c7415f From Frank Lahm: 
Fixes for FPSpotlightRPC AFP dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7235

svn path=/trunk/; revision=42508
 2012-05-08 14:24:13 +00:00
Anders Broman 572fcbe463 From Jim Wright: 
Add decoding of CTEB to packet-dtn.c

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7234

svn path=/trunk/; revision=42507
 2012-05-08 14:17:16 +00:00
Guy Harris bd95016694 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42506
 2012-05-08 07:01:04 +00:00
Guy Harris 74c0b35425 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42505
 2012-05-08 06:43:15 +00:00
Guy Harris 6e60188def Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42504
 2012-05-08 06:41:10 +00:00
Guy Harris 7ff367e4ec Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Fix a field type - FT_UINT_BYTES means "byte array preceded by a
length, with the length field included", not "byte array, not including
any length field, even if it happens to be preceded by a length field".

svn path=/trunk/; revision=42503
 2012-05-08 06:35:50 +00:00
Anders Broman c406e86cc1 Pretify info_col for mor MSG:s 
svn path=/trunk/; revision=42502
 2012-05-08 05:35:30 +00:00
Guy Harris 3067d31c24 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.  (The only non-integral/non-boolean fields
aren't fetched as array elements.)

svn path=/trunk/; revision=42501
 2012-05-08 02:41:15 +00:00
Guy Harris 913d8951d1 Fix a proto_tree_add_ipv4() call that was probably intended to be a 
proto_tree_add_item() call.

svn path=/trunk/; revision=42500
 2012-05-08 02:05:16 +00:00
Guy Harris 77c75e4e43 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.  (There's no spec for the protocol that I
could find, just an implementation, and it's not clear whether the
description field is ASCII or UTF-8 or something else.)

svn path=/trunk/; revision=42499
 2012-05-08 02:02:26 +00:00
Guy Harris fad3e5f467 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42498
 2012-05-08 00:37:37 +00:00
Guy Harris cbd26a417b Fix a proto_tree_add_uint() call that appears to have been intended to 
be a proto_tree_add_item() call.

svn path=/trunk/; revision=42497
 2012-05-08 00:34:12 +00:00
Guy Harris 8822dffb82 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42496
 2012-05-08 00:31:56 +00:00
Guy Harris ff546a0151 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42495
 2012-05-08 00:29:22 +00:00
Guy Harris 7b67c96c9a Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Clean up indentation.

svn path=/trunk/; revision=42494
 2012-05-08 00:24:07 +00:00
Guy Harris 1fca484224 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Update the RFC number for LDAP.

svn path=/trunk/; revision=42493
 2012-05-08 00:15:53 +00:00
Guy Harris 551d8aaacf Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42492
 2012-05-07 23:55:46 +00:00
Guy Harris 5d4e982e93 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42491
 2012-05-07 23:40:44 +00:00
Guy Harris 0ac5ef9e91 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Update the introductory comment to give the RFC for IAX2. 
(tools.ietf.org rules.)

svn path=/trunk/; revision=42490
 2012-05-07 23:37:38 +00:00
Guy Harris 0851bd312c Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42489
 2012-05-07 22:52:33 +00:00
Guy Harris c51cadd00e Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42488
 2012-05-07 22:46:14 +00:00
Bill Meier c055ca8c7e General minor cleanup including: 
- remove unneeded #includes;
- use val_to_str_const() as appropriate;
- reformat hf[] entries;
- reformat long lines;
- use #if 0/#endif to coment out code instead of /* ... */;
- remove boilerplate comments;
- whitespace & indentation


svn path=/trunk/; revision=42487
 2012-05-07 22:11:34 +00:00
Guy Harris 8d33dddd11 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42486
 2012-05-07 21:11:58 +00:00
Guy Harris dedf907787 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42485
 2012-05-07 21:04:05 +00:00
Balint Reczey 4441dd7d59 Give hints to capture from stdin or pipe instead of opening it as a file 
svn path=/trunk/; revision=42484
 2012-05-07 19:53:49 +00:00