d12d5a606c
AFAICT sys/types.h & netinet/in.h #includes are not needed for these files.
...
(Let's see if any of the buildbots give any errors).
Also: remove trailing whitespace on lines.
svn path=/trunk/; revision=42429
2012-05-04 21:29:00 +00:00
0c1b9e9007
Fix typo error
...
svn path=/trunk/; revision=42428
2012-05-04 21:20:22 +00:00
c7ee2fb1e3
Clean up indentation.
...
svn path=/trunk/; revision=42427
2012-05-04 21:18:01 +00:00
6dbc3ab0ed
Websocket masked tvb was never freed, set it as child of original tvb.
...
Also change data memory allocator from ep_ to glib one.
svn path=/trunk/; revision=42426
2012-05-04 19:50:44 +00:00
860f1f2e3b
FALSE -> ENC_BIG_ENDIAN conversion
...
Enhance dissesction of SoundingRS-UL-ConfigDedicated/setup/duration parameter
svn path=/trunk/; revision=42425
2012-05-04 17:56:28 +00:00
9bad4b330d
ng_file_seek_rand() is supposed to return a Boolean; make it do so.
...
svn path=/trunk/; revision=42424
2012-05-04 17:18:15 +00:00
33bb54a945
file_seek() used to be a wrapper around fseek() or gzseek(), both of
...
which could use lseek() and were thus expensive due to system call
overhead. To avoid making a system call for every packet on a
sequential read, we maintained a data_offset field in the wtap structure
for sequential reads.
It's now a routine that just returns information from the FILE_T data
structure, so it's cheap. Use it, rather than maintaining the data_offset
field.
Readers for some file formats need to maintain file offset themselves;
have them do so in their private data structures.
svn path=/trunk/; revision=42423
2012-05-04 16:56:18 +00:00
f65cb5f27b
FALSE -> ENC_BIG_ENDIAN conversion
...
svn path=/trunk/; revision=42422
2012-05-04 16:35:59 +00:00
90bdc67fca
Set up conversations for the FP data flow.
...
svn path=/trunk/; revision=42421
2012-05-04 15:10:31 +00:00
fd38b34c2c
Fix opening packet window when frame has got cap_len = 0 (i.e. last frame from mime_file reader)
...
Workaround, if someone has better idea how to fix it, please do.
svn path=/trunk/; revision=42420
2012-05-04 10:28:16 +00:00
8bf8070340
Add proto_hier_tree_model.c to CMakeLists
...
svn path=/trunk/; revision=42419
2012-05-04 08:17:46 +00:00
77dc38ec5a
value_string_ext: Reorder entries in value_string arrays to get Binary Search instead of Linear Search.
...
svn path=/trunk/; revision=42418
2012-05-04 07:34:06 +00:00
5728240af1
Fix conflicting entries in CIP vendor list.
...
344 is registered to KEBA.
(Ref: http://www.odva.org/Home/CIPSUPPLIERDIRECTORY/LicensedVendorList/tabid/86/lng/en-US/Default.aspx )
svn path=/trunk/; revision=42417
2012-05-04 07:27:41 +00:00
ced09423a6
Dissect transport layer address NSAP
...
svn path=/trunk/; revision=42416
2012-05-04 06:31:31 +00:00
82b077278c
cleanup proto_hier_tree_model a little.
...
svn path=/trunk/; revision=42415
2012-05-04 06:08:22 +00:00
fdaa9aa3ac
Fix memleak of GtkTextBuffer
...
svn path=/trunk/; revision=42414
2012-05-04 05:56:38 +00:00
ba78859f64
Fix comments.
...
svn path=/trunk/; revision=42413
2012-05-04 05:43:48 +00:00
739f7c2f1d
Get rid of declaration of non-existent routine.
...
svn path=/trunk/; revision=42412
2012-05-04 05:42:42 +00:00
0cea399fda
From Jakub Zawadzki: Use custom model in Filter Expression dialog.
...
svn path=/trunk/; revision=42411
2012-05-04 04:44:23 +00:00
77074a5a37
From Evan Huus: - Make sure that unsupported link-layer types *always* have a dlt of -1 in the `device.links` list so that we can tell if they're unsupported. - When building the combo-box of link-layer types, make the unsupported ones insensitive (disabled), and be sure to default to a supported one if we have one. - Compiling a capture filter requires a supported link-layer type, so disable the 'Compile BPF' button if there are none. - It is not always a programming error to have no active pointer in the combo-box, as this can happen when all the available entries are unsupported (and thus disabled). Don't abort with g_assert_not_reached() when this happens. - Unlock the `pcap_compile_mtx` mutex in all cases after compiling a packet filter. This was causing a deadlock (complete program hang) if you tried to compile two different filters in a row on the same interface. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7135
...
svn path=/trunk/; revision=42410
2012-05-04 04:35:43 +00:00
9467af6931
Make everything static that doesn't need to be exported.
...
svn path=/trunk/; revision=42409
2012-05-04 02:35:12 +00:00
daa7f8851e
Fix indentation.
...
svn path=/trunk/; revision=42408
2012-05-04 02:16:51 +00:00
652349d0a5
Partial fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7221
...
(emem alignment problems on SPARC) :
Add the room for the pointer to the next (from r31577) *before* calculating
the canary+pad: that way the complete allocation
(allocation+canary_ptr+canary+pad) will end on an 8-byte boundary (as was the
case before r31577).
This only solves the alignment problem when using canaries (i.e., not, by
default, se_ allocations).
(And, yes, this is ignoring the 16-byte alignment requirements of long
doubles.)
svn path=/trunk/; revision=42407
2012-05-04 01:33:58 +00:00
a151b7c3e3
Don't use spaces before (and after) packet-waveagent.c entry
...
svn path=/trunk/; revision=42406
2012-05-03 21:35:54 +00:00
7dcd2e2a6b
General cleanup including:
...
- remove unneeded #includes;
- remove "boilerplate" coments;
- reformat long lines;
- whitespace changes.
svn path=/trunk/; revision=42405
2012-05-03 21:01:22 +00:00
777e3b4fea
More whitespace cleanup;
...
svn path=/trunk/; revision=42404
2012-05-03 20:35:44 +00:00
44b2b50bc2
General cleanup:
...
- use gboolean instead of gint8 for a TRUE/FALSE flag;
- remove unneeded #includes;
- remove "boilerplate" comments;
- reformat hf[] entries;
- whitespace fixes.
svn path=/trunk/; revision=42403
2012-05-03 20:15:53 +00:00
580a655675
General cleanup to include:
...
- remove unneeded includes;
- remove "boilerplate" comments;
- reformat hf[] entries;
- reformat long lines;
- unneeded use of check_col();
- whitespace fixes.
svn path=/trunk/; revision=42402
2012-05-03 19:31:03 +00:00
41cbf49820
Fix a typo.
...
svn path=/trunk/; revision=42401
2012-05-03 15:31:45 +00:00
babb1e59f6
Fix a typo.
...
svn path=/trunk/; revision=42400
2012-05-03 15:31:01 +00:00
d1c1455efc
Fix Coverity CID 280809 (formerly CID 809): Uninitialized scalar variable.
...
svn path=/trunk/; revision=42399
2012-05-03 14:51:36 +00:00
b242dda95d
Delete extraneous return statement, which effectively made the entire dissect_ieee_802_3_tlv() function dead code. Fixes Coverity CID 281470 (formerly CID 1470). [I guess the new Coverity version does cross-reference the CID's after all.]
...
svn path=/trunk/; revision=42398
2012-05-03 14:35:55 +00:00
639362d340
Regenerated the file.
...
svn path=/trunk/; revision=42397
2012-05-03 14:24:17 +00:00
f41fefdfe0
Add back the missing line of code to increment the offset.
...
svn path=/trunk/; revision=42396
2012-05-03 14:22:43 +00:00
76f582c58d
Fix logic bug. I'm sure this was something Coverity found and I fixed but forgot to commit it. Unfortunately Coverity has upgraded to Scan 5.5 and things are different now so I can't cross reference which CID this was anymore.
...
svn path=/trunk/; revision=42395
2012-05-03 14:00:56 +00:00
33646d3411
Add Klaus Heckelmann to the list of Wireshark authors for his contribution to resolving bug 7221.
...
svn path=/trunk/; revision=42394
2012-05-03 01:58:35 +00:00
2eeb504807
From Klaus Heckelmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7221 : Avoid wireshark crash on platforms where an 8 byte alignment is required by changing the resp_time field in the icmp_transaction_t from a double to an nstime_t.
...
svn path=/trunk/; revision=42393
2012-05-03 01:48:59 +00:00
8f557d0874
Attempt to fix clang warnings (dead assignment, dereference of null pointer, branch condition evaluates to a garbage value)
...
svn path=/trunk/; revision=42392
2012-05-02 21:55:59 +00:00
ecacaacbe2
Add a file_skip() routine to skip N bytes forward in the file - it's
...
currently just a wrapper around file_seek(), but could be implemented by
reading forward if, for example, we add support for reading
(sequentially only!) from a pipe.
Sort the declarations of file-reading routines into one block.
svn path=/trunk/; revision=42391
2012-05-02 21:25:48 +00:00
e1ee9ca907
Put all the comments about the "don't check the CRC" flag together, and
...
expand the resulting comment a bit.
svn path=/trunk/; revision=42390
2012-05-02 21:11:28 +00:00
736627bb97
Attempt to fix clang warnings (dead assignment and dereference of null pointer)
...
svn path=/trunk/; revision=42389
2012-05-02 20:40:49 +00:00
1aaa8207f4
Properly decrypt user-password according to http://tools.ietf.org/html/rfc2865#section-5.2
...
This fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6779
#BACKPORT
svn path=/trunk/; revision=42388
2012-05-02 20:37:59 +00:00
47d57de0b1
Remove most blurbs (they do not have any added value) and fix a few typo errors
...
svn path=/trunk/; revision=42387
2012-05-02 15:29:50 +00:00
d974535a07
Add missing updated file from previous commit.
...
svn path=/trunk/; revision=42386
2012-05-02 14:56:51 +00:00
e01d3b549e
From "oss.2nerds":
...
IEEE P802.1aq/D3.6 and the corresponding IETF draft
(http://tools.ietf.org/html/draft-ietf-isis-ieee-aq-05 ) defines a series of new
ISIS TLVs for the shortest-path-bridging protocol.
The attached patch file contains a simple dissector for one such TLV (the
MT-Port-Cap TLV) and several corresponding sub-TLVs (mcid, aux_mcid, digest,
and b-vid). The digest sub-TLV dissector has not been exercised because no
suitable capture files are available (the digest sub-TLV seems not to be widely
implemented at this point in time).
Note that the codepoints mentioned in the IETF draft have changed. The
IANA-assigned codepoints are further described in these pages:
http://www.ietf.org/mail-archive/web/spb-isis/current/msg00007.html
http://www.iana.org/assignments/isis-tlv-codepoints/isis-tlv-codepoints.xml#tlv-143
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7154
svn path=/trunk/; revision=42385
2012-05-02 14:23:35 +00:00
203fa68972
From Jim Wright:
...
Add decoding of ACS to packet-dtn.c
- Changed to use proto_tree_add_item();
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7220
svn path=/trunk/; revision=42384
2012-05-02 12:47:59 +00:00
feab4f6bab
From Evan Huus:
...
Given the problems with the original attempt, and the fact that there's a new
version of the protocol spec out (v1.1), I took a crack at writing a new
dissector from scratch. It doesn't decode the fields within the message
parameters (there are far too many to bother with for an initial draft), but it
decodes everything else.
Even though it's not complete, I feel it's worth checking in as an intermediate
step (assuming it passes review), since it's still far better than nothing, and
adding full parameter-field decoding is going to take a lot of time simply for
transcribing all the different fields.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1957
svn path=/trunk/; revision=42383
2012-05-02 11:05:35 +00:00
2311c797b2
From Gabor Somlai:
...
Decoding DOCSIS 3.0 Isolation DATA frames (FC_TYPE=10).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7214
svn path=/trunk/; revision=42382
2012-05-02 10:49:03 +00:00
fbecf576d1
From David Wei:
...
Change GTP and GTPv2 dissectors for pre-Rel7 UEs that do not support bitrates higher than 16 Mbps.
svn path=/trunk/; revision=42381
2012-05-02 07:23:32 +00:00
ec69aa8d27
Rename the NetMon 802.11 radio header and radiotap 802.11 radio header
...
dissector source files to match the "packet-ieee80211-XXX" pattern used
for other 802.11 radio header dissectors.
svn path=/trunk/; revision=42380
2012-05-02 04:03:49 +00:00
Bill Meier