8f9acccbc5
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
svn path=/trunk/; revision=42483
2012-05-07 19:47:15 +00:00
dc06d2643a
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
(The field is a counted string, so the byte order is in theory relevant,
although the count is, in this case, a single byte.)
svn path=/trunk/; revision=42482
2012-05-07 19:38:26 +00:00
25fe8a3f22
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
svn path=/trunk/; revision=42481
2012-05-07 19:30:29 +00:00
8b5748d182
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
Get rid of unnecessary include of <stdio.h>.
svn path=/trunk/; revision=42480
2012-05-07 18:59:18 +00:00
f64b0b69a4
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
svn path=/trunk/; revision=42479
2012-05-07 18:14:08 +00:00
172798b88f
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
svn path=/trunk/; revision=42478
2012-05-07 18:10:05 +00:00
6eaf0037f8
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
svn path=/trunk/; revision=42477
2012-05-07 18:06:47 +00:00
20e4f9468f
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
svn path=/trunk/; revision=42476
2012-05-07 18:03:43 +00:00
761ce3c75b
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls; for the items that don't actually have hf_
entries (which is a bug in the dissector!), assume the short
fixed-length ones are integral and the "to the end of the packet" ones
are byte arrays (hence ENC_NA).
svn path=/trunk/; revision=42475
2012-05-07 18:00:13 +00:00
aee419527f
Revert previous change - packet-umts_fp.h wasn't changed.
...
svn path=/trunk/; revision=42474
2012-05-07 17:41:29 +00:00
bf09922d1d
packet-umts_fp.h now requires epan/conversation.h.
...
svn path=/trunk/; revision=42473
2012-05-07 17:40:05 +00:00
71cb7a6cf3
packet-umts_fp.h now requires epan/conversation.h.
...
svn path=/trunk/; revision=42472
2012-05-07 17:39:09 +00:00
f758ee84f9
packet-umts_fp.h now requires epan/conversation.h.
...
svn path=/trunk/; revision=42471
2012-05-07 17:38:26 +00:00
1637f2965e
packet-umts_fp.h now requires epan/conversation.h.
...
svn path=/trunk/; revision=42470
2012-05-07 17:37:30 +00:00
c9a82fcdb1
Include <epan/conversation.h> from packet-umts_fp.h.
...
svn path=/trunk/; revision=42469
2012-05-07 17:10:12 +00:00
15ee6468e8
packet-umts_fp.h now requires epan/conversation.h.
...
svn path=/trunk/; revision=42468
2012-05-07 17:04:41 +00:00
63f9279370
packet-umts_fp.h now requires epan/conversation.h.
...
svn path=/trunk/; revision=42467
2012-05-07 16:41:03 +00:00
1e6a26dfe9
Use converstaion info in umts_fp.
...
svn path=/trunk/; revision=42466
2012-05-07 16:09:49 +00:00
7afe87264d
Decode the Israeli TCM and CAM messages.
...
svn path=/trunk/; revision=42465
2012-05-07 15:13:28 +00:00
82ff1fd754
General cleanup:
...
- Setup COL_PROTO & COL_INFO before fetching from the tvb;
- Improve byte pane highlighing: Use proper length in proto_tree_add_item() calls;
- Remove unneeded include;
- Use VALS macro when referencing a value_string in hf[];
- Simplify/rework code slightly;
- Whitespace.
svn path=/trunk/; revision=42464
2012-05-07 13:35:45 +00:00
a2fc95b244
General fixes and cleanup:
...
- Calls to a sub-dissector must not be under 'if (tree)';
- Setup COL_PROTO & COL_INFO before fetching from the tvb;
- Move proto_reg_handoff_...() to the end of the file;
- prefs callback not required;
- Localize a global variable;
- whitespace.
svn path=/trunk/; revision=42463
2012-05-07 13:30:58 +00:00
438d147181
(Minor): packet_reg_handoff() & prefs callback not req'd;
...
whitespace (trailing spaces) cleanup.
svn path=/trunk/; revision=42462
2012-05-07 13:13:49 +00:00
1f6ab2ee8f
Use defines in value_string values.
...
svn path=/trunk/; revision=42461
2012-05-07 11:14:30 +00:00
709d04976c
Avoid calling tvb_get_ptr() on 0-length TVBs.
...
It seems to be better fix than r42420
svn path=/trunk/; revision=42460
2012-05-07 10:51:14 +00:00
6b38e752db
From David Wei:
...
Fix to PCI and PVI in Bearer QoS and ARP IE:s for GTPv2.
svn path=/trunk/; revision=42459
2012-05-07 07:43:03 +00:00
557ab87a9b
Trivial typo: of -> or
...
svn path=/trunk/; revision=42458
2012-05-07 04:15:10 +00:00
bb14288a52
From Evan Huus:
...
CppCheck found a bunch of redundant assignments to the variable
'operand_address'.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7232
svn path=/trunk/; revision=42457
2012-05-07 01:27:36 +00:00
07d88fc044
From Evan Huus:
...
In dissect_sdp_media_attribute() we can leak 'key' in an error condition.
Simply move the allocation to after the error check.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7231
svn path=/trunk/; revision=42456
2012-05-07 01:18:17 +00:00
7582254ef1
From Evan Huus: remove unused variables
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7229
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7230
svn path=/trunk/; revision=42455
2012-05-07 01:12:03 +00:00
9d4b7ad9fe
From Evan Huus:
...
In get_capture_device_open_failure_messages() in dumpcap.c, there are some
statements that should have been guarded by ifdefs, causing a little
unnecessary work on some platforms, and a bunch of unused-variable warnings
from static analyzers. The patch fixes the problem.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7228
svn path=/trunk/; revision=42454
2012-05-07 00:49:39 +00:00
6edf8b716b
Move converation setup code, pretify som messages info col. entries.
...
svn path=/trunk/; revision=42453
2012-05-06 22:10:13 +00:00
fc54a4a9e7
[Automatic manuf, services and enterprise-numbers update for 2012-05-06]
...
svn path=/trunk/; revision=42448
2012-05-06 14:03:29 +00:00
bdcbefabcb
Prefs callback not required ....
...
svn path=/trunk/; revision=42447
2012-05-05 21:47:55 +00:00
1783543e92
AFAICT '#include sys/types.h' is not needed for these files.
...
svn path=/trunk/; revision=42446
2012-05-05 21:29:13 +00:00
e62bb03dbc
Fix a typo which resulted in displaying the wrong SCTP stream reset response
...
sequence number.
svn path=/trunk/; revision=42445
2012-05-05 21:06:16 +00:00
f21d6f1dfa
Actually remove #include <sys/types.h> ....
...
svn path=/trunk/; revision=42444
2012-05-05 21:00:32 +00:00
a703450659
AFAICT '#include sys/types.h' is not needed for these files.
...
svn path=/trunk/; revision=42443
2012-05-05 20:51:14 +00:00
ec696f6dc0
Display CHAP password's Ident and String components.
...
svn path=/trunk/; revision=42442
2012-05-05 18:54:27 +00:00
126c94d8c8
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6906 :
...
Restore dissection without private key when RSA-NULL-MD5 or RSA-NULL-SHA cipher is used
svn path=/trunk/; revision=42441
2012-05-05 17:35:35 +00:00
f672e4822a
Cosmetic change....
...
svn path=/trunk/; revision=42440
2012-05-05 16:02:36 +00:00
7afb363eab
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6892 :
...
Sort the recent filters list by "most recently used" (that is, put the most
recently used filter at the head of the list).
svn path=/trunk/; revision=42439
2012-05-05 15:09:19 +00:00
24f5265620
Clean up white space and indentation; remove tabs.
...
svn path=/trunk/; revision=42438
2012-05-05 14:37:19 +00:00
48f4ae6e3b
From Nhi Nguyen:
...
OPC UA bytestring node id decoding is wrong
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7226
svn path=/trunk/; revision=42437
2012-05-05 04:57:40 +00:00
1fc695a022
Directly calculate the time stamp based on the offset in the stream from
...
the first bit in the stream. This prevents accumulated truncation
errors.
Get the seek offset from file_tell().
svn path=/trunk/; revision=42436
2012-05-05 02:52:41 +00:00
444187c5e8
Add support for Israeli national variant of (ITU) ISUP; Only the BCM
...
message is decoded for now.
Also clean up lots of white space and replace tabs (including 4-space tabs)
with spaces.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4231
svn path=/trunk/; revision=42435
2012-05-05 01:55:21 +00:00
2e11463277
Fix some more hf encodings.
...
svn path=/trunk/; revision=42434
2012-05-05 00:19:49 +00:00
5ad3d4ac04
Fix some encoding arguments.
...
svn path=/trunk/; revision=42433
2012-05-05 00:03:59 +00:00
080ad215a3
As suggested in http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html :
...
Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no
endianism, so ENC_NA is more appropriate.
svn path=/trunk/; revision=42432
2012-05-04 23:49:07 +00:00
06bb167824
The rest of the fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7221
...
(emem alignment problems on SPARC) :
Have emem use 8-byte alignment when we need it.
Since I can't seem to write code that which reliably (across GCC versions and
optimization levels) determines if 8-byte alignment is needed for doubles,
"when" is defined as "if we're compiling for a CPU other than i386."
Windows doesn't need a check because it's either i386 or 64-bit (x86_64 or
maybe ia64--both of which get 8-byte alignment from G_MEM_ALIGN).
(And, yes, all of this is ignoring the 16-byte alignment requirements of long
doubles.)
svn path=/trunk/; revision=42431
2012-05-04 21:56:32 +00:00
d1566f00a2
AFAICT sys/types.h & netinet/in.h #includes are not needed.
...
Also: remove "boilerplate" comment and do whitespace cleanup.
svn path=/trunk/; revision=42430
2012-05-04 21:39:30 +00:00
Guy Harris