pascal
5e0e1ceea8
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7213 :
...
Update dissection of Reverse charging, fast select, and ICRD status selection facilities
svn path=/trunk/; revision=42319
2012-04-28 17:34:23 +00:00
pascal
120f19310a
From Evan Huus:
...
Remove unused variables in SMB dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7211
svn path=/trunk/; revision=42318
2012-04-28 16:48:16 +00:00
Martin Mathieson
f0b6f7a6ae
Avoid assignement and clang warning.
...
svn path=/trunk/; revision=42317
2012-04-28 16:48:11 +00:00
Martin Mathieson
eafce30cf0
Another unnecessary assignment removed to fix clang warning.
...
svn path=/trunk/; revision=42316
2012-04-28 16:40:54 +00:00
Martin Mathieson
8b8f87be81
Remove move unread updates to 'offset' to avoid clang warnings.
...
svn path=/trunk/; revision=42315
2012-04-28 16:33:19 +00:00
Martin Mathieson
68841134b7
Don't look up p_fp_info only to always overwrite it.
...
svn path=/trunk/; revision=42314
2012-04-28 16:23:23 +00:00
Martin Mathieson
6eb94dd35e
Test a return value to avoid an initialised warning from clang.
...
svn path=/trunk/; revision=42313
2012-04-28 16:18:28 +00:00
Martin Mathieson
ca382b40b4
Remove an unnecessary assignment from clang output. I can't see the
...
problem with the other 2 warnings for this file.
--This linen , and those below, will be ignored--
M packet-umts_fp.c
svn path=/trunk/; revision=42312
2012-04-28 16:11:54 +00:00
Guy Harris
3684bb31a0
Remove _U_ from arguments that are actually used.
...
Fix a comment.
svn path=/trunk/; revision=42311
2012-04-28 16:05:18 +00:00
Martin Mathieson
21cca7ed28
Remove a couple of unused assignments pointed out by clang.
...
svn path=/trunk/; revision=42310
2012-04-28 15:57:50 +00:00
pascal
8d15f366c6
Remove unused header fields
...
svn path=/trunk/; revision=42309
2012-04-28 13:37:41 +00:00
pascal
f8f3756ab0
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7051 :
...
Add option 82 suboptions 150/151/152 decoding to DHCP dissector
svn path=/trunk/; revision=42308
2012-04-28 13:20:41 +00:00
Ronnie Sahlberg
d307c7fcd8
SCSI SBC: Add dissection of the ANCHOR and UNMAP bits in WRITESAME10/16
...
svn path=/trunk/; revision=42307
2012-04-28 08:16:17 +00:00
Guy Harris
a59e931733
If xml_get_int() fails, bail immediately; don't use the variable it
...
would have filled in had it not failed. (Thanks and a tip of the Hatlo
hat to the Clang static analyzer for complaining about this.)
svn path=/trunk/; revision=42306
2012-04-28 03:07:04 +00:00
Guy Harris
faa13e5072
Neither C90 nor C99 explicitly guarantee that a memcpy() call with a
...
null source argument and a zero count will work; in practice, they
probably will (with a zero count, there's nothing to fetch from the
source), but the Clang static analyzer still warns about it.
svn path=/trunk/; revision=42305
2012-04-28 02:25:15 +00:00
Guy Harris
d6e5b20bf2
Get rid of some unnecessary assignments, to remove warnings from the
...
Clang static analyzer.
svn path=/trunk/; revision=42304
2012-04-28 02:01:40 +00:00
Jakub Zawadzki
8ab67b185e
Like r42302 but in other place.
...
Followup to r42283: the loop which allocates operation summaries may not run
to completion, so don't try to free all the operation summaries.
svn path=/trunk/; revision=42303
2012-04-27 20:49:15 +00:00
Jeff Morriss
a8a5721d47
Fix fuzz failure reported in
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7209 :
Followup to r42283: the loop which allocates operation summaries may not run
to completion, so don't try to free all the operation summaries.
svn path=/trunk/; revision=42302
2012-04-27 20:43:22 +00:00
Jakub Zawadzki
4253c73d8f
Fix sigsegv in filter expression dialog when user clicked on some BASE_CUSTOM field.
...
svn path=/trunk/; revision=42301
2012-04-27 20:35:17 +00:00
Jeff Morriss
6aa32cb03a
As suggested in http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html :
...
Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no
endianism, so ENC_NA is more appropriate.
svn path=/trunk/; revision=42300
2012-04-27 19:45:35 +00:00
Jeff Morriss
445790ccb7
Bugzilla always uses https (and has for quite a while), so use https in the URLs to the bugs.
...
svn path=/trunk/; revision=42299
2012-04-27 19:18:22 +00:00
Jeff Morriss
a7f206dc02
Based on mail from Guy on -dev regarding the 1.7.1 release notes: Add entry for bug 3315 (save dependent frames when saving displayed packets)
...
svn path=/trunk/; revision=42298
2012-04-27 19:15:24 +00:00
Jeff Morriss
891c9db19b
As suggested in http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html :
...
Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no
endianism, so ENC_NA is more appropriate.
svn path=/trunk/; revision=42297
2012-04-27 18:58:37 +00:00
Guy Harris
4d1e993305
Update commented-out code to reflect the new reality.
...
svn path=/trunk/; revision=42296
2012-04-27 18:31:19 +00:00
Jeff Morriss
642099c485
Fix r42293: Make the script actually fail when tshark fails: use a new variable to indicate when we've caught a signal rather than (re-)using MAX_PASSES.
...
svn path=/trunk/; revision=42295
2012-04-27 17:58:06 +00:00
pascal
e191fe2a99
From Tom Bottom:
...
Fix AEM status field decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7205
svn path=/trunk/; revision=42294
2012-04-27 17:36:53 +00:00
Jeff Morriss
7891f04d8c
Get the script working again in the "unlimited passes" mode.
...
svn path=/trunk/; revision=42293
2012-04-27 16:58:21 +00:00
Anders Broman
8a4268505b
Fix Malformed packet AMS for Read Device Info Read State Request.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6710
check if data exists.
svn path=/trunk/; revision=42292
2012-04-27 14:13:06 +00:00
Jakub Zawadzki
31f6e7e35d
Don't store protocol field names in Filter Expression dialog.
...
Using gtk_tree_view_column_set_cell_data_func() and formating string on request
gives significant speedup (before patch: 12.392ms, after: 9.779ms).
svn path=/trunk/; revision=42291
2012-04-27 13:54:21 +00:00
Anders Broman
9d9be8f76d
From David Wei:
...
Further additions and fixes to MBMS in M3AP dissector.
from me update to 11.1
svn path=/trunk/; revision=42290
2012-04-27 11:08:37 +00:00
Anders Broman
a72f9abfc0
From David Wei:
...
Further additions and fixes to MBMS in GTPv2 and DIAMETER dissectors.
svn path=/trunk/; revision=42289
2012-04-27 10:48:03 +00:00
pascal
7eab849657
Fix typo errors
...
svn path=/trunk/; revision=42288
2012-04-27 09:04:23 +00:00
Jakub Zawadzki
08105610a0
nflog: add BYTE_ORDER_HOST, fix conflicting ENC_BIG_ENDIAN, ENC_NA value_string entries.
...
svn path=/trunk/; revision=42287
2012-04-27 08:44:38 +00:00
Anders Broman
3b0c9892a0
From Steve Magnani:
...
Add decoding of fields within endpoint descriptor wMaxPacketSize
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7206
svn path=/trunk/; revision=42286
2012-04-27 08:44:36 +00:00
Jakub Zawadzki
aec21991ec
Fix value of "Error in Parameter API"
...
References: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3753#c3
svn path=/trunk/; revision=42285
2012-04-27 08:41:44 +00:00
Anders Broman
33b522efd5
From Tom Bottom:
...
The AEM status field was erroneously displayed using ACMP status field values.
Minor change to display correct (as of draft 18) AEM status field values.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7205
svn path=/trunk/; revision=42284
2012-04-27 08:32:06 +00:00
Anders Broman
9e506104ed
From Evan Huus:
...
Memory leak in NFS Dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7204
svn path=/trunk/; revision=42283
2012-04-27 08:24:02 +00:00
Anders Broman
a2921f7b97
From Evan Huus:
...
Get rid of unused cur_pos variable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7203
svn path=/trunk/; revision=42282
2012-04-27 08:18:58 +00:00
Anders Broman
7d17553acc
From Evan Huus: Fix memory leaks in wslua_tvb.c fix typos in wslu_proto.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7202
...
svn path=/trunk/; revision=42281
2012-04-27 06:02:45 +00:00
Anders Broman
48fc51f835
From Evan Huus: Fix memory leaks in wslua_proto.c
...
svn path=/trunk/; revision=42280
2012-04-27 05:51:47 +00:00
Anders Broman
ace0603d8f
From Evan Huus: Fix memory leaks in wslua_pinfo.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7202
...
svn path=/trunk/; revision=42279
2012-04-27 05:47:42 +00:00
Bill Meier
1d04d562c5
For pcapng files: revert svn:mime-type back to application/octet-stream;
...
See wireshark-dev discussion starting at:
http://www.wireshark.org/lists/wireshark-dev/201204/msg00145.html
svn path=/trunk/; revision=42278
2012-04-27 05:02:36 +00:00
Guy Harris
177be74688
Get rid of tabs; make white space consistent.
...
Get rid of gtk_widget_set_size_request() calls - at least on my machine
and GTK+ version, they make some of the items too small to show the full
text. Let GTK+ figure out how big things have to be - and if that makes
the toolbar too wide, redesign the toolbar.
svn path=/trunk/; revision=42277
2012-04-26 22:11:01 +00:00
Jeff Morriss
5fa0ead414
Add a TODO comment; indicate why PCAP-NG files don't use application/vnd.tcpdump.pcap
...
svn path=/trunk/; revision=42276
2012-04-26 18:45:07 +00:00
Guy Harris
661afd4ba9
Consistently InterCapitalize StatusBar.
...
Separate "Toolbar" from the toolbar name in the View menu items.
Use "l", rather than "W", as the whatchamacallit for the wireless
toolbar - "W" is already used for "show packet in new window".
svn path=/trunk/; revision=42275
2012-04-26 18:02:04 +00:00
Guy Harris
99a66a0e77
While we're at it, add back the shortcuts, or whatever the heck the
...
Alt+{letter}+... things are called, for the Expand and Collapse items.
svn path=/trunk/; revision=42274
2012-04-26 17:36:39 +00:00
Jeff Morriss
d3adfa1927
Use a mime-type of application/x-gzip for *.gz files
...
svn path=/trunk/; revision=42273
2012-04-26 17:31:46 +00:00
Guy Harris
6163bcfa89
Just use a Boring Old ASCII Dash for hex ranges.
...
svn path=/trunk/; revision=42272
2012-04-26 16:58:30 +00:00
Bill Meier
557ed5e971
Minor: reformatting, unneeded #includes, whitespace cleanup;
...
Also: use val_to_str_const(0 instead of val_to_str() in a few cases.
svn path=/trunk/; revision=42271
2012-04-26 16:47:37 +00:00
Guy Harris
781891bd7b
Remove duplicate comment.
...
svn path=/trunk/; revision=42270
2012-04-26 16:30:33 +00:00