mirror of https://gerrit.osmocom.org/libusrp
Update patch set 2
Patch Set 2: Code-Review+1 (1 comment) Patch-set: 2 Reviewer: Gerrit User 1000147 <1000147@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1
This commit is contained in:
parent
48b9635037
commit
d4b497b00a
|
@ -22,6 +22,30 @@
|
|||
"revId": "30a609f03e3c1e89749c105492d36e05fd9918df",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "43602fb5_fc3b95d9",
|
||||
"filename": "firmware/src/common/build_eeprom.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 87,
|
||||
"author": {
|
||||
"id": 1000147
|
||||
},
|
||||
"writtenOn": "2021-11-12T10:48:53Z",
|
||||
"side": 1,
|
||||
"message": "looks correct according to https://stackoverflow.com/a/403426\n\nalso I\u0027ve verified that the generated files are the same in both versions.\n\n $ git checkout master\n $ autoreconf -fi\n $ ./configure\n $ make\n $ cp firmware/src/usrp2/burn-usrp* /tmp/\n $ make distclean\n $ git review -d 19675\n $ autoreconf -fi\n $ ./configure\n $ make\n $ diff -s /tmp/burn-usrp2-eeprom firmware/src/usrp2/burn-usrp2-eeprom\n Files /tmp/burn-usrp2-eeprom and firmware/src/usrp2/burn-usrp2-eeprom are identical\n $ diff -s /tmp/burn-usrp4-eeprom firmware/src/usrp2/burn-usrp4-eeprom\n Files /tmp/burn-usrp4-eeprom and firmware/src/usrp2/burn-usrp4-eeprom are identical",
|
||||
"parentUuid": "015df098_dc49d469",
|
||||
"range": {
|
||||
"startLine": 87,
|
||||
"startChar": 12,
|
||||
"endLine": 87,
|
||||
"endChar": 32
|
||||
},
|
||||
"revId": "30a609f03e3c1e89749c105492d36e05fd9918df",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue