Commit Graph

43043 Commits

Author SHA1 Message Date
Anders Broman e0c023859e Building with GTK3 works.
svn path=/trunk/; revision=45555
2012-10-15 08:32:38 +00:00
Anders Broman a85e8b73a8 Build GTK2 versions again.
svn path=/trunk/; revision=45554
2012-10-15 08:30:32 +00:00
Anders Broman 92160cde38 Try to get rid of some of the" pedantic" warnings.
svn path=/trunk/; revision=45553
2012-10-15 08:05:32 +00:00
Anders Broman 58066cd222 See if we can build u3 pacakage with GTK3.
svn path=/trunk/; revision=45552
2012-10-15 08:03:44 +00:00
Anders Broman a3f65d3680 Try a experimental gtk3 build
svn path=/trunk/; revision=45551
2012-10-15 06:12:51 +00:00
Guy Harris 85b3da7c63 Clean up the "round up to a multiple of 4" code a bit.
svn path=/trunk/; revision=45548
2012-10-14 22:53:25 +00:00
Guy Harris 26ddc4c04f According to
http://home.martin.cc/linux/prism

there's a set of DID type values different from the ones we were using,
and there are captures out there that use values from both sets. 
Support both sets.

That page also says that a "status" value of 0 means "supplied"; treat
zero as meaning "supplied", and, if it's not zero for a field, don't
include it.

The "Mac Time" is, according to that page, the lower 32 bits of the MAC
timestamp; report it as such.

Fix some field names that were copied-and-pasted but not changed.

The RSSI and signal quality values are numbers, so show them in decimal.

The "signal" and "noise" values appear to be signed numbers, so make
them signed rather than unsigned and show them in decimal.

Show the data rate in the same style as it's shown in the radiotap
dissector.

Show the frame length in decimal; we probably have relatively few users
with 16 fingers.

svn path=/trunk/; revision=45545
2012-10-14 22:38:58 +00:00
Evan Huus 9433de4c8a Unused variable
svn path=/trunk/; revision=45544
2012-10-14 19:48:22 +00:00
Evan Huus a892d9486d Fix leak in get_interface_type as caught by cppcheck.
svn path=/trunk/; revision=45543
2012-10-14 19:33:08 +00:00
Evan Huus 90584f4655 Add verbose option to the cppcheck script.
svn path=/trunk/; revision=45542
2012-10-14 19:30:33 +00:00
Anders Broman f8d36704a8 Revert back to GTK2
svn path=/trunk/; revision=45541
2012-10-14 19:16:34 +00:00
Anders Broman 091559e2ab Try a experimental gtk3 build
svn path=/trunk/; revision=45540
2012-10-14 18:42:02 +00:00
Guy Harris ac6341f361 The strings added to the value_string table for X11 opcodes for
extensions were incorrectly made ephemeral, rather than seasonal, in
r44662.  They need to be seasonal, as they're used for dissecting all
packets in the X session.

Redo a couple of loops as for loops to make it a little clearer what
they're doing.

svn path=/trunk/; revision=45539
2012-10-14 18:18:37 +00:00
Bill Meier 6e135fb693 Fix compile error.
svn path=/trunk/; revision=45538
2012-10-14 16:24:17 +00:00
Bill Meier be2e4d238f Minor changes:
- Init COL_PROTOCOL before fetching from tvb;
- Remove some unneeded variable initializers;
- Localize some variables;
- Misc including whitespace revisions.


svn path=/trunk/; revision=45537
2012-10-14 16:18:05 +00:00
Bill Meier 301b185cf4 remove unused variable; fixes compile error.
svn path=/trunk/; revision=45536
2012-10-14 15:31:44 +00:00
Michael Mann 8856e1a03a convert proto_tree_add_text to proto_tree_add_item and expert_add_info_format for packet-dhcpv6.c and packet-dhcp-failover.c
"Refactor" value_string in ARP dissector

svn path=/trunk/; revision=45535
2012-10-14 15:27:52 +00:00
Bill Meier 6cf76e38bf From Yaniv Kaul: Spice protocol fixes and enhancements
- Dissection of monitors config message (SPICE_DISPLAY_MONITORS_CONFIG message)
- Better dissection of capabilities (added several more capabilities for main
  and display channels)

From me:
- Remove (now) unused variables.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7859

svn path=/trunk/; revision=45534
2012-10-14 15:12:03 +00:00
Gerald Combs ad29ce058b [Automatic manuf, services and enterprise-numbers update for 2012-10-14]
svn path=/trunk/; revision=45531
2012-10-14 14:03:39 +00:00
Guy Harris 09e4e205c7 Some of the changes claimed to be in the previous checkin weren't there.
Label the data sources for reassembled fragments as "Reassembled
6LoWPAN". 

Fix the capitalization of "6LoWPAN".

Also, label the data sources for decompressed fragments as "Decompressed
6LoWPAN xxx".

svn path=/trunk/; revision=45529
2012-10-14 02:54:25 +00:00
Guy Harris 395dd4a88e *Always* create a new data source when we decompress an IPv6 header.
Label the data sources for them as "6LoWPAN xxx", where "xxx" is the
type of compression, and label the data sources for reassembled
fragments as "Reassembled 6LoWPAN".

Fix the capitalization of "6LoWPAN".

Note that if reassembly fails, continuing dissection is not the right
thing to do, at least not if it failed because we don't *yet* have all
the fragments.

svn path=/trunk/; revision=45527
2012-10-14 02:33:26 +00:00
Guy Harris 7ac57a8411 The Interface Name field of the Interface Name sub-object of the
Interface Information object for ICMP is *NOT* null-terminated.  Use
tvb_format_text() for now, to properly null-terminate the display string
and to cope with non-ASCII data.  (It should ultimately be a named field
with an encoding of UTF-8.)

svn path=/trunk/; revision=45525
2012-10-13 22:20:34 +00:00
Evan Huus e2c898959c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7858
Use a full 32-bit literal instead of just a 16-bit one. Fixes case where
the value we're &-ing with just slips over 2^16, making us get stuck
in an infinite loop.

I'm not sure this matches the iscsi spec anymore, the comment in the code
about padding bytes is ambiguous as to whether they're leading or trailing.

svn path=/trunk/; revision=45524
2012-10-13 22:12:52 +00:00
Pascal Quantin fa57420e74 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7857 :
Fix an infinite loop in WaveAgent dissector

svn path=/trunk/; revision=45523
2012-10-13 20:59:14 +00:00
Martin Mathieson f1939f9442 Add 2 new file extension associations, and restore alphabetical order.
svn path=/trunk/; revision=45522
2012-10-13 19:39:05 +00:00
Guy Harris 4fdfccd56d Don't add FT_UINTn values with proto_tree_add_int(). (The fields in
question are 4-byte header fields containing bitfields, so "unsigned" is
appropriate here.)

svn path=/trunk/; revision=45521
2012-10-13 17:57:13 +00:00
Evan Huus 4930f6d820 Enhancements to the CppCheck script:
- make html output a flag (-h), instead of what happens when you
  specify no files
- add flag (-j) for job count, like make et al.
- add flag (-a) to ignore the suppressions file and report all issues
- require /bin/bash instead of just /bin/sh in order to get arithmetic $(())
- add mode-lines

svn path=/trunk/; revision=45520
2012-10-13 02:03:18 +00:00
Evan Huus 93f4ea8838 Always initiailize member variables in constructors, even if it's just to NULL.
Use C++'s initializer syntax more.

svn path=/trunk/; revision=45519
2012-10-13 01:37:48 +00:00
Evan Huus d11b00d760 Reduce variable scopes where possible.
svn path=/trunk/; revision=45518
2012-10-13 01:29:29 +00:00
Evan Huus 1ed9eb2ece Fix compilation with GCC:
- initialization order
- unused and uninitialized local print_args_t
- missing comment on #endif

svn path=/trunk/; revision=45517
2012-10-13 01:15:35 +00:00
Gerald Combs 818cf887f9 Add missing arguments.
svn path=/trunk/; revision=45516
2012-10-13 01:01:48 +00:00
Gerald Combs 86797e9c0a Fix initialization order.
svn path=/trunk/; revision=45515
2012-10-13 00:21:25 +00:00
Gerald Combs 419f851e34 Fix Windows compilation problems from r45513. #ifdef out some non-Windows
code.  Get rid of a few uses of the global cfile.

svn path=/trunk/; revision=45514
2012-10-13 00:18:46 +00:00
Gerald Combs cfa22deaae Add a packet format group box, similar to the packet range group box.
Use it in the new "Export Packet Dissections" dialog.

I'm omitting PostScript exports on purpose. If you *really* need that
feature you can probably get better results than we produce using text +
enscript or print-to-PDF + pdf2ps/pdftops or PSML/PDML + XSL + ...

The Windows code is untested. I'll check in any needed fixes shortly.

svn path=/trunk/; revision=45513
2012-10-12 23:40:29 +00:00
Gerald Combs c91c1df500 Use seasonal allocation for name resolution. This effectively scrubs our
resolution information between capture files so that we don't leak host
entries from one file to another (e.g. embarassing-host-name.example.com
from file1.pcapng into a name resolution block in file2.pcapng).

host_name_lookup_cleanup and host_name_lookup_init must now be called
after each call to se_free_all. As a result we now end up reading our
various name resolution files much more than we should.

svn path=/trunk/; revision=45511
2012-10-12 21:37:02 +00:00
Pascal Quantin c5e0d7ce32 Do not use private_data from caller dissector as IKEv2 decryption parameters
svn path=/trunk/; revision=45510
2012-10-12 21:06:27 +00:00
Guy Harris a2c64e173e And that also means that we need to split the data rate from the
pseudo-header into two bytes and fill in both the rate and direction
fields when writing CommView NCF files out.

svn path=/trunk/; revision=45507
2012-10-12 20:59:08 +00:00
Guy Harris 10b89e0430 The "rate" field in the CommView NCF format is 1 byte long, not 2 bytes
long; that means we read only one byte into our structure, so make its
"rate" element one byte long, so we don't fill in half the "rate"
element with the read - and the *wrong* half on big-endian machines -
and leave the other half un-set and thus containing some random possibly
non-zero data.

In addition, that's not the full data rate for faster networks; for
Wi-Fi, the one-byte "direction" field is actually the upper 8 bits of
the data rate, so combine them when we fill in the data rate in the
pseudo-header.

#BACKPORT

svn path=/trunk/; revision=45504
2012-10-12 20:51:04 +00:00
Bill Meier 58c859dd90 Move proto_register...() and proto_reg_handoff...() to the end of the file as per convention;
Do minor whitespace changes.

svn path=/trunk/; revision=45503
2012-10-12 19:59:56 +00:00
Bill Meier 96f708abd5 Fix (what appears to be) a minor "off by one" bug in 'for' loop.
svn path=/trunk/; revision=45500
2012-10-12 18:31:31 +00:00
Anders Broman cfa7c28fe7 From Josip Medved:
Wrong casing for Auth-Request-Type enumerations.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7852

svn path=/trunk/; revision=45499
2012-10-12 13:06:15 +00:00
Anders Broman 8527d3912c From Andrei Emeltchenko:
Register eapol dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7633

svn path=/trunk/; revision=45498
2012-10-12 12:52:36 +00:00
Anders Broman 1f867e7901 Include setup.ini in the tarball.
Copy setup.ini to etc/gtk-3.0

svn path=/trunk/; revision=45497
2012-10-12 12:36:22 +00:00
Guy Harris 928ebf0ea3 If we see an SHB after we've read the first SHB, report that as an
unsupported feature.

If we see an IDB after all the IDBs at the beginning of the file,
process it.  Fixes bug 7851.

Get rid of unused read_idbs flag in pcapng_t structure.  (Also, as per
the above, just because we've read all the IDBs at the beginning of the
section, that doesn't necessarily mean we've read all the IDBs in the
section.)

Fix some places where we reject SPBs.

svn path=/trunk/; revision=45495
2012-10-12 03:55:10 +00:00
Martin Mathieson fa79b7580a When configuring DRB mappings (from signalling channel), create a
separate table for each UE.

svn path=/trunk/; revision=45494
2012-10-12 03:00:38 +00:00
Alexis La Goutte 9392d98978 Make new text translatable (a
And lupdate QtShark.pro (update translation file)
Updating 'qtshark_de.ts'...
    Found 257 source text(s) (15 new and 242 already existing)
    Kept 1 obsolete entries
Updating 'qtshark_fr.ts'...
    Found 257 source text(s) (15 new and 242 already existing)
    Kept 1 obsolete entries
    Same-text heuristic provided 1 translation(s)


svn path=/trunk/; revision=45492
2012-10-11 21:45:05 +00:00
Alexis La Goutte 29862fd1a1 Reorder 80211 dissector code (put value_string/true_false_string in top of file not in proto_register_...
svn path=/trunk/; revision=45491
2012-10-11 21:37:37 +00:00
Pascal Quantin 5f4f0b2637 Enhance dissection of Terminal Profile
svn path=/trunk/; revision=45490
2012-10-11 21:29:01 +00:00
Alexis La Goutte 969dcb9475 Small enhance following patch about 802.11ac (VHT)
svn path=/trunk/; revision=45489
2012-10-11 21:18:23 +00:00
Bill Meier d9c189e2d8 Correction to SVN #45476
svn path=/trunk/; revision=45486
2012-10-11 21:01:51 +00:00