Commit Graph

46325 Commits

Author SHA1 Message Date
Martin Mathieson be51acfffb Fix some issues seen by tools/check_typed_item_calls.py 2023-01-20 12:47:59 +00:00
PMcL d45a733258 mako: Updated Metamako trailer dissection
Minor updates to some variable names and wording of fields.
2023-01-20 09:27:01 +00:00
Alexis La Goutte 8080189ff3 h261: remove if(tree) check
not longer needed
2023-01-20 07:36:05 +00:00
Alexis La Goutte d4932b3313 h261: Remove extra space 2023-01-20 07:36:05 +00:00
Alexis La Goutte 1844094e07 H261: Fix encoding of H261 vmvd
Close #18812
2023-01-20 07:36:05 +00:00
John Thacker c380f516a2 GTP, GTPv2: Add request/response framenum types
Add the appropriate FT_FRAMENUM string types to the request
and response fields for GTP and GTPv2, so that arrows are
drawn for the related packet symbols.
2023-01-20 00:51:19 +00:00
Sergey V. Lobanov 4d2d0b7f6d MP4: add support for segment boxes (styp, sidx)
sidx and styp boxes are implemented according to 3GPP TS 26.244
Both boxes are added as mp4 magic bytes due to mp4 segments start from them

pcap and mp4 samples: https://wiki.wireshark.org/SampleCaptures#mp4-init-segments-and-segments
2023-01-19 17:59:50 +00:00
Kevin Grigorenko 43c5eedc97 Handle NULL http2_session_t parsing an H2 settings frame 2023-01-19 17:35:48 +00:00
João Valverde 74909f1499 Install PDML files to DOCDIR
Add README because this stuff is somewhat obscure and move XSLT
file to DOCDIR because it is not used by wireshark directly.
2023-01-19 17:08:36 +00:00
Jorge Mora ae4868f4bd NFS: fix IO_ADVISE hints mask
Use correct tree for hints mask in IO_ADVISE so it is displayed
properly within the operation.
2023-01-19 15:40:38 +00:00
John Thacker 1dac8660fc DHCP: Use BASE_CUSTOM for formatting time options
Use BASE_CUSTOM and custom formatting functions for formatting
DHCP options that are time fields, instead of
proto_tree_add_uint_format_value(). This makes the formatted form
show up in columns.

Fix #18743
2023-01-19 09:41:55 +00:00
Mikael Kanstrup c4db402db5 Add follow websocket stream support
The websocket protocol masking feature makes follow TCP stream
on websocket traffic show masked payload. To easily view unmasked
and reassembled websocket payload add follow websocket stream
support.
2023-01-19 03:14:18 +00:00
João Valverde a5eb85a1d6 Revert "ORAN FH CUS: Add subtree for bfwCompHdr"
This reverts commit 2c5f2e40fc.
2023-01-18 19:19:32 +00:00
Martin Mathieson 2c5f2e40fc ORAN FH CUS: Add subtree for bfwCompHdr 2023-01-18 14:59:17 +00:00
John Thacker b1f50b0b68 DNS: Add reverse DNS (PTR) answers to Resolved Addresses
If "use captured DNS packet data for name resolution" is enabled,
also use the information from PTR (reverse DNS) answers to fill
the hash table for IPv4 and IPv6 host resolution.

Fix #10036
2023-01-18 14:13:34 +00:00
Kevin Grigorenko b301dee0e1 Add HTTP2 connection and session window sizes 2023-01-18 07:04:53 +00:00
João Valverde fe7bfdf6ca CMake: Require explicit installation of development headers
Develpment headers are a sizeable part of the binary installation
and most users won't ever require them. It's recommended to package
them separately in a devel package or SDK.

Create a CMake installation component for development headers
and add the EXCLUDE_FROM_ALL property.

Headers can be installed using the invocation:

    cmake --install <dir> --component Development
2023-01-18 03:35:13 +00:00
João Valverde b801ea0191 MinGW: Fix -Wclobbered 2023-01-17 15:04:40 +00:00
Alexis La Goutte 3504b423b9 MySQL: Fix Dead Store Found by Clang Analyzer
Line 3728 Value stored to 'offset' is never read
2023-01-17 14:18:31 +00:00
Pascal Quantin 2dd8345895 NR RRC: upgrade dissector to v17.3.0 2023-01-17 14:47:25 +01:00
Joris Peeraer 918c9c5d5c PFCP: add Nokia proprietary IEs 2023-01-17 10:17:24 +00:00
John Thacker c8f8bc82a7 epan: FT_FRAMENUM strings are special
When creating the text of a custom column, don't call hf_try_val_to_str,
etc. on FT_FRAMENUM fields that have hfinfo->strings.
It refers to the ft_framenum_type.

Prevents crashing on custom columns of FT_FRAMENUM fields of
a type different than FT_FRAMENUM_NONE.
2023-01-16 20:34:19 -05:00
Martin Mathieson 30ef9d38cd Make a couple of functions static 2023-01-16 18:17:59 +00:00
Martin Mathieson 2f1493316a ORAN FH CUS: Round ext11 bundle to next byte 2023-01-16 17:35:48 +00:00
Martin Mathieson 4dd78f11c9 Fix various issues seen with tools/check_typed_item_calls.py 2023-01-16 15:35:04 +00:00
Pascal Quantin da0c933aa8 LTE RRC: upgrade dissector to v17.3.0 2023-01-16 13:59:13 +00:00
João Valverde 7738d5af5d MSYS2: Add some packages for missing dependencies
Add mingw packages for dependencies that are missing upstream;
these should eventually be submitted there.

Fix a version check for libsmi.

Update README.
2023-01-16 13:30:43 +00:00
Pascal Quantin 84f3a094d4 LPP: upgrade dissector to v17.3.0 2023-01-16 12:31:55 +00:00
João Valverde 7e6266d33d MSYS2: Add Lua 5.1 support and fix test suite failures 2023-01-16 11:54:43 +00:00
John Thacker 1e1e733d8c iSCSI: Handle invalid opcodes inside Reject message
Allow dissect_iscsi_pdu to handle iSCSI messages with invalid
opcodes, so that it does not crash when receiving them in Reject
messages.

Fix #18796
2023-01-15 19:58:29 -05:00
Gerald Combs 3bde296404 [Automatic update for 2023-01-15]
Update manuf, services enterprise numbers, translations, and other items.
2023-01-15 23:10:01 +00:00
Jiří Engelthaler a5319966bc Fix typo 2023-01-15 20:55:53 +01:00
Stig Bjørlykke c0dd9620c5 lwm2mtlv: Fix resource id lookup
The LwM2M object instance and resource id may be given in both the
CoAP Uri-Path and the LwM2M TLV header, and in this case the created
uri_path is wrong and resource id lookup will fail.

Change the logic to get object id from CoAP Uri-Path and resource id
from either Uri-Path or LwM2M TLV header.
2023-01-14 15:39:54 +00:00
João Valverde edd4295166 MinGW: Fix -Wunknown-pragma 2023-01-13 22:41:04 +00:00
João Valverde 6870449734 MinGW: Fix -Wbool-compare
The return of -1 for negative infinity is glibc specific and
non-portable.

/epan/dissectors/packet-synphasor.c:1634:62: error: comparison of constant '-1' with boolean expression is always false [-Werror=bool-compare]
 1634 |                 if ((isinf(pmu_lat) == 1) || (isinf(pmu_lat) == -1)) {
      |                                                              ^~
2023-01-13 22:41:04 +00:00
Gerald Combs 9754448044 CoAP+RTPS: Initialize some variables
Fix

    ==10365== Conditional jump or move depends on uninitialised value(s)
    ==10365==    at 0x81514B4: get_hfi_length (epan/proto.c:5981)
    ==10365==    by 0x815A0A5: proto_tree_add_pi (epan/proto.c:5953)
    ==10365==    by 0x815F41B: proto_tree_add_uint64 (epan/proto.c:5542)
    ==10365==    by 0x6BF362C: dissect_msg_tag (epan/dissectors/packet-cose.c:462)
    ==10365==    by 0x6BF1A27: dissect_cose_mac (epan/dissectors/packet-cose.c:656)
    ==10365==    by 0x813511A: call_dissector_through_handle (epan/packet.c:757)
    ==10365==    by 0x8130E58: call_dissector_work (epan/packet.c:850)
    ==10365==    by 0x8131604: dissector_try_string_new (epan/packet.c:1751)
    ==10365==    by 0x8131686: dissector_try_string (epan/packet.c:1776)
    ==10365==    by 0x6BD8C60: dissect_coap_payload (epan/dissectors/packet-coap.c:1115)
    ==10365==    by 0x6BDAD34: dissect_coap_message (epan/dissectors/packet-coap.c:1403)
    ==10365==    by 0x6BD8ECB: dissect_coap (epan/dissectors/packet-coap.c:1526)
    ==10365==
    ==10365== Conditional jump or move depends on uninitialised value(s)
    ==10365==    at 0x81517EC: get_hfi_length (epan/proto.c:6115)
    ==10365==    by 0x815A0A5: proto_tree_add_pi (epan/proto.c:5953)
    ==10365==    by 0x815F41B: proto_tree_add_uint64 (epan/proto.c:5542)
    ==10365==    by 0x6BF362C: dissect_msg_tag (epan/dissectors/packet-cose.c:462)
    ==10365==    by 0x6BF1A27: dissect_cose_mac (epan/dissectors/packet-cose.c:656)
    ==10365==    by 0x813511A: call_dissector_through_handle (epan/packet.c:757)
    ==10365==    by 0x8130E58: call_dissector_work (epan/packet.c:850)
    ==10365==    by 0x8131604: dissector_try_string_new (epan/packet.c:1751)
    ==10365==    by 0x8131686: dissector_try_string (epan/packet.c:1776)
    ==10365==    by 0x6BD8C60: dissect_coap_payload (epan/dissectors/packet-coap.c:1115)
    ==10365==    by 0x6BDAD34: dissect_coap_message (epan/dissectors/packet-coap.c:1403)
    ==10365==    by 0x6BD8ECB: dissect_coap (epan/dissectors/packet-coap.c:1526)

and

    ==10365== Conditional jump or move depends on uninitialised value(s)
    ==10365==    at 0x748EB90: hash_by_guid (epan/dissectors/packet-rtps.c:6006)
    ==10365==    by 0xC522FD5: wmem_map_lookup (wsutil/wmem/wmem_map.c:264)
    ==10365==    by 0x74A2E33: rtps_util_detect_coherent_set_end_empty_data_case (epan/dissectors/packet-rtps.c:3294)
    ==10365==    by 0x74A1054: dissect_RTPS_DATA (epan/dissectors/packet-rtps.c:10829)
    ==10365==    by 0x748E606: dissect_rtps_submessage_v2 (epan/dissectors/packet-rtps.c:12064)
    ==10365==    by 0x748DFBE: dissect_rtps_submessages (epan/dissectors/packet-rtps.c:12439)
    ==10365==    by 0x74A3FC9: dissect_rtps (epan/dissectors/packet-rtps.c:12357)
    ==10365==    by 0x748EDD2: dissect_rtps_udp (epan/dissectors/packet-rtps.c:12459)
    ==10365==    by 0x81334CA: dissector_try_heuristic (epan/packet.c:2864)
    ==10365==    by 0x76A8FF6: decode_udp_ports (epan/dissectors/packet-udp.c:712)
    ==10365==    by 0x76AB875: dissect (epan/dissectors/packet-udp.c:1267)
    ==10365==    by 0x76A9DAD: dissect_udp (epan/dissectors/packet-udp.c:1273)

Fixes #18785
2023-01-13 13:21:24 -08:00
João Valverde d902cabd3f MinGW: Fix -Wformat 2023-01-13 15:48:03 +00:00
Dr. Lars Völker 566292435f DoIP/UDS: Allow mixing with OBD-II
This patch allows users to dissect UDS and OBD-II messages on the same
ISO15765 or DoIP connection without changing manually changing the
config.
2023-01-13 13:04:09 +00:00
Martin Mathieson 9baefc3d5d eCPRI/ORAN: Various changes while looking at captures 2023-01-13 12:49:03 +00:00
Dr. Lars Völker ea0f20e993 OBD-II: Fixing Service/Mode 0x04 dissection
The current code assumes that the Service 0x04 has at least 1 parameter
byte in the request and 1 parameter byte in the response, which is
wrong.
2023-01-13 09:40:30 +00:00
Louis Scalbert 764890d159 BGP: fix BGP-LS IPv6 Neighbor Address TLV s length 2023-01-13 09:02:02 +00:00
Joris Peeraer 6281ad450b PFCP: refactor dissecting of enterprise IEs
The code for dissecting enterprise IEs has been reworked.

Previously, each enterprise was registered by its enterprise-ie in a
dissector-table. The per-enterprise dissector would index into an array
of IEs in order to find the correct IE-dissector.

Using this method has following drawbacks:
- IEs had to be defined in two arrays (value_string and dissector),
  possibly causing these two arrays becoming out-of-sync,
- the array only can be indexed if all IE-types are contiguous or gaps
  are maintained, which would be wasteful in case of bigger gaps
- individual IEs cannot easily be added outside of the source of this
  file

This commit implements a new approach that addresses above drawbacks by:
- defining all IE information together in one array,
- using per-vendor dissector_tables containing per-IE dissector handles,
  allowing both for arbitrary ie-types and adding individual
  enterprise-IEs separately from external code

This method does a two-level lookup for the IES:
- first looking up a vendor-dissector in the pfcp.enterprise_ies table
- if using the generic-ie-dissector a lookup in the per-vendor table to
  find the IE-dissector

A vendor-dissector receives the whole IE including header and has to do
all the work. An IE-dissector receives only the data-part and
a tree + header-fields have already been created.

The code for registering the per-IE tree-types has been modified as
well, because these tree-types are now stored together with the
IE-definitions. (Getting rid of the hardcoded indexes is also a plus.)

The 3GPP example enterprise dissector has been removed, as there are two
other enterprises which can serve as example.
2023-01-13 08:57:58 +00:00
Joris Peeraer b782c599ae Provide create_dissector_handle_with_data
Provide function create_dissector_handle_with_data that creates an
anonymous handle that uses a dissector with callback argument.
2023-01-13 08:57:58 +00:00
Alexis La Goutte 5766002231 proto(.c): Fix Argument with 'nonnull' attribute passed null 2023-01-13 08:06:02 +00:00
Ivan Stanoev cc9f5aed2b PFCP: Fix QFI bitmask
QFI field is 6-bit long but in PFCP dissector bitmask was set to 0x7f.
It needs to be 0x3f
2023-01-13 08:05:07 +00:00
Tomasz Moń 500b514b59
USBLL: Dissect USB 2.0 LPM Extended Transaction
Implement USB 2.0 Extension Transaction specified in USB Engineering
Change Notice: USB 2.0 Link Power Management Addendum.

Display Best Effort Service Latency (BESL) instead of Host Initiated
Resume Duration (HIRD) when dissecting LPM Token to align with USB 2.0
ECN Errata for Link Power Management.
2023-01-12 21:03:02 +01:00
Gerald Combs c14eb1767c E2AP: Use tvb_memcpy instead of memcpy(...tvb_get_ptr()) 2023-01-12 18:09:07 +00:00
Gerald Combs 9700b8cf8b LoRaWAN: Use tvb_memcpy instead of memcpy(...tvb_get_ptr()) 2023-01-12 18:09:07 +00:00
YDKK b0cb719672 opus: Fix TOC configuration parameter definitions 2023-01-12 12:41:56 +00:00
Martin Mathieson a88545ae95 Mysql: fix a couple of typos 2023-01-12 10:40:26 +00:00