Commit Graph

86484 Commits

Author SHA1 Message Date
João Valverde c66fc43e5b GUI: Ship authors as a Qt resource file 2023-01-20 13:35:03 +00:00
Martin Mathieson be51acfffb Fix some issues seen by tools/check_typed_item_calls.py 2023-01-20 12:47:59 +00:00
João Valverde 5f63989ee0 Update authors file in place
Instead of having AUTHORS.src and copying that to a new AUTHORS
file with git log information appended to that have a single
AUHTORS file and update it in place with git log info.
2023-01-20 12:04:57 +00:00
João Valverde 597bcca9ee wsutil: Add get_docfile_path() 2023-01-20 10:16:20 +00:00
PMcL d45a733258 mako: Updated Metamako trailer dissection
Minor updates to some variable names and wording of fields.
2023-01-20 09:27:01 +00:00
Alexis La Goutte 8080189ff3 h261: remove if(tree) check
not longer needed
2023-01-20 07:36:05 +00:00
Alexis La Goutte d4932b3313 h261: Remove extra space 2023-01-20 07:36:05 +00:00
Alexis La Goutte 1844094e07 H261: Fix encoding of H261 vmvd
Close #18812
2023-01-20 07:36:05 +00:00
John Thacker 199ecf2983 Qt: Clear selection, not current, in drawCurrentPacket
QItemSelectionModel tracks both the selected index and the
current index.

PacketList redraws when the *selected* index changes, not
the current index. Clearing the current index, and then marking
the same packet as selected and current fires currentChanged but
not selectionChanged. So drawCurrentPacket needs to call
clearSelection(), not clearCurrentIndex(), in order to trigger
a redissection of the currently selected packet and update
the packet details.

For example, if you mark or unmark the currently selected frame,
this causes the packet details to update. Cf 52955b9c43,
which fixed the same issue but for Find Packet.

Fix #14330.
2023-01-19 19:51:37 -05:00
John Thacker c380f516a2 GTP, GTPv2: Add request/response framenum types
Add the appropriate FT_FRAMENUM string types to the request
and response fields for GTP and GTPv2, so that arrows are
drawn for the related packet symbols.
2023-01-20 00:51:19 +00:00
João Valverde c22f47bba6 Wix: Remove leftover component 2023-01-19 22:17:11 +00:00
John Thacker 38fbccd33e Follow: Remove use of follow type from FollowStreamDialog
We can check if we have a follower. follow_type_t is still
used in the constructor, for now, since other parts call it.
2023-01-19 14:49:37 -05:00
João Valverde 2ab291b3b2 GUI: Ship license + acknowledgements as Qt resource 2023-01-19 19:14:32 +00:00
John Thacker 0a840b5dd8 Follow: Remove check for FOLLOW_TCP for fragments in Qt
Only TCP uses fragments, but we don't need to check FOLLOW_TCP
because the fragments pointers exist but are null if not being
used. See the similar code in epan/follow.c

Part of making it simpler for dissectors to register with Follow.
2023-01-19 18:34:45 +00:00
Sergey V. Lobanov 4d2d0b7f6d MP4: add support for segment boxes (styp, sidx)
sidx and styp boxes are implemented according to 3GPP TS 26.244
Both boxes are added as mp4 magic bytes due to mp4 segments start from them

pcap and mp4 samples: https://wiki.wireshark.org/SampleCaptures#mp4-init-segments-and-segments
2023-01-19 17:59:50 +00:00
João Valverde 776aafc7de CMake: Install CSS to DOCDIR 2023-01-19 17:55:20 +00:00
Kevin Grigorenko 43c5eedc97 Handle NULL http2_session_t parsing an H2 settings frame 2023-01-19 17:35:48 +00:00
João Valverde 74909f1499 Install PDML files to DOCDIR
Add README because this stuff is somewhat obscure and move XSLT
file to DOCDIR because it is not used by wireshark directly.
2023-01-19 17:08:36 +00:00
Joakim Karlsson c06a38da31 CMake: Update a compiler version check 2023-01-19 16:58:58 +00:00
Jorge Mora ae4868f4bd NFS: fix IO_ADVISE hints mask
Use correct tree for hints mask in IO_ADVISE so it is displayed
properly within the operation.
2023-01-19 15:40:38 +00:00
John Thacker 1dac8660fc DHCP: Use BASE_CUSTOM for formatting time options
Use BASE_CUSTOM and custom formatting functions for formatting
DHCP options that are time fields, instead of
proto_tree_add_uint_format_value(). This makes the formatted form
show up in columns.

Fix #18743
2023-01-19 09:41:55 +00:00
João Valverde 59b15749af Wix: Remove stale reference to dftest 2023-01-19 09:15:13 +00:00
Mikael Kanstrup c4db402db5 Add follow websocket stream support
The websocket protocol masking feature makes follow TCP stream
on websocket traffic show masked payload. To easily view unmasked
and reassembled websocket payload add follow websocket stream
support.
2023-01-19 03:14:18 +00:00
João Valverde 06519be205 Install documentation (HTML manuals) to DOCDIR
Install documentation to DOCDIR instead of DATADIR.
The code must be fixed to open the Help URLs from
this new path.

This only affects Unix-like FHS platforms. Windows
installation does its own thing.

Needs testing with macOS packaging.
2023-01-19 01:40:59 +00:00
João Valverde 9c9c5343d8 RPM: Remove some unnecessary doc files
INSTALL and READMEs for all the different platforms are totally
unnecessary and arguably wrong. ChangeLog is not useful either IMO.
2023-01-19 00:27:50 +00:00
João Valverde 9e6faf4169 Remove dftest man page
DFTest is a private test utility and isn't installed anywhere.

I don't think it makes sense to maintain a man page. Certainly
doesn't make sense to ship it.

The doc file is understandably minimal so just nuke it.
2023-01-19 00:17:56 +00:00
João Valverde 277605ac57 Windows: Do not ship dftest in installers
DFTest is a developer-oriented utility and none of the other
platforms ship it to end-users.

Remove it from the windows installers.
2023-01-19 00:17:56 +00:00
Gerald Combs 24ab9c0aaa Falco bridge+falcodump: Scan for personal plugins 2023-01-19 00:17:08 +00:00
Gerald Combs de7ca4c64a Packaging: Add a Logray AppImage package 2023-01-18 14:26:33 -08:00
Gerald Combs 5a9812ab61 AppRun: Set various paths
Set our ld library path and our data, extcap, and plugin directories.
Document WIRESHARK_EXTCAP_DIR and WIRESHARK_PLUGIN_DIR. Note that we
might want to set our various directories relative to the program path.
2023-01-18 20:37:08 +00:00
João Valverde a5eb85a1d6 Revert "ORAN FH CUS: Add subtree for bfwCompHdr"
This reverts commit 2c5f2e40fc.
2023-01-18 19:19:32 +00:00
Martin Mathieson 2c5f2e40fc ORAN FH CUS: Add subtree for bfwCompHdr 2023-01-18 14:59:17 +00:00
John Thacker b1f50b0b68 DNS: Add reverse DNS (PTR) answers to Resolved Addresses
If "use captured DNS packet data for name resolution" is enabled,
also use the information from PTR (reverse DNS) answers to fill
the hash table for IPv4 and IPv6 host resolution.

Fix #10036
2023-01-18 14:13:34 +00:00
João Valverde 3335197b42 RPM: Fix header installation 2023-01-18 13:03:55 +00:00
João Valverde 83f57bd4c2 Debian: Fix header installation 2023-01-18 10:51:51 +00:00
Kevin Grigorenko b301dee0e1 Add HTTP2 connection and session window sizes 2023-01-18 07:04:53 +00:00
João Valverde fe7bfdf6ca CMake: Require explicit installation of development headers
Develpment headers are a sizeable part of the binary installation
and most users won't ever require them. It's recommended to package
them separately in a devel package or SDK.

Create a CMake installation component for development headers
and add the EXCLUDE_FROM_ALL property.

Headers can be installed using the invocation:

    cmake --install <dir> --component Development
2023-01-18 03:35:13 +00:00
João Valverde 728073ade0 CMake: Do no install some misc CMake modules
These are build files, not part of the installation.
2023-01-18 02:46:45 +00:00
John Thacker a05104df66 Qt: Fix build on OpenSUSE 15.3
OpenSUSE requires explicitly including the QTime header.
Fixup 4d3d856d8f
2023-01-17 20:38:48 -05:00
Gerald Combs 2d8cdec477 NSIS: Update the donation page
Update the plea text and URL.
2023-01-17 21:17:33 +00:00
Gerald Combs d3d6db58fe Resources: Add Logray Freedesktop files 2023-01-17 20:58:31 +00:00
John Thacker 4d3d856d8f Qt: Conversation/Endpoint table Filter by different QVariant types
Return the percentage in the UNFORMATTED_DISPLAYDATA converted
from our string so it it compares properly with an equality filter.

Use QVariant comparisons where appropriate so that Filter by
works as expected with types that are not integers, such as doubles
the City/Country strings from GeoIP, or when absolute start time
is used for conversation starts.

Fix #18738.
2023-01-17 16:47:19 +00:00
João Valverde a201eaf118 MinGW: Enable -Werror by default 2023-01-17 15:04:40 +00:00
João Valverde b801ea0191 MinGW: Fix -Wclobbered 2023-01-17 15:04:40 +00:00
Alexis La Goutte 3504b423b9 MySQL: Fix Dead Store Found by Clang Analyzer
Line 3728 Value stored to 'offset' is never read
2023-01-17 14:18:31 +00:00
Pascal Quantin 2dd8345895 NR RRC: upgrade dissector to v17.3.0 2023-01-17 14:47:25 +01:00
John Thacker 9afd2f23ef Qt: Plug credentials model memory leak 2023-01-17 13:25:02 +00:00
John Thacker 058400d8e0 ECATMB: Get filename with encoding when adding to column
When retrieving a string, don't just use tvb_memcpy, even if
expected to be ASCII (because it might have errors.)

This doesn't get truncated, even if all replacement characters,
because the eventual returned buffer is 200 octets long and the
max filename is 49.

Fix #18800
2023-01-17 12:41:58 +00:00
Joris Peeraer 918c9c5d5c PFCP: add Nokia proprietary IEs 2023-01-17 10:17:24 +00:00
John Thacker ffdf332f24 docs: Explain the FT_FRAMENUM use of the strings field
Add a section about FRAMENUM_TYPE to the 'strings' field
section of README.dissector
2023-01-17 09:27:29 +00:00