osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

MinGW: Fix -Wbool-compare 

The return of -1 for negative infinity is glibc specific and
non-portable.

/epan/dissectors/packet-synphasor.c:1634:62: error: comparison of constant '-1' with boolean expression is always false [-Werror=bool-compare]
 1634 |                 if ((isinf(pmu_lat) == 1) || (isinf(pmu_lat) == -1)) {
      |                                                              ^~
This commit is contained in:
João Valverde 2023-01-13 20:20:45 +00:00
parent dfc992466e
commit 6870449734
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
epan/dissectors/packet-synphasor.c
View File

@ -1631,7 +1631,7 @@ static int dissect_config_3_frame(tvbuff_t *tvb, proto_item *config_item)
pmu_elev = tvb_get_ntohieee_float(tvb, offset + 8);
/* PMU_LAT */
if ((isinf(pmu_lat) == 1) || (isinf(pmu_lat) == -1)) {
if (isinf(pmu_lat)) {
proto_tree_add_float_format_value(wgs84_tree, hf_conf_pmu_lat_unknown, tvb, offset,
4, INFINITY, "%s", unspecified_location);
}
@ -1641,7 +1641,7 @@ static int dissect_config_3_frame(tvbuff_t *tvb, proto_item *config_item)
offset += 4;
/* PMU_LON */
if ((isinf(pmu_long) == 1) || (isinf(pmu_long) == -1)) {
if (isinf(pmu_long)) {
proto_tree_add_float_format_value(wgs84_tree, hf_conf_pmu_lon_unknown, tvb, offset,
4, INFINITY, "%s", unspecified_location);
}
@ -1651,7 +1651,7 @@ static int dissect_config_3_frame(tvbuff_t *tvb, proto_item *config_item)
offset += 4;
/* PMU_ELEV */
if ((isinf(pmu_elev) == 1) || (isinf(pmu_elev) == -1)) {
if (isinf(pmu_elev)) {
proto_tree_add_float_format_value(wgs84_tree, hf_conf_pmu_elev_unknown, tvb, offset,
4, INFINITY, "%s", unspecified_location);
}