Commit Graph

15218 Commits

Author SHA1 Message Date
Anders Broman bd42437262 Fix malformed packet if linkedId is present dissect some OID:s
svn path=/trunk/; revision=15533
2005-08-25 21:25:52 +00:00
Ulf Lamping 77a3d0991c add OUI's for Siemens and Xerox (and a hyperlink to the IEEE page)
svn path=/trunk/; revision=15532
2005-08-25 21:01:42 +00:00
Anders Broman 557df81507 From Timo Metsala
Changes:

o Implemented CRC and SHA-1 (sort operations are still missing)

o After state acccess, the execution start is not necessarily the
  beginning of the bytecode; start IP is now a new parameter to
  decompress_sigcomp_message()

o Removed some hard-coded assumptions about bytecode starting at offset
   128

svn path=/trunk/; revision=15531
2005-08-25 19:23:15 +00:00
Luis Ontanon f1ba6f515f http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=377
svn path=/trunk/; revision=15530
2005-08-25 15:48:28 +00:00
Gerald Combs 1b8f8ffcb3 Fix sorting in the "Ports" columns. Add a comment about address sorting.
Remove unused code.

svn path=/trunk/; revision=15529
2005-08-25 13:58:34 +00:00
Guy Harris 3c01b45ac2 Show dBm and dB signal and noise values differently, so that the user
knows what they're getting.

svn path=/trunk/; revision=15528
2005-08-25 08:16:08 +00:00
Ronnie Sahlberg 7acbc26396 when tracking PDU bondaries, only do this IFF
the next few bytes match an SMB header.

1,  SMB is the only important protocol transported atop NBSS
2, if we miss the first packets of a PDU, we DONT! want nbns to suddenly think  there are Xmegabytes until the end of it and thus prevent any real PDUs from being dissected.



svn path=/trunk/; revision=15527
2005-08-25 07:45:57 +00:00
Guy Harris 9b4994afcd I missed one OID string.
svn path=/trunk/; revision=15526
2005-08-25 03:43:16 +00:00
Guy Harris bcb91d2f45 The OID strings returned by new_format_oid(), and the OID string
returned by format_oid(), are allocated with the ep_alloc routines;
don't free them.

svn path=/trunk/; revision=15525
2005-08-25 03:31:54 +00:00
Guy Harris bd8c6df460 "sprint_realloc_objid()" expects to be handled a malloced buffer, so
hand it one (and check for malloc failures), and it returns a malloced
or realloced buffer, so free it when we're done.

That means that routines that use it can return/supply back a null
pointer, so check for that.

Don't ep_allocate fixed-length buffers for formatted OID information,
allocate one that's 'big enough".

svn path=/trunk/; revision=15524
2005-08-25 03:28:31 +00:00
Guy Harris 16e2c6605d The "secs" field of a "struct wtap_nstime" is a time_t, so it could be
an int or it could be a long; print stuff computed from it with %lu, and
cast the arguments to "long" so that it works on platforms where time_t
*isn't* a long and where "long int" and "int" have different sizes.

svn path=/trunk/; revision=15523
2005-08-25 01:16:40 +00:00
Guy Harris 72e862b129 The time stamp in a Wiretap packet header is now a wtap_nstime, not a
"struct timeval".

svn path=/trunk/; revision=15522
2005-08-24 23:53:40 +00:00
Ulf Lamping d90d0f9e7c fix usec -> nsec translation
svn path=/trunk/; revision=15521
2005-08-24 22:27:21 +00:00
Ulf Lamping 6f43fbb2f0 EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...

What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.

As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.

Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...

As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...

svn path=/trunk/; revision=15520
2005-08-24 21:31:56 +00:00
Gerald Combs ef81f7d060 Properly initialize our hf_ arrays. Make hf_rtcp_app_poc1_conn_session_type
an FT_UINT8 instead of an FT_BOOLEAN.  This keeps the Solaris builder from
crashing while running "-G values".

svn path=/trunk/; revision=15519
2005-08-24 20:34:15 +00:00
Ulf Lamping 4b0b7448fd fix a comment typo
svn path=/trunk/; revision=15518
2005-08-24 18:35:54 +00:00
Ronnie Sahlberg 6d5d4f8bec From Graeme Hewson
Fix for infinite loop of configure events that were present for early GTK 2.4 in addition to 2.2



svn path=/trunk/; revision=15517
2005-08-24 07:28:28 +00:00
Guy Harris f95233a889 The name in a Display TLV is null-terminated (or padded with a null byte
and extra crud).

Don't bother with length checking on the VLAN name item - if it's
zero-length, so be it.

svn path=/trunk/; revision=15516
2005-08-23 08:49:57 +00:00
Guy Harris a7933c7cc5 Use "format_text()" and "tvb_format_text()" when displaying strings.
(It's not necessary, or desirable, to use them when fetching strings.)

When processing a VLAN TLV, check the length of the TLV, so we don't end
up running past the end of the TLV and getting a negative remaining
length.  Append to the protocol tree item for the TLV, and the Info
column, as we dissect the VLAN ID and VLAN name fields.

svn path=/trunk/; revision=15515
2005-08-23 08:34:19 +00:00
Guy Harris 9fa5d5fd9e Fix the parenthesization of an expression.
svn path=/trunk/; revision=15514
2005-08-23 08:01:46 +00:00
Luis Ontanon 9362605183 Two fixes to tektronix k12 import:
- it appears that there are more packet record types other than 0x00010020.
     accept anything matching 0x00010020/28 as a packet record.

- make the stack filename lowercase before comparing it so that capitalization is not an issue.


svn path=/trunk/; revision=15513
2005-08-22 23:11:48 +00:00
Jörg Mayer 412ae3d09d Length of string == lengt of element - headerlength
svn path=/trunk/; revision=15512
2005-08-22 17:48:17 +00:00
Anders Broman bdec656b1a From Timo Metsala:
Updates the  PoC floor control parsing to comply to the latest version of the 
specification. 

svn path=/trunk/; revision=15511
2005-08-22 16:26:29 +00:00
Anders Broman 1f0b3d1d38 Fix decoding of sendIdentificationArg/Res and ProvideSubscriberLocation
svn path=/trunk/; revision=15510
2005-08-22 16:19:31 +00:00
Guy Harris 86ea8b88f3 Add a "time_stat_init()" routine to initialize the fields of a
"timestat_t".

Move "nstime_to_msec()" to "epan/nstime.c", as it has nothing to do with
a "timestat_t".

Use structure assignment when possible.

Fix the "addtime()" macro and use it in "time_stat_update()".

Use "timestat_t"s, and the routines to manipulate them, in the service
response time table code.

svn path=/trunk/; revision=15509
2005-08-22 07:12:20 +00:00
Anders Broman 6d52a0369a From Graeme Lunt:
Zero length elements (e.g. an empty SET) the logic is slightly wrong in get_ber_length().

Make SET work.


svn path=/trunk/; revision=15508
2005-08-22 05:49:09 +00:00
Guy Harris d742f07d5c Export get_timesum().
svn path=/trunk/; revision=15507
2005-08-21 23:24:20 +00:00
Guy Harris 50ed5c9159 Use "g_strdup_printf()" rather than formatting into a fixed-length
buffer and "g_strdup()"ing it.

Use the nstime.c routines to compute time deltas and to add up times.

Don't add rows to the CList until a procedure gets a non-zero call
count, so only the ones with non-zero call counts are displayed (and
especially so that procedure numbers not corresponding to real
procedures aren't displayed!).

Ethereal requires 64-bit integer support, so don't bother checking
whether we have it.

Use the right format for 64-bit integers.

svn path=/trunk/; revision=15506
2005-08-21 21:50:49 +00:00
Jörg Mayer 81b9fa64b5 - Make it possible to filter on eap.null, eap.info, eap.unknown etc
- Display "Info" instead of "System" in packet summary
- Make the Null element look like the other elements.
- Small element summary formatting changes

svn path=/trunk/; revision=15505
2005-08-21 21:32:19 +00:00
Guy Harris 1bd66768de Use the tap_dfilter_dlg mechanism.
svn path=/trunk/; revision=15504
2005-08-21 20:24:59 +00:00
Guy Harris 06a670ae9b Use the tap_dfilter_dlg code.
svn path=/trunk/; revision=15503
2005-08-21 20:16:12 +00:00
Jörg Mayer 547efe8ee3 - In the info summary, port# and slot# were exchanged
- In the Display element, the length of the display string
  was 4 too long
- Display the Vlan id in the packet summary, not just "Vlan"
- Remove trailing whitespace


svn path=/trunk/; revision=15502
2005-08-21 19:25:45 +00:00
Guy Harris 13e0b409cf As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so
that it doesn't appear to be part of GTK+.

svn path=/trunk/; revision=15501
2005-08-21 19:24:11 +00:00
Anders Broman 78e0a2b458 From Mike Duigou:
A patch to the JXTA dissector. It's purpose is to improve 
the behaviour of the dissector when dissecting captures that do not 
include the whole conversation.

The dissector is now more capable of isolating a conversation without 
seeing the beginning of the conversation. It's still not always able to 
pick up all conversations (suggestions, patches and hints welcome).

improved some of the doxygen docs and comments.

svn path=/trunk/; revision=15500
2005-08-21 18:42:54 +00:00
Ulf Lamping 06c86303e7 The protocol item in the protocol tree will have a gray background now, which makes it much better visible.
Add some more optional flags to the protocol items, so more "special cases" can be marked in the protocol tree.

New flags:
/** The protocol field has a bad checksum */
FI_CHECKSUM_ERROR
/** The protocol field has an unusual sequence (e.g. TCP window is zero) */
FI_SEQUENCE_WARNING
/** The protocol field has a bad sequence (e.g. TCP segment is lost) */
FI_SEQUENCE_ERROR

svn path=/trunk/; revision=15499
2005-08-21 15:23:48 +00:00
Ulf Lamping 808b6d48d0 as discussed some time ago: don't add bad checksum fields conditionally but use a subtree and use boolean flags instead
svn path=/trunk/; revision=15498
2005-08-21 15:13:47 +00:00
Anders Broman 929bd9dc39 remove sprintf from gsm_a
Do the update for the .cnf file too.

svn path=/trunk/; revision=15497
2005-08-21 13:52:33 +00:00
Guy Harris b3562ac040 "gtk_tap_dfilter_dlg_cb()" is no longer used outside
gtk/tap_dfilter_dlg.c; don't export it.

That means that gtk/tap_dfilter_dlg.h is no longer useful; get rid of
it.

Rename "gtk_tap_dfilter_dlg_cb()" to "tap_dfilter_dlg_cb()", as it's
inside GTK+-specific code, so there's no need to distinguish it from
non-GTK+ callbacks.

Update some comments to reflect the name change and the new API for
registering tap_dfilter_dlg stats.

Make the AFP and SMB stats use the gtk/tap_dfilter_dlg.c stuff.

svn path=/trunk/; revision=15496
2005-08-21 11:09:36 +00:00
Guy Harris 195c549d1a Have "register_dfilter_stat()" add "..." to the menu item, as all menu
items registered with it pop up a dialog box before displaying the stat.
Don't pass a name with "..." to it.

Put "..." into other menu items that pop up a dialog box before
displaying the stat; remove "..." from other menu items that don't.

svn path=/trunk/; revision=15495
2005-08-21 10:29:47 +00:00
Guy Harris 997601f754 Set properties.
svn path=/trunk/; revision=15494
2005-08-21 10:00:56 +00:00
Guy Harris a0e68da918 Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".

Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.

Get rid of headers not declaring any functions not being used in the
module.

svn path=/trunk/; revision=15493
2005-08-21 09:48:27 +00:00
Ronnie Sahlberg e88b3ccb32 remove sprintf from gsm_a
svn path=/trunk/; revision=15492
2005-08-21 01:52:09 +00:00
Ronnie Sahlberg bc3abb6ace remove gmalloc and sprintf
svn path=/trunk/; revision=15491
2005-08-21 01:14:43 +00:00
Ronnie Sahlberg 73d84924b5 remove sprintf
svn path=/trunk/; revision=15490
2005-08-21 00:55:46 +00:00
Guy Harris ce8ac34225 The routines registered with "register_stat_cmd_arg()" *are* called if
you use the "-z" command-line options for them; make them pop up the
appropriate windows.

Move the calls to "register_stat_cmd_arg()" after the code to register
the tap, just as the calls to "register_stat_menu_item()" are done after
registering the tap.

Use "g_strdup_printf()" rather than formatting into a fixed-length
buffer and "g_strdup()"ing that buffer.

svn path=/trunk/; revision=15489
2005-08-20 22:28:49 +00:00
Guy Harris 65064719d3 We already have a tap that registers as a command-line stat under the
name "rtp"; we don't need another one, especially given that
"rtp_stream.c" doesn't directly implement a stat (note that it doesn't
register a menu item).

svn path=/trunk/; revision=15488
2005-08-20 22:26:32 +00:00
Ulf Lamping cf3b9f23e5 capture_sync.c(290) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(290) : warning C4022: 'g_realloc' : pointer mismatch for actual parameter 1
capture_sync.c(431) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(431) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1
capture_sync.c(442) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(442) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1
capture_sync.c(549) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(549) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1

svn path=/trunk/; revision=15487
2005-08-20 22:16:12 +00:00
Ronnie Sahlberg 91c1db961b remove sprintf
svn path=/trunk/; revision=15486
2005-08-20 22:15:39 +00:00
Ulf Lamping 03ea549ecc radius_dict.l(216) : warning C4090: 'function' : different 'const' qualifiers
radius_dict.l(216) : warning C4022: 'g_hash_table_insert' : pointer mismatch for actual parameter 2
radius_dict.l(268) : warning C4090: 'function' : different 'const' qualifiers
radius_dict.l(268) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1

svn path=/trunk/; revision=15485
2005-08-20 22:08:35 +00:00
Ronnie Sahlberg b0476bbe19 removal of sprintf
svn path=/trunk/; revision=15484
2005-08-20 22:06:31 +00:00