Commit Graph

15218 Commits

Author SHA1 Message Date
Ronnie Sahlberg 1df55c8071 remove g_malloc from manolito
svn path=/trunk/; revision=15383
2005-08-17 09:11:37 +00:00
Ronnie Sahlberg d7cf8bfc97 remove g_malloc()s from rtcp
svn path=/trunk/; revision=15382
2005-08-17 08:54:25 +00:00
Ronnie Sahlberg 68bfa7736e replace g_malloc() with ep_alloc() for ftp and sdp
sdp never free the allocated memory so it were leaking memory for every packet containng sdp.
fix memleak for sdp


svn path=/trunk/; revision=15381
2005-08-17 08:50:04 +00:00
Ronnie Sahlberg db4cbf9537 remove g_malloc() from rip remove one g_malloc() from tacacs
svn path=/trunk/; revision=15380
2005-08-17 08:43:40 +00:00
Ronnie Sahlberg 2046fd75b8 from Tomas Kukosa, remove a redundant g_strdup()
svn path=/trunk/; revision=15379
2005-08-17 08:31:54 +00:00
Jörg Mayer 05856f3519 - Small comment updates.
- Add some info about the element to the top level.

svn path=/trunk/; revision=15378
2005-08-16 21:38:18 +00:00
Gerald Combs 877d75d1a2 For "-G decodes", print the selector values as unsigned ints.
svn path=/trunk/; revision=15377
2005-08-16 16:11:02 +00:00
Gerald Combs e66c31ddd0 Add a note about sFlow. Remove the CSM_ENCAPS bug; I inadvertently
reintroduced it after the 0.10.12 release.

svn path=/trunk/; revision=15376
2005-08-16 16:09:49 +00:00
Gerald Combs 2f2a3fedd3 In packet-sflow.c, don't pass a NULL value pointer to
proto_tree_add_ipv6().  Add tree items for the extended router source
and dest mask, and fix offsets.  These changes appear to be correct,
but I don't have a valid capture with extended router data.

In proto.c, throw a dissector error if we try to pass a NULL value to
various proto_tree_set_*() routines.

Fixes bug 356.


svn path=/trunk/; revision=15375
2005-08-16 16:04:30 +00:00
Ronnie Sahlberg 75f38fa0a5 add SetFileInfo level 1013 SetDispositionInfo decoding
svn path=/trunk/; revision=15374
2005-08-16 08:40:06 +00:00
Ronnie Sahlberg e7d5fbaeff prettify MNT (and friends) by placing the path in COL_INFO
svn path=/trunk/; revision=15373
2005-08-16 07:49:03 +00:00
Jörg Mayer 0b845c626f Change the default font size on Unix (etc) to 10 pt, just as it was
already on Windows.
Changed the default font to Monospace, as some Linux distributions did
that already. In case this isn't available on all platforms we will
need to change it back to "fixed medium".

svn path=/trunk/; revision=15372
2005-08-16 06:48:06 +00:00
Jörg Mayer 0f9ffd6923 Move SVNVERSION handling into version_info. That way, we won't have
to recompile tethereal.o etc each time the svn version has changed,
relinking is sufficient.

I'm not sure what to do about mergecap, as it currently doesn't link
against version_info, so it's "overhead" either way.

svn path=/trunk/; revision=15371
2005-08-16 06:45:17 +00:00
Guy Harris bc35e184c7 Change to match more closely the way I read 802.11h, at least; I'm just
guessing about the "17" indicator for "management notification" frames -
I'm not sure whether, after paying USD 60 to get the current 802.11e
draft, Preview on my Mac could even decrypt it.

802.11h seems to say in 7.2.3.12 and 7.3.1.11 that the body of an Action
frame has a 1-byte Category field, with a value of 0 meaning "Spectrum
management", followed by, for Spectrum management, a 1-byte Action
field, with 0=Measurement Request, 1=Measurement Report, 2=TPC Request,
3=TPC Report, and 4=Channel Switch Announcement, followed by:

	for all but Channel Switch Announcement, a 1-byte Dialog Token
	followed by some tagged parameters;

	for the Channel Switch announcement, some tagged parameters.

Show some fields given in decimal in various 802.11 specs in decimal,
not hex.

svn path=/trunk/; revision=15370
2005-08-16 06:09:39 +00:00
Guy Harris 3b6b4817e1 From Peter Johansson: add an option to decode the client information,
and check the validity of messages a bit more carefully.

Reformat a bit so not as much code is missed by those of us who like
narrow editor windows.

svn path=/trunk/; revision=15369
2005-08-16 05:58:50 +00:00
Guy Harris 79588aa6e9 The real problem is that iTunes requests gzipped data and responds with
it, so unless you're reassembling headers and bodies the DAAP dissector
will see the gzipped crap.  The HTTP dissector should perhaps not bother
handing gzipped or otherwise unusually-encoded bodies to subdissectors
if it's not undoing the encoding.

svn path=/trunk/; revision=15368
2005-08-16 02:04:02 +00:00
Guy Harris 7de213fc6a gcc4 gets confused by the break statements, and I guess it thinks you
can reach them, and thus thinks you can fall off the end of
"fc_get_ftype()".

svn path=/trunk/; revision=15367
2005-08-16 01:34:44 +00:00
Guy Harris 21ab160bcd Note where a table comes from, and that we don't use it.
svn path=/trunk/; revision=15366
2005-08-16 01:24:19 +00:00
Luis Ontanon 158ada58b3 se_alloc not ep_alloc!
svn path=/trunk/; revision=15365
2005-08-16 01:01:17 +00:00
Luis Ontanon 0de8a67599 more allocators se_alloc0() se_memdups() se_strdup() se_strndup() se_strdup_printf()
svn path=/trunk/; revision=15364
2005-08-16 00:55:08 +00:00
Jörg Mayer 1c37d9592a - Update manuf
- Add some Extreme MAC addresses to wka.tmpl

svn path=/trunk/; revision=15363
2005-08-15 21:06:09 +00:00
Jörg Mayer 13bde76d02 - Change $1 to $@
- Don't exit if we can't find the scripts - try to continue anyway,
  as they might be installed in some preconfigured system directory.

svn path=/trunk/; revision=15362
2005-08-15 20:31:57 +00:00
Gerald Combs 5a7164249e When we create a new tvb, make sure the memory is freed at some point.
svn path=/trunk/; revision=15361
2005-08-15 20:28:04 +00:00
Anders Broman a8a4c251f0 TP-PI (TP-Parameter-Indicator) is optional.
svn path=/trunk/; revision=15360
2005-08-15 19:35:09 +00:00
Jörg Mayer 27245a1d1f Properly dissect vlan flags
svn path=/trunk/; revision=15359
2005-08-15 15:50:25 +00:00
Jörg Mayer 7733254253 - Documentation update
- The slot and port numbers printed on the chassis are off by
  one when compared to the transmitted values (reported by
  Jim Young).

svn path=/trunk/; revision=15358
2005-08-15 12:41:08 +00:00
Ronnie Sahlberg 12e2db899c ememify g_malloc() calls
svn path=/trunk/; revision=15357
2005-08-15 12:04:15 +00:00
Ronnie Sahlberg 6a87b85451 ememify g_malloc() calls
svn path=/trunk/; revision=15356
2005-08-15 11:53:57 +00:00
Jörg Mayer 956eee946f Some 'no previous declararion' warning fixes
svn path=/trunk/; revision=15355
2005-08-14 23:25:20 +00:00
Ronnie Sahlberg 9e7dbe202b ememify sip and at the same plug a memleak
every single time the sip dissector was called   a 32byte or larger blob was g_malloced and never freed.
this not only leaks 32+ bytes + g_malloc bookkeeping overhead  but also fragments memory so the real leak of memory is likely much bigger.


fix  bad memleak


svn path=/trunk/; revision=15354
2005-08-14 06:00:20 +00:00
Ronnie Sahlberg f6d36d20d0 ememify cip
svn path=/trunk/; revision=15353
2005-08-14 05:54:54 +00:00
Ronnie Sahlberg eb994de4cb change a g_malloc() that was never released into ep_alloc()
this function would always leak memory when called.

this fixes a memleak in dcm



svn path=/trunk/; revision=15352
2005-08-14 05:50:14 +00:00
Ronnie Sahlberg 675e61a8a4 ememify packet-x11
plug a memleak for ...].strptr   that is alloced by g_malloc() but never released.



svn path=/trunk/; revision=15351
2005-08-14 05:37:12 +00:00
Ronnie Sahlberg 185d5c2f04 giop allocates only and never releases the memory from the gmemchunk so replace it with equivalen g_malloc() calls and get rid of the gmemchunks
svn path=/trunk/; revision=15350
2005-08-14 01:48:43 +00:00
Ronnie Sahlberg 6411d20b50 the tds dissector were only using a GMemChunk as a simple way to prevent memleaks in case of an exception. (reset the gmemchunk at the start of each packet)
replace this gmemchunk with ep_alloc()


svn path=/trunk/; revision=15349
2005-08-14 01:41:55 +00:00
Ronnie Sahlberg 99d08f067e remove two more GMemChunks
svn path=/trunk/; revision=15348
2005-08-14 01:26:34 +00:00
Ronnie Sahlberg 10f8a36eda get rid of another two GMemChunks
svn path=/trunk/; revision=15347
2005-08-14 00:37:05 +00:00
Ronnie Sahlberg 88f1cd4201 Data sources have a lifetime spanning a single packet
so instead for g-alloc and g_free   data
just use ep_alloc() that is automatically freed instead.

this also gets rid of one more GMemChunk



svn path=/trunk/; revision=15346
2005-08-14 00:26:56 +00:00
Ronnie Sahlberg f8d286b7e3 add dissection of two more SSC commands
add 4 commands from SMC to the SSC tables.
the fallback for missing commands/i.e. commands defined outside the SSC
only handles SPC   I.e.  If a command for SSC is missing in the SSC tables, assume it might be imported from SPC instead.

This fallback only works with opcodes imported from SPC.


svn path=/trunk/; revision=15345
2005-08-14 00:10:41 +00:00
Guy Harris fc9d3d4165 Use gboolean for Booleans.
Use "proto_tree_add_item()" whenever possible.

svn path=/trunk/; revision=15344
2005-08-13 22:35:50 +00:00
Guy Harris ebb23fbc68 Construct the tvbuff for the payload of an 802.3 packet to have the
appropriate length (min(reported length, captured data present)).

svn path=/trunk/; revision=15343
2005-08-13 22:34:44 +00:00
Guy Harris 79dcb408d3 Properly terminate the string generated for string items.
Use "format_text()" to handle non-printable characters in the display
string for those items.

svn path=/trunk/; revision=15342
2005-08-13 22:08:22 +00:00
Guy Harris 0fb64bd9cb Get rid of unused variables.
Use "tvb_format_text()" and friends to format strings for display.

Don't throw an exception on errors if we can keep dissecting.

Use "PROTO_ITEM_SET_GENERATED()" to mark items as generated.

If an item covers real data, it's not generated.

Dissect WRITE FILEMARKS (6) (we already had a dissector, but it wasn't
being used).

svn path=/trunk/; revision=15341
2005-08-13 22:05:01 +00:00
Gerald Combs 871bcab448 Add an item for CSM_ENCAPS.
svn path=/trunk/; revision=15340
2005-08-13 18:52:41 +00:00
Gerald Combs 078df6ca6c Fix another infinite loop found by randpkt.
svn path=/trunk/; revision=15339
2005-08-13 18:49:57 +00:00
Anders Broman 5030bf580c Get rid of an unused variable, don't include tcap.h and remove some redundant code.
svn path=/trunk/; revision=15338
2005-08-13 10:17:20 +00:00
Anders Broman 1f31e083d2 From Peter Johansson:
mnc>>4; Should  be replaced with mnc = mnc>>4;

svn path=/trunk/; revision=15337
2005-08-13 10:11:23 +00:00
Guy Harris 51769bfaac "fi" comes before "fr" in alphabetical order. (This also makes it match
the main "ethereal.desktop" file.)

Expand the RCS ID.

svn path=/trunk/; revision=15336
2005-08-13 08:10:12 +00:00
Guy Harris ccbb97ed45 Do the sequence number analysis *before* dissecting the payload, so we
don't have to worry about catching exceptions in the payload dissection
and doing the sequence number analysis - we weren't doing so in one
place.  That also puts the sequence number analysis *before* the "TCP
payload" entry for payload being reassembled into a later packet.

XXX - should we do the tapping before dissecting the payload, too, so
that it gets done even if we throw an exception?

svn path=/trunk/; revision=15335
2005-08-13 07:30:57 +00:00
Jörg Mayer 9503bca967 Small optimization
svn path=/trunk/; revision=15334
2005-08-13 06:42:19 +00:00