Commit Graph

34580 Commits

Author SHA1 Message Date
Martin Mathieson b138ffa9e7 Avoid some unnecessary assignments (as reported by clang).
svn path=/trunk/; revision=36204
2011-03-16 23:18:59 +00:00
Martin Mathieson c1d824c46c Don't increment after reading last outheader value (as reported by clang).
svn path=/trunk/; revision=36203
2011-03-16 23:01:33 +00:00
Martin Mathieson f558138026 Avoid having large buffers on the stack (as noted in VS Code Analyzer warnings).
svn path=/trunk/; revision=36202
2011-03-16 22:53:41 +00:00
Martin Mathieson 46f9b98003 2 VS Code Analyzer warnings were bogus. Avoid one and add a comment about the second one.
svn path=/trunk/; revision=36201
2011-03-16 22:51:45 +00:00
Chris Maynard 14ae6b8405 From Jakub Zawadzki: Annotate Jakub as the author of the JSON dissector.
svn path=/trunk/; revision=36200
2011-03-16 20:32:53 +00:00
Chris Maynard d40ddf49c6 From Fulko Hew via bug 5755: Fix dissect_octet_string() so it properly displays
strings of any length.

svn path=/trunk/; revision=36199
2011-03-16 14:51:53 +00:00
Anders Broman 9486d7dcc2 From Roland Knall:
Patch, which removes both EPL and EPLv1 .h files, as well as adding a heuristic dissector hook to EPL (v1 is nearly nowhere in use anymore, therefore not needed)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5751

svn path=/trunk/; revision=36198
2011-03-16 06:21:56 +00:00
Martin Mathieson da45af3980 Try to fix checkApi script.
svn path=/trunk/; revision=36197
2011-03-15 22:55:53 +00:00
Martin Mathieson 2e7a9893c3 Fix calling of LTE dissectors for R9 DCT protocols.
svn path=/trunk/; revision=36196
2011-03-15 17:30:00 +00:00
Anders Broman 23400cd7a3 Add dissection of
- MBMS-SESSION-STOP-REQUEST
- MBMS-SESSION-STOP-RESPONSE
- MBMS-SESSION-UPDATE-REQUEST
- MBMS-SESSION-UPDATE-RESPONSE
- PS-HANDOVER-COMPLETE
- PS-HANDOVER-CANCEL
- PS-HANDOVER-COMPLETE-ACK

svn path=/trunk/; revision=36195
2011-03-15 06:03:58 +00:00
Stephen Fisher 55b1e9a877 Add expert info to UDP dissector for showing possible (Unix-style)
traceroute packets: if the port number range is 33434 to 33434 + 30.


svn path=/trunk/; revision=36194
2011-03-14 22:01:49 +00:00
Stephen Fisher 1fc46d7c4d Don't verify the checksum of an ICMP packet when it the payload of an
error packet (pinfo->in_error_pkt), such as an ICMP destination
unreachable, because we probably don't have the whole original packet.


svn path=/trunk/; revision=36193
2011-03-14 19:58:02 +00:00
Gerald Combs 670d38ec71 Properly initialize our filter counters.
svn path=/trunk/; revision=36190
2011-03-14 16:00:51 +00:00
Anders Broman ab7e2fd487 Export
tvb_new_composite
tvb_composite_finalize
tvb_composite_append

svn path=/trunk/; revision=36188
2011-03-14 14:05:51 +00:00
Jaap Keuter 15a032af98 Fix for bug 3933:
Decode TCP port 2443 as Secure Skinny (SCCPS).

svn path=/trunk/; revision=36187
2011-03-14 07:49:05 +00:00
Anders Broman 338f238746 Add dissection of
- MBMS-SESSION-START-REQUEST
- MBMS-SESSION-START-RESPONSE

svn path=/trunk/; revision=36186
2011-03-14 07:15:25 +00:00
Gerald Combs 4d6d8c58a5 [Automatic manuf, services and enterprise-numbers update for 2011-03-13]
svn path=/trunk/; revision=36183
2011-03-13 15:03:43 +00:00
Anders Broman 5b60867fc6 ../../../epan/dissectors/packet-gtp.c:5607: error: unused variable ‘length’
svn path=/trunk/; revision=36182
2011-03-13 09:33:45 +00:00
Anders Broman 285513860c Add sub dissection of AVP MBMS Service Area.
svn path=/trunk/; revision=36181
2011-03-12 23:26:55 +00:00
Bill Meier a37493fe16 Fix bug #5189: Wireshark crashes when cancelling a large sort operation.
Essentially: Don't try to sort if the pre-requisite "columnization" step is stopped
             via the progressbar dialog window before the step completes.
Also: Fix a (very) minor bug wherein the sort-indicator not always cleared on the
      "previous column" when "No Sorting" was selected from a column context menu.
Also: Do minor code, comments & whitespace cleanup.

svn path=/trunk/; revision=36180
2011-03-12 19:02:24 +00:00
Stig Bjørlykke d3cff4643b Use TRUE/FALSE for encoding_info to make it build.
Added packet-mndp.c to Makefile build.

svn path=/trunk/; revision=36179
2011-03-12 12:09:52 +00:00
Stephen Fisher a8a7de17ea Improve r36177 per Guy's suggestion at bug #5746 to always call the
PPP-over-HDLC dissector since it will do the check for us to see if
the HDLC framing is present or not.


svn path=/trunk/; revision=36178
2011-03-12 02:06:25 +00:00
Chris Maynard ebe492525f Handle PPP in HDLC framing. Fixes bug 5746.
svn path=/trunk/; revision=36177
2011-03-12 01:32:35 +00:00
Chris Maynard a96eed7007 Add emem_tree_lookup32_array_le. Resolves bug 5744.
svn path=/trunk/; revision=36176
2011-03-09 17:20:29 +00:00
Jörg Mayer df9543e3a1 Update/correct some TLVs
svn path=/trunk/; revision=36175
2011-03-09 13:27:13 +00:00
Bill Meier ff6cd61a00 Check that imported private key is RSA; Prevents a crash.
Fixes Bug #5662

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5662

svn path=/trunk/; revision=36174
2011-03-09 00:43:49 +00:00
Chris Maynard 41c433856f Display a console warning instead of a simple_dialog for invalid color filters.
svn path=/trunk/; revision=36173
2011-03-08 21:21:48 +00:00
Stephen Fisher a96e3dbe3b A little more old packet list cleanup
svn path=/trunk/; revision=36172
2011-03-08 20:23:48 +00:00
Anders Broman 49ac7b9759 W -> E for g_clist funktions.
svn path=/trunk/; revision=36171
2011-03-08 19:55:22 +00:00
Jörg Mayer 3fc5ee8f53 Add support for Mikrotiks Neigbor Discovery Protocol (MNDP).
Sample capture at
http://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=mndp.pcap

svn path=/trunk/; revision=36170
2011-03-08 19:10:46 +00:00
Chris Maynard 2cc88f04a1 Don't bother creating/finding conversations if we're encapsulated within an
error packet, such as an ICMP destination unreachable.  Prior to this change,
I had captures that showed such encapsulated requests with responses indicated
in other frames, which obviously can't be true.

svn path=/trunk/; revision=36169
2011-03-08 18:52:12 +00:00
Chris Maynard 4d20bdd60d Conversation tracking must be handled whether "tree" is NULL or not.
svn path=/trunk/; revision=36168
2011-03-08 18:33:45 +00:00
Jörg Mayer cf8c877d0d Add support for the pre-rfc DAE port 1700
svn path=/trunk/; revision=36167
2011-03-08 18:29:30 +00:00
Chris Maynard ac6ae6dbd3 Allow <variance> to be successfully sscanf'd no matter the locale for the
decimal symbol.  Same change and reason as for revision 36160.

svn path=/trunk/; revision=36166
2011-03-08 14:57:38 +00:00
Bill Meier dbc7c80782 Remove the 'NEW_PACKET_LIST' defines & etc (since the code no longer supports the old packet list)
svn path=/trunk/; revision=36165
2011-03-08 14:55:07 +00:00
Jeff Morriss ec75406c30 Remove the --enable-new-packet-list option (since the code no longer supports the old packet list)
svn path=/trunk/; revision=36164
2011-03-08 14:41:12 +00:00
Bill Meier d9beb8fcb0 From Martin Kaiser: initialize hdr_tag with NO_TAG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654

svn path=/trunk/; revision=36163
2011-03-08 13:52:16 +00:00
Sake Blok f28084f772 Fix for bug 5743 : tshark incorrectly calculates tcp stream for SYN packets when port numbers are re-used
svn path=/trunk/; revision=36162
2011-03-08 11:26:34 +00:00
Sake Blok 307c0d70fb Removal of the old packet-list in favor of the new packet list.
It compiles with "./configure without options" on my Mac. Let's see what the buildbots have to say about it :-)


svn path=/trunk/; revision=36161
2011-03-08 01:52:25 +00:00
Chris Maynard 4f8edc81e6 Allow <interval> to be successfully sscanf'd no matter the locale for the
decimal symbol.  Similar to the fix made to tap-iostat.c to resolve bug 2880.

Motivated by the discussion started from this thread on the user list:
http://www.wireshark.org/lists/wireshark-users/201103/msg00018.html

svn path=/trunk/; revision=36160
2011-03-07 21:58:30 +00:00
Jeff Morriss e6ce1793e2 Don't pass retransmitted chunks to subdissectors. Instead just mark them as
retranmissions (in COL_INFO).  (Obviously this only works if TSN analysis is
enabled.)

This should make it more obvious to users which chunks are retransmissions and
will help avoid confusing the subdissector(s).

svn path=/trunk/; revision=36159
2011-03-07 19:23:55 +00:00
Anders Broman aac7fca686 From Alexis La Goutte:
enhance tag Power Constraint/Capability, TPC Request/Report, Supported Channel, csa 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36158
2011-03-07 17:46:30 +00:00
Stephen Fisher 664916ad64 Squelch compiler warning:
packet-dvbci.c: In function 'dissect_dvbci_lpdu':
packet-dvbci.c:1153: warning: 'hdr_tag' may be used uninitialized in this function
packet-dvbci.c:1153: note: 'hdr_tag' was declared here

By setting hdr_tag = 0, but see question on bug #5654 on whether 0 is a 
good default value or not.


svn path=/trunk/; revision=36157
2011-03-07 17:01:55 +00:00
Bill Meier 523d4d1cbe From Stefan Metzmacher: smb2 multi-credit / large mtu support
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5729

From me: Update a comment re the "epoch" field: It's now called "credit charge".

svn path=/trunk/; revision=36156
2011-03-07 16:43:55 +00:00
Anders Broman 24133413b9 Remove a no longer needed struct.
svn path=/trunk/; revision=36155
2011-03-07 12:31:49 +00:00
Anders Broman 840b816f05 Remove more obsolete code.
svn path=/trunk/; revision=36154
2011-03-07 11:56:21 +00:00
Anders Broman 6c47c809ef Fix packet-bssgp.c:125: warning: 'hf_bssgp_tmsi_ptmsi' defined but not used
svn path=/trunk/; revision=36153
2011-03-07 10:01:24 +00:00
Anders Broman a7e379499d Remove the old code.
svn path=/trunk/; revision=36152
2011-03-07 09:36:24 +00:00
Bill Meier 3e92ea5c2f Fix compiler error on Windows 64: cast strlen() to (int);
Also: Apparently the length of an address of type AT_STRINGZ must include the NULL.

svn path=/trunk/; revision=36151
2011-03-07 03:10:51 +00:00
Bill Meier b71ec510e1 Set properties
svn path=/trunk/; revision=36150
2011-03-07 02:44:38 +00:00