Commit Graph

34580 Commits

Author SHA1 Message Date
Bill Meier 16b528aaf1 From Martin Kaiser: dissector for DVB-CI (Common Interface)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654

From me:
- Entry for DVBCI added to wtap.c encap_table_base[];
- Some code simplification with respect to the use of col_...() for COL_INFO;
- Certain tests for "enough bytes available" not really needed;
- (Other minor tweaks);
- #include<stdio.h> not req'd;
- Minor reformatting and whitespace cleanup;


svn path=/trunk/; revision=36149
2011-03-07 02:22:48 +00:00
Martin Mathieson 4d3d029e09 Remove some instances of _U_ where the parameter is now used.
svn path=/trunk/; revision=36148
2011-03-06 23:10:28 +00:00
Martin Mathieson d36178cd5d Improve expert info output when detect Scheduling Request 'state machine' problem.
svn path=/trunk/; revision=36147
2011-03-06 22:52:33 +00:00
Stig Bjørlykke 3e261511ab Mark value_string_ext bssgp_cause_vals_ext as WS_VAR_IMPORT.
svn path=/trunk/; revision=36144
2011-03-06 16:37:21 +00:00
Gerald Combs c7990056c2 [Automatic manuf, services and enterprise-numbers update for 2011-03-06]
svn path=/trunk/; revision=36143
2011-03-06 16:03:46 +00:00
Anders Broman b4941ca580 Prepare to remove old bssgp code by changing exports.
svn path=/trunk/; revision=36142
2011-03-06 09:42:41 +00:00
Anders Broman 9a7ad380af From Alexis La Goutte:
Enhance tag fh_hopping_.., tclas, tspec, challenge_text...

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36141
2011-03-04 17:40:32 +00:00
Bill Meier f7be370643 From Stefan Metzmacher: Patch that fixes false positives and allows large smb1/2 pdus
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4914



svn path=/trunk/; revision=36140
2011-03-04 15:09:29 +00:00
Tomas Kukosa 0b9c645150 Fix warning
svn path=/trunk/; revision=36139
2011-03-04 14:36:27 +00:00
Tomas Kukosa 3f8b9e87a9 Check only first 14 digits of GeneralizedTime which are fixed, next parts are optional
svn path=/trunk/; revision=36138
2011-03-04 14:01:57 +00:00
Anders Broman 7e17176c39 All messages converted to the "GSM style" dissection.
svn path=/trunk/; revision=36137
2011-03-04 12:57:55 +00:00
Stephen Fisher eec3e70821 Change descriptions of NTP Reference Identifier Codes for stratum 1
servers to match IANA assignment / RFC 5905.  A number of codes already
in Wireshark that aren't assigned were left intact.


svn path=/trunk/; revision=36136
2011-03-04 00:25:56 +00:00
Stephen Fisher 47b9a1235e Correct the usage of tvb_memeql() after r35558: it doesn't return true
if the values are the same; we have to check for "== 0" to see if they
are the same. 


svn path=/trunk/; revision=36135
2011-03-04 00:17:01 +00:00
Stephen Fisher ed9de27ba1 Change "Reference Clock ID" to "Reference ID" to match RFC5905 (also
mention this RFC in the comments).


svn path=/trunk/; revision=36134
2011-03-03 23:48:56 +00:00
Stephen Fisher 4c6e0d3604 Clarify / add explanations for the fields
svn path=/trunk/; revision=36133
2011-03-03 23:47:05 +00:00
Jeff Morriss 62edb47987 Add more duplicate fragment tests.
svn path=/trunk/; revision=36132
2011-03-03 23:28:32 +00:00
Jeff Morriss 4ed0e07ef0 When reassembling fragments, don't stop looking at fragments just because the
current fragment pushes us past the reassembled size: it may be that the
current fragment is a duplicate/retransmission and will be ignored.

Also, if we detect a conflict between a previous and the current fragment,
flag the current (conflicting) fragment as FD_OVERLAPCONFLICT.  Do *not* flag
the fragment that got us into the reassembly routine (probably the final
fragment): it is not (may not be) the guilty fragment.

Clean up some spacing.

Also add reassembly tests for duplicate/retransmitted fragments.

svn path=/trunk/; revision=36131
2011-03-03 20:22:45 +00:00
Anders Broman 675d79871e Export SONtransferRequestContaine, SONtransferResponseContainerand and Global-ENB-ID
svn path=/trunk/; revision=36130
2011-03-03 07:20:34 +00:00
Jeff Morriss 2ea51a7ad2 There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Use tvb_ether_to_str().

Remove some unnecessary includes.

svn path=/trunk/; revision=36129
2011-03-03 03:28:38 +00:00
Jeff Morriss ad99181031 There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Use tvb_ether_to_str().

svn path=/trunk/; revision=36128
2011-03-03 03:09:21 +00:00
Jeff Morriss 609b1b1e1f Use tvb_memcpy() instead of tvb_get_ptr() + memcpy().
Remove a few unnecessary includes.

svn path=/trunk/; revision=36127
2011-03-03 03:02:03 +00:00
Jeff Morriss 559c1e0d53 Use tvb_ether_to_str().
svn path=/trunk/; revision=36126
2011-03-03 02:41:22 +00:00
Jeff Morriss 212a0274f7 Use tvb_get_guint8() instead of tvb_get_ptr().
Remove a few unnecessary includes.

svn path=/trunk/; revision=36125
2011-03-03 02:32:18 +00:00
Jeff Morriss 26789f5d00 Use tvb_ether_to_str().
svn path=/trunk/; revision=36124
2011-03-03 02:24:44 +00:00
Jeff Morriss ab2b947088 Make the _to_str() functions in here take a pointer to a TVB and an offset
rather than (generally) a pointer into the TVB.

Replace some tabs with spaces (for consistency).

Remove a couple unnecessary includes.

svn path=/trunk/; revision=36123
2011-03-03 02:18:57 +00:00
Jeff Morriss 1e425a1d66 As suggested by Anders: when we detect non-ASCII characters, print the line
number on which we found them.

svn path=/trunk/; revision=36122
2011-03-02 17:18:34 +00:00
Anders Broman 6db5c9387b Fix Error: Found non-ASCII characters in packet-ieee80211.c
svn path=/trunk/; revision=36121
2011-03-02 16:25:33 +00:00
Anders Broman 3ccb1950a4 From Alexis La Goutte:
* Add 802.11 Standard Reference
* Reorder IE (Information Element) and define in decimal (the standard use
decimal...) 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=36120
2011-03-02 15:23:38 +00:00
Martin Mathieson 2f6486166f Allow linking back to previous UL tx 32 ms ago.
svn path=/trunk/; revision=36119
2011-03-02 11:33:46 +00:00
Martin Mathieson c5c0195362 Don't overwrite isPhyRetx field for UL frames with DL check.
svn path=/trunk/; revision=36118
2011-03-02 11:16:28 +00:00
Gerald Combs 2009cc6f17 Update some of the "Details" properties in the installer. Remove the
32-bit BMPs from the installer icon; they don't appear to render properly.

svn path=/trunk/; revision=36113
2011-03-01 19:40:51 +00:00
Michael Tüxen 5da016099a Make HAVE_PCAP_REMOTE and HAVE_PCAP_SETSAMPLING independent
as in other places of the code. Such that this is consistently
used. While there, clean up some whitespaces.

This fix was provided by Irene Ruengeler which testing
remote capturing (with multiple interfaces).

svn path=/trunk/; revision=36112
2011-03-01 17:29:09 +00:00
Martin Mathieson 3fac9089cb After SR failure, allow for another attempt in SR state machine (presumably with a subsequent RACH happening in-between...)
svn path=/trunk/; revision=36109
2011-03-01 14:58:51 +00:00
Tomas Kukosa 16bdcb2fbe QSIG: decoding of PSS1InformationElement
svn path=/trunk/; revision=36108
2011-03-01 13:01:26 +00:00
Martin Mathieson 0b2e755182 Tweak the way we setup FP R8 info.
svn path=/trunk/; revision=36107
2011-03-01 10:54:57 +00:00
Martin Mathieson aa9102b72f Was reading F in mac-is descriptors the wrong way around...
svn path=/trunk/; revision=36106
2011-03-01 10:53:58 +00:00
Gerald Combs 91fe31c9b4 If we encounter an excessively long filter string or one with too many
elements, add an expert item and throw a ReportedBoundsError. We may
want to handle this more cleanly in the future but this avoids
allocating a huge amount of memory.

svn path=/trunk/; revision=36101
2011-03-01 00:50:17 +00:00
Bill Meier 16097406f4 Define some globals as static; Remove uneeded #includes; Whitespace cleanup.
svn path=/trunk/; revision=36100
2011-02-28 23:50:01 +00:00
Bill Meier ef997f2290 Remove unneeded #includes; Add #includes to packet-gsm_rlcmac.c
svn path=/trunk/; revision=36099
2011-02-28 23:46:07 +00:00
Bill Meier 093e8f25c4 Define global vars as static; Whitespace cleanup.
svn path=/trunk/; revision=36098
2011-02-28 23:09:02 +00:00
Stephen Fisher 191f6622e1 Display the NTP version in COL_INFO so tshark output (without -V) looks
more like tcpdump.


svn path=/trunk/; revision=36097
2011-02-28 18:00:34 +00:00
Stig Bjørlykke 002cac81c2 Close UAT file after loading.
Open files may prevent deleting a used profile with UAT files.

svn path=/trunk/; revision=36096
2011-02-28 16:11:20 +00:00
Anders Broman 9a7dbb4182 From Pascal Quantin:
the attached patch should hopefully please the buildbots

svn path=/trunk/; revision=36095
2011-02-28 15:42:58 +00:00
Anders Broman 4c26d6ccb3 From Pascal Quantin:
patch to fix the various issues

svn path=/trunk/; revision=36094
2011-02-28 14:54:22 +00:00
Anders Broman 6eaae55c79 - RE apply checkapi patch.
- Mark unused parameters (From Pascal Quantin).

svn path=/trunk/; revision=36093
2011-02-28 14:17:52 +00:00
Anders Broman 7f604b779d From Vincent Helfre:
I change the void * descr field as an union to either store a pointer or a value.

Hope it solves the problem.

svn path=/trunk/; revision=36092
2011-02-28 13:55:47 +00:00
Martin Mathieson ee5202f2d8 When doing sequence analysis, allow for the first SN to be seen not to be 0.
This will happen if the capture doesn't include the start of this channel.

svn path=/trunk/; revision=36091
2011-02-28 12:26:26 +00:00
Martin Mathieson 93333d8fa1 Make UL retx use warning, rather than error, expert level.
svn path=/trunk/; revision=36090
2011-02-28 12:24:45 +00:00
Anders Broman e761ed7206 Add private extensions under the right tree.
svn path=/trunk/; revision=36089
2011-02-28 11:34:59 +00:00
Anders Broman 6820a81354 Fix checkapi detected errors.
Missing log message:
From Vincent Helfre:
GSM RLC MAC dissector

There are 2 things remaining to do:

-  Update to Rel 8 the control messages such as Packet Measurement Order, Packet Measurement Report, Packet Cell Change Order, Packet Cell Change Notification…

-  Improve the display by replacing the strings describing the type by a hf field

svn path=/trunk/; revision=36088
2011-02-28 11:33:27 +00:00