header later causes it to be redefined - as happens on my Solaris 11
virtual machine - we get a redefinition warning, which gets treated as
an error.
svn path=/trunk/; revision=51349
header later causes it to be redefined - as happens on my Solaris 11
virtual machine - we get a redefinition warning, which gets treated as
an error.
svn path=/trunk/; revision=51344
the kernel" thing, and add the NetBSD and DragonFly BSD /proc links (if
they don't mount /proc, that doesn't work, but it doesn't get in the
way).
On Solaris, check for getexecname, just in case somebody tries to build
on an old Solaris that doesn't support it (that could well end up being
the least of their problems, but at least they won't ask us to diagnose
that one).
svn path=/trunk/; revision=51343
Make epan_free a no-op if the pointer is NULL. This fixes 99% of the cases
causing problems for wmem_leave_file_scope() - remove that XXX comment and add
back the assertion.
Remove the cleanup_dissection call from epan_cleanup, it doesn't make sense
there. init_dissection is only called from epan_new, so cleanup_dissection
should only be called from epan_free.
Add one missing epan_free call to tshark revealed by the above changes.
svn path=/trunk/; revision=51342
802.11 HT Extended Capabilities B10 decode incorrect
#Backport 1.10 and 1.8
Within the 802.11 HT Capabilities IE the "HT Extended Capabilities" B10's name is incorrect.
It is currently titled "High Throughput". This is incorrect/missleading. It should be something like "High Throughput Control (+HTC)". The field indicates if the "High Throughput Control (HTC)" field is supported - not if HT itself is supported.
svn path=/trunk/; revision=51339
1. Cleanly break out Convergence Layer Protocol (TCPCL) into its own (new-style) pure dissector.
2. Make Bundle dissection into a new style dissector and clean so that it can be called using call_disssector.
3. Use tcp_dissect_pdus for TCPCL protocol instead of "manual" while loop. This allows contact header to benefit from TCP fragmentation.
4. Make time fields use time field types so they can be filterable.
5. A few functions were move to remove need for static declaration at top of file.
6. Remove pri_hdr_procflags global variable.
Next up - making more fields filterable.
svn path=/trunk/; revision=51337
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=51322
> User: guy
> Date: 2013/08/12 01:01 PM
>
> Log:
> Just check whether dladdr() is available; we check in the code whether
> it succeeds, so there's no point in checking whether it succeeds in a
> sample program.
svn path=/trunk/; revision=51334
Dissect additional OSD-2 service actions (CREATE/REMOVE PARTITION, GET/SET ATTRIBUTES, QUERY).
This patch adds support for some OSD-2 service actions, following the approach described in bug 8832.
The implemented service actions are:
- CREATE PARTITION
- REMOVE PARTITION
- REMOVE COLLECTION
- GET ATTRIBUTES
- SET ATTRIBUTES
- QUERY
The following service action codes was #defined
- OSD_2_REMOVE_PARTITION 0x888c
The following trees were added
- ett_osd2_query_criteria_entry
The following fields were added:
- hf_scsi_osd2_remove_scope (REMOVE PARTITION)
- hf_scsi_osd2_immed_tr (QUERY)
- hf_scsi_osd2_matches_collection_object_id (QUERY)
- hf_scsi_osd2_query_type (query list CDB continuation descriptor)
- hf_scsi_osd2_query_entry_length (query list CDB continuation descriptor)
- hf_scsi_osd2_query_attributes_page (query list CDB continuation descriptor)
- hf_scsi_osd2_query_attribute_number (query list CDB continuation descriptor)
- hf_scsi_osd2_query_minimum_attribute_value_length (query list CDB continuation descriptor)*
- hf_scsi_osd2_query_maximum_attribute_value_length (query list CDB continuation descriptor)*
* (dissection of the attribute value in query descriptors is not implemented yet)
The following value_string arrays were added:
- scsi_osd2_remove_scope_val (OSD2r4 Table 143)
- scsi_osd2_query_type_vals (OSD2r4 Table 75)
The following value_string arrays were updated:
- scsi_osd_svcaction_vals
- scsi_osd2_object_descriptor_format_val
The following functions were added:
- dissect_osd2_query
- dissect_osd2_query_list_descriptor (dissect CDB continuation descriptor type 0x0002)
The following expert_info fields were added:
- ei_osd2_query_values_equal (PI_PROTOCOL,PI_NOTE) - the minimum and maximum attribute values are equal in a query descriptor entry
Changes in dissect_osd2_cdb_continuation:
- Dissect case 0x0002
Changes in dissect_osd_*
- Initialize extra_data->osd2
- Dissect OSD-2 specific fields
- Call dissect_osd_cdb_continuation_length / dissect_osd_cdb_continuation (if osd2)
- Version-specific increment of offset after dissecting capability/security_parameters
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9029
svn path=/trunk/; revision=51331
should be freed when it is destroyed. This requires splitting packet_init in
two: the hash table which must be created before protocol registration, and the
caching of common protocol handles, which must happen after registration.
svn path=/trunk/; revision=51329
- if we find a name during lookup, return it even if it's not a dummy
- read personal hosts after global hosts so that they take precedence
Neither of these problems appear to be new - the recent work did not change this
logic, so I have no idea how come name resolution wasn't failing before, but I
guess the old hash table was weirder than I thought...
svn path=/trunk/; revision=51326
That way, if somebody specifies --with-gtk[23] and that version of GTK+
isn't found, we fail with an indication that the version of GTK+ they
asked for isn't there, and if no GUI toolkit was specified, and they
didn't explicitly say "don't build Wireshark", we look for GTK+ 3 and,
if it's not found, let the user know explicitly.
svn path=/trunk/; revision=51323
With gcc :
pcapng.c: In function 'pcapng_read_packet_block':
pcapng.c:1147:9: error: request for member 'pseudo_header' in something not a structure or union
With clang :
pcapng.c:1150:86: error: member reference type 'struct wtap_pkthdr *' is a pointer; maybe you meant to use '->'?
pcap_get_phdr_size(int_data.wtap_encap, &wblock->packet_header.pseudo_header));
~~~~~~~~~~~~~~~~~~~~~^
->
(Error message from clang is better...)
svn path=/trunk/; revision=51317
to remember this being suggested relatively recently on some mailing list
(either one of the Wireshark lists or tcpdump-workers, I think).
Handle systems where /usr/X11R6/bin is a symlink to /usr/bin and where
the user running autogen.sh has /usr/X11R6/bin before /usr/bin in their
$PATH.
svn path=/trunk/; revision=51315
try it without -ldl (in case the OS doesn't have it - not a good idea,
as it complicates the build process for cross-platform tools that might
require it on other platforms, but "not a good idea" never stopped UN*X
vendors in the past) and, if that fails, try it with -ldl.
svn path=/trunk/; revision=51309
information supplied by the kernel; sadly, we can't trust dladdr() to
use those mechanisms, so we try this first.
Expand the comment about finding the application bundle path given the
executable image path.
svn path=/trunk/; revision=51308
we're running from inside an OS X app bundle and, if we are, save the
pathname of the top-level bundle directory and use it to get the
pathnames of global data files, plugins, and Python modules.
This obviates the need to set special environment variables for them in
the launcher scripts, so get rid of the commands to do that.
The @rpathification of binaries also obviates the need for the
commented-out setting of DYLD_LIBRARY_PATH, so get rid of that as well.
svn path=/trunk/; revision=51306
consistency (they are called just once and will be inlined by any reasonable
compiler).
Also add some comments, fix some spacing etc. No functional changes.
svn path=/trunk/; revision=51304
Guy Harris