Commit Graph

48171 Commits

Author SHA1 Message Date
Jakub Zawadzki c6669a3c63 dfilter: report warning if OR and AND logic operands are mixed without parentheses.
svn path=/trunk/; revision=51247
2013-08-10 17:49:28 +00:00
Martin Mathieson 237182ba42 Use proper macros to cast between uint and pointer
svn path=/trunk/; revision=51246
2013-08-10 17:09:12 +00:00
Martin Mathieson 11304a30ee Try again...
svn path=/trunk/; revision=51245
2013-08-10 16:53:05 +00:00
Martin Mathieson 8cddb7a24e Try using guint.
svn path=/trunk/; revision=51244
2013-08-10 16:34:19 +00:00
Martin Mathieson 0fb73abcc9 Add a malformed check to show if GroupA has more RAPIDs than A & B
combined.

svn path=/trunk/; revision=51243
2013-08-10 16:17:33 +00:00
Martin Kaiser 1ea4e88824 coverity 1058716
set but not used variable

svn path=/trunk/; revision=51242
2013-08-10 12:37:47 +00:00
Martin Kaiser 48485e2c98 dissect the URL in the transport protocol descriptor
svn path=/trunk/; revision=51241
2013-08-10 12:16:00 +00:00
Gerald Combs 5364626e07 Fix error handling.
svn path=/trunk/; revision=51240
2013-08-09 22:47:35 +00:00
Evan Huus c4befc8a7a Decode Kafka metadata requests and responses.
svn path=/trunk/; revision=51239
2013-08-09 15:37:07 +00:00
Chris Maynard 41f444ef87 Move the description of the -Y <displaY filter> option to maintain a proper sort.
svn path=/trunk/; revision=51238
2013-08-09 15:26:48 +00:00
Chris Maynard 9aa40bfcee Replace tabs with spaces. Add modelines.
svn path=/trunk/; revision=51237
2013-08-09 15:08:48 +00:00
Cal Turney 249285a022 Patch for bug 9014. If the relative time is negative, it is set to that of the previous packet. Since the packet is not discarded, its metadata is included in the stats.
svn path=/trunk/; revision=51236
2013-08-09 14:53:35 +00:00
Michael Mann 5ffa911a6b Allow display base, not field type to have multiple ORed entries (for things like BASE_EXT_STRING)
svn path=/trunk/; revision=51235
2013-08-09 13:55:35 +00:00
Evan Huus 1c2cb57a38 Enhance verification to assert that the recycler and master list contain all
free chunks of sufficient size.

svn path=/trunk/; revision=51234
2013-08-09 11:20:02 +00:00
Pascal Quantin 2214b3f9d0 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9022 :
Fix dissection of Feature-Caps header field

svn path=/trunk/; revision=51233
2013-08-09 07:58:27 +00:00
Michael Mann 48fcd0c243 Make more filterable items courtesy of convert_proto_tree_add_text.pl
Fix a few misspelled hf_ variables.

svn path=/trunk/; revision=51229
2013-08-09 01:51:23 +00:00
Guy Harris 5c0baee2a9 Don't print the packet counter when capturing if we're also printing
packet information to a terminal (which we assume is the same terminal
as the one to which the packet counts are being printed), as they get in
the way of each other.

Don't print it if we're sending the standard error to a terminal, or if
-q is specified, either.

Put all the setting of print_packet_counts together; it looks as if the
default value of print_packet_counts may have been changed to TRUE and
the code to handle -q wasn't changed to set it to FALSE if -q was
specified rather than setting it to TRUE if it wasn't specified.

svn path=/trunk/; revision=51227
2013-08-09 00:24:31 +00:00
Jeff Morriss 2bbe93006f As suggested in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9011 :
Rename packet-cmd.c to packet-cisco-metadata.c .

Assign copyright to the author.

Also add the dissector to cmake (oops, should have been in r51198!).

svn path=/trunk/; revision=51226
2013-08-08 18:56:42 +00:00
Jeff Morriss 77ff8f6d59 Remove a couple of set-but-no-longer-used variables.
svn path=/trunk/; revision=51225
2013-08-08 18:03:29 +00:00
Jeff Morriss 45d2989e8b From Francesco Fondelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9024 :
In dissect_rsvp_lsp_attributes() there is a check for invalid Attributes 
TLV length that is no more correct in light of changes described in 
Section 14 of RFC 5420.  This patch fixes that.

svn path=/trunk/; revision=51224
2013-08-08 17:53:11 +00:00
Michael Mann 30e199e2a1 Use convert_proto_tree_add_text.pl to make many more fields filterable.
Someone may want to check that the display filter naming scheme is consistent, I at least tried to make it consistent with the new filters created.
May want to also add subtrees for the bit flags that used to be grouped in a single proto_tree_add_text.

svn path=/trunk/; revision=51223
2013-08-08 17:25:03 +00:00
Martin Mathieson b882f54f1d Apply same changes to common stats to tshark tap
svn path=/trunk/; revision=51222
2013-08-08 16:56:41 +00:00
Gerald Combs c00caf8eab Remove catalog.xml. As a comment from Bill Meier in 2010 notes, we don't
seem to use it (and if your Docbook environment isn't set up correctly
the problem should probably be fixed elsewhere).

svn path=/trunk/; revision=51221
2013-08-08 16:41:10 +00:00
Gerald Combs 42ede93b8e Switch from Docbook 4.2 to 4.5. Our documentation builder only has the
4.4 and 4.5 DTDs installed and a quick check using a popular network
protocol analyzer showed that xsltproc was fetching the 4.2 DTDs from
the network instead of the local filesystem.

svn path=/trunk/; revision=51220
2013-08-08 15:58:35 +00:00
Martin Mathieson aabda8b275 Improve stats of broadcast messages
svn path=/trunk/; revision=51219
2013-08-08 14:45:45 +00:00
Evan Huus c5319ebc93 One more chunk header alignment fix.
svn path=/trunk/; revision=51218
2013-08-08 12:23:23 +00:00
Evan Huus 0ebe18dcea Make sure our chunk headers are large enough to correctly align the actual data
pointer we return.

svn path=/trunk/; revision=51217
2013-08-08 11:27:39 +00:00
Evan Huus d8684cf32d When splitting a free chunk, if we don't have room for a free header don't even
bother splitting. This greatly simplifies the logic, trims another 4% off the
fast path, and doesn't actually affect the results at all because of the way we
pad for alignment anyways.

svn path=/trunk/; revision=51216
2013-08-08 11:16:10 +00:00
Stig Bjørlykke cf6288e21f Added default ignore targets for new asn1 dissectors.
Removed cnf data from atn-cpdlc.asn to make it generate.

svn path=/trunk/; revision=51215
2013-08-08 11:15:45 +00:00
Evan Huus 2d2271f12b Correctly check bounds on dim_max.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9019

svn path=/trunk/; revision=51213
2013-08-08 10:50:11 +00:00
Anders Broman 77f4bef154 From Mathias Guettler:
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.

Add the files to the distribution.

svn path=/trunk/; revision=51212
2013-08-08 05:34:22 +00:00
Guy Harris 1219287df3 Rename variables to reflect their use and to avoid a shadowing warning.
Fix some indentation while we're at it.

svn path=/trunk/; revision=51211
2013-08-08 05:14:33 +00:00
Anders Broman a4d1560fd1 From Mathias Guettler:
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.

Just adding the files to SVN for now.

svn path=/trunk/; revision=51210
2013-08-08 05:09:13 +00:00
Guy Harris 6e0c354769 Clarify what the special cases in wtap_wtap_encap_to_pcap_encap() are
doing.

svn path=/trunk/; revision=51209
2013-08-08 04:57:38 +00:00
Anders Broman 08d223eb71 When dissecting IMSI handle the zero length tvb case, fixes "Malformed Packet: CAMEL (empty IMSI tag)"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9015

svn path=/trunk/; revision=51208
2013-08-08 04:36:54 +00:00
Anders Broman fd4a111149 Don't call eth_addr_resolve() unconditionally.
svn path=/trunk/; revision=51207
2013-08-08 04:32:19 +00:00
Anders Broman 812ad4f3bf From Tommy Wu:
-          Show major and Minor version.
-          Correct SPI Name.

svn path=/trunk/; revision=51206
2013-08-08 04:31:07 +00:00
Anders Broman a46f373c54 Add an application Id.
svn path=/trunk/; revision=51205
2013-08-08 04:30:16 +00:00
Guy Harris ea72be8607 Speak of the "-d encap:" value as a linktype, rather than a DLT; if a
name is specified, it currently must be a DLT_ name rather than a
LINKTYPE_ name, as we use libpcap to do the mapping and it currently has
no API to map LINKTYPE_ names to values, but if a number is specified,
it could either be a LINKTYPE_ name or a DLT_ name if the two are
different, and we want to encourage the use of LINKTYPE_ values.

Note that in comments.

svn path=/trunk/; revision=51204
2013-08-08 04:29:08 +00:00
Guy Harris 3734d4e2b3 Point to the tcpdump.org link-layer header types page.
svn path=/trunk/; revision=51203
2013-08-08 04:18:20 +00:00
Guy Harris 81865326d0 Rename "dlt_value" to "linktype_value", and give more details in
comments about LINKTYPE_ values vs. DLT_ values.

svn path=/trunk/; revision=51202
2013-08-08 04:16:53 +00:00
Gerald Combs 62c083fe8e Compile on Qt < 5.0.
svn path=/trunk/; revision=51201
2013-08-08 00:46:19 +00:00
Gerald Combs 79454ef9fa Add initial capture filter support.
Add CaptureFilterCombo and CaptureFilterEdit classes, similar to their
display filter counterparts. Add a CaptureFilterSyntaxWorker class which
runs a syntax check in a background thread similar to the threaded code
in capture_dlg.c. Add a bunch of related signal and slot plumbing. Other
minor fixups.

svn path=/trunk/; revision=51200
2013-08-08 00:26:57 +00:00
Jeff Morriss 786adc8522 From Francesco Fondelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8954 :
This patch adds XRO (Exclude Routes) support to RSVP dissector.  It
also extends coverage of some new Attribute Flags (LSP_ATTRIBUTES object).

svn path=/trunk/; revision=51199
2013-08-07 23:07:15 +00:00
Jeff Morriss a018f63bca From Vaibhav Katkade via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9011 :
Add support for the Cisco MetaData (0x8909) ethertype.

From me:

Don't try to register the "eth.type" abbreviation; use "cmd.type" instead.
Add SVN id.
Clean up trailing white space and fix up some indentation.
Don't declare a variable static that need not be.

svn path=/trunk/; revision=51198
2013-08-07 22:52:43 +00:00
Jeff Morriss c44883cb1a From Роман Донченко via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9018 :
This patch enables Wireshark to correctly decode messages specific to the
selected key exchange method by determining and remembering that method.
It's a little incomplete in that it doesn't support the case where
first_kex_packet_follows is true, but then the current implementation
doesn't either.

It also adds/fixes dissection for the plain Diffie-Hellman key exchange and
DH group exchange messages that were broken/missing, completing support for
both of these key exchange methods.

svn path=/trunk/; revision=51197
2013-08-07 22:20:49 +00:00
Martin Kaiser 07ee14d5c1 fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9020
make sure that the loop counter is always incremented

svn path=/trunk/; revision=51196
2013-08-07 21:17:53 +00:00
Martin Kaiser 2f072ac53c add a range check for dch_id
this should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9005

svn path=/trunk/; revision=51195
2013-08-07 20:18:11 +00:00
Gerald Combs 6fea3ab734 Make sure we copy our support files to DESTDIR.
svn path=/trunk/; revision=51194
2013-08-07 18:30:21 +00:00
Pascal Quantin a2452d6926 Fix dissection of FemtoInterfaceMsg media type when it includes a mandatory LV or V IE
svn path=/trunk/; revision=51193
2013-08-07 17:34:49 +00:00