osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
40,390 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

40390 Commits

Author SHA1 Message Date
Guy Harris 7ff367e4ec Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Fix a field type - FT_UINT_BYTES means "byte array preceded by a
length, with the length field included", not "byte array, not including
any length field, even if it happens to be preceded by a length field".

svn path=/trunk/; revision=42503
 2012-05-08 06:35:50 +00:00
Anders Broman c406e86cc1 Pretify info_col for mor MSG:s 
svn path=/trunk/; revision=42502
 2012-05-08 05:35:30 +00:00
Guy Harris 3067d31c24 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.  (The only non-integral/non-boolean fields
aren't fetched as array elements.)

svn path=/trunk/; revision=42501
 2012-05-08 02:41:15 +00:00
Guy Harris 913d8951d1 Fix a proto_tree_add_ipv4() call that was probably intended to be a 
proto_tree_add_item() call.

svn path=/trunk/; revision=42500
 2012-05-08 02:05:16 +00:00
Guy Harris 77c75e4e43 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.  (There's no spec for the protocol that I
could find, just an implementation, and it's not clear whether the
description field is ASCII or UTF-8 or something else.)

svn path=/trunk/; revision=42499
 2012-05-08 02:02:26 +00:00
Guy Harris fad3e5f467 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42498
 2012-05-08 00:37:37 +00:00
Guy Harris cbd26a417b Fix a proto_tree_add_uint() call that appears to have been intended to 
be a proto_tree_add_item() call.

svn path=/trunk/; revision=42497
 2012-05-08 00:34:12 +00:00
Guy Harris 8822dffb82 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42496
 2012-05-08 00:31:56 +00:00
Guy Harris ff546a0151 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42495
 2012-05-08 00:29:22 +00:00
Guy Harris 7b67c96c9a Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Clean up indentation.

svn path=/trunk/; revision=42494
 2012-05-08 00:24:07 +00:00
Guy Harris 1fca484224 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Update the RFC number for LDAP.

svn path=/trunk/; revision=42493
 2012-05-08 00:15:53 +00:00
Guy Harris 551d8aaacf Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42492
 2012-05-07 23:55:46 +00:00
Guy Harris 5d4e982e93 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42491
 2012-05-07 23:40:44 +00:00
Guy Harris 0ac5ef9e91 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Update the introductory comment to give the RFC for IAX2. 
(tools.ietf.org rules.)

svn path=/trunk/; revision=42490
 2012-05-07 23:37:38 +00:00
Guy Harris 0851bd312c Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42489
 2012-05-07 22:52:33 +00:00
Guy Harris c51cadd00e Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42488
 2012-05-07 22:46:14 +00:00
Bill Meier c055ca8c7e General minor cleanup including: 
- remove unneeded #includes;
- use val_to_str_const() as appropriate;
- reformat hf[] entries;
- reformat long lines;
- use #if 0/#endif to coment out code instead of /* ... */;
- remove boilerplate comments;
- whitespace & indentation


svn path=/trunk/; revision=42487
 2012-05-07 22:11:34 +00:00
Guy Harris 8d33dddd11 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42486
 2012-05-07 21:11:58 +00:00
Guy Harris dedf907787 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42485
 2012-05-07 21:04:05 +00:00
Balint Reczey 4441dd7d59 Give hints to capture from stdin or pipe instead of opening it as a file 
svn path=/trunk/; revision=42484
 2012-05-07 19:53:49 +00:00
Guy Harris 8f9acccbc5 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42483
 2012-05-07 19:47:15 +00:00
Guy Harris dc06d2643a Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

(The field is a counted string, so the byte order is in theory relevant,
although the count is, in this case, a single byte.)

svn path=/trunk/; revision=42482
 2012-05-07 19:38:26 +00:00
Guy Harris 25fe8a3f22 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42481
 2012-05-07 19:30:29 +00:00
Guy Harris 8b5748d182 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Get rid of unnecessary include of <stdio.h>.

svn path=/trunk/; revision=42480
 2012-05-07 18:59:18 +00:00
Guy Harris f64b0b69a4 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42479
 2012-05-07 18:14:08 +00:00
Guy Harris 172798b88f Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42478
 2012-05-07 18:10:05 +00:00
Guy Harris 6eaf0037f8 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42477
 2012-05-07 18:06:47 +00:00
Guy Harris 20e4f9468f Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42476
 2012-05-07 18:03:43 +00:00
Guy Harris 761ce3c75b Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls; for the items that don't actually have hf_
entries (which is a bug in the dissector!), assume the short
fixed-length ones are integral and the "to the end of the packet" ones
are byte arrays (hence ENC_NA).

svn path=/trunk/; revision=42475
 2012-05-07 18:00:13 +00:00
Guy Harris aee419527f Revert previous change - packet-umts_fp.h wasn't changed. 
svn path=/trunk/; revision=42474
 2012-05-07 17:41:29 +00:00
Guy Harris bf09922d1d packet-umts_fp.h now requires epan/conversation.h. 
svn path=/trunk/; revision=42473
 2012-05-07 17:40:05 +00:00
Guy Harris 71cb7a6cf3 packet-umts_fp.h now requires epan/conversation.h. 
svn path=/trunk/; revision=42472
 2012-05-07 17:39:09 +00:00
Guy Harris f758ee84f9 packet-umts_fp.h now requires epan/conversation.h. 
svn path=/trunk/; revision=42471
 2012-05-07 17:38:26 +00:00
Guy Harris 1637f2965e packet-umts_fp.h now requires epan/conversation.h. 
svn path=/trunk/; revision=42470
 2012-05-07 17:37:30 +00:00
Martin Mathieson c9a82fcdb1 Include <epan/conversation.h> from packet-umts_fp.h. 
svn path=/trunk/; revision=42469
 2012-05-07 17:10:12 +00:00
Guy Harris 15ee6468e8 packet-umts_fp.h now requires epan/conversation.h. 
svn path=/trunk/; revision=42468
 2012-05-07 17:04:41 +00:00
Guy Harris 63f9279370 packet-umts_fp.h now requires epan/conversation.h. 
svn path=/trunk/; revision=42467
 2012-05-07 16:41:03 +00:00
Anders Broman 1e6a26dfe9 Use converstaion info in umts_fp. 
svn path=/trunk/; revision=42466
 2012-05-07 16:09:49 +00:00
Jeff Morriss 7afe87264d Decode the Israeli TCM and CAM messages. 
svn path=/trunk/; revision=42465
 2012-05-07 15:13:28 +00:00
Bill Meier 82ff1fd754 General cleanup: 
- Setup COL_PROTO & COL_INFO before fetching from the tvb;
- Improve byte pane highlighing: Use proper length in proto_tree_add_item() calls;
- Remove unneeded include;
- Use VALS macro when referencing a value_string in hf[];
- Simplify/rework code slightly;
- Whitespace.

svn path=/trunk/; revision=42464
 2012-05-07 13:35:45 +00:00
Bill Meier a2fc95b244 General fixes and cleanup: 
- Calls to a sub-dissector must not be under 'if (tree)';
- Setup COL_PROTO & COL_INFO before fetching from the tvb;
- Move proto_reg_handoff_...() to the end of the file;
- prefs callback not required;
- Localize a global variable;
- whitespace.

svn path=/trunk/; revision=42463
 2012-05-07 13:30:58 +00:00
Bill Meier 438d147181 (Minor): packet_reg_handoff() & prefs callback not req'd; 
whitespace (trailing spaces) cleanup.

svn path=/trunk/; revision=42462
 2012-05-07 13:13:49 +00:00
Anders Broman 1f6ab2ee8f Use defines in value_string values. 
svn path=/trunk/; revision=42461
 2012-05-07 11:14:30 +00:00
Jakub Zawadzki 709d04976c Avoid calling tvb_get_ptr() on 0-length TVBs. 
It seems to be better fix than r42420

svn path=/trunk/; revision=42460
 2012-05-07 10:51:14 +00:00
Anders Broman 6b38e752db From David Wei: 
Fix to PCI and PVI in Bearer QoS and ARP IE:s for GTPv2.

svn path=/trunk/; revision=42459
 2012-05-07 07:43:03 +00:00
Chris Maynard 557ab87a9b Trivial typo: of -> or 
svn path=/trunk/; revision=42458
 2012-05-07 04:15:10 +00:00
Bill Meier bb14288a52 From Evan Huus: 
CppCheck found a bunch of redundant assignments to the variable
 'operand_address'.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7232

svn path=/trunk/; revision=42457
 2012-05-07 01:27:36 +00:00
Bill Meier 07d88fc044 From Evan Huus: 
In dissect_sdp_media_attribute() we can leak 'key' in an error condition.
 Simply move the allocation to after the error check.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7231

svn path=/trunk/; revision=42456
 2012-05-07 01:18:17 +00:00
Bill Meier 7582254ef1 From Evan Huus: remove unused variables 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7229
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7230

svn path=/trunk/; revision=42455
 2012-05-07 01:12:03 +00:00
Bill Meier 9d4b7ad9fe From Evan Huus: 
In get_capture_device_open_failure_messages() in dumpcap.c, there are some
 statements that should have been guarded by ifdefs, causing a little
 unnecessary work on some platforms, and a bunch of unused-variable warnings
 from static analyzers. The patch fixes the problem.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7228

svn path=/trunk/; revision=42454
 2012-05-07 00:49:39 +00:00