Piotr Winiarczyk
6846271b76
btmesh: Enhanced messages reassembly
...
This commit adds enhanced messages reassembly for access and control
message. Closes #17417 .
2021-06-04 08:40:31 +00:00
Thomas Dreibholz
6e5081474e
SCTP: Display basic TSN information with packets
2021-06-04 08:04:31 +00:00
Chris Brandson
256af1d2f0
added latest Zigbee manufacturer codes
2021-06-03 14:37:00 +00:00
Simon Barber
5202119239
ieee80211_radio: Use calculated bitrate if not supplied
...
For 802.11n if the bitrate is not supplied then the calculated bitrate is used. This change does the same for 11ac and 11ax.
Sniffer traces taken on recent versions of Macos no longer supply the bitrate for 11ac frames in the RADIOTAP header, this change allows the wireless timeline to work with these traces.
Fixes #17419 .
2021-06-02 21:47:03 +00:00
Guy Harris
2f5c0ffdb2
pcapng: set the length of the options item.
...
It runs up to either the end of the option data or the terminating
end-of-options option (readers MUST handle lists of options that
contains an end-of-options option and lists of options that don't).
2021-06-01 18:59:29 -07:00
Guy Harris
6542fd7ab2
802.11: move PV1 control and management frame information.
...
Put the control frame information into the header tree, and put the
management frame information into its own subtree, as we do with PV0.
2021-06-01 17:09:18 -07:00
Guy Harris
ea0e04d53d
802.11: clean up the handling of protocol versions.
...
Put the PV0 dissection into its own routine.
Add a small routine for unknown protocol versions.
Have the top-level dissector just call the PV0, PV1, or unknown version
routines.
Have the PV1 routine create an 802.11-protocol top-level tree item,
rather than putting the header fields at the top level.
2021-06-01 16:30:27 -07:00
Guy Harris
4cf5cb704c
ieee80211: prevent an infinite loop.
...
dissect_ieee80211_ranging_trigger_variant(), when passed a subtype
other than 0 through 3, will return 0, causing
add_he_trigger_user_info() to loop infinitely on a TRIGGER_TYPE_RANGING
frame.
This change checks for a return value of 0 and terminates the loop.
This probably needs a better fix that reports an error (and maybe
requires dissect_ieee80211_ranging_trigger_variant() to handle subtype
4; I don't have the latest 11ax draft to check).
Fixes #17418 .
2021-06-01 02:00:57 -07:00
Nardi Ivan
ebbea87b1f
TLS: add basic support for ALPS (Application-Layer Protocol Settings) extension
...
See: https://datatracker.ietf.org/doc/html/draft-vvv-tls-alps-01.txt
Based on BoringSSL implementation:
https://boringssl.googlesource.com/boringssl/+/51607f1fe11202f2876ec26486ffbef3cbbf0f35
2021-05-31 19:32:38 +00:00
Luis Colmenero
4941c5bb6d
rtps-vt: Fix sizeof(guint..) - replace with numeric value
2021-05-31 20:04:22 +02:00
Nardi Ivan
26dd456e62
HTTP: fix typo in dissect_http_heur_tls()
...
Fixes: a1a2b536
Close #17414
2021-05-31 07:56:46 +00:00
Nardi Ivan
eb71853533
TLS: add decoding of grease versions
...
See RFC-8701 Sec 2
2021-05-31 07:26:29 +00:00
Graham Bloice
59de442abb
MQTT: Revert subdissector call to not pass topic as data
...
An inadvertent change in f6ad48 caused sub-dissectors to be called
with their data argument set to the message topic.
This isn't required for the SparkplugB heuristic dissector (or any
other it seems).
2021-05-30 19:56:50 +00:00
Chris Brandson
a5df597b3d
fixed typo
2021-05-30 19:15:25 +00:00
Chris Brandson
aed5c63e73
fixed whitespace issues
2021-05-30 19:15:25 +00:00
Chris Brandson
8e97359883
Added expert info to mark depreciated Zigbee ZDO commands and made
...
dissection of ZDO responses with a status other than SUCCESS more
lenient, i.e. dissect what is possible and avoid reporting malformed
2021-05-30 19:15:25 +00:00
Lin Sun
e058d47734
RTP: fix RTP Player play failed when SDP not exist
...
* packet-rtp.c: add conversation info for RTP packets to help RTP Player work
without SDP.
2021-05-30 08:29:17 +00:00
Uli Heilmeier
a4b598d3d6
MQTT: Fix dissector call for payload
...
As we don't know which dissector we call we don't know which data type the
subdissector wants. Therefore we should only call with data for specific
dissectors.
2021-05-30 06:44:25 +00:00
Alfredo
1e467963d4
IMAP: Fix resetting of tls state
...
The ssl_requested field is reset with every frame, regardless of being a request or a
response. Reset ssl_requested only when the next frame is an OK response
2021-05-29 08:04:14 +00:00
Alfredo
ddab0457f0
FTP: Add initial support for TLS
...
Add support for the AUTH TLS command as per RFC 2417 adding the new field tls_requested to FTP conversation, as soon as the 234 response code is received start the TLS communications
2021-05-29 07:42:07 +00:00
Dr. Lars Völker
642d1ca97d
MKA: Stop warning for MKA v3
...
IEEE 802.1X-2020 defined MKA version 3, so the MKA dissector should
not warn that this version does not exist anymore.
2021-05-29 07:26:55 +00:00
Thomas Dreibholz
08f1d27a9b
Using G_GUINT64_FORMAT for printing DCCP sequence numbers.
2021-05-28 14:28:21 +00:00
Thomas Dreibholz
8dc0e42721
DCCP: Added preferences setting for relative sequence numbers.
2021-05-28 14:28:21 +00:00
Thomas Dreibholz
6928241b30
DCCP: Added support for displaying relative sequence numbers.
2021-05-28 14:28:21 +00:00
Stig Bjørlykke
6f72d738de
exported_pdu: Add a new TAG for p2p_dir
...
Add a new exported_pdu TAG to specify pinfo->p2p_dir.
2021-05-28 12:43:21 +00:00
Anders Broman
e1e2aaf91a
Geographical description, correct the bitmask.
2021-05-28 12:19:15 +00:00
Constantine Gavrilov
8d60d8c4f2
NVMe: decode Set Fatures data transfers.
...
This closes #17407 .
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
e75998cded
NVMe: decode Set Fatures response (DWORD0) in CQE.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
d5c1bd9d93
NVMe: refactor CQE decoding to decode all fields and decode comand status.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
12ddec82bf
NVMe: decode Set Features DWORD11 and DWORD12 for each feature.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
f0b83585c1
NVMe: decode Set Features command.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
6755309958
NVMe: refactor command parsing to always print DWORD10-DWORD15.
2021-05-28 08:45:26 +00:00
Thomas Dreibholz
03921ac668
DCCP: Lookup of service code for DCCP Request and Response.
2021-05-28 04:22:29 +00:00
JanTheMan
108b816fcc
doip: make version hdr for ISO13400-2:2019 usable
...
the already provided defines for the latest ISO version have been made
usable for the version detection in the protocol header
2021-05-28 03:14:58 +02:00
Richard Sharpe
fa89a8f673
ieee80211: Fix an infinite loop in the HE Trigger handling.
...
fixes #17410
Change-Id: I04ce052722f3ed62eb36b8894ee7d67d7c522f94
2021-05-27 19:26:30 +00:00
Lin Sun
5f338e5f1b
opus: fix dissector error for win32 build
...
* packet-opus.c: the array for proto_tree_add_bitmask_list should end with NULL
2021-05-27 07:12:01 +00:00
Kirill Smorodinnikov
dde67b0182
PCEP: Fixing PATH-SETUP-TYPE-CAPABILITY padding offset
...
Fix offset of padding in PATH-SETUP-TYPE-CAPABILITY TLV. The offset was incorrect.
2021-05-27 06:13:12 +00:00
Lin Sun
7f63556627
opus: fix build error on MacOS for commit ecd1ab5b23
2021-05-27 05:13:25 +00:00
John Thacker
1513237d10
DVB-S2-BB: Add preference for default mode adaptation format
...
DVB Baseband Frames have four possible mode adaptation formats, and
the check to distinguish them depends on only a CRC-8, so it's possible
to have ambiguity, particularly in a large capture. Add a preference to
for preferred format, defaulting to the SatLabs L.3 mode, since that's
the most common format I've seen in captures or in datasheets for
BBFrames over UDP or RTP. Also make L.3 the second highest preference
when something else is set to the default.
2021-05-26 21:57:05 -04:00
John Thacker
99618b5b93
DVB-S2-BB: Verify EIP CRC
...
Verify the optional DVB-RCS2 Explicit Integrity Protection CRC32.
2021-05-26 20:31:28 +00:00
Kirill Smorodinnikov
33c414a2c8
PCEP: Fixing SR-PCE-CAPABILITY flags offset
...
Fix offset of flags in SR-PCE-CAPABILITY TLV. Flags are placed after reserved 2 bytes: https://datatracker.ietf.org/doc/html/rfc8664#section-4.1.2
2021-05-26 19:27:41 +00:00
Gtker
837fd40081
WOW: Move unused variable into function
2021-05-26 19:09:30 +00:00
Gtker
7b73af34ce
WOW: Remove unused variables
...
As discussed on issue
https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_581073618
2021-05-26 19:09:30 +00:00
Gtker
2e8027c645
WOW: Remove declarations and move functions above dissect_wow_pdu
...
As discussed in issue
https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580961205
2021-05-26 19:09:30 +00:00
Gtker
09b0e09cb8
WOW: Fix whitespace change that was accidentally applied
2021-05-26 19:09:30 +00:00
Gtker
bc1fd8e5c4
WOW: Rearrange header field variables and add comments
...
From discussion with maintainers on issue tracker
https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
60c68534a5
Revert "WOW: Refactor logon challenge server to client packet into struct"
...
This reverts commit 94333a170b0e7b55db035ccb7224bd2a0fd2395c.
See discussion in issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
881a8f300f
Revert "WOW: Refactor logon challenge server to client packet into struct"
...
This reverts commit 07f796f3573dc05e561e6034acabf28514715561.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
1fb8a922e7
Revert "WOW: Refactor logon proof client to server packet into struct"
...
This reverts commit 92fe72f612f789693eba8f2ee02143db2193b5b3.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
b8c5f8ab00
Revert "WOW: Refactor logon proof server to client packet into struct"
...
This reverts commit 12b28e29f98ce1ee64e4e3759ae1adbde1530a5c.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00