osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
34236 commits 26 branches 0 tags 795 MiB
Commit graph

34236 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bill Meier
becab16f36 Fix a crash which can occur if a user hits "Capture:Options" immediately followed by "Capture:Start" 
Fixes Bug #4645: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4645

Essentially: The "Capture Start" code "interrupted" the "Capture Options" code and attempted
 to use not yet initialized "Capture Options" state.

svn path=/trunk/; revision=35633
 2011-01-23 20:59:12 +00:00
Jaap Keuter
f7544b339e From Alexis La Goutte: 
Some patch to cleanup the 802.11 Dissector.

svn path=/trunk/; revision=35632
 2011-01-23 20:15:31 +00:00
Jaap Keuter
e3a0721786 From Alexis La Goutte: 
Some patch to cleanup the 802.11 Dissector.

svn path=/trunk/; revision=35631
 2011-01-23 20:11:08 +00:00
Bill Meier
ce1313cc15 Reword some text about the accuracy of the dislayed values. 
svn path=/trunk/; revision=35629
 2011-01-23 17:29:06 +00:00
Gerald Combs
5f1812edf2 [Automatic manuf, services and enterprise-numbers update for 2011-01-23] 
svn path=/trunk/; revision=35627
 2011-01-23 16:03:54 +00:00
Stig Bjørlykke
db82c54bef Ensure we keep the pkg_data pointer for the init routine to cleanup correctly, 
because the ep memory is cleared before the init routine is called.

Fixed the variable name for the no_yes true_false_string.
Update reference to protocol description.

svn path=/trunk/; revision=35626
 2011-01-22 18:07:28 +00:00
Stephen Fisher
73100c482b Resolve bug #2520 by moving the follow stream direction combo box above the 
buttons to make more room for hostnames.


svn path=/trunk/; revision=35625
 2011-01-22 17:42:40 +00:00
Bill Meier
79342907f3 Add Loránd Jakab; Add two missing left-braces; 
svn path=/trunk/; revision=35624
 2011-01-22 17:01:47 +00:00
Bill Meier
9bc5fc06ce Remove unneeded #includes: <stdio>,<stdlib>,<string>; Add emacs editor modelines 
svn path=/trunk/; revision=35623
 2011-01-22 16:48:02 +00:00
Jeff Morriss
867bf1477e Use nstime_set_zero() to initialize nstime_t's. 
svn path=/trunk/; revision=35622
 2011-01-22 15:35:34 +00:00
Jeff Morriss
262997e2f4 From Johannes Lange via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5606 : 
In semcheck.c the display filter string of an expression is checked against the
header_field_info.display value BASE_CUSTOM. But the value of BASE_CUSTOM is
applied as bitmask while the actual type is an enum (BASE_CUSTOM = 6).

With this BASE_DEC, BASE_DEC_HEX and BASE_HEX_DEC are also matching and are not
accepted as filter expression.


Actually: BASE_DEC works but not BASE_HEX.  And the problem only shows up when
trying to match a field in one of these bases against a string (from a
value_string).

svn path=/trunk/; revision=35621
 2011-01-22 15:15:51 +00:00
Stig Bjørlykke
09d5dd80c7 Set active combo_box entry before connecting the changed signal 
to avoid a crash when opening the Import window.

svn path=/trunk/; revision=35620
 2011-01-22 14:02:38 +00:00
Stig Bjørlykke
44a8913445 Close dir opened by ws_dir_open(). 
svn path=/trunk/; revision=35619
 2011-01-22 13:44:06 +00:00
Stig Bjørlykke
fb4d2c059c Close dir opened by ws_dir_open(). 
svn path=/trunk/; revision=35618
 2011-01-22 13:43:54 +00:00
Jaap Keuter
205fb11d60 Insert and update tshark and dumpcap help information. 
svn path=/trunk/; revision=35617
 2011-01-22 10:38:10 +00:00
Martin Mathieson
58fc79bb04 Add buttons to allow filtering only UL or DL on selected UE. 
svn path=/trunk/; revision=35616
 2011-01-22 03:49:23 +00:00
Jaap Keuter
2f74388448 From Loránd Jakab: 
The patch I am attaching here is for dissecting LISP data packets.

From me: 
Minor cleanups.
Showing the reserved field.
Adding to all makefiles and release notes.

svn path=/trunk/; revision=35615
 2011-01-22 00:18:03 +00:00
Jaap Keuter
c4209f569c Update the User Interface chapter of the User's Guide. 
svn path=/trunk/; revision=35614
 2011-01-21 23:37:46 +00:00
Jaap Keuter
2c4bf4d8fa Re-arrange help menu a bit to group website and wiki links. 
svn path=/trunk/; revision=35613
 2011-01-21 23:24:08 +00:00
Jaap Keuter
e1e1566afb Start update for 1.5 version of User's Guide. 
svn path=/trunk/; revision=35612
 2011-01-21 20:57:24 +00:00
Jeff Morriss
5695d835f5 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5604 : 
A small patch to add color rules for ICMPv6 Error (some error as ICMP(v4)..)

With this patch, Wireshark is ready for IPv6 Day ;)

svn path=/trunk/; revision=35611
 2011-01-21 17:12:02 +00:00
Jeff Morriss
4eb43096b1 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5603 : 
Following the discussion on the dev mailing list about ett_ value in subtree
http://www.wireshark.org/lists/wireshark-dev/201101/msg00039.html

a small to update the Readme Developer Guide !

svn path=/trunk/; revision=35610
 2011-01-21 17:08:35 +00:00
Anders Broman
4374c0b0b7 - Wrong element type used. 
- Use match_strval_idx_ext.

svn path=/trunk/; revision=35609
 2011-01-21 14:03:42 +00:00
Anders Broman
dd1ab4b227 Use EXTRANEOUS_DATA_CHECK_EXPERT 
svn path=/trunk/; revision=35608
 2011-01-21 09:31:25 +00:00
Anders Broman
83c29e1672 Move sgsap_elem_idx_t to packet-gsm_a_common.h 
Dissect Global-CN-Id

svn path=/trunk/; revision=35607
 2011-01-21 09:26:29 +00:00
Anders Broman
6956ad46d5 CN-Id is two bytes. 
svn path=/trunk/; revision=35606
 2011-01-21 09:24:43 +00:00
Anders Broman
fe68c6f1d2 From Tobias Klauser: 
Fix standard to IEC62439 Part 3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5599

svn path=/trunk/; revision=35605
 2011-01-21 06:30:55 +00:00
Anders Broman
531317a178 Fix typos 
svn path=/trunk/; revision=35604
 2011-01-21 06:27:08 +00:00
Jeff Morriss
f53744b59d There's no need to pass the result of tvb_get_ptr() as the 'value' in 
proto_tree_add_*(): just use proto_tree_add_item().
   
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().

svn path=/trunk/; revision=35603
 2011-01-21 03:00:31 +00:00
Jeff Morriss
6e0fcb7ab5 Introduce, and start using, tvb_eth_to_str(). 
Export tvb_*_to_str() and put them in alphabetical order.

svn path=/trunk/; revision=35602
 2011-01-21 02:48:55 +00:00
Jeff Morriss
03066d0820 Use tvb_ip_to_str() 
svn path=/trunk/; revision=35601
 2011-01-21 02:25:30 +00:00
Sake Blok
6e74ad9097 Adress => Address corrections (also in comments). 
(see bug 5600)


svn path=/trunk/; revision=35600
 2011-01-21 00:19:03 +00:00
Jaap Keuter
9e1d1e0e13 Allow presentation of Gauge32 values larger than 0x7FFFFFFF. 
svn path=/trunk/; revision=35599
 2011-01-20 20:04:39 +00:00
Stephen Fisher
fc7b0c019b Fix the dead initialization warnings found by clang's static analysis 
("Value stored to 'xxx' during its initialization is never read")


svn path=/trunk/; revision=35598
 2011-01-20 18:56:11 +00:00
Anders Broman
9c04eb9b2c Fix typos 
svn path=/trunk/; revision=35597
 2011-01-20 14:03:13 +00:00
Anders Broman
fbde1c7130 Update a comment. 
svn path=/trunk/; revision=35596
 2011-01-20 13:19:26 +00:00
Anders Broman
3112035ad2 In MM context the container contains IE:s not a complete 
DTAP message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5598

svn path=/trunk/; revision=35595
 2011-01-20 13:05:17 +00:00
Jaap Keuter
3ff6167958 Allow for expert items to be actually attached somewhere. 
svn path=/trunk/; revision=35594
 2011-01-20 08:58:03 +00:00
Jeff Morriss
705f2ede5d Roll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (instead 
of going through a temporary variable).  This just makes it more obvious which
add_bytes_format() calls are or are not being given pointers into the TVB.

Use tvb_ip_to_str() and tvb_ip6_to_str() in a couple spots.

svn path=/trunk/; revision=35593
 2011-01-20 03:49:44 +00:00
Stephen Fisher
573b4d449f Add a note to the top about r35589's change of the ADDCARRY(x) macro. 
svn path=/trunk/; revision=35592
 2011-01-19 22:57:19 +00:00
Jaap Keuter
969b5a240e Don't stop calling subdissectors when there's no tree. 
svn path=/trunk/; revision=35591
 2011-01-19 22:55:53 +00:00
Jaap Keuter
c5c0a0d943 Use Wireshark standard marking for unused parameters. 
svn path=/trunk/; revision=35590
 2011-01-19 22:53:46 +00:00
Stephen Fisher
c732e15d77 Change the ADDCARRY(x) macro to eliminate clang warning about unused 
result from the ADDCARRY portion of the REDUCE macro.

-#define ADDCARRY(x)  (x > 65535 ? x -= 65535 : x)
+#define ADDCARRY(x)  {if ((x) > 65535) (x) -= 65535;}

The new code is from in_cksum.c in the Tahoe/CGI port of 4.4BSD-Lite2 (we're
using the "Portable Version" copy otherwise).


svn path=/trunk/; revision=35589
 2011-01-19 22:53:38 +00:00
Stephen Fisher
32f6ab2248 Simply this: 
#define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN ((gint)strlen (SIP2_HDR))

To this:

    #define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN 7


svn path=/trunk/; revision=35588
 2011-01-19 21:51:30 +00:00
Stephen Fisher
316cd69642 Fix warning found by clang... 
packet-dcerpc.c:4056:19: error: comparison of integers of different signs:
      'guint32' (aka 'unsigned int') and 'int' [-Wsign-compare]
    for (i = 0; i < (int) commands_nb; ++i) {
                ~ ^ ~~~~~~~~~~~~~~~~~

... by removing the "(int)" cast


svn path=/trunk/; revision=35587
 2011-01-19 21:45:54 +00:00
Jaap Keuter
5c7ec8729a From Alexis La Goutte: 
A patch to enhance the ICMPv6 dissector
- Make ICMP Type (sub)field filterable
- Add Inverse Neighbor Discovery (RFC 3122)
- Remove dependency to packet-ipv6.h
- Cleanup packet-ipv6.h
- Update RFC Draft to draft-ietf-roll-rpl-17 (with make a sub dissector
  for RPL Control and add Secure RPL...)
- Replace tvb_get_ipv6/ip6_to_str by new function tvb_ip6_to_str
- and other enchancements.....

svn path=/trunk/; revision=35586
 2011-01-19 20:57:39 +00:00
Stephen Fisher
fb645f7e28 Cast the returned value from strlen() to an int to make the Windows 64-bit 
buildbot happy.


svn path=/trunk/; revision=35585
 2011-01-19 19:42:00 +00:00
Stephen Fisher
347d0a77bf From Cal Turney via enhancement bug #5587: In hex or string searches of the 
packet data highlight the target rather than the entire field.


svn path=/trunk/; revision=35584
 2011-01-19 18:21:21 +00:00
Stephen Fisher
30b047223a From Cal Turney via bug #5585: When searching in packet bytes, the field and 
bytes are not immediately shown.


svn path=/trunk/; revision=35583
 2011-01-19 17:58:53 +00:00
Anders Broman
bc80cd8155 Fix the broken Edit Menu when UImanager is used. 
(UnmarkAllDisplayedPackets)

svn path=/trunk/; revision=35582
 2011-01-19 14:55:15 +00:00