osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
34236 commits 26 branches 0 tags 795 MiB
Commit graph

34236 commits

This branch
This branch
All branches
Author SHA1 Message Date
Anders Broman
6adf502aa7 Replace a couple of deprecated functions # ifdef:ed with the GTK version they are deprecated in. 
svn path=/trunk/; revision=35740
 2011-02-01 07:15:14 +00:00
Stephen Fisher
1980a286ac Fix compilation error: gsm_a_dir_of_ver_speed_vals is a VALS not a TFS. 
svn path=/trunk/; revision=35739
 2011-02-01 00:46:59 +00:00
Anders Broman
daf631cce8 packet-bssgp.c:10020: warning: 'bssgp_perform_loc_response' defined but not used 
svn path=/trunk/; revision=35738
 2011-01-31 23:00:11 +00:00
Jaap Keuter
efba76d248 From Johan Kristell: 
In the standard 802.3at-2009 the PoE+ TLVs are 12 bytes long, but in the
earlier version 802.3bc-2009, they are 7 bytes long (the power type/
source/priority, and the requested and allocated fields are lacking).
Not respecting the length of the TLV leads to wireshark displaying garbage 
data and could lead to reading outside of buffer.

svn path=/trunk/; revision=35737
 2011-01-31 22:31:05 +00:00
Anders Broman
882874e91c More IE dissection. 
svn path=/trunk/; revision=35736
 2011-01-31 22:25:19 +00:00
Bill Meier
51bae2f9f8 Use {'0', ...} type initializer for fixed length character arrays. 
svn path=/trunk/; revision=35735
 2011-01-31 21:45:16 +00:00
Bill Meier
fa8fb80f53 Use tvb_bytes_to_str() iso home-grown hex output fcn. 
svn path=/trunk/; revision=35734
 2011-01-31 21:35:48 +00:00
Jaap Keuter
60ca36fea7 Clean up dissector code. Pass data block to data dissector. 
svn path=/trunk/; revision=35733
 2011-01-31 21:23:49 +00:00
Bill Meier
af30978c39 Fix minor bug lookups of certain "peer ids" would fail. 
The  issue (in essence)
 For:
  char foo[][4] = {"abc", "defg", "hij"};

strlen(foo[1]) will be 7 and not 4 as expected;

Detected via msvc level 4 warning: "array is too small to include a terminating null character"

svn path=/trunk/; revision=35732
 2011-01-31 21:23:35 +00:00
Jaap Keuter
c8e6818a23 Clean up the whitespace in script. 
svn path=/trunk/; revision=35731
 2011-01-31 21:16:20 +00:00
Jaap Keuter
6101757e33 Jack up the Lua reference entries one level to make it segmented. 
svn path=/trunk/; revision=35730
 2011-01-31 21:15:27 +00:00
Jaap Keuter
70d55366ae Add a Manual entry to the Lua menu. 
svn path=/trunk/; revision=35729
 2011-01-31 21:13:20 +00:00
Jeff Morriss
d8468eb53a Replace some blurbs with NULL 
svn path=/trunk/; revision=35728
 2011-01-31 21:09:28 +00:00
Anders Broman
5e05ed6632 Change a bunch of value and tfs strings to not be prefixed by hf_ but ieee8021. Based on Alexis La Gouttes patch. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5636

svn path=/trunk/; revision=35727
 2011-01-31 20:37:17 +00:00
Bill Meier
ed78f0a33e Fix two cases of 'if (x = y)' which should be 'if (x == y)'. 
Found by reviewing msvc level 4 warnings "assignment within conditional expression".

(Unfortunately most of the warnings are false positives so this warning can't be enabled)



svn path=/trunk/; revision=35726
 2011-01-31 18:58:38 +00:00
Bill Meier
88d53d925f #include <stdio.h>, #include <stdlib.h> not req'd; 
Make a global variable static (since it's apparently not used elsewhere);
Whitespace changes (indentation, trailing, etc).

svn path=/trunk/; revision=35725
 2011-01-31 17:09:58 +00:00
Martin Mathieson
9ca092db13 Return a string (even though abort is called first) to pacify gcc. 
svn path=/trunk/; revision=35724
 2011-01-31 16:38:40 +00:00
Anders Broman
0855affbec Add dissection of Evolved Allocation/Retention Priority I IE. 
svn path=/trunk/; revision=35723
 2011-01-31 16:25:26 +00:00
Bill Meier
767cdc69fd From Roberto Morro: Fix for Bug #5628 
This patch (against revision 35716) resolves the following bug:
[introduced in patch attached to Bug #5518]
"Dissector bug, protocol RSVP, in packet 78:
More than 1000000 items in the tree -- possible infinite loop"

Actually the bug is resolved by the "return" statement that was erased by
mistake. The patch fixes another issue: the code didn't take care of the fact
that TLVs must be padded to a length multiple of 4.

See:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5518
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5628

From me:
 Change two bytestring_to_str(tvb_get_ptr(...),...) to tvb_bytes_to_str(tvb,...)

svn path=/trunk/; revision=35722
 2011-01-31 15:27:26 +00:00
Anders Broman
7a78a180c7 Dissect more IE's in PERFORM-LOCATION-REQUEST. 
svn path=/trunk/; revision=35721
 2011-01-31 15:16:45 +00:00
Anders Broman
1d9fe2c424 Only define view_menu_auto_scroll_live_cb if HAVE_LIBPCAP 
svn path=/trunk/; revision=35720
 2011-01-31 13:58:36 +00:00
Anders Broman
c9b96a9bfb Try to fix previous commit. 
- menu.h commited by mistake
- new_packet_list.c missing

svn path=/trunk/; revision=35719
 2011-01-31 13:52:32 +00:00
Anders Broman
b7527dd063 From Cal Turney: 
Bug 5621 - With String in Packet details searches, highlight row in tree 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5621

svn path=/trunk/; revision=35718
 2011-01-31 12:19:15 +00:00
Stig Bjørlykke
502ddd6cdb Added filter autocomplete to "Edit Column Details". 
svn path=/trunk/; revision=35717
 2011-01-31 07:42:13 +00:00
Bill Meier
79e8fdf14f Put back a 'return' statement so GCC doesn't generate a warning... 
svn path=/trunk/; revision=35716
 2011-01-31 04:23:46 +00:00
Martin Mathieson
7f94b7bc66 Describe in more detail some of the fields that may be filled in for an LTE MAC frame. 
svn path=/trunk/; revision=35715
 2011-01-31 00:28:22 +00:00
Guy Harris
0e2361fdb8 Clean up white space. 
Use the bssgp_perform_loc_request() routine for PERFORM-LOCATION-REQUEST
(fixes a "defined, but not used" warning).

svn path=/trunk/; revision=35714
 2011-01-31 00:12:21 +00:00
Bill Meier
7f0107220d Fix various instances of "unreachable code". 
svn path=/trunk/; revision=35713
 2011-01-30 23:27:57 +00:00
Bill Meier
043e0e0bbf Don't compile non-used (unreachable) code on Windows. 
svn path=/trunk/; revision=35712
 2011-01-30 23:24:23 +00:00
Bill Meier
6e079af172 Whitespace cleanup (remove trailing blanks from lines). 
svn path=/trunk/; revision=35711
 2011-01-30 22:57:00 +00:00
Bill Meier
17281958a2 Add a comment about some "unreachable code" indicating possible incorrect code someplace. 
Fix some spelling..

svn path=/trunk/; revision=35710
 2011-01-30 22:42:06 +00:00
Bill Meier
8a07e469f3 Fix a number of msvc level 4 "Unreachable code" warnings by removing unneeded 
return statements.

svn path=/trunk/; revision=35709
 2011-01-30 22:32:25 +00:00
Bill Meier
b0d7bf821c Don't compile unused non-Windows code when on Windows. 
(Found by msvc level 4 warning "unreachable code").

Also:
- suppress an invalid msvc level 4 warning by initializing a variable.
- Use #ifdef _WIN32 iso #if _WIN32


svn path=/trunk/; revision=35708
 2011-01-30 22:23:45 +00:00
Anders Broman
f4fad72618 Add more MSG dissection. 
svn path=/trunk/; revision=35707
 2011-01-30 22:08:22 +00:00
Bill Meier
164b0e4a9d When searching a list, validate pointer before (not after) trying to use it. 
In this particular case, the code logic may ensure that
 the search thru the list never hits the end of the list so that a
 crash because of an attempt to deref a NULL pointer never happens.

Issue found via msvc level 4 warning "code not reachable".

svn path=/trunk/; revision=35706
 2011-01-30 21:56:05 +00:00
Stig Bjørlykke
84bc28bd6a Introduce "Fragment count" filter element for all protocols doing reassembly. 
svn path=/trunk/; revision=35705
 2011-01-30 21:01:07 +00:00
Stig Bjørlykke
7a16aeaf05 Moved packet-t38.c to the ASN.1 section. 
svn path=/trunk/; revision=35704
 2011-01-30 20:59:39 +00:00
Anders Broman
d848a90815 From Alexis La Goutte: 
Cleanup 802.11 Dissector : Make checkhf Happy
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5636
Pach #1,#2;#3

svn path=/trunk/; revision=35703
 2011-01-30 18:44:53 +00:00
Gerald Combs
1817033522 [Automatic manuf, services and enterprise-numbers update for 2011-01-30] 
svn path=/trunk/; revision=35700
 2011-01-30 16:05:20 +00:00
Anders Broman
830f6f9891 From Grzegorz Szczytowski: 
Add Bearer Control Mode selection support in gtpv1 dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5634
Sligtly reworked by me:
- prefix names with gtp
- Use proto_tree_add_item()
- remove ref to specific protocol version, as it's probably a mix.
- Changed the update to the AUTHORS file.

svn path=/trunk/; revision=35699
 2011-01-30 11:32:42 +00:00
Anders Broman
e4822bb43b From Alexis La Goutte: 
Cleanup 802.11 Dissector : Rework Prism Header
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5631

svn path=/trunk/; revision=35698
 2011-01-29 23:51:06 +00:00
Stephen Fisher
d6e70aa723 Improve r35695/35696 by repeating the whole function call in each 
block of the #if / #else / #endif for clarity.


svn path=/trunk/; revision=35697
 2011-01-29 07:47:03 +00:00
Bill Meier
b96434a014 Fix Windows compile error(s); 
{Compiles OK on Windows but not tested). 

svn path=/trunk/; revision=35696
 2011-01-29 04:41:03 +00:00
Stephen Fisher
bf8ce5c383 If we're compiling with GTK+ 2.14 or higher, use accessor function 
gtk_color_selection_dialog_get_color_selection() instead of accessing
the struct member directly. 


svn path=/trunk/; revision=35695
 2011-01-29 00:30:42 +00:00
Bill Meier
1f1563946e I believe 0 was meant instead of sizeof(0).... 
svn path=/trunk/; revision=35694
 2011-01-28 21:02:40 +00:00
Stephen Fisher
9699cdcf26 Move protocol details from above the copyright notice to below. 
svn path=/trunk/; revision=35693
 2011-01-28 20:37:28 +00:00
Stephen Fisher
fd1e26d285 Remove the remaining tvb_fake_unicode() calls in the dissector source. 
svn path=/trunk/; revision=35692
 2011-01-28 20:15:41 +00:00
Stephen Fisher
42dbbb9090 Fix r35690: tvb_get_unicode_string() takes length in 8-bit bytes, not 
16-bit UTF-16 characters as tvb_fake_unicode() did.


svn path=/trunk/; revision=35691
 2011-01-28 20:12:12 +00:00
Stephen Fisher
2040a3421d Change tvb_fake_unicode() to tvb_get_unicode_string() in the DCERPC 
DRSUAPI dissector.  Updated the packet-dcerpc-drsuapi.c file manually
because it used to be auto-generated, but appears to have had changes
since then.


svn path=/trunk/; revision=35690
 2011-01-28 20:07:18 +00:00
Stephen Fisher
d37c33b7e7 Mention that the fake tvb unicode functions have been superceded 
svn path=/trunk/; revision=35689
 2011-01-28 20:01:01 +00:00