Commit graph

34236 commits

Author SHA1 Message Date
Anders Broman
feea97e6aa packet-bssgp.c:6916: warning: 'bssgp_tree' may be used uninitialized in this function
svn path=/trunk/; revision=35581
2011-01-19 09:49:36 +00:00
Anders Broman
3c491eee6b Cleaned up splitt between old and new dissection style.
A lot of conversion still needed.

svn path=/trunk/; revision=35580
2011-01-19 09:35:34 +00:00
Anders Broman
6b24548858 Add the RAI value to "add_string"
svn path=/trunk/; revision=35579
2011-01-19 06:43:28 +00:00
Anders Broman
0119e04527 Try to enhance output at ValueError to ease debugging.
svn path=/trunk/; revision=35578
2011-01-19 06:33:33 +00:00
Anders Broman
4a3eda9862 Updated to OMA-TS-ULP-V2_0-20100806-D
with asn1 files from eyimjia.
Files hand edited to pass as2wrs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5593
(Does not fix the bug)

svn path=/trunk/; revision=35577
2011-01-19 06:27:50 +00:00
Anders Broman
f785ee57ff Introduce EXTRANEOUS_DATA_CHECK_EXPERT
which adds an expert item.

svn path=/trunk/; revision=35576
2011-01-18 20:16:56 +00:00
Jörg Mayer
6e4b5cac5e dumpcap failed to link - add glib2 and wsutil libraries to fix this.
svn path=/trunk/; revision=35575
2011-01-18 17:49:41 +00:00
Gerald Combs
9fe5b9af3f Add another item.
svn path=/trunk/; revision=35574
2011-01-17 22:23:35 +00:00
Anders Broman
cbc7cbd1b2 Handle two length octets correctly in TELV.
svn path=/trunk/; revision=35573
2011-01-17 21:12:30 +00:00
Anders Broman
821f91f278 - append TLLI value.
- Whitespace changes.

svn path=/trunk/; revision=35572
2011-01-17 21:10:54 +00:00
Bill Meier
8d272fb165 (Until Anders comletes work): use #if 0 instead of //; init a variable;
svn path=/trunk/; revision=35571
2011-01-17 16:51:31 +00:00
Bill Meier
180bb0c13f Remove redundant test for a non-null pointer;
svn path=/trunk/; revision=35570
2011-01-17 16:36:52 +00:00
Jeff Morriss
fa16c931e1 Actually use proto_tree_add_item() instead of proto_tree_add_ether(). I hope I didn't miss more of these...
svn path=/trunk/; revision=35569
2011-01-17 15:22:11 +00:00
Martin Mathieson
7205313026 - Use correct data pointer during a comparison.
- Add expert info to show when DRX command is received
- Get rid of some tabs


svn path=/trunk/; revision=35568
2011-01-17 15:01:22 +00:00
Anders Broman
fe7213590b Restore dissection of Mobile Identity(revert the code).
svn path=/trunk/; revision=35567
2011-01-17 14:18:54 +00:00
Anders Broman
71d02b5455 - Remove debug printout.
- Enhance dissection a bit.
- add new true_false_strings

svn path=/trunk/; revision=35566
2011-01-17 13:09:08 +00:00
Bill Meier
7089b9c780 Do Windows compile with /WX flag: treat warnings as errors.
svn path=/trunk/; revision=35565
2011-01-16 23:47:05 +00:00
Bill Meier
483b52c8e7 Compile text2pcap.c,mergecap.c,capinfos.c,editcap.c, & version_info.c with -WX;
(Treat warnings as errors);
Done by simplifing the dependency line for the objects so that the
 default .c.obj inference rule is used.

svn path=/trunk/; revision=35564
2011-01-16 23:24:15 +00:00
Bill Meier
ba48c5061e Fix a Windows compiler warning;
Minor whitespace cleanup.

svn path=/trunk/; revision=35563
2011-01-16 23:04:33 +00:00
Jeff Morriss
884d5491b1 Actually use proto_tree_add_item instead of proto_tree_add_bytes. Fixes bug 5588.
svn path=/trunk/; revision=35562
2011-01-16 22:52:17 +00:00
Anders Broman
672ce3871d Switch to using proto_add_bits_item in a couple of places and fix
missing stepping of bit_offset.

svn path=/trunk/; revision=35561
2011-01-16 22:32:22 +00:00
Bill Meier
6d01681d93 Fix Windows comiler warning: remove unused 'wsadata' variable.
svn path=/trunk/; revision=35560
2011-01-16 22:10:03 +00:00
Jaap Keuter
8356fdd6ac From Vaibhav Katkade:
Add support for newly defined LLDP Four-wire Power-via-MDI and 
CDP Spare Pair PoE TLVs

svn path=/trunk/; revision=35559
2011-01-16 21:32:39 +00:00
Jeff Morriss
8d32d2066a There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or
tvb_get_const_stringz().

Use tvb_memeql() & tvb_memcmp().

svn path=/trunk/; revision=35558
2011-01-16 20:51:21 +00:00
Jeff Morriss
c04dd5fda9 Use tvb_fc_to_str() and tvb_fcwwm_to_str().
svn path=/trunk/; revision=35557
2011-01-16 18:37:56 +00:00
Anders Broman
b80813a45c From Porus Mehta:
Corrections to ANSI MAP ASN.1 specifications.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5584

svn path=/trunk/; revision=35556
2011-01-16 18:36:17 +00:00
Jeff Morriss
6e1353b3b0 <shortcut> doesn't appear to be a valid element.
svn path=/trunk/; revision=35555
2011-01-16 18:36:04 +00:00
Gerald Combs
fd9f6c3ea3 [Automatic manuf, services and enterprise-numbers update for 2011-01-16]
svn path=/trunk/; revision=35552
2011-01-16 16:03:51 +00:00
Anders Broman
568605ae13 r35546 Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.
Make the change also in the .cnf file

svn path=/trunk/; revision=35551
2011-01-16 08:24:11 +00:00
Jeff Morriss
b2c0cfa9dd Move assignment of 'oct' outside of if(tree)--it is used outside of the if block.
svn path=/trunk/; revision=35550
2011-01-16 04:38:59 +00:00
Jeff Morriss
77b3392e72 Introduce, and start using, tvb_fc_to_str() and tvb_fcwwm_to_str(): these
functions act like their non-tvb counterparts except that they take a tvb and
and offset instead of a pointer to a byte array.

This basically saves the dissectors from having to call tvb_get_ptr()--which in
this case eliminates a couple of typos in the length given to tvb_get_ptr().

svn path=/trunk/; revision=35549
2011-01-16 04:33:42 +00:00
Jeff Morriss
61876001c3 Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

svn path=/trunk/; revision=35548
2011-01-16 03:57:12 +00:00
Jeff Morriss
d553df218e Use tvb_memeql().
Use tvb_ip_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

svn path=/trunk/; revision=35547
2011-01-16 03:46:16 +00:00
Jeff Morriss
f36e2be287 Use tvb_memeql() and tvb_memcpy().
Use tvb_ip_to_str() and tvb_ip6_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

svn path=/trunk/; revision=35546
2011-01-16 03:35:29 +00:00
Jeff Morriss
067a076179 Use tvb_ip_to_str().
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

svn path=/trunk/; revision=35545
2011-01-16 03:29:03 +00:00
Anders Broman
1f19cd8f1b Comitting work in progress to fix the linking problem.
>Linking fails now:
>epan/.libs/libwireshark.so: undefined reference to `hf_bssgp_elem_id'
>epan/.libs/libwireshark.so: undefined reference to `bssgp_elem_fcn'
>epan/.libs/libwireshark.so: undefined reference to `ett_bssgp_elem'
>epan/.libs/libwireshark.so: undefined reference to >`bssgp_elem_strings'
>Did you miss packet-bssgp.c in that commit?

I'll try to clean this up in the next few days.

svn path=/trunk/; revision=35544
2011-01-15 23:13:28 +00:00
Jeff Morriss
ed329ca1d4 Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

svn path=/trunk/; revision=35543
2011-01-15 19:01:53 +00:00
Jeff Morriss
c037bba949 Don't (blindly) pass the result of match_strval() into proto_tree_add_*():
some OS (like Solaris) don't like NULL pointers to strings in (s)printf
formats; use val_to_str() instead.

svn path=/trunk/; revision=35542
2011-01-15 18:58:42 +00:00
Jeff Morriss
b589c42fa3 Replace some duplicate blurbs with NULL
svn path=/trunk/; revision=35541
2011-01-15 18:18:13 +00:00
Jeff Morriss
e11921d192 Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

svn path=/trunk/; revision=35540
2011-01-15 03:25:43 +00:00
Anders Broman
862e2d498c - Add TELV to dissct IE's with an extention bit in the length vallue.
- Add a BSSGP PDU type
- Put IE name in the top tree for ELEM_V

svn path=/trunk/; revision=35539
2011-01-14 21:43:31 +00:00
Chris Maynard
116d67e164 Add tvb_get_[n|le]toh[40|48|56]() accessors. Addresses bug 5082.
svn path=/trunk/; revision=35538
2011-01-14 19:02:38 +00:00
Chris Maynard
f37c04357b From Cal Turney via bug 4964: Round & display 6 decimal places in tshark SRTs.
svn path=/trunk/; revision=35537
2011-01-14 17:06:53 +00:00
Graham Bloice
8e86e3dbbf Removed redundant comparison that caused compilation failure on OSX
svn path=/trunk/; revision=35536
2011-01-14 14:39:40 +00:00
Martin Mathieson
51170aa0fc When looking for previous frame for UL/DL retx, use harq-id + ndi bit.
svn path=/trunk/; revision=35535
2011-01-14 14:25:24 +00:00
Graham Bloice
1be12860e6 Updated dissector:
Additional function codes: Disable unsolicited messages, Open\Close\Delete file
Additional data objects: Analog output events, File objects and Octet string events.
Improved Info column display for reassembled fragments.
Changed all event timestamps to be UTC as per protocol spec.

svn path=/trunk/; revision=35533
2011-01-14 12:15:10 +00:00
Martin Mathieson
fc38e13bcf Move MAC and RLC stats menu items into a common LTE subtree.
svn path=/trunk/; revision=35532
2011-01-14 11:32:58 +00:00
Martin Mathieson
b1dd79a122 Rather than repairing out-of-range subframe numbers, make sure error gets reported (and then are not used to access beyond subframe arrays).
svn path=/trunk/; revision=35531
2011-01-14 11:21:28 +00:00
Jaap Keuter
cc3952ca4f From Hadar Shoham:
bootp option 123 has 2 chooses - coordinate based location RFC 3825 or
CableLabs DSS_ID. Add better support for having 2 DSS_ID with dynamic
size (up to 32 byte each)

svn path=/trunk/; revision=35530
2011-01-14 07:20:31 +00:00
Jeff Morriss
6cfdeed280 Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.

Replace some memcpy()+tvb_get_ptr() with tvb_memcpy().

svn path=/trunk/; revision=35529
2011-01-14 03:44:58 +00:00