the spec.in files already stated so expicitly, since some files include
osmocom/gprs/*.h. Only some data types from there are used, so there's
no need in linking the lib. Even more, doing so makes the build fail
because there soft-linking symbols required to be implemented by
libosmogb are not implemented here.
Related: OS#5311
Change-Id: I9a8fa03cef1efc9fdaea65ee63ca9b3379993989
Resolve conflict with other Osmocom software by moving ports:
osmo-pcap-client 4237 -> 4227
osmo-pcap-server 4238 -> 4228
Notably the defines OSMO_VTY_PORT_PCAP_CLIENT and _SERVER are currently
not provided by libosmocore, but will be added with the related commit.
Related: OS#5203
Related: libosmocore I098f211370bba61995ce424ab64029bdd4c49e2d
Change-Id: I3b18b1fbbca2799f868f28104e2f5d513f93d46c
In case the config file specifies a vty bind address, we must read
it before we start the telnet server.
Change-Id: I44561754d4beaad5c74cb66994ca4ef38960ea78
Prior to this patch, you could configure 'bind 1.2.3.4' in the
config file, but the telnet interface still binds to 127.0.0.1.
Change-Id: I9b86b2cf6949917c55ea15277619cfa2b745185d
A non-blocking STREAM socket connect() will mark the socket as
write-able once the connection succeeds. However, as we first
call osmo_fd_setup() and then osmo_sock_init2_ofd(), the latter
will force the 'when' to OSMO_FD_READ and hence the write callback
will not be called.
Change-Id: I44c484b48966a985a9b85fb16122a17df5666bc1
Currently `make publish` fails on Jenkins because there is nothing
to publish. In [1] we simply forgot to pass '--enable-manuals'
if $WITH_MANUALS is set to 1, so no PDFs are built. Fix this.
Change-Id: I85dfecf2025a0466fccfe5a1e63cda788f85992e
Fixes: [1] I28353f51de798535a3bb6efdc6c2da443d96ddfb
This adds one common user manual for both osmo-pcap-client
and osmo-pcap-server.
The manual is still basic in nature, but already contains useful
information regarding the setup of both clients and servers.
Change-Id: I66182fc55f1ee323eba45e7a7fc59db55bff520e
If we have more than one dependency in the line, osmo-release.sh
fails with
ERROR: configure.ac <libosmocore, 0.11.0> does NOT match debian/control <Build-Depends:debhelper, 7.0.50~dh-autoreconfautotools-devlibpcap0.8-devpkg-configlibosmocore-devlibgnutls28-devlibzmq3-dev>!
Change-Id: I8ab9a24af6ac0e4610ecc0eca1d5f5b9e03ad445
Previous code relied on abort() switching sigaction to SIG_FDL +
retriggering SIGABRT in case the signal handler returns, which would
then generate the coredump + terminate the process.
However, if a SIGABRT is received from somewhere else (kill -SIGABRT),
then the process would print the talloc report and continue running,
which is not desired.
Fixes: OS#4865
Change-Id: I39367aa480445fe961dcfa308789b3fc0cf759a1
Remove OpenSUSE bug report link, set version to @VERSION@, make it build
with CentOS 8 etc.
Related: OS#4550
Change-Id: I7ac5f2c6bf11d88a3ebbc2f17d963d26f0b7de13
Make build and external tests work with python3, so we can drop
the python2 dependency.
Note that the external tests, which are using this file, are currently
not enabled in jenkins (OS#4317). However, I've manually verified that the
external tests work with this change.
Related: OS#2819
Depends: osmo-python-tests I3ffc3519bf6c22536a49dad7a966188ddad351a7
Change-Id: I19a996458745026cff60608710944e5ab76d8976
Building against older versions fail for different reasons, newest one
being due to osmo_init_logging2 being added in 0.11.0.
Change-Id: Ic7f147c5a26b45b75931cfd8f662642f59a1d725
Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.
API osmo_stats_vty_add_cmds never had a param list but has seem problem
(no "void"), so some users decided to pass a parameter to it.
Change-Id: I2e1ab7005514f1a06cac03e967aa5c8ea472e671
Related: OS#4138
Without this patch, make check fails with following error:
No rule to make target 'atconfig', needed by 'check-local'
Changes needed to fix the issue were gathered by looking at differences
with libosmo-netif's Makefile.
Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db
On (at least) Debian unstable I'm seeing the following compiler
warninig:
/usr/include/features.h:184:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
# warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
Apparently this was deprecated in glibc 2.20 released in 2014 (!)
Change-Id: I826189dec4107e7c3e8cf4c013316ef3014b7857
Holgers' personal feed hasn't been updated for quite some time, and
we're building osmo-pcap as part of the normal latest and nightly builds
for quite some time now.
The only disadvantage compared to Holgers' personal feed is the lack of
support for RPM-based distributions (RHEL, CentOS, OpenSuSE).
Change-Id: Ic479c192ca259f01d422da3bd44443fe4160ccaa
Set AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of
DISTCHECK_CONFIGURE_FLAGS. This is the recommended way from the
automake manual, as otherwise the flag can't be changed by the user
anymore.
Related: OS#3718
Change-Id: Iaac6d41ef1cc2d5449edf870f635b28b045dc7db
Cfg files are moved to doc/examples like in other osmocom projects.
All the cfg files get installed into
$prefix/share/doc/osmo-pcap/examples/$subdir/, and 1 script per binary is
installed into /etc/osmocom.
Change-Id: If3f3a7d3867c0d4d2b1fe01f465532d1ce4bda66
Pau Espin
Oliver Smith
Harald Welte
Vadim Yanitskiy
Joachim Steiger
Pau Espin Pedrol