osmocom
/
osmo-pcap
mirror of https://gerrit.osmocom.org/osmo-pcap
11
0
Fork 0
Code Issues Releases Wiki Activity

Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds 

Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.
API osmo_stats_vty_add_cmds never had a param list but has seem problem
(no "void"), so some users decided to pass a parameter to it.

Change-Id: I2e1ab7005514f1a06cac03e967aa5c8ea472e671
Related: OS#4138
This commit is contained in:
Pau Espin 2019-08-05 16:28:11 +02:00
parent 901543a788
commit 210ed934bb
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/osmo_client_main.c
View File

@ -186,8 +186,8 @@ int main(int argc, char **argv)
vty_info.copyright = osmopcap_copyright;
vty_init(&vty_info);
logging_vty_add_cmds(&log_info);
osmo_stats_vty_add_cmds(&log_info);
logging_vty_add_cmds();
osmo_stats_vty_add_cmds();
/* parse options */
handle_options(argc, argv);

4
src/osmo_server_main.c
View File

@ -199,8 +199,8 @@ int main(int argc, char **argv)
vty_info.copyright = osmopcap_copyright;
vty_init(&vty_info);
logging_vty_add_cmds(&log_info);
osmo_stats_vty_add_cmds(&log_info);
logging_vty_add_cmds();
osmo_stats_vty_add_cmds();
/* parse options */
handle_options(argc, argv);