osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 2 

Patch Set 2: Code-Review-1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
This commit is contained in:
Gerrit User 1000074 2022-10-17 09:01:02 +00:00 committed by Gerrit Code Review
parent e519f3621b
commit db2fc272ce
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
2496668d42670999460635ab6bb86a8cdd52e2d9 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "0b88f7c8_082a77c6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-17T09:01:02Z",
"side": 1,
"message": "I think the main point of a realloc API is to avoid allocating a new chunk and having to copy over all the memory in the old chunk unless it\u0027s really unneeded.\nSo I think msgb_copy() should be kept as it was, and msgb_realloc in any case implemented with \"man realloc\" API.\n\nThe API you are proposing there is more actually \"msgb_copy_new_length()\" or something similar, not a realloc function.",
"revId": "2496668d42670999460635ab6bb86a8cdd52e2d9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}