From db2fc272ce6a3f753288d58aa59a4809e44f2165 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326> Date: Mon, 17 Oct 2022 09:01:02 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: Code-Review-1 (1 comment) Patch-set: 2 Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=-1 Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"} --- 2496668d42670999460635ab6bb86a8cdd52e2d9 | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 2496668d42670999460635ab6bb86a8cdd52e2d9 diff --git a/2496668d42670999460635ab6bb86a8cdd52e2d9 b/2496668d42670999460635ab6bb86a8cdd52e2d9 new file mode 100644 index 000000000..fb2764884 --- /dev/null +++ b/2496668d42670999460635ab6bb86a8cdd52e2d9 @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "0b88f7c8_082a77c6", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 1000074 + }, + "writtenOn": "2022-10-17T09:01:02Z", + "side": 1, + "message": "I think the main point of a realloc API is to avoid allocating a new chunk and having to copy over all the memory in the old chunk unless it\u0027s really unneeded.\nSo I think msgb_copy() should be kept as it was, and msgb_realloc in any case implemented with \"man realloc\" API.\n\nThe API you are proposing there is more actually \"msgb_copy_new_length()\" or something similar, not a realloc function.", + "revId": "2496668d42670999460635ab6bb86a8cdd52e2d9", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + } + ] +} \ No newline at end of file