osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
30941 commits 23 branches 0 tags 1.3 GiB
Commit graph

4543 commits

Author SHA1 Message Date
Jörg Mayer
c34a88f0ae -G -> -J 
-d -> -j
Update AUTHORS

svn path=/trunk/; revision=31037
 2009-11-20 22:55:18 +00:00
Jörg Mayer
13a0a5edf9 Johanna Sochos <johanna.sochos@swissqual.com> 
Add two new options to wireshark:
-G filter: Jump to the first frame matching filter
-d: make -G match the last frame matching filter

svn path=/trunk/; revision=31033
 2009-11-20 18:52:01 +00:00
Stig Bjørlykke
542a34ced8 Implement new_packet_list_recreate(). This should be reimplemented to 
avoid building a new table and redissecting all packets.

svn path=/trunk/; revision=31024
 2009-11-19 21:11:41 +00:00
Stig Bjørlykke
9a7d0994d8 Add a custom column from the packet details popup menu. 
This fixes bug 4246.

svn path=/trunk/; revision=31020
 2009-11-19 18:22:26 +00:00
Stig Bjørlykke
005049bebb Changed hf_ip_proto to use ipproto_val[]. 
Removed some unneeded includes.

svn path=/trunk/; revision=31017
 2009-11-19 15:30:06 +00:00
Jaap Keuter
da9746a17b Remove debug code. 
svn path=/trunk/; revision=30970
 2009-11-16 06:53:05 +00:00
Anders Broman
ba933b055a GTK_STOCK_SELECT_ALL is gtk 2.10. 
Fix indentation.

svn path=/trunk/; revision=30968
 2009-11-16 05:23:12 +00:00
Anders Broman
b16fab6435 From Alejandro Vaquero: 
Add RTP player to "RTP Stream Analysis" and makeover of VoIP flow
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4240

svn path=/trunk/; revision=30967
 2009-11-15 20:13:08 +00:00
Stig Bjørlykke
6946604051 Use the USB icon for usbmon devices on Linux. 
svn path=/trunk/; revision=30960
 2009-11-14 00:43:22 +00:00
Jaap Keuter
943bd2c32d Fix for bug 4120: 
Calculate amount of silence samples in samples/ms i.s.o. samples/s

svn path=/trunk/; revision=30953
 2009-11-13 19:51:51 +00:00
Gerald Combs
23df4e7f01 Update the AirPcap code for Win64 and enable AirPcap for the 64-bit build. 
svn path=/trunk/; revision=30945
 2009-11-12 23:48:11 +00:00
Gerald Combs
9495754ee8 Add a USB network icon. 
svn path=/trunk/; revision=30941
 2009-11-12 18:10:34 +00:00
Jörg Mayer
564500f873 - Generate manpages and html version of manpages 
- Detect pod2man/pod2html to do that
- Install manpages and html version thereof


svn path=/trunk/; revision=30934
 2009-11-11 16:20:37 +00:00
Gerald Combs
7b7d48d2a7 Check for vmnet interfaces everywhere, not just Windows and OS X. Make 
the "vmnet" check case-insensitive. Look for "vmxnet" as well. Clarify
vmnet (host) vs vmxnet (guest).

svn path=/trunk/; revision=30929
 2009-11-11 00:43:23 +00:00
Anders Broman
cafad87fd9 From Stig: 
Invalidate cfile.current_row instead(revert 30910).

svn path=/trunk/; revision=30925
 2009-11-10 20:16:14 +00:00
Gerald Combs
3d40778d1b Move the contents of image/expert_*.h to gtk/expert_indicators.h. Add 
pixbuf versions of the wired, wireless, and bluetooth interface icons to
gtk/network_icons.h. In the interface list use the new icons in all
their alpha-channel-infested glory. Add Makefile targets for rebuilding
the pixbuf files.

svn path=/trunk/; revision=30922
 2009-11-10 18:02:05 +00:00
Stig Bjørlykke
0dbfde8b6d Removed some unused variables and unused assignments. 
svn path=/trunk/; revision=30918
 2009-11-10 12:05:25 +00:00
Stig Bjørlykke
88afdd9525 Removed some dead code. The sm_resolv, sp_resolv and geoip_resolv button 
references are not used anywhere else.

svn path=/trunk/; revision=30917
 2009-11-10 12:03:57 +00:00
Stig Bjørlykke
d195614097 Yet another fix in dlg_destroy(). 
svn path=/trunk/; revision=30916
 2009-11-10 09:30:42 +00:00
Stig Bjørlykke
3946bbe2f2 Fixed a bug in dlg_destroy() to destroy all widgets. 
Removed unused variable 'sortable' in create_list().
Removed unused variable 'checksum' in sctp_stat_on_apply_filter().

svn path=/trunk/; revision=30914
 2009-11-10 09:08:43 +00:00
Gerald Combs
ca04ab9979 Instead of trying to change the background color of the info bar when we 
push a temporary message, make it "throb" using gtk_drag_highlight and
gtk_drag_unhighlight.

svn path=/trunk/; revision=30912
 2009-11-09 21:52:41 +00:00
Anders Broman
989dcf58d1 In new_packet_list_select_cb() remove the check if the packet is reselected as the row number may be the same in a filtered 
list as in the previous unfiltered list.

svn path=/trunk/; revision=30910
 2009-11-09 21:32:32 +00:00
Jörg Mayer
9ee31d1d0e cmake will now honor -Werror if configured (default: on) 
svn path=/trunk/; revision=30852
 2009-11-07 10:07:00 +00:00
Gerald Combs
3c3014820b Add some null pointer checks. This is a blind attempt to fix bug 4155. 
svn path=/trunk/; revision=30846
 2009-11-06 18:08:59 +00:00
Gerald Combs
77ce6145bb Draw little wireless icons for AirPcap adapters. 
svn path=/trunk/; revision=30839
 2009-11-05 22:23:41 +00:00
Gerald Combs
01c31f7d2a Make each level color and the light gradient color in the statusbar match. 
svn path=/trunk/; revision=30836
 2009-11-05 19:45:51 +00:00
Stig Bjørlykke
58c0abee94 Simplified printing of bits in packet bytes view. 
svn path=/trunk/; revision=30835
 2009-11-05 15:40:44 +00:00
Stig Bjørlykke
a5a7905084 From Bahaa Naamneh via bug 4207: 
Adjusts the positioning of the autocomplete popup window in a way it gets
displayed exactly under the editable box.

svn path=/trunk/; revision=30834
 2009-11-05 13:21:03 +00:00
Stig Bjørlykke
146ce8f258 Restore text_end_1 vs. text_start_2 handling. 
svn path=/trunk/; revision=30833
 2009-11-05 10:26:43 +00:00
Stig Bjørlykke
7c5f1b80ac Introduce packet bytes bit view. 
svn path=/trunk/; revision=30832
 2009-11-05 10:16:49 +00:00
Stig Bjørlykke
d0ad8bcdcf Select the previous byte in the packet bytes hex view when clicking in 
the column just behind the first half and the last half.

This behavior is more user friendly.

svn path=/trunk/; revision=30831
 2009-11-05 10:11:45 +00:00
Gerald Combs
d54eea534e Add a convenience routine to convert pixbuf data generated by 
gdk-pixbuf-csource to a GtkImage. Use it to load the expert indicator
images. Add prettier indicator images. The "chat" indicator is more blue
in order to differentiate it from the "none" indicator; make the chat
text background more blue to match.

svn path=/trunk/; revision=30825
 2009-11-04 21:16:38 +00:00
Gerald Combs
b1436f7dca Get rid of a few more simple dialogs. 
svn path=/trunk/; revision=30812
 2009-11-04 00:47:47 +00:00
Gerald Combs
5e34f21076 Add the ability to push temporary (and highlighted) messages onto the 
statusbar. This lets us notify the user about something significant
without having to pop up an annoying window. Replace a few dialogs with
statusbar messages.

svn path=/trunk/; revision=30810
 2009-11-04 00:02:52 +00:00
Stig Bjørlykke
71b719df07 From Eric Sesterhenn via bug 4175: 
Fixed cfmt->cfield and cfmt leakage in the error path.

svn path=/trunk/; revision=30756
 2009-10-29 11:20:33 +00:00
Stig Bjørlykke
a7e3a1b3d9 Check if selected packet is already selected before doing any updates. 
This was originally added in r26803 for the old packet list.

svn path=/trunk/; revision=30749
 2009-10-28 22:17:18 +00:00
Anders Broman
1dcdfd714b Get rid of deprecated GTK functions. 
svn path=/trunk/; revision=30734
 2009-10-27 20:12:37 +00:00
Stig Bjørlykke
4fe10501d2 Use correct default value in tick interval combo box. 
svn path=/trunk/; revision=30729
 2009-10-27 13:59:05 +00:00
Stig Bjørlykke
74ffeef1e8 Removed an unneeded cast. 
svn path=/trunk/; revision=30728
 2009-10-27 09:58:57 +00:00
Anders Broman
db24f90c2d From Jakub Zawadzki: 
Don't duplicate empty string in col_text

svn path=/trunk/; revision=30725
 2009-10-27 05:11:52 +00:00
Stig Bjørlykke
f88e3c3b84 From Jakub Zawadzki via bug 3764: 
Don't call strcmp() when pointers are the same.

svn path=/trunk/; revision=30685
 2009-10-24 15:51:10 +00:00
Stig Bjørlykke
3a5c9ec3b2 Load lua scripts in the plugins directory, both global and personal. 
List loaded lua scripts in Help->About->Plugins.

svn path=/trunk/; revision=30675
 2009-10-23 17:52:18 +00:00
Jaap Keuter
eae4219cea From Lars Ruoff: 
Do not make dialog windows transient to the Wireshark top level window on
WIN32, since this causes some strange behaviour on Windows.
See http://www.wireshark.org/lists/wireshark-dev/200909/msg00184.html

svn path=/trunk/; revision=30667
 2009-10-22 19:40:15 +00:00
Anders Broman
977e880afb Use gtk_combo_box in GTK v 2.4 
svn path=/trunk/; revision=30592
 2009-10-18 10:23:50 +00:00
Anders Broman
c6620d7770 More gtk_option_menu -> gtk_combo_box 
svn path=/trunk/; revision=30570
 2009-10-16 10:32:06 +00:00
Stig Bjørlykke
6f57facbe5 Added revision 30561 with changes to make it work. 
svn path=/trunk/; revision=30569
 2009-10-16 07:54:20 +00:00
Jörg Mayer
2e82dd2966 everted 
------------------------------------------------------------------------
r30561 | etxrab | 2009-10-15 18:57:26 +0200 (Do, 15 Okt 2009) | 1 line

gtk_option_menu -> gtk_combo_box
------------------------------------------------------------------------

as it broke compilation on my system and I don't know enough about gtk
to fix it properly.


In file included from /usr/include/gtk-2.0/gtk/gtk.h:224,
                 from /home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:35:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration isn’t a prototype
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: In function ‘scsistat_program_select’:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:122: error: ‘SCSI_STAT_PROG_LABEL_SBC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:122: error: (Each undeclared identifier is reported only once
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:122: error: for each function it appears in.)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:125: error: ‘SCSI_STAT_PROG_LABEL_SSC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:128: error: ‘SCSI_STAT_PROG_LABEL_MMC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:129: error: ‘SCSI_DEV_MMC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: In function ‘gtk_scsistat_init’:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:229: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:234: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:239: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:244: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:249: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: At top level:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:333: warning: comma at end of enumerator list
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: In function ‘gtk_scsistat_cb’:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:388: error: ‘severity_combo_box’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:343: warning: unused variable ‘menu_item’
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: At top level:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:452: warning: no previous declaration for ‘register_tap_listener_gtkscsistat’
make[2]: *** [gtk/CMakeFiles/ui.dir/scsi_stat.c.o] Error 1



svn path=/trunk/; revision=30565
 2009-10-15 21:44:07 +00:00
Anders Broman
77d3f2e728 gtk_option_menu -> gtk_combo_box 
svn path=/trunk/; revision=30561
 2009-10-15 16:57:26 +00:00
Anders Broman
9d45f50695 Option_menu -> combo_box 
svn path=/trunk/; revision=30543
 2009-10-12 15:27:37 +00:00
Stig Bjørlykke
bed471d64f Remove unused code. 
svn path=/trunk/; revision=30541
 2009-10-12 15:11:37 +00:00
Stig Bjørlykke
a06bfe00f0 Avoid using uninitialized values. 
svn path=/trunk/; revision=30539
 2009-10-12 15:04:46 +00:00
Stig Bjørlykke
1c8f8b4f3d Use prefs.col_list when writing recent entries for new packet list. 
This is to avoid a mismatch between cfile.cinfo and prefs.col_list.

svn path=/trunk/; revision=30529
 2009-10-12 07:55:24 +00:00
Guy Harris
134b6b0f41 The q931_info argument to q931_calls_packet() is used. Don't mark it as 
unused.

svn path=/trunk/; revision=30482
 2009-10-10 22:00:07 +00:00
Kovarththanan Rajaratnam
1615cdcba6 Start using register_tap_files() macro 
svn path=/trunk/; revision=30437
 2009-10-09 16:56:15 +00:00
Anders Broman
4bd41da307 Remove code guarded by #ifdef USE_CONVERSATION_GRAPH 
as this eems to newer have been fully implemented and the old clist is replaced now.

svn path=/trunk/; revision=30425
 2009-10-09 09:56:16 +00:00
Anders Broman
85d8b896a6 From Didier Gautheron: 
- memory leak, free the list after walking it, ie free a NULL list, ie free nothing. I've only fixed bugs introduced by me with GTKCList to TreeView modifs, it seems there's the same bug in gtk/dlg_utils.c.

svn path=/trunk/; revision=30421
 2009-10-09 09:06:22 +00:00
Anders Broman
b8755d9305 From Didier Gautheron: 
Treeview for hostlist. 
Notes:
- tested without and with geoip lib but only with the free DB (no lat/long data) thus 'open_as_map_cb' is not really tested.
 
- It changes the sorting of addresses if 'resolve names' is set and uses the same sorting than conversations. The old way may make more sense for ethernet though.

svn path=/trunk/; revision=30420
 2009-10-09 09:01:04 +00:00
Anders Broman
4d52b3aa83 From Didier Gautheron: 
- Display number with a space as thousand separator.
- Move functions use both by conversations and hostlist in gui_utils.c, they may be useful for other taps too.

svn path=/trunk/; revision=30416
 2009-10-09 08:52:36 +00:00
Anders Broman
5fa3b703a9 Use a "String pool" in the new packet list to reduce memory usage. 
svn path=/trunk/; revision=30400
 2009-10-08 13:57:19 +00:00
Anders Broman
1f34437271 From Didier Gautheron: 
conversations table leaks hash keys memory on close.
Modified by me to use g_hash_table_new_full().

svn path=/trunk/; revision=30396
 2009-10-08 07:56:48 +00:00
Anders Broman
079ff0ba27 From : Didier Gautheron 
gtktreeview patch for stat(not well tested, no traces).

svn path=/trunk/; revision=30389
 2009-10-07 10:00:26 +00:00
Anders Broman
f4938ecf33 From Jim Young: 
Add "Drag and Drop entries..." message on Columns preferences page.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4099

svn path=/trunk/; revision=30381
 2009-10-07 05:03:16 +00:00
Stig Bjørlykke
98024a007f Invert check for getopt: NEED_GETOPT_H -> HAVE_GETOPT_H 
Rename getopt.[ch] -> wsgetopt.[ch] to avoid name collision.

svn path=/trunk/; revision=30370
 2009-10-06 16:01:18 +00:00
Kovarththanan Rajaratnam
e02fcd3990 Remove superfluous cast 
svn path=/trunk/; revision=30366
 2009-10-06 14:02:01 +00:00
Kovarththanan Rajaratnam
73316149c0 Use G_SEARCHPATH_SEPARATOR_S 
svn path=/trunk/; revision=30365
 2009-10-06 13:58:17 +00:00
Kovarththanan Rajaratnam
4d0be14403 Make splash_destroy() return a gboolean 
svn path=/trunk/; revision=30364
 2009-10-06 13:54:32 +00:00
Kovarththanan Rajaratnam
d1dda18cca Guard icon_list_create() 
svn path=/trunk/; revision=30363
 2009-10-06 13:51:56 +00:00
Stig Bjørlykke
727f0062a7 Mark some functions static. 
Removed an unused tooltips.

svn path=/trunk/; revision=30362
 2009-10-06 13:26:00 +00:00
Stig Bjørlykke
4355ba12a9 Removed unused variable thdr. 
svn path=/trunk/; revision=30359
 2009-10-06 13:21:15 +00:00
Stig Bjørlykke
cd31f4d83a Removed unused sortable. 
svn path=/trunk/; revision=30358
 2009-10-06 13:20:40 +00:00
Anders Broman
b42fda0fd2 From : Didier Gautheron 
gtktreeview for conversations:
- use a garray rather than g_realloc memory for conversations list.
- use a hashtable for finding conversation rather than a linear search.

Notes:
- sorting is too slow, I disabled it.
- the dialog box is really a big problem because it's also empty the idle event queue, slow down a lot.
- Test on a 1.5M packets with hundred thousands conversations capture, slow but bearable.

svn path=/trunk/; revision=30353
 2009-10-06 07:44:48 +00:00
Stig Bjørlykke
8ad8a9a233 Return from sctp_stat_on_select_row() if nothing selected. 
svn path=/trunk/; revision=30338
 2009-10-05 17:52:23 +00:00
Anders Broman
2bd73944ff From Didier Gautheron: 
Sorting wasn't working right for time columns.

svn path=/trunk/; revision=30336
 2009-10-05 17:19:39 +00:00
Anders Broman
73452c577b Prepare to change GtkItemFactory to GtkUIManager. 
(Will not have time to work on this for a while).

svn path=/trunk/; revision=30325
 2009-10-05 08:32:59 +00:00
Anders Broman
4a0dc1b5b5 Make Wireshark compile on Windows. 
svn path=/trunk/; revision=30324
 2009-10-05 08:31:31 +00:00
Stig Bjørlykke
066b12d7d4 Prototype follow_add_to_gtk_text(). 
Made some functions static.

svn path=/trunk/; revision=30323
 2009-10-05 07:25:33 +00:00
Stig Bjørlykke
4bc43c93d4 Prototype reset_tap_update_timer() in main.h 
svn path=/trunk/; revision=30322
 2009-10-05 07:02:38 +00:00
Anders Broman
8fc53b829b Use gtk_image_new_from_pixmap(). 
svn path=/trunk/; revision=30316
 2009-10-04 18:33:23 +00:00
Anders Broman
199330559c Remove #if 0'ed code. 
svn path=/trunk/; revision=30312
 2009-10-04 18:21:14 +00:00
Anders Broman
ecc0cdb162 From GTK docs: 
Warning
gtk_window_set_policy is deprecated and should not be used in newly-written code. Use gtk_window_set_resizable() instead.

Changes how a toplevel window deals with its size request and user resize attempts. There are really only two reasonable ways to call this function: 

1.gtk_window_set_policy (GTK_WINDOW (window), FALSE, TRUE, FALSE) means that the window is user-resizable. 

2.gtk_window_set_policy (GTK_WINDOW (window), FALSE, FALSE, TRUE) means that the window's size is program-controlled, and should simply match the current size request of the window's children. 

gtk_window_set_resizable () :
Sets whether the user can resize a window. Windows are user resizable by default.

svn path=/trunk/; revision=30311
 2009-10-04 18:11:22 +00:00
Anders Broman
fa3b06e9de Get rid of deprecated symblol gtk_widget_draw(). 
svn path=/trunk/; revision=30305
 2009-10-04 15:49:52 +00:00
Kovarththanan Rajaratnam
62de58c913 Fix create_list() prototype 
svn path=/trunk/; revision=30300
 2009-10-04 12:31:32 +00:00
Kovarththanan Rajaratnam
a653c171f2 Add HAVE_AIRPDCAP guard 
svn path=/trunk/; revision=30299
 2009-10-04 12:25:20 +00:00
Kovarththanan Rajaratnam
5b6a59936e make-tapreg-dotc has moved to tools/make-tapreg-dotc 
svn path=/trunk/; revision=30295
 2009-10-04 10:01:34 +00:00
Kovarththanan Rajaratnam
dd4e4fc6d6 make-tapreg-dotc has moved to tools/make-tapreg-dotc 
svn path=/trunk/; revision=30293
 2009-10-04 09:12:14 +00:00
Stig Bjørlykke
6325c5d30f Return from dfilter_expr_dlg_accept_cb() if nothing selected. 
svn path=/trunk/; revision=30235
 2009-10-01 14:44:59 +00:00
Stig Bjørlykke
68778b862e Added check for valid pointers (to avoid warnings). 
svn path=/trunk/; revision=30234
 2009-10-01 14:41:34 +00:00
Anders Broman
e7948dc626 From : Didier Gautheron 
A gtk tree view version of service response time.
Tested with AFP and SMB, variable size columns don't look great with SMB though.

svn path=/trunk/; revision=30227
 2009-10-01 09:04:23 +00:00
Stig Bjørlykke
5f9d734bf8 Corrected prototype for create_list(). 
svn path=/trunk/; revision=30221
 2009-09-30 19:39:33 +00:00
Stig Bjørlykke
be378b901e Rewrite some local variable names to avoid function argument names. 
svn path=/trunk/; revision=30202
 2009-09-29 19:29:03 +00:00
Stig Bjørlykke
a59f13dbf4 Renamed some local GtkWidget's to avoid variable shadowing. 
svn path=/trunk/; revision=30201
 2009-09-29 19:23:50 +00:00
Stig Bjørlykke
77c49f4d4b Made colorize_filter_te_as_deprecated() static. 
svn path=/trunk/; revision=30200
 2009-09-29 19:20:48 +00:00
Stig Bjørlykke
e384c2d682 Remove alloc of unused variables in sctp_analyse_cb(). 
This fixes bug 4064.

Set sctp_set_filter() static.
Use correct prototype for create_list().

svn path=/trunk/; revision=30195
 2009-09-29 13:04:47 +00:00
Anders Broman
ff7492d22d Trying to fix the bug found by Bill Meier: 
I'm getting the following running Wireshark on Fedora Linux after a build from a recent SVN.

(lt-wireshark:8501): Gtk-CRITICAL **: gtk_toolbar_set_style: assertion 
`GTK_IS_TOOLBAR (toolbar)'

svn path=/trunk/; revision=30185
 2009-09-28 18:58:26 +00:00
Stig Bjørlykke
ad6a8fbe51 Move cfselect_cb to avoid variable shadowing. 
svn path=/trunk/; revision=30181
 2009-09-28 17:44:06 +00:00
Stig Bjørlykke
99411c8509 Only include config.h in C files. 
svn path=/trunk/; revision=30179
 2009-09-28 17:39:27 +00:00
Stig Bjørlykke
c675651a13 Remove config.h to avoid multiple inclusions in C files. 
svn path=/trunk/; revision=30178
 2009-09-28 17:28:06 +00:00
Stig Bjørlykke
a11b2e4019 Fix a possible dereference of null pointer. 
svn path=/trunk/; revision=30177
 2009-09-27 21:28:52 +00:00
Anders Broman
271884a0f0 From Speck Michael: 
trivial patch that makes Wireshark compiling again, please check it into the sources.
There is a comment not properly terminated in file gtk\keys.h.

svn path=/trunk/; revision=30139
 2009-09-25 07:40:40 +00:00
Anders Broman
b55f1e412f Fooled by an #ifdef 
svn path=/trunk/; revision=30138
 2009-09-25 06:02:22 +00:00
Anders Broman
b3bea18e2f Remove forgotten C++ style comments. 
svn path=/trunk/; revision=30137
 2009-09-25 05:21:00 +00:00
Anders Broman
ce39b29305 Make the filter toolbar style a preference. 
svn path=/trunk/; revision=30136
 2009-09-25 05:19:18 +00:00
Anders Broman
1a1a5dd3f0 Get rid of some deprecated functions. 
svn path=/trunk/; revision=30115
 2009-09-24 15:49:56 +00:00
Anders Broman
9ac672ca81 Update *.vcproj to visual studio 8 
svn path=/trunk/; revision=30111
 2009-09-24 05:11:47 +00:00
Anders Broman
d78510ed51 option menu -> combo box. 
svn path=/trunk/; revision=30110
 2009-09-24 05:10:38 +00:00
Stig Bjørlykke
64fb3eb496 Small indent fix. 
svn path=/trunk/; revision=30102
 2009-09-23 18:36:50 +00:00
Anders Broman
c52de3ee90 Change option menu to combo box. 
svn path=/trunk/; revision=30087
 2009-09-23 14:30:56 +00:00
Anders Broman
7e06989ac3 Fix the debug code somewhat, we do not have a clist any more. 
svn path=/trunk/; revision=30085
 2009-09-23 13:54:43 +00:00
Anders Broman
2d77aab376 Fix: jyoung SVN #30065; Sort order at start of new capture. 
svn path=/trunk/; revision=30079
 2009-09-22 20:09:04 +00:00
Anders Broman
4827316ea4 - new_packet_list_resize_column() if we get an empty string from 
packet_list_get_widest_column_string() (no visible row) don't
change the colum width.
- packet_list_moveto_end() selection no longer needed.

svn path=/trunk/; revision=30077
 2009-09-22 19:36:14 +00:00
Anders Broman
ffcaf32074 Select the first packet when doing a live capture. In the old packet list this is automatically done as the clist emits a selct-row signal. 
Seting focus in new_packet_list_moveto_end() seems also to be needed to make it work properly I'm not 100% sure if it should be done differently.

svn path=/trunk/; revision=30074
 2009-09-22 18:51:33 +00:00
Kovarththanan Rajaratnam
0ee2b7754d Rename init_cap_file() to cap_file_init() 
svn path=/trunk/; revision=30073
 2009-09-22 16:53:11 +00:00
Anders Broman
08525e79d7 - Add new_packet_list_set_sel_browse() 
- When scrolling to the end don't select the row.

svn path=/trunk/; revision=30065
 2009-09-22 12:39:16 +00:00
Kovarththanan Rajaratnam
ace2a16807 Constify colour source 
svn path=/trunk/; revision=30059
 2009-09-22 04:10:50 +00:00
Stephen Fisher
60b4a9a3c5 Minor white space cleanup. 
svn path=/trunk/; revision=30056
 2009-09-21 20:20:02 +00:00
Kovarththanan Rajaratnam
8af452f83d Constify (missed in r30051) 
svn path=/trunk/; revision=30054
 2009-09-21 20:00:29 +00:00
Kovarththanan Rajaratnam
3ea9409792 Store 'color_filter' as const in 'frame_data' 
svn path=/trunk/; revision=30051
 2009-09-21 18:48:53 +00:00
Kovarththanan Rajaratnam
7ca137e294 Rename capture_file.plist to capture_file.plist_start to make it consistent with capture_file.plist_end 
svn path=/trunk/; revision=30047
 2009-09-21 18:09:19 +00:00
Anders Broman
546014cdaf cf_change_time_formats() is not needed with new packet list. 
svn path=/trunk/; revision=30034
 2009-09-21 11:58:36 +00:00
Anders Broman
219ac9ebdd Add a more verbose error printout. 
svn path=/trunk/; revision=30031
 2009-09-21 09:25:48 +00:00
Jörg Mayer
95182116aa CMake: 
- Add opcua to the list of plugins to build
- Link the gtk stuff statically into wireshark
- Beginnings of "make install"
- Change a few things about install paths

svn path=/trunk/; revision=30029
 2009-09-21 00:19:07 +00:00
Anders Broman
4ac9d6b8c5 Try to fix(take II): 
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened: 
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed 
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.

svn path=/trunk/; revision=30027
 2009-09-20 21:41:02 +00:00
Kovarththanan Rajaratnam
f76fe1b808 From Jim Young via bug 4033: 
With the "old" list if keyboard focus was initially in the details pane, the
use of the <F7>/<F8> keys will restore focus to details pane after the
prev/next move.   Without this patch "new" packet list prev/next moves simply
moves focus to summary pane.

svn path=/trunk/; revision=30025
 2009-09-20 19:39:54 +00:00
Anders Broman
0474a38cc4 Add myself and Kovarththanan Rajaratnam as co authors. 
svn path=/trunk/; revision=30006
 2009-09-20 09:12:56 +00:00
Kovarththanan Rajaratnam
5cd06c69a9 Add NEW_PACKET_LIST guard 
svn path=/trunk/; revision=30004
 2009-09-20 08:51:30 +00:00
Anders Broman
3421576de6 Fix for: 
Columns Lazy initialization clobbers cinfo packet buffer. Open a file, goto packet 1000, menu View->Show packet in a new window, the wrong packet is decoded (it's the last displayed in the packet list pane). gtk/packet_win.c:new_window_cb() should call wtap_seek_reread().

svn path=/trunk/; revision=29997
 2009-09-20 08:22:00 +00:00
Kovarththanan Rajaratnam
8767b75876 Use G_STRLOC 
svn path=/trunk/; revision=29991
 2009-09-20 07:46:12 +00:00
Anders Broman
b809359c65 Try to fix: 
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened: 
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed 
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.

svn path=/trunk/; revision=29989
 2009-09-20 07:35:55 +00:00
Guy Harris
3e9738ac89 Add support for opening separate packet window when you double-click on 
a row in the packet list.

svn path=/trunk/; revision=29987
 2009-09-19 22:51:42 +00:00
Anders Broman
6e56815095 Set focus to packet list when a row is selected. 
svn path=/trunk/; revision=29981
 2009-09-18 14:01:10 +00:00
Bill Meier
cf84f1840a Indicate if "with new_packet_list" in version info (for now to minimize any confusion). 
svn path=/trunk/; revision=29978
 2009-09-18 00:31:27 +00:00
Gerald Combs
988b882948 Remove a cast. 
svn path=/trunk/; revision=29974
 2009-09-17 16:52:42 +00:00
Anders Broman
ea43f2d906 Try to get the Solaris build going... 
(Google is your friend)

svn path=/trunk/; revision=29966
 2009-09-17 13:43:43 +00:00
Gerald Combs
ccad8f74f5 Make sure we don't fetch too much data from the registry. 
svn path=/trunk/; revision=29949
 2009-09-16 20:29:00 +00:00
Gerald Combs
668723356a Check for TCP Chimney offloading as described at 
http://support.microsoft.com/kb/912222. Print a warning on the welcome
page if it's present and enabled.

This hasn't yet been tested on a chimney-enabled machine, but it should
work.

svn path=/trunk/; revision=29948
 2009-09-16 19:23:15 +00:00
Anders Broman
00f1977bb9 Change gtk_pixmap_new() to gtk_image_new_from_pixmap(). 
svn path=/trunk/; revision=29900
 2009-09-14 16:06:31 +00:00
Anders Broman
528382445f From Didier Gautheron: 
optimizations patch http://wiki.wireshark.org/Development/Optimization
'patch.29854.diff.gz"

Speed up sorting.

svn path=/trunk/; revision=29879
 2009-09-13 16:11:11 +00:00
Anders Broman
9c5451174f 'function' : different 'const' qualifiers 
svn path=/trunk/; revision=29878
 2009-09-13 16:03:46 +00:00
Gerald Combs
3dbbc4cc4e svn path=/trunk/; revision=29868 2009-09-11 20:36:01 +00:00
Gerald Combs
05519b323a Reduce the spacing between new packet list items from 2 pixels to 1. If 
we want the new packet list to look like the old packet list we'll have
to adjust the behavior of the cell renderer.

svn path=/trunk/; revision=29867
 2009-09-11 19:13:39 +00:00
Anders Broman
b9901ede8a Be consistent use and g_string_chunk_insert_const() in stead of 
g_string_chunk_insert() as in expert_dlg.c

svn path=/trunk/; revision=29827
 2009-09-09 19:34:14 +00:00
Anders Broman
1e137770e6 Allocate col_text and col_text_len when the fdata struct is allocated. 
svn path=/trunk/; revision=29817
 2009-09-09 08:50:06 +00:00
Kovarththanan Rajaratnam
de23d92163 Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter. 
svn path=/trunk/; revision=29806
 2009-09-08 19:00:54 +00:00
Kovarththanan Rajaratnam
b90a11bee3 Make tshark and rawshark use build_column_format_array() instead of duplicating the code 
svn path=/trunk/; revision=29803
 2009-09-08 17:29:57 +00:00
Jörg Mayer
1aca48909c - now wireshark compiles with cmake as well 
svn path=/trunk/; revision=29799
 2009-09-08 15:56:16 +00:00
Kovarththanan Rajaratnam
d75778eb4a Custom columnfication: 
* Deprecate COL_DCE_CTX ("Context ID). Use dcerpc.cn_ctx_id

svn path=/trunk/; revision=29797
 2009-09-08 14:59:26 +00:00
Anders Broman
b8fba82f4c Get rid of deprecated gtk_entry_append_text(). 
svn path=/trunk/; revision=29796
 2009-09-08 14:41:25 +00:00
Anders Broman
7ce24f7744 Get rid of deprecated gtk_option_menu_new(); 
svn path=/trunk/; revision=29791
 2009-09-08 13:49:19 +00:00
Stig Bjørlykke
bc52d8079d Fixed initialization of fdata. 
svn path=/trunk/; revision=29788
 2009-09-08 10:12:01 +00:00
Jörg Mayer
3b3ea47176 dftest and rawshark now build. 
tshark might build.


svn path=/trunk/; revision=29786
 2009-09-08 07:03:57 +00:00
Kovarththanan Rajaratnam
c6f96e4ec9 Make sure that reset the elapsed time to load a file before we reload/rescan the file 
svn path=/trunk/; revision=29783
 2009-09-07 21:07:51 +00:00
Kovarththanan Rajaratnam
8d909ba79e Rename new_packet_list_set_time_width() -> new_packet_list_resize_column() because it contains no time format specific code. Further this change also ensures that new_packet_list_resize_columns() uses the newly introduced new_packet_list_resize_column() 
svn path=/trunk/; revision=29782
 2009-09-07 20:45:32 +00:00
Kovarththanan Rajaratnam
4662b8c326 Rename packet_list_dissect_and_cache => packet_list_dissect_and_cache_iter 
svn path=/trunk/; revision=29781
 2009-09-07 19:50:19 +00:00
Kovarththanan Rajaratnam
3efea601d4 Make sure that we fill in the frame_data before passing it onto col_fill_in_frame_data 
svn path=/trunk/; revision=29780
 2009-09-07 19:43:05 +00:00
Kovarththanan Rajaratnam
450de61a1e Auto resize rest of the frame_data columns 
svn path=/trunk/; revision=29779
 2009-09-07 19:07:30 +00:00
Kovarththanan Rajaratnam
33b8efd375 Auto size COL_NUMBER, COL_PACKET_LENGTH and COL_CUMULATIVE_BYTES 
svn path=/trunk/; revision=29778
 2009-09-07 18:53:17 +00:00
Kovarththanan Rajaratnam
1ce02f035d Add progress bar while constructing columns (which is time consuming) 
svn path=/trunk/; revision=29777
 2009-09-07 17:45:37 +00:00
Kovarththanan Rajaratnam
ff7fda0df5 Track how many const strings we're storing. This is guarded by NEW_PACKET_LIST_STATISTICS 
svn path=/trunk/; revision=29775
 2009-09-07 17:09:09 +00:00
Kovarththanan Rajaratnam
72c9662da6 ntroduce some seasonal address name lookup functions which we use when NEW_PACKET_LIST is defined. This change partially reverts some parts of r29768, which didn't seem to work because it assumed that get_addr_name() would always return a seasonal string. This wasn't the case if the adddress type was AT_STRINGZ. 
svn path=/trunk/; revision=29771
 2009-09-07 16:05:37 +00:00
Anders Broman
3abd049a9b Use constant strings for Addresses saves some memory. 
svn path=/trunk/; revision=29768
 2009-09-07 14:03:05 +00:00
Kovarththanan Rajaratnam
4fbc99e411 Auto resize non frame_data based columns 
svn path=/trunk/; revision=29766
 2009-09-07 13:10:59 +00:00
Stig Bjørlykke
5b1d0749de Set sensitivity on resize columns button. 
svn path=/trunk/; revision=29764
 2009-09-07 12:13:28 +00:00
Stig Bjørlykke
1eba4dca43 Enable resize columns button for new packet list. 
svn path=/trunk/; revision=29763
 2009-09-07 12:12:45 +00:00
Kovarththanan Rajaratnam
0a09528611 Add initial implementation of new_packet_list_resize_columns() which just sets the column width according to the column format (work in progress) 
svn path=/trunk/; revision=29762
 2009-09-07 12:04:59 +00:00
Anders Broman
5cc8d3e71d col_fmt not needed. 
svn path=/trunk/; revision=29760
 2009-09-07 11:50:08 +00:00
Kovarththanan Rajaratnam
cd8831c72d Track length of columns strings. We'll need this in order to resize columns quickly 
svn path=/trunk/; revision=29759
 2009-09-07 11:33:38 +00:00
Anders Broman
7473e1e04c Automatically adjust the time column width when time format changes. 
svn path=/trunk/; revision=29758
 2009-09-07 10:03:55 +00:00
Jörg Mayer
99fba22209 The external declaration of airpcap_tb here is not needed 
and creates warnings

svn path=/trunk/; revision=29757
 2009-09-07 07:30:42 +00:00
Kovarththanan Rajaratnam
8c48c6835f Rename address_to_str() to ep_address_to_str() because: 
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
 2009-09-06 14:25:47 +00:00
Kovarththanan Rajaratnam
0e5a101815 Fix target of assignment not really an lvalue error 
svn path=/trunk/; revision=29743
 2009-09-06 12:27:32 +00:00
Kovarththanan Rajaratnam
ecd9ddd845 Tigthen the condition under which we create a protocol create while sorting 
svn path=/trunk/; revision=29740
 2009-09-06 10:41:35 +00:00
Kovarththanan Rajaratnam
8edec9be91 Sort the visible list while traversing the physical row list. This halves the time needed to sort 
svn path=/trunk/; revision=29738
 2009-09-06 09:36:21 +00:00
Kovarththanan Rajaratnam
5c51aacb21 Add NEW_PACKET_LIST guard to color_filters_colorize_packet() 
svn path=/trunk/; revision=29729
 2009-09-06 06:07:53 +00:00
Kovarththanan Rajaratnam
2ab0685d8a Make sure that we can enable/disable color filtering. 
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=11&rev2=12

svn path=/trunk/; revision=29728
 2009-09-06 05:49:00 +00:00
Stig Bjørlykke
07b1329a7c Remove an obsolete gui_time_format setting. 
svn path=/trunk/; revision=29724
 2009-09-05 19:42:43 +00:00
Kovarththanan Rajaratnam
0326f65bf3 Don't copy constant column strings. This reduces memory foot print because COL_PROTOCOL is usually a constant string. This saves us 3-4 bytes for each frame 
svn path=/trunk/; revision=29723
 2009-09-05 19:07:04 +00:00
Stig Bjørlykke
8024460bc0 Move reloading pane geometry to a point where we have the correct 
main_first_pane and main_second_pane.

svn path=/trunk/; revision=29719
 2009-09-05 18:13:48 +00:00
Kovarththanan Rajaratnam
f493e75db6 Dissect-on-the-fly when we have columns that are empty, i.e. columns containing strings (COL_INFO + friends). This allows us to sort on _all_ columns now. 
svn path=/trunk/; revision=29718
 2009-09-05 16:35:05 +00:00
Kovarththanan Rajaratnam
e1eaab161d Move new_packet_list_dissect() to packet_list_store.c. We need to have it there in order to dissect columns on the fly when we have to sort 
svn path=/trunk/; revision=29717
 2009-09-05 15:46:47 +00:00
Kovarththanan Rajaratnam
583d41904c Inline cache_columns() 
svn path=/trunk/; revision=29716
 2009-09-05 15:30:34 +00:00
Kovarththanan Rajaratnam
4aa6c8baef Remove dead code. We dont construct columns while reading the file. We do that when we have to display the frame 
svn path=/trunk/; revision=29715
 2009-09-05 15:25:53 +00:00
Stig Bjørlykke
5a7d9922c1 Fetch old column width values if we have not initialized the packet list, 
so we don't write zero width values if closing before loading a capture.

svn path=/trunk/; revision=29714
 2009-09-05 14:37:02 +00:00
Kovarththanan Rajaratnam
fb54567dae Restore original condition in packet_list_iter_n_children() 
svn path=/trunk/; revision=29713
 2009-09-05 13:46:17 +00:00
Stig Bjørlykke
45bdd7577b Apply user font when changing profile with new packet list. 
svn path=/trunk/; revision=29712
 2009-09-05 13:30:16 +00:00
Kovarththanan Rajaratnam
fcf25fe42b Get rid of row_data_t 
svn path=/trunk/; revision=29711
 2009-09-05 13:27:34 +00:00
Kovarththanan Rajaratnam
2d5a1323e1 Make sure that we can resort with an active display filter 
svn path=/trunk/; revision=29710
 2009-09-05 13:24:16 +00:00
Kovarththanan Rajaratnam
a71f9bbde3 Sort out some of the confusion r29706 introduced (visible vs. physical rows). We choose the wrong packet in the packet view because we used the physical row instead of the visible. I suspect there a couple more of these lurking. 
svn path=/trunk/; revision=29708
 2009-09-05 12:42:44 +00:00
Kovarththanan Rajaratnam
2db51a0b3e Bail out gracefully on colums we cant sort on yet instead of crashing 
svn path=/trunk/; revision=29707
 2009-09-05 11:58:44 +00:00
Stig Bjørlykke
f91c46757a Make it build without warnings. 
svn path=/trunk/; revision=29706
 2009-09-05 11:15:50 +00:00
Kovarththanan Rajaratnam
95ddec4d07 Get rid off GtkTreeModelFilter because the time to sort becomes unbearable when combined with GtkTreeSortable. This means that we now track which frames are visible in the our own packet list store. To do so, we now distinguish between physical and visible rows. All frames are added as physical rows. Only those that passes the display filter are marked as visible. 
svn path=/trunk/; revision=29705
 2009-09-05 10:36:29 +00:00
Kovarththanan Rajaratnam
314b693828 Rename new_packet_list_reset_dissected to packet_list_reset_dissected 
svn path=/trunk/; revision=29699
 2009-09-04 17:42:03 +00:00
Michael Tüxen
798b1ecdb2 Cleanup whitespaces. 
svn path=/trunk/; revision=29698
 2009-09-04 13:23:51 +00:00
Michael Tüxen
471111ffc6 Fix handling of multiple duplicate TSNs. 
svn path=/trunk/; revision=29697
 2009-09-04 13:10:59 +00:00
Michael Tüxen
648bdb564b Fix compilation. 
svn path=/trunk/; revision=29696
 2009-09-04 12:52:28 +00:00
Michael Tüxen
56366dcb59 From Irene Ruengeler: Show duplicate TSNs in SACKs. 
svn path=/trunk/; revision=29695
 2009-09-04 12:42:22 +00:00
Kovarththanan Rajaratnam
4930802fa1 Only store the last column as G_TYPE_POINTER. Hopefully this will soon make us able to sort again 
svn path=/trunk/; revision=29690
 2009-09-03 17:56:57 +00:00
Kovarththanan Rajaratnam
5a8df08491 Add packet_list_visible_record() to avoid poking PacketListRecord in new_packet_list.c 
svn path=/trunk/; revision=29689
 2009-09-03 17:39:42 +00:00
Kovarththanan Rajaratnam
8a33ec23bb Allocate and use an extra column at the end of the column list to indicate the 'magic' column which contains the _entire_ PacketListRecord 
svn path=/trunk/; revision=29688
 2009-09-03 17:00:17 +00:00
Kovarththanan Rajaratnam
bd69669e1d Make sure that we stop auto scroll if we start scrolling manually. 
Caveat: we jump to first frame when auto scroll is stopped

svn path=/trunk/; revision=29685
 2009-09-03 14:32:11 +00:00
Stig Bjørlykke
7b5da30392 Read column widths from recent file also for new packet list. 
svn path=/trunk/; revision=29684
 2009-09-03 11:37:12 +00:00