Commit graph

4543 commits

Author SHA1 Message Date
Gerasimos Dimitriadis
c08fa6f3cf Move underscore escaping/unscaping function to strutil.c;
Update decoding of IS-801 Request GPS Acquisition Assistance

svn path=/trunk/; revision=31685
2010-01-26 18:21:17 +00:00
Stig Bjørlykke
77fb961f3d Introduce "Remove Ignored packets" in Packet Range frames, which is used in
Save As, Export and Print dialogs.

svn path=/trunk/; revision=31680
2010-01-26 13:08:22 +00:00
Anders Broman
98f7fe5f9a From Jakub Zawadzki:
- Create only one marker in packet_hex_print_common.
- Set start & end values in good keys.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4403

svn path=/trunk/; revision=31669
2010-01-25 20:58:24 +00:00
Gerasimos Dimitriadis
e50527b8e1 Handle underscore escaping/unescaping for old packet list; Simplify
and make more robust the unescaping function.

svn path=/trunk/; revision=31668
2010-01-25 20:30:09 +00:00
Martin Mathieson
40b7c56f01 Add a field to allow easy filtering of one SN of interest.
svn path=/trunk/; revision=31666
2010-01-25 18:32:18 +00:00
Gerasimos Dimitriadis
065546cdcb Change the prefix of the underscore escaping/unescaping
functions from g_ to ws_; Insert function names in
libwireshark.def

svn path=/trunk/; revision=31662
2010-01-25 18:14:01 +00:00
Gerasimos Dimitriadis
11e340038f Handle underscore escaping/unescaping of the column titles
under the new packet list

svn path=/trunk/; revision=31649
2010-01-24 22:25:40 +00:00
Gerasimos Dimitriadis
6c80168b46 When a custom column is added, escape the underscores in the name of
the column so that the underscores are printed and the next characters
are not interpreted as accelerators.

svn path=/trunk/; revision=31644
2010-01-24 19:57:21 +00:00
Martin Mathieson
346c1878bc Show NACKs in the UE table
svn path=/trunk/; revision=31622
2010-01-22 17:02:40 +00:00
Martin Mathieson
85a419a8fe Fix some counters.
svn path=/trunk/; revision=31621
2010-01-22 16:40:10 +00:00
Martin Mathieson
2fe243a071 Fix some labels, and maintain overall frame count
svn path=/trunk/; revision=31618
2010-01-22 14:16:49 +00:00
Martin Mathieson
a33e4ee41e Add a simple help page for LTE RLC stats.
svn path=/trunk/; revision=31616
2010-01-22 12:42:53 +00:00
Martin Mathieson
b5edad51e3 Fix a test, and make some more functions static.
svn path=/trunk/; revision=31592
2010-01-20 12:54:57 +00:00
Stig Bjørlykke
693d58697c Added rlc_lte_stat_dlg.c.
svn path=/trunk/; revision=31591
2010-01-20 12:54:39 +00:00
Martin Mathieson
417b1839f1 Add initial version of LTE RLC stats dialog.
svn path=/trunk/; revision=31588
2010-01-20 12:37:26 +00:00
Anders Broman
eef24f0765 From Jim Young:
Wireshark GUI not reporting filename after save of new capture file.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4406

svn path=/trunk/; revision=31587
2010-01-20 06:44:03 +00:00
Bill Meier
e0064797fb Use more unique names for certain enum constants.
(enum constant names are part of the global name space).
(Fixes at least one gcc -Wshadow warning).

svn path=/trunk/; revision=31572
2010-01-19 19:37:03 +00:00
Guy Harris
982cfc5410 From Jakub Zawadzki: get rid of redundant BYTE_VIEW_WIDTH and
BIT_VIEW_WIDTH definitions in favor of BYTES_PER_LINE and BITS_PER_LINE.

While we're at it, move the definition of BYTE_VIEW_SEP down among the
other definitions.

svn path=/trunk/; revision=31570
2010-01-19 19:18:51 +00:00
Guy Harris
4b8554fa3c From Jakub Zawadzki: fix the return type of hex_view_get_byte().
svn path=/trunk/; revision=31569
2010-01-19 19:12:55 +00:00
Anders Broman
ca43f3cb6a From Didier Gautheron:
Wlan stat: sorting on broadcast is broken if MAC name resolution is disabled.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4398

svn path=/trunk/; revision=31530
2010-01-15 07:01:19 +00:00
Stig Bjørlykke
68199d5506 Improved the Interface Options dialog:
- Use toggle checkbox for Hide? column
- Adjusted default column width (device name is shorter on UN*X)
- Increased dialog height

svn path=/trunk/; revision=31513
2010-01-13 14:00:20 +00:00
Stig Bjørlykke
ac458da257 Display the capture filter in the main window title when capturing.
svn path=/trunk/; revision=31512
2010-01-13 10:21:25 +00:00
Stig Bjørlykke
a8a225d1f2 Use get_column_custom_field() to get unknown custom column field.
svn path=/trunk/; revision=31490
2010-01-11 08:27:10 +00:00
Stig Bjørlykke
5c771d6e5f Fixed the tooltip for unknown custom column field.
Apply the correction fix for the old packet list.

svn path=/trunk/; revision=31489
2010-01-11 08:16:14 +00:00
Anders Broman
12479a1376 From Jim Young:
Wireshark crash with new packet list if unknown custom column field.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4379

svn path=/trunk/; revision=31485
2010-01-11 07:56:29 +00:00
Guy Harris
118cd1fbb5 Clean up indentation.
svn path=/trunk/; revision=31459
2010-01-07 02:24:06 +00:00
Stig Bjørlykke
60ffce32e7 Check for valid linktype_history in capture_get_linktype().
svn path=/trunk/; revision=31438
2010-01-04 11:59:27 +00:00
Stig Bjørlykke
330a257c0a Set correct linktype when starting capture from the welcome page.
svn path=/trunk/; revision=31393
2009-12-30 19:21:21 +00:00
Martin Mathieson
ccaca7c006 Show in stats % of UL traffic that is padding (subheader or payload).
svn path=/trunk/; revision=31390
2009-12-29 22:55:39 +00:00
Guy Harris
bdf87f037f Squelch warning from MSVC++ when building 64-bit code.
svn path=/trunk/; revision=31389
2009-12-29 21:37:20 +00:00
Bill Meier
9924afab1f Use gtk_editable_insert_text() instead of deprecated gtk_entry_append_text().
svn path=/trunk/; revision=31386
2009-12-29 19:23:39 +00:00
Bill Meier
b28c81bf19 Use gtk_progress_bar_set_fraction instead of the deprecated gtk_progress_bar_update;
svn path=/trunk/; revision=31384
2009-12-29 17:46:34 +00:00
Bill Meier
a6a1c4ce68 Use gtk_progress_bar_set_fraction instead of the deprecated gtk_progress_bar_update;
Optimize the progress_bar related code a bit;
Fix some indentation.

svn path=/trunk/; revision=31383
2009-12-29 17:41:06 +00:00
Jaap Keuter
e03e8553dd Fix for bug 4354:
Set Edit and Delete button sensitivity when deleting a row.

svn path=/trunk/; revision=31364
2009-12-27 13:26:00 +00:00
Jaap Keuter
ac7dd7b085 Add save option to RTP graph window.
svn path=/trunk/; revision=31363
2009-12-24 21:28:38 +00:00
Gerald Combs
6580e861df Rename splash_register_freq to info_update_freq. Use it to throttle name
resolution updates as well as splash screen updates.

svn path=/trunk/; revision=31351
2009-12-22 20:29:28 +00:00
Gerald Combs
4f30c2170e Change host_name_lookup_process to return TRUE if anything new has been
resolved since the last time it was called. Use this to redraw the packet
list and detail any time we have newly-resolved objects.

svn path=/trunk/; revision=31350
2009-12-22 20:01:06 +00:00
Stig Bjørlykke
c280820a86 Renamed some menu items to clarify the usage:
"Mark All Packets"   -> "Mark All Displayed Packets"
 "Ignore All Packets" -> "Ignore All Displayed Packets"

svn path=/trunk/; revision=31349
2009-12-22 12:57:39 +00:00
Stig Bjørlykke
6c329cdc06 Set correct sensitivity for "Ignore All Packets".
svn path=/trunk/; revision=31348
2009-12-22 12:53:05 +00:00
Sake Blok
5c665874ba Only mark/ignore displayed frames when doing mark/ignore all packets
svn path=/trunk/; revision=31345
2009-12-22 07:37:00 +00:00
Sake Blok
2cd7003383 Add "Ignore all packets", just like "Mark all packets"
svn path=/trunk/; revision=31343
2009-12-21 23:07:14 +00:00
Stig Bjørlykke
fe793ed781 Added Copy Profile functionality.
svn path=/trunk/; revision=31335
2009-12-21 12:32:31 +00:00
Stig Bjørlykke
d9de90be12 Set new column minimum width and resize column when changing column title
from the packet list popup menu.

svn path=/trunk/; revision=31329
2009-12-20 23:15:04 +00:00
Jaap Keuter
220054bd43 PortAudio doesn't make sure that a default device is even available on the default Host API (go figure).
Therefore opening the default stream may fail in the precense of usable devices, on other Host API's.
If the default stream fails to open iterate among the Host API's to find one with a default device.

svn path=/trunk/; revision=31318
2009-12-18 23:26:12 +00:00
Stig Bjørlykke
59835dbe0f Added some shortcuts for the Ignore Packet menu items.
svn path=/trunk/; revision=31314
2009-12-18 17:45:42 +00:00
Gerald Combs
7c0dc5d7e7 If we don't have PCRE and we do have GLib >= 2.14, use GRegexes for the
"matches" operator.

svn path=/trunk/; revision=31302
2009-12-18 01:15:08 +00:00
Jaap Keuter
9b55f28a3d Squelch GTK warnings on the RTP player progress bar when resizeing the window.
svn path=/trunk/; revision=31298
2009-12-17 19:58:57 +00:00
Jaap Keuter
b5080f83c7 Squelch a GTK warning on the RTP player spinner control.
svn path=/trunk/; revision=31297
2009-12-17 17:59:46 +00:00
Stig Bjørlykke
ef92b4ec11 Added "Ignore Packet" menu items to the main menu.
Show ignored packages in the summary dialog.

svn path=/trunk/; revision=31289
2009-12-17 12:05:13 +00:00
Stig Bjørlykke
47be3577a7 Introduce "Ignore Packet" in the packet list.
This will remove the package from the dissection functions without
removing it from the capture file.

svn path=/trunk/; revision=31287
2009-12-17 01:18:14 +00:00
Gerald Combs
7871c54e99 Behave more gracefully if WinPcap isn't installed. Don't assert if
we call pcap_open or pcap_open_live when WinPcap isn't loaded - just
return NULL. Don't display the "NPF driver isn't running" dialog if
we're capturing from stdin or a file.

Fix a cut-and-paste error in capture_pcap_linktype_list.

svn path=/trunk/; revision=31275
2009-12-15 19:29:21 +00:00
Jaap Keuter
81b585cf8e From Valerio Messina:
As now, when Wireshark save capture files, it show "Loading" in status bar and
in the dialog box, warning many users of lost them packets. Saving work as expected.
Is simply a GUI use interaction problem.

svn path=/trunk/; revision=31269
2009-12-14 22:05:29 +00:00
Stig Bjørlykke
8694c22be9 Moved conversations_ipv6.c and hostlist_ipv6.c to TAP_SRC.
svn path=/trunk/; revision=31262
2009-12-14 13:07:56 +00:00
Anders Broman
17bce3616b From Andreas Heise:
Fix different duration format beteen directions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4327

svn path=/trunk/; revision=31254
2009-12-13 10:05:35 +00:00
Guy Harris
a4b7135ce3 Rename BASE_STRUCTURE_RESET to BASE_DISPLAY_E_MASK, to clarify that it's
a mask to select the base_display_e value from a display field in a
header_field_info structure.

Never select that value by masking out the BASE_RANGE_STRING flag bit,
as that won't continue to work if more flag bits, or other bitfields,
are added.  Instead, mask with BASE_DISPLAY_E_MASK.

Note that the base_display_e value and BASE_RANGE_STRING flag are only
for integral field types, and clarify what BASE_DISPLAY_E_MASK is.

Give at least one of the reasons why hiding protocol fields is not
considered a good idea.

svn path=/trunk/; revision=31249
2009-12-12 03:15:28 +00:00
Jörg Mayer
32141ae771 Add new files
svn path=/trunk/; revision=31242
2009-12-11 11:38:49 +00:00
Jaap Keuter
fc5cc7a7fb Fix for bug 3801:
Following r28546 and r30953 this adjusts the timescale in the RTP Graph Analysis, restoring its operation.

svn path=/trunk/; revision=31240
2009-12-11 08:53:19 +00:00
Anders Broman
141e1fb3b3 From Andreas Heise:
fix missing display of max skew in reversed d.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4320

svn path=/trunk/; revision=31235
2009-12-11 06:44:47 +00:00
Jaap Keuter
0209b3014d From Clif Bratcher:
Support for IPv6 in the Conversations window.
Add IPv6 tab to the Endpoints window

svn path=/trunk/; revision=31231
2009-12-10 23:18:08 +00:00
Stig Bjørlykke
5333f8ac36 Cleanup some column alignment code.
svn path=/trunk/; revision=31217
2009-12-09 16:16:04 +00:00
Stig Bjørlykke
f10882a1f8 Save column alignment in the old packet list.
svn path=/trunk/; revision=31216
2009-12-09 15:50:20 +00:00
Stig Bjørlykke
40b1be25fa Moved column xalign values.
svn path=/trunk/; revision=31215
2009-12-09 15:48:38 +00:00
Stig Bjørlykke
f9ef0270eb Added "No Sorting" and Align menu items to the old packet list
heading popup menu.

svn path=/trunk/; revision=31214
2009-12-09 14:40:19 +00:00
Anders Broman
0f8ab929a6 When freezing/thawing selection gets lost.
svn path=/trunk/; revision=31206
2009-12-08 16:14:01 +00:00
Anders Broman
c5eabf762f - Use the gtk_tree_view_column_set_min_width() method also
when crating the list.
- Set min width to the size of the title or COLUMN_WIDTH_MIN

svn path=/trunk/; revision=31167
2009-12-03 20:59:18 +00:00
Stig Bjørlykke
39f0b9efde Improved Apply/Prepare a filter from Packet List for custom columns:
- Add quotes for strings
- Use only protocol for protocol only columns

svn path=/trunk/; revision=31158
2009-12-03 14:01:18 +00:00
Stig Bjørlykke
8a488e5fbf Use size_t for length.
svn path=/trunk/; revision=31152
2009-12-02 14:44:53 +00:00
Stig Bjørlykke
eae70bf323 Set tooltips on the column button.
svn path=/trunk/; revision=31151
2009-12-02 14:00:04 +00:00
Stig Bjørlykke
942d6e41f8 Indicate default column alignment in the popup menu.
svn path=/trunk/; revision=31150
2009-12-02 13:53:33 +00:00
Stig Bjørlykke
40b377bd66 Fixed opening correct preferences page.
svn path=/trunk/; revision=31149
2009-12-02 09:39:13 +00:00
Gerald Combs
52eaeafba9 Borrow some of the web site colors for the welcome screen.
svn path=/trunk/; revision=31147
2009-12-02 00:31:04 +00:00
Guy Harris
5f1887e630 Fix a comment.
svn path=/trunk/; revision=31146
2009-12-01 21:30:30 +00:00
Gerald Combs
9338d16323 Use pango_font_description_get_size() to pad out the default column
size.  This may require tweaking, e.g. with
pango_font_description_set_absolute_size().

svn path=/trunk/; revision=31145
2009-12-01 21:24:48 +00:00
Stig Bjørlykke
8b1f93f288 Save column alignment in the recent file.
Added center and default alignment menu items.

svn path=/trunk/; revision=31143
2009-12-01 17:07:13 +00:00
Stig Bjørlykke
81ffd50409 Added three states for sorting: ascending, descending and no sorting
(ascending on first column).

svn path=/trunk/; revision=31141
2009-12-01 16:23:20 +00:00
Guy Harris
1e72ad9469 Clean up indentation a bit more.
svn path=/trunk/; revision=31139
2009-12-01 01:40:37 +00:00
Guy Harris
a39e0b3afc Squelch LLP64 warning.
Clean up indentation somewhat.

svn path=/trunk/; revision=31138
2009-12-01 01:37:52 +00:00
Anders Broman
8c3d9cf0d7 Add a character's spacing when resizing columns.
svn path=/trunk/; revision=31134
2009-11-30 20:46:07 +00:00
Stig Bjørlykke
874657592c Move the heading context menu to secondary-button and preserve
primary-button to toggle sorting.

svn path=/trunk/; revision=31131
2009-11-30 16:15:48 +00:00
Stig Bjørlykke
bc35b6fc5a Function rename:
new_packet_list_column_clicked() -> new_packet_list_column_menu_cb() 
packet_list_column_clicked() -> packet_list_column_menu_cb() 

svn path=/trunk/; revision=31130
2009-11-30 15:58:57 +00:00
Anders Broman
875d0c46c2 From Jim Young:
Add keyboard navigation controls to TCP Stream Graphs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4144

svn path=/trunk/; revision=31122
2009-11-29 20:42:00 +00:00
Kovarththanan Rajaratnam
729497d72f Avoid possible NULL pointer dereference
svn path=/trunk/; revision=31108
2009-11-29 02:33:22 +00:00
Stig Bjørlykke
62d9adf4c3 Build for GTK older than 2.18.
svn path=/trunk/; revision=31104
2009-11-28 00:28:16 +00:00
Stig Bjørlykke
be49cd13f9 Added function to align columns.
svn path=/trunk/; revision=31099
2009-11-27 18:12:30 +00:00
Stig Bjørlykke
028996daf0 Small fix in changing column title.
svn path=/trunk/; revision=31098
2009-11-27 18:00:07 +00:00
Stig Bjørlykke
63fa42c5ab Added correct sorting for custom numeric columns.
svn path=/trunk/; revision=31097
2009-11-27 15:33:34 +00:00
Stig Bjørlykke
a68334bcec Prefix tooltip with protocol name.
svn path=/trunk/; revision=31094
2009-11-27 13:15:41 +00:00
Stig Bjørlykke
6bcb851e06 Added a descriptive tooltip to the packet list column headers.
We should probably add some more column documentation to each column.

svn path=/trunk/; revision=31093
2009-11-27 11:29:13 +00:00
Stig Bjørlykke
97cbb07e58 Fixed adding new columns from preferences.
svn path=/trunk/; revision=31091
2009-11-26 21:41:14 +00:00
Stig Bjørlykke
5fa9b50863 Cleanup object keys.
svn path=/trunk/; revision=31090
2009-11-26 16:12:03 +00:00
Stig Bjørlykke
5f2779d7bf Added the popup menu to the old packet list heading, to make it equal to
the new packet list.

svn path=/trunk/; revision=31089
2009-11-26 14:47:05 +00:00
Stig Bjørlykke
8700f6658d Add custom column before COL_INFO if this is last.
svn path=/trunk/; revision=31088
2009-11-26 09:22:01 +00:00
Stig Bjørlykke
2e06779073 Save preferences when adding and removing columns in the main window.
svn path=/trunk/; revision=31087
2009-11-26 09:11:55 +00:00
Stig Bjørlykke
43de696a6c Added a popup menu in the packet list heading to set sort order and some
functions to rename column title, resize a single column and remove a column.

svn path=/trunk/; revision=31086
2009-11-26 09:09:07 +00:00
Stig Bjørlykke
7322057d66 Added functions to rename and remove columns.
svn path=/trunk/; revision=31085
2009-11-26 09:02:29 +00:00
Stig Bjørlykke
537cacc926 Added an option to open the Preferences directly in the Layout or Columns page.
svn path=/trunk/; revision=31084
2009-11-26 08:57:21 +00:00
Stig Bjørlykke
c00e12fd9d Corrected include guard in packet_list_store.h
svn path=/trunk/; revision=31083
2009-11-26 08:52:44 +00:00
Gerald Combs
8cbaec8e99 Add a comment about dfilter_compile freezing the UI, and how we might work
around the problem.

svn path=/trunk/; revision=31066
2009-11-24 19:24:09 +00:00
Stig Bjørlykke
f7425e276d packet_list_get_widest_column_string() can return NULL, so check for this.
Use get_default_col_size() to get pixel size for string.

svn path=/trunk/; revision=31062
2009-11-24 00:16:26 +00:00
Stig Bjørlykke
3c4f5186fa Use the highest time value when calculating widest column string for
time columns.  Not the one different from the previous, which in most
cases is the last one in the list.

svn path=/trunk/; revision=31061
2009-11-24 00:12:10 +00:00