osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
30941 commits 23 branches 0 tags 1.3 GiB
Commit graph

4543 commits

Author SHA1 Message Date
Gerald Combs
7871c54e99 Behave more gracefully if WinPcap isn't installed. Don't assert if 
we call pcap_open or pcap_open_live when WinPcap isn't loaded - just
return NULL. Don't display the "NPF driver isn't running" dialog if
we're capturing from stdin or a file.

Fix a cut-and-paste error in capture_pcap_linktype_list.

svn path=/trunk/; revision=31275
 2009-12-15 19:29:21 +00:00
Jaap Keuter
81b585cf8e From Valerio Messina: 
As now, when Wireshark save capture files, it show "Loading" in status bar and
in the dialog box, warning many users of lost them packets. Saving work as expected.
Is simply a GUI use interaction problem.

svn path=/trunk/; revision=31269
 2009-12-14 22:05:29 +00:00
Stig Bjørlykke
8694c22be9 Moved conversations_ipv6.c and hostlist_ipv6.c to TAP_SRC. 
svn path=/trunk/; revision=31262
 2009-12-14 13:07:56 +00:00
Anders Broman
17bce3616b From Andreas Heise: 
Fix different duration format beteen directions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4327

svn path=/trunk/; revision=31254
 2009-12-13 10:05:35 +00:00
Guy Harris
a4b7135ce3 Rename BASE_STRUCTURE_RESET to BASE_DISPLAY_E_MASK, to clarify that it's 
a mask to select the base_display_e value from a display field in a
header_field_info structure.

Never select that value by masking out the BASE_RANGE_STRING flag bit,
as that won't continue to work if more flag bits, or other bitfields,
are added.  Instead, mask with BASE_DISPLAY_E_MASK.

Note that the base_display_e value and BASE_RANGE_STRING flag are only
for integral field types, and clarify what BASE_DISPLAY_E_MASK is.

Give at least one of the reasons why hiding protocol fields is not
considered a good idea.

svn path=/trunk/; revision=31249
 2009-12-12 03:15:28 +00:00
Jörg Mayer
32141ae771 Add new files 
svn path=/trunk/; revision=31242
 2009-12-11 11:38:49 +00:00
Jaap Keuter
fc5cc7a7fb Fix for bug 3801: 
Following r28546 and r30953 this adjusts the timescale in the RTP Graph Analysis, restoring its operation.

svn path=/trunk/; revision=31240
 2009-12-11 08:53:19 +00:00
Anders Broman
141e1fb3b3 From Andreas Heise: 
fix missing display of max skew in reversed d.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4320

svn path=/trunk/; revision=31235
 2009-12-11 06:44:47 +00:00
Jaap Keuter
0209b3014d From Clif Bratcher: 
Support for IPv6 in the Conversations window.
Add IPv6 tab to the Endpoints window

svn path=/trunk/; revision=31231
 2009-12-10 23:18:08 +00:00
Stig Bjørlykke
5333f8ac36 Cleanup some column alignment code. 
svn path=/trunk/; revision=31217
 2009-12-09 16:16:04 +00:00
Stig Bjørlykke
f10882a1f8 Save column alignment in the old packet list. 
svn path=/trunk/; revision=31216
 2009-12-09 15:50:20 +00:00
Stig Bjørlykke
40b1be25fa Moved column xalign values. 
svn path=/trunk/; revision=31215
 2009-12-09 15:48:38 +00:00
Stig Bjørlykke
f9ef0270eb Added "No Sorting" and Align menu items to the old packet list 
heading popup menu.

svn path=/trunk/; revision=31214
 2009-12-09 14:40:19 +00:00
Anders Broman
0f8ab929a6 When freezing/thawing selection gets lost. 
svn path=/trunk/; revision=31206
 2009-12-08 16:14:01 +00:00
Anders Broman
c5eabf762f - Use the gtk_tree_view_column_set_min_width() method also 
when crating the list.
- Set min width to the size of the title or COLUMN_WIDTH_MIN

svn path=/trunk/; revision=31167
 2009-12-03 20:59:18 +00:00
Stig Bjørlykke
39f0b9efde Improved Apply/Prepare a filter from Packet List for custom columns: 
- Add quotes for strings
- Use only protocol for protocol only columns

svn path=/trunk/; revision=31158
 2009-12-03 14:01:18 +00:00
Stig Bjørlykke
8a488e5fbf Use size_t for length. 
svn path=/trunk/; revision=31152
 2009-12-02 14:44:53 +00:00
Stig Bjørlykke
eae70bf323 Set tooltips on the column button. 
svn path=/trunk/; revision=31151
 2009-12-02 14:00:04 +00:00
Stig Bjørlykke
942d6e41f8 Indicate default column alignment in the popup menu. 
svn path=/trunk/; revision=31150
 2009-12-02 13:53:33 +00:00
Stig Bjørlykke
40b377bd66 Fixed opening correct preferences page. 
svn path=/trunk/; revision=31149
 2009-12-02 09:39:13 +00:00
Gerald Combs
52eaeafba9 Borrow some of the web site colors for the welcome screen. 
svn path=/trunk/; revision=31147
 2009-12-02 00:31:04 +00:00
Guy Harris
5f1887e630 Fix a comment. 
svn path=/trunk/; revision=31146
 2009-12-01 21:30:30 +00:00
Gerald Combs
9338d16323 Use pango_font_description_get_size() to pad out the default column 
size.  This may require tweaking, e.g. with
pango_font_description_set_absolute_size().

svn path=/trunk/; revision=31145
 2009-12-01 21:24:48 +00:00
Stig Bjørlykke
8b1f93f288 Save column alignment in the recent file. 
Added center and default alignment menu items.

svn path=/trunk/; revision=31143
 2009-12-01 17:07:13 +00:00
Stig Bjørlykke
81ffd50409 Added three states for sorting: ascending, descending and no sorting 
(ascending on first column).

svn path=/trunk/; revision=31141
 2009-12-01 16:23:20 +00:00
Guy Harris
1e72ad9469 Clean up indentation a bit more. 
svn path=/trunk/; revision=31139
 2009-12-01 01:40:37 +00:00
Guy Harris
a39e0b3afc Squelch LLP64 warning. 
Clean up indentation somewhat.

svn path=/trunk/; revision=31138
 2009-12-01 01:37:52 +00:00
Anders Broman
8c3d9cf0d7 Add a character's spacing when resizing columns. 
svn path=/trunk/; revision=31134
 2009-11-30 20:46:07 +00:00
Stig Bjørlykke
874657592c Move the heading context menu to secondary-button and preserve 
primary-button to toggle sorting.

svn path=/trunk/; revision=31131
 2009-11-30 16:15:48 +00:00
Stig Bjørlykke
bc35b6fc5a Function rename: 
new_packet_list_column_clicked() -> new_packet_list_column_menu_cb() 
packet_list_column_clicked() -> packet_list_column_menu_cb() 

svn path=/trunk/; revision=31130
 2009-11-30 15:58:57 +00:00
Anders Broman
875d0c46c2 From Jim Young: 
Add keyboard navigation controls to TCP Stream Graphs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4144

svn path=/trunk/; revision=31122
 2009-11-29 20:42:00 +00:00
Kovarththanan Rajaratnam
729497d72f Avoid possible NULL pointer dereference 
svn path=/trunk/; revision=31108
 2009-11-29 02:33:22 +00:00
Stig Bjørlykke
62d9adf4c3 Build for GTK older than 2.18. 
svn path=/trunk/; revision=31104
 2009-11-28 00:28:16 +00:00
Stig Bjørlykke
be49cd13f9 Added function to align columns. 
svn path=/trunk/; revision=31099
 2009-11-27 18:12:30 +00:00
Stig Bjørlykke
028996daf0 Small fix in changing column title. 
svn path=/trunk/; revision=31098
 2009-11-27 18:00:07 +00:00
Stig Bjørlykke
63fa42c5ab Added correct sorting for custom numeric columns. 
svn path=/trunk/; revision=31097
 2009-11-27 15:33:34 +00:00
Stig Bjørlykke
a68334bcec Prefix tooltip with protocol name. 
svn path=/trunk/; revision=31094
 2009-11-27 13:15:41 +00:00
Stig Bjørlykke
6bcb851e06 Added a descriptive tooltip to the packet list column headers. 
We should probably add some more column documentation to each column.

svn path=/trunk/; revision=31093
 2009-11-27 11:29:13 +00:00
Stig Bjørlykke
97cbb07e58 Fixed adding new columns from preferences. 
svn path=/trunk/; revision=31091
 2009-11-26 21:41:14 +00:00
Stig Bjørlykke
5fa9b50863 Cleanup object keys. 
svn path=/trunk/; revision=31090
 2009-11-26 16:12:03 +00:00
Stig Bjørlykke
5f2779d7bf Added the popup menu to the old packet list heading, to make it equal to 
the new packet list.

svn path=/trunk/; revision=31089
 2009-11-26 14:47:05 +00:00
Stig Bjørlykke
8700f6658d Add custom column before COL_INFO if this is last. 
svn path=/trunk/; revision=31088
 2009-11-26 09:22:01 +00:00
Stig Bjørlykke
2e06779073 Save preferences when adding and removing columns in the main window. 
svn path=/trunk/; revision=31087
 2009-11-26 09:11:55 +00:00
Stig Bjørlykke
43de696a6c Added a popup menu in the packet list heading to set sort order and some 
functions to rename column title, resize a single column and remove a column.

svn path=/trunk/; revision=31086
 2009-11-26 09:09:07 +00:00
Stig Bjørlykke
7322057d66 Added functions to rename and remove columns. 
svn path=/trunk/; revision=31085
 2009-11-26 09:02:29 +00:00
Stig Bjørlykke
537cacc926 Added an option to open the Preferences directly in the Layout or Columns page. 
svn path=/trunk/; revision=31084
 2009-11-26 08:57:21 +00:00
Stig Bjørlykke
c00e12fd9d Corrected include guard in packet_list_store.h 
svn path=/trunk/; revision=31083
 2009-11-26 08:52:44 +00:00
Gerald Combs
8cbaec8e99 Add a comment about dfilter_compile freezing the UI, and how we might work 
around the problem.

svn path=/trunk/; revision=31066
 2009-11-24 19:24:09 +00:00
Stig Bjørlykke
f7425e276d packet_list_get_widest_column_string() can return NULL, so check for this. 
Use get_default_col_size() to get pixel size for string.

svn path=/trunk/; revision=31062
 2009-11-24 00:16:26 +00:00
Stig Bjørlykke
3c4f5186fa Use the highest time value when calculating widest column string for 
time columns.  Not the one different from the previous, which in most
cases is the last one in the list.

svn path=/trunk/; revision=31061
 2009-11-24 00:12:10 +00:00
Jörg Mayer
c34a88f0ae -G -> -J 
-d -> -j
Update AUTHORS

svn path=/trunk/; revision=31037
 2009-11-20 22:55:18 +00:00
Jörg Mayer
13a0a5edf9 Johanna Sochos <johanna.sochos@swissqual.com> 
Add two new options to wireshark:
-G filter: Jump to the first frame matching filter
-d: make -G match the last frame matching filter

svn path=/trunk/; revision=31033
 2009-11-20 18:52:01 +00:00
Stig Bjørlykke
542a34ced8 Implement new_packet_list_recreate(). This should be reimplemented to 
avoid building a new table and redissecting all packets.

svn path=/trunk/; revision=31024
 2009-11-19 21:11:41 +00:00
Stig Bjørlykke
9a7d0994d8 Add a custom column from the packet details popup menu. 
This fixes bug 4246.

svn path=/trunk/; revision=31020
 2009-11-19 18:22:26 +00:00
Stig Bjørlykke
005049bebb Changed hf_ip_proto to use ipproto_val[]. 
Removed some unneeded includes.

svn path=/trunk/; revision=31017
 2009-11-19 15:30:06 +00:00
Jaap Keuter
da9746a17b Remove debug code. 
svn path=/trunk/; revision=30970
 2009-11-16 06:53:05 +00:00
Anders Broman
ba933b055a GTK_STOCK_SELECT_ALL is gtk 2.10. 
Fix indentation.

svn path=/trunk/; revision=30968
 2009-11-16 05:23:12 +00:00
Anders Broman
b16fab6435 From Alejandro Vaquero: 
Add RTP player to "RTP Stream Analysis" and makeover of VoIP flow
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4240

svn path=/trunk/; revision=30967
 2009-11-15 20:13:08 +00:00
Stig Bjørlykke
6946604051 Use the USB icon for usbmon devices on Linux. 
svn path=/trunk/; revision=30960
 2009-11-14 00:43:22 +00:00
Jaap Keuter
943bd2c32d Fix for bug 4120: 
Calculate amount of silence samples in samples/ms i.s.o. samples/s

svn path=/trunk/; revision=30953
 2009-11-13 19:51:51 +00:00
Gerald Combs
23df4e7f01 Update the AirPcap code for Win64 and enable AirPcap for the 64-bit build. 
svn path=/trunk/; revision=30945
 2009-11-12 23:48:11 +00:00
Gerald Combs
9495754ee8 Add a USB network icon. 
svn path=/trunk/; revision=30941
 2009-11-12 18:10:34 +00:00
Jörg Mayer
564500f873 - Generate manpages and html version of manpages 
- Detect pod2man/pod2html to do that
- Install manpages and html version thereof


svn path=/trunk/; revision=30934
 2009-11-11 16:20:37 +00:00
Gerald Combs
7b7d48d2a7 Check for vmnet interfaces everywhere, not just Windows and OS X. Make 
the "vmnet" check case-insensitive. Look for "vmxnet" as well. Clarify
vmnet (host) vs vmxnet (guest).

svn path=/trunk/; revision=30929
 2009-11-11 00:43:23 +00:00
Anders Broman
cafad87fd9 From Stig: 
Invalidate cfile.current_row instead(revert 30910).

svn path=/trunk/; revision=30925
 2009-11-10 20:16:14 +00:00
Gerald Combs
3d40778d1b Move the contents of image/expert_*.h to gtk/expert_indicators.h. Add 
pixbuf versions of the wired, wireless, and bluetooth interface icons to
gtk/network_icons.h. In the interface list use the new icons in all
their alpha-channel-infested glory. Add Makefile targets for rebuilding
the pixbuf files.

svn path=/trunk/; revision=30922
 2009-11-10 18:02:05 +00:00
Stig Bjørlykke
0dbfde8b6d Removed some unused variables and unused assignments. 
svn path=/trunk/; revision=30918
 2009-11-10 12:05:25 +00:00
Stig Bjørlykke
88afdd9525 Removed some dead code. The sm_resolv, sp_resolv and geoip_resolv button 
references are not used anywhere else.

svn path=/trunk/; revision=30917
 2009-11-10 12:03:57 +00:00
Stig Bjørlykke
d195614097 Yet another fix in dlg_destroy(). 
svn path=/trunk/; revision=30916
 2009-11-10 09:30:42 +00:00
Stig Bjørlykke
3946bbe2f2 Fixed a bug in dlg_destroy() to destroy all widgets. 
Removed unused variable 'sortable' in create_list().
Removed unused variable 'checksum' in sctp_stat_on_apply_filter().

svn path=/trunk/; revision=30914
 2009-11-10 09:08:43 +00:00
Gerald Combs
ca04ab9979 Instead of trying to change the background color of the info bar when we 
push a temporary message, make it "throb" using gtk_drag_highlight and
gtk_drag_unhighlight.

svn path=/trunk/; revision=30912
 2009-11-09 21:52:41 +00:00
Anders Broman
989dcf58d1 In new_packet_list_select_cb() remove the check if the packet is reselected as the row number may be the same in a filtered 
list as in the previous unfiltered list.

svn path=/trunk/; revision=30910
 2009-11-09 21:32:32 +00:00
Jörg Mayer
9ee31d1d0e cmake will now honor -Werror if configured (default: on) 
svn path=/trunk/; revision=30852
 2009-11-07 10:07:00 +00:00
Gerald Combs
3c3014820b Add some null pointer checks. This is a blind attempt to fix bug 4155. 
svn path=/trunk/; revision=30846
 2009-11-06 18:08:59 +00:00
Gerald Combs
77ce6145bb Draw little wireless icons for AirPcap adapters. 
svn path=/trunk/; revision=30839
 2009-11-05 22:23:41 +00:00
Gerald Combs
01c31f7d2a Make each level color and the light gradient color in the statusbar match. 
svn path=/trunk/; revision=30836
 2009-11-05 19:45:51 +00:00
Stig Bjørlykke
58c0abee94 Simplified printing of bits in packet bytes view. 
svn path=/trunk/; revision=30835
 2009-11-05 15:40:44 +00:00
Stig Bjørlykke
a5a7905084 From Bahaa Naamneh via bug 4207: 
Adjusts the positioning of the autocomplete popup window in a way it gets
displayed exactly under the editable box.

svn path=/trunk/; revision=30834
 2009-11-05 13:21:03 +00:00
Stig Bjørlykke
146ce8f258 Restore text_end_1 vs. text_start_2 handling. 
svn path=/trunk/; revision=30833
 2009-11-05 10:26:43 +00:00
Stig Bjørlykke
7c5f1b80ac Introduce packet bytes bit view. 
svn path=/trunk/; revision=30832
 2009-11-05 10:16:49 +00:00
Stig Bjørlykke
d0ad8bcdcf Select the previous byte in the packet bytes hex view when clicking in 
the column just behind the first half and the last half.

This behavior is more user friendly.

svn path=/trunk/; revision=30831
 2009-11-05 10:11:45 +00:00
Gerald Combs
d54eea534e Add a convenience routine to convert pixbuf data generated by 
gdk-pixbuf-csource to a GtkImage. Use it to load the expert indicator
images. Add prettier indicator images. The "chat" indicator is more blue
in order to differentiate it from the "none" indicator; make the chat
text background more blue to match.

svn path=/trunk/; revision=30825
 2009-11-04 21:16:38 +00:00
Gerald Combs
b1436f7dca Get rid of a few more simple dialogs. 
svn path=/trunk/; revision=30812
 2009-11-04 00:47:47 +00:00
Gerald Combs
5e34f21076 Add the ability to push temporary (and highlighted) messages onto the 
statusbar. This lets us notify the user about something significant
without having to pop up an annoying window. Replace a few dialogs with
statusbar messages.

svn path=/trunk/; revision=30810
 2009-11-04 00:02:52 +00:00
Stig Bjørlykke
71b719df07 From Eric Sesterhenn via bug 4175: 
Fixed cfmt->cfield and cfmt leakage in the error path.

svn path=/trunk/; revision=30756
 2009-10-29 11:20:33 +00:00
Stig Bjørlykke
a7e3a1b3d9 Check if selected packet is already selected before doing any updates. 
This was originally added in r26803 for the old packet list.

svn path=/trunk/; revision=30749
 2009-10-28 22:17:18 +00:00
Anders Broman
1dcdfd714b Get rid of deprecated GTK functions. 
svn path=/trunk/; revision=30734
 2009-10-27 20:12:37 +00:00
Stig Bjørlykke
4fe10501d2 Use correct default value in tick interval combo box. 
svn path=/trunk/; revision=30729
 2009-10-27 13:59:05 +00:00
Stig Bjørlykke
74ffeef1e8 Removed an unneeded cast. 
svn path=/trunk/; revision=30728
 2009-10-27 09:58:57 +00:00
Anders Broman
db24f90c2d From Jakub Zawadzki: 
Don't duplicate empty string in col_text

svn path=/trunk/; revision=30725
 2009-10-27 05:11:52 +00:00
Stig Bjørlykke
f88e3c3b84 From Jakub Zawadzki via bug 3764: 
Don't call strcmp() when pointers are the same.

svn path=/trunk/; revision=30685
 2009-10-24 15:51:10 +00:00
Stig Bjørlykke
3a5c9ec3b2 Load lua scripts in the plugins directory, both global and personal. 
List loaded lua scripts in Help->About->Plugins.

svn path=/trunk/; revision=30675
 2009-10-23 17:52:18 +00:00
Jaap Keuter
eae4219cea From Lars Ruoff: 
Do not make dialog windows transient to the Wireshark top level window on
WIN32, since this causes some strange behaviour on Windows.
See http://www.wireshark.org/lists/wireshark-dev/200909/msg00184.html

svn path=/trunk/; revision=30667
 2009-10-22 19:40:15 +00:00
Anders Broman
977e880afb Use gtk_combo_box in GTK v 2.4 
svn path=/trunk/; revision=30592
 2009-10-18 10:23:50 +00:00
Anders Broman
c6620d7770 More gtk_option_menu -> gtk_combo_box 
svn path=/trunk/; revision=30570
 2009-10-16 10:32:06 +00:00
Stig Bjørlykke
6f57facbe5 Added revision 30561 with changes to make it work. 
svn path=/trunk/; revision=30569
 2009-10-16 07:54:20 +00:00
Jörg Mayer
2e82dd2966 everted 
------------------------------------------------------------------------
r30561 | etxrab | 2009-10-15 18:57:26 +0200 (Do, 15 Okt 2009) | 1 line

gtk_option_menu -> gtk_combo_box
------------------------------------------------------------------------

as it broke compilation on my system and I don't know enough about gtk
to fix it properly.


In file included from /usr/include/gtk-2.0/gtk/gtk.h:224,
                 from /home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:35:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration isn’t a prototype
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: In function ‘scsistat_program_select’:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:122: error: ‘SCSI_STAT_PROG_LABEL_SBC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:122: error: (Each undeclared identifier is reported only once
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:122: error: for each function it appears in.)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:125: error: ‘SCSI_STAT_PROG_LABEL_SSC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:128: error: ‘SCSI_STAT_PROG_LABEL_MMC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:129: error: ‘SCSI_DEV_MMC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: In function ‘gtk_scsistat_init’:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:229: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:234: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:239: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:244: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:249: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: At top level:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:333: warning: comma at end of enumerator list
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: In function ‘gtk_scsistat_cb’:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:388: error: ‘severity_combo_box’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:343: warning: unused variable ‘menu_item’
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: At top level:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:452: warning: no previous declaration for ‘register_tap_listener_gtkscsistat’
make[2]: *** [gtk/CMakeFiles/ui.dir/scsi_stat.c.o] Error 1



svn path=/trunk/; revision=30565
 2009-10-15 21:44:07 +00:00
Anders Broman
77d3f2e728 gtk_option_menu -> gtk_combo_box 
svn path=/trunk/; revision=30561
 2009-10-15 16:57:26 +00:00
Anders Broman
9d45f50695 Option_menu -> combo_box 
svn path=/trunk/; revision=30543
 2009-10-12 15:27:37 +00:00
Stig Bjørlykke
bed471d64f Remove unused code. 
svn path=/trunk/; revision=30541
 2009-10-12 15:11:37 +00:00
Stig Bjørlykke
a06bfe00f0 Avoid using uninitialized values. 
svn path=/trunk/; revision=30539
 2009-10-12 15:04:46 +00:00
Stig Bjørlykke
1c8f8b4f3d Use prefs.col_list when writing recent entries for new packet list. 
This is to avoid a mismatch between cfile.cinfo and prefs.col_list.

svn path=/trunk/; revision=30529
 2009-10-12 07:55:24 +00:00
Guy Harris
134b6b0f41 The q931_info argument to q931_calls_packet() is used. Don't mark it as 
unused.

svn path=/trunk/; revision=30482
 2009-10-10 22:00:07 +00:00
Kovarththanan Rajaratnam
1615cdcba6 Start using register_tap_files() macro 
svn path=/trunk/; revision=30437
 2009-10-09 16:56:15 +00:00
Anders Broman
4bd41da307 Remove code guarded by #ifdef USE_CONVERSATION_GRAPH 
as this eems to newer have been fully implemented and the old clist is replaced now.

svn path=/trunk/; revision=30425
 2009-10-09 09:56:16 +00:00
Anders Broman
85d8b896a6 From Didier Gautheron: 
- memory leak, free the list after walking it, ie free a NULL list, ie free nothing. I've only fixed bugs introduced by me with GTKCList to TreeView modifs, it seems there's the same bug in gtk/dlg_utils.c.

svn path=/trunk/; revision=30421
 2009-10-09 09:06:22 +00:00
Anders Broman
b8755d9305 From Didier Gautheron: 
Treeview for hostlist. 
Notes:
- tested without and with geoip lib but only with the free DB (no lat/long data) thus 'open_as_map_cb' is not really tested.
 
- It changes the sorting of addresses if 'resolve names' is set and uses the same sorting than conversations. The old way may make more sense for ethernet though.

svn path=/trunk/; revision=30420
 2009-10-09 09:01:04 +00:00
Anders Broman
4d52b3aa83 From Didier Gautheron: 
- Display number with a space as thousand separator.
- Move functions use both by conversations and hostlist in gui_utils.c, they may be useful for other taps too.

svn path=/trunk/; revision=30416
 2009-10-09 08:52:36 +00:00
Anders Broman
5fa3b703a9 Use a "String pool" in the new packet list to reduce memory usage. 
svn path=/trunk/; revision=30400
 2009-10-08 13:57:19 +00:00
Anders Broman
1f34437271 From Didier Gautheron: 
conversations table leaks hash keys memory on close.
Modified by me to use g_hash_table_new_full().

svn path=/trunk/; revision=30396
 2009-10-08 07:56:48 +00:00
Anders Broman
079ff0ba27 From : Didier Gautheron 
gtktreeview patch for stat(not well tested, no traces).

svn path=/trunk/; revision=30389
 2009-10-07 10:00:26 +00:00
Anders Broman
f4938ecf33 From Jim Young: 
Add "Drag and Drop entries..." message on Columns preferences page.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4099

svn path=/trunk/; revision=30381
 2009-10-07 05:03:16 +00:00
Stig Bjørlykke
98024a007f Invert check for getopt: NEED_GETOPT_H -> HAVE_GETOPT_H 
Rename getopt.[ch] -> wsgetopt.[ch] to avoid name collision.

svn path=/trunk/; revision=30370
 2009-10-06 16:01:18 +00:00
Kovarththanan Rajaratnam
e02fcd3990 Remove superfluous cast 
svn path=/trunk/; revision=30366
 2009-10-06 14:02:01 +00:00
Kovarththanan Rajaratnam
73316149c0 Use G_SEARCHPATH_SEPARATOR_S 
svn path=/trunk/; revision=30365
 2009-10-06 13:58:17 +00:00
Kovarththanan Rajaratnam
4d0be14403 Make splash_destroy() return a gboolean 
svn path=/trunk/; revision=30364
 2009-10-06 13:54:32 +00:00
Kovarththanan Rajaratnam
d1dda18cca Guard icon_list_create() 
svn path=/trunk/; revision=30363
 2009-10-06 13:51:56 +00:00
Stig Bjørlykke
727f0062a7 Mark some functions static. 
Removed an unused tooltips.

svn path=/trunk/; revision=30362
 2009-10-06 13:26:00 +00:00
Stig Bjørlykke
4355ba12a9 Removed unused variable thdr. 
svn path=/trunk/; revision=30359
 2009-10-06 13:21:15 +00:00
Stig Bjørlykke
cd31f4d83a Removed unused sortable. 
svn path=/trunk/; revision=30358
 2009-10-06 13:20:40 +00:00
Anders Broman
b42fda0fd2 From : Didier Gautheron 
gtktreeview for conversations:
- use a garray rather than g_realloc memory for conversations list.
- use a hashtable for finding conversation rather than a linear search.

Notes:
- sorting is too slow, I disabled it.
- the dialog box is really a big problem because it's also empty the idle event queue, slow down a lot.
- Test on a 1.5M packets with hundred thousands conversations capture, slow but bearable.

svn path=/trunk/; revision=30353
 2009-10-06 07:44:48 +00:00
Stig Bjørlykke
8ad8a9a233 Return from sctp_stat_on_select_row() if nothing selected. 
svn path=/trunk/; revision=30338
 2009-10-05 17:52:23 +00:00
Anders Broman
2bd73944ff From Didier Gautheron: 
Sorting wasn't working right for time columns.

svn path=/trunk/; revision=30336
 2009-10-05 17:19:39 +00:00
Anders Broman
73452c577b Prepare to change GtkItemFactory to GtkUIManager. 
(Will not have time to work on this for a while).

svn path=/trunk/; revision=30325
 2009-10-05 08:32:59 +00:00
Anders Broman
4a0dc1b5b5 Make Wireshark compile on Windows. 
svn path=/trunk/; revision=30324
 2009-10-05 08:31:31 +00:00
Stig Bjørlykke
066b12d7d4 Prototype follow_add_to_gtk_text(). 
Made some functions static.

svn path=/trunk/; revision=30323
 2009-10-05 07:25:33 +00:00
Stig Bjørlykke
4bc43c93d4 Prototype reset_tap_update_timer() in main.h 
svn path=/trunk/; revision=30322
 2009-10-05 07:02:38 +00:00
Anders Broman
8fc53b829b Use gtk_image_new_from_pixmap(). 
svn path=/trunk/; revision=30316
 2009-10-04 18:33:23 +00:00
Anders Broman
199330559c Remove #if 0'ed code. 
svn path=/trunk/; revision=30312
 2009-10-04 18:21:14 +00:00
Anders Broman
ecc0cdb162 From GTK docs: 
Warning
gtk_window_set_policy is deprecated and should not be used in newly-written code. Use gtk_window_set_resizable() instead.

Changes how a toplevel window deals with its size request and user resize attempts. There are really only two reasonable ways to call this function: 

1.gtk_window_set_policy (GTK_WINDOW (window), FALSE, TRUE, FALSE) means that the window is user-resizable. 

2.gtk_window_set_policy (GTK_WINDOW (window), FALSE, FALSE, TRUE) means that the window's size is program-controlled, and should simply match the current size request of the window's children. 

gtk_window_set_resizable () :
Sets whether the user can resize a window. Windows are user resizable by default.

svn path=/trunk/; revision=30311
 2009-10-04 18:11:22 +00:00
Anders Broman
fa3b06e9de Get rid of deprecated symblol gtk_widget_draw(). 
svn path=/trunk/; revision=30305
 2009-10-04 15:49:52 +00:00
Kovarththanan Rajaratnam
62de58c913 Fix create_list() prototype 
svn path=/trunk/; revision=30300
 2009-10-04 12:31:32 +00:00
Kovarththanan Rajaratnam
a653c171f2 Add HAVE_AIRPDCAP guard 
svn path=/trunk/; revision=30299
 2009-10-04 12:25:20 +00:00
Kovarththanan Rajaratnam
5b6a59936e make-tapreg-dotc has moved to tools/make-tapreg-dotc 
svn path=/trunk/; revision=30295
 2009-10-04 10:01:34 +00:00
Kovarththanan Rajaratnam
dd4e4fc6d6 make-tapreg-dotc has moved to tools/make-tapreg-dotc 
svn path=/trunk/; revision=30293
 2009-10-04 09:12:14 +00:00
Stig Bjørlykke
6325c5d30f Return from dfilter_expr_dlg_accept_cb() if nothing selected. 
svn path=/trunk/; revision=30235
 2009-10-01 14:44:59 +00:00
Stig Bjørlykke
68778b862e Added check for valid pointers (to avoid warnings). 
svn path=/trunk/; revision=30234
 2009-10-01 14:41:34 +00:00
Anders Broman
e7948dc626 From : Didier Gautheron 
A gtk tree view version of service response time.
Tested with AFP and SMB, variable size columns don't look great with SMB though.

svn path=/trunk/; revision=30227
 2009-10-01 09:04:23 +00:00
Stig Bjørlykke
5f9d734bf8 Corrected prototype for create_list(). 
svn path=/trunk/; revision=30221
 2009-09-30 19:39:33 +00:00
Stig Bjørlykke
be378b901e Rewrite some local variable names to avoid function argument names. 
svn path=/trunk/; revision=30202
 2009-09-29 19:29:03 +00:00
Stig Bjørlykke
a59f13dbf4 Renamed some local GtkWidget's to avoid variable shadowing. 
svn path=/trunk/; revision=30201
 2009-09-29 19:23:50 +00:00
Stig Bjørlykke
77c49f4d4b Made colorize_filter_te_as_deprecated() static. 
svn path=/trunk/; revision=30200
 2009-09-29 19:20:48 +00:00
Stig Bjørlykke
e384c2d682 Remove alloc of unused variables in sctp_analyse_cb(). 
This fixes bug 4064.

Set sctp_set_filter() static.
Use correct prototype for create_list().

svn path=/trunk/; revision=30195
 2009-09-29 13:04:47 +00:00
Anders Broman
ff7492d22d Trying to fix the bug found by Bill Meier: 
I'm getting the following running Wireshark on Fedora Linux after a build from a recent SVN.

(lt-wireshark:8501): Gtk-CRITICAL **: gtk_toolbar_set_style: assertion 
`GTK_IS_TOOLBAR (toolbar)'

svn path=/trunk/; revision=30185
 2009-09-28 18:58:26 +00:00
Stig Bjørlykke
ad6a8fbe51 Move cfselect_cb to avoid variable shadowing. 
svn path=/trunk/; revision=30181
 2009-09-28 17:44:06 +00:00
Stig Bjørlykke
99411c8509 Only include config.h in C files. 
svn path=/trunk/; revision=30179
 2009-09-28 17:39:27 +00:00
Stig Bjørlykke
c675651a13 Remove config.h to avoid multiple inclusions in C files. 
svn path=/trunk/; revision=30178
 2009-09-28 17:28:06 +00:00
Stig Bjørlykke
a11b2e4019 Fix a possible dereference of null pointer. 
svn path=/trunk/; revision=30177
 2009-09-27 21:28:52 +00:00
Anders Broman
271884a0f0 From Speck Michael: 
trivial patch that makes Wireshark compiling again, please check it into the sources.
There is a comment not properly terminated in file gtk\keys.h.

svn path=/trunk/; revision=30139
 2009-09-25 07:40:40 +00:00
Anders Broman
b55f1e412f Fooled by an #ifdef 
svn path=/trunk/; revision=30138
 2009-09-25 06:02:22 +00:00