osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
30941 commits 23 branches 0 tags 1.3 GiB
Commit graph

4543 commits

Author SHA1 Message Date
Stig Bjørlykke
a06bfe00f0 Avoid using uninitialized values. 
svn path=/trunk/; revision=30539
 2009-10-12 15:04:46 +00:00
Stig Bjørlykke
1c8f8b4f3d Use prefs.col_list when writing recent entries for new packet list. 
This is to avoid a mismatch between cfile.cinfo and prefs.col_list.

svn path=/trunk/; revision=30529
 2009-10-12 07:55:24 +00:00
Guy Harris
134b6b0f41 The q931_info argument to q931_calls_packet() is used. Don't mark it as 
unused.

svn path=/trunk/; revision=30482
 2009-10-10 22:00:07 +00:00
Kovarththanan Rajaratnam
1615cdcba6 Start using register_tap_files() macro 
svn path=/trunk/; revision=30437
 2009-10-09 16:56:15 +00:00
Anders Broman
4bd41da307 Remove code guarded by #ifdef USE_CONVERSATION_GRAPH 
as this eems to newer have been fully implemented and the old clist is replaced now.

svn path=/trunk/; revision=30425
 2009-10-09 09:56:16 +00:00
Anders Broman
85d8b896a6 From Didier Gautheron: 
- memory leak, free the list after walking it, ie free a NULL list, ie free nothing. I've only fixed bugs introduced by me with GTKCList to TreeView modifs, it seems there's the same bug in gtk/dlg_utils.c.

svn path=/trunk/; revision=30421
 2009-10-09 09:06:22 +00:00
Anders Broman
b8755d9305 From Didier Gautheron: 
Treeview for hostlist. 
Notes:
- tested without and with geoip lib but only with the free DB (no lat/long data) thus 'open_as_map_cb' is not really tested.
 
- It changes the sorting of addresses if 'resolve names' is set and uses the same sorting than conversations. The old way may make more sense for ethernet though.

svn path=/trunk/; revision=30420
 2009-10-09 09:01:04 +00:00
Anders Broman
4d52b3aa83 From Didier Gautheron: 
- Display number with a space as thousand separator.
- Move functions use both by conversations and hostlist in gui_utils.c, they may be useful for other taps too.

svn path=/trunk/; revision=30416
 2009-10-09 08:52:36 +00:00
Anders Broman
5fa3b703a9 Use a "String pool" in the new packet list to reduce memory usage. 
svn path=/trunk/; revision=30400
 2009-10-08 13:57:19 +00:00
Anders Broman
1f34437271 From Didier Gautheron: 
conversations table leaks hash keys memory on close.
Modified by me to use g_hash_table_new_full().

svn path=/trunk/; revision=30396
 2009-10-08 07:56:48 +00:00
Anders Broman
079ff0ba27 From : Didier Gautheron 
gtktreeview patch for stat(not well tested, no traces).

svn path=/trunk/; revision=30389
 2009-10-07 10:00:26 +00:00
Anders Broman
f4938ecf33 From Jim Young: 
Add "Drag and Drop entries..." message on Columns preferences page.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4099

svn path=/trunk/; revision=30381
 2009-10-07 05:03:16 +00:00
Stig Bjørlykke
98024a007f Invert check for getopt: NEED_GETOPT_H -> HAVE_GETOPT_H 
Rename getopt.[ch] -> wsgetopt.[ch] to avoid name collision.

svn path=/trunk/; revision=30370
 2009-10-06 16:01:18 +00:00
Kovarththanan Rajaratnam
e02fcd3990 Remove superfluous cast 
svn path=/trunk/; revision=30366
 2009-10-06 14:02:01 +00:00
Kovarththanan Rajaratnam
73316149c0 Use G_SEARCHPATH_SEPARATOR_S 
svn path=/trunk/; revision=30365
 2009-10-06 13:58:17 +00:00
Kovarththanan Rajaratnam
4d0be14403 Make splash_destroy() return a gboolean 
svn path=/trunk/; revision=30364
 2009-10-06 13:54:32 +00:00
Kovarththanan Rajaratnam
d1dda18cca Guard icon_list_create() 
svn path=/trunk/; revision=30363
 2009-10-06 13:51:56 +00:00
Stig Bjørlykke
727f0062a7 Mark some functions static. 
Removed an unused tooltips.

svn path=/trunk/; revision=30362
 2009-10-06 13:26:00 +00:00
Stig Bjørlykke
4355ba12a9 Removed unused variable thdr. 
svn path=/trunk/; revision=30359
 2009-10-06 13:21:15 +00:00
Stig Bjørlykke
cd31f4d83a Removed unused sortable. 
svn path=/trunk/; revision=30358
 2009-10-06 13:20:40 +00:00
Anders Broman
b42fda0fd2 From : Didier Gautheron 
gtktreeview for conversations:
- use a garray rather than g_realloc memory for conversations list.
- use a hashtable for finding conversation rather than a linear search.

Notes:
- sorting is too slow, I disabled it.
- the dialog box is really a big problem because it's also empty the idle event queue, slow down a lot.
- Test on a 1.5M packets with hundred thousands conversations capture, slow but bearable.

svn path=/trunk/; revision=30353
 2009-10-06 07:44:48 +00:00
Stig Bjørlykke
8ad8a9a233 Return from sctp_stat_on_select_row() if nothing selected. 
svn path=/trunk/; revision=30338
 2009-10-05 17:52:23 +00:00
Anders Broman
2bd73944ff From Didier Gautheron: 
Sorting wasn't working right for time columns.

svn path=/trunk/; revision=30336
 2009-10-05 17:19:39 +00:00
Anders Broman
73452c577b Prepare to change GtkItemFactory to GtkUIManager. 
(Will not have time to work on this for a while).

svn path=/trunk/; revision=30325
 2009-10-05 08:32:59 +00:00
Anders Broman
4a0dc1b5b5 Make Wireshark compile on Windows. 
svn path=/trunk/; revision=30324
 2009-10-05 08:31:31 +00:00
Stig Bjørlykke
066b12d7d4 Prototype follow_add_to_gtk_text(). 
Made some functions static.

svn path=/trunk/; revision=30323
 2009-10-05 07:25:33 +00:00
Stig Bjørlykke
4bc43c93d4 Prototype reset_tap_update_timer() in main.h 
svn path=/trunk/; revision=30322
 2009-10-05 07:02:38 +00:00
Anders Broman
8fc53b829b Use gtk_image_new_from_pixmap(). 
svn path=/trunk/; revision=30316
 2009-10-04 18:33:23 +00:00
Anders Broman
199330559c Remove #if 0'ed code. 
svn path=/trunk/; revision=30312
 2009-10-04 18:21:14 +00:00
Anders Broman
ecc0cdb162 From GTK docs: 
Warning
gtk_window_set_policy is deprecated and should not be used in newly-written code. Use gtk_window_set_resizable() instead.

Changes how a toplevel window deals with its size request and user resize attempts. There are really only two reasonable ways to call this function: 

1.gtk_window_set_policy (GTK_WINDOW (window), FALSE, TRUE, FALSE) means that the window is user-resizable. 

2.gtk_window_set_policy (GTK_WINDOW (window), FALSE, FALSE, TRUE) means that the window's size is program-controlled, and should simply match the current size request of the window's children. 

gtk_window_set_resizable () :
Sets whether the user can resize a window. Windows are user resizable by default.

svn path=/trunk/; revision=30311
 2009-10-04 18:11:22 +00:00
Anders Broman
fa3b06e9de Get rid of deprecated symblol gtk_widget_draw(). 
svn path=/trunk/; revision=30305
 2009-10-04 15:49:52 +00:00
Kovarththanan Rajaratnam
62de58c913 Fix create_list() prototype 
svn path=/trunk/; revision=30300
 2009-10-04 12:31:32 +00:00
Kovarththanan Rajaratnam
a653c171f2 Add HAVE_AIRPDCAP guard 
svn path=/trunk/; revision=30299
 2009-10-04 12:25:20 +00:00
Kovarththanan Rajaratnam
5b6a59936e make-tapreg-dotc has moved to tools/make-tapreg-dotc 
svn path=/trunk/; revision=30295
 2009-10-04 10:01:34 +00:00
Kovarththanan Rajaratnam
dd4e4fc6d6 make-tapreg-dotc has moved to tools/make-tapreg-dotc 
svn path=/trunk/; revision=30293
 2009-10-04 09:12:14 +00:00
Stig Bjørlykke
6325c5d30f Return from dfilter_expr_dlg_accept_cb() if nothing selected. 
svn path=/trunk/; revision=30235
 2009-10-01 14:44:59 +00:00
Stig Bjørlykke
68778b862e Added check for valid pointers (to avoid warnings). 
svn path=/trunk/; revision=30234
 2009-10-01 14:41:34 +00:00
Anders Broman
e7948dc626 From : Didier Gautheron 
A gtk tree view version of service response time.
Tested with AFP and SMB, variable size columns don't look great with SMB though.

svn path=/trunk/; revision=30227
 2009-10-01 09:04:23 +00:00
Stig Bjørlykke
5f9d734bf8 Corrected prototype for create_list(). 
svn path=/trunk/; revision=30221
 2009-09-30 19:39:33 +00:00
Stig Bjørlykke
be378b901e Rewrite some local variable names to avoid function argument names. 
svn path=/trunk/; revision=30202
 2009-09-29 19:29:03 +00:00
Stig Bjørlykke
a59f13dbf4 Renamed some local GtkWidget's to avoid variable shadowing. 
svn path=/trunk/; revision=30201
 2009-09-29 19:23:50 +00:00
Stig Bjørlykke
77c49f4d4b Made colorize_filter_te_as_deprecated() static. 
svn path=/trunk/; revision=30200
 2009-09-29 19:20:48 +00:00
Stig Bjørlykke
e384c2d682 Remove alloc of unused variables in sctp_analyse_cb(). 
This fixes bug 4064.

Set sctp_set_filter() static.
Use correct prototype for create_list().

svn path=/trunk/; revision=30195
 2009-09-29 13:04:47 +00:00
Anders Broman
ff7492d22d Trying to fix the bug found by Bill Meier: 
I'm getting the following running Wireshark on Fedora Linux after a build from a recent SVN.

(lt-wireshark:8501): Gtk-CRITICAL **: gtk_toolbar_set_style: assertion 
`GTK_IS_TOOLBAR (toolbar)'

svn path=/trunk/; revision=30185
 2009-09-28 18:58:26 +00:00
Stig Bjørlykke
ad6a8fbe51 Move cfselect_cb to avoid variable shadowing. 
svn path=/trunk/; revision=30181
 2009-09-28 17:44:06 +00:00
Stig Bjørlykke
99411c8509 Only include config.h in C files. 
svn path=/trunk/; revision=30179
 2009-09-28 17:39:27 +00:00
Stig Bjørlykke
c675651a13 Remove config.h to avoid multiple inclusions in C files. 
svn path=/trunk/; revision=30178
 2009-09-28 17:28:06 +00:00
Stig Bjørlykke
a11b2e4019 Fix a possible dereference of null pointer. 
svn path=/trunk/; revision=30177
 2009-09-27 21:28:52 +00:00
Anders Broman
271884a0f0 From Speck Michael: 
trivial patch that makes Wireshark compiling again, please check it into the sources.
There is a comment not properly terminated in file gtk\keys.h.

svn path=/trunk/; revision=30139
 2009-09-25 07:40:40 +00:00
Anders Broman
b55f1e412f Fooled by an #ifdef 
svn path=/trunk/; revision=30138
 2009-09-25 06:02:22 +00:00
Anders Broman
b3bea18e2f Remove forgotten C++ style comments. 
svn path=/trunk/; revision=30137
 2009-09-25 05:21:00 +00:00
Anders Broman
ce39b29305 Make the filter toolbar style a preference. 
svn path=/trunk/; revision=30136
 2009-09-25 05:19:18 +00:00
Anders Broman
1a1a5dd3f0 Get rid of some deprecated functions. 
svn path=/trunk/; revision=30115
 2009-09-24 15:49:56 +00:00
Anders Broman
9ac672ca81 Update *.vcproj to visual studio 8 
svn path=/trunk/; revision=30111
 2009-09-24 05:11:47 +00:00
Anders Broman
d78510ed51 option menu -> combo box. 
svn path=/trunk/; revision=30110
 2009-09-24 05:10:38 +00:00
Stig Bjørlykke
64fb3eb496 Small indent fix. 
svn path=/trunk/; revision=30102
 2009-09-23 18:36:50 +00:00
Anders Broman
c52de3ee90 Change option menu to combo box. 
svn path=/trunk/; revision=30087
 2009-09-23 14:30:56 +00:00
Anders Broman
7e06989ac3 Fix the debug code somewhat, we do not have a clist any more. 
svn path=/trunk/; revision=30085
 2009-09-23 13:54:43 +00:00
Anders Broman
2d77aab376 Fix: jyoung SVN #30065; Sort order at start of new capture. 
svn path=/trunk/; revision=30079
 2009-09-22 20:09:04 +00:00
Anders Broman
4827316ea4 - new_packet_list_resize_column() if we get an empty string from 
packet_list_get_widest_column_string() (no visible row) don't
change the colum width.
- packet_list_moveto_end() selection no longer needed.

svn path=/trunk/; revision=30077
 2009-09-22 19:36:14 +00:00
Anders Broman
ffcaf32074 Select the first packet when doing a live capture. In the old packet list this is automatically done as the clist emits a selct-row signal. 
Seting focus in new_packet_list_moveto_end() seems also to be needed to make it work properly I'm not 100% sure if it should be done differently.

svn path=/trunk/; revision=30074
 2009-09-22 18:51:33 +00:00
Kovarththanan Rajaratnam
0ee2b7754d Rename init_cap_file() to cap_file_init() 
svn path=/trunk/; revision=30073
 2009-09-22 16:53:11 +00:00
Anders Broman
08525e79d7 - Add new_packet_list_set_sel_browse() 
- When scrolling to the end don't select the row.

svn path=/trunk/; revision=30065
 2009-09-22 12:39:16 +00:00
Kovarththanan Rajaratnam
ace2a16807 Constify colour source 
svn path=/trunk/; revision=30059
 2009-09-22 04:10:50 +00:00
Stephen Fisher
60b4a9a3c5 Minor white space cleanup. 
svn path=/trunk/; revision=30056
 2009-09-21 20:20:02 +00:00
Kovarththanan Rajaratnam
8af452f83d Constify (missed in r30051) 
svn path=/trunk/; revision=30054
 2009-09-21 20:00:29 +00:00
Kovarththanan Rajaratnam
3ea9409792 Store 'color_filter' as const in 'frame_data' 
svn path=/trunk/; revision=30051
 2009-09-21 18:48:53 +00:00
Kovarththanan Rajaratnam
7ca137e294 Rename capture_file.plist to capture_file.plist_start to make it consistent with capture_file.plist_end 
svn path=/trunk/; revision=30047
 2009-09-21 18:09:19 +00:00
Anders Broman
546014cdaf cf_change_time_formats() is not needed with new packet list. 
svn path=/trunk/; revision=30034
 2009-09-21 11:58:36 +00:00
Anders Broman
219ac9ebdd Add a more verbose error printout. 
svn path=/trunk/; revision=30031
 2009-09-21 09:25:48 +00:00
Jörg Mayer
95182116aa CMake: 
- Add opcua to the list of plugins to build
- Link the gtk stuff statically into wireshark
- Beginnings of "make install"
- Change a few things about install paths

svn path=/trunk/; revision=30029
 2009-09-21 00:19:07 +00:00
Anders Broman
4ac9d6b8c5 Try to fix(take II): 
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened: 
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed 
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.

svn path=/trunk/; revision=30027
 2009-09-20 21:41:02 +00:00
Kovarththanan Rajaratnam
f76fe1b808 From Jim Young via bug 4033: 
With the "old" list if keyboard focus was initially in the details pane, the
use of the <F7>/<F8> keys will restore focus to details pane after the
prev/next move.   Without this patch "new" packet list prev/next moves simply
moves focus to summary pane.

svn path=/trunk/; revision=30025
 2009-09-20 19:39:54 +00:00
Anders Broman
0474a38cc4 Add myself and Kovarththanan Rajaratnam as co authors. 
svn path=/trunk/; revision=30006
 2009-09-20 09:12:56 +00:00
Kovarththanan Rajaratnam
5cd06c69a9 Add NEW_PACKET_LIST guard 
svn path=/trunk/; revision=30004
 2009-09-20 08:51:30 +00:00
Anders Broman
3421576de6 Fix for: 
Columns Lazy initialization clobbers cinfo packet buffer. Open a file, goto packet 1000, menu View->Show packet in a new window, the wrong packet is decoded (it's the last displayed in the packet list pane). gtk/packet_win.c:new_window_cb() should call wtap_seek_reread().

svn path=/trunk/; revision=29997
 2009-09-20 08:22:00 +00:00
Kovarththanan Rajaratnam
8767b75876 Use G_STRLOC 
svn path=/trunk/; revision=29991
 2009-09-20 07:46:12 +00:00
Anders Broman
b809359c65 Try to fix: 
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened: 
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed 
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.

svn path=/trunk/; revision=29989
 2009-09-20 07:35:55 +00:00
Guy Harris
3e9738ac89 Add support for opening separate packet window when you double-click on 
a row in the packet list.

svn path=/trunk/; revision=29987
 2009-09-19 22:51:42 +00:00
Anders Broman
6e56815095 Set focus to packet list when a row is selected. 
svn path=/trunk/; revision=29981
 2009-09-18 14:01:10 +00:00
Bill Meier
cf84f1840a Indicate if "with new_packet_list" in version info (for now to minimize any confusion). 
svn path=/trunk/; revision=29978
 2009-09-18 00:31:27 +00:00
Gerald Combs
988b882948 Remove a cast. 
svn path=/trunk/; revision=29974
 2009-09-17 16:52:42 +00:00
Anders Broman
ea43f2d906 Try to get the Solaris build going... 
(Google is your friend)

svn path=/trunk/; revision=29966
 2009-09-17 13:43:43 +00:00
Gerald Combs
ccad8f74f5 Make sure we don't fetch too much data from the registry. 
svn path=/trunk/; revision=29949
 2009-09-16 20:29:00 +00:00
Gerald Combs
668723356a Check for TCP Chimney offloading as described at 
http://support.microsoft.com/kb/912222. Print a warning on the welcome
page if it's present and enabled.

This hasn't yet been tested on a chimney-enabled machine, but it should
work.

svn path=/trunk/; revision=29948
 2009-09-16 19:23:15 +00:00
Anders Broman
00f1977bb9 Change gtk_pixmap_new() to gtk_image_new_from_pixmap(). 
svn path=/trunk/; revision=29900
 2009-09-14 16:06:31 +00:00
Anders Broman
528382445f From Didier Gautheron: 
optimizations patch http://wiki.wireshark.org/Development/Optimization
'patch.29854.diff.gz"

Speed up sorting.

svn path=/trunk/; revision=29879
 2009-09-13 16:11:11 +00:00
Anders Broman
9c5451174f 'function' : different 'const' qualifiers 
svn path=/trunk/; revision=29878
 2009-09-13 16:03:46 +00:00
Gerald Combs
3dbbc4cc4e svn path=/trunk/; revision=29868 2009-09-11 20:36:01 +00:00
Gerald Combs
05519b323a Reduce the spacing between new packet list items from 2 pixels to 1. If 
we want the new packet list to look like the old packet list we'll have
to adjust the behavior of the cell renderer.

svn path=/trunk/; revision=29867
 2009-09-11 19:13:39 +00:00
Anders Broman
b9901ede8a Be consistent use and g_string_chunk_insert_const() in stead of 
g_string_chunk_insert() as in expert_dlg.c

svn path=/trunk/; revision=29827
 2009-09-09 19:34:14 +00:00
Anders Broman
1e137770e6 Allocate col_text and col_text_len when the fdata struct is allocated. 
svn path=/trunk/; revision=29817
 2009-09-09 08:50:06 +00:00
Kovarththanan Rajaratnam
de23d92163 Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter. 
svn path=/trunk/; revision=29806
 2009-09-08 19:00:54 +00:00
Kovarththanan Rajaratnam
b90a11bee3 Make tshark and rawshark use build_column_format_array() instead of duplicating the code 
svn path=/trunk/; revision=29803
 2009-09-08 17:29:57 +00:00
Jörg Mayer
1aca48909c - now wireshark compiles with cmake as well 
svn path=/trunk/; revision=29799
 2009-09-08 15:56:16 +00:00
Kovarththanan Rajaratnam
d75778eb4a Custom columnfication: 
* Deprecate COL_DCE_CTX ("Context ID). Use dcerpc.cn_ctx_id

svn path=/trunk/; revision=29797
 2009-09-08 14:59:26 +00:00
Anders Broman
b8fba82f4c Get rid of deprecated gtk_entry_append_text(). 
svn path=/trunk/; revision=29796
 2009-09-08 14:41:25 +00:00
Anders Broman
7ce24f7744 Get rid of deprecated gtk_option_menu_new(); 
svn path=/trunk/; revision=29791
 2009-09-08 13:49:19 +00:00
Stig Bjørlykke
bc52d8079d Fixed initialization of fdata. 
svn path=/trunk/; revision=29788
 2009-09-08 10:12:01 +00:00
Jörg Mayer
3b3ea47176 dftest and rawshark now build. 
tshark might build.


svn path=/trunk/; revision=29786
 2009-09-08 07:03:57 +00:00
Kovarththanan Rajaratnam
c6f96e4ec9 Make sure that reset the elapsed time to load a file before we reload/rescan the file 
svn path=/trunk/; revision=29783
 2009-09-07 21:07:51 +00:00
Kovarththanan Rajaratnam
8d909ba79e Rename new_packet_list_set_time_width() -> new_packet_list_resize_column() because it contains no time format specific code. Further this change also ensures that new_packet_list_resize_columns() uses the newly introduced new_packet_list_resize_column() 
svn path=/trunk/; revision=29782
 2009-09-07 20:45:32 +00:00
Kovarththanan Rajaratnam
4662b8c326 Rename packet_list_dissect_and_cache => packet_list_dissect_and_cache_iter 
svn path=/trunk/; revision=29781
 2009-09-07 19:50:19 +00:00
Kovarththanan Rajaratnam
3efea601d4 Make sure that we fill in the frame_data before passing it onto col_fill_in_frame_data 
svn path=/trunk/; revision=29780
 2009-09-07 19:43:05 +00:00
Kovarththanan Rajaratnam
450de61a1e Auto resize rest of the frame_data columns 
svn path=/trunk/; revision=29779
 2009-09-07 19:07:30 +00:00
Kovarththanan Rajaratnam
33b8efd375 Auto size COL_NUMBER, COL_PACKET_LENGTH and COL_CUMULATIVE_BYTES 
svn path=/trunk/; revision=29778
 2009-09-07 18:53:17 +00:00
Kovarththanan Rajaratnam
1ce02f035d Add progress bar while constructing columns (which is time consuming) 
svn path=/trunk/; revision=29777
 2009-09-07 17:45:37 +00:00
Kovarththanan Rajaratnam
ff7fda0df5 Track how many const strings we're storing. This is guarded by NEW_PACKET_LIST_STATISTICS 
svn path=/trunk/; revision=29775
 2009-09-07 17:09:09 +00:00
Kovarththanan Rajaratnam
72c9662da6 ntroduce some seasonal address name lookup functions which we use when NEW_PACKET_LIST is defined. This change partially reverts some parts of r29768, which didn't seem to work because it assumed that get_addr_name() would always return a seasonal string. This wasn't the case if the adddress type was AT_STRINGZ. 
svn path=/trunk/; revision=29771
 2009-09-07 16:05:37 +00:00
Anders Broman
3abd049a9b Use constant strings for Addresses saves some memory. 
svn path=/trunk/; revision=29768
 2009-09-07 14:03:05 +00:00
Kovarththanan Rajaratnam
4fbc99e411 Auto resize non frame_data based columns 
svn path=/trunk/; revision=29766
 2009-09-07 13:10:59 +00:00
Stig Bjørlykke
5b1d0749de Set sensitivity on resize columns button. 
svn path=/trunk/; revision=29764
 2009-09-07 12:13:28 +00:00
Stig Bjørlykke
1eba4dca43 Enable resize columns button for new packet list. 
svn path=/trunk/; revision=29763
 2009-09-07 12:12:45 +00:00
Kovarththanan Rajaratnam
0a09528611 Add initial implementation of new_packet_list_resize_columns() which just sets the column width according to the column format (work in progress) 
svn path=/trunk/; revision=29762
 2009-09-07 12:04:59 +00:00
Anders Broman
5cc8d3e71d col_fmt not needed. 
svn path=/trunk/; revision=29760
 2009-09-07 11:50:08 +00:00
Kovarththanan Rajaratnam
cd8831c72d Track length of columns strings. We'll need this in order to resize columns quickly 
svn path=/trunk/; revision=29759
 2009-09-07 11:33:38 +00:00
Anders Broman
7473e1e04c Automatically adjust the time column width when time format changes. 
svn path=/trunk/; revision=29758
 2009-09-07 10:03:55 +00:00
Jörg Mayer
99fba22209 The external declaration of airpcap_tb here is not needed 
and creates warnings

svn path=/trunk/; revision=29757
 2009-09-07 07:30:42 +00:00
Kovarththanan Rajaratnam
8c48c6835f Rename address_to_str() to ep_address_to_str() because: 
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
 2009-09-06 14:25:47 +00:00
Kovarththanan Rajaratnam
0e5a101815 Fix target of assignment not really an lvalue error 
svn path=/trunk/; revision=29743
 2009-09-06 12:27:32 +00:00
Kovarththanan Rajaratnam
ecd9ddd845 Tigthen the condition under which we create a protocol create while sorting 
svn path=/trunk/; revision=29740
 2009-09-06 10:41:35 +00:00
Kovarththanan Rajaratnam
8edec9be91 Sort the visible list while traversing the physical row list. This halves the time needed to sort 
svn path=/trunk/; revision=29738
 2009-09-06 09:36:21 +00:00
Kovarththanan Rajaratnam
5c51aacb21 Add NEW_PACKET_LIST guard to color_filters_colorize_packet() 
svn path=/trunk/; revision=29729
 2009-09-06 06:07:53 +00:00
Kovarththanan Rajaratnam
2ab0685d8a Make sure that we can enable/disable color filtering. 
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=11&rev2=12

svn path=/trunk/; revision=29728
 2009-09-06 05:49:00 +00:00
Stig Bjørlykke
07b1329a7c Remove an obsolete gui_time_format setting. 
svn path=/trunk/; revision=29724
 2009-09-05 19:42:43 +00:00
Kovarththanan Rajaratnam
0326f65bf3 Don't copy constant column strings. This reduces memory foot print because COL_PROTOCOL is usually a constant string. This saves us 3-4 bytes for each frame 
svn path=/trunk/; revision=29723
 2009-09-05 19:07:04 +00:00
Stig Bjørlykke
8024460bc0 Move reloading pane geometry to a point where we have the correct 
main_first_pane and main_second_pane.

svn path=/trunk/; revision=29719
 2009-09-05 18:13:48 +00:00
Kovarththanan Rajaratnam
f493e75db6 Dissect-on-the-fly when we have columns that are empty, i.e. columns containing strings (COL_INFO + friends). This allows us to sort on _all_ columns now. 
svn path=/trunk/; revision=29718
 2009-09-05 16:35:05 +00:00
Kovarththanan Rajaratnam
e1eaab161d Move new_packet_list_dissect() to packet_list_store.c. We need to have it there in order to dissect columns on the fly when we have to sort 
svn path=/trunk/; revision=29717
 2009-09-05 15:46:47 +00:00
Kovarththanan Rajaratnam
583d41904c Inline cache_columns() 
svn path=/trunk/; revision=29716
 2009-09-05 15:30:34 +00:00
Kovarththanan Rajaratnam
4aa6c8baef Remove dead code. We dont construct columns while reading the file. We do that when we have to display the frame 
svn path=/trunk/; revision=29715
 2009-09-05 15:25:53 +00:00
Stig Bjørlykke
5a7d9922c1 Fetch old column width values if we have not initialized the packet list, 
so we don't write zero width values if closing before loading a capture.

svn path=/trunk/; revision=29714
 2009-09-05 14:37:02 +00:00
Kovarththanan Rajaratnam
fb54567dae Restore original condition in packet_list_iter_n_children() 
svn path=/trunk/; revision=29713
 2009-09-05 13:46:17 +00:00
Stig Bjørlykke
45bdd7577b Apply user font when changing profile with new packet list. 
svn path=/trunk/; revision=29712
 2009-09-05 13:30:16 +00:00
Kovarththanan Rajaratnam
fcf25fe42b Get rid of row_data_t 
svn path=/trunk/; revision=29711
 2009-09-05 13:27:34 +00:00
Kovarththanan Rajaratnam
2d5a1323e1 Make sure that we can resort with an active display filter 
svn path=/trunk/; revision=29710
 2009-09-05 13:24:16 +00:00
Kovarththanan Rajaratnam
a71f9bbde3 Sort out some of the confusion r29706 introduced (visible vs. physical rows). We choose the wrong packet in the packet view because we used the physical row instead of the visible. I suspect there a couple more of these lurking. 
svn path=/trunk/; revision=29708
 2009-09-05 12:42:44 +00:00
Kovarththanan Rajaratnam
2db51a0b3e Bail out gracefully on colums we cant sort on yet instead of crashing 
svn path=/trunk/; revision=29707
 2009-09-05 11:58:44 +00:00
Stig Bjørlykke
f91c46757a Make it build without warnings. 
svn path=/trunk/; revision=29706
 2009-09-05 11:15:50 +00:00
Kovarththanan Rajaratnam
95ddec4d07 Get rid off GtkTreeModelFilter because the time to sort becomes unbearable when combined with GtkTreeSortable. This means that we now track which frames are visible in the our own packet list store. To do so, we now distinguish between physical and visible rows. All frames are added as physical rows. Only those that passes the display filter are marked as visible. 
svn path=/trunk/; revision=29705
 2009-09-05 10:36:29 +00:00
Kovarththanan Rajaratnam
314b693828 Rename new_packet_list_reset_dissected to packet_list_reset_dissected 
svn path=/trunk/; revision=29699
 2009-09-04 17:42:03 +00:00
Michael Tüxen
798b1ecdb2 Cleanup whitespaces. 
svn path=/trunk/; revision=29698
 2009-09-04 13:23:51 +00:00
Michael Tüxen
471111ffc6 Fix handling of multiple duplicate TSNs. 
svn path=/trunk/; revision=29697
 2009-09-04 13:10:59 +00:00
Michael Tüxen
648bdb564b Fix compilation. 
svn path=/trunk/; revision=29696
 2009-09-04 12:52:28 +00:00
Michael Tüxen
56366dcb59 From Irene Ruengeler: Show duplicate TSNs in SACKs. 
svn path=/trunk/; revision=29695
 2009-09-04 12:42:22 +00:00
Kovarththanan Rajaratnam
4930802fa1 Only store the last column as G_TYPE_POINTER. Hopefully this will soon make us able to sort again 
svn path=/trunk/; revision=29690
 2009-09-03 17:56:57 +00:00
Kovarththanan Rajaratnam
5a8df08491 Add packet_list_visible_record() to avoid poking PacketListRecord in new_packet_list.c 
svn path=/trunk/; revision=29689
 2009-09-03 17:39:42 +00:00
Kovarththanan Rajaratnam
8a33ec23bb Allocate and use an extra column at the end of the column list to indicate the 'magic' column which contains the _entire_ PacketListRecord 
svn path=/trunk/; revision=29688
 2009-09-03 17:00:17 +00:00
Kovarththanan Rajaratnam
bd69669e1d Make sure that we stop auto scroll if we start scrolling manually. 
Caveat: we jump to first frame when auto scroll is stopped

svn path=/trunk/; revision=29685
 2009-09-03 14:32:11 +00:00
Stig Bjørlykke
7b5da30392 Read column widths from recent file also for new packet list. 
svn path=/trunk/; revision=29684
 2009-09-03 11:37:12 +00:00
Stig Bjørlykke
7d2c55dc47 Adjusted int/uint check and fixed a comment in right justify check. 
svn path=/trunk/; revision=29683
 2009-09-03 10:50:30 +00:00
Stig Bjørlykke
b462cace92 Right justify "Packet length", "Cumulative bytes" and custom columns 
displaying numerical values.

svn path=/trunk/; revision=29682
 2009-09-03 10:40:06 +00:00
Anders Broman
865d14c43f Right align COL_NUMBER. 
svn path=/trunk/; revision=29681
 2009-09-03 05:35:21 +00:00
Anders Broman
7b916257bd Don't set the minimum column width to the computed or stored value, 
use a fixed minimum value and use the other as the size used to display the column.

svn path=/trunk/; revision=29680
 2009-09-03 05:03:57 +00:00
Stig Bjørlykke
36e4c964fa Also deactivate and activate menu for recent.gui_time_precision. 
svn path=/trunk/; revision=29679
 2009-09-02 21:04:41 +00:00
Kovarththanan Rajaratnam
b0d1651885 Make sure that we deactivate before activating in menu_recent_read_finished(). This fixes a crash due to recent.gui_time_format being invalid (-1). Please review whether this is a correct fix 
svn path=/trunk/; revision=29678
 2009-09-02 19:56:39 +00:00
Kovarththanan Rajaratnam
47b766a998 Only try and select the last row if not already selected. This fix doesn't seem to work. Any suggestions? 
svn path=/trunk/; revision=29677
 2009-09-02 19:31:56 +00:00
Michael Tüxen
283a4997ba Mark unused parameter as such. 
svn path=/trunk/; revision=29675
 2009-09-02 19:15:02 +00:00
Anders Broman
d1b6cefef4 Use new_packet_list_colorize_packets() where cf_colorize_packets(); 
is used.

svn path=/trunk/; revision=29674
 2009-09-02 18:18:57 +00:00
Anders Broman
d96beaaecb Trying to fix: 
packets without color are randomly colorized.

svn path=/trunk/; revision=29673
 2009-09-02 17:59:56 +00:00
Anders Broman
012a6c12e4 Adding new color rules should work now. 
svn path=/trunk/; revision=29672
 2009-09-02 17:52:14 +00:00
Anders Broman
cdd2959aa5 Adding new color rules should work now. 
svn path=/trunk/; revision=29671
 2009-09-02 17:51:48 +00:00
Kovarththanan Rajaratnam
bc36849a9e Add seperate new_packet_list_moveto_end() which scrolls to the end _without_ selecting the last packet. 
svn path=/trunk/; revision=29670
 2009-09-02 17:29:52 +00:00
Kovarththanan Rajaratnam
6149d4be35 Make sure that we select the last row if autoscroll is enabled. The scrolling is still very jumpy. It seems that we always select the first packet before moving to the end. 
svn path=/trunk/; revision=29668
 2009-09-02 17:15:20 +00:00
Martin Mathieson
2ef4429761 Add Semi-Persistent Scheduling (SPS) RNTI. 
svn path=/trunk/; revision=29667
 2009-09-02 16:39:39 +00:00
Anders Broman
1858d86612 Prepare abillity to add color filters with new packet list. 
(Packets not recolored yet).

svn path=/trunk/; revision=29664
 2009-09-02 15:07:03 +00:00
Anders Broman
8035954712 Didier Gautheron: 
Expert info clean up.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3971

svn path=/trunk/; revision=29663
 2009-09-02 05:48:38 +00:00
Anders Broman
c5c569597b In new_packet_list_append() all we need is in fdata. 
svn path=/trunk/; revision=29657
 2009-09-01 18:29:11 +00:00
Kovarththanan Rajaratnam
17f010119a From Jakub Zawadzki via. Bug 3330: 
* Fix memleak (df->deprecated in dfilter_free())
* Free protocol hash tables on cleanup.
* Free protocols list on cleanup.
* Free memory allocated by fgetline() in parse_services_file()

From me:

* proto.c: set gmc_hfinfo to NULL after free
* proto.c: switch order of g_free() and g_list_remove() in proto_cleanup()

svn path=/trunk/; revision=29656
 2009-09-01 18:16:55 +00:00
Kovarththanan Rajaratnam
8cba530c81 From Richard Brodie via. Bug 3913: 
Free ptr array allocated through proto_find_finfo()

svn path=/trunk/; revision=29654
 2009-09-01 17:09:36 +00:00
Kovarththanan Rajaratnam
5b3f74f9d5 We no longer store the column text in our record, so don't ever dereference the record column text pointer. In fact, remove it completely. This could cause a crash. 
While there, throw in a few g_assert()'s.

svn path=/trunk/; revision=29653
 2009-09-01 16:00:56 +00:00
Kovarththanan Rajaratnam
b429655b7f Plug memleak in new_packet_list_store_clear(). Make sure that we free the pointer array segment 
svn path=/trunk/; revision=29652
 2009-09-01 15:54:53 +00:00
Michael Tüxen
db86fb6684 Out with debug output... 
svn path=/trunk/; revision=29650
 2009-09-01 10:29:17 +00:00
Michael Tüxen
66e738ede6 From Irene Ruengeler: Get rid of legacy gtk code... 
svn path=/trunk/; revision=29649
 2009-09-01 10:12:27 +00:00
Anders Broman
3d1e65e2a0 Typo 
svn path=/trunk/; revision=29647
 2009-09-01 07:29:16 +00:00
Anders Broman
b787bbb334 Don't bother with a progress dialog for small Hex windows. 
svn path=/trunk/; revision=29646
 2009-09-01 05:19:24 +00:00
Anders Broman
a871f30434 Connect F7 and F8 for new_packet_list. 
svn path=/trunk/; revision=29642
 2009-08-31 19:31:04 +00:00
Kovarththanan Rajaratnam
418699b85d Add utf_8to16_snprintf() which creates a UTF16 string according to the given format string. The format string + arguments are expected to be in UTF-8 format. This change effectively removes the only place where we use PRIu64. 
svn path=/trunk/; revision=29635
 2009-08-31 18:16:16 +00:00
Bill Meier
439486505f Fix potential crash due to NULL dereference. 
(Found by clang scan-build)

svn path=/trunk/; revision=29619
 2009-08-29 17:00:22 +00:00
Anders Broman
2cd2eecd0a Compute the loading time and show it in the main status bar. 
(Modified code from Didier Gautheron).

svn path=/trunk/; revision=29592
 2009-08-28 05:19:52 +00:00
Stig Bjørlykke
9c1f832cb4 Remove the three dots in the menu item. 
svn path=/trunk/; revision=29584
 2009-08-27 11:58:03 +00:00
Anders Broman
beb57e259b make the columns sortable. 
svn path=/trunk/; revision=29583
 2009-08-27 06:57:53 +00:00
Anders Broman
0267ffb01c Don't copy const strings, store the pointer in the list store instead, 
saves memory.

svn path=/trunk/; revision=29582
 2009-08-27 05:34:06 +00:00
Bill Meier
db04e3941f Add #include <stdio.h> 
svn path=/trunk/; revision=29581
 2009-08-27 05:17:40 +00:00
Bill Meier
fb37e926f6 Add #include <stdio.h> 
svn path=/trunk/; revision=29579
 2009-08-27 05:04:05 +00:00
Bill Meier
a15bb4beb9 Add #include <stdio.h> in a few more places .... 
svn path=/trunk/; revision=29578
 2009-08-27 04:47:28 +00:00
Bill Meier
1bc9f19f05 Add #include <stdio.h> in a few more places for Solaris. 
svn path=/trunk/; revision=29577
 2009-08-27 03:54:57 +00:00
Bill Meier
1826a02933 Add #include <stdio.h> in a few places for Solaris 
svn path=/trunk/; revision=29576
 2009-08-27 02:53:13 +00:00
Bill Meier
fd7021476f Add #include <stdio.h> to print.h; Undo the previous change to about_dlg.c 
svn path=/trunk/; revision=29575
 2009-08-26 23:24:22 +00:00
Bill Meier
228bc22aa9 Keep Solaris buildbot happy .... 
svn path=/trunk/; revision=29573
 2009-08-26 22:45:07 +00:00
Bill Meier
94f28dd8f9 (FWIW) One step towards including stdio.h & stdlib.h only when req'd. 
svn path=/trunk/; revision=29568
 2009-08-26 19:27:49 +00:00
Anders Broman
5e4e5755a8 From Didier Gautheron: 
expert info clean up,
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3948

svn path=/trunk/; revision=29566
 2009-08-26 17:26:26 +00:00
Bill Meier
cd107a40f2 Fix some indentation 
svn path=/trunk/; revision=29563
 2009-08-26 13:58:17 +00:00
Anders Broman
3c399bf8bb Make it possible to close and reactivate the window. 
svn path=/trunk/; revision=29557
 2009-08-26 04:37:08 +00:00
Anders Broman
2dd60e1b66 Custom columnfication: 
* Deprecate COL_BSSGP_TLLI (GPRS BSSGP IE TLLI). Use bssgp.tlli

svn path=/trunk/; revision=29546
 2009-08-25 05:42:14 +00:00
Guy Harris
9b62cfb7f1 Fix another typo. 
svn path=/trunk/; revision=29545
 2009-08-25 01:01:55 +00:00
Guy Harris
559dd27964 Fix typo. 
svn path=/trunk/; revision=29544
 2009-08-24 21:38:57 +00:00
Anders Broman
112dda41fa From Didier Gautheron: 
Speed up expert info composite.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3935

svn path=/trunk/; revision=29542
 2009-08-24 20:33:49 +00:00
Anders Broman
e5822b1874 Use our own version of gdk_color_to_string if GTK < 2.12 
svn path=/trunk/; revision=29541
 2009-08-24 18:45:01 +00:00
Guy Harris
04544e1213 We no longer need the "ascending arrow" and "descending arrow" images 
for clists, as we're not using a clist.

Clean up white space, and use C89 comments rather than C99/C++ comments.

svn path=/trunk/; revision=29540
 2009-08-24 18:20:20 +00:00
Anders Broman
efba5a7678 Use list_store isf deprecated clist. 
Try to optimize expert_comp_table.

svn path=/trunk/; revision=29539
 2009-08-24 16:11:00 +00:00
Bill Meier
a8e3b5d758 Rework code slightly to prevent a GCC 'breaking strict-aliasing rules' warning 
svn path=/trunk/; revision=29537
 2009-08-24 14:30:55 +00:00
Kovarththanan Rajaratnam
60a30e223e From Didier gautheron via bug 3929: 
* Expert Info / Expert Info Composite requires a full protocol tree.
* Delay tree NULL pointer check in bootp dissector

svn path=/trunk/; revision=29530
 2009-08-23 18:32:29 +00:00
Kovarththanan Rajaratnam
7c1d96d831 From Didier gautheron via bug 3929: 
* Don't use g_string_chunk_clear(). It is only defined if GLib >= 2.14

From me:

* Whitespace fixes

svn path=/trunk/; revision=29529
 2009-08-23 18:13:03 +00:00
Kovarththanan Rajaratnam
23d4eba3b1 Custom columnfication: 
* Deprecate COL_DELTA_CONV_TIME (Delta time (conversation)). Use tcp.time_delta

svn path=/trunk/; revision=29524
 2009-08-23 12:30:48 +00:00
Kovarththanan Rajaratnam
b9cbd15469 Custom columnfication: 
* Deprecate COL_REL_CONV_TIME (Relative time (conversation)). Use tcp.time_relative

svn path=/trunk/; revision=29523
 2009-08-23 12:24:14 +00:00
Kovarththanan Rajaratnam
55cf35e3a0 Custom columnfication: 
* Deprecate COL_FR_DLCI (Frame Relay DLCI). Use fr.dlci

svn path=/trunk/; revision=29522
 2009-08-23 12:16:10 +00:00
Kovarththanan Rajaratnam
51ca1739ae Custom columfication: 
* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield

svn path=/trunk/; revision=29518
 2009-08-23 11:12:12 +00:00
Kovarththanan Rajaratnam
00670c55c6 Custom columfication: 
* Deprecate COL_HPUX_DEVID (HP-UX Device ID). Use nettl.devid

svn path=/trunk/; revision=29517
 2009-08-23 10:25:51 +00:00
Kovarththanan Rajaratnam
205129d25c Custom columfication: 
* Deprecate COL_HPUX_SUBSYS (HP-UX Nettl Subsystem). Use nettl.subsys

svn path=/trunk/; revision=29516
 2009-08-23 10:20:42 +00:00
Kovarththanan Rajaratnam
56369978ae Custom columfication: 
* Deprecate COL_CIRCUIT_ID (Circuit ID). Use iax2.call

svn path=/trunk/; revision=29515
 2009-08-23 09:52:57 +00:00
Kovarththanan Rajaratnam
6b89de8393 Custom columfication: 
* Deprecate COL_COS_VALUE (L2 COS Value (802.1p)). Use vlan.priority

svn path=/trunk/; revision=29513
 2009-08-23 09:07:54 +00:00
Jörg Mayer
dfac9e4091 Get rid of a bunch of "warning: redundant redeclaration of" messages. 
In that process, include the contents of packet-fmp_notify.h directly
in packet-fmp_notify.c - it wasn't used anywhere else.

svn path=/trunk/; revision=29512
 2009-08-23 06:57:16 +00:00
Anders Broman
3c86b750e5 expert_comp_table.c: Minor cleanup 
expert_dlg.c change GtkOptionMenu to GtkComboBox.

svn path=/trunk/; revision=29504
 2009-08-22 16:17:42 +00:00
Michael Tüxen
cc11620041 From Irene Ruengeler: Fix two bugs regarding plotted TSNs reported by 
Christian Constantin.

svn path=/trunk/; revision=29498
 2009-08-21 20:10:51 +00:00
Kovarththanan Rajaratnam
27f7d88c84 Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere. 
svn path=/trunk/; revision=29490
 2009-08-21 11:03:30 +00:00
Anders Broman
1108352f00 Use col_text in frame data. 
- colum-utils needs more work, based on
 Didier Gautherons optimizations patch http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=29489
 2009-08-21 10:12:47 +00:00
Martin Mathieson
70284d6cc4 Trivial formatting changes 
svn path=/trunk/; revision=29484
 2009-08-20 13:16:34 +00:00
Anders Broman
a599db08d8 Destroy window with parent, update label when showing window. 
svn path=/trunk/; revision=29481
 2009-08-19 19:20:45 +00:00
Anders Broman
31132240f9 Make it possible to run checkapi with "deprecated-gtk-todo". 
svn path=/trunk/; revision=29479
 2009-08-19 18:39:30 +00:00
Anders Broman
7ec476b88a From Didier Gautheron: 
Part 2
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize expert info.
Slightly changed by me.

svn path=/trunk/; revision=29478
 2009-08-19 18:37:13 +00:00
Anders Broman
2c87da6c66 From Didier Gautheron: 
Part 1
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize expert info.
Slightly changed by me.

svn path=/trunk/; revision=29477
 2009-08-19 18:36:36 +00:00
Anders Broman
bbaf419559 Fix a memmory leak. 
svn path=/trunk/; revision=29470
 2009-08-19 06:04:30 +00:00
Anders Broman
a47a4a5242 Add new_packet_list_recent_write_all(). 
svn path=/trunk/; revision=29469
 2009-08-18 23:00:42 +00:00
Jaap Keuter
e2c8640c8d Properly handle closing/destruction of RTP player window. 
svn path=/trunk/; revision=29468
 2009-08-18 17:36:30 +00:00
Anders Broman
3208870317 Make copy summary work for new_packet_list. 
XXX The enum in .h file does not seem to work???

svn path=/trunk/; revision=29467
 2009-08-18 14:40:51 +00:00
Jaap Keuter
201746a1a1 Change window_new() to dlg_window_new() and destroy the window with the top level window. 
svn path=/trunk/; revision=29457
 2009-08-17 19:10:19 +00:00
Anders Broman
a1772b0197 Remove #if 0 
svn path=/trunk/; revision=29455
 2009-08-17 15:13:58 +00:00
Anders Broman
a1a129abb5 Prepare to store column data from pinfo. 
svn path=/trunk/; revision=29454
 2009-08-17 15:05:43 +00:00
Kovarththanan Rajaratnam
5b88477401 Add missing call to packets_bar_update() after thaw'ing 
svn path=/trunk/; revision=29450
 2009-08-16 15:33:05 +00:00
Kovarththanan Rajaratnam
c28b654f20 Switch over to using GPtrArray instead of manually g_renew'ing. This switch has some benefits: 
1) We don't have to manually resize
2) GPtrArray uses a sligtly more efficient allocation scheme. It increases the size of the array exponentially which reduces the amount of memcpy's we have to do when we resize the array

svn path=/trunk/; revision=29439
 2009-08-16 04:08:00 +00:00
Stephen Fisher
8b00ed7674 Mark function paramter as unused with _U_ to please gcc. 
svn path=/trunk/; revision=29438
 2009-08-16 02:35:44 +00:00
Anders Broman
408b658647 Try to please build bot 
svn path=/trunk/; revision=29437
 2009-08-15 21:59:03 +00:00
Anders Broman
23dc20f6bf Prepare for storing column data in packet list store. 
svn path=/trunk/; revision=29436
 2009-08-15 21:12:56 +00:00
Kovarththanan Rajaratnam
3beae5944f Micro optimize by storing PACKET_LIST(tree_model) into a local variable and using that instead of computing PACKET_LIST(tree_model) each time. 
svn path=/trunk/; revision=29426
 2009-08-15 05:26:02 +00:00
Kovarththanan Rajaratnam
68e07573bf Avoid superfluous g_strdup() 
svn path=/trunk/; revision=29425
 2009-08-15 05:06:27 +00:00
Kovarththanan Rajaratnam
efa7710fdf Enable 'Mark Packet' in the Edit menu 
svn path=/trunk/; revision=29424
 2009-08-15 04:24:43 +00:00
Kovarththanan Rajaratnam
6b556d4039 Add support for mark/unmark all frames in our new packet list 
svn path=/trunk/; revision=29423
 2009-08-15 04:19:45 +00:00
Kovarththanan Rajaratnam
e15fef4355 Find next/previous mark is also supported so don't exclude it 
svn path=/trunk/; revision=29422
 2009-08-15 04:05:04 +00:00
Kovarththanan Rajaratnam
2a7add22c2 Don't exclude functionality we already support 
svn path=/trunk/; revision=29421
 2009-08-15 03:57:14 +00:00
Kovarththanan Rajaratnam
af00c3e6da Make 'Apply as filter'/'Prepare filter' work for new packet list. 
svn path=/trunk/; revision=29419
 2009-08-14 19:35:01 +00:00
Kovarththanan Rajaratnam
4d5d306372 Remove the hacky row_from_iter() function and use new_packet_list_get_record() instead. Alas, new_packet_list_get_record() is also somewhat hacky in its nature, but hey at least we're using one less hacky thing. 
svn path=/trunk/; revision=29418
 2009-08-14 18:59:15 +00:00
Kovarththanan Rajaratnam
b266cb731e Make mark/unmark frame work with the new filter model 
svn path=/trunk/; revision=29417
 2009-08-14 18:49:48 +00:00
Kovarththanan Rajaratnam
b43f8f5e5a Remove unused functions/prototypes 
svn path=/trunk/; revision=29416
 2009-08-14 18:32:44 +00:00
Kovarththanan Rajaratnam
e9004b22b1 New packet list: right clicking on a row now selects the given row. 
svn path=/trunk/; revision=29415
 2009-08-14 18:29:32 +00:00
Kovarththanan Rajaratnam
0e710239dc Make first/last frame work again with the new filter model. 
svn path=/trunk/; revision=29414
 2009-08-14 15:56:23 +00:00
Kovarththanan Rajaratnam
2c07d7ad80 Make next/previous frame work again with the new filter model. 
svn path=/trunk/; revision=29413
 2009-08-14 15:44:57 +00:00
Kovarththanan Rajaratnam
9efecb181a Don't attach our original packet list model in new_packet_list_thaw(). It's pointless because we override it in filter_function(). 
svn path=/trunk/; revision=29411
 2009-08-14 13:33:17 +00:00
Anders Broman
df97e60d27 Start to implement display filtering. 
svn path=/trunk/; revision=29407
 2009-08-13 21:46:00 +00:00
Anders Broman
96907a7180 Get the pointer to the packet list record and use the data directly. 
svn path=/trunk/; revision=29406
 2009-08-13 21:36:01 +00:00