Commit Graph

40420 Commits

Author SHA1 Message Date
Guy Harris c0cdd900fc Add a pcoreytohll() macro to extract "Corey-endian" 64-bit quantities,
and use it.

Fix some comments.

svn path=/trunk/; revision=42269
2012-04-26 16:27:03 +00:00
Guy Harris 0819326e21 Fix presumed typo (zero-origin bit 5 is 0x0020, not 0x0002).
svn path=/trunk/; revision=42268
2012-04-26 16:25:14 +00:00
Anders Broman 0820e375b0 Prepare to use value_string or range_string.
svn path=/trunk/; revision=42267
2012-04-26 16:11:34 +00:00
Bill Meier f0c3ee5c4a Whitespace cleanup: Indentation, trailing, ...
svn path=/trunk/; revision=42266
2012-04-26 16:05:05 +00:00
pascal 81c1371d5d From Evan Huus:
Add missing break
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7201

svn path=/trunk/; revision=42265
2012-04-26 15:44:01 +00:00
Anders Broman 6b29debe58 From Evan Huus:
Unused structure in packet-btrfcomm.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7200

svn path=/trunk/; revision=42264
2012-04-26 15:39:52 +00:00
Jakub Zawadzki 9a0ab7831d Correct value for Baudot50
From H.248.2: Gateway control protocol: Facsimile, text conversation and call discrimination packages (page 23)
[URL: http://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-H.248.2-200501-I!!PDF-E&type=items]

svn path=/trunk/; revision=42263
2012-04-26 15:35:38 +00:00
Jakub Zawadzki e6f2751cdd Add support for checking conflicting entries in value_string_ext.
svn path=/trunk/; revision=42262
2012-04-26 15:33:46 +00:00
Anders Broman 47fdd93c3c Restore Accelerators for "Expand Subtree", "Expand All" and "Collapse All".
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7197

svn path=/trunk/; revision=42261
2012-04-26 15:17:01 +00:00
Jakub Zawadzki e2c680b245 Fix some "conflicting" value_string warnings.
copy & paste errors, not 0-terminated value_string arrays, etc.

svn path=/trunk/; revision=42260
2012-04-26 14:41:37 +00:00
Anders Broman 2cc15fd9c6 Fully dissect more IEs
svn path=/trunk/; revision=42259
2012-04-26 13:23:16 +00:00
Anders Broman 6819789c54 From Bodo Petermann:
Megaco parser problem with LF in header.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7198

svn path=/trunk/; revision=42258
2012-04-26 13:22:40 +00:00
pascal 0607e2c0bd From vaicebine via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7199 :
wrong value displayed for OAMPDU event notification "Errored Frame Window" field

svn path=/trunk/; revision=42257
2012-04-26 13:20:02 +00:00
Guy Harris a3ce72529c Use the pletohXX macros when fetching little-endian values.
svn path=/trunk/; revision=42256
2012-04-26 08:57:33 +00:00
Guy Harris c7575ff095 Put the pseudo-header information for Veriwave packets into the buffer
in little-endian byte order, as that's what the dissector expects.  Add
a pletohl() macro for that purpose.

Fix comments (the Veriwave code is *not* writing data to a file!) and
clean up indentation.

svn path=/trunk/; revision=42255
2012-04-26 08:45:48 +00:00
Anders Broman 7486872523 Refcount edt.s as we may have atleast two "active" edt:s in certain
circumstances see bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5284

patch by Evan Huus

svn path=/trunk/; revision=42254
2012-04-26 08:41:47 +00:00
Guy Harris 3980d56370 Fix indentation.
svn path=/trunk/; revision=42253
2012-04-26 07:44:28 +00:00
Guy Harris d4d080e1a1 Use pntohs(), pntoh24(), and pntohl() to fetch big-endian data from the
headers.

Fix some indentation.

svn path=/trunk/; revision=42252
2012-04-26 05:07:53 +00:00
Guy Harris 1e6eaee16c Global variables considered harmful. Move all the per-capture-file
global variables into a structure that's attached to the wtap_t as
private data, and make all the per-*packet* global variables local
variables.

svn path=/trunk/; revision=42251
2012-04-26 04:26:03 +00:00
Guy Harris 28175cbf9a Put pcapng_open() right after libpcap_open(); pcap and pcap-ng are our
native file formats, so try them first.

Move eyesdn_open() to the section for open routines for file formats
that have a magic number - EyeSDN traces all start with "EyeSDN".

svn path=/trunk/; revision=42250
2012-04-26 03:21:29 +00:00
Guy Harris 51633791a9 If you get an I/O error when looking for the FPGA version, return -1, so
we know we had a real problem with the file.  If we just get a short
read, return 0, as it means the file is probably not a VWR file.

If we get an invalid message length when reading packets (rather than
when looking for the FPGA version), return WTAP_ERR_BAD_FILE and an
"Invalid message record length" indication, not a generic fallback
"can't read the file" error.

For file_tell() errors, fetch the error code with file_error().

For file_seek() errors, use the error file_seek returned.

svn path=/trunk/; revision=42249
2012-04-26 03:06:35 +00:00
Martin Mathieson e74d2fd9db Return 0 if doesn't match signature of vwr files.
Pointed out by Martin Kaiser in bug 7196.

svn path=/trunk/; revision=42248
2012-04-25 22:54:45 +00:00
pascal e94974887c Convert spaces to tabs
svn path=/trunk/; revision=42247
2012-04-25 21:37:10 +00:00
Michael Tüxen e08a45d705 Set also the pcap buffer, if the default of 1 MB is used. This bug was
reported by Guy.

svn path=/trunk/; revision=42246
2012-04-25 21:19:31 +00:00
Michael Tüxen 3c866b04d0 Report the packets captured and the packets dropped (either by libpcap or by dumpcap).
svn path=/trunk/; revision=42245
2012-04-25 21:09:33 +00:00
pascal f0a6f372ac From Niels de Vos:
dissect AUTH_RSA as Gluster AUTH-flavor
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7190

svn path=/trunk/; revision=42244
2012-04-25 21:02:48 +00:00
pascal 7a15d6be87 From Niels de Vos:
Rename AUTH_DH to AUTH_RSA as specified in RFC 5531

svn path=/trunk/; revision=42243
2012-04-25 20:59:35 +00:00
Michael Tüxen 8ea1984ddc Allow writing ISB with given recv/drop counters.
No functional change by this commit.

svn path=/trunk/; revision=42242
2012-04-25 20:50:38 +00:00
pascal 1cd8ca08a6 From Evan Huus:
Fix Integer32 length field detection
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7192

svn path=/trunk/; revision=42241
2012-04-25 20:20:23 +00:00
pascal 2787ebf988 Upgrade MAC LTE dissector to Release 10 (V10.5.0)
svn path=/trunk/; revision=42240
2012-04-25 20:02:12 +00:00
Michael Tüxen 4088083ae6 Fix typo.
svn path=/trunk/; revision=42239
2012-04-25 19:21:25 +00:00
Michael Tüxen 27a21cd04d Fix copy and paste error.
Reported by Evan Huus. This should fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7194

svn path=/trunk/; revision=42238
2012-04-25 19:17:10 +00:00
Michael Tüxen b6ed0f345a Fix compilation. While there, remove some trailing whitespaces.
svn path=/trunk/; revision=42237
2012-04-25 18:38:55 +00:00
Michael Tüxen d2526de5f8 Fix the packet counters.
This fixes the inconsistencies reported on the command line by dumpcap
as indicated by
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7191

svn path=/trunk/; revision=42236
2012-04-25 17:43:44 +00:00
Michael Tüxen 0fe7859ca4 Fix locking problem.
svn path=/trunk/; revision=42235
2012-04-25 16:05:29 +00:00
Anders Broman 25c3a2b236 Get rid of a few more of the explicitly defined ett:s
svn path=/trunk/; revision=42234
2012-04-25 15:33:06 +00:00
Anders Broman 19a53f1ee2 use in_files->filename
svn path=/trunk/; revision=42233
2012-04-25 14:33:06 +00:00
Anders Broman f696fb7bde Add some info in SHB if writing a pcap-ng file.
svn path=/trunk/; revision=42232
2012-04-25 14:01:15 +00:00
Anders Broman 71780ae952 Add wtap_dump_fdopen_ng
svn path=/trunk/; revision=42231
2012-04-25 14:00:23 +00:00
Anders Broman 102991bf0f Handle wtap_dump_fdopen() as wtap_dump_open() eg call
wtap_dump_fdopen_ng() and add a dummy IDB to be able to write pcapng files.
Solves https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6969
mergecap: Can't open or create <FILENAME>: Internal error.

We might want to add a SHB comment from mergecap giving the merged filenames or something like that, Merging of pcapng files
is a different issue, idealy we should probably start using several SHB:s in that case.

svn path=/trunk/; revision=42230
2012-04-25 12:33:23 +00:00
Anders Broman ee3910f6ce Add packet-gtpv2.h
svn path=/trunk/; revision=42229
2012-04-25 10:15:07 +00:00
Anders Broman 323585c2e3 From David Wei:
Significantly improve M3AP dissection and MBMS related GTPv2 dissection.

svn path=/trunk/; revision=42228
2012-04-25 08:39:49 +00:00
Martin Mathieson 56add1934d Remove some unnecessary includes and fix some indentation.
svn path=/trunk/; revision=42227
2012-04-25 00:28:19 +00:00
Bill Meier 1ec161eab8 Minor cleanup: whitespace, indentation, long-lines, style, typos, etc;
Also: remove unneeded #include <stdlib.h> in 2 cases.

svn path=/trunk/; revision=42226
2012-04-24 18:27:06 +00:00
Bill Meier 53738a1695 Remove svn:keywords property; Change mime-type to vnd.tcpdump.pcap
svn path=/trunk/; revision=42225
2012-04-24 17:30:45 +00:00
Bill Meier e8f79f608a Remove svn:keywords property
svn path=/trunk/; revision=42224
2012-04-24 15:00:07 +00:00
Bill Meier a2b096141a Add svn:eol-style property; reformat a few long lines.
svn path=/trunk/; revision=42223
2012-04-24 14:55:59 +00:00
Anders Broman 01abbdf6d2 Add missing ";"
svn path=/trunk/; revision=42222
2012-04-24 14:48:46 +00:00
Bill Meier 14601c633b Remove svn:executable property; Minor whitespace changes.
svn path=/trunk/; revision=42221
2012-04-24 14:37:18 +00:00
Anders Broman 949079e2b4 From David Wei:
Bug fixes and improvements to Sm (GTPv2) and SGmb (DIAMETER) dissectors.

svn path=/trunk/; revision=42220
2012-04-24 12:33:00 +00:00