smalltalk
/
osmo-st-smpp
Archived
1
0
Fork 0

misc: Add proper categories to all classes

In preparation to the pharo port add proper categories.
This commit is contained in:
Holger Hans Peter Freyther 2014-07-15 13:45:25 +02:00
parent 6502e32773
commit 47cbd9c5b1
34 changed files with 63 additions and 3 deletions

View File

@ -17,6 +17,8 @@
" "
SMPPBindTransmitterBody subclass: SMPPBindTransceiver [ SMPPBindTransmitterBody subclass: SMPPBindTransceiver [
<category: 'SMPP-Codec'>
SMPPBindTransceiver class >> messageType [ SMPPBindTransceiver class >> messageType [
^self bindTransceiver ^self bindTransceiver
] ]

View File

@ -18,6 +18,7 @@
SMPPBodyBase subclass: SMPPBindTransmitterBody [ SMPPBodyBase subclass: SMPPBindTransmitterBody [
| system_id password system_type version addr_ton addr_npi addr_range | | system_id password system_type version addr_ton addr_npi addr_range |
<category: 'SMPP-Codec'>
SMPPBindTransmitterBody class >> messageType [ SMPPBindTransmitterBody class >> messageType [
^self bindTransmitter ^self bindTransmitter

View File

@ -17,6 +17,7 @@
" "
Osmo.TLVParserBase subclass: SMPPBodyBase [ Osmo.TLVParserBase subclass: SMPPBodyBase [
<category: 'SMPP-Codec'>
<comment: 'I represent a specific "BODY" of a Payload. My <comment: 'I represent a specific "BODY" of a Payload. My
sub-classes will provide the specific bodies.'> sub-classes will provide the specific bodies.'>

View File

@ -17,6 +17,7 @@
" "
SMPPBodyBase subclass: SMPPEnquireLink [ SMPPBodyBase subclass: SMPPEnquireLink [
<category: 'SMPP-Codec'>
SMPPEnquireLink class >> messageType [ SMPPEnquireLink class >> messageType [
^self enquireLink ^self enquireLink

View File

@ -17,6 +17,8 @@
" "
SMPPBodyBase subclass: SMPPGenericNack [ SMPPBodyBase subclass: SMPPGenericNack [
<category: 'SMPP-Codec'>
SMPPGenericNack class >> messageType [ SMPPGenericNack class >> messageType [
^self genericNack ^self genericNack
] ]

View File

@ -19,6 +19,8 @@
Object subclass: SMPPMessage [ Object subclass: SMPPMessage [
| header body | | header body |
<category: 'SMPP-Codec'>
SMPPMessage class >> readFrom: aStream [ SMPPMessage class >> readFrom: aStream [
| len data stream header body | | len data stream header body |
len := ((aStream next: 4) asByteArray uintAt: 1) swap32. len := ((aStream next: 4) asByteArray uintAt: 1) swap32.

View File

@ -18,7 +18,7 @@
Object subclass: SMPPPDUHeader [ Object subclass: SMPPPDUHeader [
| commandId commandStatus sequenceNumber | | commandId commandStatus sequenceNumber |
<category: 'OsmoSMPP-Codec'> <category: 'SMPP-Codec'>
<comment: 'I represent a SMPPv3.4 SMPP PDU Header. E.g. <comment: 'I represent a SMPPv3.4 SMPP PDU Header. E.g.
3.2 of the SMPPv3.4 specification. The four byte lengths 3.2 of the SMPPv3.4 specification. The four byte lengths
need to be written/read by someone else.'> need to be written/read by someone else.'>

View File

@ -32,6 +32,8 @@ SMPPBodyBase subclass: SMPPSubmitSM [
alert_on_msg_delivery language_indicator its_reply_type alert_on_msg_delivery language_indicator its_reply_type
its_session_info ussd_service_op | its_session_info ussd_service_op |
<category: 'SMPP-Codec'>
SMPPSubmitSM class >> messageType [ SMPPSubmitSM class >> messageType [
^self submitSM ^self submitSM
] ]

View File

@ -17,6 +17,9 @@
" "
SMPPBodyBase subclass: SMPPUnbind [ SMPPBodyBase subclass: SMPPUnbind [
<category: 'SMPP-Codec'>
SMPPUnbind class >> messageType [ SMPPUnbind class >> messageType [
^self unbind ^self unbind
] ]

View File

@ -17,6 +17,8 @@
" "
SMPPOctetString subclass: SMPPAddress [ SMPPOctetString subclass: SMPPAddress [
<category: 'SMPP-Codec'>
<comment: 'I re-present an 5.2.8 attribute. It should be a IPv4 <comment: 'I re-present an 5.2.8 attribute. It should be a IPv4
address. IPv6 is not supported'> address. IPv6 is not supported'>

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPAddressNumberingPlanIndicator [ SMPPInteger subclass: SMPPAddressNumberingPlanIndicator [
<category: 'SMPP-Codec'>
<comment: 'I re-present 5.2.6 of SMPPv3.4'> <comment: 'I re-present 5.2.6 of SMPPv3.4'>
SMPPAddressNumberingPlanIndicator class [ SMPPAddressNumberingPlanIndicator class [

View File

@ -17,6 +17,8 @@
" "
SMPPOctetString subclass: SMPPAddressRange [ SMPPOctetString subclass: SMPPAddressRange [
<category: 'SMPP-Codec'>
<comment: 'I re-present 5.2.7 of SMPPv3.4'> <comment: 'I re-present 5.2.7 of SMPPv3.4'>
SMPPAddressRange class >> tlvDescription [ SMPPAddressRange class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPAddressTypeOfNumber [ SMPPInteger subclass: SMPPAddressTypeOfNumber [
<category: 'SMPP-Codec'>
<comment: 'I re-present 5.2.5 of SMPPv3.4'> <comment: 'I re-present 5.2.5 of SMPPv3.4'>
SMPPAddressTypeOfNumber class [ SMPPAddressTypeOfNumber class [

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPDataCoding [ SMPPInteger subclass: SMPPDataCoding [
<category: 'SMPP-Codec'>
<comment: 'I represent a 5.2.19'> <comment: 'I represent a 5.2.19'>
SMPPDataCoding class >> tlvDescription [ SMPPDataCoding class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPDefaultMessageId [ SMPPInteger subclass: SMPPDefaultMessageId [
<category: 'SMPP-Codec'>
<comment: 'I re-present 5.2.20'> <comment: 'I re-present 5.2.20'>
SMPPDefaultMessageId class >> tlvDescription [ SMPPDefaultMessageId class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPESMClass [ SMPPInteger subclass: SMPPESMClass [
<category: 'SMPP-Codec'>
<comment: 'I re-present a 5.2.12'> <comment: 'I re-present a 5.2.12'>
SMPPESMClass class [ SMPPESMClass class [

View File

@ -17,6 +17,8 @@
" "
Object subclass: SMPPInteger [ Object subclass: SMPPInteger [
<category: 'SMPP-Codec'>
<comment: 'I help with the various kind of numbers'> <comment: 'I help with the various kind of numbers'>
SMPPInteger class >> tlvDescription [ SMPPInteger class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPInterfaceVersion [ SMPPInteger subclass: SMPPInterfaceVersion [
<category: 'SMPP-Codec'>
<comment: 'I re-present 5.2.4 of SMPPv3.4'> <comment: 'I re-present 5.2.4 of SMPPv3.4'>
SMPPInterfaceVersion class >> attrVersion34 [ SMPPInterfaceVersion class >> attrVersion34 [

View File

@ -17,6 +17,8 @@
" "
Object subclass: SMPPOctetString [ Object subclass: SMPPOctetString [
<category: 'SMPP-Codec'>
<comment: 'I represent a variable string as used in SMPP'> <comment: 'I represent a variable string as used in SMPP'>
SMPPOctetString class >> tlvDescription [ SMPPOctetString class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPOctetString subclass: SMPPPassword [ SMPPOctetString subclass: SMPPPassword [
<category: 'SMPP-Codec'>
<comment: 'I represent 5.2.2 of SMPPv3.4'> <comment: 'I represent 5.2.2 of SMPPv3.4'>
SMPPPassword class >> tlvDescription [ SMPPPassword class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPPriorityFlag [ SMPPInteger subclass: SMPPPriorityFlag [
<category: 'SMPP-Codec'>
<comment: 'I re-present 5.2.14 of SMPPv3.4. The range is 0 to 3 but <comment: 'I re-present 5.2.14 of SMPPv3.4. The range is 0 to 3 but
the meaning depends on the type of message.'> the meaning depends on the type of message.'>

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPProtocolId [ SMPPInteger subclass: SMPPProtocolId [
<category: 'SMPP-Codec'>
<comment: 'I re-present a 5.2.13. But it refers to other things'> <comment: 'I re-present a 5.2.13. But it refers to other things'>
SMPPProtocolId class >> tlvDescription [ SMPPProtocolId class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPRegisteredDelivery [ SMPPInteger subclass: SMPPRegisteredDelivery [
<category: 'SMPP-Codec'>
<comment: 'I re-present a 5.2.17'> <comment: 'I re-present a 5.2.17'>
SMPPRegisteredDelivery class >> tlvDescription [ SMPPRegisteredDelivery class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPInteger subclass: SMPPReplaceIfPresentFlag [ SMPPInteger subclass: SMPPReplaceIfPresentFlag [
<category: 'SMPP-Codec'>
<comment: 'I re-present a 5.2.18 flag'> <comment: 'I re-present a 5.2.18 flag'>
SMPPReplaceIfPresentFlag class [ SMPPReplaceIfPresentFlag class [

View File

@ -17,6 +17,8 @@
" "
SMPPOctetString subclass: SMPPScheduleDeliveryTime [ SMPPOctetString subclass: SMPPScheduleDeliveryTime [
<category: 'SMPP-Codec'>
<comment: 'I re-present a 5.2.15 field and can be NULL'> <comment: 'I re-present a 5.2.15 field and can be NULL'>
SMPPScheduleDeliveryTime class >> tlvDescription [ SMPPScheduleDeliveryTime class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPOctetString subclass: SMPPServiceType [ SMPPOctetString subclass: SMPPServiceType [
<category: 'SMPP-Codec'>
<comment: 'I re-present a ServiceType as of 5.2.11'> <comment: 'I re-present a ServiceType as of 5.2.11'>
SMPPServiceType class [ SMPPServiceType class [

View File

@ -17,6 +17,8 @@
" "
Object subclass: SMPPShortMessage [ Object subclass: SMPPShortMessage [
<category: 'SMPP-Codec'>
<comment: 'I represent the sm_length and short_message'> <comment: 'I represent the sm_length and short_message'>
SMPPShortMessage class >> tlvDescription [ SMPPShortMessage class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPOctetString subclass: SMPPSystemId [ SMPPOctetString subclass: SMPPSystemId [
<category: 'SMPP-Codec'>
<comment: 'I re-present 5.2.1 of SMPPv3.4'> <comment: 'I re-present 5.2.1 of SMPPv3.4'>
SMPPSystemId class >> tlvDescription [ SMPPSystemId class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPOctetString subclass: SMPPSystemType [ SMPPOctetString subclass: SMPPSystemType [
<category: 'SMPP-Codec'>
<comment: 'I re-present 5.2.3 of SMPPv3.4'> <comment: 'I re-present 5.2.3 of SMPPv3.4'>
SMPPSystemType class >> tlvDescription [ SMPPSystemType class >> tlvDescription [

View File

@ -17,6 +17,8 @@
" "
SMPPOctetString subclass: SMPPValidityPeriod [ SMPPOctetString subclass: SMPPValidityPeriod [
<category: 'SMPP-Codec'>
<comment: 'I represent a 5.2.16 validity period. I can be <comment: 'I represent a 5.2.16 validity period. I can be
an empty string or contain 16 characters'> an empty string or contain 16 characters'>

View File

@ -18,6 +18,8 @@
Object subclass: SMPPValueHolder [ Object subclass: SMPPValueHolder [
| tag value | | tag value |
<category: 'SMPP-Codec'>
<comment: 'I re-present a general TLV kind of structure'> <comment: 'I re-present a general TLV kind of structure'>
SMPPValueHolder class >> for: aString tag: aTag [ SMPPValueHolder class >> for: aString tag: aTag [

View File

@ -18,12 +18,14 @@
SMPPEnquireLink extend [ SMPPEnquireLink extend [
connectionDispatchOn: aConnection with: aMessage [ connectionDispatchOn: aConnection with: aMessage [
<category: '*SMPP-Connection'>
aConnection respondToEnquire: aMessage aConnection respondToEnquire: aMessage
] ]
] ]
SMPPBindTransceiverResponse extend [ SMPPBindTransceiverResponse extend [
connectionDispatchOn: aConnection with: aMessage [ connectionDispatchOn: aConnection with: aMessage [
<category: '*SMPP-Connection'>
aConnection receviedResponse: aMessage aConnection receviedResponse: aMessage
] ]
] ]

View File

@ -17,7 +17,7 @@
" "
TestCase subclass: SMPPMessageTest [ TestCase subclass: SMPPMessageTest [
<category: 'OsmoSMPP-Test'> <category: 'SMPP-Codec-Test'>
<comment: 'I test reading and writing most of the SMPP header and body'> <comment: 'I test reading and writing most of the SMPP header and body'>
examplePdu [ examplePdu [

View File

@ -17,7 +17,7 @@
" "
TestCase subclass: SMPPPDUHeaderTest [ TestCase subclass: SMPPPDUHeaderTest [
<category: 'OsmoSMPP-Test'> <category: 'SMPP-Codec-Test'>
<comment: 'I test reading and writing most of the SMPP header.'> <comment: 'I test reading and writing most of the SMPP header.'>
testParse [ testParse [