sdr
/
gr-osmosdr
8
1
Fork 2
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Fix compilation of retpitaya and rtl_tcp with MinGW #5

Merged
horizon merged 3 commits from argilo/gr-osmosdr:fix-win-compile into master 2023-12-03 09:08:40 +00:00
Conversation 1 Commits 3 Files Changed 6 +14 -454
argilo commented 2023-12-03 00:52:58 +00:00
Contributor
Copy Link

gr-osmosdr's redpitaya and rtl_tcp drivers fail to build with MinGW because the dependency on ws2_32 is specified in a #pragma comment only understood by MSVC. I have moved it into CMake instead.

Also, I removed rtl_tcp_source_f.cc and rtl_tcp_source_f.h, which were made obsolete in 26f93e4687, and I fixed a compiler warning (redefinition of ENOPROTOOPT).

gr-osmosdr's redpitaya and rtl_tcp drivers fail to build with MinGW because the dependency on ws2_32 is specified in a `#pragma comment` only understood by MSVC. I have moved it into CMake instead. Also, I removed `rtl_tcp_source_f.cc` and `rtl_tcp_source_f.h`, which were made obsolete in 26f93e46874824cd36bd9f05baf3fe3b851aa640, and I fixed a compiler warning (redefinition of `ENOPROTOOPT`).
argilo added 3 commits 2023-12-03 00:52:58 +00:00
argilo commented 2023-12-03 01:57:14 +00:00
Author
Contributor
Copy Link

I tried building with MSVC (in a Conda environment) and these changes work there as well.

I had to apply this patch, since the Red Pitaya driver does not currently compile with MSVC: https://github.com/conda-forge/gnuradio-osmosdr-feedstock/blob/main/recipe/0002-redpitaya-For-Windows-target-Vista-or-newer-for-wins.patch

I tried building with MSVC (in a Conda environment) and these changes work there as well. I had to apply this patch, since the Red Pitaya driver does not currently compile with MSVC: https://github.com/conda-forge/gnuradio-osmosdr-feedstock/blob/main/recipe/0002-redpitaya-For-Windows-target-Vista-or-newer-for-wins.patch
horizon merged commit 73d8982ac0 into master 2023-12-03 09:08:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sdr/gr-osmosdr#5
No description provided.
Delete Branch "argilo/gr-osmosdr:fix-win-compile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?