osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
wireshark/tools
History
Michael Mann 268841f3e0 Combine Decode As and port preferences for tcp.port dissector table. 
This patch introduces new APIs to allow dissectors to have a preference for
a (TCP) port, but the underlying data is actually part of Decode As functionality.
For now the APIs are intentionally separate from the regular APIs that register a
dissector within a dissector table.  It may be possible to eventually combine the
two so that all dissectors that register with a dissector table have an opportunity
to "automatically" have a preference to adjust the "table value" through the
preferences dialog.

The tcp.port dissector table was used as the guinea pig.  This will eventually be
expanded to other dissector tables as well (most notably UDP ports).  Some
dissectors that "shared" a TCP/UDP port preference were also converted. It also
removed the need for some preference callback functions (mostly when the callback
function was the proto_reg_handoff function) so there is cleanup around that.

Dissectors that has a port preference whose default was 0 were switched to using
the dissector_add_for_decode_as_with_preference API rather than dissector_add_uint_with_preference

Also added comments for TCP ports used that aren't IANA registered.

Change-Id: I99604f95d426ad345f4b494598d94178b886eb67
Reviewed-on: https://code.wireshark.org/review/17724
Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-08 02:44:53 +00:00
..
cppcheck
dftestfiles
dftestlib Make the dfilter time tests work regardless of what time zone the tests are 2015-11-10 09:04:48 +00:00
lemon Disable ASAN when building lemon. 2016-10-07 17:54:35 +00:00
npl new_create_dissector_handle -> create_dissector_handle for plugins. 2015-12-11 03:42:52 +00:00
pidl tools/pidl: support HRESULT as return code in wireshark autogenerated dissectors. 2016-08-06 15:34:02 +00:00
tpg Remove Nmake build system 2016-06-15 19:21:57 +00:00
.gitattributes
asn2deb Fix FSF address. 2016-08-05 20:16:51 +00:00
asn2wrs.py asn2wrs: put back parsetab.py file in ASN.1 source folder 2016-08-04 18:54:05 +00:00
checkAPIs.pl checkAPI: move atoi from deprecated to soft-deprecated list. 2016-09-06 12:31:02 +00:00
checkfiltername.pl checkfiltername.pl: Don't print empty line on successful run 2016-01-10 18:43:53 +00:00
checkhf.pl Cleanup and extend the regex for matching expert info entries. 2016-07-10 15:06:20 +00:00
checklicenses.py Documentation with unset license is under project's license (GPL-2+) 2016-08-23 15:02:31 +00:00
colorfilters2js.pl
commit-msg
compare-abis.sh
compress-pngs.sh Recompress PNGs. 2016-06-30 15:41:32 +00:00
convert-proto-tree-new.awk
convert_expert_add_info_format.pl
convert_proto_tree_add_text.pl
debian-setup.sh debian-setup: add customized profiles. 2016-08-08 21:19:23 +00:00
delete_includes.py Remove Nmake build system 2016-06-15 19:21:57 +00:00
dfilter-test.py
extract_asn1_from_spec.pl
fix-encoding-args.pl
fixhf.pl
ftsanity.py Support bitfields for FT_CHAR. 2016-09-19 04:16:39 +00:00
fuzz-test.sh Add an initial "shellcheck" target. 2016-09-26 23:17:02 +00:00
gen-bugnote
generate-bacnet-vendors.py
generate-sysdig-event.py Initial Sysdig syscall (event) support. 2015-11-10 20:59:53 +00:00
generate_authors.pl Fix out-of-tree "gen-authors" target 2016-03-28 22:13:59 +00:00
Get-HardenFlags.ps1 Remove remnants of g_spawn_helper support 2016-07-05 16:11:13 +00:00
git-compare-abis.sh
git-export-release.sh
html2text.py
idl2deb Update FSF address. 2016-08-05 20:25:12 +00:00
idl2wrs
indexcap.py
install_rpms_for_devel.sh When installing RPMs for development, use dnf if the OS has it. 2016-02-23 22:24:41 +00:00
lex.py Ply parser updated to 3.8 from http://www.dabeaz.com/ply/ 2016-08-04 08:20:24 +00:00
licensecheck.pl checklicenses: Remove whitelisted licenses not being used 2016-08-09 02:41:30 +00:00
list_protos_in_cap.sh
macos-setup-brew.sh Add tools for setup macos dev environnement using brew 2016-08-19 02:10:32 +00:00
make-dissector-reg.py Remove Nmake build system 2016-06-15 19:21:57 +00:00
make-manuf make-manuf: Add more sanity checks. 2016-10-02 19:05:46 +00:00
make-pixbuf-csource.pl Make sure our shell, Perl, & Python tools are executable. 2016-03-03 20:11:25 +00:00
make-services.pl
make-services.py
make-sminmpec.pl
make-tap-reg.py
make-usb.py Fixup make-usb.py 2015-07-19 20:24:08 +00:00
make_charset_table.c
Makefile.am Add a script to validate the Diameter dictionary XML. 2016-08-17 23:53:23 +00:00
msnchat
ncp2222.py Move the proto data stuff out of frame_data.[ch]. 2016-01-25 02:24:34 +00:00
netscreen2dump.py
parse_xml2skinny_dissector.py dissector-skinny: Update skinny dissector to fix ServerRes Message 2015-09-13 19:24:00 +00:00
pkt-from-core.py More spelling fixes found by lintian 2015-11-20 05:47:29 +00:00
pre-commit pre-commit: Ignore missing pre-commit-ignore.py 2016-08-18 11:00:27 +00:00
pre-commit-ignore.conf Combine Decode As and port preferences for tcp.port dissector table. 2016-10-08 02:44:53 +00:00
pre-commit-ignore.py pre-commit: Ignore missing pre-commit-ignore.py 2016-08-18 11:00:27 +00:00
process-x11-fields.pl Support building the X11 dissector outside the source tree. 2015-11-29 11:20:39 +00:00
process-x11-xcb.pl X11: Fix last indent issue on X11 generator 2016-06-16 03:08:07 +00:00
randpkt-test.sh randpkt-test: Fix our optstring 2016-10-05 18:35:44 +00:00
rdps.py
runa2x.sh Make sure our shell, Perl, & Python tools are executable. 2016-03-03 20:11:25 +00:00
runlex.sh Expand a comment. 2016-04-05 23:11:22 +00:00
setuid-root.pl.in No need for execute bit on setuid-root.pl.in 2016-02-03 14:49:08 +00:00
SkinnyProtocolOptimized.xml [skinny] Fix StartMediaTransmissionMessage and OpenReceiveChannelMessage protocol version 20 2016-05-21 20:08:52 +00:00
test-captures.sh Add an initial "shellcheck" target. 2016-09-26 23:17:02 +00:00
test-common.sh Check for ASAN when fuzzing. 2016-09-24 21:04:31 +00:00
textify.ps1
update-tx remove Wireshark.pro, modify update-tx accordingly 2016-06-30 05:32:29 +00:00
usb-ptp-extract-models.pl
usb-ptp-extract-models.txt
valgrind-wireshark.sh tools: improve valgrind script. 2016-02-08 15:24:02 +00:00
validate-diameter-xml.sh Add a script to validate the Diameter dictionary XML. 2016-08-17 23:53:23 +00:00
vg-suppressions
win-setup.ps1 Update c-ares to 1.12.0 2016-09-29 20:35:10 +00:00
wireshark_be.py Spelling fixes for errors found by lintian 2015-12-07 07:11:54 +00:00
wireshark_gen.py Spelling fixes for errors found by lintian 2015-12-07 07:11:54 +00:00
WiresharkXML.py
ws-coding-style.cfg We now support C++/C99-style comments. 2016-09-06 02:44:32 +00:00
yacc.py Ply parser updated to 3.8 from http://www.dabeaz.com/ply/ 2016-08-04 08:20:24 +00:00