osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

checkAPI: move atoi from deprecated to soft-deprecated list. 

atoi must lie in soft-deprecated list until close to complete removal.

Change-Id: Ia26ada56114559637fdc598913ee93523ed9434d
Reviewed-on: https://code.wireshark.org/review/17529
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
This commit is contained in:
Dario Lombardo 2016-09-06 13:41:46 +02:00 committed by Alexis La Goutte
parent 10e84a612b
commit 3fce8da341
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/checkAPIs.pl
View File

@ -143,7 +143,6 @@ my %APIs = (
'freopen',
'fstat',
'lseek',
'atoi', # use wsutil/ws_strtoi.h function
# Misc
'tmpnam', # use mkstemp
'_snwprintf' # use StringCchPrintf
@ -160,7 +159,13 @@ my %APIs = (
# "I" isn't always the upper-case form of "i", and "i" isn't
# always the lower-case form of "I"). Use the g_ascii_* version
# instead.
'toupper'
'toupper',
# use wsutil/ws_strtoi.h function
# because of the wide use of atoi, we keep it in soft-deprecation status
# until we approach its complete removal, otherwise windows buildbot
# will keep to stuck with error.
'atoi',
] },
# APIs that SHOULD NOT be used in Wireshark (any more)