wireshark/epan
Stephen Fisher 4b416d92d0 Fix Coverity 524: NEGATIVE_RETURNS
Coverity sees that two calls to tvb_length_remaining() with an offset
of 0 may return -1 (for an "out of bounds" condition), which would lead
to an assignment of -1 to an unsigned variable and then passing it
to functions further down that cannot accept negative values.

Use tvb_ensure_length_remaining() to throw an exception in a case of
out of bounds access (though unlikely with an offset of 0) instead of
tvb_length_remaining(), which would return -1.


svn path=/trunk/; revision=36615
2011-04-12 22:23:03 +00:00
..
crc A bit of Windows makefiles rework and cleanup: 2011-02-02 01:19:53 +00:00
crypt Fix Coverity CID 557. 2011-04-08 21:21:32 +00:00
dfilter Don't assign to a variable if the value won't be used: Coverity 817-821. 2011-04-04 15:31:33 +00:00
dissectors Fix Coverity 524: NEGATIVE_RETURNS 2011-04-12 22:23:03 +00:00
ftypes Use g_snprintf instead of sprintf: (Part of) Covertiy 665. 2011-04-12 18:29:52 +00:00
wslua From Felix Kraemer: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5694 : 2011-04-05 02:18:28 +00:00
wspython A bit of Windows makefiles rework and cleanup: 2011-02-02 01:19:53 +00:00
CMakeLists.txt From Juliusz Chroboczek via bug #5812: Dissector for the Babel Routing 2011-04-08 16:53:02 +00:00
Makefile.am declare_wslua.h is built, so we need to also search in the wslua build directory for it. (This fixes out-of-source-tree builds with Lua.) 2011-01-07 18:32:17 +00:00
Makefile.common Oh yeah, there's a reason we don't put targets in Makefile.common: the first target in a makefile is what you get when you just run make (without a target). Revert 35073 and 35069. 2010-11-30 02:04:55 +00:00
Makefile.nmake A bit of Windows makefiles rework and cleanup: 2011-02-02 01:19:53 +00:00
addr_and_mask.c
addr_and_mask.h
addr_resolv.c Minor whitespace fix. 2011-04-10 16:40:29 +00:00
addr_resolv.h Add initial pcapng name resolution record support. Wireshark has read 2011-03-24 22:47:57 +00:00
address.h From Slava via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5335 : 2010-11-17 02:57:22 +00:00
address_to_str.c Rename vines_to_str() to tvb_vines_to_str() and make it take a pointer a TVB 2011-02-11 03:13:24 +00:00
adler32.c
adler32.h
afn.c Added "LISP Canonical Address Format (LCAF)". 2010-07-18 16:05:48 +00:00
afn.h Added "LISP Canonical Address Format (LCAF)". 2010-07-18 16:05:48 +00:00
aftypes.h
arcnet_pids.h
arptypes.h Added some ARP options from RFC 5494. 2010-07-18 16:01:11 +00:00
asm_utils.c
asm_utils.h
asm_utils_win32_x86.asm
asn1.c
asn1.h Do not report undecoded message to expert info for ReturnResult without result filed 2010-09-08 09:02:16 +00:00
atalk-utils.c
atalk-utils.h
base64.c
base64.h
bitswap.c
bitswap.h
bridged_pids.h
camel-persistentdata.c
camel-persistentdata.h Doxygen changes. 2010-08-29 10:47:38 +00:00
charsets.c
charsets.h
chdlctypes.h
circuit.c Add minor sanity check 2010-03-25 19:06:49 +00:00
circuit.h Doxygen changes. 2010-08-28 19:27:19 +00:00
codecs.c
codecs.h
column-utils.c In packet_list_dissect_and_cache_record(), set the columns to 2011-04-09 04:33:26 +00:00
column-utils.h In packet_list_dissect_and_cache_record(), set the columns to 2011-04-09 04:33:26 +00:00
column.c Added "Edit Column Details" functions to the packet list heading popup. 2010-10-09 15:22:53 +00:00
column.h Added "Edit Column Details" functions to the packet list heading popup. 2010-10-09 15:22:53 +00:00
column_info.h Corrected comment for col_custom_occurrence. 2010-12-30 20:16:33 +00:00
conversation.c As suggested in http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html 2010-05-13 18:28:34 +00:00
conversation.h Doxygen changes. 2010-08-28 19:27:19 +00:00
crc6.c
crc6.h
crc10.c
crc10.h
crc16.c On Windows, try putting __declspec(noreturn) in front of declarations of 2011-02-17 23:11:49 +00:00
crc16.h
crc32.c On Windows, try putting __declspec(noreturn) in front of declarations of 2011-02-17 23:11:49 +00:00
crc32.h
crcdrm.c
crcdrm.h
diam_dict.h
diam_dict.l From Tamas Regos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4760 : 2010-05-13 13:29:13 +00:00
dissector_filters.c
dissector_filters.h Doxygen changes. 2010-08-28 19:27:19 +00:00
doxygen.cfg.in
dtd.h
dtd_grammar.lemon
dtd_parse.h
dtd_parse.l
dtd_preparse.l
eap.h
emem.c Introduce ep_strconcat (copied from the glib version) 2011-03-26 02:39:04 +00:00
emem.h Introduce ep_strconcat (copied from the glib version) 2011-03-26 02:39:04 +00:00
enterprise-numbers [Automatic manuf, services and enterprise-numbers update for 2011-04-10] 2011-04-10 15:03:48 +00:00
epan.c Revert 34191 and add some casts instead 2010-09-23 06:00:22 +00:00
epan.h Revert 34191 and add some casts instead 2010-09-23 06:00:22 +00:00
epan_dissect.h
etypes.h Add RoHC to the ethertypes. 2011-04-06 18:48:07 +00:00
ex-opt.c
ex-opt.h
except.c config.h is now included, and it defines _WIN32_WINNT. 2011-02-17 23:36:39 +00:00
except.h Put WS_MSVC_NORETURN back. 2011-02-18 00:08:03 +00:00
exceptions.h Get rid of trailing white space. 2010-12-27 21:40:48 +00:00
exntest.c
expert.c Make frames containing Malformed expert items match with "malformed" display filter. 2010-07-16 11:17:32 +00:00
expert.h From John Thacker via bug #5644: Can't include expert.h in C++ code 2011-02-01 21:03:29 +00:00
filesystem.c Rename ws_stat to ws_stat64, and make it take a pointer to a ws_statb64 2011-04-10 20:59:10 +00:00
filesystem.h Added functionality for handling global profiles. 2011-02-26 17:23:24 +00:00
follow.c
follow.h
frame_data.c Removal of the old packet-list in favor of the new packet list. 2011-03-08 01:52:25 +00:00
frame_data.h Removal of the old packet-list in favor of the new packet list. 2011-03-08 01:52:25 +00:00
frequency-utils.c
frequency-utils.h
funnel.c
funnel.h
g_gnuc_malloc.h Introduce ep_strconcat (copied from the glib version) 2011-03-26 02:39:04 +00:00
garrayfix.h
gcp.c Use g_ascii_strdown instead of g_strdown 2011-03-28 19:44:41 +00:00
gcp.h Whitespace/indentation/code style cleanup. 2010-06-03 07:38:27 +00:00
geoip_db.c Close dir opened by ws_dir_open(). 2011-01-22 13:44:06 +00:00
geoip_db.h
golay.c
golay.h
greproto.h Jason Masker <jason at masker.net>: 2010-09-23 13:31:28 +00:00
guid-utils.c
guid-utils.h
h225-persistentdata.c
h225-persistentdata.h
iana_snap_pid.h
iax2_codec_type.h
in_cksum.c Add a note to the top about r35589's change of the ADDCARRY(x) macro. 2011-01-19 22:57:19 +00:00
in_cksum.h
ip_opts.h Doxygen changes. 2010-08-29 10:47:38 +00:00
ipproto.c Rename g_resolv_flags --> gbl_resolv_flags; Also: cleanup some whitespace & indentation. 2010-10-12 13:15:08 +00:00
ipproto.h Make value_string ipproto_val static; It should only be referenced using ipproto_val_ext 2010-09-23 18:00:06 +00:00
ipv4.c From Yaniv Kaul: constify parameters 2010-04-03 18:18:50 +00:00
ipv4.h From Yaniv Kaul: constify parameters 2010-04-03 18:18:50 +00:00
ipv6-utils.h Doxygen changes. 2010-08-29 10:47:38 +00:00
lapd_sapi.h
libwireshark.def Add proto_field_is_referenced. Fixes bug 5816. 2011-04-11 13:44:31 +00:00
libwireshark.vcproj
llcsaps.h
next_tvb.c Rename the routines that handle dissector tables with unsigned integer 2010-12-20 05:35:29 +00:00
next_tvb.h Another #define for old code. 2010-12-20 05:58:42 +00:00
nlpid.h
nstime.c Added two new functions: nstime_diff() and nstime_subtract(). 2010-10-27 07:44:26 +00:00
nstime.h Added two new functions: nstime_diff() and nstime_subtract(). 2010-10-27 07:44:26 +00:00
oids.c Corrected decoding of oid values with length 5. 2011-03-21 18:58:48 +00:00
oids.h Doxygen changes. 2010-08-29 10:47:38 +00:00
osi-utils.c Fix some dead code and zero division issues found by Clang scan-build. 2011-02-18 22:43:48 +00:00
osi-utils.h
oui.h Enhancement bug #5796: Add Atheros vendor specific 802.11 IE parsing 2011-04-06 19:57:39 +00:00
packet.c Added dissector_handle_get_long_name(). 2011-03-31 12:14:59 +00:00
packet.h Added dissector_handle_get_long_name(). 2011-03-31 12:14:59 +00:00
packet_info.h Rename the routines that handle dissector tables with unsigned integer 2010-12-20 05:35:29 +00:00
pint.h Add tvb_get_[n|le]toh[40|48|56]() accessors. Addresses bug 5082. 2011-01-14 19:02:38 +00:00
plugins.c Move wslua_plugin_list to epan/plugins.c, that should fix the Solaris builds finally. 2010-12-10 10:37:03 +00:00
plugins.h Always provide wslua_plugin_list, even if we don't have Lua configured. 2010-12-09 15:20:14 +00:00
ppptypes.h
prefs-int.h Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4768 : 2010-10-29 22:09:31 +00:00
prefs.c Fix some dead code and zero division issues found by Clang scan-build. 2011-02-18 22:43:48 +00:00
prefs.h Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4768 : 2010-10-29 22:09:31 +00:00
proto.c Use g_strlcpy() instead of prohibited strncpy() to guarantee NULL-termination. 2011-04-11 13:38:32 +00:00
proto.h Add a hint for Visual C++ to DISSECTOR_ASSERT. Hopefully this will 2011-02-17 23:21:07 +00:00
ptvcursor.h Refer to the endianness arguments as "encoding" rather than 2010-05-24 06:06:17 +00:00
radius_dict.l Fix dead initialization error found by clang: 2011-02-17 18:53:35 +00:00
range.c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4768 : 2010-10-29 22:09:31 +00:00
range.h Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4768 : 2010-10-29 22:09:31 +00:00
reassemble.c From Jakub Zawadzki via wireshark-dev: Fix comment. 2011-03-21 13:28:20 +00:00
reassemble.h Introduce "Fragment count" filter element for all protocols doing reassembly. 2011-01-30 21:01:07 +00:00
reassemble_test.c Add more duplicate fragment tests. 2011-03-03 23:28:32 +00:00
reedsolomon.c
reedsolomon.h
report_err.c
report_err.h
req_resp_hdrs.c Try to optimize a bit. 2010-05-26 11:51:41 +00:00
req_resp_hdrs.h
rtp_pt.h Use value_string_ext for RTP payload types. 2010-11-08 14:43:59 +00:00
sctpppids.h Obtained from Thomas Dreibholz: Update SCTP PPIDs. 2011-02-10 12:54:20 +00:00
sigcomp-udvm.c Make sure our addresses are modulo 2^16 in a lot of places. Fixes a 2010-06-25 17:14:41 +00:00
sigcomp-udvm.h
sigcomp_state_hdlr.c Adress => Address corrections (also in comments). 2011-01-21 00:19:03 +00:00
sigcomp_state_hdlr.h
slab.h
sminmpec.h From Andrew Feren via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5377 : 2010-12-07 03:46:10 +00:00
sna-utils.c
sna-utils.h
stat_cmd_args.c
stat_cmd_args.h
stats_tree.c Fix some dead code and zero division issues found by Clang scan-build. 2011-02-18 22:43:48 +00:00
stats_tree.h
stats_tree_priv.h Doxygen changes. 2010-08-29 10:47:38 +00:00
stream.c (Minor): Do some sanity checking.... 2010-03-25 19:05:44 +00:00
stream.h
strutil.c Fix some dead code and zero division issues found by Clang scan-build. 2011-02-18 22:43:48 +00:00
strutil.h Doxygen changes. 2010-08-29 10:47:38 +00:00
t35.c
t35.h
tap-voip.h
tap.c (Trivial) Fix some typos; do some whitespace cleanup & rewording of comments. 2011-03-31 14:30:38 +00:00
tap.h Add ICMP tap support, and add a tshark tap to measure such things as: 2011-04-05 20:21:59 +00:00
tcap-persistentdata.c
tcap-persistentdata.h Doxygen changes. 2010-08-28 19:27:19 +00:00
tfs.c Change a bunch of value and tfs strings to not be prefixed by hf_ but ieee8021. Based on Alexis La Gouttes patch. 2011-01-31 20:37:17 +00:00
tfs.h Change a bunch of value and tfs strings to not be prefixed by hf_ but ieee8021. Based on Alexis La Gouttes patch. 2011-01-31 20:37:17 +00:00
time_fmt.h Make the absolute_time_display_e enum start at 1000 to avoid overlapping with 2010-04-24 19:07:21 +00:00
timestamp.c Added an option to display seconds as hours, minutes and seconds 2010-05-06 10:32:59 +00:00
timestamp.h Added an option to display seconds as hours, minutes and seconds 2010-05-06 10:32:59 +00:00
to_str.c Use g_strlcat instead of strcat: Coverity 632. 2011-04-12 18:16:55 +00:00
to_str.h Rename vines_to_str() to tvb_vines_to_str() and make it take a pointer a TVB 2011-02-11 03:13:24 +00:00
tpg.c
tpg.h
tvbparse.c From Jakub Zawadzki via bug 4753: New dissector: JSON, w/minor changes by me: 2010-12-31 18:03:23 +00:00
tvbparse.h Cleanup and export the TVB parser. 2010-05-06 18:37:47 +00:00
tvbtest.c From jakub Zawadzki: 2011-04-04 05:48:06 +00:00
tvbuff.c From jakub Zawadzki: 2011-04-04 05:48:06 +00:00
tvbuff.h Mention that the fake tvb unicode functions have been superceded 2011-01-28 20:01:01 +00:00
uat-int.h
uat.c Ensure we don't index into a NULL pointer. 2010-08-04 13:34:50 +00:00
uat.h Set maximum value for UAT range in fld_data, not cbdata.chk/set/tostr. 2010-10-30 17:51:20 +00:00
uat_load.l Close UAT file after loading. 2011-02-28 16:11:20 +00:00
value_string.c Fix the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5574 : 2011-01-12 17:20:52 +00:00
value_string.h Fix the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5574 : 2011-01-12 17:20:52 +00:00
x264_prt_id.h
xdlc.c
xdlc.h Doxygen changes. 2010-08-29 10:47:38 +00:00