Commit Graph

11667 Commits

Author SHA1 Message Date
Ronnie Sahlberg f4f2b80b21 change result code names to be the same as in the LDAP standard
so it is easier to grep between them


svn path=/trunk/; revision=11880
2004-09-02 08:12:41 +00:00
Guy Harris 0d5f2faf2c Use the value for the UNIX epoch from RFC 868 for the difference between
the Time Protocol epoch and the UNIX epoch; that wasn't the value we
were using.

svn path=/trunk/; revision=11876
2004-09-01 18:48:31 +00:00
Ulf Lamping 1622014b3b various minor changes (adding missing id's to sections, changed some phrases, ...)
svn path=/trunk/; revision=11875
2004-09-01 13:50:02 +00:00
Ulf Lamping 812bc6eade renamed REQUIRED_APPS to REQUIRED_TOOLS and verify_apps to verify_tools, as it seems much more appropriate
svn path=/trunk/; revision=11874
2004-09-01 11:53:28 +00:00
Ulf Lamping e2ccb3668e rework of chapter
svn path=/trunk/; revision=11873
2004-09-01 11:51:50 +00:00
Ulf Lamping 537881ecf5 added a section "Win32: Verify installed tools"
svn path=/trunk/; revision=11872
2004-09-01 11:51:08 +00:00
Ulf Lamping 75fb33231b reworked chapters
svn path=/trunk/; revision=11871
2004-09-01 09:31:06 +00:00
Guy Harris 365a145c34 Get rid of some unused variables.
Put into the protocol tree for APP1 and APP2 segments not otherwise
handled an item for the remaining segment data.

svn path=/trunk/; revision=11870
2004-09-01 08:12:20 +00:00
Guy Harris d15724fc9e Make a bunch of source files non-executable.
svn path=/trunk/; revision=11869
2004-09-01 07:07:23 +00:00
Guy Harris b061f78dad Updates from Erwin Rol.
svn path=/trunk/; revision=11868
2004-09-01 06:56:33 +00:00
Ulf Lamping aa4256e519 major rework
svn path=/trunk/; revision=11867
2004-08-31 21:02:52 +00:00
Ulf Lamping b713f09c6d added some infos about the two parts of the book
svn path=/trunk/; revision=11866
2004-08-31 20:58:01 +00:00
Ulf Lamping e833caab96 minor change (added a <filename> tag)
svn path=/trunk/; revision=11865
2004-08-31 20:57:00 +00:00
Ulf Lamping 7b71fe2b17 add HFILL to the skeleton example and documentation of the field registration
svn path=/trunk/; revision=11864
2004-08-31 12:39:25 +00:00
Ulf Lamping 121022d8a0 fixed two typos
svn path=/trunk/; revision=11863
2004-08-31 12:36:36 +00:00
Ulf Lamping 91eebca54d added correct usage of "svn diff" tool
svn path=/trunk/; revision=11862
2004-08-31 12:35:49 +00:00
Ulf Lamping fb7f8d937b added two (almost) emtpy new chapters
svn path=/trunk/; revision=11861
2004-08-31 11:25:23 +00:00
Ulf Lamping bd2a5268db some minor rework
svn path=/trunk/; revision=11860
2004-08-31 11:24:10 +00:00
Ulf Lamping 5e32dc06eb added a preference setting, to be able to change the preview timeout in the file open dialog (as requested by Ronnie Sahlberg).
svn path=/trunk/; revision=11859
2004-08-31 09:22:57 +00:00
Ulf Lamping 5a9fc6543f corrected paths, where the dissectors and the corresponding Makefile.common can be found, to epan/dissectors
svn path=/trunk/; revision=11858
2004-08-31 09:19:41 +00:00
Ronnie Sahlberg 477ab2a7cc break out the nt decryption and password handling into a separate function
so we can call it from elsewhere


svn path=/trunk/; revision=11857
2004-08-31 08:30:58 +00:00
Ulf Lamping 50b29ff07d Split the preview function into a prepare and a do part, to be able to do some experiments about the preview timeout things.
As the FileChooser dialog (GTK2.4) doesn't seem to let pass other GTK events (even with calling gtk_main_iteration()), it's not possible to change the preview behaviour to be more keen. To get a mechanism to update the preview independant from the dialog workings, we would need to start a new thread/task, which is too much effort for this IMHO.

So we might use the more simple approach of setting the timeout by a preference setting.

svn path=/trunk/; revision=11856
2004-08-31 08:18:10 +00:00
Guy Harris 92a52408e8 Don't have a dummy widget to use for panes marked as "None" - that means
the widget in question gets more than one parent if more than one pane
is marked as "None", and GTK_ doesn't like that.  Instead, just have
"main_widget_layout()" return a null pointer for "None" panes, and don't
put the pane into the pane splitter if that pane is null.

Clean up the handling of layouts.

svn path=/trunk/; revision=11855
2004-08-31 02:49:28 +00:00
Guy Harris 344dddb124 Pass an "address *" to "rtp_add_address()" and "rtcp_add_address()", so
so that they could handle IPv6 addresses.

Clean up white space.

svn path=/trunk/; revision=11854
2004-08-30 10:03:54 +00:00
Ronnie Sahlberg e74f18ee9b Add a key origin string for kerberos keys
so that IF kerberos succeeds in decrypting a blob it can print a nice
"[Decrypted using: keytab principal foo/bar@REALM]"
or
"[Decrypted using: key learnt from frame xx]"

This makes it much easier to keep track of what keys decrypt what blob
and is very useful for illustrating the sequence of keys that are exchanged and used in kerberos during the AS/TGS/AP exchanges.




svn path=/trunk/; revision=11853
2004-08-30 09:49:08 +00:00
Ronnie Sahlberg ddf0bdb696 For protocols running atop TCP and PDUs spanning multiple segments
ethereal used to (bug) print in the summary line
"[Continuation to #%d]" where %d was the current frame number.

Fix this bug and let %d print the frame number of the first frame for this multiframe PDU.


(Strange that no one has complained about this one)


svn path=/trunk/; revision=11852
2004-08-30 08:40:08 +00:00
Ronnie Sahlberg 6de3544a52 Reintroduce the three previously removed iscsi header digest preference options as obsolete preferences so that users upgrading to later versions of ethereal will not get the warning output for unknown preferences printed to stdout.
svn path=/trunk/; revision=11851
2004-08-30 08:31:21 +00:00
Ronnie Sahlberg ccf7ed00b6 remove two preference options related to iscsi header digest
make ethereal attempt to automatically detect wether header digest is used or not for iscsi sessions.

This makes ethereal decode the packets properly EVEN for perfectly normal sessions where
the discovery session is performed with no digest but the normal login session negotiates digest.


the detected headerdigest setting is tcp session wide and thus it
it does not work for such initiators (if such exist) that resuse the same socketpair between the discovery and normal login sessions.



svn path=/trunk/; revision=11850
2004-08-29 04:12:35 +00:00
Ronnie Sahlberg d15ea23bd3 finalize refactoring of conversation handling.
what remains now is attaching autodetection of header digest to 
the session state structure.


svn path=/trunk/; revision=11849
2004-08-29 02:55:02 +00:00
Ronnie Sahlberg 9812797721 move the conversation find and create into dissect_iscsi() from dissect_iscsi_pdu() so it will be easier to add a session wide state structure to iscsi.
later this soon to be implemented structure (and not the conversation) will 
hold the information we need to track  wether
digests etc are in use or not.

this also allows some minor indentation cleanups as well.



svn path=/trunk/; revision=11848
2004-08-29 01:15:32 +00:00
Ronnie Sahlberg 6ab442bacf indentation change to make dissect_iscsi() easier to read
svn path=/trunk/; revision=11847
2004-08-28 23:54:16 +00:00
Ronnie Sahlberg b5daad6252 ISCSI Login Request and Login Response never contain any HeaderDigests
svn path=/trunk/; revision=11846
2004-08-28 23:12:16 +00:00
Ronnie Sahlberg ba7901db6c fix the bug introduced in the window scaling update, dont
try to access the conversation structures unless the
proper preferences are enabled (so that the structs exists iun the first place)



svn path=/trunk/; revision=11845
2004-08-28 21:46:54 +00:00
Guy Harris 03be75bd1c We use "#ifdef" elsewhere to test WIN32; use it, rather than #if, in the
one place we were using #if.

svn path=/trunk/; revision=11844
2004-08-28 21:27:08 +00:00
Guy Harris 57d15574ef From Francisco Alcoba: fix a crashing bug caused if you change the
dissection for a given transport protocol port and there's no packet
currently selected.

svn path=/trunk/; revision=11843
2004-08-28 09:54:04 +00:00
Gerald Combs 7d2c21e317 Bump the GTK+ 2.4 version up to 2.4.7, and bup GTK-Wimp up to 0.62.
svn path=/trunk/; revision=11842
2004-08-26 23:01:46 +00:00
Guy Harris 6e9e773a85 From Lars Roland:
don't support GTK-Wimp for GTK+ 1.2[.x] (it requires 2.x);

	install the NEWS file as "NEWS.txt";

	optionally show it at the end of an installation.

svn path=/trunk/; revision=11841
2004-08-26 22:48:29 +00:00
Guy Harris e6bc3872b0 From Lars Roland: don't link with GTK+, as it's not necessary to do so,
and as plugin dissectors shouldn't be linked with GTK+ (so that they
don't depend on Ethereal being built with a particular version of GTK+ -
Ethereal is packaged for Windows in both GTK+ 1.3[.x] and 2.x versions -
and so that they can work with Tethereal, which doesn't use GTK+).

svn path=/trunk/; revision=11840
2004-08-26 22:46:32 +00:00
Guy Harris 463ea07dde Clean up white space.
"dissect_sip()" returns a "gint", so it has to be registered with
"new_register_dissector()".

svn path=/trunk/; revision=11839
2004-08-26 22:03:47 +00:00
Guy Harris f51d98f87b Update the I-D name.
svn path=/trunk/; revision=11838
2004-08-26 18:34:16 +00:00
Ronnie Sahlberg 58b6e2f49f fix to that long outstanding bug with windowscaling
If window scaling is NOT offered in the SYN+ACK  then window scaling will
not be used at all, so clear it if we saw it offered previously in the SYN packet.

If the window is scaled in a packet,  make ethereal display that by appendign the 
string "  (scaled)" to the end of the tcp.window line in the
decode pane.



svn path=/trunk/; revision=11837
2004-08-26 10:03:40 +00:00
Guy Harris 5d1de30923 From Greg Morris:
1. Fix Fax Number NDS attribute.  This was causing malformed
	   packet message due to improper decoding. 

	2. Do not try to decode packet beyond connection status when
	   return value is non-zero (error condition).

svn path=/trunk/; revision=11836
2004-08-26 07:46:29 +00:00
Ulf Lamping a821d26c5d fixed some typos
svn path=/trunk/; revision=11835
2004-08-25 19:35:11 +00:00
Ronnie Sahlberg 379ca865e4 Add the optional 13th tag to the KRB_ERR structure.
This tag was part of an early kerberos draft but had dissapeared
when 1510 was published.
this early draft exist in implementations in the wild.

add 4 extra checksum types as well from that draft.



svn path=/trunk/; revision=11834
2004-08-25 11:35:04 +00:00
Ronnie Sahlberg 29a31444b6 Prettify the principal name expansion to make it look more like normal kerberos notation for principals
i.e. display it as "foo/bar"  instead of as "foo bar"




svn path=/trunk/; revision=11833
2004-08-25 10:48:37 +00:00
Guy Harris 46edf2a910 Newer version of Luis Ontanon's patch.
svn path=/trunk/; revision=11832
2004-08-25 05:51:14 +00:00
Anders Broman 8d89d3556d Add Luis Ontanon to the list of authors.
svn path=/trunk/; revision=11831
2004-08-25 05:24:49 +00:00
Anders Broman ed93214bc5 From Luis Ontanon:
add some fields for filtering on radius attributes. 

svn path=/trunk/; revision=11830
2004-08-25 05:14:17 +00:00
Guy Harris f122136663 Don't free something we haven't allocated.
svn path=/trunk/; revision=11829
2004-08-25 05:12:58 +00:00
Guy Harris 750812d739 guint64 & guint64 is another guint64, but a gboolean is just 32 bits on
most if not all platforms; the "bitwise and" operator in display filters
is Boolean and evaluates to "true" if the result is non-zero and "false"
otherwise, so explicitly do the comparison with 0 to make sure we don't
just throw away the upper 32 bits.

Do the same for the 32-bit bitwise AND as well, although it's not
strictly necessary.

svn path=/trunk/; revision=11828
2004-08-25 03:44:04 +00:00