Commit Graph

23596 Commits

Author SHA1 Message Date
Stig Bjørlykke f4871e6269 Fixed a possible buffer overflow in dissect_fmp_flushCmd() when cmd has
all bits set.

svn path=/trunk/; revision=24248
2008-02-02 17:17:16 +00:00
Stig Bjørlykke dc1f6dc424 Rewrote strcat -> strncat, and fixed to show more than the last remaining
Cmd_Argv value for Remote Command.

svn path=/trunk/; revision=24247
2008-02-02 17:13:30 +00:00
Jaap Keuter 1c2f043913 From Peter Kjellerstedt:
I was capturing an RTP stream the other day which contained JPEG images
streamed according to RFC 2435. However, Wireshark reported them as malformed.
After some debugging of the Wireshark code it turned out that the decoding of
JPEG images which contain a quantization table was incorrect. I have attached a
patch to correct the decoding.

svn path=/trunk/; revision=24246
2008-02-02 16:41:12 +00:00
Jaap Keuter 1a9aa1ae62 From Alan McBride:
The decoding of a SubscribeCOVProperty packet is not properly decoding the
Monitored Property Identifier field. It leaves a number of decoded bytes at the
end as data.

svn path=/trunk/; revision=24245
2008-02-02 16:30:46 +00:00
Sake Blok 0446fc0d94 Fix for bug 2202, when an ethernet frame with padding is encountered, the
reported length is 46, so there was a one-off error in the code.


svn path=/trunk/; revision=24244
2008-02-02 09:21:09 +00:00
Stig Bjørlykke de3c7e9a0b Disallow ending space was not such a good idea, chop it of before save instead.
Also disallow '/' in profilename for !win32. 

svn path=/trunk/; revision=24243
2008-02-01 18:42:59 +00:00
Stig Bjørlykke 4c2f3b0644 Fixed a problem with renaming a profile after hitting apply.
Profile name cannot start or end with space, and on win32 it cannot contain
any of this characters: \ / : * ? " < > |
Added a tooltip to the profile name text box.

svn path=/trunk/; revision=24242
2008-02-01 16:49:34 +00:00
Stig Bjørlykke fe98fab03c Added tooltip description for yellow filter background.
svn path=/trunk/; revision=24241
2008-02-01 10:02:19 +00:00
Jaap Keuter 0b9fb7efea Updated various misleading examples.
svn path=/trunk/; revision=24240
2008-02-01 06:47:12 +00:00
Stig Bjørlykke 10a8f59e03 Rewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24239
2008-02-01 01:07:58 +00:00
Stig Bjørlykke ee8b8b0ad7 Hmmm. Second try to fix the const problems.
svn path=/trunk/; revision=24238
2008-01-31 23:10:09 +00:00
Stig Bjørlykke dc5b4a8239 Removed a const to make it compile.
svn path=/trunk/; revision=24237
2008-01-31 22:31:01 +00:00
Anders Broman fc1244edbe Split out the Gmb application AVP:s to at least make it simpler to handle the
AVP "collision".
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1494

svn path=/trunk/; revision=24236
2008-01-31 21:53:26 +00:00
Anders Broman 8f3eeff54b Split out the Gmb application AVP:s to at least make it simpler to handle the
AVP "collision".
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1494

svn path=/trunk/; revision=24235
2008-01-31 21:52:47 +00:00
Gerald Combs a4a1f2a69e Make the "!="/"ne" change compile under Windows.
svn path=/trunk/; revision=24234
2008-01-31 20:18:07 +00:00
Stig Bjørlykke 18fd58de40 Added missing space in front of new statusbar messages.
svn path=/trunk/; revision=24233
2008-01-31 20:00:45 +00:00
Gerald Combs 9703c2bb75 If "!=" or "ne" are used in a display filter, warn the user that the results
may be unexpected.

svn path=/trunk/; revision=24232
2008-01-31 19:50:38 +00:00
Stig Bjørlykke f3747bf637 Hide hidden devices in "Capture Interfaces" dialog.
Added a function to check for hidden devices, which also work correctly
for plumbed devices on solaris.

svn path=/trunk/; revision=24231
2008-01-31 16:47:05 +00:00
Bill Meier 161eb8b6d7 Add missing g_object_unref for treeview models;
Remove not needed set_tree_model (stats_tree_stat.c)

svn path=/trunk/; revision=24230
2008-01-31 16:37:56 +00:00
Stig Bjørlykke 1efb7e3627 Add Luis' uat_get_table_by_name() to fetch SMI uat tables.
svn path=/trunk/; revision=24229
2008-01-30 22:50:55 +00:00
Anders Broman df0e82fa10 Dissect the FLUTE "data".
svn path=/trunk/; revision=24228
2008-01-30 22:34:17 +00:00
Jeff Morriss 8ba9f2d3a4 Move glib-2 specific code out of gsmmap.cnf (where we can't #ifdef around
it--asn2wrs doesn't understand #ifdef's) to packet-gsm-template.c

svn path=/trunk/; revision=24227
2008-01-30 17:11:06 +00:00
Stig Bjørlykke 869213d9ef Added missing space in front of some statusbar messages.
svn path=/trunk/; revision=24226
2008-01-30 15:16:21 +00:00
Mike Duigou 98ccd35021 Update my email address.
svn path=/trunk/; revision=24225
2008-01-29 23:30:27 +00:00
Mike Duigou 136e5c2e1f cleanup initial comment. fix urls and email addresses.
svn path=/trunk/; revision=24224
2008-01-29 23:28:10 +00:00
Bill Meier fcff7d7613 Add missing 'static int' for dissect_diameter_3gpp_tmgi(...)
svn path=/trunk/; revision=24223
2008-01-29 20:33:43 +00:00
Anders Broman 9e03164d14 Dissect 3GPP AVP Code: 900 TMGI
svn path=/trunk/; revision=24222
2008-01-29 20:05:02 +00:00
Bill Meier 1401a76e91 For Windows: Update to use Gtk+ 2.12.6; Use latest Glib 2.14.5 again;
Gtk 2.12.6 fixes bugzilla.gnome.org bug #503326 which thus means that
Wireshark no longer needs a work-around for Wireshark bug #2066. 
(See svn #24219).

svn path=/trunk/; revision=24221
2008-01-29 18:55:28 +00:00
Stig Bjørlykke 7ec0e26318 When having more than one matching item in a frame the MAX and MIN calculation
could return an invalid value.  Also fixed AVG calculation.

svn path=/trunk/; revision=24220
2008-01-29 14:27:02 +00:00
Sake Blok c024c88a0b Revert GTK+/GLIB to GTK+ 2.12.1 with GLib 2.14.3 for Windows installs
as a workaround for bug 2066. We should stick to these versions until
bug report #503326 on bugzilla.gnome.org has been fixed.


svn path=/trunk/; revision=24219
2008-01-29 10:48:53 +00:00
Stig Bjørlykke 70d1699bb2 SSI dBm signal is signed.
svn path=/trunk/; revision=24218
2008-01-29 09:56:11 +00:00
Stig Bjørlykke 7715fe8c8c Use the new gettext-runtime.
svn path=/trunk/; revision=24217
2008-01-28 20:23:08 +00:00
Anders Broman dd1ae8f4f7 Dissect Vendor id and Auth-application Id.
svn path=/trunk/; revision=24216
2008-01-28 19:55:20 +00:00
Tomas Kukosa b2b6786670 cleanup code (remove some collapsed conditions)
svn path=/trunk/; revision=24215
2008-01-28 17:34:38 +00:00
Jaap Keuter e5aa8c3f52 Adding Thomas Morin
svn path=/trunk/; revision=24214
2008-01-28 17:27:22 +00:00
Stig Bjørlykke dc3900dc00 Make use of an unused value.
svn path=/trunk/; revision=24213
2008-01-27 23:33:09 +00:00
Anders Broman 39b64a4d6c Add the forgotten file.
svn path=/trunk/; revision=24212
2008-01-27 23:18:57 +00:00
Anders Broman ce40fc22a4 Make it possible to do subdissection of Diameter AVP:s and add dissection
of some 3GPP AVP:s.

svn path=/trunk/; revision=24211
2008-01-27 21:06:33 +00:00
Stig Bjørlykke 3278775634 When having more than one matching item in a frame the AVG calculation
did not return a correct value.

svn path=/trunk/; revision=24210
2008-01-27 18:19:40 +00:00
Stig Bjørlykke 8369bda495 Expand the Protocol column instead of the last column on window resize.
svn path=/trunk/; revision=24209
2008-01-27 15:54:15 +00:00
Stig Bjørlykke 45572b611c Do not change profile if directory creation failed, and change to default
profile if existing profile was deleted.

svn path=/trunk/; revision=24208
2008-01-27 14:45:31 +00:00
Anders Broman c3fa6a267c Uncomplete code change.
svn path=/trunk/; revision=24207
2008-01-27 14:27:11 +00:00
Anders Broman 2e5732b7ae New gettext-runtime
svn path=/trunk/; revision=24206
2008-01-27 14:26:11 +00:00
Anders Broman 1144c36b11 Fix reassembly.
svn path=/trunk/; revision=24205
2008-01-27 11:03:56 +00:00
Stig Bjørlykke 57ab05545c Also destroy the window when failure to export/import color filters.
svn path=/trunk/; revision=24204
2008-01-26 17:04:49 +00:00
Stig Bjørlykke dce0761a4a Destroy the open window after open failure to avoid having an unusable
open dialog when using GTK >= 2.4.

This fixes bug 1986.

svn path=/trunk/; revision=24203
2008-01-26 16:50:08 +00:00
Stig Bjørlykke 9c8078686e Destroy the save window after canceling a save to an existing file, so
the user is able to save again without having a hidden save window which 
will not open.

Older GTK versions will show the hidden window after failure.

This fixes bug 1896.

svn path=/trunk/; revision=24202
2008-01-26 16:45:29 +00:00
Stig Bjørlykke 8d512b51d2 From Peter (bug 2224):
Patch to fix compile with glib-1.2.

svn path=/trunk/; revision=24199
2008-01-26 15:28:37 +00:00
Ulf Lamping 79fbb2a272 g_warning -> pcapng_debug and "switch it off" as default, so normal users won't be annoyed by debug messages
svn path=/trunk/; revision=24198
2008-01-26 14:08:51 +00:00
Graeme Lunt bf8ce12ca3 Use the standard X.402 module as a separate file rather than as cut/paste into the ACP133 module.
svn path=/trunk/; revision=24197
2008-01-26 10:18:10 +00:00