Commit Graph

34372 Commits

Author SHA1 Message Date
Gerald Combs f3bbbce5e3 Fix a buffer overflow found by the Visual C++ analyzer.
svn path=/trunk/; revision=35953
2011-02-16 00:42:06 +00:00
Bill Meier 4099dfa603 Update a few comments about the use of LOCAL_CFLAGS, STANDARD_CFLAGS and WARNING_ARE_ERRORS
svn path=/trunk/; revision=35952
2011-02-15 16:56:31 +00:00
Bill Meier dcb5dfe207 Enable /analyze:WX- only if ENABLE_CODE_ANALYSIS is defined ...
svn path=/trunk/; revision=35951
2011-02-15 16:40:09 +00:00
Jörg Mayer 77047f4ea4 Previously 1 byte TCP payload to port 2000 got interpreted as malformed Skinny
svn path=/trunk/; revision=35950
2011-02-15 12:06:39 +00:00
Jaap Keuter 1be49d98a5 From Matthew Parris:
Display "Day of Year" for January 1 as 1, not 0.

svn path=/trunk/; revision=35949
2011-02-15 07:14:22 +00:00
Jaap Keuter bc1832599b From Ania:
Patch enables decoding CM 7.1(3b) messages and CM5 CallInfoMessage (0x14A).

svn path=/trunk/; revision=35948
2011-02-14 22:52:14 +00:00
Jaap Keuter fdca1ea223 Make sure RTP conversations are created.
svn path=/trunk/; revision=35947
2011-02-14 20:51:40 +00:00
Gerald Combs 7bd9a9c607 Enable Enterprise Code Analysis via the ENABLE_CODE_ANALYSIS environment
variable.

svn path=/trunk/; revision=35946
2011-02-14 18:58:37 +00:00
Stig Bjørlykke 0ac8e7cc8d Put error messages and expert info for illegal UTCTime elements as a
subtree on the UTCTime element.

svn path=/trunk/; revision=35945
2011-02-14 10:18:03 +00:00
Chris Maynard 25d68e6c5b Disallow invalid char's in the filename passed to idl2wrs. Fixes bug 1129.
svn path=/trunk/; revision=35944
2011-02-14 01:44:15 +00:00
Jaap Keuter 3c54ea00a9 From Fulko Hew:
The 'upper bound field is not being displayed in Register and Unregister PDU's.

svn path=/trunk/; revision=35943
2011-02-13 21:19:26 +00:00
Gerald Combs 5a7ac9140e [Automatic manuf, services and enterprise-numbers update for 2011-02-13]
svn path=/trunk/; revision=35940
2011-02-13 16:03:49 +00:00
Anders Broman f9b379bab5 Advance offsets in the "default" branch to avoid infinite loops.
** (tshark.exe:4392): WARNING **: Dissector bug, protocol GSM BSSMAP, in packet
194520: More than 1000000 items in the tree -- possible infinite loop
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5688

svn path=/trunk/; revision=35939
2011-02-13 15:43:17 +00:00
Anders Broman fcec56cd31 Register BICC by name.
svn path=/trunk/; revision=35938
2011-02-13 15:01:34 +00:00
Anders Broman d8a87d589b Update standard references.
svn path=/trunk/; revision=35937
2011-02-13 13:56:30 +00:00
Guy Harris adfedf3600 Use the p2p_dir names for the direction values, and also list
P2P_DIR_UNKNOWN as "Unspecified" (to distinguish it from "Unknown" as in
"I don't know what that value means").

svn path=/trunk/; revision=35936
2011-02-12 20:59:43 +00:00
Anders Broman 35bde0d589 Update dissection of
3.2.2.103 Speech Codec List
3.2.2.104 Speech Codec
to 3GPP TS 48.008 version 9.4.0 Release 9.

svn path=/trunk/; revision=35935
2011-02-12 20:17:47 +00:00
Guy Harris 38c6d248e8 When generating the Info column, don't assume the direction is either
P2P_DIR_SENT or P2P_DIR_RECV - it might be unknown.

Use some #defines for SDP data element IDs, and rename the routine that
gets data elements tor reflect what it does.

svn path=/trunk/; revision=35934
2011-02-12 20:08:47 +00:00
Guy Harris a595f69ce4 The lack of _WITH_PHDR in WTAP_ENCAP_BLUETOOTH_H4 means there's no
pseudo-header, and hence there's no direction indication. Don't set
pinfo->p2p_dir for it.  Use WTAP_ENCAP_BLUETOOTH_H4_WITH_PHDR, not
WTAP_ENCAP_BLUETOOTH_H4, for capture files where we have the direction.

Don't assume pinfo->p2p_dir is either P2P_DIR_SENT or P2P_DIR_RECV when
setting the info column in various Bluetooth dissectors; it might be
unknown.

In the HCI H4 dissector, put the direction into the info column
regardless of whether we have a type match or not; the dissectors for
HCI packet types appear to assume it's been set (as they put a blank at
the beginning of the stuff they append to the direction).

svn path=/trunk/; revision=35933
2011-02-12 19:59:41 +00:00
Gerald Combs b83634d5a9 Cygwin 1.7 is much pickier about paths. Pass a POSIX path to bash.
svn path=/trunk/; revision=35930
2011-02-12 17:54:36 +00:00
Jeff Morriss 2620f18569 There is a better (and faster) way to see if all the members of one list are
in another list: convert the 2nd list to a hash.  This speeds checking for ett_
variables up considerably.

Store the pattern to match ett_ variable names in a variable (since it's used 3
times).

Only match ett_ variable declarations that start on their own line (hopefully to
speed things up a bit).

svn path=/trunk/; revision=35929
2011-02-12 03:53:29 +00:00
Jeff Morriss ba3f31d873 Register an ett_ variable.
svn path=/trunk/; revision=35928
2011-02-12 03:52:05 +00:00
Jeff Morriss 21cf6ff3ce Remove an unused ett_ variable.
svn path=/trunk/; revision=35927
2011-02-12 03:51:12 +00:00
Stephen Fisher a29a04f112 Traditional GtkTooltips deprecated at GTK+ 2.14 (and removed in 3.0), so
use the new functions when available. 


svn path=/trunk/; revision=35926
2011-02-12 00:27:47 +00:00
Jeff Morriss e13389a2b7 Add a function to verify that ett_ variables are registered (or at least
stored in an array which will hopefully be registered).

This is a work-in-progress, so the function is not called.

It is also EXTREMELY slow on big files.  (Or maybe it's looping...
I haven't yet had the patience to let it finish processing packet-rrc.c .)

svn path=/trunk/; revision=35923
2011-02-11 22:44:29 +00:00
Jeff Morriss e92dd56b71 Register a bunch of ett_ variables.
Use gint (instead of int) for ett_ variables (for consistency only).

svn path=/trunk/; revision=35922
2011-02-11 21:27:46 +00:00
Anders Broman 5fbe65d670 Update 8.12 Indication IE to 3GPP TS 29.274 version 9.4.0 Release 9
svn path=/trunk/; revision=35921
2011-02-11 21:21:45 +00:00
Jeff Morriss 947ca59731 Register a couple of ett_ variables.
Move the declaration of all the ett_ variables after the hf_ variables
(instead of in between some of them).

svn path=/trunk/; revision=35920
2011-02-11 21:15:41 +00:00
Jeff Morriss fc45d04c22 Register a couple ett_ variables. Declare all the ett_ variables together.
svn path=/trunk/; revision=35919
2011-02-11 21:13:38 +00:00
Stephen Fisher 5e5aa3c09e Add a command line argument for the configure script of "--with-gtk3" to
attempt to compile against GTK+ 3.0 (which can be installed at the same
time as GTK+ 2.0).  Also place a copy of the autoconf macro for finding
GTK+ 3.0 in the aclocal-fallback directory taken from the GTK+ 3.0
distribution.

(Note: Wireshark won't finish compiling with GTK+ 3.0 yet...)


svn path=/trunk/; revision=35918
2011-02-11 20:21:32 +00:00
Stephen Fisher 1b2f2426e0 Remove #ifndef GSEAL_ENABLE hack to work-around the lack of an accessor
for a GSEALed variable since GTK 3.0 is out, which has the accessor.


svn path=/trunk/; revision=35917
2011-02-11 18:28:55 +00:00
Guy Harris ab15a35f65 Don't assume we're on port 631.
svn path=/trunk/; revision=35916
2011-02-11 09:28:05 +00:00
Jaap Keuter ff7eeffdb9 From Joe McEachern:
Add support the 6RD DHCP option defined in RFC 5969.

svn path=/trunk/; revision=35915
2011-02-11 08:00:21 +00:00
Guy Harris 0d9152e782 Register for the media type "application/ipp", so *any* HTTP request or
response with that content type will be dissected as IPP.

svn path=/trunk/; revision=35914
2011-02-11 05:54:34 +00:00
Jeff Morriss be81bc949a Rename arphrdaddr_to_str() to tvb_arphrdaddr_to_str() and make it take a pointer a TVB
and an offset instead of (generally) a pointer into a TVB.

svn path=/trunk/; revision=35913
2011-02-11 03:33:11 +00:00
Jeff Morriss 0f59bc7c45 Rename vines_to_str() to tvb_vines_to_str() and make it take a pointer a TVB
and an offset instead of (generally) a pointer into a TVB.

Move most of the contents of packet-vines.h into packet-vines.c: the moved
content is only needed in that file.

svn path=/trunk/; revision=35912
2011-02-11 03:13:24 +00:00
Jeff Morriss d8659693ef Check for places where tvb_bytes_to_str() or tvb_get_bytes_to_str_punct()
should be used (instead of the non-tvb functions with a call to tvb_get_ptr()).

Use those functions in a bunch of places.

svn path=/trunk/; revision=35911
2011-02-11 02:43:07 +00:00
Jeff Morriss 8d03f63e17 Oops, put a comma back
svn path=/trunk/; revision=35910
2011-02-11 02:29:45 +00:00
Jeff Morriss 1a0287a486 Clean up indentation
svn path=/trunk/; revision=35909
2011-02-11 02:27:33 +00:00
Martin Mathieson f30d00e00a Show subheaders summary in subheader root item.
svn path=/trunk/; revision=35908
2011-02-11 00:29:40 +00:00
Jeff Morriss fddb50a582 Document that proto_tree_add_bytes_format() and
proto_tree_add_bytes_format_value() may be given a NULL value_ptr.


svn path=/trunk/; revision=35907
2011-02-10 22:57:50 +00:00
Jeff Morriss 7be63e199b Add (commented-out for now) code to check certain function calls for embedded
(in the argument list) calls to tvb_get_ptr().

svn path=/trunk/; revision=35906
2011-02-10 22:53:48 +00:00
Jeff Morriss b1d4ef8851 Use tvb_ip_to_str() and tvb_ether_to_str().
svn path=/trunk/; revision=35905
2011-02-10 22:14:05 +00:00
Jeff Morriss b58b5b5c67 Pass NULL as the value_ptr to proto_tree_add_bytes_format().
Simplify the code a bit since tvb_ensure_bytes_exist() was already throwing
an exception if all the bytes weren't there.

Use tvb_ether_to_str().

svn path=/trunk/; revision=35904
2011-02-10 22:07:29 +00:00
Anders Broman 61515ab830 From Alexis La Goutte:
Cleanup 802.11 Dissector :Enhance SSID, Supported Rates, DS, FH, CFP.. Information Element sub dissector 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660

svn path=/trunk/; revision=35903
2011-02-10 21:45:36 +00:00
Chris Maynard 8d47cebd00 Declare ett's as gint, not guint.
svn path=/trunk/; revision=35902
2011-02-10 20:55:26 +00:00
Guy Harris e2bdef175d Add the rest of the changes from the patch in bug 5924. Squelches some
compiler warnings.

svn path=/trunk/; revision=35901
2011-02-10 20:27:35 +00:00
Gerald Combs ceb650ecee #ifdef → #ifndef.
svn path=/trunk/; revision=35900
2011-02-10 20:15:31 +00:00
Gerald Combs 66281f8744 Mark a parameter unused if needed.
svn path=/trunk/; revision=35899
2011-02-10 19:50:05 +00:00
Guy Harris d63741d566 Add some information based on a Tektronix manual whose name popped up in
an email I found when looking for some other stuff and which I then
found with a Google search.

svn path=/trunk/; revision=35898
2011-02-10 18:27:39 +00:00