Martin Mathieson
7e88a07e71
proto_item_append_string() doesn't work this case, so stop using it.
...
I am tempted though to chage proto_item_append_string() just be like
proto_item_append_text() without the call to g_vsnprintf(), which is the
expensize part I was hoping to avoid.
svn path=/trunk/; revision=44614
2012-08-22 19:01:01 +00:00
Martin Mathieson
1470f4a6b7
Call proto_item_append_string() rather than proto_item_append_text()
...
when there are no specifiers.
svn path=/trunk/; revision=44609
2012-08-21 21:36:59 +00:00
Martin Mathieson
973be664bb
Use proto_item_append_string() rather than proto_item_append_text() with
...
%s.
svn path=/trunk/; revision=44606
2012-08-21 17:12:13 +00:00
Martin Mathieson
1d1cc74e93
Zero a struct to avoid branching based upon uninitialised fields
...
(previousFrameNum & nextFrameNum). Spotted by valgrind.
svn path=/trunk/; revision=44017
2012-07-25 22:02:29 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Guy Harris
15ee6468e8
packet-umts_fp.h now requires epan/conversation.h.
...
svn path=/trunk/; revision=42468
2012-05-07 17:04:41 +00:00
Martin Mathieson
b9677f575c
Avoid needlessly shadowing a variable. From Visual Studio Analyzer.
...
svn path=/trunk/; revision=42326
2012-04-28 23:14:54 +00:00
Martin Mathieson
2fc3322e82
Trivial formatting: Show segment offsets/length closer to associated sequence number
...
in partial NACK.
svn path=/trunk/; revision=41723
2012-03-21 13:53:18 +00:00
Martin Mathieson
5a84afd814
Within a status report, check that NACK_SNs are not 'ahead' of ACK_SN.
...
svn path=/trunk/; revision=41493
2012-03-11 23:44:03 +00:00
Martin Mathieson
e06cb4430c
Put UM and AM extension headers inside the header tree.
...
svn path=/trunk/; revision=41431
2012-03-08 11:08:17 +00:00
Martin Mathieson
2f6990550b
Write UEID to info column using left-justified, fixed width.
...
svn path=/trunk/; revision=41430
2012-03-08 10:59:49 +00:00
Martin Mathieson
d5f0b50647
Show number of extensions in header root.
...
svn path=/trunk/; revision=41229
2012-02-28 19:01:24 +00:00
Martin Mathieson
1b42caf3b3
Add a link back to previous frame for UM sequence number analysis.
...
Change a couple of filter names to use "-" rather than "_". Update
stats window to use changed filter name.
svn path=/trunk/; revision=40822
2012-02-03 10:42:01 +00:00
Martin Mathieson
13316398dd
Use bitfields to make channel_hash_key struct fit into one word.
...
svn path=/trunk/; revision=40683
2012-01-24 03:05:21 +00:00
Martin Mathieson
7e5f6d9fc1
PDCP:
...
- Pass is_retx flag to PDCP from RLC in struct instead of calling function
RLC:
- use full key to look up sequence analysis results
- avoids overwriting and attaching result details to wrong PDU
- add links to previous and next 'OK' PDUs in channel
- shorten some long variable and type names.
svn path=/trunk/; revision=40656
2012-01-23 02:36:46 +00:00
Martin Mathieson
02e8a91a35
Various small tweaks to sequence analysis/re-assembly, plus implement
...
function to check for a frame being a retx as used by pdcp.
svn path=/trunk/; revision=40648
2012-01-22 02:55:47 +00:00
Bill Meier
439adbdbcc
Remove obsolete comments referring to mem_chunks.
...
svn path=/trunk/; revision=40507
2012-01-14 20:14:43 +00:00
Bill Meier
4756f41771
Fix tvb memory leak; Also: For a "packet-lifetime" tvb use ep_alloc'd (not se_alloc'd) memory.
...
svn path=/trunk/; revision=40230
2011-12-16 17:33:09 +00:00
Martin Mathieson
e9608da9c8
From Pascal Quantin:
...
Show SDU lengths for UM PDUs.
Also, if the logged pduLength is < the real RLC PDU length, show that the length of the last segment is unknown.
svn path=/trunk/; revision=40067
2011-12-01 23:17:17 +00:00
Martin Mathieson
ee5bfb35a3
When have RLC PDUs that are truncated after headers:
...
- set extent of headers item properly
- show in the info column what the data would look like, based upon reported length and segment offsets
svn path=/trunk/; revision=40062
2011-12-01 13:53:09 +00:00
Martin Mathieson
20019f77ed
Only add the priority level if it is set inside valid range.
...
svn path=/trunk/; revision=39997
2011-11-24 12:44:11 +00:00
Bill Meier
30cee99009
Fix a number of proto_tree_add_item() encoding args.
...
svn path=/trunk/; revision=39774
2011-11-09 17:33:18 +00:00
Bill Meier
54b72021bb
Fix encoding arg for various fcn calls:
...
- proto_tree_add_bits_item
- proto_tree_add_bits_ret_val
- proto_tree_add_bitmask
- tvb_get_bits
- tvb_get_bits16
- tvb_get_bits24
- tvb_get_bits32
- tvb_get_bits64
svn path=/trunk/; revision=39539
2011-10-24 19:57:53 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
126aa85393
Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
...
1. If there's no character encoding (ENC_ASCII, ...) specified
then use ENC_ASCII.
2. For all but FT_UINT_STRING, always use ENC_NA
(replacing any existing True/1/FALSE/0
/ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).
svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier
4e57694d4a
Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
...
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Bill Meier
94f36ca4ff
Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
...
FT_NONE
FT_BYTES
FT_IPV6
FT_IPXNET
FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Martin Mathieson
4a3d86e46c
Be careful about reporting number of missing SNs when wrapping around SN range.
...
svn path=/trunk/; revision=39088
2011-09-22 15:28:46 +00:00
Bill Meier
d4a982fd1f
Use '%" G_GINT64_MODIFIER "u' iso '%llu'. Fixes checkapi fail and (presumably) compile errors.
...
svn path=/trunk/; revision=39083
2011-09-21 21:07:07 +00:00
Martin Mathieson
d41594e01b
Report as expert/malformed if the same SN appears as ACK and NACK in same status PDU.
...
svn path=/trunk/; revision=39077
2011-09-21 16:45:03 +00:00
Martin Mathieson
f220deb9a3
Update some comments.
...
svn path=/trunk/; revision=38960
2011-09-10 23:46:49 +00:00
Martin Mathieson
71cb9d69d2
Use correct hf item, and add reassembled length into subtree summary.
...
svn path=/trunk/; revision=38896
2011-09-06 13:18:26 +00:00
Martin Mathieson
0cd1b811af
First stab at RLC re-assembly.
...
svn path=/trunk/; revision=38895
2011-09-06 12:01:28 +00:00
Martin Mathieson
ca126bace5
Don't attach sequence analysis results to control/data PDUs when not appropriate. The problem is that I use the frame number in the result hash table - I may end up adding more info (e.g. channel, SN) to further avoid attaching reports to wrong PDUs.
...
svn path=/trunk/; revision=38208
2011-07-26 10:16:02 +00:00
Martin Mathieson
7d7f7d870e
Register nicer entry points for LTE RRC BCH messages, and use them in RLC, MAC, PDCP.
...
svn path=/trunk/; revision=38131
2011-07-20 12:19:22 +00:00
Martin Mathieson
049643cf28
From Pradip Biswas, bug 6127 - Added Decode for RRC BCCH (BCH and DL_SCH) messages on RLC-over-UDP.
...
Add separate codes/cases for BCH-over-BCH and BCH-over-DLSCH.
svn path=/trunk/; revision=38115
2011-07-19 16:41:56 +00:00
Martin Mathieson
3f3fde986f
Add a generated field for the number of NACKs in an AM status PDU.
...
svn path=/trunk/; revision=38076
2011-07-18 10:40:57 +00:00
Martin Mathieson
5f95d18d59
Some fixes to UM sequence analysis.
...
svn path=/trunk/; revision=37729
2011-06-20 08:55:51 +00:00
Martin Mathieson
5d78458e4b
Fix a typo (spotted by Pascal Quantin).
...
svn path=/trunk/; revision=37622
2011-06-08 17:10:40 +00:00
Martin Mathieson
cb78939ede
Pass tap info into sequence analysis function.
...
svn path=/trunk/; revision=37368
2011-05-23 17:15:00 +00:00
Martin Mathieson
002b0e16ed
Improve AM sequence analysis, check ACK looks sensible compared with latest SN received in opposite direction.
...
svn path=/trunk/; revision=37272
2011-05-19 01:05:26 +00:00
Jakub Zawadzki
ed59c450f4
Cleanup: replace se_alloc+memcpy combo with single se_memdup().
...
svn path=/trunk/; revision=36996
2011-05-05 06:55:12 +00:00
Martin Mathieson
16cb326768
Allow signaling protocol (e.g. RRC) to set number of SN bits
...
PDCP should use for DRB channels.
Not yet called by RRC.
svn path=/trunk/; revision=36692
2011-04-17 21:34:47 +00:00
Martin Mathieson
deac0b8af4
Show Segment offset number in AM header root item.
...
svn path=/trunk/; revision=36565
2011-04-11 21:34:47 +00:00
Martin Mathieson
5344e9f3d9
Take care not to append RLC mode to proto_item twice.
...
svn path=/trunk/; revision=36429
2011-04-01 13:41:08 +00:00
Martin Mathieson
b138ffa9e7
Avoid some unnecessary assignments (as reported by clang).
...
svn path=/trunk/; revision=36204
2011-03-16 23:18:59 +00:00
Martin Mathieson
4d3d029e09
Remove some instances of _U_ where the parameter is now used.
...
svn path=/trunk/; revision=36148
2011-03-06 23:10:28 +00:00
Martin Mathieson
ee5202f2d8
When doing sequence analysis, allow for the first SN to be seen not to be 0.
...
This will happen if the capture doesn't include the start of this channel.
svn path=/trunk/; revision=36091
2011-02-28 12:26:26 +00:00
Gerald Combs
aaeca955a5
Try to fix more Clang scan-build warnings.
...
svn path=/trunk/; revision=36005
2011-02-18 21:44:06 +00:00
Martin Mathieson
6b4acef729
Allow PDCP dissector to be called for complete SDUs from UM RLC PDUs.
...
svn path=/trunk/; revision=35775
2011-02-02 23:23:07 +00:00