Commit graph

9209 commits

Author SHA1 Message Date
Guy Harris
5e33fbf97b From Michael Lum: fix the usage message to say "-z", not "-Z".
svn path=/trunk/; revision=9104
2003-11-27 22:04:02 +00:00
Guy Harris
7b3a7c3a94 From Arsen Chaloyan: fix offsets in "proto_tree_add" calls.
svn path=/trunk/; revision=9103
2003-11-27 21:20:47 +00:00
Guy Harris
254f2f790b From Erwin Rol: RTCFG support.
Add in a URL to the RTNET home page.

svn path=/trunk/; revision=9102
2003-11-27 21:09:43 +00:00
Guy Harris
b2c0b30ff9 From David Fort: fix to previous patch.
svn path=/trunk/; revision=9101
2003-11-27 21:02:34 +00:00
Ulf Lamping
ad6b446228 Redesign of the whole menu structure, to be more intuitive to the user and
conforms somewhat better to the Gnome Human Interface Guideline

svn path=/trunk/; revision=9100
2003-11-27 20:34:01 +00:00
Ulf Lamping
ba2b942138 bugfix: removed access violation when using "File/Print Packet".
The label_ptr could be NULL, when calling function print_line

svn path=/trunk/; revision=9099
2003-11-27 17:18:13 +00:00
Ulf Lamping
2cd8629c86 using text files from help dir, to display the help texts.
the "dynamic protocol fields" are already moved to gtk/supported_protos_dlg.c

svn path=/trunk/; revision=9098
2003-11-27 00:22:12 +00:00
Ulf Lamping
4c5b5d8d51 Added this intermediate files, until a Makfile.am is available for unix systems
svn path=/trunk/; revision=9097
2003-11-27 00:17:12 +00:00
Guy Harris
ff5569c895 From David Fort: DNS DSS RR support.
svn path=/trunk/; revision=9096
2003-11-26 23:23:37 +00:00
Ronnie Sahlberg
eb39a99b2c Speed updates
create generic macros for allocating/freeing structures.

remove one more slow GMemChunk and replace it with a simple linked list

~4% speed improvement in my tests.

the allocated data is never freed.   this may be a problem if ethereal is
ever supported on a platform lacking resource tracking but makes the
implementation faster and simpler.

svn path=/trunk/; revision=9095
2003-11-26 12:22:22 +00:00
Guy Harris
d525d957e4 From Patrick Kursawe: rename "getline()" so it doesn't collide with the
"getline()" declared in <stdio.h> with recent versions of glibc.

Fix a typo in the AUTHORS file.

svn path=/trunk/; revision=9094
2003-11-26 02:58:12 +00:00
Guy Harris
d792460eac From Jaime Fournier: fix a typo.
svn path=/trunk/; revision=9093
2003-11-26 02:54:05 +00:00
Guy Harris
ade7d05cdf From Reinhard Speyerer: handle 10-digit UCP dates, which lack a seconds
value.

svn path=/trunk/; revision=9092
2003-11-25 20:26:40 +00:00
Guy Harris
26d021d8eb As with fvalue_t, so with field_info and item_label - the individual
items aren't individually g_mallocated and can't be g_freed, only the
chunks can.

svn path=/trunk/; revision=9091
2003-11-25 20:02:42 +00:00
Guy Harris
06f204843e Individual fvalue_t's aren't individually allocated with "g_malloc()",
so they can't be freed with "g_free()"; keep a list of the chunks of
"fvalue_t"s, which are whare are allocated with "g_malloc()", so we can
free them all.

svn path=/trunk/; revision=9090
2003-11-25 19:25:31 +00:00
Guy Harris
3dd28656ba From Anders Broman: add more SIP headers, and the PUBLISH method.
svn path=/trunk/; revision=9089
2003-11-25 18:02:57 +00:00
Ronnie Sahlberg
06ed59a1ec replace free_node_field_info with a macro since it is only called from one other place in the code and this reduces one unnecessary function call overhead.
and it makes ethereal ~1% faster.

svn path=/trunk/; revision=9088
2003-11-25 14:16:30 +00:00
Ronnie Sahlberg
c68fddc5e1 rename FREE_FIELD_INFO to FIELD_INFO_FREE for consistency
svn path=/trunk/; revision=9087
2003-11-25 14:11:44 +00:00
Ronnie Sahlberg
fec720051f create a FIELD_INFO_NEW for consistency
svn path=/trunk/; revision=9086
2003-11-25 14:10:27 +00:00
Ronnie Sahlberg
9d88e58e51 remove another slow GMemChunk from ethereal making ethereal a little bit faster
svn path=/trunk/; revision=9085
2003-11-25 14:07:45 +00:00
Ronnie Sahlberg
04d07e6578 change free_field_info to FREE_FIELD_INFO to indicate it is a macro and not a function
svn path=/trunk/; revision=9084
2003-11-25 13:23:10 +00:00
Ronnie Sahlberg
4f84e65c50 fvalue_free() is one of the most called functions.
This function is also very small, so small that teh overhead for the actual function call and return is likely to be a significant part
of its execution time.

change it into a macro and make it thus slightly faster by eliminating the function call overhead.

svn path=/trunk/; revision=9083
2003-11-25 13:20:36 +00:00
Ronnie Sahlberg
0bf28e51af Change the handling of temporary allocation of fvalue_t structures to be faster.
Use a similar technique as was used in epan/proto.c to speed up the field_info
allocation/deallocation routines

svn path=/trunk/; revision=9082
2003-11-25 08:50:38 +00:00
Guy Harris
186bd3bab6 From Jaime Fournier: show the RPC version of the unknown interface in
the Info column.

svn path=/trunk/; revision=9081
2003-11-25 08:19:33 +00:00
Guy Harris
ff797aaf4a From Jamie Fournier: DCE RPC EPM version 4 support, and stub support for
BUDB, ICL RPC, and RS_PROP_ACCT DCE RPC-based protocols.

svn path=/trunk/; revision=9080
2003-11-25 08:10:57 +00:00
Guy Harris
e3f791ebea "file_seek()" sets "*err" - we don't have to set it ourselves.
The same is true of "parse_cosine_rec_hdr()".

svn path=/trunk/; revision=9079
2003-11-25 05:58:56 +00:00
Guy Harris
6939f62da0 "file_seek()" sets "*err" - there's no need to set it ourselves. It
returns -1 on errors, so just check for that.

svn path=/trunk/; revision=9078
2003-11-25 05:56:16 +00:00
Guy Harris
ff9ac52735 Fix a typo.
svn path=/trunk/; revision=9077
2003-11-25 00:21:06 +00:00
Guy Harris
9c8b8819b8 Eliminate compiler warnings.
svn path=/trunk/; revision=9076
2003-11-24 23:46:06 +00:00
Guy Harris
122dd3959c Make the recent epan/proto.{c,h} change compile.
svn path=/trunk/; revision=9075
2003-11-24 22:11:55 +00:00
Guy Harris
2e94fc8139 Preserve 62 as an (old) IP protocol type for mobility headers.
svn path=/trunk/; revision=9074
2003-11-24 21:42:13 +00:00
Ronnie Sahlberg
fa1ee7667b performance enhancement to proto.c
Removed the GMemChunk used to allocate/free field_info structures
and used a free list to store the freed structs until they are allocated again.

Ethereal will allocate more field_info structs as it needs to but never free them. Instead the are just placed in a cheap and fast free list so that if we
want to use the struct again, this will be fast.

This affects the speed of the two functions
alloc_field_info() that should be slightly faster now
free_field_info() that was replaced with a 2 line macro.

All in all  my testing suggests that ethereal is 2-3% faster with this patch.

svn path=/trunk/; revision=9073
2003-11-24 21:12:10 +00:00
Ulf Lamping
a24a6b7a37 bugfix: corrected clean and distclean targets
svn path=/trunk/; revision=9072
2003-11-24 17:41:33 +00:00
Guy Harris
0367782acf From Scott Hovis :CCSDS (Consultative Committee for Space Data Systems)
support.

svn path=/trunk/; revision=9071
2003-11-24 00:34:13 +00:00
Guy Harris
b0e8631b55 From Anders Broman: fix dissection of GRS/GRA messages.
svn path=/trunk/; revision=9070
2003-11-24 00:05:09 +00:00
Guy Harris
794858f6bf Include the BFD dissector when building with MSVC++.
svn path=/trunk/; revision=9069
2003-11-23 23:42:46 +00:00
Gerald Combs
807458f7e1 From Hannes Gredler: Add support for Bi-directional Fault Detection (BFD).
svn path=/trunk/; revision=9068
2003-11-23 22:00:48 +00:00
Jörg Mayer
56e66f0293 - Bugfix: Passworddecoding should only be done for attribute 2, but
not for VSA 2
- Fixme comment about length handling added
- Cleanup: Setting a variable to the right type removes the necessity
          for casts.

svn path=/trunk/; revision=9067
2003-11-22 12:02:49 +00:00
Ronnie Sahlberg
058e84ff14 Change the way signalType is dissected to be
compatible with and dissect the packets from Martin R and Paul H.

I still think ethereal was correct before this patch and that
this patch is not compatible with teh standard.
Anyway, that doesnt matter much. With this patch ethereal will dissect the packets properly.
Time to study x691 again.

svn path=/trunk/; revision=9066
2003-11-22 11:12:19 +00:00
Guy Harris
262f77330a From Martti Kuparinen: use correct values for Mobile IPv6.
svn path=/trunk/; revision=9065
2003-11-22 08:35:45 +00:00
Ronnie Sahlberg
ac1608f3c6 As per Guys suggestion, continue optimizing proto.c to macroize it
and make it even faster

svn path=/trunk/; revision=9064
2003-11-22 04:41:31 +00:00
Guy Harris
6768aefac8 From Olivier Biot: fix up the description of the
"port_number_udh_means_wsp" preference.

svn path=/trunk/; revision=9063
2003-11-21 22:18:30 +00:00
Guy Harris
05ad6d03d4 From Olivier Biot:
* Fix the WSP dissector so a Quoted-string with extraneous
	  trailing quote is displayed without duplicated final quote, and
	  issue a warning in the protocol tree.
	* Remove the Openwave x-up-proxy-client-id header decoding as it
	  was incorrectly decoded as a text string, and process it with
	  the default Openwave header parser.
	* Fix byte highlighting of some WSP parameters.
	* Rename the WSP parameter filter names so they don't all refer to
	  content_type.

svn path=/trunk/; revision=9062
2003-11-21 22:00:25 +00:00
Guy Harris
364261f0ad From Olivier Biot:
* Add a "match_string" field to the "packet_info" structure,
	  saving the string value that matched in a string dissector
	  lookup, by analogy to "match_port" - this was required for
	  dissection with token rendering of WBXML content when no public
	  ID was given (e.g. Nokia/Ericsson OTA provisioning data).
	* Add support for textual content type based WBXML token
	  mapping.
	* Add extra WBXML public identifiers.
	* Add the Nokia/Ericsson OTA provisioning (version 7) token
	  definitions.
	* Inform the user when a content-type based token match is found.

svn path=/trunk/; revision=9061
2003-11-21 21:58:55 +00:00
Guy Harris
8796847f64 From Eric Wedel: fix dissection of NetServerDiskEnum reply.
svn path=/trunk/; revision=9060
2003-11-21 21:33:44 +00:00
Guy Harris
50917e1ead From Lars Ruoff: use the pointer to the RTP payload, rather than
extracting the data from the frame directly.

svn path=/trunk/; revision=9059
2003-11-21 19:24:00 +00:00
Ronnie Sahlberg
7eef1914e0 Performance fix
In the GPROF logs proto_registrar_get_nth() used to take anything between 2.5 and 5.5% of the time.

Replace the GLIB array with a handroleld one for one of the private structures.

the function should now be virtually zero cost
and thus ethereal should be 2.5-5.5% faster on those traces.

anyone that wants to, please rerun GPROF with this fix and see what has changed.

svn path=/trunk/; revision=9058
2003-11-21 14:58:49 +00:00
Guy Harris
809cc0c765 A "handle_t" as the first argument to a call doesn't seem to be sent
over the wire, at least in the DCE RPC 1.1 code.

That suggests that the first 24 bytes of a Map request are the UUID
pointer that the EPM IDL says should be there, not a context handle.

svn path=/trunk/; revision=9057
2003-11-21 08:40:00 +00:00
Guy Harris
27fdd16f4e Maybe the problem is that the compilers used on AIX weren't defining
"AIX", and that code was never compiled.  Libpcap uses "_AIX" to
conditionally compile in the extra AIX BPF support; we'll do the same.

svn path=/trunk/; revision=9056
2003-11-21 08:33:49 +00:00
Guy Harris
23c4738618 Pass "strncmp()" the right number of arguments. (Why hasn't anybody
reported this as a problem when compiling on AIX?  Doesn't any compiler
complain that "strncmp()" isn't being passed enough arguments?  GCC sure
did in a test program I built on FreeBSD 3.4....)

svn path=/trunk/; revision=9055
2003-11-21 08:30:40 +00:00