Commit graph

9209 commits

Author SHA1 Message Date
Guy Harris
95f25d46c1 "strtoul()" returns a "long", not a "long long".
svn path=/trunk/; revision=9154
2003-12-03 19:47:36 +00:00
Ronnie Sahlberg
9c14c51834 Replace two expensive macros with a much simpler mechanism
to prevent memory leaks due to exceptions.

makes my tethereal testcase ~1% faster.

svn path=/trunk/; revision=9153
2003-12-03 10:14:34 +00:00
Ronnie Sahlberg
5ff0237060 performance update
replace tvb_raw_offset() which is essentially a simple assignment and which
is called a lot with a macro.

this makes my tethereal testcase 2-3% faster.

svn path=/trunk/; revision=9152
2003-12-03 09:50:40 +00:00
Guy Harris
dcd98ae8d3 The "ptr_u" unions no longer have a "next" pointer - they now just have
one member - or have one that's not used, so get rid of those unions.

svn path=/trunk/; revision=9151
2003-12-03 09:28:26 +00:00
Guy Harris
ed2ae2d8d3 Instead of requiring slab-allocated structures to have a "next" pointer,
when adding them to the free list, cast the pointer to the structure to
a pointer to a "freed_item_t" which contains the "next" pointer.

This reduces the memory requirement for some of those structures, and
leaves us free to slab-allocate structures that have a "next" pointer
for other reasons.

svn path=/trunk/; revision=9150
2003-12-03 08:53:37 +00:00
Ronnie Sahlberg
e4b6c50461 Update to SMB ReadAndX replies.
There might be a 4 (not 2) byte datalen high field.
If there is no such field (due to an early dialect being used) these bytes are often 0xff.
If these four bytes are all 0xff    dont display them in the tree.

svn path=/trunk/; revision=9149
2003-12-03 08:43:59 +00:00
Guy Harris
4740a3ae15 Bring it up to date.
svn path=/trunk/; revision=9148
2003-12-03 07:46:34 +00:00
Guy Harris
0c84e1c329 From Didier Gautheron: for each column format type, save the first and
last columns, if any, with that format, and use that to speed up
processing of columns with a particular format and checking whether
we're displaying a column with a particular format.

svn path=/trunk/; revision=9147
2003-12-02 23:14:32 +00:00
Guy Harris
bd9f96738c From Didier Gautheron: put an "fvalue_t" structure into a "field_info"
structure, rather than separately allocating "fvalue_t"s and having the
"field_info" structure point to them - this appears to speed up protocol
tree construction a bit.

svn path=/trunk/; revision=9146
2003-12-02 21:15:49 +00:00
Guy Harris
98c4d5d030 Check for errors and EOF, and handle them appropriately; don't treat all
errors when reading the header as indications that the file isn't an
AiroPeek V9 file.

Put in comments nothing some additional checks we should do.

svn path=/trunk/; revision=9145
2003-12-02 20:27:14 +00:00
Guy Harris
fe73d8e3b6 From Martijn Schipper: support for reading AiroPeek files in V9 capture
file format (AiroPeek 2.x).

svn path=/trunk/; revision=9144
2003-12-02 19:37:05 +00:00
Guy Harris
37b5a4786f Tomas Kukosa noted that the TPKT dissector spends a significant amount
of time in "find_protocol_by_id()"; the protocol_t pointer for a
protocol doesn't change over time, so get that pointer when the protocol
is registered and save it.

svn path=/trunk/; revision=9143
2003-12-02 18:50:52 +00:00
Guy Harris
c1966429fe From Yaniv Kaul:
1) fix description of Check Point version 5004;

	2) add description of Check Point version 5005.

svn path=/trunk/; revision=9142
2003-12-02 18:35:36 +00:00
Ronnie Sahlberg
bfaca0cab6 Move the definition of the tvbuff_t structure and friends to tvbuff.h
so that we can change tvb_get_ds_tvb() into a macro.

This function was a single line assignment and was called a lot.

This made tethereal ~2.5% faster in one testcase I use.

svn path=/trunk/; revision=9141
2003-12-02 10:23:18 +00:00
Ronnie Sahlberg
266b5a4b2e Use the LSAB_ALLOC and SLAB_FREE macros to allocate/free fvalue_t data
svn path=/trunk/; revision=9140
2003-12-02 09:47:23 +00:00
Ronnie Sahlberg
917c9da95e Moving SLAB_ALLOC and SLAB_FREE to its own header file
svn path=/trunk/; revision=9139
2003-12-02 09:11:16 +00:00
Guy Harris
77ae9aa55a From Arnaud Jacques: fix a typo, and handle another CheckPoint version
number.

svn path=/trunk/; revision=9138
2003-12-02 09:05:10 +00:00
Guy Harris
f2fb3130b4 From Dave Sclarsky:
Correct several problems with zoneset decodes (e.g.  the zoneset
	and zone name lengths do *not* include the pad bytes, so the
	offset calculation needed to be fixed).

	Move the decode of zoneset name into the routine
	"dissect_fcfzs_zoneset", so that it is done in only one place.

svn path=/trunk/; revision=9137
2003-12-02 06:06:30 +00:00
Guy Harris
089911a0e4 Don't call the presentation layer dissector if we don't have a handle
for it.

svn path=/trunk/; revision=9136
2003-12-02 05:53:26 +00:00
Guy Harris
87561392ef From Michael Lum: don't register the handoff routine for dissectors as a
preference change callback if the ports they register on aren't
preferences.

svn path=/trunk/; revision=9135
2003-12-02 02:58:32 +00:00
Guy Harris
f549d46c37 From Tomas Kukosa: add "decode_enumerated_bitfield_shifted()", which is
like "decode_enumerated_bitfield()" but handles value_string tables
containing values as they appear in the bitfield rather than as they
appear in the item containing the bitfield.

svn path=/trunk/; revision=9134
2003-12-01 23:42:32 +00:00
Guy Harris
00fbb88229 From Michael Lum: add a preference setting to specify the parameter tag
for "Protocol Data 1", as it changed between draft 7 and RFC 3331.

svn path=/trunk/; revision=9133
2003-12-01 23:26:40 +00:00
Guy Harris
ad0107ddf4 From Michael Lum:
add a message statistics tap for ANSI A interface for Tethereal;

	fix the BSSAP, BSMAP, and DTAP interface dissectors to call
	subdissectors even if no protocol tree is being built.

svn path=/trunk/; revision=9132
2003-12-01 23:05:09 +00:00
Guy Harris
42718f60b4 From Michael Lum: add a heuristic RANAP dissector, for use atop SCCP, as
the SCCP dissector currently doesn't support conversations to be given
dissectors.

svn path=/trunk/; revision=9131
2003-12-01 22:25:32 +00:00
Gerald Combs
4306925479 Don't automatically fill in a capture filter if CLIENTNAME is set to
"Console".

svn path=/trunk/; revision=9130
2003-12-01 20:27:09 +00:00
Gerald Combs
9e396b2e9e Updates for new zlib.
svn path=/trunk/; revision=9129
2003-12-01 17:25:23 +00:00
Gerald Combs
31fca6e9da Switch from zlib.dll to zlib1.dll.
svn path=/trunk/; revision=9128
2003-12-01 17:19:09 +00:00
Gerald Combs
7569aef3df Switch to the new (and official) zlib DLL from www.gzip.org.
svn path=/trunk/; revision=9127
2003-12-01 17:17:51 +00:00
Richard Sharpe
da672d6f17 It's RedHat, not Red Hat.
svn path=/trunk/; revision=9126
2003-12-01 06:59:10 +00:00
Guy Harris
bb0eb4879f "select_file_cb()" only needs a title, not a "construct_args_t" -
"construct_args_t" is for use with filter dialogs, and the members other
than the title apply only to filter dialogs.

Have "select_file_cb()" actually use the title supplied to it.

svn path=/trunk/; revision=9125
2003-12-01 02:01:56 +00:00
Richard Sharpe
a168545845 Fix the accelerator issue ...
svn path=/trunk/; revision=9124
2003-12-01 01:57:14 +00:00
Guy Harris
971d7e3816 Not all platforms have <unistd.h> - in particular, Windows doesn't.
If you're using "open()", "close()", "read()", "write()", etc., you
should include <io.h> on Windows.

svn path=/trunk/; revision=9123
2003-11-30 23:05:45 +00:00
Richard Sharpe
fc6c270c4b Fix some warnings in proto_draw.c
svn path=/trunk/; revision=9122
2003-11-30 18:01:20 +00:00
Richard Sharpe
45f226fc2c Rename that to Save Highlighted with Ctl-H as the accellerator.
svn path=/trunk/; revision=9121
2003-11-30 04:40:19 +00:00
Richard Sharpe
d9cb6a9d64 Add Save Selected as a menu item in the File Menu.
This still has a way to go, though, because the menu item should be greyed out
until something is Highlighted.

svn path=/trunk/; revision=9120
2003-11-30 04:37:50 +00:00
Richard Sharpe
114c52bf0b Move print_file_cb out of gtk/print_dlg.c and into gtk/file_dlg.c and
rename it to select_file_cb to reflect its function.

While this cleans things up a bit, I am still not happy because now
filter_prefs.h must be included before file_dlg.h just to get
construct_args_t.

svn path=/trunk/; revision=9119
2003-11-30 04:21:55 +00:00
Jörg Mayer
42625e6aae Fix two small typos
svn path=/trunk/; revision=9118
2003-11-29 12:34:33 +00:00
Richard Sharpe
fa68b4af87 Properly capitalize the string for the menu item.
svn path=/trunk/; revision=9117
2003-11-29 06:15:05 +00:00
Richard Sharpe
02087e332f Add an entry in the byte_view pane that allows the user to save the highlighted
data to a file. This allows the user to select some stuff, and analyse it with
external tools, and is very useful for quickly prototying dissectors etc.

This works by retrieving the info that is needed to define where the selected
region is.

It puts up a dialog box that asks for the file to save in.

However, it is an ugly hack, because it reuses print_file_cb, while
print_file_cb should be moved into file_dlg.c.

It also needs to have some warning dialogs put up in error cases.

Finally, it would be good to be able to select a region in the byte_view,
which you can do with click and drag, and then have a menu item to save the
selected bytes.

svn path=/trunk/; revision=9116
2003-11-29 06:09:54 +00:00
Guy Harris
c344289260 From melerski [AT] poczta.onet.pl: fix a problem with unknown IEs.
svn path=/trunk/; revision=9115
2003-11-29 03:55:32 +00:00
Ulf Lamping
1ef427d649 renamed frame to packet in all GUI elements
moved "Enabled Protocols" and such
from "View" to "Analyze" toplevel menu

svn path=/trunk/; revision=9114
2003-11-28 19:13:25 +00:00
Ulf Lamping
e4037df998 renamed frame to packet in all GUI elements
svn path=/trunk/; revision=9113
2003-11-28 19:02:41 +00:00
Ulf Lamping
eb209e9438 use dlg_window_new instead of gtk_window_new
svn path=/trunk/; revision=9112
2003-11-28 19:00:28 +00:00
Ulf Lamping
390f20ea6b label changed from "Portions" to "% of total" as suggested by Guy
svn path=/trunk/; revision=9111
2003-11-28 00:44:21 +00:00
Ulf Lamping
cd01ca6cb0 using dlg_utils.c functions to catch the ESC key to close the dialog
svn path=/trunk/; revision=9110
2003-11-28 00:13:08 +00:00
Ulf Lamping
131eeab31d using dlg_utils.c functions to catch the ESC key to close the dialog
svn path=/trunk/; revision=9109
2003-11-27 23:25:55 +00:00
Guy Harris
d33d06d9a9 "representation", in an "item_label_t", is now an array, not a pointer,
so "fi->rep->representation" can't be null.

svn path=/trunk/; revision=9108
2003-11-27 22:29:52 +00:00
Guy Harris
7bed6d2087 Fix comments to correctly refer to the "-z" option.
svn path=/trunk/; revision=9107
2003-11-27 22:15:05 +00:00
Guy Harris
ef47333f2e From Michael Lum: fix the usage message to refer to "-z", not "-Z".
svn path=/trunk/; revision=9106
2003-11-27 22:14:24 +00:00
Guy Harris
41cedaa088 Show the -z flag in the usage message.
svn path=/trunk/; revision=9105
2003-11-27 22:12:18 +00:00