problems with single bit fields when declared as an enumerated field.
It shows an unknown ... Damn ... Can't see what the problem is.
svn path=/trunk/; revision=353
doesn't link with libpcap, so no packet captures can be made. The
"--disable-pcap" option has been added to the configure script. Docs
have been updated. And the string buffer size in the simple_dialog()
has been doubled so that Johan's e-mail address in the "About" dialogue
window doesn't get chopped off.
svn path=/trunk/; revision=351
returns a "guint32", which is an "unsigned int" on all platforms Glib
supports, so print what it returns with "%u", not "%lu".
svn path=/trunk/; revision=349
new proto_tree routines. I also removed the check for lex and yacc from
wiretap's configure script. The IP dissector now uses
proto_register_field_array().
svn path=/trunk/; revision=348
operators that I had thrown in at the last moment. Sorry! But I'm trying
to get rid of those embarrassing shift/reduce and reduce/reduce warnings.
I also removed wiretap/wiretap.c, which is no longer needed.
svn path=/trunk/; revision=345
mechanism that is built into ethereal. Wiretap is now used to read all
file formats. Libpcap is used only for capturing.
svn path=/trunk/; revision=342
(which could cause core dumps in "Follow TCP Stream") -
"check_fragments()" was, when deleting a TCP segment at the beginning of
the list of segments, setting "src[index]" to point to the next segment,
not "frags[index]". "src[index]" is the source IP address, not a
pointer to a fragment.
Also, make some routines not used outside "follow.c" static.
svn path=/trunk/; revision=341
returns a "guint32", which is an "unsigned int" on all platforms Glib
supports, so print what it returns with "%u", not "%lu".
svn path=/trunk/; revision=339
that you need "flex" and either "bison" or Berkeley "yacc". (XXX -
should notes such as this go in some other file, e.g. INSTALL? I
discovered the "flex" and "bison"/byacc requirement on a Solaris 7
system, but it's probably a problem on other commercial UNIXes, as well,
so it probably doesn't belong in, say, "README.solaris".)
svn path=/trunk/; revision=337
source and destination port numbers, check both port numbers against the
specified port, rather than checking the lower of the two port numbers
against the specified port, just in case you happen to either have
1) the port number for that type being high enough that you can
get client sockets using it
or
2) client sockets using it for some other reason.
svn path=/trunk/; revision=333
pointer to a signed int instead of an unsigned int. In my testing the
code still worked, but it's better to do the conversion correctly.
svn path=/trunk/; revision=331
window, revert the timestamp type display option to the value it
had before that window was popped up, undoing any changes
applied with the "Apply" button.
If "Display/Options" is selected while there's a "Display
Options" window active, don't pop up another "Display Options"
window (we really should, if that's done, switch the input focus
to the existing "Display Options" window, if possible).
svn path=/trunk/; revision=329
NetMon statistic packets for now. We might fix that problem with wiretap,
either filtering out those packets, and/or providing the summary
information through a new wiretap API.
svn path=/trunk/; revision=326
changed by updating those columns showing the time in the
"command-line-specified" format, not by redoing the entire packet list
display; that way, the display continues to show the same packets and
any packet the user selected remains selected. (It's also less work to
do that - you don't have to re-dissect the packet.)
Turn "redisplay_packets()" into "filter_packets()", and do some other
cleanups.
svn path=/trunk/; revision=325
why I had to swap fields (data = w) in some of the callback functions when
I added support for gtk+-1.1. Because of the use of gtk_signal_connect_object,
the wrong value was being sent to the callback function. We were just lucky
that with gtk+-1.0 it worked.
gtk_signal_connect_object is for use with callbacks that take one argument.
gtk_signal_connect is for use with callbacks that take two arguments.
svn path=/trunk/; revision=324
were printing values in hex. The lack of "0x" in fron of the hex numbers
made me think the values were decimal, causing me to waste a bit of time
during debugging.
svn path=/trunk/; revision=323
either the UCD or CMU SNMP library. Also documented the fact that SNMP
support in ethereal can be disabled with the "--disable-snmp" option to
'configure'.
svn path=/trunk/; revision=322
"gtk_toggle_button_set_active()" to set the state of radio buttions;
"gtk_toggle_button_set_active()" doesn't exist in GTK+ 1.0[.x], and
"gtk_toggle_button_set_state()" is an alias for it in GTK+ 1.2[.x].
Compute the column widths in the summary display based on the longest
string in the column; recompute it whenever we update the columns.
svn path=/trunk/; revision=319
"Display/Options" dialog box.
"get_column_width()" should check "timestamp_type" against ABSOLUTE, not
against COL_ABS_TIME.
Clean up the code to check the state of the time stamp radio buttons in
the "Display/Options" dialog box.
Check in "timestamp.h", which we failed to check in on the previous
commit.
svn path=/trunk/; revision=318
is the same as "Tools/Capture", and "Display" has an "Options" item,
which pops up a dialog box to let you change the "default" time-stamp
column display format on the fly (the "default" is what the "-t"
command-line option sets), and have the display change when you do that.
Made infrastructure changes to make the immediate display update work.
Removed some unused functions, declared some functions used only in the
file in which they're defined "static", and removed some unnecessary
#includes.
svn path=/trunk/; revision=317
(standard convention in many GUIs).
Make "Save as" be "Save As", and make "A" be the menu mnemonic for it in
the "File" menu, with GTK 1.2.
svn path=/trunk/; revision=315
already appears in the list; the extra line is probably leftover from
cutting-and-pasting the author list from the AUTHORS file).
svn path=/trunk/; revision=314
"gtk_widget_show()" of the main window; that way:
1) any alert box popped up because a capture file specified with
the "-r" flag can't be read shows up after the main window
shows up, and is more likely to end up on top of the main
window, rather than behind it;
2) as the main window is up before we start reading a capture
file specified with the "-r" flag, the progress bar can show
our progress reading that file.
If the "-k" flag was specified, make sure "-i" and "-w" were specified
as well, rather than just dropping core trying to dereference NULL
"cf.iface" or "cf.save_file" pointers.
svn path=/trunk/; revision=313
to use the decode_*_bitfield() routines. This needed to happen anyway, but
I finally made the change so that I can figure out how I'm going to handle
bitfield fields in my experiment of changing the implementation of the
protocol tree in ethereal.
svn path=/trunk/; revision=311
influence came from
http://developer.apple.com/techpubs/mac/HIGuidelines/HIGuidelines-232.html
which has a section on dialog box and alert box messages. However,
we're largely dealing with technoids, not with The Rest Of Us, so I
didn't go as far as one perhaps should.)
Unfortunately, it looks like it's a bit more work to arrange that, if
you give a bad file name to the "-r" flag, the dialog box pop up only
*after* the main window pops up - it has the annoying habit of popping
up *before* the main window pops up, and sometimes getting *obscured* by
it, when I do that. The removal of the dialog box stuff from
"load_cap_file()" was intended to facilitate that work. (It might also
be nice if, when an open from the "File/Open" menu item fails, we keep
the file selection box open, and give the user a chance to correct
typos, choose another file name, etc.)
svn path=/trunk/; revision=310
we've shown the top-level window, because we want it to pop up on *top*
of the top-level window, rather than being hidden behind it.
Put a "strerror()"-based reason *why* the open failed in that dialog.
svn path=/trunk/; revision=308
GtkMenuEntry table, and add the comment from the equivalent part of the
GTK 1.2 tutorial before the GTK 1.2 GtkItemFactoryEntry table.
svn path=/trunk/; revision=307
doesn't modify anything pointed to by that argument, and that keeps us
from getting complaints if we pass a "const gchar *" to it.
svn path=/trunk/; revision=306
versions, PDU types, error statuses, and trap types to strings.
Set the protocol column to "SNMP", and set the info column to an error
message if the parse fails (rather than printing a message to the
standard error) and to the PDU type if it succeeds.
svn path=/trunk/; revision=305
Guy Harris