Commit Graph

81692 Commits

Author SHA1 Message Date
Dario Lombardo ee0dc72084
file_packet_provider: fix constness in declaration.
This fixes a warning (threated as error) on Windows

(ClCompile target) ->
         C:\projects\wireshark\file_packet_provider.c(84,1): warning C4028:  formal parameter 3 different from declaration [C:\projects\wireshark\build\shark_common.vcxproj]
2021-08-22 19:47:15 +02:00
Martin Mathieson 82b1092fe9 ORAN: Decompress block floating point numbers (used in ext11). 2021-08-22 13:39:20 +01:00
Dario Lombardo 8bcd077eb0
kerberos: add missing parameter. 2021-08-21 22:52:35 +02:00
Guy Harris 4de9f6ef83 Fix some issues with Exported PDUs.
Fix the description in wsutil/exported_pdu_tlvs.h to reflect reality
(i.e., to match what the code in Wireshark that reads the exported PDU
TLVs, and all code that writes them, does).

In the code that dissects them, treat all strings as FT_STRINGZPAD, as
any null bytes at the end of the string are padding, not part of the
string.

See merge request !3895 and issue #17535.
2021-08-21 02:31:45 -07:00
Jirka Novak dd161ade12 RTP Player: Fix of resampling for visual waveform
When capture was longer (e.g. 800s), audio was decoded correctly, but
visual waveform was shown incorrectly. Reason was exceeding range of
guint32 during calculation. Calculation is now made in guint64 and then
put back to guint32.
2021-08-21 07:20:33 +00:00
Jorge Mora 2c556a0e90 Infiniband: display the NAK error code
Display the NAK error from the ACK Extended Transport Header (AETH)
when the syndrome is a NAK error code.
2021-08-20 23:20:07 +00:00
Guy Harris c6717dc6b3 text_import.c: get EXP_PDU_TAG_PROTO_NAME from the header.
Don't hardcode 12, use EXP_PDU_TAG_PROTO_NAME from
wsutil/exported_pdu_tlvs.h.
2021-08-20 14:58:44 -07:00
Guy Harris 097656e805 androiddump: get the WIRESHARK_UPPER_PDU tags from the header.
Don't define WIRESHARK_UPPER_PDU_TAG_DISSECTOR_NAME ourselves and use
it, use EXP_PDU_TAG_PROTO_NAME from wsutil/exported_pdu_tlvs.h.
2021-08-20 13:16:15 -07:00
Martin Mathieson 4fc200ce51 UDPCP: Set length of Packet Transfer Options subfree 2021-08-20 17:57:58 +01:00
Pascal Quantin e20e6e30d7 LPPe: upgrade dissector to OMA-TS-LPPe-V1_0-20200630-D
Closes #17531
2021-08-20 18:19:23 +02:00
Taisuke Sasaki 79e82c3018 OSPF: Add Flexible Algorithm (draft-ietf-lsr-flex-algo-17) 2021-08-20 15:56:51 +00:00
Martin Mathieson 78b4835bc5 ORAN FH CUS: For Ext12, create subtree for value pairs 2021-08-20 11:05:19 +00:00
Martin Mathieson 927690e883 Fix some docbook spellings. 2021-08-20 10:43:01 +00:00
Alvin 9d8f38e600 ORAN : add extension type 12 2021-08-20 09:47:18 +00:00
Guy Harris 4e80643cc0 Move LINKTYPE_WIRESHARK_UPPER_PDU definitions to a separate header.
Have wsutil/exported_pdu_tlvs.h define the LINKTYPE_WIRESHARK_UPPER_PDU
TLV type and length values, as well as the port type values written to
files in EXP_PDU_TAG_PORT_TYPE TLVs.

Update the comment that describes the LINKTYPE_WIRESHARK_UPPER_PDU TLVs
to more completely and correctly reflect reality (it was moved from
epan/exported_pdu.h to wsutil/exported_pdu_tlvs.h).

Rename those port type values from OLD_PT_ to EXP_PDU_PT_; there is
nothing "old" about them - yes, they originally had the same numerical
values as the PT_ enum values in libwireshark, but that's no longer the
case, and the two are now defined independently.  Rename routines that
map between libwireshark PT_ values and EXP_PDU_PT_ values to remove
"old" from the name while we're at it.

Don't include epan/exported_pdu.h if we only need the
LINKTYPE_WIRESHARK_UPPER_PDU definitions - just include
wsutil/exported_pdu_tlvs.h.

In extcap/udpdump.c, include wsutil/exported_pdu_tlvs.h rather than
defining the TLV types ourselves.
2021-08-20 02:18:19 -07:00
Stig Bjørlykke ebf5da61c6 gsm_sim: Show status in info column when response only
Show value from status word in info column when packet is a
response only (not SIMtrace).
2021-08-20 08:29:00 +00:00
Stig Bjørlykke 1807d3874a coap: Do not handle Accept as Content-Format
Only use value of Content-Format to dissect the content in the
current packet. Accept is used to tell which format is expected
in the reply.

Fixes: #17536
2021-08-20 08:12:44 +00:00
Kaige Ye 487445c596 MySQL: Fix COM_QUERY response dissector when CLIENT_DEPRECATE_EOF is set
When CLIENT_DEPRECATE_EOF is set, no EOF packet between field packets and row
packets. See
https://dev.mysql.com/doc/internals/en/com-query-response.html#text-resultset
2021-08-20 07:56:05 +00:00
Guy Harris d679564d7b Use the wsutil/pint.h functions to fill in "exported PDU" headers.
That makes the code cleaner, including making it clearer that the fields
in those headers are big-endian.
2021-08-20 00:35:33 -07:00
Guy Harris 1b54c40a5b jpeg: don't free something allocated from a wmem pool.
If it's allocated with the NULL "pool", yes - that's just a regular
allocation - but if it's allocated from a pool, no.
2021-08-19 15:59:43 -07:00
Evan Huus eda26f9e5f wmem: convert more asn1 dissectors to pinfo->pool
We prefer pinfo->pool over the global wmem_packet_scope() now. Convert a
few more asn1 dissectors. After this commit, just three asn1 dissectors
remain.
2021-08-19 15:07:44 +00:00
Thomas Dreibholz 042001fb55
Added heuristics to ICMP and ICMPv6 dissectors to decode the payload. 2021-08-19 16:13:16 +02:00
Thomas Dreibholz a104403dad
Added HiPerConTracer dissector. 2021-08-19 16:13:15 +02:00
Michail Koreshkov 595a5a1c9d gsm_a_rr: add NRI decoding when pool is used
Protocol BSSGP has option in GUI to enable decoding NRI when SGSN pool
is used. But this configuration option is not used in code.

I have marked this option as obsolete and add new single option to protocol dissector gsm_a_rr
where TLLI is decoded and added code for processing NRI.
2021-08-19 09:51:39 +00:00
Jirka Novak 6672f1eb2b Updated release notes 2021-08-18 19:27:10 +00:00
Jirka Novak af059913b3 RTP Analysis: CSV export has header line
Export to CSV from RTP Analysis has header now. Header is on top of the
export so for export of multiple tabs it is just once in the export.
2021-08-18 19:27:10 +00:00
Kaige Ye e5062a2249 MySQL: Fix EOF packet dissector when CLIENT_DEPRECATE_EOF is set
Closes: #13467
2021-08-18 09:24:44 +00:00
Chloe Pelling a2b17d3dbe X11: Handle GenericEvents longer than 32 bytes.
While X11 Events are generally fixed-length, GenericEvents extend the protocol
to provide a length field, similar to Replies. As noted in the extension spec,
if a GenericEvent longer than 32 bytes is sent to a client unable to process it,
"future interpretation of replies and events by this client will fail." See
https://www.x.org/releases/current/doc/xextproto/geproto.html

This patch merely prevents that failure case. It does not attempt to
meaningfully dissect the contents of such packets, which in any case will vary
depending on the relevant X11 extension.
2021-08-16 23:06:36 +00:00
Rui f5dc703259 MPTCP: Add support for MP_CAPABLE C Flag
Interpret C Flag as described in section 3.1 RFC8684

Issue: https://github.com/multipath-tcp/mptcp_net-next/issues/190
2021-08-16 19:15:57 +01:00
Gerald Combs 2683508b38 Windows: Upgrade c-ares to 1.17.2. 2021-08-15 18:45:33 +00:00
Gerald Combs 2fadbe7c28 [Automatic update for 2021-08-15]
Update manuf, services enterprise numbers, translations, and other items.
2021-08-15 09:29:16 +00:00
Martin Mathieson 545eab808e Fix some item label names with unbalanced parens/braces/brackets
Spotted by new check added to check_typed_item_calls.py --label
2021-08-14 21:24:13 +01:00
Gerald Combs cd899ce8d1 LWAPP: Fix a preference description.
Fix a typo in the "Swap Frame Control" preference description, which
makes it match its CAPWAP counterpart.
2021-08-14 04:53:19 +00:00
Dylan Ulis 8c811459b3 CIP Motion: Parse more bits in Act/Cmd Data Sets
Parse Unwind Cycle Count and Position Displacement in the Actual Data
Set and Command Data Set.
2021-08-12 11:14:35 -04:00
David Garcia Villalba b77f028b29 PFCP: Fix Enterprise IE generic decoding offsets
Reduce by two every offset in generic enterprise IE decoding.
Closes: #17523
2021-08-12 09:53:01 +00:00
Ignacio Martínez Rivera 5b9c0fde98 WebSocket: Add support for "x-webkit-deflate-frame" frame compression 2021-08-12 07:25:13 +00:00
Adrian Granados 5f3278c8d5 ieee80211: Add dissector for the Non-Inheritance IE Extension
Implements dissector for Element ID Extension 56 (Non-Inheritance).
See 9.4.2.240 Non-Inheritance element in IEEE 802.11-2020.
2021-08-12 00:21:35 -04:00
Joakim Andersson b75107c77f Bluetooth: Fix clock accuracy field offset in sync info
Fix clock accuracy field offset in the sync info information in the
extended advertising header.
The field was placed at offset 4 instead of the current offset + 4.

Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
2021-08-10 20:33:25 +00:00
Pascal Quantin 1b61474d9d CMake: include CheckFunctionExists in FindKERBEROS.cmake 2021-08-10 17:46:40 +02:00
John Thacker 3c5168c874 editcap doc: Fix description of split output file names
The editcap documentation still refers to the pre 1.2.1 behavior
of determining output file names when splitting based on either
packet counts or time intervals. (See commit a8eb860103) Update
it to reflect the current behavior.
2021-08-10 08:05:39 +00:00
Guy Harris 158810c713 editcap: if -T was specified, change the linktype of all interfaces.
Don't just change the linktype of the file (if it has one) and the
linktypes of all the packets, change the linktype of all interfaces as
well.

Fixes #17520.
2021-08-09 23:45:37 -07:00
David Perry 6e12643f19 [#17478] free blocks in more places
Bug 17478 was caused by `wtap_rec.block` being allocated for each
packet, but not freed when it was done being used -- typically at the
end of a loop.

Rather than requiring each caller of `wtap_read()` to know to free a
member of `rec`, I added a new function `wtap_rec_reset()` for a
slightly cleaner API. Added calls to it everywhere that seemed to make
sense.

Fixes #17478
2021-08-10 00:08:15 +00:00
Guy Harris 4aee405974 etw: use PACK_FLAGS_DIRECTION() to extract the direction from the flags.
Use PACK_FLAGS_DIRECTION() rather than making with
PACK_FLAGS_DIRECTION_MASK.  They happen to be at the bottom of the flags
option, so no shifing is needed, but it's cleaner to use the macro.

Make the packet flags variable local to the code that uses it, and fix
indentation (don't use tabs - they're not used elsewhere), while we're
at it.
2021-08-09 15:57:29 -07:00
Gerald Combs 410cfdd7da [Automatic update for 2021-08-09]
Update manuf, services enterprise numbers, translations, and other items.
2021-08-09 00:41:29 +00:00
Martin Mathieson c0faa8f1da Some more dissector spellings. 2021-08-08 22:21:38 +01:00
Martin Mathieson 03c3c9a056 check_typed_item_calls: Add some ptvcursor_add...() calls
Fix up some NFAPI calls.
2021-08-08 17:47:42 +01:00
Martin Mathieson 21eb235d15 ORAN FH CUS: Fix ext11 with disableBFs for orphaned PRBs 2021-08-08 12:01:23 +01:00
Dr. Lars Völker 54d47868b8 ISO15765: Cleanup and Bugfix
This patch fixes the wrong value for frame_length being shown in the
header field.

In addition, code is cleaned up and simplified.
2021-08-06 21:38:18 +02:00
Martin Mathieson aaf79b62d7 F1AP stats 2021-08-06 09:31:15 +00:00
ZhaoHao 272ed7a05a trailing whitespace 2021-08-06 06:53:38 +00:00