Commit Graph

2358 Commits

Author SHA1 Message Date
Moshe Kaplan 8e8d19be1a WSUG: Avoid using multiple layers of replacements
Change-Id: I3fc56fc6b586e40bc1f81ba41e32e8a554c239d1
Reviewed-on: https://code.wireshark.org/review/35146
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-21 04:58:33 +00:00
Gerald Combs beb1fee658 3.1.0 → 3.3.0.
Change-Id: Ia6217b00741f824b1f6805eb406408802dd5b5a8
Reviewed-on: https://code.wireshark.org/review/35167
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-20 23:33:02 +00:00
Gerald Combs f2ca15bfa2 Release notes: Update the new protocol list.
Update the new protocol list and clarify our Qt versions.

Change-Id: If4d5e591b4419cc3171616825201375fdc5401aa
Reviewed-on: https://code.wireshark.org/review/35165
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-20 18:59:15 +00:00
Roland Knall 6d8355e7de ReleaseNotes: Add info about "Expressions"
They no longer reside to the right of the display filter toolbar, but
have been moved to Analyze->Display Filter Expressions... as well as
the context menu of the display filter edit

Change-Id: I5afb87a483838204be33f5b8b965643c2c95e306
Reviewed-on: https://code.wireshark.org/review/35151
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-20 08:56:05 +00:00
Tomasz Moń 4e77ca61d9 docbook: Add USB 2.0 Link Layer to release notes
Change-Id: Ifb87e70b89f63fc633660924b730b73156872580
Reviewed-on: https://code.wireshark.org/review/35139
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-20 06:39:05 +00:00
Gerald Combs ae58402e14 3.1.1 → 3.1.2.
Change-Id: Id89e46103f61392653cfdc60ef16d11123fe0928
Reviewed-on: https://code.wireshark.org/review/35128
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-18 20:12:27 +00:00
Gerald Combs 5169b9f3bc Build 3.1.1.
Change-Id: I007d9e6c6b0562e727673787e6c27efd6a2f6269
Reviewed-on: https://code.wireshark.org/review/35125
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-18 19:03:24 +00:00
Roland Knall 1ddd30856d ReleaseNotes: Multi-selection of packets
Change-Id: I0003b0785aec17d6cb86f1020836f5caf07c9d08
Reviewed-on: https://code.wireshark.org/review/35089
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-17 12:21:28 +00:00
Graham Bloice 669613f41d WSDG: Remove duplicate paragraph
Change-Id: Ia96444bc463337e0ffb050a05ce4d454dd18986d
Reviewed-on: https://code.wireshark.org/review/35103
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-16 13:33:06 +00:00
Gerald Combs 02057200fd macOS: Add support for automatic updates using Sparkle.
Add support for automatic updates using the Sparkle framework. Add
FindSparkle.cmake and associated CMake plumbing. Add a public key and
other info to Info.plist.in. Add ui/macosx/sparkle_bridge.{h,m}, which
wraps the Sparkle API. Make code that's specific to WinSparkle
Windows-only.

Add Sparkle installation steps to the macos-setup scripts. Sparkle
prints a warning if your bundle is unsigned (which is the case during
development) so disable installing it by default.

Updating here takes a long time. We might be able to fix that by
shipping our DSYMs separately.

Change-Id: I6cc6671db5657dadc514bda6bf6e1c8bbc9468a5
Reviewed-on: https://code.wireshark.org/review/35090
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-15 18:39:04 +00:00
Gerald Combs 766f231da6 Release notes: Add an item about following HTTP/2 and QUIC.
Change-Id: If3078136aa6996fda04eb4f18f36f142f7d18b1f
Reviewed-on: https://code.wireshark.org/review/35075
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-13 05:19:39 +00:00
Jaap Keuter ca114508d1 Documentation: update (long) cmd line options.
Documentation of the Wireshark command line options between help text,
manual page and user's guide diverged over time. One aspect of this is
the implementation of more long options. This change tries to update
all documentation to be complete and in sync again.

Bug: 16168
Change-Id: Id833fbeb14fdb7b3dbc1564504a25d96f4367c91
Reviewed-on: https://code.wireshark.org/review/35047
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-11-11 06:16:07 +00:00
Gerald Combs 71996e8d93 CMake+docbook: Fixup our .chm titles.
Some parts of HTML Help have issues displaying curly quotes. Add a
title argument to the XML2HHP macro so that we can set one with a
straight quote. Set the title using the htmlhelp.title XSL parameter
instead of relying on HTML Help to derive it for us. This seems to keep
"???TITLE???" from being mysteriously appended to the title.

Try setting htmlhelp.window.geometry while we're here.

Bug: 16183
Change-Id: I0bf2dbeeb811dc65010ab5223725d6b5cdc96966
Reviewed-on: https://code.wireshark.org/review/35031
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-08 20:27:15 +00:00
Dario Lombardo 69356f1b60 Document long command line options.
Bug: 16168
Change-Id: Ifdfa9092b632171c461430bc3e9de32ec1ed46f4
Reviewed-on: https://code.wireshark.org/review/34996
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-06 11:27:07 +00:00
Roland Knall 0e64e9f3ca extcap: Allow loading of extcap files from personal directory
Allow the storage of extcap plugins in the personal directory and
enable loading from there. It will also take precedence of any
system-wide extcaps with an identical name

Change-Id: Ib88e09a26c4f99cf5e793327f2808c7445c6b1b5
Reviewed-on: https://code.wireshark.org/review/34988
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05 16:57:09 +00:00
Roland Knall a802000a2e Qt: Allow action buttons to be left-aligned
Buttons can be left-aligned in the display filter edit bar, by selecting
the corresponding option from the context menu

Bug: 14123
Change-Id: I18b48bb0ea43a598b2e309dcad9210463be06414
Reviewed-on: https://code.wireshark.org/review/34980
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05 16:56:33 +00:00
Roland Knall a218460e22 Qt: IOGraph display filter graph added
Add a graph for the currently display filter if none exists, upon
opening IOGraph

Change-Id: Ic25b014484898dd1917b13f2616fd519e2e8183b
Reviewed-on: https://code.wireshark.org/review/34984
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05 15:50:50 +00:00
Roland Knall a8052b9f38 Qt: Coloringrules Mime is encoded as JSON
Encode coloring rules as json objects to avoid encoding issues

Change-Id: I4b5369fef3c0f9e73cbb08edf14de6535ff35026
Reviewed-on: https://code.wireshark.org/review/34947
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-04 13:09:52 +00:00
Roland Knall 013e87a8fd Qt: Remove DisplayFilterMimeData
Make the mimetype for the display filter more generic, so that external
programs can attach to Wireshark and users can drag and drop display
filters to the program

Change-Id: Id78b4dff7883e3dab879a31aad07f577d8cc4ee3
Reviewed-on: https://code.wireshark.org/review/34936
Reviewed-by: Roland Knall <rknall@gmail.com>
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-04 11:39:48 +00:00
Huang Qiangxiong 0b0bbb8060 HTTP2/gRPC: Support streaming mode reassembly
If working in streaming RPC mode, many grpc messages will be
contained in one http2 stream, the stream will end very late
(for example ETCD watch stream).

So we could not rely on old http2 reassembly mode which call
sub-dissector only END_STREAM appeared. We need a reassembly
mode that call subdissector which support streaming mode as
soon as the message in STREAM is available.

Please refer to comments of
reassemble_http2_data_according_to_subdissector() function
of epan/dissectors/packet-http2.c for more detail.

See the linked bug for streaming mode gRPC capture files.

Ping-Bug: 16160
Change-Id: Id9e5337a0e3ca9f8c8119d74d2c1fe4cc263afc3
Reviewed-on: https://code.wireshark.org/review/23988
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-03 16:43:39 +00:00
Roland Knall accd563aaf Qt: Consolidate mimedata usage
Ensure, that all mimedata uses similar mimetypes and document
the mimetypes being used throughout wireshark

Change-Id: I7c02d0a5e12a823153640e600051abb95d58cdeb
Reviewed-on: https://code.wireshark.org/review/34923
Petri-Dish: Roland Knall <rknall@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-03 15:45:34 +00:00
Gerald Combs 530c30e8a8 Docs: Try to make our "drag and drop" usage more consistent.
Apple uses "drag and drop" and "drag-and-drop":
https://developer.apple.com/design/human-interface-guidelines/macos/user-interaction/drag-and-drop/
https://support.apple.com/guide/mac-help/drag-and-drop-items-mh35852/mac
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/DragandDrop/DragandDrop.html

So does Microsoft:
https://docs.microsoft.com/en-us/windows/win32/com/drag-and-drop

Qt and KDE use "drag and drop":
https://doc.qt.io/qt-5/dnd.html
https://docs.kde.org/stable5/en/applications/konsole/drag-and-drop.html

GTK+ and GNOME uses "drag-and-drop"
https://developer.gnome.org/gtk-tutorial/stable/c1899.html

Wikipedia uses "drag and drop" and "drag-and-drop"
https://en.wikipedia.org/wiki/Drag_and_drop

Let's go with "drag and drop" (and "dragging and dropping") in the
release notes and User's Guide.

Change-Id: I5010478e5d15928a3a8a7528296c3f5cdc98f3ab
Reviewed-on: https://code.wireshark.org/review/34921
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-03 13:15:33 +00:00
Gerald Combs dc3cdf87a5 Release notes: We're building with VS 2019 on Windows.
Change-Id: I5fd3f6546419aa5906cbc3def2be175989fa0e4b
Reviewed-on: https://code.wireshark.org/review/34858
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-25 16:11:32 +00:00
Moshe Kaplan 9d6551f3fd WSUG: fix <= escaping
Change-Id: I06ddd372ae51580bc9010db1f3bf32f69360d2f7
Reviewed-on: https://code.wireshark.org/review/34798
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-19 11:34:18 +00:00
Moshe Kaplan 42683fbd94 WSUG: Update enabled protocols image
Change-Id: I78042220df3de00e11f5e9a514365150e6ca7de6
Reviewed-on: https://code.wireshark.org/review/34799
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-18 05:17:19 +00:00
Gerald Combs e76f518913 Release notes: Remove an item.
The recent macOS installer changes were backported to master-3.0, so
they're no longer new in master.

Change-Id: I357e0f8facbc2266c3780bcf8d696b5c2b00602d
Reviewed-on: https://code.wireshark.org/review/34745
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-08 18:04:32 +00:00
Moshe Kaplan 930aa328dd WSUG: Clean up opening sentences
Change-Id: I7c1443459f5705a1a087dfe3e3af8c3826dc1f08
Reviewed-on: https://code.wireshark.org/review/34727
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-08 06:31:41 +00:00
Moshe Kaplan 67d5c58bd2 WSDG: Fix duplicate 'the the'
Change-Id: Iaa383391daa6deb569852fe4bb464f7cda3658dd
Reviewed-on: https://code.wireshark.org/review/34726
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-08 03:58:17 +00:00
Moshe Kaplan cb7dafbcf6 WSUG: Clean up duplicated words
Used egrep "\b([a-zA-Z]+) \1\b" docbook/wsug_src/*.adoc to find instances
where words were erroneously duplicated.

Change-Id: Ie390fa4f1c61a288ff0ed77aa84c4fb01f4de27e
Reviewed-on: https://code.wireshark.org/review/34725
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-08 03:57:49 +00:00
Huang Qiangxiong 5750c4981c protobuf: add support for Protocol Buffers Language (*.proto) files
1. A C-style Protocol Buffers Language (PBL) parser for *.proto file is added.
It contains protobuf_lang_scanner.l (lex scanner), epan/protobuf_lang.y (grammar
parser), and protobuf_lang_tree.h/c (grammar tree implementation).

2. The protobuf-helper.h/cpp is an interface wrapper layer. If one day C++ is allowed,
we can create a protobuf-helper.cpp file, which using offical protobuf C++
library, to replace protobuf-helper.c. That keeps packet-protobuf.c unchanged.

3. User can specify protobuf search paths, and the UDP ports to protobuf message type
maps at the Protobuf protocol preferences.

4. Other dissectors can pass the message type to Protobuf dissector by data parameter
or pinfo->private_table["pb_msg_type"] (pinfo.private["pb_msg_type"] in lua).

Some Sample of GRPC with Protobuf captures can be found in Bug: 13932.

Bug: 13932
Change-Id: Ife16c2f7b381296f8db4740dabe5f8362a456f48
Reviewed-on: https://code.wireshark.org/review/22892
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-07 10:35:52 +00:00
Peter Wu d2a660d805 QUIC: Add Follow QUIC Stream support to Qt and tshark
The QUIC transport protocol provides a stream, similar to HTTP/2. Make
it possible to look at the stream contents. This can be helpful while
HTTP/3 support is not yet complete.

Known issues that will be addressed in the future:

 - If a single packet contains multiple streams, then Follow QUIC Stream
   will wrongly include data from streams other than the selected one.
   This is tracked by bug 16093 and affects HTTP/2 as well.

 - The Substream index menu does not properly filter for available
   stream numbers. If a non-existing stream is selected, then changing
   to another (potentially valid) index results in the "Capture file
   invalid." error. As workaround, clear the display filter first.

 - Follow Stream always selects Stream ID 0 instead of the first or
   currently selected stream field in a packet. Users should manually
   update the stream index as needed.

Change-Id: I5866be380d58c96f0a71a29abdbd1be20ae3534a
Ping-Bug: 13881
Reviewed-on: https://code.wireshark.org/review/34694
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-04 04:36:09 +00:00
Gerald Combs 160f525e2c Docbook: Update macOS packaging.
Update the macOS packaging sections to reflect current reality.

Change-Id: I6795787c0d4d3c9a85da14bdb69a31fc74e9ddf2
Reviewed-on: https://code.wireshark.org/review/34624
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-26 19:51:53 +00:00
Dr. Lars Völker 3aeaf5c6fc SOMEIP: Adding support for the SOME/IP protocol.
The Scalable service-Oriented MiddlewarE over IP (SOME/IP) is the
standard communication middleware for IP and Ethernet based
communication. It supports Service Discovery, RPC, Pub/Sub, and more.

Bug: 16014
Change-Id: Ifd6549818ccc87f376a5fb9ba1d6c335818c6e00
Signed-off-by: Dr. Lars Völker <lars.voelker@bmw.de>
Reviewed-on: https://code.wireshark.org/review/34497
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-26 04:01:33 +00:00
Gerald Combs ac4f3c0f4d macOS: Make Wireshark.app drag-installable.
Create ChmodBPF installer and uninstaller packages using pkgbuild and
productbuild. Place them in Wireshark.app/Resources/Extras.

Add a path_helper installer and uninstaller which respectively add and
remove /etc/*paths.d/Wireshark.

Remove the PackageMaker and utility-launcher assets and build targets.

Show a message in the main welcome screen if we don't have capture
permissions. Add an link which launches the ChmodBPF installer.

Add a "macOS Extras" item to About → Folders.

Migrate "Read me first" from RTF to Asciidoctor, which lets us add links
and looks like our other documentation.

Rename dmg_set_style.scpt to arrange_dmg.applescript and make it plain
text. Always run it in osx-dmg.sh.

Bug: 6991
Bug: 12593
Bug: 11399
Ping-Bug: 16074
Change-Id: I7b6aa89aae2be522b4141b0d44e8142dec749e90
Reviewed-on: https://code.wireshark.org/review/31047
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-25 16:26:31 +00:00
Alexander Gryanko 9fff62e2a8 Qt, http2: Add Follow HTTP/2 Stream functionality
The HTTP/2 protocol multiplexes a single TCP connection into multiple
independent streams. The Follow TCP output can interleave multiple
HTTP/2 streams, making it harder to analyze a single HTTP/2 stream.

Add the ability to select HTTP/2 Streams within a TCP stream.
Internally, the HTTP/2 dissector now stores the known Stream IDs in a
set for every TCP session which allows an amortized O(n) lookup time for
the previous/next/max Stream ID.

[Peter: make the dissector responsible for clamping the HTTP/2 Stream ID
instead of the Qt code, that should permit future optimizations.]

Change-Id: I5d78f29904ae8f227ae36e1a883155c0ed719200
Reviewed-on: https://code.wireshark.org/review/32221
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexander Gryanko <xpahos@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-22 05:29:30 +00:00
Peter Wu 29be7f9d9a Qt, docs, ieee1905: fix some spelling errors
The spelling error for "Desription" in the context menu was very
obvious. The others were found by scanning the output of:

    grep -Po '<source>\K.*(?=</source>)' wireshark_en.ts

Change-Id: I4b95236c82f76828a115d59d7c8e0b853eae1d26
Reviewed-on: https://code.wireshark.org/review/34582
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-09-21 08:33:58 +00:00
Gerald Combs 655f7442ae WSDG: Add an "or".
Change-Id: I3f068dcdf4b7df1e54a742ccf55983aae200eba5
Reviewed-on: https://code.wireshark.org/review/34550
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-16 22:47:54 +00:00
Gerald Combs 72eb4e5b26 WSUG: Packet list and detail context menu updates.
Update some of the packet list and detail context menu items.

Add a release note entry noting the new Apply/Prepare behavior and
update some other items.

Change-Id: I3c2336a3f438f2d97bdb4df764e2af78a3499d81
Reviewed-on: https://code.wireshark.org/review/34543
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-16 22:40:30 +00:00
Gerald Combs c8ce89111d WSDG: Visual Studio fixes.
Convert a single numbered list to a simple paragraph. Generalize a
reference to to the VS Community Edition in one place and fix the VS
version in another.

Start using one sentence per line as recommended at
https://asciidoctor.org/docs/asciidoc-recommended-practices/#one-sentence-per-line

Change-Id: Iaa2a830d6cdb034c8057e4a6c45935e65d1d387e
Reviewed-on: https://code.wireshark.org/review/34519
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-16 17:37:11 +00:00
Gerald Combs fb5a029e47 Docbook: Fixup our table delimiters.
Update our table delimiters to match the Asciidoctor documentation.

Change-Id: I87a6834f2889e175236aa609984a9bc4dd9d3b8e
Reviewed-on: https://code.wireshark.org/review/34544
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-16 17:35:49 +00:00
Gerald Combs 3bff8f372e WSDG: Updates for Visual Studio 2019.
Start recommending Visual Studio 2019.

Change-Id: I743844691baf6798f708aca48dd73da8d7fb6aeb
Reviewed-on: https://code.wireshark.org/review/34508
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-12 03:47:55 +00:00
Dr. Lars Völker d963b312d0 DLT: Adding support for the DLT protocol
The Diagnostic Log and Trace protocol (DLT) is a commonly used and
standardized protocol in the automotive industry used to retrieve
log data. This patch adds the protocol to Wireshark. Keep in mind
that ports have to be configured before the dissector can be used.

Change-Id: I24592705476fb0c3bb83a1cc10b3dae8867523f4
Signed-off-by: Dr. Lars Völker <lars.voelker@bmw.de>
Reviewed-on: https://code.wireshark.org/review/34462
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10 03:56:28 +00:00
Moshe Kaplan f45ed90a4f WSUG: Update docs on working with captured packets
Change-Id: Ic411028e4026618471fa9933bea0b5a78875e049
Reviewed-on: https://code.wireshark.org/review/34414
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04 16:59:08 +00:00
Roland Knall d56ad090fb Qt: in EnabledProtocolsDialog handle protocol type
Allow a selection of the list based on the protocol type. That way
one can easily enable/disable for instance just heuristic protocols

Change-Id: I1ee8df5d9887c764272ec55b33703855c0c91f5a
Reviewed-on: https://code.wireshark.org/review/34442
Reviewed-by: Roland Knall <rknall@gmail.com>
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04 06:45:00 +00:00
Guy Harris 286369a758 Clean up some formatting.
List syntax is *not* one of the more straightforward parts of AsciiDoc.

Change-Id: Icfed27de84c8c11cad02c4ba4d359786cd480eea
Reviewed-on: https://code.wireshark.org/review/34423
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-01 21:50:29 +00:00
Guy Harris 9ae6abdec9 Fix the section on Boolean fields to match reality.
Confusing though it might be, a patch-matching expression containing
only the name of a Boolean field matches all packets containing that
field, regardless of whether the field is true or false; you need to
compare the field against 1 to check whether it's true.

Change-Id: I615acc4d71964c8474e6f3655ade8814cbe07b22
Reviewed-on: https://code.wireshark.org/review/34422
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-01 21:09:55 +00:00
Ido Schimmel a94a860c06 net_dm: Add dissector for drop monitor netlink packets
The Linux kernel includes a module called drop monitor which -
unsurprisingly - monitors packet drops.

Once enabled, the module will periodically send netlink notifications to
user space over generic netlink. Historically, these notifications only
included the program counter where the drop occurred and the number of
packets that were dropped in this location in the last interval.

Patches in net-next (queued for Linux kernel 5.4) extend drop monitor
with another mode of operation where the dropped packets themselves are
sent to user space along with relevant metadata as netlink
notifications. This allows users to perform a more detailed analysis of
the dropped packets.

This patch adds a dissector for these netlink packets. The dissector is
expected to be invoked by the generic netlink dissector and during its
hand off routine it adds an entry in the 'genl.family' dissector table.

The various netlink attributes are dissected by calling
dissect_netlink_attributes(), in a similar fashion to the rtnetlink
dissector. The dropped packet itself is encoded in the netlink attribute
'NET_DM_ATTR_PAYLOAD' and dissected by invoking a dissector from the
'sll.ltype' dissector table based on the packet's protocol which is
encoded in the 'NET_DM_ATTR_PROTO' attribute.

Bug: 16018
Change-Id: I10bfa4b9c9d8f5e82769c250f929f74693142a23
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-on: https://code.wireshark.org/review/34351
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-01 09:03:37 +00:00
Roland Knall 6e240e6727 Qt: Apply Invert/Enable/Disable only to selected list
Also, put the search field on top, as this is the default for search
fields and apply the change of enable/disable and invert-all only to
the selected items, instead of all items.

Bug: 16013
Change-Id: If4ef1c5ce63eef6fa72db679cdcbf52dcb0e8fb6
Reviewed-on: https://code.wireshark.org/review/34393
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-29 10:26:02 +00:00
Gerald Combs e9daf6ce51 WSUG: Clean up some menu item descriptions.
Summarize and clean up some of the menu item text. Start sentences on a
new line as recommended at
https://asciidoctor.org/docs/asciidoc-recommended-practices/#one-sentence-per-line,
although we wrap long lines.

Change-Id: I778f278d8503153ec649c3f0a4b2ccb24512e701
Reviewed-on: https://code.wireshark.org/review/34341
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-08-23 18:18:03 +00:00
Jaap Keuter 7519c077d0 WSUG: Update Control Protocol dissection chapter
With the design changes made in the Qt interface with respect to the
Deocode as dialogs the Users Guide content is confusing. Update the
graphics and text to accurately describe the current design. Update
references in other parts of the document too.

Change-Id: Iad6af555d2da3430230c7f176bf2ec1e808cc134
Reviewed-on: https://code.wireshark.org/review/34337
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-22 15:17:25 +00:00
Gerald Combs 646ff56fae doc+docbook: Add .guisubmenu.
Change-Id: I40ce4a26b0d8228cccca2904dc4c71f2c01b40ce
Reviewed-on: https://code.wireshark.org/review/34296
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-15 17:55:08 +00:00
Harald Welte b1412ab11d Add dissector for OsmoTRX protocol
This protocol is a non-standard, ad-hoc protocol to pass baseband GSM
bursts between the modem (osmo-trx) and the encoder / decoder
(osmo-bts-trx). Osmocom inherited this when forking OsmoTRX off the
OpenBTS "Transceiver" program.

Change-Id: I31f5071d08eff1731f1d602886e204c87eed107c
Related: OS#4081 (https://osmocom.org/issues/4081)
Bug: 14814
Reviewed-on: https://code.wireshark.org/review/26796
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-08-14 10:00:34 +00:00
Jaap Keuter fb42c24a2c User Guide: document dfilter_macros file
In the configuration files overview the dfilter_macros file was missing.
Add its description and slay a few typos on the way.

Bug: 15973
Change-Id: I381d0482ac13dce6ea1daf44300c74d3a1ff03fe
Reviewed-on: https://code.wireshark.org/review/34243
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-08-13 22:55:11 +00:00
Gerald Combs f5aaea0da9 doc+docbook: More CSS tweaks.
Change-Id: I16af6fec3eccf5e8516a1fbcfe269882493e41d0
Reviewed-on: https://code.wireshark.org/review/34260
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-12 23:07:20 +00:00
Gerald Combs 7af296d9fd doc+docbook: Add .guimenuitem.
Change-Id: I63f097576d3dd85425e6e44fbc1c46fd4305f3e7
Reviewed-on: https://code.wireshark.org/review/34254
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-12 18:43:40 +00:00
Gerald Combs 29febdc4f3 doc+docbook: Add .guibutton and .keycap rules.
Change-Id: I3499b97600ea3ad8e036a40f219e2a80693916ed
Reviewed-on: https://code.wireshark.org/review/34253
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-12 17:59:50 +00:00
Gerald Combs 8a0e22b4b9 doc+docbook: Update our CSS file.
Update ws.css by rebasing
https://github.com/geraldcombs/asciidoctor-stylesheet-factory against
the latest master at
https://github.com/asciidoctor/asciidoctor-stylesheet-factory and adding
a ".guimenu" rule.

Change-Id: I79532c18ffd036ba5a24b84a7eaa448231cbf7f0
Reviewed-on: https://code.wireshark.org/review/34225
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-12 04:07:39 +00:00
Guy Harris a41c7aa223 Update the set of buildbots to the current reality.
(That's the master and 3.0.x buildbots; the 2.6 Mac buildbot is running
an older version of Apple's UNIX-for-Macs - sufficiently older that
Apple's name for it was different back then.)

While we're at it, note that it's been updated past VS 2013.

Change-Id: I063daa7c38ff58aed0c77950d4265b5544783f2c
Reviewed-on: https://code.wireshark.org/review/34217
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-09 02:43:43 +00:00
Gerald Combs 545a3986fe Docbook: Document using middle-click to mark packets.
Add an item about marking packets using the middle mouse button to the
release notes.

Update the "Marking Packets" section of the User's Guide accordingly.

Use "menu:...[]" to mark up menu items in a bunch of places. It looks
like we need to a add a "guimenu" class to ws.css.

Change-Id: Ide99112f7643e509d8af8a4aa6ddb4287f3585cf
Reviewed-on: https://code.wireshark.org/review/34182
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-05 08:26:43 +00:00
Roland Knall f259187803 Qt: Update UI for profiles and handle export/import properly
This patchset ensures a 1:1 replacement of the old 3.0 version of the profiles
dialog. It is a major bugfix for the new version in case of handling creating/
deleting and adding profiles.

Delete can be performed on multiple profiles now, by selecting the profiles
which need to be deleted.

Import/Export functionality has been overhauled to follow these rules:

* No imports while changes are pending, due to datamodel sanity
* Export for Default Profile and Global Profiles is not possible
* Either all personal profiles can be selected or individually choosen ones
* Use last directory and store it properly
* Imports can be cancelled
* Only one import is allowed at a time (but it can contain as many profiles as needed)

Change-Id: Ie2fccd397202ec06976d764734437284f464409a
Reviewed-on: https://code.wireshark.org/review/34123
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-02 21:38:02 +00:00
Dario Lombardo d614865c8c docbook: fix infos and commands.
- Use apt instead of aptitude.
- Update example file name versions.
- Remove leading $ from command lines.

Change-Id: I888f6612615ac252c0c0b3f867bac36610ae3e51
Reviewed-on: https://code.wireshark.org/review/34110
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-30 07:56:13 +00:00
Gerald Combs ede4ecb8c8 [Automatic update for 2019-07-28]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Iae1d6218e2353d99569caaeff072f6691b7b817f
Reviewed-on: https://code.wireshark.org/review/34104
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-28 08:20:23 +00:00
Guy Harris 20800366dd HTTPS (almost) everywhere.
Change all wireshark.org URLs to use https.

Fix some broken links while we're at it.

Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c
Reviewed-on: https://code.wireshark.org/review/34089
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-26 18:44:40 +00:00
Gerald Combs 12e8b4edd3 3.1.0 > 3.1.1.
Change-Id: Idc7ab6cfe38cffa4053d0d8ce710cb95b33aa6ac
Reviewed-on: https://code.wireshark.org/review/34084
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-25 20:03:30 +00:00
Gerald Combs 414ca80b21 Build 3.1.0.
Change-Id: Iced73e36e00018ace596b671959bc087b3541765
Reviewed-on: https://code.wireshark.org/review/34082
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-25 18:47:24 +00:00
Gerald Combs 7122a8a53e Update the release notes for 3.1.0.
Change-Id: I85b2a8088e1968bd8e2fb707fe269e11fb2e0c90
Reviewed-on: https://code.wireshark.org/review/34078
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-24 22:50:25 +00:00
Moshe Kaplan b4c6b3981f WSUG: Corrected keyboard shortcuts for Edit Menu
Change-Id: Id65a56c179bdcf60772239f0f371efa4b79a652b
Reviewed-on: https://code.wireshark.org/review/34062
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-23 18:35:41 +00:00
Roland Knall 3a62b1bc75 Qt: Allow profile import from directory
To allow for easy import of profiles, one can select a directory
to import profiles from

Change-Id: I12f66e3dc6bd272d34baa76093152dce412b0158
Reviewed-on: https://code.wireshark.org/review/34038
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-21 16:41:13 +00:00
Peter Wu c88e525168 Documentation: convert http URLS to https
Remove some dead links or point them to archive.org while at it. All
updated links have been verified.

Change-Id: Icf02167a13d5fe9dfce39ea57525b3f185554c9d
Reviewed-on: https://code.wireshark.org/review/34028
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-20 20:51:30 +00:00
Gerald Combs 8147af211d Editcap: Allow floating point split intervals.
Update the `-i` option to allow floating point values as suggested at
https://stackoverflow.com/questions/57004719/split-wireshark-to-miliseconds

Change-Id: I24028d409bc441ed3b45ac2179f7c42b2bc424bc
Reviewed-on: https://code.wireshark.org/review/33938
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-16 06:43:09 +00:00
Gerald Combs e5efd68d3b [Automatic update for 2019-07-14]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ia49e8d1cd5cefbcef6781a4abaab536b9547b4bf
Reviewed-on: https://code.wireshark.org/review/33929
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-14 08:20:51 +00:00
Jeremy Kerr eae522d9cc ncsi: Add NCSI dissector
This change adds a basic dissector for the Network Controller Sideband
Interface (NCSI), as described by DMTF specification DSP0222.

Change-Id: I4e98361bfb7315c524f9c90db38507892adeeebe
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Reviewed-on: https://code.wireshark.org/review/33818
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-03 08:55:02 +00:00
Moshe Kaplan f27c30c2a8 Add comments and reorder Lua example
Change-Id: Iabffbd43645914c92a98f45065ce3baee35d062f
Reviewed-on: https://code.wireshark.org/review/33825
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-03 03:46:51 +00:00
Dario Lombardo 1af6e1f860 tap: add credentials tap.
This new tap collects credentials (username and paassword)
from the dissectors.

So far, few dissectors have been instrumented:
- http (basic auth)
- http (header auth)
- ftp
Others can be instrumented as well using the same technique.

Tshark has a new option (-z credentials) and Wireshark a new
"tools" menu: the documentation has been updated accordingly.

Change-Id: I2d0d96598c85bb3ea4fb5ec090dd8dc28b481fc9
Reviewed-on: https://code.wireshark.org/review/33453
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-06-26 07:09:54 +00:00
Gerald Combs 94f497f929 Qt: Use a lighter link color in dark mode.
Add ColorUtils::themeLinkBrush, which returns a readable link color in
dark mode. Use it in place of existing ...palette().link() calls.

Add ColorUtils::themeLinkStyle, which produces an HTML <style/> block
that lightens the link foreground color in dark mode. Use this to style
links in the about box and in elided labels.

Catch ApplicationPaletteChange events where needed.

Add dark theme / dark mode notes to the WSDG.

Ping-Bug: 15511
Change-Id: I92925bd997f97b155491f55a8c818f03549bc7f4
Reviewed-on: https://code.wireshark.org/review/33704
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-06-25 20:31:41 +00:00
Dario Lombardo 7969c41519 Use I/O Graphs instead of IO graphs everywhere.
Change-Id: I6ce866b03632965dd1bad6eff361d91dd210c62b
Reviewed-on: https://code.wireshark.org/review/33680
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-20 20:01:00 +00:00
Anders Broman c1c0a2911b NRPPa: Add dissector for TS 38.455 V15.2.1
Change-Id: I66da8ced410163c872af1d4161f2c9fc38f72ff8
Reviewed-on: https://code.wireshark.org/review/33590
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17 13:12:20 +00:00
Peter Wu 94b211977a Add support for embedding WireGuard keys in a pcapng file
pcapng spec update is here: https://github.com/pcapng/pcapng/pull/62

Bug: 15571
Change-Id: I2f1921b1da70ac0bab8c38dd5138a9dfe7843fea
Reviewed-on: https://code.wireshark.org/review/33300
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17 00:48:29 +00:00
Gerald Combs 178e7ce9a5 Qt: Filter expression toolbar dark mode updates.
Move plus-8.png to stock_icons/8x8 and rename it list-add.template.png
which conforms to the Freedesktop icon naming specifications and makes
it a template icon.

Update our style sheet when we recive a QEvent::PaletteChange.

Ping-Bug: 15511
Change-Id: I4b8ddcb4eb64f11faec21d5df4a3fd7fdc5cf488
Reviewed-on: https://code.wireshark.org/review/33626
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17 00:46:21 +00:00
Moshe Kaplan c6bed35254 WSUG: Clarified and improved phrasing
Change-Id: I1b3b8b7bf5f6460aa779c54881abd53059b26bbb
Reviewed-on: https://code.wireshark.org/review/33606
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17 00:46:03 +00:00
João Valverde 63af1da7e7 Kill libwscodecs plugin library, just use plugins
Change-Id: I085d04840acb53b0b7681787429a2b4e10547cd5
Reviewed-on: https://code.wireshark.org/review/33068
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-11 20:59:39 +00:00
Jon Dennis de44630666 CL3DCW: Added Dual Channel Wi-Fi Dissectors
Initial go at adding the CableLabs Dual Channel Wi-Fi dissector.
Changes:
  . New dissector for CableLabs Layer-3 Protocol ("CL3") IEEE EtherType 0xB4E3
  . New dissector for Dual Channel Wi-Fi (Subprotocol of CL3)
  . Defined EtherType macro for CL3 + description

Bug: 15818
Change-Id: I6edf99d40883c1890659185cc3f0524a2218a6c4
Reviewed-on: https://code.wireshark.org/review/33440
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-11 20:26:56 +00:00
Tomasz Moń 8219ff2ed2 Add FTDI FT dissector to release notes
Change-Id: I89335813a5ec0a0748741bd8fb2f1ee77369bfe4
Reviewed-on: https://code.wireshark.org/review/33554
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-06-11 16:33:34 +00:00
Michael Mann 6476ec79aa Document why extcap utilities can't be run "by hand" on Windows
Bug: 15591
Change-Id: Icb8246ba196df026736ce1e54eb2ace2c7cd49b0
Reviewed-on: https://code.wireshark.org/review/33530
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-09 23:17:31 +00:00
Jaap Keuter 860e73c88f WSDG: Don't make hyperlinks of Gerrit git access links
The URL's used to access the repository with git should not be hyperlinks in
the documentation. These are not intended to be used by a webbrowser.

Change-Id: I2d516f823e58681474f6a2a9e2e229471fbc87f6
Reviewed-on: https://code.wireshark.org/review/33423
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-05-30 21:18:58 +00:00
Jaap Keuter 9d8f55cb05 WSDG: refine text on cloning repository
Text smells of CVS/SVN heratige.

Change-Id: I37c3309781f49149b2603ae32087ed01363460ee
Reviewed-on: https://code.wireshark.org/review/33421
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-05-30 12:41:01 +00:00
Slava Bacherikov 9fa13ff70d [packet-gelf.c] Add dissector for GELF protocol
Add dissection for Graylog Extended Log Format (GELF) over UDP.

Bug: 15776
Change-Id: Ie976a1dee8d3441532f209061aef5c804219f289
Reviewed-on: https://code.wireshark.org/review/33184
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-28 03:38:13 +00:00
Dario Lombardo 1f75694f14 docbook: add a link to the gerrit manual explaining change-ids.
Change-Id: I775e05bac8b0f8988d503bde6091922d2fab2583
Reviewed-on: https://code.wireshark.org/review/33381
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-28 03:33:29 +00:00
Uli Heilmeier d4836d1efe WSUG: Update vlan resolving
Update documentation to profile aware vlans file.

Change-Id: I210964528663bdf7e3e20e623eda1d93a26f7486
Ping-Bug: 15795
Reviewed-on: https://code.wireshark.org/review/33387
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-28 03:32:35 +00:00
Graham Bloice 93303118d4 Developers Guide: Fix issue with Windows env vars
Change-Id: I2f78cf59267196c2994f7f16934562074afa9f4f
Reviewed-on: https://code.wireshark.org/review/33358
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2019-05-25 18:25:22 +00:00
Graham Bloice 0636c267d9 developers-guide: restore winflexbison to Windows install
Change-Id: I46d0822b2939793990b7e0ef6a34bd421335c919
Reviewed-on: https://code.wireshark.org/review/33337
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-24 03:43:32 +00:00
Dario Lombardo 4cfe3fb6e0 docbook: add section from wiki.
The section "Writing a Good Commit Message" from the wiki has been
incorporated in the wsdg.

Missing parenthesis fix, while here.

Bug: 15752
Change-Id: I93f2a6956d366b3e1db0deab6d884f67748d3c54
Reviewed-on: https://code.wireshark.org/review/33254
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-20 04:20:13 +00:00
Moshe Kaplan f8e80f33f1 WSDG: Clarified and expanded Lua docs
Change-Id: Ib108ac256654ede1fd2ba5f0c87604e87b7ed5fb
Reviewed-on: https://code.wireshark.org/review/33216
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-20 04:19:42 +00:00
Solganik Alexander b06dcb32c7 nvme-tcp: Add nvme-tcp dissector
This patch adds support of NVMe/TCP (NVM Express over Fabrics for TCP).
to wireshark.

NVM Express is high speed interface for accessing solid state drives.
NVM Express specifications are maintained by NVM Express industry
association at https://nvmexpress.org/.

NVMe/TCP is the TCP transport binding specification
which recently ratified (Technical Proposal 8000) and is a part
of NVMe-oF spec version 1.1.

Reference can be found here:
https://lwn.net/Articles/772556/
and protocol specification:
https://nvmexpress.org/welcome-nvme-tcp-to-the-nvme-of-family-of-transports/

Supported commands are
*) NVMe/TCP ICREQ, ICRESP.
*) NVMe Fabrics commands
*) NVMe commands that are supported by packet-nvme dissector.

Testing is done with Linux 5.0 nvme-tcp host and target drivers.
H2C and C2H termination PDU`s are not supported as Linux NVMe/TCP driver
does not support them as well in kernel 5.0

Bug: 15735
Change-Id: I63ae7aa2a42ff843b9832110830fd345f30d9170
Reviewed-on: https://code.wireshark.org/review/32640
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-05-13 06:11:52 +00:00
Gerald Combs af80a96e8a Docbook: Remove an example capture file.
Remove docbook/examples/test.cap. According to Git we've never used it.

Change-Id: Ie789862fd3c9448a306194e6f5b3d1b92cb11084
Reviewed-on: https://code.wireshark.org/review/33139
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-10 03:43:36 +00:00
Harald Welte aa8d948cf4 3GPP CBSP (Cell Broadcast Service Protocol) dissector
This protocol is spoken between the BSC (Base Station Controller) and
the CBC (Cell Broadcast Centre).  It runs over TCP Port 48049 and is
specified in 3GPP TS 48.049.

Change-Id: I183e4741e2db5b9cc4dfe2b89f7920a32af67971
Reviewed-on: https://code.wireshark.org/review/29745
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-08 10:15:34 +00:00
João Valverde 186f985793 CMake: Check for and use system SpeexDSP library
Change-Id: I8443379d23a2946dd21c12e5e0bd5464ab73ca25
Reviewed-on: https://code.wireshark.org/review/31857
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j@v6e.pt>
2019-05-02 21:12:01 +00:00
Gerald Combs cec5991f40 Windows: Modernize our WSAStartup usage.
Make sure we link each application that calls WSAStartup with ws2_32.lib.
Pass version 2.2 to WSAStartup. Wikipedia says it was introduced in 1996,
so we should be OK.

Ping-Bug: 15711
Change-Id: I431839e930e7c646669af7373789640b5180ec28
Reviewed-on: https://code.wireshark.org/review/33033
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-05-01 17:51:59 +00:00
Peter Wu bb757e661a docbook/faq.adoc: remove execute bits
Change-Id: I9f4b2f5bd1646362fe5c0bb2dd98aa923abb78fe
Reviewed-on: https://code.wireshark.org/review/32971
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-24 22:23:21 +00:00
Peter Wu 6f31151f07 docbook: fix broken image link on ChLibsNpcap
Only warning, note and tips admonitions are documented for use in the
"Typographic Conventions" section. Asciidoctor also supports IMPORTANT
and CAUTION, but we do not use it. Remove it to avoid broken pictures.

Extcap is another user, but that is being removed in another patch.

Change-Id: Iea7c9e67ddb978ae1b9c18e5d8f65b0cfb0d6f2c
Reviewed-on: https://code.wireshark.org/review/32936
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-04-22 18:01:13 +00:00
Dániel Bakai 9ce60b173b Add brotli decompression support for HTTP and HTTP2 dissectors.
Change-Id: I9c09f55673187f6fee723fcd72798fb6b9958b03
Reviewed-on: https://code.wireshark.org/review/32745
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-22 15:24:46 +00:00
Peter Wu 0974b68f5c WSDG/Capture: Fix typo in extcap_example.py name
Change-Id: I0f1bff75e90f37d07afcbe3bb786965db9cb442e
Reviewed-on: https://code.wireshark.org/review/32900
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-19 17:38:20 +00:00
Moshe Kaplan 27dd00b30c Readability improvements to WSUG - Introduction
Change-Id: I39270092772daa0c119c2fb2ece2fcb1cbad2d8c
Reviewed-on: https://code.wireshark.org/review/32867
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-15 22:59:44 +00:00
Moshe Kaplan 75b03ac485 Improve phrasing in wsug-preface
Change-Id: I3460abadb36f77ec9d3eaac694a070b9a8eccdd0
Reviewed-on: https://code.wireshark.org/review/32838
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-04-12 20:20:37 +00:00
Joel Colledge 39299a13cb DRBD: Add dissector for the Distributed Replicated Block Device protocol
Bug: 15589
Change-Id: Iab2284f79130b0ab024e7ab00c0774d1907077db
Reviewed-on: https://code.wireshark.org/review/32332
Tested-by: Petri Dish Buildbot
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-11 23:37:01 +00:00
Moshe Kaplan 2cb8bed2e4 Update docs for WinPcap to Npcap switch
Change-Id: I23287165c3aaf11327a3320282fa9eebe23e2a22
Reviewed-on: https://code.wireshark.org/review/32616
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-29 07:06:10 +00:00
Gerald Combs d5f431b1ec WSUG: Update deprecated syntax.
Asciidoctor 2.0.0 deprecated "footnoteref". Use "footnote" instead.

Change-Id: Ic7eeabcb20ddbb5137c24c6861b01168879235d9
Reviewed-on: https://code.wireshark.org/review/32592
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-26 22:10:53 +00:00
Gerald Combs f717932af2 [Automatic update for 2019-03-24]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ib05f06638757aa7d96f6ebfd4cfb5baaf347bf99
Reviewed-on: https://code.wireshark.org/review/32552
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-24 08:32:56 +00:00
Gerald Combs 62e8dba893 WSUG: Update the requirements section.
Change-Id: I84e7e0b22e1933385d6e928cc83ebd485beada06
Reviewed-on: https://code.wireshark.org/review/32470
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-18 16:29:43 +00:00
Gerald Combs 9887fe3d15 WSDG: Describe our tag naming conventions.
Change-Id: Icb8ba1be843b8a109713df9260330df5b215bf0b
Reviewed-on: https://code.wireshark.org/review/32318
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-04 18:35:06 +00:00
Gerald Combs ad45f19196 [Automatic update for 2019-03-03]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I1dcc92c6de3028af82556e6713451c3473fdb2d0
Reviewed-on: https://code.wireshark.org/review/32295
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-03 08:33:26 +00:00
Gerald Combs 0fcf4b1de9 [Automatic update for 2019-02-24]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: If37808291aca1f9bdd75d064bbfb738b89945eb8
Reviewed-on: https://code.wireshark.org/review/32180
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-24 08:32:11 +00:00
Maximilian Kohler 334f7e1fd9 eCPRI: added new dissector
evolved Common Public Radio Interface (eCPRI) is a protocol, which will
be used in fronthaul transport network. It will be included in standard
ethernet frames and UDP frames.
There are 8 Message Types to decode with eCPRI Specification V1.2.

Bug: 15510
Change-Id: I2bb74c1e95e89f0b812492509a05395d6b86eb54
Reviewed-on: https://code.wireshark.org/review/32004
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-19 18:50:48 +00:00
Gerald Combs 3b8bf168e6 WSDG: Let Windows developers know that they need Perl.
Add an "Install Perl" section to the "Win32/64: Step-by-Step Guide"
section. Recommend Strawberry Perl first there and in the "Microsoft
compiler toolchain" chapter under the theory that if it's good enough
for Larry Wall then it's good enough for us.

Bug: 15512
Change-Id: I9a01c7ae2da01b98fd20b64d29144577a8f456b2
Reviewed-on: https://code.wireshark.org/review/32088
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-19 08:44:33 +00:00
Peter Wu ba1ef0ec3d Re-implement "Map" feature for Endpoints
This feature was removed in v2.5.1rc0-427-gf529ab5d0a, anticipating that
MaxMind would remove support for it in 2019. They have however changed
their mind and maintained latitude and longitude information.

They recommend displaying an accuracy radius, but the reported values
are 50, 100, 200 and 1000km. When implemented literally, a marker in
Ireland would cover the whole island plus mainland, so I have instead
opted to use a fixed radius of 1km at deeper zoom levels.

The old ipmap.html file was outdated and had broken tiles, I rewrote a
new one from scratch using the light-weight Leaflet library combined
with tiles from OpenStreetMap. This is more mobile-friendly and secure
(https, SRI). To improve handling of nearby or overlapping nodes,
clustering is used (individual nodes can still be inspected).

Browser compatibility results: IE8 is unusable, IE9 partially works
(tooltips sometimes disappear and the cluster radius control is gone),
IE11 works. Of course Firefox 65 and Chromium 72 have no issues.

The map popup description in the generated GeoJSON structure is now
split in several properties, allowing presentation to be handled by the
HTML page instead of the C code.

Bug: 14693
Change-Id: If2ec9c518f7723ac0ab27b6272463356875a0ff2
Reviewed-on: https://code.wireshark.org/review/31952
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-02-16 21:11:12 +00:00
Guy Harris 751ab080eb Remove whitespace from the end of the line.
Change-Id: I9dc504e8f5ab97021876f12376ac2c6f20258288
Reviewed-on: https://code.wireshark.org/review/32052
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-16 00:41:44 +00:00
Guy Harris b88e2325bb VS 2017 and later include the redistributables even in Community versions.
Change-Id: I540273976dc0e99620894b45b7fa14093e55aa08
Reviewed-on: https://code.wireshark.org/review/32051
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-16 00:37:05 +00:00
Guy Harris 693d04f281 Give the current URL where you can find the VS redistributables.
(Fix a typoo while we're at it.)

Change-Id: I2129c301ea377a9fb48b3f5abd418f7319659638
Reviewed-on: https://code.wireshark.org/review/32050
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-15 22:17:33 +00:00
Gerald Combs b658de2fa7 Rename our .asciidoc files to .adoc
As noted in "AsciiDoc Recommended Practices" at
https://asciidoctor.org/docs/asciidoc-recommended-practices/, the
AsciiDoc/Asciidoctor community seems to have settled on ".adoc" as a
file extension and that's the one preferred by the Asciidoctor project.
Update our filenames to match.

Change-Id: I2d352623d42d65d950b64310c3655b0fd177ee8c
Reviewed-on: https://code.wireshark.org/review/32037
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-15 05:17:26 +00:00
Gerald Combs 23c9a1e036 Convert the FAQ to Asciidoctor and remove old help files.
Convert our self-generating FAQ to Asciidoctor via the following steps:

- `help/faq.py > /tmp/faq.html`.
- `pandoc -t asciidoc -o docbook/faq.adoc /tmp/faq.html`.
- Manually clean up the markup using a text editor.

Question and answer content was left intact. Removing or updating
obsolete content will have to be done in a separate change.

The Asciidoctor project uses the .adoc extension, so start using it here
as well.

The contents of the "help" directory appear to have been used for
offline support in help_url.c, but that functionality was removed in
2008 in 242e3b78bc. Its content is covered in the User's Guide and man
pages so remove it.

Change-Id: I9060eefe97cfc137f8b414077c30f814379b576a
Reviewed-on: https://code.wireshark.org/review/32014
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-14 23:11:15 +00:00
Gerald Combs 55db3d523d [Automatic update for 2019-02-10]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I3ac8fcfec83e5d35ee07e07cd0d1d04a17cc2ac5
Reviewed-on: https://code.wireshark.org/review/31954
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-10 08:28:46 +00:00
Gerald Combs aabce6151c WSDG: Windows toolchain updates.
Update some items in the toolchain section.

Change-Id: I3c2035873d4ee311b639dd3b5c94e3530abad8bc
Reviewed-on: https://code.wireshark.org/review/31944
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-08 20:28:04 +00:00
Gerald Combs 0173337c91 CMake: Make sure we deploy Qt PDBs on Windows.
Pass "--pdb" to windeployqt 5.6 and later.

Add a note about installing the "Qt Debug Information Files" component
to the Developer's Guide.

Change-Id: I81329bc9f9131050b1076fe275445b6325c24794
Reviewed-on: https://code.wireshark.org/review/31921
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-07 04:41:04 +00:00
Gerald Combs 9c49840d1c Release notes: Fix our version.
Change-Id: I6b2270c65dcd466fe7bd49f9d0611be85a1fd266
Reviewed-on: https://code.wireshark.org/review/31920
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-06 19:53:53 +00:00
Gerald Combs c3a8bb3758 Release notes: Clear out 3.0 content.
Change-Id: Ibfebe2f72878326d9c7abee077d731352851ea41
Reviewed-on: https://code.wireshark.org/review/31918
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-06 19:39:04 +00:00
Pantar Ana 8176b492d8 ebhscr: add ebhscr dissector
ElektroBit High Speed Capture and Replay protocol is produced by a
PCIe Card for interfacing high speed automotive interfaces.

Bug: 15474
Change-Id: Ibb3ea36d9281b2779e2cc13d29b66dc382782ca3
Reviewed-on: https://code.wireshark.org/review/31847
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-05 05:02:44 +00:00
Gerald Combs 2ed12a238b 2.9 → 3.1.
Change-Id: Iea6b55037bfb62d2e9b333148cbdc55fcd53dfa2
Reviewed-on: https://code.wireshark.org/review/31888
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-05 01:21:10 +00:00
Gerald Combs 0fc6489bf9 Release notes: Add a note about Qt 5.12.1.
Change-Id: If9f423f6da6aa19f94fc1759f03920f63f8c284c
Reviewed-on: https://code.wireshark.org/review/31881
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-04 20:21:24 +00:00
Stig Bjørlykke 6aad32583d tshark: Improve options help texts
Align the usage help text for '-' as filename for stdin and stdout
with the text used for wireshark.

Change-Id: I67011b8234616940b7878fd5768c9e2a9e79f9f0
Reviewed-on: https://code.wireshark.org/review/31838
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-31 13:16:54 +00:00
Peter Wu fec117b99a Qt: Add support for RSA private key file selection
Update release notes now that this GUI is mostly functional.

Change-Id: I118fbbe879e366643084f0e7ac3e437a29f21d5f
Reviewed-on: https://code.wireshark.org/review/31797
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29 23:34:14 +00:00
Stig Bjørlykke 5b6ba0c119 doc: Add custom window title enhancements to release notes
Change-Id: I8911a55e4f4952095b9ab64d373a6faa19729f63
Reviewed-on: https://code.wireshark.org/review/31801
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29 20:38:52 +00:00
Craig Jackson 58861b07ee TDS: Fix colmetadata handling of Text and Image types
The Colmetadata handling for TEXT, NTEXT, and IMAGE types was incorrect for
TDS 7 versions before TDS 7.2. In addition, the macros using for testing
versions were incorrect.

Clean up max length display to agree with Microsoft specification (as best
as I can understand it).

Bug: 3098
Change-Id: I8254649fd3de97c103078ceaac1557fde3569ded
Reviewed-on: https://code.wireshark.org/review/31734
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-28 05:01:08 +00:00
Peter Wu 1527177cb9 TCP: pass data after a ZeroWindowProbe to subdissectors
If the single byte within a ZeroWindowProbe triggers reassembly within a
subdissector, a new MSP will be created with just a single byte. Be sure
not to mark subsequent segments that contain the full segment data as
retransmission as this prevents the subdissector from seeing the data.

Bug: 15427
Change-Id: I36ae2622689c6606c99cdff70b6beba4b9d25ca7
Reviewed-on: https://code.wireshark.org/review/31732
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jasper Bongertz <jasper@packet-foo.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-27 09:47:54 +00:00
Peter Wu 596f538b5b TCP: do not mark data following a ZeroWindowProbe as retransmission
The single byte within the ZWP could be retransmitted with the next
segment, this is perfectly acceptable behavior. Do not flag these new
segments as retransmissions or Out-Of-Order.

Bug: 15427
Change-Id: I76db2b7a2b684c8c78fa24c9c4b457e1833d12b7
Reviewed-on: https://code.wireshark.org/review/31731
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jasper Bongertz <jasper@packet-foo.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-27 09:47:44 +00:00
Peter Wu 8c698ffc99 Test: enable capture tests by default using the Loopback interface
Avoid pinging www.wireshark.org, this removes an external dependency.
Instead send small UDP datagrams to UDP port 9 (discard) every 50ms.

Enable this for all platforms (including macOS and Linux) by default.
On Windows the tests requires Npcap and will be skipped with WinPcap.
Remove the --capture-interface option since it is no longer needed.
Copy WSDG Wireshark Tests Quick Start to README.test and add a link.

Change-Id: Id4105a6b1e95407ebf69b871c785c68f9ae26368
Reviewed-on: https://code.wireshark.org/review/31677
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-24 00:26:17 +00:00
Peter Wu 079fbb8b82 editcap: document --inject-secrets in --help
Change-Id: Icc027f3c53e1da580c2e49042134b1075ad65cf2
Reviewed-on: https://code.wireshark.org/review/31666
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-22 04:58:53 +00:00
Jaap Keuter 020c90fd36 Text Import: update code comments and help texts
From the updates to text2pcap take the updates to the code comments and
apply them here as well. This also applies to the User Guide help texts.

Change-Id: I4e73fb1372ea0c1866c6d0fee7c14bc645fbe1b1
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/31636
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-21 21:03:49 +00:00
Peter Wu 0971d20452 test: fail tests when programs are missing
Building only a subset of programs is not a very common situation, it is
more likely that some feature was accidentally disabled. For that
reason, fail tests by default unless a program is explicitly permitted
to be missing.

The '-v' test is now dropped from the Travis tests, the sole reason of
adding it was to see which tests got (accidentally) skipped.

Change-Id: I725f4508541d8ed980e17d69fb7aee1ad2875d73
Reviewed-on: https://code.wireshark.org/review/31660
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-21 16:46:17 +00:00
Peter Wu bdba8e3829 release-notes: add developer/distribution-specific updates
Mention some changes to aid developers and distributors.

Change-Id: Ifd33796fd3b4883275c034021d25ae9b35eef1a5
Reviewed-on: https://code.wireshark.org/review/31651
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-21 14:16:58 +00:00
Gerald Combs be103a4286 [Automatic update for 2019-01-20]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I18a5419a2953f5893aa76e2823c50d48e284b270
Reviewed-on: https://code.wireshark.org/review/31625
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-20 08:30:30 +00:00
Dario Lombardo 18cd173974 docbook: use fixed space section for filters code.
Change-Id: I6052bc3ec9705a272d0cd6f31cf8b5c1f4b8d45c
Reviewed-on: https://code.wireshark.org/review/31573
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-18 07:52:40 +00:00
Peter Wu cbe7f26a86 DTLS: add DSB support, use the key log file from the TLS dissector
The DTLS and TLS dissectors already share code for parsing the key log
file contents but the actual key material was stored separately. As
implementations (like GnuTLS) write the TLS and DTLS secrets to the same
file (specified by the SSLKEYLOGFILE environment variable), it seems
reasonable to combine them.

This also enables use of the pcapng Decryption Secrets Block for
decryption of DTLS traces. The dtls.keylog_file preference has become
obsolete and can no longer be used (this was not tested anyway).

A new test was added based on dtls12-aes128ccm8.pcap, the master secret
was extracted using the tls.debug_file preference.

Bug: 15252
Change-Id: Idfd52c251da966fe111dea37bc3fb143d968f744
Reviewed-on: https://code.wireshark.org/review/31577
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-17 21:33:25 +00:00
Peter Wu 1af39d6dac WSDG: make Testing more accessible, add missing anchors
Rename sections to avoid files named like
_documentation_toolchain.html and _adding_or_modifying_tests.html.

Rewrite the testing introduction to directly show the required commands
for the pytest method. That provides much nicer output and finishes
faster, except when you cannot install extra build dependencies there
should be no reason to avoid it. ctest is removed from the description
since it does not provide many advantages over the test target (except
for the possibility of adding --verbose I guess).

Group some related sections under a "Test suite structure" heading in
order to collect some small sections on a single page.

Fix some other grammatical issues while at it.

Change-Id: I8ab821a67254e62c0fc3d18630e4bc8b0ef872dd
Reviewed-on: https://code.wireshark.org/review/31550
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-17 00:01:22 +00:00
Gerald Combs 1f2f253424 make-version.pl updates.
Read our major, minor, and micro versions from CMakeLists.txt.

Add the ability to set our extra version information differently if our
Git commit is tagged or untagged. Change our extra version placeholder
from "%#" to "{vcsinfo}".

Add --tagged-version-extra (-t) and --untagged-version-extra (-u)
arguments for specifying the tagged and untagged extra formats. Add
--force-extra (-f) so that we can force one format or the other.

Require the major.minor.micro version to be specified when using
--set-version (-v).

Update appveyor.yml and the Developer's Guide to match the new behavior.

Change-Id: I6e5d55470aff7e7c61e75f208e24c4105276905a
Reviewed-on: https://code.wireshark.org/review/31479
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-15 19:20:27 +00:00
Dario Lombardo c3d198c401 dfilter: add string() function.
This function can convert non-string fields into strings. This allows the
user to apply string functions (like contains and matches) to non-string fields.

Examples:

string(frame.number) matches "[13579]$" => for odd frames
string(eth.dst) matches "aa\.bb\.cc\.dd\.ee\..." => to match a group of stations
string(snmp.name) matches "^1.2.3.4" => for all OIDs under a specific node

Change-Id: I18173f50ba5314ecdcd1e4b66c7e8ba5b44257ee
Reviewed-on: https://code.wireshark.org/review/31427
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-14 16:00:29 +00:00
Gerald Combs 7f3349183b [Automatic update for 2019-01-13]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ic7f6b5dd91ca6404909b941c0b4844cb17ef4820
Reviewed-on: https://code.wireshark.org/review/31522
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-13 08:32:04 +00:00
Peter Wu 3cc0cfc48c CMake: try harder to find the right Python version
The FindPythonInterp module does not verify that a discovered 'python'
program is actually Python 3. Replace this deprecated module by a modern
version that was introduced with CMake 3.12.

Remove PYTHON_EXECUTABLE from WSDG now that it is much more likely that
CMake discovers the right version.

Change-Id: I1f8438baced3d5bf9e1e2732980ad177d3257ca3
Reviewed-on: https://code.wireshark.org/review/31468
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-10 06:42:08 +00:00
Gerald Combs 1243976ccd Move make-version.pl to tools.
Move make-version.pl to the tools directory.

Change-Id: I7c3ec8951a682d45d650e3fdb1580d90bf19e8b4
Reviewed-on: https://code.wireshark.org/review/31473
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-10 05:18:29 +00:00
Gerald Combs 69a7caac06 WSDG: Move README.packaging to the Developer's Guide.
Move doc/README.packaging to the Developer's Guide and update the
content.

Change-Id: I25fda6cade8f3cfd11af865745bedd0fb5a7c86f
Reviewed-on: https://code.wireshark.org/review/31474
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-10 05:17:48 +00:00
Peter Wu aac30ba2d1 CMake,WSDG: Remove Cygwin support
Declare Cygwin as unsupported and remove all supporting code. Simplify
some Chocolatey notes in the WSDG.

Remove FindPerl.cmake as it only existed to force use of Wireshark's
bundled FindCygwin.cmake (bug 13922). FindXSLTPROC.cmake special
handling for Cygwin was also removed, in theory this could cause issues
when the PATH contains a Cygwin xsltproc, but it's unsupported anyway.

Change-Id: Iabfac2b4a9fd930530505d27bdba618bdb8f7f34
Reviewed-on: https://code.wireshark.org/review/31452
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-09 04:21:50 +00:00
Gerald Combs 2b7615e603 [Automatic update for 2019-01-06]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I0e282baebc0cda0e54e49eff60827eec02f6f797
Reviewed-on: https://code.wireshark.org/review/31402
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-06 08:26:31 +00:00
Guy Harris 824baf9e16 Fix typo.
Change-Id: I03291922ddef34ab1408684df650dbac191a2020
Reviewed-on: https://code.wireshark.org/review/31401
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-06 07:17:38 +00:00
Guy Harris 9a20acc071 Fix link, don't put it separately from the introductory words.
Change-Id: If144fb08d27886ae1bf3610c2157c8a25d1de75e
Reviewed-on: https://code.wireshark.org/review/31400
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-06 07:11:18 +00:00
Guy Harris 44c662ce66 Replace ancient notes about modifying libpcap with a link to a newer doc.
Instead of giving horribly out-of-date instructions on how to add a new
module to libpcap, just point to the document that I started whipping up
earlier today (it definitely needs work - it's incomplete - but I'll be
getting back to it).

While we're at it, update the notes on adding support for new LINKTYPE_
values to libwiretap, and note that it's only necessary if you had to
add a new DLT_ *and* there isn't already a WTAP_ENCAP_ value that would
correspond to that DLT_.

Change-Id: I3882d0a57b29e98f73c074317bc6df7458fcc677
Reviewed-on: https://code.wireshark.org/review/31397
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-06 03:34:58 +00:00
Peter Wu 40b2ba8e7b WSDG: update testing section to cover use of pytest
Remove traces of the "config" module, it was removed. Add a new section
on using pytest.

Change-Id: I763fc53359157f5fcb04198ed98e2d7f7a2c7220
Reviewed-on: https://code.wireshark.org/review/31372
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-05 06:47:39 +00:00
Gerald Combs 340ad1793b Finish migrating to Asciidoctor's modern syntax.
Finish migrating the User's and Developer's guides to modern syntax.
Remove :compat-mode: from attributes.asciidoc.

Change-Id: I1232676c6ef4c3638253d070dcbae6d3c1ead284
Reviewed-on: https://code.wireshark.org/review/31374
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-04 21:49:59 +00:00
Gerald Combs 1db84c9330 WSDG: Add a note about Npcap licensing.
Expand the Npcap text. Make it clear that you might need to purchase a
license to redistribute Npcap.

Change-Id: I9340ed2d363e66443797478c59859ce10d648aff
Reviewed-on: https://code.wireshark.org/review/31351
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-04 05:07:07 +00:00
Gerald Combs 5dfec5f64f WSDG: Stop recommending DDD.
Drop mentions of DDD in favor of Qt Creator, CLion, and Eclipse. From
looking at https://sourceware.org/gdb/wiki/GDB%20Front%20Ends I'm
guessing that those have superseded DDD, as nice at it is/was.

Change-Id: I445a909ab8c8aa73c90f868d6b0958bb8faf62d6
Reviewed-on: https://code.wireshark.org/review/31353
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-04 05:02:37 +00:00
Guy Harris c7ac27b288 Put a period at the end of a sentence.
Change-Id: Ifad6b9a09bc052d687cefe3ccda8c07ad765abda
Reviewed-on: https://code.wireshark.org/review/31350
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03 22:01:43 +00:00
Guy Harris fae1db0326 Slight fixup for where the capture code lives.
The full explanation is a bit more complicated - we'd have to mention
the dumpcap/*shark split, and the code on both sides of the split.

Change-Id: I43f8fc3c589bdf900e20714b55a3b4f544879bc2
Reviewed-on: https://code.wireshark.org/review/31349
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-03 21:57:34 +00:00
Gerald Combs c39bc2a4f6 WSDG: Miscellaneous updates and fixes.
Update the Windows CRT text to mention the Universal CRT.

Replace references to WinPcap with Npcap.

Update the Qt LTS text.

Add a WiX / .msi section

Use curly quotes.

Use the {cpp} attribute so that the "++" in "C++" doesn't trigger
monospace formatting.

Make the various "Unix" and "Windows" subsection title names uniform.
Give them the "discrete" attribute so that they don't clutter up the
TOC.

Title-case section titles.

Remove the reference to m4. As far as I can tell we don't require it.

Change-Id: I73f851adae640f77205781d6c4962002c2d53f49
Reviewed-on: https://code.wireshark.org/review/31343
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-03 21:38:49 +00:00
Peter Wu 1d7ed3d8fe release-notes: document TLS and library changes
Change-Id: I3af4cb96a6c87205cdd6c85c27977366cb77291f
Reviewed-on: https://code.wireshark.org/review/31327
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-03 15:54:45 +00:00
Kenneth Soerensen 6fa164e7c4 Add dissector for Great Britain Companion Specification (GBCS)
The Smart Metering Equipment Technical Specifications (SMETS) requires
that Gas Smart Metering Equipment (GSME), and Electricity Smart
Metering Equipment (ESME) including variants, meet the requirements
described in the Great Britain Companion Specification (GBCS).

GBCS messages are end-to-end and contains ZigBee, DLMS or ASN.1
formatted payloads. The GBCS messages are transported via IPor via
the ZigBee Tunneling cluster.

https://smartenergycodecompany.co.uk/document-download-centre/download-info/gbcs-v2-1/

Bug: 15381
Change-Id: I28ca9831fc266a6abd310db103306b98786e63f9
Reviewed-on: https://code.wireshark.org/review/31168
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Martin Boye Petersen <martinboyepetersen@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-03 04:02:15 +00:00
Gerald Combs 0a4942eda5 WSDG: Update the find and goto images and descriptions.
Change-Id: I3e8fcc3b2c940e241d4c38c2b03d4ec44bcd319e
Reviewed-on: https://code.wireshark.org/review/31280
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31 21:21:21 +00:00
Jaap Keuter 5016cd478e CESoETH: Add dissection of MEF 8 CES over Ethernet
Add dissection of Metro Ethernet Forum specification of Implementation
Agreement for the Emulation of PDH Circuits over Metro Ethernet
Networks [MEF 8]. This includes the introduction of a RTP shim header
dissection function, as is not uncommon in PW and CES services.

Signed-off-by: Jaap Keuter <jaap.keuter@aimvalley.nl>
Change-Id: I6de81007ce11793cd5352fadadd80d3f6f45ae0d
Reviewed-on: https://code.wireshark.org/review/31239
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-12-31 10:59:45 +00:00
Gerald Combs ba32436f60 WSDG: Update packet list and popup images and descriptions.
Update the images and descriptions for the packet list, column header
popup, packet list popup, and packet detail popups.

Add images and descriptions for the byte view popup.

Use title case in more places.

Change-Id: Icf3af426c97c6e7cf97dee377c20039b7b8791ce
Reviewed-on: https://code.wireshark.org/review/31271
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-31 08:25:30 +00:00
Gerald Combs 0f7812f5ef [Automatic update for 2018-12-30]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ic8eac1cb4b08b5d567ef5bd3a52062eca095458c
Reviewed-on: https://code.wireshark.org/review/31254
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-30 08:27:10 +00:00
Peter Wu 604aef7164 Windows: fix handling of Unicode paths in Lua
Lua internally uses ANSI C APIs (such as fopen). On many systems (macOS
and Linux for example) these work fine with UTF-8. Windows however
requires special Unicode APIs (such as _wfopen), so patch the Lua
library to interpret paths are UTF-8 and call appropriate Unicode APIs.

Changes compared to the previous LuaBinaries zip archive:

- Patched with UTF-8 support for loadfile, os.execute, etc.
- Built with VS 2015 (VCRUNTIME140.dll) instead of MinGW (MSVCRT.dll).
- Includes PDB file for lua52.dll
- Includes lua52.exe and luac52.exe with UTF-8 argv support (wmain).
- Includes build scripts, source files and README.md.
- Extra subdirectory named after the zip file.

These zip files are taken from https://github.com/Lekensteyn/lua-unicode
(the "prepared" source zips can be found here as well.)

Bug: 15118
Change-Id: I219f046d6e0fd5093287b5d6503a48ba7d1fc6a4
Reviewed-on: https://code.wireshark.org/review/31165
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-29 08:27:08 +00:00
Craig Jackson 52b7c8929a Z39.50: Implementation of Z39.50 Information Retrieval protocol
NISO Z39.50 is a protocol used by libraries and library vendors for information retrieval and catalog manipulation. It is defined using ASN.1 using BER encoding. It has an assigned TCP port of 210. This is an initial implementation.

Features:
- The Z39.50 standard OIDs are defined.
- The bib-1 attribute set is decoded.
- The bib-1 diagnostics are decoded.
- Some OCTET STRINGs which are nearly always printable ASCII are special-cased.
- The MARC (MAchine Readable Cataloging) format is decoded. Only the MARC21 variant is
  currently handled, but this is one of the most common variants. The most common tags
  are decoded. The MARC dissector is included in the Z39.50 dissector, but the code is
  structured in such away that it could be pulled out.

Todo:
- Add information to the Wiki about Z39.50.

As part of this work, the definition of isdigit_string() was fixed to avoid const complaints.

Change-Id: I29a7db53375ef8be83738a1ab98707761d878717
Reviewed-on: https://code.wireshark.org/review/31209
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-28 09:28:17 +00:00
Alexis La Goutte 79c4f0ffbb Qt: Add Ukrainian (uk) translation
No yet available at 100% (35,8%) but work in progress...

Change-Id: I3d0d861037abe5e5f2611f95ac27ad42c8d20c47
Reviewed-on: https://code.wireshark.org/review/31158
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-23 06:49:22 +00:00
Alexis La Goutte 8eb3ef85fe Qt: Add Swedish (sv) translation
No yet available at 100% (57,05%) but work in progress...

Change-Id: I3fa95c49003aa6fd5183d24fe76b721520a44ba0
Reviewed-on: https://code.wireshark.org/review/31157
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-23 06:49:08 +00:00
Gerald Combs 54711eeac7 NSIS: Expand our vcredist exit code check.
Along with checking for exit code 3010 (reboot required), check for
other errors and show a warning as needed.

Add a note about the Universal CRT to the User's Guide.

Bug: 15358
Change-Id: Ia49dbdc66edc8ea68f957ec353f1115536002d13
Reviewed-on: https://code.wireshark.org/review/31100
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-19 04:50:21 +00:00
Christophe GUERBER c7f7b60c6b ITS facilities message dissector
Dissector for Intelligent Transport System facility messages:
 - Cooperative Awareness Message (CAM)
 - Decentralized Environmental Notification Message (DENM)
 - Infrastructure to Vehicle Information Message (IVIM)
 - MAP (topology) Extended Message (MAPEM)
 - Signal Phase And Timing Extended Message (SPATEM)
 - Signal Request Extended Message (SREM)
 - Signal request Status Extended Message (SSEM)
 - Electric Vehicle Charging Spot Notification (EVCSN)
 - Electric Vehicle - Recharging Spot Reservation (EVRSR)
 - Tyre Information System (TIS) and Tyre Pressure Gauge (TPG) interoperability

Subdissectors:
 - ITS version if ever the ITS PDU header is changed
 - Version << 16 | MessageID to register new message dissectors
 - RegionId << 16 | type to register regional extensions
   AddGrpC regional additions already provided

TAP:
 - its TAP with ItsPduHeader fields provided

Bug: 15148
Change-Id: I4c71d4dfa1d5d63cb57f61a4e1436a60a3482205
Reviewed-on: https://code.wireshark.org/review/31049
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-18 12:31:48 +00:00
Gerald Combs b71c310203 [Automatic update for 2018-12-16]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Iafc95a8b4a651033480dc82de7ecd839cc8fa46c
Reviewed-on: https://code.wireshark.org/review/31060
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-16 08:24:15 +00:00
Christophe GUERBER a87e56aa79 GeoNetworking, BTP dissectors (ITS-V2X)
Implements V2X protocol dissectors:

 * Geonetworking (network layer):
Dissector is registered on top of Ethernet (ethertype=0x8947).  Secured
Packets are dissected up to the basic header, the rest is shown as data.
GN_ADDR address type is registerd and provides resolution of station
type and country code in the address. MID is shown as an ethernet address.
All the fields are dissected for non Secured Packets.
A subdissector table named "geonw.ch.nh" is provided on the next header
field. IPv6 is automatically registered. Heuristic dissectors is not
supported. If no dissector is foundd, payload is shown as data.
A preference boolean allows to enable/disable sequence number checking.
Tap "geonw" gets headers of all packets (with most fields).
Expert info tests if and provide feedback on:
 - version is zero (no other version possible),
 - reserved fields are zeros,
 - payload_len matching with reported length of buffer,
 - Remaining Hop Limit is 1 for Beacon and SHB,
 - low RHL or RHL > Max Hop Limit,
 - country code is less than 999 (3 digits ITU-T E.164),
 - latitude, longitude, heading and angle limits,
 - (suspected) duplicate packets,
 - LS_REQUEST/LS_REPLY matching.

 * Basic Transport Portocol:
BTP-X (X=A or B)  dissectors are registered on top of Geonetworking.
Subdissector tables "btpx.port" allow to register for a given port,
while heuristic dissector can register to "btpx.payload". Decode as
capability is supported.
"btpx" taps get headers of all packets with ports/@ infos.
"btpx_follow" taps get the payload.

Bug: 15148
Change-Id: Iab5f4486d4c38068d9ad4361e77296b747f9b1bb
Reviewed-on: https://code.wireshark.org/review/30992
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-13 21:39:12 +00:00
Luis Rosa 07a22c7bad pcomtcp: new built-in dissector for PCOM protocol
New built-in dissector for PCOM protocol (ASCII and binary modes included)

Bug: 15315
Change-Id: Ie13da6bfd7fefefbc5bb5df3461c7fc18261df81
Reviewed-on: https://code.wireshark.org/review/30823
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-13 05:29:10 +00:00
Gerald Combs 17b721e451 2.9.0 → 2.9.1.
Change-Id: I5c1a26f234289edeb9e29f5b8a8bdd220bd49ecf
Reviewed-on: https://code.wireshark.org/review/31028
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-13 00:40:18 +00:00
Gerald Combs b415c6ede7 Release notes: Add a note about Qt 5.12.0.
Change-Id: Ibe72b940bff14729d06dd46651a5205bd0ddcafe
Reviewed-on: https://code.wireshark.org/review/31025
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-12 23:03:05 +00:00
Gerald Combs 4d6509854c Packaging: Add initial support for AppImage.
Add an "appimage" target that will create an AppImage package. Current
AppImage tools assume that you only have one executable, so add
a custom AppRun wrapper that will let you run our associated CLI
utilities via symlinks, e.g.

    ln -s ./Wireshark-3.2.1-x86.appimage capinfos
    ./capinfos --help

Packaging requires both linuxdeployqt and appimagetool, although we
might be able to reduce this to just linuxdeployqt:

    https://github.com/probonopd/linuxdeployqt
    https://github.com/AppImage/AppImageKit

I haven't done much testing beyond running Wireshark and
capinfos. There are undoubtedly issues that need to be fixed.

Bug: 14464
Change-Id: Ic004ba1962e6a8630ebb017349d9b2c0462fd5fe
Reviewed-on: https://code.wireshark.org/review/30953
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-12 21:02:44 +00:00
Gerald Combs 8ab57eb3d6 Update the release notes.
Clean up the release notes in preparation for 2.9.0 and 3.0.

Change-Id: I7feb37846ce0b1c3caf248f616943b0f80cf60f3
Reviewed-on: https://code.wireshark.org/review/31012
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-11 23:23:41 +00:00
Gerald Combs 86bd968662 [Automatic update for 2018-12-09]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I29aca5c44e8371ffede8b66eebbb366aac7ac4f9
Reviewed-on: https://code.wireshark.org/review/30973
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-09 08:23:06 +00:00
Jaap Keuter a58904f387 PCAP/PCAPNG: Be consistent in documentation, etc
1) The default build configuration is to select PCAPNG as
output format, but it can be selected as PCAP. Some of the
command line tools have the option to select the output
format and default towards the build configuration.
This has to be reflected in their help output also.

2) Various documentation files are still stating that PCAP is
the default format of various tools. With the default build
configuration being PCAPNG these have to be adjusted as well.
(with lack of dynamic content the documentation can only refer
to the default build configuration format).

Change-Id: I51d19642a7ed8c99817971c1f25d20972095021e
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/30951
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07 06:00:14 +00:00
Jaap Keuter 0da8a3dbd3 Doc: add mentioning of ip link to get interfaces
With the introduction of the ip command (from iproute2) on modern
Linux systems it becomes common to see this tool available,
gradually replacing tools like netstat and ifconfig.

Change-Id: I1fb309e741c07c93271b61a35c4833d36bcc5cb8
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/30924
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06 06:26:20 +00:00
Gerald Combs 8c22c5bade Fix some spelling errors found by Lintian.
Change-Id: If6fc3aab7ad4fc634567121f7b9541bc6f6c5766
Reviewed-on: https://code.wireshark.org/review/30926
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05 18:58:19 +00:00
Anders Broman bd8cfad8b8 Add dissection of HI3CCLinkData
Change-Id: I002c31972c4bcc231527eeaa2c6b21c3b1a9636a
Reviewed-on: https://code.wireshark.org/review/30920
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05 13:38:55 +00:00
Alexis La Goutte 3a83a8476a Qt: Add Russian translation
Change-Id: I06044953bbf6040f8a0bb291c2b3e9cbf87c39f4
Reviewed-on: https://code.wireshark.org/review/30869
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-03 04:51:40 +00:00
Gerald Combs bbad3e1870 Release notes: We now ship with Npcap.
Change-Id: Ibb4f886eb061502a141160af5c595adba8205dbc
Reviewed-on: https://code.wireshark.org/review/30891
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-02 22:29:08 +00:00
Gerald Combs 74b0c08905 [Automatic update for 2018-12-02]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Idfe3eaa6b9abd2337590a09972ce44266c2893ca
Reviewed-on: https://code.wireshark.org/review/30880
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-02 08:21:32 +00:00
Jaap Keuter 00a375dfba User Guide: fix reference to menu item
The Supported Protocols list has move from Help to View.
Also everything is presented in one dialog now.

Change-Id: Ie6105741b1307a0de062a33e4f5e3f933cd14caa
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/30845
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-30 15:05:03 +00:00
Milan Stute 6f2ca96359 Add Apple Wireless Direct Link (AWDL) dissector
More information on Apple's proprietary AWDL protocol can be found in
  Milan Stute, David Kreitschmann, and Matthias Hollick. "One Billion Apples'
  Secret Sauce: Recipe for the Apple Wireless Direct Link Ad hoc Protocol"
  in ACM MobiCom '18. https://doi.org/10.1145/3241539.3241566

Bug: 15245
Change-Id: I5ce18125b3c957f338909e46f18e30405a3d3941
Reviewed-on: https://code.wireshark.org/review/30413
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-29 22:12:42 +00:00
Peter Wu bcd32b07e7 Drop support for GnuTLS 2.12.x, require GnuTLS 3.2 or newer
Upcoming changes need GnuTLS >= 3.0.2. Require GnuTLS 3.2 (or newer) for
licensing reasons. The Debian control file still mentions 3.2.14 because
older packages linked with a GMP library that was not GPLv2+ compatible.

RHEL6 only has 2.12.23, but is already unsupported anyway.

Change-Id: I024b2a734ebb16b73a624bb2435c254e963d8b7d
Reviewed-on: https://code.wireshark.org/review/30832
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-29 22:11:27 +00:00
Gerald Combs 0b9810ab97 Add a "No Reassembly" profile.
Add a script that disables all of our desegmentation and reassembly
preferences and use it to create a "No Reassembly" profile.

Change-Id: Icd0b72e9e271a511e637acde9018f3aae018e589
Reviewed-on: https://code.wireshark.org/review/30799
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27 04:38:15 +00:00
Gerald Combs e158a96612 [Automatic update for 2018-11-25]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I4dbb483a58c10480b30da38ba234707344671222
Reviewed-on: https://code.wireshark.org/review/30785
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-25 08:23:45 +00:00
Jaap Keuter 36d26b38d7 Update text2pcap documentation
Various parts of the text2pcap documentation need some fixing up.
This change brings them back in line and up to date with current
features.

Change-Id: I038cf5c4943d2a4bbcc3d0fbd8f5e111dcf0d0a9
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/30754
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-11-21 23:00:31 +00:00
Peter Wu 7059a51ee2 WSDG: update test section with pytest fixtures
Try to describe the motivation of pytest fixtures and update the
examples. Add a missing build dependency in CMake while at it.

Change-Id: I5384a86f2191835b834285b81343a7ee56f88e79
Reviewed-on: https://code.wireshark.org/review/30632
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-14 20:21:02 +00:00
Dario Lombardo 51a2a00b7f fix documentation and tests for cmake run directory.
Change-Id: If33a39c26714ebe699463d1c8c67469025767efb
Reviewed-on: https://code.wireshark.org/review/30581
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-12 12:36:26 +00:00
Jim Borden a8c40412d8 Added support for the Couchbase BLIP protocol
Documentation for the protocol is available at https://github.com/couchbaselabs/BLIP-Cpp/blob/master/docs/BLIP%20Protocol.md

Bug: 15212
Change-Id: I2fe947c3af10c53d68c740241466e2de6c4be551
Reviewed-on: https://code.wireshark.org/review/30229
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-11-11 16:52:16 +00:00
Gerald Combs 9fdd27a196 [Automatic update for 2018-11-11]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I49c9b5a86e33811c59c7e70d5f548d103f7bc35c
Reviewed-on: https://code.wireshark.org/review/30573
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-11 08:25:41 +00:00
Peter Wu 34d3afa3e4 CMake: fix parallel build by not copying ws.css repeatedly
A race condition exists with msbuild where building some targets
(generate_{developer,user}-guide.xml, {developer,user}_guide_pdf) will
result in parallel, repeated execution of the commands to copy 'ws.css'.
Synchronize those executions using a single target to avoid this.

Change-Id: Ie93d07e504bc18fa4e4e8aac5b611fba329ff188
Reviewed-on: https://code.wireshark.org/review/30553
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-09 13:25:22 +00:00
Gerald Combs 11a9a501fb Dumpcap+Qt: Add support for `-a packets:NUM` and `-b packets:NUM`.
Add the ability to rotate files after a specified number of packets (`-b
packets:NUM`). Move some condition checks to capture_loop_write_packet_cb.

Add `-a packets:NUM` in order to be consistent. It is functionally
equivalent to the `-c` flag.

Add a corresponding "packets" option to the Capture Interfaces dialog
Output tab.

Add initial tests for autostop and ringbuffer conditions.

Change-Id: I66eb968927ed287deb8edb96db96d7c73526c257
Reviewed-on: https://code.wireshark.org/review/30534
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-09 05:55:11 +00:00
Peter Wu e9f7bb5127 Require Python 3, drop Python 2 support
Python 3 is widely available. All major Linux distributions support it.
RHEL is covered via EPEL (which is already required for cmake3). Drop
support for Python 2 in order to reduce maintenance costs. The main
motivation is being able to simplify the tests.

CMake is updated to search for Python >= 3.4 and will fail if
unavailable (generating dissectors.c requires Python, so it is quite an
important piece to have).

The documentation is updated to reflect the Python 3.7 paths used by
Chocolatey. Tested the git-review installation instructions in Windows 7
x64 without a previous Chocolatey installation.

macOS brew now installs Python 3 (its dependencies are already installed
by python@2 for libxml2). The macOS (non-brew variant) is updated to use
the official 64-bit installer to install Python 3.

Change-Id: I80b1e36957f338e0dad1bfcc173b6418682cddba
Reviewed-on: https://code.wireshark.org/review/30192
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-07 20:46:59 +00:00
Stig Bjørlykke eac0c131c7 docbook: Fix a typo
Change-Id: I41b3626bdfac54291fb3d8be0deb035c1a9f9f55
Reviewed-on: https://code.wireshark.org/review/30529
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-11-07 09:06:12 +00:00
Anders Broman b53680145c Add dissector for CDMA 2000 3GPP2 C.S0005-E v3.0
Change-Id: Id71c4208297893468dfa7d48e778e25c342f1581
Reviewed-on: https://code.wireshark.org/review/30521
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-06 17:02:37 +00:00
Anders Broman 44d5eca533 Add GCSNA General Circuit Services Notification Application Protocol
dissector.

Change-Id: I8c29b827cd5bc875bc40ee7e9315b0525b0d3263
Reviewed-on: https://code.wireshark.org/review/30520
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-06 17:02:25 +00:00
Maxim Sharabayko 04005c0729 Add Secure Reliable Transport dissector
Bug: 15209
Change-Id: I4353a9d3961a8cd8e7bbc02167d8d6cb1fd76285
Reviewed-on: https://code.wireshark.org/review/30224
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-11-06 10:54:48 +00:00
Anders Broman 4f6e55fcc7 Add dissector for ANSI Local Number Portability Database Query Protocol.
Bug: 15236
Change-Id: I3a04394bf9069f63b90f7a3d60e801a846840839
Reviewed-on: https://code.wireshark.org/review/30515
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-06 08:49:43 +00:00
Dario Lombardo 0a5770a78a extcap: add option to set proxycommand to ssh sessions.
sshdump and ciscodump have been updated to use it.

Change-Id: I4e1e0d35f086d76c13264939bc4f14308cc88cfb
Reviewed-on: https://code.wireshark.org/review/30496
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-05 05:59:38 +00:00
Lajos Olah f68b24d12e UDP/UDP-Lite : Add Conversation timestamps
Change-Id: Ibc6cf4ec014e2798032f7dcd65d119ff3ca1a78d
Reviewed-on: https://code.wireshark.org/review/30476
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-11-04 20:10:39 +00:00
Gerald Combs 4eeea57e2d [Automatic update for 2018-11-04]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Iee0e09f81a210056a76987713b09d95c390f5876
Reviewed-on: https://code.wireshark.org/review/30499
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-04 08:27:38 +00:00
Dario Lombardo e655b9acf9 import: add export_pdu dummy header feature.
When importing a file from hex dump, this change adds a way to
add a custom dummy header. It's an export_pdu header which uses
one single tag: the protocol name. This allows to call directly
a dissector without more dummy headers.

Example: it can be used to call the DNS dissector without fake
eth/ip/udp headers.

Change-Id: I12fd6d09a131acd9bd1f0d7c4c8aefcd0d718b26
Reviewed-on: https://code.wireshark.org/review/30403
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-31 13:17:10 +00:00
Moshe Kaplan 74903893d8 QT: Enable filtering entries in 'Export Objects'
Change-Id: I5e9025545f9127d1c5c6200844f9b917af975998
Reviewed-on: https://code.wireshark.org/review/28844
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-10-29 02:13:08 +00:00
Dario Lombardo e99250e81a release-notes: drop a line about APT-X renaming.
Was missing in 53089029c1.

Change-Id: I76150bf1783c85436ee6c0e38cce7b597f0e850c
Reviewed-on: https://code.wireshark.org/review/30376
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-25 07:34:11 +00:00
mkg20001 5490e4f8c4 Add TSDNS (TeamSpeak 3 DNS) dissector
Change-Id: I1f828df1735bd10ef8849d208e10ea1339ba37e2
Reviewed-on: https://code.wireshark.org/review/26403
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-22 04:46:39 +00:00
Craig Jackson 36483c3ef5 TDS: Update release notes to indicate that Sybase is now supported.
Change-Id: I541226f9ba8981d1014698703b61bd32a7a5c9b1
Reviewed-on: https://code.wireshark.org/review/30254
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-10-18 18:36:39 +00:00
AndersBroman 3eb38bc5ea Add dissector for ITU-t X.696 Octet Encoding Rules (OER).
Bug: 13766
Change-Id: Id1770d8b0bab73ef26af679cba4d88c65cbc21cc
Reviewed-on: https://code.wireshark.org/review/30242
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-18 14:49:14 +00:00
Guy Harris b0759a02bb Update VS command prompt menu names for VS 2017.
At least on my W10 machine, they shols up as "xxx Native Tools
Commmand Prompt for VS 2017", not "VS2017 xxx Native Tools Command
Prompt".

Change-Id: I55d7ad24df717cfce21f6abdaf97ed1972128e3c
Reviewed-on: https://code.wireshark.org/review/30215
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-14 20:55:03 +00:00
Guy Harris 278c1a26fd Update installation instructions for MSVC and Qt.
Change-Id: Id610d4d11a0aaa132c0a528a8dfcb41c1cfc4215
Reviewed-on: https://code.wireshark.org/review/30197
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-13 21:31:17 +00:00
Guy Harris 11c9896a77 We don't support VS prior to 2015 in the master branch.
Change-Id: I16380ca9205832960c0b2e7f43e237797d7671b6
Reviewed-on: https://code.wireshark.org/review/30188
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-12 22:04:19 +00:00
Guy Harris 6a90221770 Fix section anchor.
Change-Id: I5480c643c44698af764297feb77750850ffefde8
Reviewed-on: https://code.wireshark.org/review/30186
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-12 21:16:02 +00:00
Guy Harris 3553ccc773 Consistenly use "Windows native" rather than "Windows Native".
Change-Id: I40164b892e48dc4f484f8e24451b29c68a0da62d
Reviewed-on: https://code.wireshark.org/review/30182
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-12 20:35:13 +00:00
Guy Harris 2d02f1b200 Fix typoes introduced by the previous change.
Change-Id: Ifc3b2c4d51e935f8cb4c5514e6c1f0c4bb9007ba
Reviewed-on: https://code.wireshark.org/review/30180
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-12 20:33:12 +00:00
Guy Harris fd78e3f2ed Some cleanups.
More use of "UNIX-like" as the term for "macOS and Linux and *BSD and
Solaris and AIX and..." or, alternatively, for "not Windows".

Add Fedora as a Linux distribution for which packages are available.

Use "Windows" rather than "Win32" in more cases; "Win32" dates back to
the days when the big difference was between Boring Old 16-bit Windows
and modern shiny new 32-bit Windows, but the former is now dead and the
latter now supports both 32-bit and 64-bit machines and software.  More
people have probably never heard "Win32" but are familiar with
"Windows".

*ALL* UNIX-like platforms support symlinks; Linux wasn't even the first
one, it just picked them up from the UN*Xes with which it was trying to
be compatible.

Change-Id: I254e74f0ed3c86b55d00f9e8d7b78d009b61fb5e
Reviewed-on: https://code.wireshark.org/review/30178
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-12 20:25:24 +00:00
Guy Harris 01ed5b84f3 Updates.
We use VS 2017, not VS 2015, for 2.6.x and development builds.

Microsoft's documentation is moving from msdn.microsoft.com to
docs.microsoft.com.

The way you download pre-2017 versions of VS has changed.

Update links to the Android, GNOME, KDE and macOS human interface
guidelines while we're at it.

Change-Id: I1a3973f76aa5b476cb906b8a8604b82d6131e9c5
Reviewed-on: https://code.wireshark.org/review/30168
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-12 19:11:43 +00:00
Stig Bjørlykke 420c4ecc56 Qt: Add copy from another profile for UAT frames
Add a new button to UAT frames to copy entries from another profile.

Change-Id: I9decb5ed5d67e97388ee7b22a15cacae4d5a3621
Reviewed-on: https://code.wireshark.org/review/30084
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-10-08 21:07:58 +00:00
Stig Bjørlykke ac50aca6ad Release note updates.
Add an entry for the copy from profile feature for coloring rules,
IO graphs and protocol preference tables.

Change-Id: I79a191c1ec13e96fcb1b5fb04dd28c95dd034aca
Reviewed-on: https://code.wireshark.org/review/30070
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-08 17:54:26 +00:00
Uli Heilmeier 8dfaa8fa7c *shark: Update help and manpage for name resolving
Add 'v' option for VLAN ID resolving and get rid of
deprecated 'C' option.

Bug: 14826
Change-Id: I63104f4a465d251048693ad02882ea7eb2c4d926
Reviewed-on: https://code.wireshark.org/review/30029
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-05 13:19:05 +00:00
Martin Peylo c36f11ba55 Add new PKCS#10 support to release notes
Added in commit 2d8e393961

Change-Id: I9a0daa0eaf24384da3b0ed9d0bc92fe868d02229
Reviewed-on: https://code.wireshark.org/review/30007
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-04 06:37:37 +00:00
Gerald Combs 58f0338b13 Add new file formats to the release notes.
Change-Id: Ib46ce218063cb09a277ca0642a532120c9f27b2a
Reviewed-on: https://code.wireshark.org/review/30006
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-10-04 00:01:48 +00:00
Gerald Combs c25ae4a182 Release note updates.
Switch the Capture Interfaces section to paragraphs and add one for
sdjournal.

Change-Id: I677a403bf2ea377214c6179f9f22facc9a4ff091
Reviewed-on: https://code.wireshark.org/review/29963
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-10-01 17:52:56 +00:00
Gerald Combs 5a401ccad9 [Automatic update for 2018-09-30]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ic15ad719f659fe7365c9e652af18507a5d050e6b
Reviewed-on: https://code.wireshark.org/review/29932
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-30 08:30:47 +00:00
Gerald Combs 66352b5e3c Revert "Stop advertising support for Solaris."
This reverts commit 5dd0c8daa5.

Reason for revert: As Guy pointed out, Oracle ships a recent version.

Change-Id: I9689dfd0656d95f7ae57ae86c2bea7d09afddc70
Reviewed-on: https://code.wireshark.org/review/29815
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-24 20:49:06 +00:00
Gerald Combs 5dd0c8daa5 Stop advertising support for Solaris.
Stop listing Solaris as a supported platform. I'm not sure if you can
compile Wireshark out of the box on it any more and the available binary
packages I can find are ancient.

Change-Id: I89afef01abe05986ce660327731c5504c6622ff7
Reviewed-on: https://code.wireshark.org/review/29764
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-21 05:52:23 +00:00
Gerald Combs cd95e197ca Start renaming SSL to TLS.
Rename the "ssl" protocol to "tls" and add an "ssl" alias. Prefer "TLS"
over "SSL" in user interface text and in the documentation.

Fix the test_tls_master_secret test while we're here.

Bug: 14922
Change-Id: Iab6ba2c7c4c0f8f6dd0f6d5d90fac5e9486612f8
Reviewed-on: https://code.wireshark.org/review/29649
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-13 22:37:52 +00:00
Peter Wu 391b8a9595 release-notes: add new features and remove known bugs list
The "known bugs" list is rarely updated. Remove it and add more helpful
and up-to-date references.

Change-Id: I5aea57c66c6645b5c903ebcebcb1676af5204ce2
Reviewed-on: https://code.wireshark.org/review/29048
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-10 17:31:20 +00:00
Alexis La Goutte 3045da8087 release-note: Add EVS dissector
Change-Id: Iab3804d70df4d0eb0b9698407121aa477b0caa27
Reviewed-on: https://code.wireshark.org/review/29559
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-10 14:26:29 +00:00
Guy Harris 7ce18dc465 Clean up the references to ChUserTable.
The references read like

	This table is handled by an Section 11.7, "User Table" with the
	following fields.

which looked a little weird.

Change-Id: I4ae9af48e7edf75aa0c7708614f4a11696db9ee1
Reviewed-on: https://code.wireshark.org/review/29530
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-10 04:26:05 +00:00
João Valverde a93698a4ff Remove the tshark -z compare feature
- It cannot support IPv6.
  - Non-standard use (specifically recommended against in the RFCs)
of the IPv4 fragment ID field.
  - Has a narrow and non-obvious use case, IMO.
  - It is not supported in the Qt GUI.
  - Significant maintenance burden for an obscure feature.

Change-Id: Icaf429269dc42f78c38b8d20001508132499faf8
Reviewed-on: https://code.wireshark.org/review/29239
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j@v6e.pt>
2018-09-09 23:55:19 +00:00
Guy Harris 04ef87a7b8 We build Wireshark with Qt 5.9.5 on Windows; update the developer's guide.
Change-Id: Ifebe4b72f35466ddc78bccc96b145afa400ad715
Reviewed-on: https://code.wireshark.org/review/29460
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-07 08:28:18 +00:00
Peter Wu 6fa2ad4922 Lua: remove various logging functions (debug, warn, etc.)
The "debug" logging function overwrites the "debug" package which breaks
luacov: https://github.com/keplerproject/luacov/issues/55

Change-Id: I9b6025c060733198bfff8ea959444c09d6e08709
Reviewed-on: https://code.wireshark.org/review/29449
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-07 04:02:45 +00:00
Gerald Combs c15ada34b1 Update tools help using a script.
Update docbook/wsug_src/*.txt using tools/update-tools-help.py. This
removes a lot of unwanted behavior that came with updating via a CMake
target.

Change-Id: I0a24f425e9673ef7bd074210d7047654c6755e79
Reviewed-on: https://code.wireshark.org/review/29416
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-05 15:28:43 +00:00
Gerald Combs 8f99b54a77 [Automatic update for 2018-09-02]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I13c6a4293cda00d1e2f3ad823ac6dd1f3f154161
Reviewed-on: https://code.wireshark.org/review/29392
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-02 08:29:06 +00:00
Stig Bjørlykke 813b87f81a docbook: Remove non-existing 'Payload Length'
Remove 'Payload Length' from extcap toolbar control protocol because
this does not exist in the protocol.

Change-Id: I9eea7366d2992a7b7ac769f290c5d7e8e1090ce8
Reviewed-on: https://code.wireshark.org/review/29378
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-08-31 18:37:07 +00:00
Gerald Combs ef01359849 Add support for protocol aliases. Switch BOOTP to DHCP.
Add support for aliasing one protocol name to another and for filtering
using aliased fields. Mark aliased fields as deprecated.

Rename the BOOTP dissector to DHCP and alias "bootp" to "dhcp". This
lets you use both "dhcp.type" and "bootp.type" as display filter fields
without having to duplicate all 500+ DHCP/BOOTP fields.

To do:
- Add checks to proto.c:check_valid_filter_name_or_fail?
- Transition SSL to TLS.
- Rename packet-bootp.c to packet-dhcp.c?

Change-Id: I29977859995e8347d80b8e83f1618db441b10279
Ping-Bug: 14922
Reviewed-on: https://code.wireshark.org/review/29327
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-31 05:25:17 +00:00
Gerald Combs 50b9da7bc2 Add a systemd Journal Export Format parser and dissector.
Add a file parser and dissector that can handle the output of
`journalctl -o export`. From here we can add a systemd journal extcap
and possibly support for the JSON and binary formats.

Change-Id: I01576959b2c347ce7ac9aa57cdb5c119c81d61e9
Reviewed-on: https://code.wireshark.org/review/29311
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-31 05:20:27 +00:00
Jason Zhekov 31c6cf982f WSUG: Fixup Advanced chapter
Change-Id: I7d08378318b4c38babfd18782d9f114748030467
Reviewed-on: https://code.wireshark.org/review/29274
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-08-24 15:53:20 +00:00
Stig Bjørlykke 0c0973196f WSUG: Remove duplicate Clear button description
Change-Id: Id7f468de1c08361ed919d1b3715966c589801d6f
Reviewed-on: https://code.wireshark.org/review/29257
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-08-23 07:53:23 +00:00
Gerald Combs ca355b8905 WSDG: Miscellaneous fixups.
Change occurrences of GIT to Git. Fix a couple of URLs. Other changes.

Change-Id: I9eb69ee16f692c2bf71b62e7a2db4b762d9ab4bf
Reviewed-on: https://code.wireshark.org/review/29237
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-22 04:07:40 +00:00
Gerald Combs 60e87794c4 WSUG: Update the main and filter toolbar sections.
Update the images and text to match the current main and display filter
toolbars.

Change-Id: I4d23a3ece35c3b9186b4fff170f6c391f4d157c9
Reviewed-on: https://code.wireshark.org/review/29234
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-08-21 23:13:11 +00:00
Gerald Combs 2e7cae3fd4 WSUG: Fixup the "Internals" section.
The Internals menu items were moved under the View menu a while back.
Fix an internals dialog title.

Change-Id: I78d61bf4f52bf9eb86cf7ff59fc036b9f7e846f5
Reviewed-on: https://code.wireshark.org/review/29228
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-08-21 22:57:12 +00:00
Gerald Combs 5535b4f307 [Automatic update for 2018-08-12]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I76f688cbe75475ef5282fa09a5b5d58609b12eb3
Reviewed-on: https://code.wireshark.org/review/29105
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-08-12 08:15:41 +00:00
Gerald Combs ef15155bbf [Automatic update for 2018-08-05]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ida5bdebe06ea1dd9dcb9cc2f29601c81c8cf27bd
Reviewed-on: https://code.wireshark.org/review/28968
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-08-05 08:17:16 +00:00
Guy Harris 5ad53f8f10 --extcap-version requires = if it has an argument.
The version argument to --extcap-version is optional, and some versions
of getopt_long() require, for a flag whose argument is optional, that
the argument be supplied as --flag=value, not --flag value.

Change-Id: I5e34132d8bb729b845ac75ff94d6d548c1c35a3d
Reviewed-on: https://code.wireshark.org/review/28864
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-26 20:39:14 +00:00
Gerald Combs 0c0dadb2ee CMake: More update_tools_help fixes.
Use our target name instead of $<TARGET_FILE:...> in a few places. As
Peter pointed out, CMake will do the desired substitution for us. Update
a comment.

Change-Id: I03bf98cc1bf4807213eb89e5e5b1f4e3c08c17be
Reviewed-on: https://code.wireshark.org/review/28836
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-24 17:52:29 +00:00
Gerald Combs f3de00fc36 CMake: Fixup some documentation dependencies.
Change the dependencies of various wsug targets to update_tools_help
instead of the files it generates. Have the nsis_package_prep
and wix_package_prep targets depend on user_guide_chm instead of
update_tools_help. This should make parallel builds of all_guides,
wix_package_prep and possibly other targets more reliable.

Change-Id: I473f0e608aade1ac0053c03bef0942c69c650f65
Reviewed-on: https://code.wireshark.org/review/28838
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-24 17:16:08 +00:00
Peter Wu cfda02a9b5 CMake: fix build when some tools are not built
oss-fuzz disables all targets except for fuzzshark, be sure to check for
tool availability or the cmake step will fail.

Change-Id: Ia873fdc1b548033ac61622f61299b5af7dfb41d9
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9533
Fixes: v2.9.0rc0-1251-gffbd3151b5 ("CMake: Fixup our tools help dependencies.")
Reviewed-on: https://code.wireshark.org/review/28832
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-23 17:56:29 +00:00
Dario Lombardo 8eafe0e41b add DXL dissector.
Change-Id: I5aeccf54d1ab6b9b4098fb3dbf529550c57319e8
Reviewed-on: https://code.wireshark.org/review/28662
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-22 08:04:12 +00:00
Dario Lombardo ac1cb82842 add MsgPack dissector.
Change-Id: Id1ae76da1b4d158227a108f38d1ac83ae08e36f5
Reviewed-on: https://code.wireshark.org/review/28661
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-21 18:45:44 +00:00
Gerald Combs 66935d8baa CMake: Add tools help checks.
Generate help for dumpcap and rawshark only if PCAP_FOUND is true. Note
that we should generate all of the tools help conditionally.

Change-Id: I2145717dee8d8a1ac3d4fd328240f58dbdd07e6c
Reviewed-on: https://code.wireshark.org/review/28785
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-21 00:18:43 +00:00
Gerald Combs ffbd3151b5 CMake: Fixup our tools help dependencies.
Make sure each tools help target is generated by and depends on its
generating executable.

Change-Id: I716c0db23b297e2d2692b72a47259c40aa0c52fa
Reviewed-on: https://code.wireshark.org/review/28780
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-20 22:35:22 +00:00
Moshe Kaplan c78b6cdcef WSUG: Added placeholders for missing documentation
Change-Id: I93b118964b0296bd32627439f8ae3c13169b1d5e
Reviewed-on: https://code.wireshark.org/review/28772
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-20 15:30:44 +00:00
Gerald Combs d83ad81aba AsciiDoctor markup updates.
Separate includes by blank lines as recommended in
https://asciidoctor.org/docs/user-manual/#include-directive.
Separate block attributes as well.

Change-Id: I933917a14eae6d1fe1879372917ab2208755f470
Reviewed-on: https://code.wireshark.org/review/28769
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-20 06:43:24 +00:00
Gerald Combs 61dd06ed9f Lua: Switch from disable_lua to enable_lua.
Deprecate "disable_lua" in favor of "enable_lua". Configuration options
typically use "true" or a similar value to enable features. Using
"disable_lua = false" to enable Lua seems odd.

Change-Id: I224acad0559d409ea0a28b5555d1eb898564328c
Reviewed-on: https://code.wireshark.org/review/28773
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-20 06:42:38 +00:00
Moshe Kaplan 381ea0973f WSUG: Update the Statistics chapter to match current Qt UI
Hide the Compare option, reorder the chapters to match the current Qt
order and move the Wireless menu to a new chapter.

Change-Id: I7f0eeb45f4894f66a9c91d62d7d43db775f469e5
Reviewed-on: https://code.wireshark.org/review/28761
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-19 19:46:39 +00:00
Moshe Kaplan 268883d1a7 WSUG: Update docs for 'Export Object'
Change-Id: Ifab1a0d76d3ba81585d557a8a8b49351cdc6a002
Reviewed-on: https://code.wireshark.org/review/28734
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2018-07-18 09:47:19 +00:00
Roland Knall 74a747fd52 extcap: Correct doc structure
Some issues in the developer doc have been corrected

Change-Id: I0d60e9080ef582dafa12607fb5ea43a8ae5d2d0f
Reviewed-on: https://code.wireshark.org/review/28727
Reviewed-by: Roland Knall <rknall@gmail.com>
2018-07-16 14:15:50 +00:00
Roland Knall 28cb2d4394 extcap: Create docbook documentation
Move the information from README.extcap into docbook.

Change-Id: Ic6504787750d04fe6c66479896cba8d6148d804d
Reviewed-on: https://code.wireshark.org/review/28690
Reviewed-by: Roland Knall <rknall@gmail.com>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-07-13 20:37:10 +00:00
Pascal Quantin fed08d380f E1AP: add dissector based on v15.0.0
Change-Id: Ic939d5f614de9c3b1204c92007b2aa3ee1e45f8f
Reviewed-on: https://code.wireshark.org/review/28649
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-06 13:40:50 +00:00
Dylan Ulis 80c4cf05a4 Developer Guide: Updates
1. Use proto_tree_add_bitmask for the flags example
2. GLib download link was dead
3. Remove old frontend information. I can't find any download for
hethereal, and Packetyzer is so old that it's not useful for any current
developers.

Change-Id: Ifa0a7363fccb95fb2ef315d84fbbcf7414ae6a6d
Reviewed-on: https://code.wireshark.org/review/28632
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-06 07:31:40 +00:00
Peter Wu 8998c91b32 CMake: check Asciidoctor version availability before using it
On Ubuntu trusty, Asciidoctor 1.4 is installed. This does not satisfy
the minimum version requirement (1.5) and should not be used even if the
binary is available.

Change-Id: Iaffd55a5bcb26510b4b59f209768a61c3116d32f
Fixes: v2.5.1rc0-76-g94a0f7c641 ("Switch from AsciiDoc to Asciidoctor.")
Reviewed-on: https://code.wireshark.org/review/28576
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-03 11:57:54 +00:00
Gerald Combs f88256c2f3 [Automatic update for 2018-07-01]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I41a23250a0b818b08475ede50792fd9acc37b2ae
Reviewed-on: https://code.wireshark.org/review/28547
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-01 08:16:52 +00:00
Pascal Quantin cc5701fbb1 XnAP: add dissector based on v15.0.0
Change-Id: If5cbcd4d6c2d0442945e8a46fe836b1dbd17991d
Reviewed-on: https://code.wireshark.org/review/28528
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-29 01:28:42 +00:00
Gerald Combs 16f543a232 IEEE 802.11: Disable FCS validation by default.
Disable FCS/checksum validation by default to match Ethernet, IPv4,
IPv6, TCP, UDP, SCTP, etc.

Change-Id: I289b6a05e73da2b020ee65b3298cb054a29c6d42
Reviewed-on: https://code.wireshark.org/review/28485
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-28 15:32:58 +00:00
Peter Wu ca42331437 tcp: add support for reassembling out-of-order segments
Currently out-of-order segments will result in cutting a stream into
two pieces while the out-of-order segment itself is ignored. For
example, a stream of segments "ABDCE" is interpreted as "AB", "DE" with
"C" ignored. This behavior breaks TLS decryption or prevent application
layer PDUs (such as HTTP requests/responses) from being reconstructed.
To fix this, buffer segments when a gap is detected.

The proposed approach extends the "multi-segment PDU" (MSP) mechanism
which is normally used for linking multiple, sequential TCP segments
into a single PDU. When a gap is detected between segments, it is
assumed that the segments within this gap are out-of-order and will be
received (or retransmitted) later.

The current implementation has a limitation though, if multiple gaps
exist, then the subdissector will only be called when all gaps are
filled (the subdissector will receive segments later than necessary).
For example with "ACEBD", "ABC" can already be processed after "B" is
received (with "E" still buffered), but due to how MSP are extended, it
must receive "D" too before it reassembles "ABCDE". In practice this
could mean that the request/response times between HTTP requests and
responses are slightly off, but at least the stream is correct now.
(These limitations are documented in the User's Guide.)

As the feature fails at least the 802.11 decryption test where packets
are missing (instead of OoO), hide this feature behind a preference.

Tested with captures containing out-of-order TCP segments from the
linked bug reports, comparing the effect of toggling the preference on
the summary output of tshark, the verbose output (-V) and the two-pass
output (-2 or -2V). Captures marked with "ok" just needed "simple"
out-of-order handling. Captures marked with "ok2" additionally required
the reassembly API change to set the correct reassembled length.

This change does "regress" on bug 10289 though when the preference is
enabled as retransmitted single-segment PDUs are now passed to
subdissectors. I added a TODO comment for this unrelated cosmetic issue.

Bug: 3389   # capture 2907 (HTTP) ok
Bug: 4727   # capture 4590 (HTTP) ok
Bug: 9461   # capture 12130 (TLS/HTTP/RPC-over-HTTP +key 12131) ok
Bug: 12006  # capture 14236 (HTTP) ok2; capture 15261 (HTTP) ok
Bug: 13517  # capture 15370 (HTTP) ok; capture 16059 (MQ) ok
Bug: 13754  # capture 15593 (MySQL) ok2
Bug: 14649  # capture 16305 (WebSocket) ok
Change-Id: If3938c5c1c96db8f7f50e39ea779f623ce657d56
Reviewed-on: https://code.wireshark.org/review/27943
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-28 06:10:35 +00:00
Dario Lombardo e6935f9635 docbook: add info about using symbolic links for git hooks.
Change-Id: I4b448c1a12946479638d04819570f5a0dd1227dd
Reviewed-on: https://code.wireshark.org/review/28497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-28 06:09:37 +00:00
jmartin-usna c8518753c8 packet-mdp.c: New dissector for Cisco Meraki Discovery Protocol
Bug: 14912
Change-Id: I2f99931abde331d087a994a22c74cf8d4dd8d53a
Reviewed-on: https://code.wireshark.org/review/28478
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-28 01:33:12 +00:00
jmartin-usna 754cf4b934 packet-updp.c: New dissector for Ubiquiti Discovery Protocol
Bug: 14911
Change-Id: Ie567a85e869707269ea66d4cd73577f926b16232
Reviewed-on: https://code.wireshark.org/review/28467
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-28 01:32:50 +00:00
Gerald Combs af4b6cb9a2 Revert "docbook: remove equivalent case."
We still need the "length == 2" behavior.

This reverts commit 622b17a475.

Change-Id: Id3b7ed9231f3fefeeac5fb910b792139c4844ec8
Reviewed-on: https://code.wireshark.org/review/28484
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-27 17:07:37 +00:00
Dario Lombardo e4e0488da9 docbook: reduce ruby code duplication by introducing utils module.
Change-Id: I7e436db3cb86f5ebd0f5827c6da630303bc3f538
Reviewed-on: https://code.wireshark.org/review/28400
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-27 17:01:18 +00:00
Dario Lombardo 622b17a475 docbook: remove equivalent case.
The output for this case is achieved by the following one.

Change-Id: I585aba39ebb67d65a8f5159217ea8a85ad13e49c
Reviewed-on: https://code.wireshark.org/review/28421
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-27 17:00:57 +00:00
Dario Lombardo 52bcc40d5e docbook: rewrite some ruby code according to RuboCop suggestions.
Change-Id: I2d1ea982c1622dbc29f927ee168b552b46e39faa
Reviewed-on: https://code.wireshark.org/review/28399
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-27 16:59:14 +00:00
Gerald Combs 57c108570f Release note updates.
Change-Id: Idbcea0e67e53665ea7b9e5e10962af3e4fd34eda
Reviewed-on: https://code.wireshark.org/review/28483
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-27 16:48:32 +00:00
Gerald Combs c68a1f049e WSDG: Fix a couple of links.
Change-Id: I6f96ac45cd3cd4f992c11dea0f0aff6df2a2bff8
Reviewed-on: https://code.wireshark.org/review/28469
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-26 22:19:57 +00:00
Dario Lombardo 29f38cf782 docbook: replace ASCIIDOCTOR_EXECUTABLE with ASCIIDOCTOR_PDF_EXECUTABLE.
This fixes the guides compilation error:

ninja: error: '../docbook/developer-guide.pdf', needed by 'docbook/CMakeFiles/developer_guide_pdf', missing and no known rule to make it

Change-Id: I58c45da34e60b950f5560716372377962a84e42e
Reviewed-on: https://code.wireshark.org/review/28393
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-25 16:38:38 +00:00
Gerald Combs 8a62ff570c WSUG: Update the Follow Stream documentation.
Update the Follow Stream documentation and screenshot.

Change-Id: I55e5e552d23b9676b23959ac07a480e0c7809ac4
Reviewed-on: https://code.wireshark.org/review/28366
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-21 18:38:55 +00:00
Ka-Shu Wong 9190cd1f89 Add dissector for Exablaze timestamping trailers
Change-Id: I2953b7441b5f55f653e93e066f1c23fdcb5be7c5
Reviewed-on: https://code.wireshark.org/review/28265
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21 13:29:47 +00:00
Jaap Keuter ebf4ce3149 WSUG: Document the use of CMake when building on Unix
Change-Id: Ie1781144856ed544736f092abcafa7c08f74c4b0
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/28347
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21 03:31:02 +00:00
Jaap Keuter d818ca2cc0 User Guide: change MATE ref from Wiki to own document
Change-Id: Icc4db66ccc5685a7466475ee02da4ad3e008b484
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/28339
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-19 21:10:19 +00:00
Jaap Keuter 304e03eb75 Documentation: Add version to Guides
Previously, before the AsciiDoc conversion, the Users' and
Developers' Guide used to carry version information on the
title page. This seems to have been dropped, for reasons
unknown to me.

At least AsciiDoctor allows to add a subtitle, so the
wireshark-version attribute can be expanded into it.

Change-Id: Ib0a90393aff1a323b7026c49e2aa11f5115b3ec7
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/28330
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-19 05:04:40 +00:00
AndersBroman 20971b17e1 NGAP: New dissector for 3GPP TS 38.413
Change-Id: I87019b6f7b8f617128e7636c63bb3f2a49694ee8
Reviewed-on: https://code.wireshark.org/review/28086
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-08 12:54:17 +00:00
Gilles Dufour 1c7b101b35 New protocol support for Lawo EmberPlus which is Glow embedded in S101
Bug: 14718
Change-Id: I7ad6503634eb6bc98cee20ef069db3156a6a1e1e
Reviewed-on: https://code.wireshark.org/review/27247
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-08 06:30:56 +00:00
Gerald Combs f8092f96b3 Qt: Move wireshark-qt.cpp back to ui/qt/main.cpp.
The Qt UI's main module started out as ui/qt/main.cpp but was moved to
the top-level directory in order to appease Autotools. We don't need to
do that any more, so move it back.

Change-Id: Ic5bc0ed5b754e36cc2b9e682f2ca097781233dfd
Reviewed-on: https://code.wireshark.org/review/28090
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-08 03:50:22 +00:00
Dario Lombardo 100d8ec970 add dissector for distributed ruby protocol.
Documentation: http://ruby-doc.org/stdlib-2.5.1/libdoc/drb/rdoc/index.html

Depends on If5d3bd2eaf261b4bc7a7df4ac15098503081dd9f.

Bug: 14731
Change-Id: I5ae9ffd3b017db0b8adc483ed093582508a3e225
Reviewed-on: https://code.wireshark.org/review/27765
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-07 08:20:48 +00:00
Dario Lombardo 500102c265 add file dissector for ruby marshal objects.
Documentation: https://ruby-doc.org/core-2.5.0/Marshal.html

Bug: 14730
Change-Id: If5d3bd2eaf261b4bc7a7df4ac15098503081dd9f
Reviewed-on: https://code.wireshark.org/review/27764
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-07 08:20:14 +00:00
Gerald Combs fc4de96fe7 Docs: Update the Configuration Profiles section of the User's Guide.
Fix an image width.

Change-Id: Icdc5a7d46c4e50346137bc271e97f3448ad4e2d2
Reviewed-on: https://code.wireshark.org/review/28046
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-05 23:28:03 +00:00
Gerald Combs 5138f6b8c3 WSUG: Update the profiles dialog image.
Change-Id: I4f96cc09d4ec6618087af29bd5119d6307dd3ccf
Reviewed-on: https://code.wireshark.org/review/28043
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-05 20:02:55 +00:00
Joerg Mayer c23f352064 Spirent Test Center Signature decoding support including FibreChannel
Change-Id: I11d5e13b041a747045d90e93f1c8e8d572a6ef67
Reviewed-on: https://code.wireshark.org/review/28001
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-06-05 15:26:00 +00:00
Gerald Combs f6679c75f7 Docs: Add a live preview section to the docbook README.
Change-Id: I92462073a65f1673a9b5e036ec72ade90558eb1c
Reviewed-on: https://code.wireshark.org/review/27935
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-31 18:24:44 +00:00
Gerald Combs 241eeb6333 Docs: Fix a couple of Asciidoctor warnings.
Change-Id: I2ad46c19f056edc65be9c6d2c5909c1f3c9d10d4
Reviewed-on: https://code.wireshark.org/review/27934
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-31 18:24:36 +00:00
Alexis La Goutte 1a1f424346 Add PROXY(v2) protocol
Bug: 14506
Change-Id: I399f3a94583985a5d036ac26438e0c5bc5a70c85
Reviewed-on: https://code.wireshark.org/review/10626
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-30 08:18:09 +00:00
Jaap Keuter 1787a1f84c Add the MATE documentation chapter to the User Guide
With MATE being an integral part of Wireshark for a long time now and its
documentation being part of the Wiki for a while it is time to move it
into the Wireshark Users Guide.

All credits go to Luis Ontanon for creating MATE and the Wiki pages,
the various contributors to those pages and especially Pavel Sindelka for
the creation of the graphics.

This change merely incorporates the contents of the Wiki pages into an
asciidoc file for processing into documentation output. It is in no way a
claim to knowledge of or deep insight in the workings of MATE on my part.

Change-Id: Id9c60fd3ba4a52aafb988370ea7d658907970ccd
Reviewed-on: https://code.wireshark.org/review/27894
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-29 14:37:38 +00:00
Gerald Combs af24816568 [Automatic update for 2018-05-27]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I6603cc4dd62ff1db23efa4374437ce9ebf7a81c8
Reviewed-on: https://code.wireshark.org/review/27840
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-27 08:16:34 +00:00
Gerald Combs 0dcd8cd1a2 Asciidoctor: Remove underscores from macro names.
AsciiDoc allows dashes in macro names but not underscores. Current
versions of AsciiDoctor allow the inverse. Remove underscores to allow
for easier copying and pasting.

Remove asciidoc.conf while we're here. It's no longer used.

Change-Id: I32d8a4ec695b9e17a80ac720ee9faf62dbb362d3
Reviewed-on: https://code.wireshark.org/review/27787
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-24 20:00:56 +00:00
Tobias Rasmusson 6000b8d872 DoIP: ISO 13400-2 Diagnostic communication over Internet Protocol
DoIP is a vehicle bus protocol. It is carried by TCP or UDP and may include an UDS payload.

Change-Id: I1459c51fd710da8e2aaff0056bbf3f6e42c1b25e
Reviewed-on: https://code.wireshark.org/review/27448
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-24 13:57:02 +00:00
Gerald Combs 73678453bb WSUG: Fix an attribute.
Change-Id: I48a81ada4b9be0f5af9c81532845e3fea23eed21
Reviewed-on: https://code.wireshark.org/review/27581
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-16 15:39:00 +00:00
Gerald Combs 9ec5b2b0fe Qt: Implement the capture info dialog.
Add back the capture info dialog. Draw sparklines for each protocol.
Update the User's Guide.

Bug: 12004
Change-Id: I45be8a0df4752255831a8b139ee84bb34d675ba9
Reviewed-on: https://code.wireshark.org/review/27565
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16 04:26:36 +00:00
Guy Harris 30ae3847e0 Mention how to get Ninja, and speak more of UNIX and UNIX-like platforms.
And put hyphens in "out-of-tree" and "in-tree".

Change-Id: I55c54a1334f490f948310139741fecf27203a359
Reviewed-on: https://code.wireshark.org/review/27550
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-15 06:54:08 +00:00
Guy Harris 81bfa3f7b8 Don't speak of "UNIX".
macOS is a UNIX(R) and FreeBSD isn't a UNIX(R), but we mentioned macOS
along with UNIX but didn't mention FreeBSD along with UNIX.

Instead, just speak of "UN*Xes" and give Linux, macOS, and *BSD as
examples.  Feel free to add Solaris, AIX, or HP-UX if you want, assuming
you can build Wireshark on them.

Change-Id: I85be3861fa0bc603b93d077a2d9d587d43cb6e7e
Reviewed-on: https://code.wireshark.org/review/27549
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-15 06:38:56 +00:00
Dirk Eibach e0002b0427 extcap: Support for DisplayPort AUX channel monitors
Support for the generic netlink DisplayPort AUX channel monitor kernel driver.

Change-Id: Iab445229ecef082968355f604993292f5f2d8d69
Reviewed-on: https://code.wireshark.org/review/27313
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Roland Knall <rknall@gmail.com>
2018-05-14 10:44:37 +00:00
Jaap Keuter af394ddf72 Add missing docbook graphics files to the CMake file.
Several graphics files are not listed in the symbol that defines
the dependancy for document building. Adding these files to the
WSUG_GRPAHICS symbol makes the list consistent.

Bug: 14676
Change-Id: I3016a1994473f90df460d726773c8470dbedd3bc
Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-on: https://code.wireshark.org/review/27471
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-12 21:59:18 +00:00
Gerald Combs 17190a1ed2 List some removed features in the release notes.
Require Qt 5.2 in CMakeLists.txt. Remove some old Qt 4 checks.

Change-Id: I06814b3776b488d55a0ce1a26aaada43fb5e096c
Reviewed-on: https://code.wireshark.org/review/27446
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-11 16:11:14 +00:00
Dario Lombardo ec5af355d3 docbook: add "-y" to all windows choco commands.
This speeds up the copy/paste step-by-step sequence.

Change-Id: Ib2e3ee54c8c86b7357260ecaab5d129ef296a9e9
Reviewed-on: https://code.wireshark.org/review/27309
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-04 10:18:33 +00:00
Gerald Combs ef4080bc3a WSDG: Stop recommending Cygwin.
Note in the quick setup and tools documentation that we no longer
require or recommend Cygwin.

Change-Id: Ie0eb92c5817ae1d786136035adf8fa3988c8b98d
Reviewed-on: https://code.wireshark.org/review/27244
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-03 04:05:16 +00:00
Gerald Combs ed38488211 Test: Add unittests.
Note that these require the "test-programs" target.

Change-Id: I1bea381eaa48504fcd76f88e1c6f2edece0a78a2
Reviewed-on: https://code.wireshark.org/review/27231
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-30 22:38:37 +00:00
Dylan Ulis c63be89ab8 WSDG: Remove ENABLE_CHM_GUIDES
ENABLE_CHM_GUIDES is no longer in CMakeOptions.txt

Change-Id: I217ac89f12c95e66591465e3230c19968dcc0bde
Reviewed-on: https://code.wireshark.org/review/27209
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-04-30 13:13:19 +00:00
Michail Koreshkov b5fc9857c7 GSM-R protocol dissector
Dissector for GSM-R protocol. Specification ETSI TS 102 610.
Trace example in https://wiki.wireshark.org/SampleCaptures [[attachment:gsm-r.uus1.pcap]]

Change-Id: I7496bfa141d75b3460f7c3bdbb791e24d4810231
Reviewed-on: https://code.wireshark.org/review/26929
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-28 06:18:34 +00:00
Gerald Combs e6d129bf23 Test: Add fileformats and I/O.
Add the fileformats and I/O suites. Move some more common code to
subprocesstest.py and add a diffOutput method.

Change-Id: I2ec34e46539022bdce78520645fdca6dfc1a8c1a
Reviewed-on: https://code.wireshark.org/review/27183
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-27 19:52:04 +00:00
Gerald Combs 0ad4239249 Start porting our test scripts to Python. Add ctest support.
Create Python versions of our various test shell scripts. Add CMake
tests for each suite. Tests can now be run directly via test.py, via the
"test" target, or via ctest, e.g.

  ctest --verbose --jobs 3

Add a testing chapter to the Developer's Guide.

Add a way to disable ctest in dpkg-buildpackage.

Suites completed:
- capture
- clopts
- decryption
- dissection

Remaining suites:
- fileformats
- io
- mergecap
- nameres
- text2pcap
- unittests
- wslua

Change-Id: I8936e05edefc76a86b6a7a5da302e7461bbdda0f
Reviewed-on: https://code.wireshark.org/review/27134
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-26 19:27:19 +00:00
Tadeusz Struk 30629ce166 tpm20: Add TPM2.0 dissector
This adds support for the TPM 2.0 "protocol" as defined
by the Trusted Computing Group (TCG) specification.
The specification can be found here:
https://trustedcomputinggroup.org/tpm-library-specification/

The specification defines the format of the all TPM requests
and responses that this dissector supports.

A sample capture file that can be used for testing this
can be found in the https://wiki.wireshark.org/SampleCaptures
It is called policy-authorizeNV.pcap.

Change-Id: I557cb779f3adc5313e6d3498bbfeb56fdd308fbf
Reviewed-on: https://code.wireshark.org/review/26866
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-26 08:27:56 +00:00
Peter Wu e39a30b691 Document "len" and "count" in wireshark-filter(4) and WSUG
Add missing section on display filter functions to WSUG and make it
consistent with the wireshark-filter(4) manual. "count" was added in
Wireshark 1.12 (bug 9480). "len" was added in Wireshark 1.6.x.

"size" (added in 1.8.x) is not documented since it works like "len",
except that it is not limited to strings and byte arrays. I think that
"len" should be extended to other types while removing "size".

Change-Id: I2c8e2b4a11f007de7852a797bed971af86840b47
Reviewed-on: https://code.wireshark.org/review/27146
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-25 19:57:15 +00:00
Guy Harris 067a67bd27 Remove some references to autotools from developer documentation.
Change-Id: I4c95e56e067eed98d269812225256462dfa46273
Reviewed-on: https://code.wireshark.org/review/27140
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-25 04:40:04 +00:00
Uli Heilmeier 8930b986aa WSUG: Add SS7 code point resolution
Bug: 14617
Change-Id: I0af61d1ad7a80796db057e25f94869b98dfdacf1
Reviewed-on: https://code.wireshark.org/review/27128
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-25 04:13:47 +00:00
Harald Welte 265e81ca3c Dissector for the Osmocom GSUP Protocol
The Osmocom GSUP protocol is a light-weight alternative to the
classic GSM MAP protocol. It operates between (MSC|SGSN) and HLR.

Change-Id: I954c7e332dce3a8855f7f4ace0b878f66da6f02e
Reviewed-on: https://code.wireshark.org/review/25477
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-21 22:46:50 +00:00
Dario Lombardo 8740ac8d4c release-notes: add autotools removal.
Change-Id: I5abc0bb8b9fef4b358c53cf4a30cb0503273f727
Reviewed-on: https://code.wireshark.org/review/26997
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-18 10:50:55 +00:00
Dario Lombardo 511c2e166a tshark: add -G elastic-mapping report.
This option generates an ElasticSearch mapping file as described here:
https://www.elastic.co/blog/analyzing-network-packets-with-wireshark-elasticsearch-and-kibana

It leverages the Glib-json library.

Change-Id: Iff25f991e87d3da07bf06654e353fb785799dde9
Reviewed-on: https://code.wireshark.org/review/26848
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-04-18 08:57:39 +00:00
Peter Wu 699ee5dc52 dfilter: make spaces around ".." optional in display filter
For numeric values such as port numbers, "4430..4434" looks more
natural than "4430 .. 4434", so support that.

To make this possible, the display filter syntax needs to be restricted.
Assume that neither field names nor values can contain "..". The display
filter `data contains ..` will now be considered a syntax error and must
be written as `data contains ".."` instead. More generally, all values
that contain ".." must be quoted.

Other than the ".." restriction, the scanner deliberately accepts more
characters that can potentially form invalid input. This is to prevent
accidentally splitting input in multiple tokens.  For example, "9.2." in
"frame.time_delta in {9.2.}" is currently parsed as one token and then
rejected because it cannot be parsed as time. If the scanner was made
stricter, it could treat it as two tokens (floats), "9." and "2." which
has different meaning for the set membership operator.

An unhandled edge case is "1....2" which is parsed as "1 .. ..  2" but
could have been parsed as "1. .. .2" instead. A float with trailing dots
followed by ".." seems sufficiently weird, so rejection is fine.

Ping-Bug: 14180
Change-Id: Ibad8e851b49346c9d470f09d5d6a54defa21bcb9
Reviewed-on: https://code.wireshark.org/review/26960
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-18 03:47:31 +00:00
Peter Wu 1ff82572ca dfilter: add range support to set membership operator ("f in {x .. y}")
Allow "tcp.srcport in {1662 1663 1664}" to be abbreviated to
"tcp.srcport in {1662 .. 1664}". The range operator is supported for any
field value which supports the "<=" and "=>" operators and thus works
for integers, IP addresses, etc.

The naive mapping "tcp.srcport >= 1662 and tcp.srcport <= 1664" is not
used because it does not have the intended effect with fields that have
multiple occurrences (e.g. tcp.port). Each condition could be satisfied
by an other value. Therefore a new DVFM instruction (ANY_IN_RANGE) is
added to test the range condition against each individual field value.

Bug: 14180
Change-Id: I53c2d0f9bc9d4f0ffaabde9a83442122965c95f7
Reviewed-on: https://code.wireshark.org/review/26945
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-18 03:47:02 +00:00
Dario Lombardo 4a156da068 Remove autotools build system.
It has been replaced by cmake.

Change-Id: I83a5eddb8645dbbf6bca9f026066d2e995d8e87a
Reviewed-on: https://code.wireshark.org/review/26969
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-18 03:46:17 +00:00
Gerald Combs ad84eec866 Switch the Doxygen API reference build to CMake.
Switch to a single Doyxgen configuration which was generated using a
recent version of Doxygen and customized to suit our needs. Add
wsar_html and wsar_html_zip targets to CMake. Update some Doxygen markup
and documentation as needed.

Change-Id: Ic8a424b292c35a26f74ae0b53322265683e56e69
Reviewed-on: https://code.wireshark.org/review/26976
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-17 03:46:05 +00:00
Gerald Combs 08c2344458 Remove some references to PortAudio.
Change-Id: Icfe9516ff814db5362aa345e6f527551dcb13935
Reviewed-on: https://code.wireshark.org/review/26946
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-15 05:33:12 +00:00
Martin Mathieson 2cb93e2121 NR (5G) PDCP
Tested with some hand-generated PDUs.

Change-Id: Ic603d0ca4578d23121e438ac2458be34e63492d2
Reviewed-on: https://code.wireshark.org/review/26755
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2018-04-10 14:48:40 +00:00
Peter Wu 2173309920 Revert "Docs: Reduce our TOC depth."
The Lua documentation has class names at its third level which is quite useful
to discover its documentation.

This reverts commit f5cd52c0fb.

Change-Id: I2a2e82041ac46a1a9974727bbb1d5cbf6855a878
Reviewed-on: https://code.wireshark.org/review/26814
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-09 23:56:36 +00:00
Gerald Combs 974a15bf74 Docs: Remove a bunch of GTK+ references.
Change-Id: Icab98813d0b81a7337562e9857429d4bb98dc44c
Reviewed-on: https://code.wireshark.org/review/26817
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-09 05:02:12 +00:00
Gerald Combs 0cb3176ab7 Remove some references to Qt4.
Change-Id: I50f5abafb8adf18a5407427f7feb260301df45cc
Reviewed-on: https://code.wireshark.org/review/26771
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-06 03:11:52 +00:00
Gerald Combs 82bfb259d3 Fix a typo.
Change-Id: I922f06a3d7df7fde695a6b917fb03af894f78bff
Reviewed-on: https://code.wireshark.org/review/26718
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-03 00:41:16 +00:00
Gerald Combs adb55d8ca4 2.5 → 2.9.
Change-Id: I9a6cd7a510f8ba5310a9cf8a2818903d4c03253f
Reviewed-on: https://code.wireshark.org/review/26712
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-02 19:30:15 +00:00
Moshe Kaplan e2ec760d5e Extend 'HTTP Referer statistics' to sequence HTTP Redirects
This patch adds support for sequencing HTTP Redirects. This enables
tracking of HTTP-based redirects, which may not have a Referer header.
As such, this patch also renames 'HTTP Referer statistics' to
'HTTP Request Sequences' to better reflect the more generic
functionality.

Note that this does not fully support RFC 3986. An external library like
uriparser.github.io may be a better option for efficient, full relative
HTTP URL resolution.

A Sample PCAP to test functionality is available here:
https://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=http_redirects.pcapng

A sample PCAP to demonstrate usefulness is available here:
https://www.malware-traffic-analysis.net/2015/08/31/page2.html
(examine request to hxxp://lk2gaflsgh.jgy658snfyfnvh.com/service.php)

Change-Id: I9edd1a1de86228b0dcb1df9f6f30e24379684321
Reviewed-on: https://code.wireshark.org/review/26679
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-03-29 15:33:53 +00:00
Uli Heilmeier f414ec5754 WSUG: Fix Display Filter doc
Bug: 14572
Change-Id: If556f6902b21f2f40c812210499c036185366a2c
Reviewed-on: https://code.wireshark.org/review/26660
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-27 08:16:28 +00:00
Gerald Combs c8adf2538b Docs: Fix some cross references.
Update some cross references which were renamed in 1cd92c4961. Fixup
some capitalization while we're here.

Change-Id: Iae3227839cd34a52662a4b973c0f87e7e5a765cc
Reviewed-on: https://code.wireshark.org/review/26655
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-26 16:38:10 +00:00
Gerald Combs 1cd92c4961 CMake: Add an rpm-package target.
Copy the current wireshark.spec.in and update it for use with CMake.
Remove the Qt4, GTK+2, and GTK+3 options. Add Ninja and mmdbresolve
options.

The rpm-package target builds a tarball using git-export-release.sh and
therefore must be run from a git checkout. The RPM _prefix macro is set
to CMAKE_INSTALL_PREFIX, so you'll probably want to run

cmake -DCMAKE_INSTALL_PREFIX=/usr ...

Change-Id: Ib014494d8858a0059126404cd91528ded5d8a9f6
Reviewed-on: https://code.wireshark.org/review/26579
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-26 14:00:35 +00:00
Gerald Combs acaff5ad2d Qt: TCP Stream Graphs dialog updates.
Add duplicate ACK ticks to Statistics → TCP Stream Graphs → Time
Sequence (tcptrace), which I missed when porting from GTK+. Add zero
window crosses while we're here.

Switch TCPStreamDialog to a subclass of GeometryStateDialog.

Add a slot and URL for the Help button and a stub entry in the User's
Guide.

Bug: 12009
Change-Id: Idf2ddb9eb33d924d65998285b5cffc234156497c
Reviewed-on: https://code.wireshark.org/review/26592
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-26 04:25:23 +00:00
Peter Wu e804376612 docs: improve Lua Listener example
Ensure the dialog is populated when the dialog is opened after a capture
file has already been loaded.

Change-Id: I9ba1b4a1eb7a8b21ce7dac4a820eadf10daa9845
Reviewed-on: https://code.wireshark.org/review/26601
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-23 19:41:21 +00:00
Nikhil AP c55d15783c Add Arista Vendor Specific Protocol (Ethertype) dissector
Bug: 14550
Change-Id: I08d54825eb054255167eb28469b7fb854507e4ed
Reviewed-on: https://code.wireshark.org/review/26492
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-22 20:15:12 +00:00
Dario Lombardo 6cff9f0720 dns: add filters for retransmitted and unsolicited packets.
Change-Id: I1af293a9dc53869858dafc5921792aa3fbbfe766
Reviewed-on: https://code.wireshark.org/review/26536
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-22 06:18:21 +00:00
Dario Lombardo 9a864b6e64 dns: add service-level stats.
They include:
- request-response time
- unsolicited response count
- retransmissions count

Change-Id: I01398bf1a88a23fb7850715f256b178c66d933a4
Reviewed-on: https://code.wireshark.org/review/26535
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-22 06:17:53 +00:00
Gerald Combs 535dd5cb6a NSIS: Link to Npcap.
Mention Npcap on the WinPcap installer page and add a link to it.

Update some other text and tell developers to use NSIS 3.0 while we're
here.

Change-Id: I64728f014f518439ba4a38eda7a283274d40fcdc
Reviewed-on: https://code.wireshark.org/review/26515
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 05:05:54 +00:00
Gerald Combs 2d15d7d51b WSDG: More CMake updates.
Switch a build example to CMake + Ninja. Add syntax highlighting
annotations.

Change-Id: I5ee0af548f44ed5be6f6e8367f5167dc499df017
Reviewed-on: https://code.wireshark.org/review/26514
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17 05:04:51 +00:00
Pascal Quantin 6280c153bb F1AP: initial dissector submission based on v15.0.0
Change-Id: Icf5c128119afa86efddb87e744f7aecb8bf71e09
Reviewed-on: https://code.wireshark.org/review/26506
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-16 19:10:25 +00:00
Gerald Combs 475daf767f More CMake documentation updates.
Change-Id: Ia568e0f46e7a38007bb9b8ea3d6c92233921cc46
Reviewed-on: https://code.wireshark.org/review/26504
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-16 17:35:47 +00:00
Gerald Combs 507d8211e9 CSS: Add a margin.
Change-Id: Ib6da6455f7af8a7cfd9dae3ef6a8511a100a184b
Reviewed-on: https://code.wireshark.org/review/26503
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-16 17:08:51 +00:00
Gerald Combs a58dac70b5 CSS: Fix a font.
Change-Id: I90b24efa863240986b30cc7ab2692c3883838798
Reviewed-on: https://code.wireshark.org/review/26499
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-16 15:36:48 +00:00