osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
40922 commits 26 branches 0 tags 795 MiB
Commit graph

18394 commits

Author SHA1 Message Date
Ronnie Sahlberg
0882a858c4 SMB2: Fix, the flag is called PERSISTENT_HANDLES, not LARGE_MTU 
From Michael Adam <obnox@samba.org>


svn path=/trunk/; revision=42766
 2012-05-22 05:45:30 +00:00
Ronnie Sahlberg
b5b00d5654 SMB2: Add support for SMB2_GLOBAL_CAP_ENCRYPTION flag 
From Michael Adam <obnox@samba.org>


svn path=/trunk/; revision=42765
 2012-05-22 05:44:07 +00:00
pascal
a65518fe55 Fix indentation 
svn path=/trunk/; revision=42760
 2012-05-21 21:49:11 +00:00
pascal
6a1470ffc9 From gyanesh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7267 : 
Add dissector function for SPB link metric sub tlv (type 29)

svn path=/trunk/; revision=42759
 2012-05-21 20:51:22 +00:00
pascal
0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs) 
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
 2012-05-21 19:27:38 +00:00
Bill Meier
bc55ee0616 Fix "Function call argument is an uninitialized value" issue found by scan-build. 
(It seems to me that this issue would rarely, if ever, actually occur).

Also:
- Use val_to_str_const() as appropriate;
- Localize some variables;
- Remove unneeded initializers;
- Do some parenthesizing;
- Use a consistent formatting style;
- Do whitespace cleanup.

svn path=/trunk/; revision=42754
 2012-05-21 18:25:29 +00:00
Bill Meier
b2b8fae93c Init a pointer to prevent a (not actually valid) scan-build "Function call argument is an uninitialized value" msg 
Also:
 - #if 0 out some unused hf[] entries;
 - use val_to_str_const() in a few places;
 - remove some unneeded initializers;
 - do col_set_str()/col_clear() before referencing tvb;
 - reformat hf[] entries;
 - Fix whitespace (4-space tabs, etc).

svn path=/trunk/; revision=42746
 2012-05-21 15:06:24 +00:00
Bill Meier
78f3be74bf Additional cleanup: 
- use #if 0/#endif to comment out code(instead of /* ...*/
- remove unused #define
- replace col_clear()/col_add() by col_set()

svn path=/trunk/; revision=42745
 2012-05-21 14:25:27 +00:00
Bill Meier
6718bfd047 From Evan Huus: Unused Prefs registration; 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7273

From me: whitespace cleanup;

svn path=/trunk/; revision=42744
 2012-05-21 14:02:40 +00:00
Jakub Zawadzki
1d510f0616 Improve Gadu-Gadu dissector (part III) 
svn path=/trunk/; revision=42742
 2012-05-21 13:07:33 +00:00
pascal
d6381b4123 From Evan Huus via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7271 : 
Remove useless null check

svn path=/trunk/; revision=42741
 2012-05-21 09:37:58 +00:00
pascal
f09a30ea93 Add packet-sync.c to epan\CMakeLists.txt 
svn path=/trunk/; revision=42740
 2012-05-21 09:18:39 +00:00
Anders Broman
26d431148c From David Wei: 
fix for Higher bitrates than 16 Mbps flag.

svn path=/trunk/; revision=42739
 2012-05-21 08:21:26 +00:00
Anders Broman
fec821f303 From Evan Huus: 
Fix Three memory leaks and a bad if-condition, as caught by CppCheck.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7272

svn path=/trunk/; revision=42738
 2012-05-21 07:42:09 +00:00
Anders Broman
35dd3b052e Use new_register_dissector. 
svn path=/trunk/; revision=42737
 2012-05-21 07:34:20 +00:00
Anders Broman
36cd403381 From Michael Mann: 
Check for enabled XML dissecto.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6625
xmpp decoder crashes when xml is disabled

svn path=/trunk/; revision=42736
 2012-05-21 07:28:13 +00:00
Anders Broman
4684cb30f4 From David Wei: 
New dissector for MBMS synchronisation protocol.

svn path=/trunk/; revision=42735
 2012-05-21 07:11:36 +00:00
Bill Meier
7d3f69262d Whitespace cleanup; 
svn path=/trunk/; revision=42734
 2012-05-21 02:20:53 +00:00
Bill Meier
e3ea682270 General cleanup: 
- 4-space tabs, trailing whitespace, etc
- use a consistent formatting style
- ...

svn path=/trunk/; revision=42733
 2012-05-21 02:13:49 +00:00
Bill Meier
ca4a51873e Prevent (what seems to me to be) a possible null pointer dereference. 
svn path=/trunk/; revision=42732
 2012-05-21 01:00:12 +00:00
Jörg Mayer
d40cea2e7b Two cases where gcc has problems to detect that a specific specific 
variable may not be used uninitialized.

svn path=/trunk/; revision=42731
 2012-05-21 00:23:13 +00:00
Bill Meier
0b6c88942b Fix 'unused parameter' warning. 
svn path=/trunk/; revision=42730
 2012-05-21 00:20:09 +00:00
Anders Broman
c5d3f8c2ba Set up conversations for more channel types 
svn path=/trunk/; revision=42729
 2012-05-20 21:24:18 +00:00
pascal
254fcdfe19 Upgrade NAS dissector to Release 10 (v10.6.1) 
svn path=/trunk/; revision=42728
 2012-05-20 20:56:42 +00:00
Jakub Zawadzki
42ec0ca701 Revert r35131 fix bug #5738 
g_unichar_isprint() is for *wide characters*.
For UTF-8 multibyte characters we could 
use g_utf8_validate() and g_utf8_next_char(),
but IMHO format_text_* should be ASCII-only.

We rather need to store encoding of FT_STRING[Z]
and in proto_item_fill_label() call appropiate
function.
For ENC_ASCII use format_text(),
for unicode (ENC_UTF*, ENC_UCS*) use format_text_utf(),
etc..

svn path=/trunk/; revision=42727
 2012-05-20 18:32:44 +00:00
Gerald Combs
feeed92f95 [Automatic manuf, services and enterprise-numbers update for 2012-05-20] 
svn path=/trunk/; revision=42724
 2012-05-20 14:03:32 +00:00
Michael Tüxen
2250389193 Make the compiler happy. 
svn path=/trunk/; revision=42723
 2012-05-20 10:57:12 +00:00
pascal
774748914f Upgrade NAS EPS dissector to Release 10 (10.6.1) 
svn path=/trunk/; revision=42722
 2012-05-20 09:50:34 +00:00
pascal
acc2a3706b Fix RVALS() macro usage 
svn path=/trunk/; revision=42720
 2012-05-19 19:05:36 +00:00
Bill Meier
12ba85a2a4 Rework proto_registrar_dump_protocols() to prevent a Clang scan-build "de-reference of a null poiunter" warning 
(In practice, bug would not actually occur).

svn path=/trunk/; revision=42717
 2012-05-19 16:07:50 +00:00
pascal
cf0d560849 Use col_append_sep_str instead of col_append_str 
svn path=/trunk/; revision=42716
 2012-05-19 16:06:12 +00:00
Bill Meier
91e5923458 Fix some "warning: Value stored to '...' is never read" clang scan-build warnings. 
Also; Do some whitespace cleanup in a few cases.

svn path=/trunk/; revision=42715
 2012-05-19 14:20:55 +00:00
pascal
7bbbb88068 From Thomas Loockx via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7269 : 
Add BGP MDT-SAFI dissection (RFC6037)

svn path=/trunk/; revision=42713
 2012-05-19 12:32:10 +00:00
pascal
20793cc947 From gyanesh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7262 : 
Digest details display issue in SPB Digest subtlv (ISIS hello pdu)

svn path=/trunk/; revision=42712
 2012-05-19 10:35:43 +00:00
Jakub Zawadzki
aaa9b34c86 Improve Gadu-Gadu dissector and fix some comments. 
svn path=/trunk/; revision=42711
 2012-05-19 07:57:45 +00:00
Anders Broman
8499bf8b8e Fix the DCH data collection for conversation setup 
svn path=/trunk/; revision=42710
 2012-05-19 06:20:05 +00:00
Jakub Zawadzki
3bb88a972b Improve Gadu-Gadu dissector. 
svn path=/trunk/; revision=42709
 2012-05-18 17:43:48 +00:00
Jeff Morriss
5c0dfb9e8e There's no need to include Custom.common here; it gets pulled in by Makefile.common 
svn path=/trunk/; revision=42708
 2012-05-18 17:19:50 +00:00
Jeff Morriss
af87b31852 Allow custom dissectors in automake too. 
svn path=/trunk/; revision=42707
 2012-05-18 16:20:36 +00:00
pascal
b3dec16072 Tabs -> spaces 
svn path=/trunk/; revision=42691
 2012-05-17 21:24:48 +00:00
pascal
8f789f7ee2 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7255 : 
dissector for generic ISO 7816 messages (atr and apdus)

svn path=/trunk/; revision=42689
 2012-05-17 21:11:22 +00:00
Bill Meier
b315490d01 Fix an "unused variable" warning.... 
svn path=/trunk/; revision=42686
 2012-05-17 20:41:46 +00:00
Bill Meier
e332a8de56 Fix the fix .... 
svn path=/trunk/; revision=42685
 2012-05-17 20:36:23 +00:00
Bill Meier
47828c3170 Silence a "may be used uninitialiuzed" warning..... 
svn path=/trunk/; revision=42684
 2012-05-17 20:30:59 +00:00
Bill Meier
bab856a504 General cleanup including as appropriate: 
- Remove unneeded #include files (string.h, addr_resolv.h);
 - Remove unneeded 'if(!initialized){...}' in proto_reg_handoff();
 - Reformat hf[] entries;
 - Remove unneeded variable initializations;
 - "localize" some variables;
 - Whitespace/indentation/long lines/formatting
(in one case: re-order code slightly to not do col_set_str() & etc until
              after initial "frame acceptance testing" by dissector.

svn path=/trunk/; revision=42683
 2012-05-17 20:13:22 +00:00
Jakub Zawadzki
b4624651e9 Fix copy&paste: hf variable name in hfi->abbrev 
svn path=/trunk/; revision=42682
 2012-05-17 19:41:19 +00:00
Michael Tüxen
24fa3fb59a No leading whitespaces in the INFO column. 
svn path=/trunk/; revision=42679
 2012-05-17 15:31:15 +00:00
Bill Meier
6fbb09d50b General Cleanup including: 
- Remove unneeded #include <stdlib.h>;
- Remove "README.developer" comments;
- Reformat hf[] entries;
- Remove unneeded variable initialization;
- "localize" some variables;
- Whitespace/indentation/long lines/formatting
- (In one case) proto_tree_add_uint returns a proto_item* (not a proto_tree *);

svn path=/trunk/; revision=42678
 2012-05-17 14:35:11 +00:00
Michael Tüxen
6526ea3751 Add support for specifying an SCTP port number. 
svn path=/trunk/; revision=42677
 2012-05-17 14:34:09 +00:00
Jakub Zawadzki
91690d8a28 Fix string buffer overflow (bug #7029) 
g_strlcpy() always return the size of strlen(src), so in case of truncation it could happen that offset_r > size or offset_e > size.
Fix it by adding new function protoo_strlcpy() which returns how many bytes was copied to dest buffer.


svn path=/trunk/; revision=42676
 2012-05-17 10:18:53 +00:00
pascal
b607964f1f Fix spice.common_cap_byte1 filter I changed by mistake in r42664 
svn path=/trunk/; revision=42675
 2012-05-17 08:22:34 +00:00
Gerald Combs
9e3487a953 Use BASE_DEC for spice.common_cap_byte1. (Hopefully that's correct.) 
svn path=/trunk/; revision=42668
 2012-05-16 22:05:47 +00:00
pascal
4a1de290f8 From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7264 : 
Enhance the Spice dissector to deal with sized data streams and playback data
From me: fix a few hf entries

svn path=/trunk/; revision=42664
 2012-05-16 21:20:16 +00:00
pascal
f400e647b8 From Pontus Andersson via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7259 : 
GTP Extension headers are dissected incorrectly

svn path=/trunk/; revision=42663
 2012-05-16 20:59:56 +00:00
Chris Maynard
ff667657e8 Largely, whitespace and formatting changes. Added modelines to match. 
Other misc. changes:
-> Delete useless, duplicate assignment of offset to 0 in dissect_vsnp().
-> Change short seq # display filter so it's not the same as the seq # filter.
-> pppoe.dump.gz looks to be malformed, so remove unnecessary "remlen" code in
   dissect_cp() and let the packets be displayed as malformed since they are.
-> Remove if (check_col()) checks.
-> Fix copy-and-paste of filter name for ipcp.opt.max_header.

svn path=/trunk/; revision=42661
 2012-05-16 19:55:49 +00:00
Jeff Morriss
ef756b397c Fix the *test_install targets so they put the test tools in the right directory (wireshark-gtk2 is one dir up from here). 
svn path=/trunk/; revision=42659
 2012-05-16 16:36:32 +00:00
Gerald Combs
bdb614e264 Fix a bunch of uninitialized variables found by Coverity Scan. CIDs 
702403, 702404, 702405, 702406, 702407, 702408, 702409, 702410, 702411,
and 702412.

svn path=/trunk/; revision=42658
 2012-05-16 16:29:12 +00:00
Anders Broman
46e202503a se_allocate and store per packet data. 
svn path=/trunk/; revision=42657
 2012-05-16 14:56:34 +00:00
pascal
e5f3a74723 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7186 : 
Link together access-request and access-challenge messages

svn path=/trunk/; revision=42656
 2012-05-16 13:24:10 +00:00
Anders Broman
3e2ea7b812 Handle DCH information in RadioLinkReconfigurationPrepareFDD 
svn path=/trunk/; revision=42655
 2012-05-16 13:05:27 +00:00
Anders Broman
dc8224653e Only do HS-DSCH Control frames for now as something is broken. 
svn path=/trunk/; revision=42653
 2012-05-16 08:35:53 +00:00
Anders Broman
e65a6548bf From David Wei: 
Corrected info column for piggybacked GTPv2 messages.

svn path=/trunk/; revision=42652
 2012-05-16 07:47:15 +00:00
Anders Broman
7918984efc Bug fixes and add HSDSCH 
svn path=/trunk/; revision=42650
 2012-05-16 05:58:30 +00:00
Anders Broman
ce6e224b5b Bug fixes and add HSDSCH 
svn path=/trunk/; revision=42649
 2012-05-16 05:57:41 +00:00
Jeff Morriss
6a4b07bb55 Store a copy of the default preferences (e_prefs; the dissectors' default 
preference values have been stored for a while now).

If a preference has not been changed from its default value, comment it out
when writing the preferences file.  That way you won't get warnings about
some new "gui.*" (or other non-dissector) preference when switching between
SVN Wireshark and some older version.


Also fix some ommissions in copy_prefs() (preferences that were not copied).


(All these non-dissector preferences seem to require an awful lot of code;
it would be very nice to have a non-dissector preference registration API that
the GUI and core could use so we could eliminate a lot of this code.)

svn path=/trunk/; revision=42648
 2012-05-16 03:06:08 +00:00
Bill Meier
2ed4baea4f all: 
Merge .h files into .c files since .h files unused elsewhere;
     Do whitespace, indentation & formatting cleanup.
packet-acn.c:
     Fix 2 minor bugs wherein subtree not displayed in packet-details
     because tree variable used in proto_tree_add_text() always NULL.

svn path=/trunk/; revision=42647
 2012-05-16 01:41:03 +00:00
Jeff Morriss
2071275974 Most dissectors don't register their preferences in subtrees, so don't allocate the submodules pe_tree until it's needed. 
svn path=/trunk/; revision=42646
 2012-05-16 01:20:55 +00:00
Chris Maynard
bf0f73f6be Call dissect_osinlcp_opt_type_len() to dissect the OSINLCP option type and length, unintentionally omitted. I guess this is what happens without enough packet captures to test against and a compiler that doesn't warn enough about unused functions. Anyone know how to get MSVC compilers to complain about such things like the other compilers do? 
svn path=/trunk/; revision=42644
 2012-05-15 23:44:23 +00:00
Jeff Morriss
6f2b6538eb ifdef out dissect_osinlcp_opt_type_len since it's not used--should it be? 
svn path=/trunk/; revision=42643
 2012-05-15 23:39:06 +00:00
Gerald Combs
63a5845486 Remove a bonus semicolon (CID 702424). 
svn path=/trunk/; revision=42641
 2012-05-15 22:19:51 +00:00
Bill Meier
a4e0dee6db Merge packet-cimd.h into packet-cimd.c (packet-cimd.h not used elsewhere); 
Remove unneeded #includes;
Reformat hf[] entries;
Do minor code rework & whitespace cleanup.

svn path=/trunk/; revision=42640
 2012-05-15 22:07:00 +00:00
Chris Maynard
4d7b302a6c PPP OSINLCP improvements. Note that the protocol name has been changed from OSICP to OSINLCP, which matches RFC1377 and IANA terminology from http://www.iana.org/assignments/ppp-numbers 
svn path=/trunk/; revision=42639
 2012-05-15 22:02:57 +00:00
Gerald Combs
21b3256918 Assign some variables that scan-build was complaining about. 
svn path=/trunk/; revision=42638
 2012-05-15 21:56:02 +00:00
pascal
101e304d4e Spaces -> tabs 
svn path=/trunk/; revision=42637
 2012-05-15 21:18:39 +00:00
pascal
96e21ee3f7 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7261 : 
Add some sanity checks when dissecting SQ_TYPE_NULL

svn path=/trunk/; revision=42636
 2012-05-15 21:16:06 +00:00
Chris Maynard
cf5eae2806 PPP IPCP improvements. 
svn path=/trunk/; revision=42635
 2012-05-15 21:01:52 +00:00
Bill Meier
b869cb0bc5 Remove unneeded includes (ctype.h, stdio.h); 
In one case, define our own size for a string buffer
 (instead of using a magic constant 'BUFSIZ');
In a few cases: do some whitespace, indentation & reformatting cleanup.

svn path=/trunk/; revision=42634
 2012-05-15 20:57:21 +00:00
pascal
d5aa739fd0 From Alexander Lüders & Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7254 : 
Enhancements for FPSpotlightRPC AFP function

svn path=/trunk/; revision=42633
 2012-05-15 19:25:33 +00:00
Bill Meier
d53320919a Remove unneeded #includes (stdlib, stdio, ctypes, time); 
In a few cases: do some whitespace, indentation cleanup & reformatting.

svn path=/trunk/; revision=42632
 2012-05-15 19:23:35 +00:00
Gerald Combs
3e4b3756fd From Evan Huus via bug 6805: 
Look before we loop

Check the value of various key count parameters against the size of their
parent tag *before* we start looping on them.

Stick an expert error on the field and bound the loop at a sane point if the
count is bogus.

svn path=/trunk/; revision=42631
 2012-05-15 19:13:10 +00:00
Gerald Combs
691ea690c8 Fix a few scan-build warnings along with some whitespace. 
svn path=/trunk/; revision=42630
 2012-05-15 19:11:08 +00:00
Anders Broman
ba39b783d8 Remove more unfinished code. 
svn path=/trunk/; revision=42629
 2012-05-15 15:46:15 +00:00
Anders Broman
e134cca032 Use converstaion info to dissect FP DCH flows. Revert unfinished code. 
svn path=/trunk/; revision=42628
 2012-05-15 15:00:52 +00:00
Guy Harris
1c2a67f348 Make the encoding argument uniformly guint rather than gint. 
Put the code that's currently common to the ENC_ASCII and ENC_UTF_8
cases in tvb_get_ephemeral_string_enc() into tvb_get_ephemeral_string(),
and call tvb_get_ephemeral_string() in those cases.  Skip the
tvb_ensure_bytes_exist() and ensure_contiguous() calls in the ENC_UTF_16
and ENC_UCS_2 cases, as they're unnecessary there.

Update the comment for tvb_get_ephemeral_string_enc().

Make tvb_get_ephemeral_stringz_enc() handle the encodings that
tvb_get_ephemeral_string_enc() does.

svn path=/trunk/; revision=42627
 2012-05-15 05:42:58 +00:00
Guy Harris
1ec0629c1b Make the "idl-light"-to-dissector generator handle hex (and octal) 
values in enums (and, while we're at it, add some error checking for
valid values).  (The regenerated dissectors don't differ usefully from
the fixed dissectors, so we don't check them in.)

svn path=/trunk/; revision=42626
 2012-05-14 23:19:13 +00:00
Guy Harris
953a5c3fff Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Change the "idl-light"-to-dissector generator to use ENC_NA for
structures and ENC_LITTLE_ENDIAN for bitmasks (are they always
little-endian, or should they check the data representation?).  Also
change it to properly set the display format for FT_ABSOLUTE_TIME fields
(it now specifies whether to show local time, UTC, or UTC with a
1-origin day-of-year).

Change one routine in the template for the DRSUAPI dissector to use
ENC_UTF_16|ENC_LITTLE_ENDIAN with proto_tree_add_item() (the field it
dissects is known to be a string, so there's no need to check its data
type).

Regenerate the BUDB, BUTC, and DRSUAPI dissectors.  (The generated BUTC
dissector handles pointers differently - either the old dissector was
wrong, or the generator is wrong, or the IDL for the protocol is wrong,
or the difference doesn't actually affect dissection.)

The generator doesn't currently handle hex values in enums correctly;
manually fix packet-dcerpc-drsuapi.h.

svn path=/trunk/; revision=42625
 2012-05-14 23:05:28 +00:00
pascal
05cfd1c391 From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7256 : 
Fix subquery_count loop variable updating

svn path=/trunk/; revision=42624
 2012-05-14 21:46:02 +00:00
Jakub Zawadzki
0f1a21aaa9 tvb_unicode_strsize() returns number of bytes, NOT number of UCS-2 characters. 
svn path=/trunk/; revision=42622
 2012-05-14 06:32:16 +00:00
Guy Harris
14b616c35d Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Add new "add_packet_field" method to the TreeItem class, taking a
protocol field (*not* a protocol), TvbRange, and encoding value as
arguments.

Add the ENC_ values to init.lua.  Make them all hex #defines so
make-init-lua.pl can easily extract them.

Export tvb_unicode_strsize() for use by Lua (and elsewhere as desired). 
Note that it handles UTF-16 and UTF-8, and fix the comment to note that
its count of hexadectets *does* include the null terminator (that's what
the code does).

svn path=/trunk/; revision=42621
 2012-05-14 00:49:05 +00:00
pascal
723b213c89 From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7246 : 
Patch adding dissection of time data

svn path=/trunk/; revision=42620
 2012-05-13 21:02:42 +00:00
pascal
2845705252 Revert 42618 (in 3GPP vocabulary multirat means multi radio access technology) 
svn path=/trunk/; revision=42619
 2012-05-13 19:03:48 +00:00
Chris Maynard
7cd17ae0b3 More typos: Multirat -> Multirate. 
svn path=/trunk/; revision=42618
 2012-05-13 18:01:35 +00:00
Chris Maynard
21863ad163 Convert tabs to spaces. Fix some typos. 
svn path=/trunk/; revision=42617
 2012-05-13 17:55:06 +00:00
Anders Broman
82ba410214 Tabs spelling 
svn path=/trunk/; revision=42616
 2012-05-13 16:34:53 +00:00
Bill Meier
f9a08c84d5 General cleanup: 
- whitespace;
- formatting (including long lines & hf[] entries).

svn path=/trunk/; revision=42614
 2012-05-13 14:53:26 +00:00
Gerald Combs
6c1dd6f0de [Automatic manuf, services and enterprise-numbers update for 2012-05-13] 
svn path=/trunk/; revision=42612
 2012-05-13 14:03:29 +00:00
Anders Broman
6d757a2083 Renove redundant code 
svn path=/trunk/; revision=42611
 2012-05-13 14:00:10 +00:00
Anders Broman
09c5089ebc Fix de_rr_cell_opt_sacch decoding the DTX cell options wrongly, by using proto_tree_add_split_bits_item_ret_val https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7253 
svn path=/trunk/; revision=42610
 2012-05-13 13:58:10 +00:00
Guy Harris
f354e31304 A routine that processes a struct_XXX() won't necessarily use its 
encoding argument; mark it as (potentially) unused.

svn path=/trunk/; revision=42609
 2012-05-12 23:00:15 +00:00
Guy Harris
13095234ad "byte_order" is an encoding value, so it should be guint. 
svn path=/trunk/; revision=42608
 2012-05-12 22:56:46 +00:00
Guy Harris
268f5c9f51 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Replaced the "little_endian" Boolean value with an "byte_order" value
containing the setting of the byte-order ENC_ bit. 

svn path=/trunk/; revision=42607
 2012-05-12 22:25:29 +00:00
Bill Meier
f2cd5350f6 Fix a compile error 
svn path=/trunk/; revision=42606
 2012-05-12 22:19:02 +00:00
Bill Meier
b8712813cc General cleanup: 
- Fix two minor bugs which resulted in missing entries in packet details pane;
- Remove packet-rdp.h: It's not used elsewhere;
- Define 3 global fcns as static: they're only referenced within packet-rdp.c;;
- Localize some variable definitions & remove uneeded variable initializations;
- ...
- Fix whitespace and indentation.


svn path=/trunk/; revision=42605
 2012-05-12 22:14:02 +00:00
Guy Harris
e4b688d5dc Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Replaced the "little_endian" Boolean value with an "byte_order" value
containing the setting of the byte-order ENC_ bit. 

svn path=/trunk/; revision=42604
 2012-05-12 20:27:35 +00:00
Chris Maynard
82fa509542 Fix display filter prefix from "ntpctrl." to "ntp.ctrl." Part of a patch submitted by Michael Mann in bug 2794, but for some reason the patch specified the filter prefix as "nap.ctrl.", which I don't think is right. 
svn path=/trunk/; revision=42603
 2012-05-12 20:26:42 +00:00
Guy Harris
3896fea6c0 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Updated tools/process-x11-xcb.pl to support different encoding values
for different fields.  Replaced the "little_endian" Boolean value with a
"byte_order" value containing the setting of the byte-order ENC_ bit. 
Regenerated X11 fields from current x.org git.

svn path=/trunk/; revision=42601
 2012-05-12 20:07:08 +00:00
Chris Maynard
da5ea5a8dd From Evan Huus via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7239 
Make inputint and outputint fields UINT32s instead of UINT16s.

svn path=/trunk/; revision=42599
 2012-05-12 17:55:09 +00:00
Alexis La Goutte
466988126d From Jim Young via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7252 
Add wlan.ra field value to wlan.addr

The (hidden) field wlan.addr==xx:xx:xx:xx:xx:xx currently matches wlan.da,
wlan.bssid, wlan.sa and wlan.da fields but not wlan.ra field.

svn path=/trunk/; revision=42597
 2012-05-12 13:12:01 +00:00
Guy Harris
bd42162bfe hf_x11_keycodes is an FT_NONE; use ENC_NA with it. 
svn path=/trunk/; revision=42595
 2012-05-12 01:59:00 +00:00
Guy Harris
675416c0de string16_with_buffer_preallocated() takes a byte-order gboolean as its 
argument.

svn path=/trunk/; revision=42594
 2012-05-12 01:54:49 +00:00
Guy Harris
f1020435f8 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42593
 2012-05-12 00:43:46 +00:00
Guy Harris
7a87d7b6a3 Add ENC_UTF_16 and ENC_UCS_2. Note that UTF-16 and UCS-2 are not the 
same, and that the routines to get "Unicode" strings are really doing
UCS-2 (and not doing anything about code values that aren't valid in
UCS-2 strings).

Have tvb_get_ephemeral_string_enc() separate cases for ASCII and UTF-8,
even though they're *currently* treated the same.

For FT_UINT_STRING, treat an encoding value of TRUE as meaning
"little-endian ASCII"; pass all other encodings through to
tvb_get_ephemeral_string_enc().

svn path=/trunk/; revision=42592
 2012-05-11 23:55:54 +00:00
Chris Maynard
bb524c6b64 Despite the OSX-10.5-x86 buildbot insisting that they are, neither 'flags' nor 'fh_tree' were used uninitialized, but make a change to shut it up. 
svn path=/trunk/; revision=42591
 2012-05-11 20:24:27 +00:00
Chris Maynard
7748862a65 Further LCP improvements: 
-> Support RFC 2153's Vendor Specific decode
-> Make more fields filterable by converting some add_text()'s to add_xyz().
-> Don't wrap call_dissector_only() within an if(tree){} block.

svn path=/trunk/; revision=42581
 2012-05-11 18:01:51 +00:00
Guy Harris
f1b11f62f8 proto_registrar_get_ftype() returns an FT_ value; make its return type 
"enum ftenum" to reflect that, and fix the "switch doesn't handle XXX"
warnings that provokes.

svn path=/trunk/; revision=42579
 2012-05-11 17:29:56 +00:00
Guy Harris
f42de82580 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_bitmask() calls.

svn path=/trunk/; revision=42577
 2012-05-11 16:38:08 +00:00
Anders Broman
dfadac5d9a Make it possible to add "dirty" custom dissectors. 
svn path=/trunk/; revision=42576
 2012-05-11 12:14:29 +00:00
pascal
633a538cdb Commit forgotten file in revision 42573 
svn path=/trunk/; revision=42575
 2012-05-11 10:22:32 +00:00
pascal
079f737508 Remove useless '+0' in proto_tree_add_* function calls 
svn path=/trunk/; revision=42574
 2012-05-11 09:50:28 +00:00
pascal
0264b67ed7 From Niels de Vos: 
Add dissection of AUTH_GLUSTERFS as used in GlusterFS-3.3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7244

svn path=/trunk/; revision=42573
 2012-05-11 09:44:55 +00:00
pascal
f982541723 From Niels de Vos: 
Add a helper function to dissect AUTH_UNIX groups
Fix hf_rpc_auth_lk_owner entry
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7244

svn path=/trunk/; revision=42572
 2012-05-11 09:38:49 +00:00
pascal
b42423a8dc From Frank Lahm: 
In FPSpotlightRPC packets, check for elements with 0 childs (denoted by L in TLV is sizeof(TLV tag))
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7245

svn path=/trunk/; revision=42571
 2012-05-11 09:03:22 +00:00
Anders Broman
1fe00a4c44 Make it possible to dissect private IE's 
svn path=/trunk/; revision=42570
 2012-05-11 08:42:23 +00:00
Guy Harris
6a92b2a472 Get rid of non-ASCII character. 
svn path=/trunk/; revision=42569
 2012-05-11 08:29:40 +00:00
Guy Harris
25917db46e Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_bitmask() calls.

svn path=/trunk/; revision=42568
 2012-05-11 08:10:42 +00:00
Guy Harris
32ec3275bd Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_bits_item() calls.

svn path=/trunk/; revision=42567
 2012-05-11 08:05:35 +00:00
Guy Harris
fde0260bee Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42566
 2012-05-11 07:49:27 +00:00
Guy Harris
d46a8a2506 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42565
 2012-05-11 07:44:43 +00:00
Guy Harris
77ae45d3b6 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Fix a field that was presumably intended to be of type FT_IPv6.

svn path=/trunk/; revision=42564
 2012-05-11 07:38:59 +00:00
Guy Harris
a01546ad7e Fix a commented-out proto_tree_add_uint() call that presumably was 
intended to be a proto_tree_add_item() call.

svn path=/trunk/; revision=42563
 2012-05-11 07:36:41 +00:00
Guy Harris
957ef532c1 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42562
 2012-05-11 07:34:47 +00:00
Guy Harris
6c0db47ef8 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42561
 2012-05-11 07:32:30 +00:00
Guy Harris
d9c07f2458 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42560
 2012-05-11 07:10:43 +00:00
Anders Broman
3cf5f7412a Correct wrong value in h264_level_bitrate_values 
svn path=/trunk/; revision=42559
 2012-05-11 05:21:22 +00:00
Guy Harris
9b179f0233 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.  (We actually need to support additional
encodings with ENC_ values and use them.)

svn path=/trunk/; revision=42558
 2012-05-11 03:38:04 +00:00
Guy Harris
18dc512738 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42557
 2012-05-11 03:32:56 +00:00
Guy Harris
7b4894e3ed Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42556
 2012-05-11 03:28:26 +00:00
Guy Harris
ab124ec901 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.  (dissect_smb2_olb_buffer() dissects an
offset-length-buffer the contents of which are a structured blob of
bytes, so the top-level item should be an FT_NONE, hence ENC_NA.)

svn path=/trunk/; revision=42555
 2012-05-11 03:24:32 +00:00
Jeff Morriss
d8c246d53d Fix CID 700200: the Israeli variant case can't happen in 
dissect_application_isup() so comment it out for now.

svn path=/trunk/; revision=42554
 2012-05-10 18:33:24 +00:00
Chris Maynard
f90809827c Trivial typo: if -> it 
svn path=/trunk/; revision=42552
 2012-05-10 16:09:10 +00:00
Martin Mathieson
270d299643 Add parenthesis to clarify intent. 
From Visual Studio Code Analyzer:
c:\buildbot\wireshark\trunk-vs-eca\vscodeanalysis\build\epan\dissectors\packet-iuup.c(322)
: warning C6336: Arithmetic operator has precedence over question
operator, use parentheses to clarify intent
c:\buildbot\wireshark\trunk-vs-eca\vscodeanalysis\build\epan\dissectors\packet-iuup.c(342)
: warning C6336: Arithmetic operator has precedence over question
operator, use parentheses to clarify intent
c:\buildbot\wireshark\trunk-vs-eca\vscodeanalysis\build\epan\dissectors\packet-iuup.c(401)
: warning C6336: Arithmetic operator has precedence over question
operator, use parentheses to clarify intent

svn path=/trunk/; revision=42550
 2012-05-10 15:57:57 +00:00
Martin Mathieson
a9463e89b3 Avoid needlessly shadowing a variable. 
svn path=/trunk/; revision=42549
 2012-05-10 15:49:25 +00:00
Martin Mathieson
eaf2e8a0bc Formatting of { } wasn't consistent, so settle on having { at the end of 
the line rather than on a  line on its own.

svn path=/trunk/; revision=42548
 2012-05-10 14:34:21 +00:00
Chris Maynard
5e58b385da AFH Channel Map should be an FT_BYTES, not an FT_UINT_BYTES. 
Ref: Core Version 2.1 + EDR, section 7.5.5 available from:
     https://www.bluetooth.org/Technical/Specifications/adopted.htm

svn path=/trunk/; revision=42547
 2012-05-10 13:19:55 +00:00
Guy Harris
7162bcf833 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42546
 2012-05-10 06:34:37 +00:00
Guy Harris
fc44346935 Fix a proto_tree_add_ipv4() call that was presumably intended to be a 
proto_tree_add_item() call.

svn path=/trunk/; revision=42545
 2012-05-10 06:13:56 +00:00
Guy Harris
b4f63743cb Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42544
 2012-05-10 05:57:12 +00:00
Guy Harris
c63721eec1 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42543
 2012-05-10 05:55:02 +00:00
Guy Harris
8c71eacce0 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42542
 2012-05-10 05:52:22 +00:00
Anders Broman
36b2157d6a Use the defines in IE value_string 
svn path=/trunk/; revision=42541
 2012-05-10 05:44:25 +00:00
Chris Maynard
a1c2c23a9c PPP code, identifier, length and magic number are now filterable. Don't call call_dissector() from within an if(tree){} block. Mark dissect_lcp_linkqualmon_opt()'s pinfo arg as unused. 
svn path=/trunk/; revision=42540
 2012-05-10 02:49:57 +00:00
Guy Harris
d6bc0d246c Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42539
 2012-05-10 02:36:50 +00:00
Guy Harris
4a9c5461fc Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42538
 2012-05-10 02:32:11 +00:00
Guy Harris
eab1625599 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42537
 2012-05-10 02:28:01 +00:00
Guy Harris
2298eeb691 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

This involves marking string fields as special.

XXX - we need ENC_UTF_16 so that we can make the Unicode strings just be
FT_STRING and add them with ENC_UTF_16|ENC_LITTLE_ENDIAN.

svn path=/trunk/; revision=42536
 2012-05-10 02:20:37 +00:00
Guy Harris
b50b6a5b0b Don't create alternative fields for the encrypted value of a string 
attribute unless the attribute is encrypted.

svn path=/trunk/; revision=42535
 2012-05-10 01:54:33 +00:00
Chris Maynard
359961a2ef PPP_OSICP -> PPP_OSINLCP 
svn path=/trunk/; revision=42534
 2012-05-10 01:34:11 +00:00
Chris Maynard
0b44e6f99b Mention that dissect_ip_tcp_options() is used by more protocols than just IP and TCP. 
svn path=/trunk/; revision=42533
 2012-05-10 01:26:53 +00:00
Chris Maynard
91b151278b PPP LCP improvements, mostly with LCP options. checkAPIs.pl and checkfiltername.pl are happy, but checkhf.pl complains; however, all complaints are false positives - maybe a Perl expert is able to modify checkhf.pl to avoid reporting them? Lots of changes so fuzz testing was performed, but no captures exist w/all the LCP options, so some are likely still untested. Compiled on Windows using MSVC2010EE, which is notorious for not reporting problems that other compilers do. Hopefully there are no warnings, but we'll see what the buildbots say ... 
svn path=/trunk/; revision=42532
 2012-05-10 01:21:37 +00:00
Guy Harris
27286517f7 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Also, fix a call for IPv4 addresses to use ENC_BIG_ENDIAN (yes, we do
support ENC_LITTLE_ENDIAN for IPv4 addresses - at least one protocol
apparently puts IPv4 addresses out byte-swapped!).

svn path=/trunk/; revision=42531
 2012-05-10 01:08:50 +00:00
Guy Harris
47cd41dbda Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

For RADIUS, this means that, for string attributes that are encrypted,
we need separate fields for the encrypted and decrypted versions, the
former of which is an FT_BYTES (as its value is *NOT* a text string!)
and the latter of which is FT_STRING.

While we're at it:

	make some routines static that don't need to be exported;

	"encrypt=" takes a value between 1 and 3 - get the value from
	the dictionary and store it, and only do User-Password-style
	decryption for encrypt=1 attributes;

	rename "hf64" to "hf_alt", as it's a general "alternate field",
	used for 64-bit values for integral attributess, IPv6 addresses
	for "combo IP" attributes, and encrypted values for string
	fields;

	give the URL for the FreeRADIUS dictionary file format man page.

svn path=/trunk/; revision=42530
 2012-05-10 01:01:18 +00:00
Guy Harris
843f041270 Get rid of one remaining Booleans-as-encoding-argument in a 
proto_tree_add_item() call.

svn path=/trunk/; revision=42527
 2012-05-09 22:14:03 +00:00
Guy Harris
e0e5f597d4 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42526
 2012-05-09 22:10:31 +00:00
Guy Harris
b280cdfbdc Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42524
 2012-05-09 22:05:21 +00:00
Bill Meier
75f6458053 From Martin Kaiser: 
"attached is a simple fix for CID281213. Although the bug can't crash wireshark,
 dissect_si_string() is not really fit for handling negative string lengths (and
 doesn't need to)."

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7243

svn path=/trunk/; revision=42523
 2012-05-09 20:39:21 +00:00
Anders Broman
582c102f16 Setup more flows, flow info is incomplete. 
svn path=/trunk/; revision=42521
 2012-05-09 14:24:46 +00:00
Anders Broman
9141a4fbcb Setup CPCH flows. 
svn path=/trunk/; revision=42520
 2012-05-09 12:54:58 +00:00
Martin Mathieson
9cd2bdf381 Remove an accidental ; following a test. 
svn path=/trunk/; revision=42519
 2012-05-09 12:07:14 +00:00
Anders Broman
41ae73c57d Collect and use more information in converstion data to be able to dissect FP flows. 
svn path=/trunk/; revision=42518
 2012-05-09 12:01:16 +00:00
pascal
bdeea8408e Fix last parameter for tvb_get_guid() call 
svn path=/trunk/; revision=42517
 2012-05-08 20:25:55 +00:00
pascal
19a766b152 Remove unused hf entries 
svn path=/trunk/; revision=42516
 2012-05-08 20:20:12 +00:00
pascal
0c4569d941 From Frank Lahm: 
Display guids in FPSpotlightRPC AFP packets
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7237

svn path=/trunk/; revision=42515
 2012-05-08 19:38:58 +00:00
Alexis La Goutte
7e0c1e3a5a Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=42514
 2012-05-08 17:42:54 +00:00
Alexis La Goutte
3c47f9e73b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=42513
 2012-05-08 17:42:36 +00:00
Alexis La Goutte
c16cd8f997 Enhance MPLS Dissector 
* use proto_tree_add_item
 * start Header field by hf_mpls...


svn path=/trunk/; revision=42512
 2012-05-08 17:41:23 +00:00
Alexis La Goutte
f5a1787a06 Enhance Unknown IPv6 Extension Header 
svn path=/trunk/; revision=42511
 2012-05-08 17:34:46 +00:00
Alexis La Goutte
3fa9ea87ce Add RFC6608 Subcodes for BGP Finite State Machine Error 
Update other notify subcodes (draft-ietf-idr-cease-subcode-02 => RFC4484)...

svn path=/trunk/; revision=42510
 2012-05-08 17:31:05 +00:00
Bill Meier
5d1d282213 General cleanup including: 
- remove unneeded #include <stdlib.h>
- rework some "function-like" macros to use
  'do {...} while (0)' construct;
- reformat hf[] entries;
- indentation/whitespace/long-lines/parentheses.

svn path=/trunk/; revision=42509
 2012-05-08 15:16:55 +00:00
Anders Broman
b438c7415f From Frank Lahm: 
Fixes for FPSpotlightRPC AFP dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7235

svn path=/trunk/; revision=42508
 2012-05-08 14:24:13 +00:00
Anders Broman
572fcbe463 From Jim Wright: 
Add decoding of CTEB to packet-dtn.c

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7234

svn path=/trunk/; revision=42507
 2012-05-08 14:17:16 +00:00
Guy Harris
bd95016694 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42506
 2012-05-08 07:01:04 +00:00
Guy Harris
74c0b35425 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42505
 2012-05-08 06:43:15 +00:00
Guy Harris
6e60188def Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42504
 2012-05-08 06:41:10 +00:00
Guy Harris
7ff367e4ec Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Fix a field type - FT_UINT_BYTES means "byte array preceded by a
length, with the length field included", not "byte array, not including
any length field, even if it happens to be preceded by a length field".

svn path=/trunk/; revision=42503
 2012-05-08 06:35:50 +00:00
Anders Broman
c406e86cc1 Pretify info_col for mor MSG:s 
svn path=/trunk/; revision=42502
 2012-05-08 05:35:30 +00:00
Guy Harris
3067d31c24 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.  (The only non-integral/non-boolean fields
aren't fetched as array elements.)

svn path=/trunk/; revision=42501
 2012-05-08 02:41:15 +00:00
Guy Harris
913d8951d1 Fix a proto_tree_add_ipv4() call that was probably intended to be a 
proto_tree_add_item() call.

svn path=/trunk/; revision=42500
 2012-05-08 02:05:16 +00:00
Guy Harris
77c75e4e43 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.  (There's no spec for the protocol that I
could find, just an implementation, and it's not clear whether the
description field is ASCII or UTF-8 or something else.)

svn path=/trunk/; revision=42499
 2012-05-08 02:02:26 +00:00
Guy Harris
fad3e5f467 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42498
 2012-05-08 00:37:37 +00:00
Guy Harris
cbd26a417b Fix a proto_tree_add_uint() call that appears to have been intended to 
be a proto_tree_add_item() call.

svn path=/trunk/; revision=42497
 2012-05-08 00:34:12 +00:00
Guy Harris
8822dffb82 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42496
 2012-05-08 00:31:56 +00:00
Guy Harris
ff546a0151 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42495
 2012-05-08 00:29:22 +00:00
Guy Harris
7b67c96c9a Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Clean up indentation.

svn path=/trunk/; revision=42494
 2012-05-08 00:24:07 +00:00
Guy Harris
1fca484224 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Update the RFC number for LDAP.

svn path=/trunk/; revision=42493
 2012-05-08 00:15:53 +00:00
Guy Harris
551d8aaacf Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42492
 2012-05-07 23:55:46 +00:00
Guy Harris
5d4e982e93 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42491
 2012-05-07 23:40:44 +00:00
Guy Harris
0ac5ef9e91 Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

Update the introductory comment to give the RFC for IAX2. 
(tools.ietf.org rules.)

svn path=/trunk/; revision=42490
 2012-05-07 23:37:38 +00:00
Guy Harris
0851bd312c Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42489
 2012-05-07 22:52:33 +00:00
Guy Harris
c51cadd00e Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42488
 2012-05-07 22:46:14 +00:00
Bill Meier
c055ca8c7e General minor cleanup including: 
- remove unneeded #includes;
- use val_to_str_const() as appropriate;
- reformat hf[] entries;
- reformat long lines;
- use #if 0/#endif to coment out code instead of /* ... */;
- remove boilerplate comments;
- whitespace & indentation


svn path=/trunk/; revision=42487
 2012-05-07 22:11:34 +00:00